alievmirza commented on code in PR #6278:
URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2215957653
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -4061,6 +4055,23 @@ private void logConfigurationChange(final Configuration
newConfiguration) {
}
}
+ private long getLastCommittedIndex() {
Review Comment:
Confusing method name, it seems to me that this method is valid only on
init, but name says nothing about that.
Somebody could use this method wrongly, thinking that it will return last
committed index at any moment
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -4061,6 +4055,23 @@ private void logConfigurationChange(final Configuration
newConfiguration) {
}
}
+ private long getLastCommittedIndex() {
Review Comment:
I also would be glad if you change serverId to getNodeId in a single left
place, where we do not provide group Id, this place is
`org.apache.ignite.raft.jraft.core.NodeImpl#initMetaStorage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
