Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#issuecomment-2650053997 @sashapolo I've improved readability of test names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on code in PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#discussion_r1950381748 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java: ## @@ -425,6 +426,7 @@ private static Str

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1950371840 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -404,6 +420,99 @@ void tes

Re: [PR] IGNITE-24359 Adjust ScanCloseReplicaRequest to be TableAware one [ignite-3]

2025-02-10 Thread via GitHub
sk0x50 commented on code in PR #5198: URL: https://github.com/apache/ignite-3/pull/5198#discussion_r1950364328 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/PartitionScanPublisher.java: ## @@ -85,6 +86,11 @@ public void subscribe(Subscriber

Re: [PR] IGNITE-24359 Adjust ScanCloseReplicaRequest to be TableAware one [ignite-3]

2025-02-10 Thread via GitHub
sk0x50 commented on code in PR #5198: URL: https://github.com/apache/ignite-3/pull/5198#discussion_r1950361920 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java: ## @@ -768,7 +777,76 @@ public voi

Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on code in PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#discussion_r1950360440 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java: ## @@ -425,6 +426,7 @@ private static Str

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1950334141 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -505,6 +518,9 @@ private Compl

Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#discussion_r1950340475 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java: ## @@ -425,6 +426,7 @@ private static Stri

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1950337877 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -103,18 +134,23 @@ public void

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1950337361 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -124,6 +160,23 @@ private void

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1950336252 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -124,6 +160,23 @@ private void

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1950335289 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -103,18 +134,23 @@ public void

Re: [PR] IGNITE-23488 Integrate cancellation of transaction with sql kill handler [ignite-3]

2025-02-10 Thread via GitHub
korlov42 commented on code in PR #5207: URL: https://github.com/apache/ignite-3/pull/5207#discussion_r1950304142 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/views/TransactionsViewProvider.java: ## @@ -124,19 +110,15 @@ static class TxInfo { priva

[PR] IGNITE-24422 DB API Driver: Add Gradle task [ignite-3]

2025-02-10 Thread via GitHub
isapego opened a new pull request, #5208: URL: https://github.com/apache/ignite-3/pull/5208 - Adjusted windows wheel building script to accept python versions as an argument; - Added a gradle task to build wheels on Windows; -- This is an automated message from the Apache Git Service.

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo merged PR #5179: URL: https://github.com/apache/ignite-3/pull/5179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on code in PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#discussion_r1949493459 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtilUpdateAssignmentsTest.java: ## @@ -222,286 +221,148

Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on code in PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#discussion_r1949490774 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java: ## @@ -425,6 +426,9 @@ private static Str

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949482375 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949462422 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949439725 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -222,14 +220,18 @@ pri

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949432732 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -222,14 +220,18 @@ pri

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949432876 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -103,18 +134,23 @@ public void

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949427070 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -222,14 +220,18 @@ privat

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949280970 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -505,6 +518,9 @@ private C

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949366808 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -222,14 +220,18 @@ privat

Re: [PR] IIGNITE-24378 : Calcite. Query validation failure with a dynamic parameter. [ignite]

2025-02-10 Thread via GitHub
sonarqubecloud[bot] commented on PR #11846: URL: https://github.com/apache/ignite/pull/11846#issuecomment-2648520004 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] IGNITE-23488 Integrate cancellation of transaction with sql kill handler [ignite-3]

2025-02-10 Thread via GitHub
xtern opened a new pull request, #5207: URL: https://github.com/apache/ignite-3/pull/5207 https://issues.apache.org/jira/browse/IGNITE-23488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Bump io.opentelemetry:opentelemetry-exporter-otlp from 1.46.0 to 1.47.0 [ignite-3]

2025-02-10 Thread via GitHub
dependabot[bot] opened a new pull request, #5206: URL: https://github.com/apache/ignite-3/pull/5206 Bumps [io.opentelemetry:opentelemetry-exporter-otlp](https://github.com/open-telemetry/opentelemetry-java) from 1.46.0 to 1.47.0. Release notes Sourced from https://github.com/open-

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949397340 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -222,14 +220,18 @@ pri

Re: [PR] IGNITE-24378 Calcite. Query validation failure with a dynamic parameter v2. [ignite]

2025-02-10 Thread via GitHub
Vladsz83 closed pull request #11847: IGNITE-24378 Calcite. Query validation failure with a dynamic parameter v2. URL: https://github.com/apache/ignite/pull/11847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] IGNITE-24378 : Calcite. query validation failure with a dynamic parameter v3 [ignite]

2025-02-10 Thread via GitHub
Vladsz83 closed pull request #11859: IGNITE-24378 : Calcite. query validation failure with a dynamic parameter v3 URL: https://github.com/apache/ignite/pull/11859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Bump NUnit3TestAdapter from 4.6.0 to 5.0.0 in /modules/platforms/dotnet [ignite-3]

2025-02-10 Thread via GitHub
dependabot[bot] opened a new pull request, #5205: URL: https://github.com/apache/ignite-3/pull/5205 Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 4.6.0 to 5.0.0. Release notes Sourced from https://github.com/nunit/nunit3-vs-adapter/releases";>NUnit3Test

[PR] Bump Microsoft.NET.Test.Sdk from 17.12.0 to 17.13.0 in /modules/platforms/dotnet [ignite-3]

2025-02-10 Thread via GitHub
dependabot[bot] opened a new pull request, #5204: URL: https://github.com/apache/ignite-3/pull/5204 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.12.0 to 17.13.0. Release notes Sourced from https://github.com/microsoft/vstest/releases";>Microsoft.NET.T

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949371231 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -397,13 +398,72 @@ void t

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949371231 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -397,13 +398,72 @@ void t

Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on code in PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#discussion_r1949365556 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtilUpdateAssignmentsTest.java: ## @@ -222,286 +221,148

Re: [PR] IGNITE-24378 SQL Calcite: Fix query validation failure with a dynamic… [ignite]

2025-02-10 Thread via GitHub
sonarqubecloud[bot] commented on PR #11864: URL: https://github.com/apache/ignite/pull/11864#issuecomment-2648438339 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949354916 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private Co

[PR] IGNITE-24378 SQL Calcite: Fix query validation failure with a dynamic… [ignite]

2025-02-10 Thread via GitHub
alex-plekhanov opened a new pull request, #11864: URL: https://github.com/apache/ignite/pull/11864 … parameter Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have

Re: [PR] IGNITE-20469 Sql. Improve usability of EXPLAIN [ignite-3]

2025-02-10 Thread via GitHub
korlov42 merged PR #5177: URL: https://github.com/apache/ignite-3/pull/5177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949281133 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949274195 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private

Re: [PR] IGNITE-24446 Implement utilities necessary for zone assignments calculation [ignite-3]

2025-02-10 Thread via GitHub
alievmirza commented on code in PR #5200: URL: https://github.com/apache/ignite-3/pull/5200#discussion_r1949197988 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java: ## @@ -425,6 +426,9 @@ private static Str

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949175422 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1949162986 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private Co

Re: [PR] IGNITE-24425 Move cache dir filters to NodeFileTree [ignite]

2025-02-10 Thread via GitHub
sonarqubecloud[bot] commented on PR #11860: URL: https://github.com/apache/ignite/pull/11860#issuecomment-2648140765 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949116625 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the A

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949123102 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949123102 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [PR] [MINOR] Clean up IgniteIndexReaderTest [ignite]

2025-02-10 Thread via GitHub
nizhikov merged PR #11863: URL: https://github.com/apache/ignite/pull/11863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949131707 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949123666 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed t

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949122639 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949113618 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949108512 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed t

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949088917 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

[PR] IGNITE-24289: Sql. SQL-schemas. Extend test coverage. [ignite-3]

2025-02-10 Thread via GitHub
lowka opened a new pull request, #5203: URL: https://github.com/apache/ignite-3/pull/5203 Fixes a DROP schema issue. https://issues.apache.org/jira/browse/IGNITE-24289 --- Thank you for submitting the pull request. To streamline the review process of the patch and

Re: [PR] IGNITE-24403 add package level javadoc for org.apache.ignite.jdbc [ignite-3]

2025-02-10 Thread via GitHub
ygerzhedovich merged PR #5202: URL: https://github.com/apache/ignite-3/pull/5202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949065306 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-24450 Implement serialization and deserialization for zone leases [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on code in PR #5201: URL: https://github.com/apache/ignite-3/pull/5201#discussion_r1949052937 ## modules/placement-driver/src/test/java/org/apache/ignite/internal/placementdriver/leases/LeaseBatchSerializerTest.java: ## @@ -94,10 +100,33 @@ void batchWithTab

Re: [PR] IGNITE-24425 Move cache dir filters to NodeFileTree [ignite]

2025-02-10 Thread via GitHub
sonarqubecloud[bot] commented on PR #11860: URL: https://github.com/apache/ignite/pull/11860#issuecomment-2647992079 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1949041564 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed

[PR] IGNITE-24403 add package level javadoc for org.apache.ignite.jdbc [ignite-3]

2025-02-10 Thread via GitHub
ygerzhedovich opened a new pull request, #5202: URL: https://github.com/apache/ignite-3/pull/5202 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

[PR] [MINOR] Clean up IgniteIndexReaderTest [ignite]

2025-02-10 Thread via GitHub
nizhikov opened a new pull request, #11863: URL: https://github.com/apache/ignite/pull/11863 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948994643 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java: ## @@ -0,0 +1,337 @@ +/* + * Licensed

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948985786 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948977623 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948972979 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948972979 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the

Re: [PR] IGNITE-24365 Implement UpdateMinimumActiveTxBeginTimeReplicaRequest processing for zone replica [ignite-3]

2025-02-10 Thread via GitHub
sk0x50 commented on code in PR #5197: URL: https://github.com/apache/ignite-3/pull/5197#discussion_r1948966238 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/handlers/MinimumActiveTxTimeReplicaRequestHandler.java: ## @@ -0,0 +1,73 @

Re: [PR] IGNITE-24365 Implement UpdateMinimumActiveTxBeginTimeReplicaRequest processing for zone replica [ignite-3]

2025-02-10 Thread via GitHub
sk0x50 commented on code in PR #5197: URL: https://github.com/apache/ignite-3/pull/5197#discussion_r1948965026 ## modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogManagerCompactionFacade.java: ## @@ -38,6 +38,7 @@ class CatalogManager

Re: [PR] IGNITE-24365 Implement UpdateMinimumActiveTxBeginTimeReplicaRequest processing for zone replica [ignite-3]

2025-02-10 Thread via GitHub
sk0x50 commented on code in PR #5197: URL: https://github.com/apache/ignite-3/pull/5197#discussion_r1948964406 ## modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java: ## @@ -403,10 +412,11 @@ CompletableFuture propa

Re: [PR] IGNITE-24365 Implement UpdateMinimumActiveTxBeginTimeReplicaRequest processing for zone replica [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5197: URL: https://github.com/apache/ignite-3/pull/5197#discussion_r1948872367 ## modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java: ## @@ -403,10 +412,11 @@ CompletableFuture propa

Re: [PR] IGNITE-24424 Move cacheWorkDir, cacheDir to NodeFileTree [ignite]

2025-02-10 Thread via GitHub
nizhikov merged PR #11857: URL: https://github.com/apache/ignite/pull/11857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-24450 Implement serialization and deserialization for zone leases [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5201: URL: https://github.com/apache/ignite-3/pull/5201#discussion_r1948844566 ## modules/placement-driver/src/test/java/org/apache/ignite/internal/placementdriver/leases/LeaseBatchSerializerTest.java: ## @@ -94,10 +100,33 @@ void batchWithTablePar

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948768918 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -72,6 +82,26 @@ private static c

Re: [PR] IGNITE-24450 Implement serialization and deserialization for zone leases [ignite-3]

2025-02-10 Thread via GitHub
ibessonov commented on code in PR #5201: URL: https://github.com/apache/ignite-3/pull/5201#discussion_r1948766406 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseBatchSerializer.java: ## @@ -390,6 +390,17 @@ protected LeaseBatch r

Re: [PR] IGNITE-24450 Implement serialization and deserialization for zone leases [ignite-3]

2025-02-10 Thread via GitHub
ivanzlenko commented on code in PR #5201: URL: https://github.com/apache/ignite-3/pull/5201#discussion_r1948768502 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseBatchSerializer.java: ## @@ -390,6 +390,17 @@ protected LeaseBatch

Re: [PR] IGNITE-24424 Move cacheWorkDir, cacheDir to NodeFileTree [ignite]

2025-02-10 Thread via GitHub
sonarqubecloud[bot] commented on PR #11857: URL: https://github.com/apache/ignite/pull/11857#issuecomment-2647451997 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sk0x50 commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948728065 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -72,6 +82,26 @@ private static

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1948645004 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1948645004 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private

Re: [PR] IGNITE-24394 Fix race on table partition listeners registration [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1948611597 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private Co

Re: [PR] IGNITE-24394 Fix flaky test [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1948596391 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -1295,15 +1330,14 @@ publi

Re: [PR] IGNITE-24451 [ducktests] Allow to configure TransactionConfiguration#setTxAwareQueriesEnabled [ignite]

2025-02-10 Thread via GitHub
sonarqubecloud[bot] commented on PR #11862: URL: https://github.com/apache/ignite/pull/11862#issuecomment-2647251453 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24451 [ducktests] Allow to configure TransactionConfiguration#setTxAwareQueriesEnabled [ignite]

2025-02-10 Thread via GitHub
timoninmaxim merged PR #11862: URL: https://github.com/apache/ignite/pull/11862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948572046 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -124,6 +159,24 @@ private void

Re: [PR] [IGNITE-24413] More HA tests [ignite-3]

2025-02-10 Thread via GitHub
alievmirza commented on code in PR #5193: URL: https://github.com/apache/ignite-3/pull/5193#discussion_r1948571909 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/distributed/disaster/ItHighAvailablePartitionsRecoveryTest.java: ## @@ -297,6 +302,62 @@

Re: [PR] IGNITE-24394 Fix flaky test [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1948568232 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -491,27 +512,43 @@ private

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948567326 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaListenerHelper.java: ## @@ -0,0 +1,99 @@ +/* Review Comment: The

Re: [PR] IGNITE-24394 Fix flaky test [ignite-3]

2025-02-10 Thread via GitHub
sashapolo commented on code in PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1948567237 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java: ## @@ -397,6 +395,11 @@ void

Re: [PR] IGNITE-22621 Implement transaction storage for the zone replica listener [ignite-3]

2025-02-10 Thread via GitHub
rpuch commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948564890 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ## @@ -124,6 +159,24 @@ private void

Re: [PR] IGNITE-24435 Disable profiling by default for jmh task [ignite-3]

2025-02-10 Thread via GitHub
PakhomovAlexander commented on code in PR #5192: URL: https://github.com/apache/ignite-3/pull/5192#discussion_r1948564403 ## DEVNOTES.md: ## @@ -170,6 +167,28 @@ Here is how configurations override each other: Meaning 1 is overridden by 2, 2 is overridden by 3. +### How to

[PR] IGNITE-24451 [ducktests] Allow to configure TransactionConfiguration#setTxAwareQueriesEnabled [ignite]

2025-02-10 Thread via GitHub
skorotkov opened a new pull request, #11862: URL: https://github.com/apache/ignite/pull/11862 …setTxAwareQueriesEnabled Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following st