sk0x50 commented on code in PR #5187:
URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1948728065
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -72,6 +82,26 @@ private static class CommittedConfiguration {
}
}
+ private final FinishTxCommandHandler finishTxCommandHandler;
+
+ /** Constructor. */
+ public ZonePartitionRaftListener(
+ TxStatePartitionStorage txStatePartitionStorage,
+ TxManager txManager,
+ SafeTimeValuesTracker safeTimeTracker,
+ PendingComparableValuesTracker<Long, Void> storageIndexTracker,
+ ZonePartitionId zonePartitionId
+ ) {
+ this.safeTimeTracker = safeTimeTracker;
+ this.storageIndexTracker = storageIndexTracker;
+
+ finishTxCommandHandler = new FinishTxCommandHandler(
+ txStatePartitionStorage,
+ new TablePartitionId(zonePartitionId.zoneId(),
zonePartitionId.partitionId()),
Review Comment:
Could you please clarify this? Why are you using `zoneId` here?
`TablePartitionId` assumes that it should be `tableId`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
