[Netstack] 'Basic VLAN' plugin - some thoughts

2011-10-17 Thread Salvatore Orlando
Hi all, I put some thoughts regarding the design and the implementation of this plugin on a wiki page: http://wiki.openstack.org/Quantum-BasicVlanPlugin Please let me have your feedback. If everything goes according to plan, I plan to start implementing this plugin in two weeks' time. Regards,

Re: [Netstack] 'Basic VLAN' plugin - some thoughts

2011-10-17 Thread Sumit Naiksatam (snaiksat)
Hi Salvatore, Thanks for starting this. A few comments/questions - * You mention - "This model however implies that the Quantum plugin will be doing not just the 'logical' plugging of the VIF/vNIC, but also the 'physical' plugging, which is not what happens today." May be I am not reading t

Re: [Netstack] 'Basic VLAN' plugin - some thoughts

2011-10-17 Thread Salvatore Orlando
Hi Sumit, Thanks for your feedback! First of all please keep in mind that the wiki page started with the following disclaimer sentence: Caution: most of these thoughts were gathered after midnight, so some of them could turn out to be just nonsenses. And by writing 'some' I'm being quite optim

Re: [Netstack] 'Basic VLAN' plugin - some thoughts

2011-10-17 Thread Brad Hall
I haven't read the entire proposal yet but I wanted to clarify something quickly (inline).. Thanks, Brad On Mon, Oct 17, 2011 at 9:49 AM, Salvatore Orlando wrote: > Hi Sumit, > > > > Thanks for your feedback! > > First of all please keep in mind that the wiki page started with the > following di

[Netstack] Please review

2011-10-17 Thread Brad Hall
Hey Netstackers, I've got some outstanding reviews that could use another +1 please :) https://review.openstack.org/#change,839 https://review.openstack.org/#change,835 https://review.openstack.org/#change,677 https://review.openstack.org/#change,666 Thanks, Brad -- Mailing list: https://launc

[Netstack] Code coverage status

2011-10-17 Thread Brad Hall
Hey Everyone, After this change goes in (https://review.openstack.org/#change,677 [1]), you'll be able to generate code coverage numbers for our tests by using run_tests.sh -c. We're actually doing fairly good so far (sorry, gmail screws up the font): NameStmts Mis

Re: [Netstack] Code coverage status

2011-10-17 Thread Edgar Magana (eperdomo)
Hi Brad, Good job here... I already +1 Edgar -Original Message- From: netstack-bounces+eperdomo=cisco@lists.launchpad.net [mailto:netstack-bounces+eperdomo=cisco@lists.launchpad.net] On Behalf Of Brad Hall Sent: Monday, October 17, 2011 11:11 PM To: netstack@lists.launchpad.net S

Re: [Netstack] Code coverage status

2011-10-17 Thread Dan Wendlandt
Great Brad, very cool. Overall, a lot of the key files have very good coverage... nice work folks! A couple files in particular jump out as having poor coverage, likely because they contain common code copied from other projects. > quantum.common.config 112 7533% 62-64, 74