Re: [Netstack] API documentation ready for review

2011-09-23 Thread Salvatore Orlando
Thanks a lot Dan for applying the last changes to the documentation! Salvatore From: Dan Wendlandt [mailto:d...@nicira.com] Sent: 23 September 2011 06:02 To: Salvatore Orlando Cc: Andy Bierman; netstack@lists.launchpad.net Subject: Re: [Netstack] API documentation ready for review Updated the

Re: [Netstack] API documentation ready for review

2011-09-22 Thread Dan Wendlandt
e! > > ** ** > > Thanks for reviewing the documentation, > > Salvatore > > ** ** > > ** ** > > *From:* Andy Bierman [mailto:bierm...@brocade.com] > *Sent:* 22 September 2011 19:33 > *To:* Dan Wendlandt > > *Cc:* Salvatore Orlando

Re: [Netstack] API documentation ready for review

2011-09-22 Thread Salvatore Orlando
eptember 2011 19:33 To: Dan Wendlandt Cc: Salvatore Orlando; netstack@lists.launchpad.net Subject: RE: [Netstack] API documentation ready for review Hi, OK - I guess it is clear enough that the only allowed strings for port-state are ACTIVE and DOWN, and hopefully the behavior for ACTIVE or DOWN is roughl

Re: [Netstack] API documentation ready for review

2011-09-22 Thread Andy Bierman
Ports? } Andy From: Dan Wendlandt [mailto:d...@nicira.com] Sent: Thursday, September 22, 2011 10:36 AM To: Andy Bierman Cc: Salvatore Orlando; netstack@lists.launchpad.net Subject: Re: [Netstack] API documentation ready for review On Thu, Sep 22, 2011 at 10:00 AM, Andy Bierman mailto:bierm.

Re: [Netstack] API documentation ready for review

2011-09-22 Thread Dan Wendlandt
sage- > From: netstack-bounces+biermana=brocade@lists.launchpad.net [mailto: > netstack-bounces+biermana=brocade@lists.launchpad.net] On Behalf Of > Salvatore Orlando > Sent: Wednesday, September 21, 2011 5:05 PM > To: netstack@lists.launchpad.net > Subject: Re: [Netstack] A

Re: [Netstack] API documentation ready for review

2011-09-22 Thread Andy Bierman
Andy -Original Message- From: netstack-bounces+biermana=brocade@lists.launchpad.net [mailto:netstack-bounces+biermana=brocade@lists.launchpad.net] On Behalf Of Salvatore Orlando Sent: Wednesday, September 21, 2011 5:05 PM To: netstack@lists.launchpad.net Subject: Re: [Netstack] API

Re: [Netstack] API documentation ready for review

2011-09-22 Thread Ying Liu (yinliu2)
: Salvatore Orlando Cc: netstack@lists.launchpad.net Subject: Re: [Netstack] API documentation ready for review Great Salvatore, I reviewed the new sections, they look good. I've added some typos to the comments on the merge prop (https://code.launchpad.net/~salvatore-orlando/quantum/qu

Re: [Netstack] API documentation ready for review

2011-09-22 Thread Dan Wendlandt
Great Salvatore, I reviewed the new sections, they look good. I've added some typos to the comments on the merge prop ( https://code.launchpad.net/~salvatore-orlando/quantum/quantum-api-doc/+merge/75588). I'm fine fixing those myself when I merge into trunk, if that is easier for you (Diablo rel

Re: [Netstack] API documentation ready for review

2011-09-15 Thread Dan Wendlandt
This is fantastic Salvatore. Docs aren't very fun to write, but they are of critical importance to the project, so hats off to you. I reviewed the doc and have a first round of feedback in. Let's hold off on a second review until we've incorporated those changes to avoid too much duplication in