Re: [Netstack] Review approval protocol (gerrit)

2011-10-15 Thread Dan Wendlandt
The net result is that the pep8 fixes I mentioned in my previous email on in trunk already. In one way, this is a good thing, as it means that we can procede integrating other fixes into trunk as well. On the other hand, it means my untested changes to the cisco plugin are in trunk, so it would

[Netstack] Review approval protocol (gerrit)

2011-10-15 Thread Brad Hall
As the first one to completely mess this up (I clicked approve on a review (+2) when there wasn't a (+1) yet) I figured I'd send out a link describing the protocol in case anyone other than me missed this in the documentation. >From http://wiki.openstack.org/GerritJenkinsGithub: Any Openstack dev

[Netstack] Fwd: Change in openstack/quantum[master]: fix pep8 issues in Cisco plugin

2011-10-15 Thread Dan Wendlandt
Hi folks, It appears that the new github/gerrit infrastructure for Quantum is gating trunk using a pep8 test that uses pep8 version 0.6.1. As a result, the pep8 errors reported by 0.6.1 in the cisco plugin are preventing us from checking in other code. I've proposed a branch (below) to fix these