Hi folks, It appears that the new github/gerrit infrastructure for Quantum is gating trunk using a pep8 test that uses pep8 version 0.6.1. As a result, the pep8 errors reported by 0.6.1 in the cisco plugin are preventing us from checking in other code. I've proposed a branch (below) to fix these issues. Feel free to propose your own branch as well if you prefer another way of fixing the errors, we just need to get this taken care of ASAP. Btw, my branch is untested, so until we get the Cisco CI infrastructure setup, I'll have to ask you folks to test the change manually. Thanks,
Dan ---------- Forwarded message ---------- From: dan wendlandt (Code Review) <rev...@openstack.org> Date: Sat, Oct 15, 2011 at 8:37 PM Subject: Change in openstack/quantum[master]: fix pep8 issues in Cisco plugin To: Cc: Dan Wendlandt <d...@nicira.com> dan wendlandt has uploaded a new change for review. Change subject: fix pep8 issues in Cisco plugin ...................................................................... fix pep8 issues in Cisco plugin bug 875458 The cisco plugin has some pep8 errors when using pep8 version 0.6.1 which is now what is used to gate trunk. This fix is not supposed to change any functionality. I was not able to test it, so I will need a review + testing from the Cisco team. Change-Id: I5e95e3ec96d5f53a3bea7cea2764fd421ba0a46e --- M quantum/plugins/cisco/ucs/cisco_ucs_inventory.py 1 file changed, 62 insertions(+), 85 deletions(-) git pull ssh://review.openstack.org:29418/openstack/quantumrefs/changes/02/902/1 -- To view, visit https://review.openstack.org/902 To unsubscribe, visit https://review.openstack.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e95e3ec96d5f53a3bea7cea2764fd421ba0a46e Gerrit-PatchSet: 1 Gerrit-Project: openstack/quantum Gerrit-Branch: master Gerrit-Owner: dan wendlandt Gerrit-Reviewer: Dan Wendlandt <d...@nicira.com> -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
