e rds.h in rds-tools is not related with the kernel rds.h, the change
in kernel rds.h does not affect rds-tools.
rds-info in rds-tools 2.0.5 and 2.0.6 is tested with this commit. It works
well.
Signed-off-by: Zhu Yanjun
---
V1->V2: RDS CI is removed.
Thanks for testing compatibility.
ean_list.
So clean_nodes is discarded. It can not be used again.
The workqueue is executed periodically. So more and more clean_nodes are
discarded. Finally the clean_list is NULL.
Then this problem will occur.
Fixes: 1bc144b62524 ("net, rds, Replace xlist in net/rds/xlist.h with llist")
Signed-off-by: Zhu Yanjun
---
Thanks.
Acked-by: Santosh Shilimkar
and "drop_list" before they even have a chance to be properly invalidated.
Signed-off-by: Gerd Rausch
---
Thanks for the update.
Acked-by: Santosh Shilimkar
Cases where locking is needed:
* If we have multiple consumers with llist_del_first used in one consumer,
* and llist_del_first or llist_del_all used in other consumers,
* then a lock is needed.
Also, while at it, drop the unused "pool" parameter
from "list_to_llist_nodes".
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
On 7/16/19 3:29 PM, Gerd Rausch wrote:
Make function "rds_ib_try_reuse_ibmr" return NULL in case
memory region could not be allocated, since callers
simply check if the return value is not NULL.
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
an invalid access error in a race from a pending
"IB_WR_LOCAL_INV" operation with a teardown ("dma_unmap_sg", "put_page")
and de-registration ("ib_dereg_mr") of the corresponding
memory region.
Signed-off-by: Gerd Rausch
---
Thanks for updated version.
Acked-by: Santosh Shilimkar
On 7/16/19 3:29 PM, Gerd Rausch wrote:
Fix a bug where fr_state first goes to FRMR_IS_STALE, because of a failure
of operation IB_WR_LOCAL_INV, but then gets set back to "FRMR_IS_FREE"
uncoditionally, even though the operation failed.
Signed-off-by: Gerd Rausch
---
Acked-b
shutdown" will spin forever,
waiting for it to go back to "RDS_IB_DEFAULT_FR_WR",
which of course will never happen as there are no
outstanding work requests.
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
alled "i_fastreg_inuse_count" that keeps track of how
many FRWR memory segments are out there marked "FRMR_IS_INUSE"
(and also wake_up rds_ib_ring_empty_wait, as they go away).
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
&conn_param);
if (ret)
- rds_ib_conn_error(conn, "rdma_connect failed (%d)\n", ret);
+ rds_ib_conn_error(conn, "rdma_connect_locked failed (%d)\n",
+ ret);
out:
/* Beware - returning non-zero tells the rdma_cm to destroy
For RDS part,
Acked-by: Santosh Shilimkar
[...]
Thanks Haakon. Patchset looks fine by me.
Acked-by: Santosh Shilimkar
y: Parav Pandit
> Signed-off-by: Leon Romanovsky
> ---
> net/rds/ib.c | 20 +———
Looks fine by me.
Acked-by: Santosh Shilimkar
> On Apr 5, 2021, at 7:08 AM, Leon Romanovsky wrote:
>
> On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote:
>> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote:
>>> From: Leon Romanovsky
>>>
From Avihai,
>>>
>>> Relaxed Ordering is a PCIe mechanism that rel
gt; Signed-off-by: Aditya Pakki
> ---
> net/rds/message.c | 1 +
> net/rds/send.c| 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Looks fine by me. Thanks.
Acked-by: Santosh Shilimkar
include/linux/slab.h:621 [inline]
> rds_rdma_extra_size+0xb2/0x3b0 net/rds/rdma.c:568
> rds_rm_size net/rds/send.c:928 [inline]
>
> Reported-by: syzbot+1bd2b07f93745fa38...@syzkaller.appspotmail.com
> Signed-off-by: Sabyrzhan Tasbolatov
> —
Looks fine by me.
Acked-by: Santosh Shilimkar
vbuf untouched.
>
> Signed-off-by: William Kucharski
> —
Looks good. Thanks !!
Acked-by: Santosh Shilimkar
On 5/11/2018 12:48 AM, Yanjun Zhu wrote:
On 2018/5/11 13:20, DaeRyong Jeong wrote:
We report the crash: KASAN: null-ptr-deref Read in rds_ib_get_mr
Note that this bug is previously reported by syzkaller.
https://syzkaller.appspot.com/bug?id=0bb56a5a48b000b52aa2b0d8dd20b1f545214d91
Nonethele
On 4/24/2018 4:25 AM, Dag Moxnes wrote:
I was going to suggest the following correction:
If all agree that this is the correct way of doing it, I can go ahead
and an post it.
Yes please. Go ahead and post your fix.
Regards,
Santosh
P.S: Avoid top posting please.
andle")
Signed-off-by: Dag Moxnes
---
Thanks Dag for following it up.
Acked-by: Santosh Shilimkar
On 7/1/19 9:39 AM, Gerd Rausch wrote:
A number of net/rds fixes necessary to make "rds_rdma.ko"
pass some basic Oracle internal tests.
Gerd Rausch (7):
net/rds: Give fr_state a chance to transition to FRMR_IS_FREE
net/rds: Get rid of "wait_clean_list_grace" and add locking
net/rds: Wait
On 7/1/19 9:40 AM, Gerd Rausch wrote:
Fix a bug where fr_state first goes to FRMR_IS_STALE, because of a failure
of operation IB_WR_LOCAL_INV, but then gets set back to "FRMR_IS_FREE"
uncoditionally, even though the operation failed.
Signed-off-by: Gerd Rausch
---
net/rds/ib_frmr.c | 3 ++-
On 7/1/19 9:40 AM, Gerd Rausch wrote:
Since "rds_ib_free_frmr" and "rds_ib_free_frmr_list" simply put
the FRMR memory segments on the "drop_list" or "free_list",
and it is the job of "rds_ib_flush_mr_pool" to reap those entries
by ultimately issuing a "IB_WR_LOCAL_INV" work-request,
we need to tr
On 7/1/19 9:40 AM, Gerd Rausch wrote:
Otherwise, if an IB connection is torn down before "rds_ib_setup_qp"
is called, the value of "ic->i_fastreg_wrs" is still at zero
(as it wasn't initialized by "rds_ib_setup_qp").
Consequently "rds_ib_conn_path_shutdown" will spin forever,
waiting for it to go
On 7/1/19 9:39 AM, Gerd Rausch wrote:
Make function "rds_ib_try_reuse_ibmr" return NULL in case
memory region could not be allocated, since callers
simply check if the return value is not NULL.
Signed-off-by: Gerd Rausch
---
Looks good to me. Will add this to other fixes.
On 7/1/19 9:39 AM, Gerd Rausch wrote:
Waiting for activity on the "clean_list" to quiesce is no substitute
for proper locking.
We can have multiple threads competing for "llist_del_first"
via "rds_ib_reuse_mr", and a single thread competing
for "llist_del_all" and "llist_del_first" via "rds_ib_f
On 7/1/19 9:39 AM, Gerd Rausch wrote:
In order to:
1) avoid a silly bouncing between "clean_list" and "drop_list"
triggered by function "rds_ib_reg_frmr" as it is releases frmr
regions whose state is not "FRMR_IS_FREE" right away.
2) prevent an invalid access error in a race from a pendi
On 7/1/19 1:50 PM, Gerd Rausch wrote:
Hi David,
On 01/07/2019 11.27, David Miller wrote:
From: Gerd Rausch
Date: Mon, 1 Jul 2019 09:39:44 -0700
+ /* Memory regions make it onto the "clean_list" via
+* "rds_ib_flush_mr_pool", after the memory regi
On 7/1/19 1:55 PM, Gerd Rausch wrote:
Hi Santosh,
On 01/07/2019 13.41, santosh.shilim...@oracle.com wrote:
@@ -144,7 +146,29 @@ static int rds_ib_post_reg_frmr(struct rds_ib_mr *ibmr)
if (printk_ratelimit())
pr_warn("RDS/IB: %s returned error(%d)\n",
On 7/1/19 2:06 PM, Gerd Rausch wrote:
Hi Santosh,
On 01/07/2019 14.00, santosh.shilim...@oracle.com wrote:
Look for command timeout in CX3 sources. 60 second is upper bound in
CX3. Its not standard in specs(at least not that I know) though
and may vary from vendor to vendor.
I am not se
On 7/1/19 10:11 PM, Gerd Rausch wrote:
Hi Santosh,
On 01/07/2019 19.28, santosh.shilim...@oracle.com wrote:
Below. All command timeouts are 60 seconds.
enum {
MLX4_CMD_TIME_CLASS_A = 6,
MLX4_CMD_TIME_CLASS_B = 6,
MLX4_CMD_TIME_CLASS_C = 6,
};
T
On 7/2/19 2:05 PM, Gerd Rausch wrote:
On 02/07/2019 09.49, santosh.shilim...@oracle.com wrote:
On 7/1/19 10:11 PM, Gerd Rausch wrote:
For the registration work-requests there is a benefit to wait a short
amount of time only (the trade-off described in patch #1 of this series).
Actually we sho
On 7/2/19 3:12 PM, Gerd Rausch wrote:
On 02/07/2019 14.18, santosh.shilim...@oracle.com wrote:
On 7/2/19 2:05 PM, Gerd Rausch wrote:
What do you call "RDS_GET_MR" semantics?
Its a blocking socket call. Meaning after this call return to the
user, the key must be valid. With async registration
e send completes fix was done by Venkat
Venkatsubra in downstream kernel.
Reviewed-and-tested-by: Zhu Yanjun
Reviewed-by: Gerd Rausch
Signed-off-by: Santosh Shilimkar
---
net/rds/ib_send.c | 29 +
net/rds/rdma.c| 10 --
net/rds/rds.h | 1 -
net/rds/se
nd invalidation path"
rds: Accept peer connection reject messages due to incompatible version
rds: Return proper "tos" value to user-space
Santosh Shilimkar (2):
rds: fix reordering with composite message notification
rds: avoid version downgrade to legitimat
inal commit was done in the name of performance:
to remove the performance bottleneck
No performance benefit could be observed with a fixed-up version
of the original commit measured between two Oracle X7 servers,
both equipped with Mellanox Connect-X5 HCAs.
The prudent course of action is to
From: Gerd Rausch
The proper "tos" value needs to be returned
to user-space (sockopt RDS_INFO_CONNECTIONS).
Fixes: 3eb450367d08 ("rds: add type of service(tos) infrastructure")
Signed-off-by: Gerd Rausch
Reviewed-by: Zhu Yanjun
Signed-off-by: Santosh Shilimkar
---
net/
iated connection with say
tos 8 while usual connection racing can get downgraded to tos 0
which is not desirable.
Patch fixes above issue introduced by commit
commit d021fabf525f ("rds: rdma: add consumer reject")
Reported-by: Yanjun Zhu
Tested-by: Yanjun Zhu
Signed-off-by: Sa
onnection:
if (rds_conn_state(conn) == RDS_CONN_CONNECTING) {
/* Wait and see - our connect may still be succeeding */
rds_ib_stats_inc(s_ib_connect_raced);
}
goto out;
#6 Host-A
receives an "RDMA_CM_EVENT_REJECTED" event (from
8/25/2017 7:21 AM, Bhumika Goyal wrote:
Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init
Signed-off-by: Bhumika Goyal
---
Acked-by: Santosh Shilimkar
Grover
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
On 8/13/19 11:21 AM, Gerd Rausch wrote:
From: Chris Mason
Date: Fri, 3 Feb 2012 11:08:51 -0500
Signed-off-by: Chris Mason
Signed-off-by: Bang Nguyen
Signed-off-by: Gerd Rausch
Signed-off-by: Somasundaram Krishnasamy
---Acked-by: Santosh Shilimkar
done in the name of compatibility
with the Oracle internal code-base.
s_recv_bytes_added_to_socket -> "recv_bytes_added_to_sock"
s_recv_bytes_removed_from_socket -> "recv_bytes_freed_fromsock"
Fixes: 192a798f5299 ("RDS: add stat for socket recv memory usage&q
eed Andy's SOB as well.
Signed-off-by: Gerd Rausch
Other than that,
Acked-by: Santosh Shilimkar
e" if "rds_ib_recv_refill_one" fails.
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
On 8/14/19 8:56 AM, Doug Ledford wrote:
On Tue, 2019-08-13 at 11:20 -0700, Gerd Rausch wrote:
From: Andy Grover
Date: Tue, 24 Nov 2009 15:35:51 -0800
Although RDS has an official PF_RDS value now, existing software
expects to look for rds sysctls to determine it. We need to maintain
these f
On 8/14/19 11:21 AM, David Miller wrote:
From: santosh.shilim...@oracle.com
Date: Wed, 14 Aug 2019 11:01:36 -0700
Some of the application software was released before 2009 and ended up
using these proc entries from downstream kernel. The newer lib/app
using RDS don't use these. Unfortunately lo
e" if "rds_ib_recv_refill_one" fails.
Signed-off-by: Gerd Rausch
---
Thought I acked V1 series.
Acked-by: Santosh Shilimkar
On 8/15/19 7:42 AM, Gerd Rausch wrote:
From: Chris Mason
Date: Fri, 3 Feb 2012 11:08:51 -0500
Signed-off-by: Chris Mason
Signed-off-by: Bang Nguyen
Signed-off-by: Gerd Rausch
Signed-off-by: Somasundaram Krishnasamy
---
Acked-by: Santosh Shilimkar
cket recv memory usage")
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
ned-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
-Cheong for getting this one out on list.
Acked-by: Santosh Shilimkar
service(tos) infrastructure")
Fixes: b7ff8b1036f0 ("rds: Extend RDS API for IPv6 support")
Reported-by: 黄ID蝴蝶
Signed-off-by: Dan Carpenter
Signed-off-by: Ka-Cheong Poon
---
Thanks for getting this out of the list.
Acked-by: Santosh Shilimkar
On 8/23/19 7:03 AM, Dag Moxnes wrote:
Add the RDMA cookie and RX timestamp to the usercopy whitelist.
After the introduction of hardened usercopy whitelisting
(https://lwn.net/Articles/727322/), a warning is displayed when the
RDMA cookie or RX timestamp is copied to userspace:
kernel: WARNING:
or the fixup patch. Should be applied to stable
as well.
Acked-by: Santosh Shilimkar
Regards,
Santosh
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
Hi,
This patchset breaks compatibility...
On 04/02/2019 16.04, Santosh Shilimkar wrote:
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id,
bool isv6)
/* If the peer doesn'
On 3/5/2019 8:48 AM, Gerd Rausch wrote:
Hi Santosh,
On 05/03/2019 08.41, Santosh Shilimkar wrote:
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
If there's a mechanism that ensures compatibility with older (pre-4.1) versions
of RDS I am not seeing it.
Thats handled as part of the connection r
nn->c_faddr);
conn->c_proposed_version = RDS_PROTOCOL_COMPAT_VERSION;
@@ -122,7 +122,6 @@ static int rds_rdma_cm_event_handler_cmn(struct rdma_cm_id
*cm_id,
rdsdebug("Connection rejected: %s\n",
rdma_reject_msg(cm_id, event->st
bf525ff ("rds: rdma: add consumer reject")
Signed-off-by: Gerd Rausch
---
net/rds/rdma_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Changes in submitted patch v2:
* Dropped the "Orabug:" line from the commit-log message (as requested)
* Added a "Fixes:" line to the commit-log-message
Thanks Gerd for posting an update. The fix looks correct as already
mentioned in earlier post.
FWIW,
Acked-by: Santosh Shilimkar
Hi Yanjun,
Please provide your tested-by since you mentioned offlist that
so far you are unable to reproduce the issue on net-next. Thanks.
Regards,
Santosh
On 3/8/2019 2:37 PM, Gerd Rausch wrote:
On 07/03/2019 17.37, santosh.shilim...@oracle.com wrote:
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -736,6 +736,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp,
void *buffer)
cinfo->next_rx_seq = cp->cp_next_rx_seq;
00 0.00 0.00 0.000.00 0.00 -1.00
100 0.00 0.00 0.000.00 0.00 -1.00
...
"
So this exchange between 8K and 1M pool is added back.
Fixes: commit 490ea5967b0d ("RDS: IB: move FMR code to its own file")
Signed-off-by: Zhu Yanjun
---
Acked-by: Santosh Shilimkar
orted rdma request to fs dax memory
Santosh Shilimkar (1):
rds: add sysctl for rds support of On-Demand-Paging
net/rds/ib.h| 1 +
net/rds/ib_sysctl.c | 8
net/rds/rdma.c | 5 +++--
3 files changed, 12 insertions(+), 2 deletions(-)
--
1.9.1
Signed-off-by: Santosh Shilimkar
---
net/rds/rdma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 182ab84..5010100 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -158,8 +158,9 @@ static int rds_pin_pages(unsigned long user_addr
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supported.
Reviewed-by: Håkon Bugge
Reviewed-tested-by: Zhu Yanjun
Signed-off-by: Hans Westgaard Ry
Signed-off-by: Sa
Signed-off-by: Santosh Shilimkar
---
net/rds/rdma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 182ab84..e0a6b72 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -158,8 +158,9 @@ static int rds_pin_pages(unsigned long user_addr
orted rdma request to fs dax memory
Santosh Shilimkar (1):
rds: add sysctl for rds support of On-Demand-Paging
net/rds/ib.h| 1 +
net/rds/ib_sysctl.c | 8
net/rds/rdma.c | 5 +++--
3 files changed, 12 insertions(+), 2 deletions(-)
--
1.9.1
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supported.
Reviewed-by: Håkon Bugge
Reviewed-tested-by: Zhu Yanjun
Signed-off-by: Hans Westgaard Ry
Signed-off-by: Sa
On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform
On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supp
On 5/1/2019 11:21 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:00AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on m
On 5/1/2019 11:18 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:50AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that requi
5/4/2019 11:22 PM, Leon Romanovsky wrote:
On Thu, May 02, 2019 at 10:59:58AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 11:18 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:50AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at
On 5/4/2019 11:28 PM, Leon Romanovsky wrote:
On Thu, May 02, 2019 at 10:52:23AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 11:21 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:00AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019
On 5/10/2019 5:54 AM, Jason Gunthorpe wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform
On 5/10/2019 6:02 AM, Jason Gunthorpe wrote:
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supp
On 5/10/2019 12:20 PM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 11:58:42AM -0700, santosh.shilim...@oracle.com wrote:
On 5/10/19 11:07 AM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 11:02:35AM -0700, santosh.shilim...@oracle.com wrote:
[...]
Why would you need to detect FS DAX mem
On 5/10/2019 12:47 PM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 12:38:31PM -0700, Santosh Shilimkar wrote:
On 5/10/2019 12:20 PM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 11:58:42AM -0700, santosh.shilim...@oracle.com wrote:
On 5/10/19 11:07 AM, Jason Gunthorpe wrote:
On Fri, May
troy_cq(ic->i_send_cq);
+ ic->i_send_cq = NULL;
This was done to ensure, you still don't get ISR delivering
the CQEs while we are in shutdown path. Your patch
is fine though since you don't change that behavior.
Acked-by: Santosh Shilimkar
On 6/25/2018 10:50 AM, Sowmini Varadhan wrote:
On (06/26/18 01:43), Ka-Cheong Poon wrote:
Yes, I think if the socket is bound, it should check the scope_id
in msg_name (if not NULL) to make sure that they match. A bound
RDS socket can send to multiple peers. But if the bound local
address is
On 6/27/2018 3:07 AM, Ka-Cheong Poon wrote:
On 06/26/2018 09:08 PM, Sowmini Varadhan wrote:
On (06/26/18 21:02), Ka-Cheong Poon wrote:
[...]
I don't expect RDS apps will want to use link local address
in the first place. In fact, most normal network apps don't.
This is not true.
You
On 6/27/2018 3:23 AM, Ka-Cheong Poon wrote:
This patch changes the internal representation of an IP address to use
struct in6_addr. IPv4 address is stored as an IPv4 mapped address.
All the functions which take an IP address as argument are also
changed to use struct in6_addr. But RDS socket la
Hi Ka-Cheong,
On 7/6/2018 8:25 AM, Sowmini Varadhan wrote:
On (07/06/18 23:08), Ka-Cheong Poon wrote:
As mentioned in a previous mail, it is unclear why the
port number is transport specific. Most Internet services
use the same port number running over TCP/UDP as shown
in the IANA database.
Hi Dave,
On 7/13/2018 2:25 PM, David Miller wrote:
From: Ka-Cheong Poon
Date: Fri, 13 Jul 2018 04:02:59 -0700
@@ -52,7 +52,7 @@
#define RDS_RECVERR 5
#define RDS_CONG_MONITOR 6
#define RDS_GET_MR_FOR_DEST 7
-#define SO_RDS_TRANSPORT
On 7/13/2018 4:27 PM, David Miller wrote:
From: Santosh Shilimkar
Date: Fri, 13 Jul 2018 15:00:59 -0700
Ofcourse any application built using upstream header and
using SO_RDS_TRANSPORT will break but since this particular
option was added for special case(application wants to
upfront select
t;)
Signed-off-by: Sowmini Varadhan
---
Thanks Sowmini for the WARN_ON() discussion off-list.
Acked-by: Santosh Shilimkar
opy for this
case.
Reported-by: syzbot+f893ae7bb2f6456df...@syzkaller.appspotmail.com
Fixes: 0cebaccef3ac ("rds: zerocopy Tx support.")
Signed-off-by: Sowmini Varadhan
---
Acked-by: Santosh Shilimkar
Hi Saeed
On 2/21/2018 12:13 PM, Saeed Mahameed wrote:
From: Yonatan Cohen
The current implementation of create CQ requires contiguous
memory, such requirement is problematic once the memory is
fragmented or the system is low in memory, it causes for
failures in dma_zalloc_coherent().
This pat
n 2/24/2018 1:40 AM, Majd Dibbiny wrote:
On Feb 23, 2018, at 9:13 PM, Saeed Mahameed wrote:
On Thu, 2018-02-22 at 16:04 -0800, Santosh Shilimkar wrote:
Hi Saeed
On 2/21/2018 12:13 PM, Saeed Mahameed wrote:
[...]
Jason mentioned about this patch to me off-list. We were
seeing similar
27;t seen yet, Dan Carpenter reported skb deref
warning on previous version of the patch. Not sure why it wasn't sent
on netdev.
smatch warnings:
net/rds/recv.c:605 rds_recvmsg_zcookie() warn: variable dereferenced
before check 'skb' (see line 596)
With that addressed,
Acked-by: Santosh Shilimkar
On 2/26/2018 9:11 AM, Sowmini Varadhan wrote:
On (02/26/18 09:07), Santosh Shilimkar wrote:
Just in case you haven't seen yet, Dan Carpenter reported skb deref
warning on previous version of the patch. Not sure why it wasn't sent
on netdev.
yes I saw it, but that was for the previo
On 3/2/2018 6:42 AM, David Miller wrote:
From: "santosh.shilim...@oracle.com"
Date: Thu, 1 Mar 2018 22:22:07 -0800
Versioning comment typically goes below "---" and not part of
commit message.
I like them to be in the commit message most of the time.
Especially for patch series header posti
hanks !!
Acked-by: Santosh Shilimkar
On 10/1/2017 10:56 PM, David Miller wrote:
From: David Miller
Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT)
From: Avinash Repaka
Date: Fri, 29 Sep 2017 18:13:50 -0700
This patch fixes the scope of has_fr and has_fmr variables as they are
needed only in rds_ib_add_one().
Signed-off-by: Avinas
Hi Dave,
On 10/2/2017 1:30 PM, Santosh Shilimkar wrote:
On 10/1/2017 10:56 PM, David Miller wrote:
From: David Miller
[...]
Actually, reverted, this breaks the build.
net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or
directory
#include "ib.h"
Although I
insertions(+), 2 deletions(-)
This patch is fine but it will be nice if you can collect
these changes in series as you are trying to update the
FRWR support. Like this patch and other cleanup patch
you posted yesterday.
With that log fixed,
Acked-by: Santosh Shilimkar
-by: Tushar Dave
Reviewed-by: Sowmini Varadhan
---
Looks good Tushar !!
Acked-by: Santosh Shilimkar
On 8/21/2018 7:05 AM, Yue Haibing wrote:
Remove duplicated include.
Signed-off-by: Yue Haibing
---
Looks fine.
Acked-by : Santosh Shilimkar
ugged so am fine to go
ahead with this change. Thanks for the patch.
FWIW,
Acked-by: Santosh Shilimkar
On 9/10/2018 5:16 PM, Cong Wang wrote:
On Mon, Sep 10, 2018 at 5:04 PM Sowmini Varadhan
wrote:
On (09/10/18 16:51), Cong Wang wrote:
__rds_create_bind_key(key, addr, port, scope_id);
- rs = rhashtable_lookup_fast(&bind_hash_table, key, ht_parms);
+ rcu_read_lock();
+
On 9/10/2018 5:45 PM, Cong Wang wrote:
On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar
wrote:
Would you mind posting an updated patch please with call_rcu and
above extended RCU grace period with rcu_read_lock. Thanks !!
If you prefer to fix _two_ problems in one patch, sure.
For the
(),
so we need to extend RCU read lock protection in rds_find_bound()
to close this race condition.
Reported-and-tested-by: syzbot+8967084bcac563795...@syzkaller.appspotmail.com
Reported-by: syzbot+93a5839deb3555374...@syzkaller.appspotmail.com
Cc: Sowmini Varadhan
Cc: Santosh Shilimkar
Cc: rds-de
1 - 100 of 487 matches
Mail list logo
