Re: [PATCH net-next 5/7] net/rds: Set fr_state only to FRMR_IS_FREE if IB_WR_LOCAL_INV had been successful

[santosh . shilimkar]

On 7/1/19 9:40 AM, Gerd Rausch wrote:

Fix a bug where fr_state first goes to FRMR_IS_STALE, because of a failure
of operation IB_WR_LOCAL_INV, but then gets set back to "FRMR_IS_FREE"
uncoditionally, even though the operation failed.

Signed-off-by: Gerd Rausch <gerd.rau...@oracle.com>
---
  net/rds/ib_frmr.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/rds/ib_frmr.c b/net/rds/ib_frmr.c
index 3c953034dca3..a5d8f4128515 100644
--- a/net/rds/ib_frmr.c
+++ b/net/rds/ib_frmr.c
@@ -328,7 +328,8 @@ void rds_ib_mr_cqe_handler(struct rds_ib_connection *ic, 
struct ib_wc *wc)
        }

if (frmr->fr_inv) {

-               frmr->fr_state = FRMR_IS_FREE;
+               if (frmr->fr_state == FRMR_IS_INUSE)
+                       frmr->fr_state = FRMR_IS_FREE;
                frmr->fr_inv = false;
                wake_up(&frmr->fr_inv_done);
        }

Looks good to me. Will add this to other fixes.