Thanks Jacub for they inputs.
> On May 28, 2019, at 3:45 PM, Jakub Kicinski
> wrote:
>
> On Tue, 28 May 2019 10:46:44 -0700, Vedang Patel wrote:
>> From: Vinicius Costa Gomes
>>
>> This adds the UAPI and the core bits necessary for userspace to
>> request hardware offloading to be enabled.
>>
[Sending the email again since the last one was rejected by netdev because it
was html.]
> On May 29, 2019, at 12:14 PM, Jakub Kicinski
> wrote:
>
> On Wed, 29 May 2019 17:06:49 +0000, Patel, Vedang wrote:
>>> On May 28, 2019, at 3:45 PM, Jakub Kicinski
>>> wro
> On May 29, 2019, at 2:06 PM, Jakub Kicinski
> wrote:
>
> On Wed, 29 May 2019 20:05:16 +0000, Patel, Vedang wrote:
>> [Sending the email again since the last one was rejected by netdev because
>> it was html.]
>>
>>> On May 29, 2019, at 12:14 PM, Jaku
a scenario where an application is trying to send a lot of small
packets. By default, these packets will be combined into a single packet and
this packet will be segmented in the hardware. But, we are not sure whether
these packets can be transmitted before the gate for this application closes.
>>> Following are some of the other highlights of the series:
>>> - Fix a bug where hardware timestamping and SO_TXTIME options cannot be used
>>>together. (Patch 1)
>>> - Introduce hardware offloading. This patch introduces offload parameter
>>> wh
Hi Murali,
> On Jun 3, 2019, at 7:15 AM, Murali Karicheri wrote:
>
> Hi Vedang,
>
> On 05/28/2019 01:46 PM, Vedang Patel wrote:
>> Currently, we are seeing non-critical packets being transmitted outside
>> of their timeslice. We can confirm that the packets are being dequeued
>> at the right ti
> On Jun 6, 2019, at 12:44 PM, Stephen Hemminger
> wrote:
>
> On Thu, 6 Jun 2019 10:52:19 -0700
> Vedang Patel wrote:
>
>> +if (tb[TCA_TAPRIO_ATTR_TXTIME_DELAY])
>> +txtime_delay =
>> rta_getattr_s32(tb[TCA_TAPRIO_ATTR_TXTIME_DELAY]);
>> +
>> +print_int(PRINT_ANY, "txt
> On Jun 6, 2019, at 12:43 PM, Stephen Hemminger
> wrote:
>
> On Thu, 6 Jun 2019 10:52:18 -0700
> Vedang Patel wrote:
>
>> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE
>> *f, struct rtattr *opt)
>> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
>> str
It looks like I sent out the wrong version of this series. Another version
coming in momentarily.
Sorry for the spam.
-Vedang
> On Jun 6, 2019, at 10:52 AM, Patel, Vedang wrote:
>
> This should only be updated after the kernel patches related to txtime-offload
> have been mer
> On Jun 6, 2019, at 2:46 PM, Stephen Hemminger
> wrote:
>
> On Thu, 6 Jun 2019 21:13:50 +0000
> "Patel, Vedang" wrote:
>
>>> On Jun 6, 2019, at 12:43 PM, Stephen Hemminger
>>> wrote:
>>>
>>> On Thu, 6 Jun 2019 10:52:18 -07
Thanks Jacub for the feedback. My comments are inline.
I will wait a few more days for more feedback/discussions on the series and
then post the next version of the series.
> On Jun 6, 2019, at 4:21 PM, Jakub Kicinski
> wrote:
>
> On Thu, 6 Jun 2019 10:50:56 -0700, Vedang Patel wrote:
>> Cu
Hi Murali,
> On Jun 7, 2019, at 11:52 AM, Murali Karicheri wrote:
>
> On 06/04/2019 04:06 PM, Patel, Vedang wrote:
>> Hi Murali,
>>> On Jun 3, 2019, at 7:15 AM, Murali Karicheri wrote:
>>>
>>> Hi Vedang,
>>>
>>> On 05/28/2019 01:
Hi Jacub,
> On Jun 7, 2019, at 3:02 PM, Jakub Kicinski
> wrote:
>
> On Fri, 7 Jun 2019 20:42:55 +0000, Patel, Vedang wrote:
>>> Thanks for the changes, since you now validate no unknown flags are
>>> passed, perhaps there is no need to check if flags are == ~
Hi Stephen,
The kernel patches corresponding to this series have been merged. I just wanted
to check whether these iproute2 related patches are on your TODO list.
Let me know if you need any information from me on these patches.
Thanks,
Vedang Patel
> On Jun 6, 2019, at 3:22 PM, Patel, Ved
Ok I will send out the patches again.
Thanks,
Vedang
> On Jul 15, 2019, at 1:16 PM, David Ahern wrote:
>
> On 7/15/19 1:50 PM, Stephen Hemminger wrote:
>> On Mon, 15 Jul 2019 19:40:19 +0000
>> "Patel, Vedang" wrote:
>>
>>> Hi Stephen,
>
Hi Stephen,
> On Jul 15, 2019, at 4:37 PM, Stephen Hemminger
> wrote:
>
> On Mon, 15 Jul 2019 15:51:41 -0700
> Vedang Patel wrote:
>
>> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE
>> *f, struct rtattr *opt)
>> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
>
> On Jul 15, 2019, at 4:38 PM, Stephen Hemminger
> wrote:
>
> On Mon, 15 Jul 2019 15:51:42 -0700
> Vedang Patel wrote:
>
>> +if (get_s32(&txtime_delay, *argv, 0)) {
>
> Is txtime_delay of a negative value meaningful?
No, txtime-delay should always be a positive value.
I request that this patch should also be considered for the net tree since it
fixes the data type of of the txtime_delay parameter and should go in with the
iproute2 patches which implement support for txtime-assist mode.
Thanks,
Vedang Patel
> On Jul 16, 2019, at 12:52 PM, Patel, Ved
> On Jul 16, 2019, at 2:19 PM, David Miller wrote:
>
> From: Vedang Patel
> Date: Tue, 16 Jul 2019 12:52:18 -0700
>
>> During the review of the iproute2 patches for txtime-assist mode, it was
>> pointed out that it does not make sense for the txtime-delay parameter to
>> be negative. So, cha
> On Jul 18, 2019, at 10:32 AM, David Ahern wrote:
>
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> The type for txtime-delay parameter will change from s32 to u32. So,
>> make the corresponding change in the ABI file as well.
>>
>> Signed-off-by: Vedang Patel
>> ---
>> include/uapi/linux/pkt_
> On Jul 18, 2019, at 10:36 AM, David Ahern wrote:
>
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> Document the newly added option (skip-skb-check) on the etf man-page.
>>
>> Signed-off-by: Vedang Patel
>> ---
>> man/man8/tc-etf.8 | 10 ++
>> 1 file changed, 10 insertions(+)
>>
>> dif
> On Jul 18, 2019, at 10:12 PM, Stephen Hemminger
> wrote:
>
> On Thu, 18 Jul 2019 12:55:39 -0700
> Vedang Patel wrote:
>
>> -print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
>> +print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
>>
> On Jul 22, 2019, at 11:21 AM, David Ahern wrote:
>
> On 7/19/19 3:40 PM, Vedang Patel wrote:
>> In iproute2 txtime-assist series, it was pointed out that print_bool()
>> should be used to print binary values. This is to make it JSON friendly.
>>
>> So, make the corresponding changes in ETF.
> On Jul 22, 2019, at 5:11 PM, David Ahern wrote:
>
> On 7/22/19 1:11 PM, Patel, Vedang wrote:
>>
>>
>>> On Jul 22, 2019, at 11:21 AM, David Ahern wrote:
>>>
>>> On 7/19/19 3:40 PM, Vedang Patel wrote:
>>>> In iproute2 txtime-ass
Hi Saeed,
> On Nov 13, 2020, at 10:02 AM, Patel, Vedang wrote:
>
> Hi Saeed,
>
>> On Nov 12, 2020, at 11:31 AM, Saeed Mahameed wrote:
>>
>> On Tue, 2020-11-10 at 23:53 +, Patel, Vedang wrote:
>>>> With BTF formatted metadata it is up to the dri
> On Nov 18, 2020, at 4:57 PM, Patel, Vedang wrote:
>
> Hi Saeed,
>
>> On Nov 13, 2020, at 10:02 AM, Patel, Vedang wrote:
>>
>> Hi Saeed,
>>
>>> On Nov 12, 2020, at 11:31 AM, Saeed Mahameed wrote:
>>>
>>> On Tue, 2020-11-1
[Sorry if you got the email twice. Resending because it was rejected by netdev
for containing HTML]
Hi Saeed/Jesper,
I am working in the Time Sensitive Networking team at Intel. We work on
implementing and upstreaming support for TSN related features for intel based
NICs. Recently we have be
Hi Saeed,
> On Nov 10, 2020, at 3:32 PM, Saeed Mahameed wrote:
>
> On Tue, 2020-11-10 at 22:44 +0000, Patel, Vedang wrote:
>> [Sorry if you got the email twice. Resending because it was rejected
>> by netdev for containing HTML]
>>
>> Hi Saeed/Jesper,
> On Tue, 10 Nov 2020 23:53:41 +
> "Patel, Vedang" wrote:
>
>> Hi Saeed,
>>
>>> On Nov 10, 2020, at 3:32 PM, Saeed Mahameed wrote:
>>>
>>> On Tue, 2020-11-10 at 22:44 +, Patel, Vedang wrote:
>>>> [Sorry if y
Hi Saeed,
> On Nov 12, 2020, at 11:31 AM, Saeed Mahameed wrote:
>
> On Tue, 2020-11-10 at 23:53 +0000, Patel, Vedang wrote:
>>> With BTF formatted metadata it is up to the driver to advertise
>>> whatever it can/want :)
>>> so yes.
>>
>>
> On Jun 10, 2019, at 7:27 AM, Murali Karicheri wrote:
>
> Vedang,
>
> On 06/07/2019 05:12 PM, Patel, Vedang wrote:
>> Hi Murali,
>>> On Jun 7, 2019, at 11:52 AM, Murali Karicheri wrote:
>>>
>>> On 06/04/2019 04:06 PM, Patel, Vedang wrote:
Thanks for the input David.
> On Jun 17, 2019, at 4:22 PM, David Miller wrote:
>
> From: Vedang Patel
> Date: Mon, 17 Jun 2019 12:31:08 -0700
>
>> diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
>> index a41d7d4434ee..ab6080013666 100644
>> --- a/net/sched/sch_taprio.c
>> +++ b/
Thanks Sergei for the input.
> On Jun 18, 2019, at 2:28 AM, Sergei Shtylyov
> wrote:
>
> Hello!
>
> On 17.06.2019 22:31, Vedang Patel wrote:
>
>> Currently, etf expects a socket with SO_TXTIME option set for each packet
>> it encounters. So, it will drop all other packets. But, in the future
> On Jun 20, 2019, at 3:47 AM, Eric Dumazet wrote:
>
>
>
> On 6/19/19 10:40 AM, Vedang Patel wrote:
>> skb->tstamp is being used at multiple places. On the transmit side, it
>> is used to determine the launchtime of the packet. It is also used to
>> determine the software timestamp after the
> On Jun 20, 2019, at 10:07 AM, Eric Dumazet wrote:
>
>
>
> On 6/20/19 9:49 AM, Patel, Vedang wrote:
>>
>>
>>> On Jun 20, 2019, at 3:47 AM, Eric Dumazet wrote:
>>>
>>>
>>>
>>> On 6/19/19 10:40 AM, Vedang Patel w
> On Jun 20, 2019, at 1:16 AM, Sergei Shtylyov
> wrote:
>
> On 19.06.2019 20:40, Vedang Patel wrote:
>
>> Currently, etf expects a socket with SO_TXTIME option set for each packet
>> it encounters. So, it will drop all other packets. But, in the future
>> commits we are planning to add functi
> On Jun 24, 2019, at 2:40 PM, Jakub Kicinski
> wrote:
>
> On Fri, 21 Jun 2019 10:28:23 -0700, Vedang Patel wrote:
>> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
>> index 8b2f993cbb77..409d1616472d 100644
>> --- a/include/uapi/linux/pkt_sched.h
>> +++ b/include/u
Hi Jeff,
> On Jun 26, 2019, at 12:44 PM, Kirsher, Jeffrey T
> wrote:
>
> On Tue, 2019-06-25 at 15:07 -0700, Vedang Patel wrote:
>> If a packet which is utilizing the launchtime feature (via SO_TXTIME
>> socket
>> option) also requests the hardware transmit timestamp, the hardware
>> timestamp i
I agree with Florian's minor comment regarding pr_info->netdev_dgb change.
But, apart from that, I reviewed both the patches look good to me:
Reviewed-By: Vedang Patel
On 3/15/19, 2:17 PM, "netdev-ow...@vger.kernel.org on behalf of Leandro
Dorileo" wrote:
This set fixes miscalculations
39 matches
Mail list logo
