Thanks for the input David.
> On Jun 17, 2019, at 4:22 PM, David Miller <da...@davemloft.net> wrote: > > From: Vedang Patel <vedang.pa...@intel.com> > Date: Mon, 17 Jun 2019 12:31:08 -0700 > >> diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c >> index a41d7d4434ee..ab6080013666 100644 >> --- a/net/sched/sch_taprio.c >> +++ b/net/sched/sch_taprio.c > ... >> +/* Get how much time has been already elapsed in the current cycle. */ >> +static inline s32 get_cycle_time_elapsed(struct sched_gate_list *sched, >> ktime_t time) >> +{ > > Please do not use the inline directive in foo.c files, let the compiler > decide. > Okay, I will remove inline directive from all C files and send a new version. -Vedang > ... >> +static inline int length_to_duration(struct taprio_sched *q, int len) >> +{ >> + return (len * atomic64_read(&q->picos_per_byte)) / 1000; >> +} > > Likewise. > > ... >> +static inline ktime_t get_cycle_start(struct sched_gate_list *sched, >> + ktime_t time) >> +{ > > Likewise.