239.1.1.11 temp
We had some reports of failing scripts which were parsing the output.
Also the old format matches the bridge mdb command syntax which makes
it easier to build commands out of the output.
Fixes: c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
Signed-off-b
On 26/07/2019 15:02, Horatiu Vultur wrote:
> Hi Nikolay,
>
> The 07/26/2019 12:26, Nikolay Aleksandrov wrote:
>> External E-Mail
>>
>>
>> On 26/07/2019 11:41, Nikolay Aleksandrov wrote:
>>> On 25/07/2019 17:21, Horatiu Vultur wrote:
>>>&g
On 12/01/2021 15:59, Horatiu Vultur wrote:
> Based on the comments of the previous version, we started to work on a
> new version, so it would be possible to enable/disable queries per vlan.
> This is still work in progress and there are plenty of things that are
> not implemented and tested:
> - i
On 13/01/2021 11:36, Jiapeng Zhong wrote:
> Fix the following warnings:
>
> net/bridge/br_sysfs_br.c(833): warning: %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
> net/bridge/br_sysfs_br.c(817): warning: %u in format string (no. 1)
> requires 'unsigne
On 13/01/2021 11:44, Jiapeng Zhong wrote:
> Fix the following warnings:
>
> net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1)
> requires 'long' but the argument type is 'unsigned long'.
> net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1)
> requires 'long' but
On 14/01/2021 09:51, menglong8.d...@gmail.com wrote:
> From: Menglong Dong
>
> Replace the check for ETH_P_8021Q and ETH_P_8021AD in
> br_dev_queue_push_xmit with eth_type_vlan.
>
> Signed-off-by: Menglong Dong
> ---
> net/bridge/br_forward.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deleti
On 16/01/2021 17:39, Joachim Wiberg wrote:
> On Wed, Jan 13, 2021 at 14:15, Nikolay Aleksandrov wrote:
>> On 12/01/2021 15:59, Horatiu Vultur wrote:
>>> Based on the comments of the previous version, we started to work on a
>>> new version, so it would be possible to
| 2 +-
> 3 files changed, 5 insertions(+), 12 deletions(-)
>
Acked-by: Nikolay Aleksandrov
On 18/01/2021 22:19, Tobias Waldekranz wrote:
> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote:
>> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote:
>>> Ah I see, no I was not aware of that. I just saw that the entry towards
>>> the CPU was added to the ATU, which it would i
On 18/01/2021 23:17, Nikolay Aleksandrov wrote:
> On 18/01/2021 22:19, Tobias Waldekranz wrote:
>> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote:
>>> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote:
>>>> Ah I see, no I was not aware of t
On 18/01/2021 23:22, Nikolay Aleksandrov wrote:
> On 18/01/2021 23:17, Nikolay Aleksandrov wrote:
>> On 18/01/2021 22:19, Tobias Waldekranz wrote:
>>> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote:
>>>> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekra
On 18/01/2021 23:50, Vladimir Oltean wrote:
> On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote:
>> Apologies for the multiple emails, but wanted to leave an example:
>>
>> 00:11:22:33:44:55 dev ens16 master bridge permanent
>>
>> This must al
On 19/01/2021 00:06, Vladimir Oltean wrote:
> On Mon, Jan 18, 2021 at 11:53:18PM +0200, Nikolay Aleksandrov wrote:
>> On 18/01/2021 23:50, Vladimir Oltean wrote:
>>> On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote:
>>>> Apologies for the multiple
On 19/01/2021 02:42, Vladimir Oltean wrote:
> On Tue, Jan 19, 2021 at 12:42:04AM +0200, Nikolay Aleksandrov wrote:
>> No, it shouldn't be a problem to change that. We should be careful about the
>> way it's changed though because reporting it for all ports might become a
On 19/01/2021 06:39, Jakub Kicinski wrote:
> On Sun, 17 Jan 2021 05:34:16 -0800 wangyingji...@126.com wrote:
>> From: Yingjie Wang
>>
>> There is no iPv4_is_multicast() check added to ip_mc_leave_group()
>> to check if imr->imr_multiaddr.s_addr is a multicast address.
>> If not a multicast address
From: Nikolay Aleksandrov
Hi,
This set adds explicit host tracking support for IGMPv3/MLDv2. The
already present per-port fast leave flag is used to enable it since that
is the primary goal of EHT, to track a group and its S,Gs usage per-host
and when left without any interested hosts delete
From: Nikolay Aleksandrov
We need to pass the host address so later it can be used for explicit
host tracking. No functional change.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 90 +--
1 file changed, 49 insertions(+), 41 deletions
From: Nikolay Aleksandrov
Rename src_size argument to addr_size in preparation for passing host
address as an argument to IGMPv3/MLDv2 functions.
No functional change.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 78 +++
1 file changed
From: Nikolay Aleksandrov
Prepare __grp_src_block_incl() for being able to cause a notification
due to changes. Currently it cannot happen, but EHT would change that
since we'll be deleting sources immediately. Make sure that if the pg is
deleted we don't return true as that would
From: Nikolay Aleksandrov
We need to preserve the srcs pointer since we'll be passing it for EHT
handling later.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/net/b
From: Nikolay Aleksandrov
Add functions to create, destroy and lookup an EHT host. These are
per-host entries contained in the eht_host_tree in net_bridge_port_group
which are used to store a list of all sources (S,G) entries joined for that
group by each host, the host's current filter mod
From: Nikolay Aleksandrov
Add support for IGMPv3/MLDv2 allow/block EHT handling. Similar to how
the reports are processed we have 2 cases when the group is in include
or exclude mode, these are processed as follows:
- group include
- allow: create missing entries
- block: remove existing
From: Nikolay Aleksandrov
Add EHT source set and set-entry create, delete and lookup functions.
These allow to manipulate source sets which contain their own host sets
with entries which joined that S,G. We're limiting the maximum number of
tracked S,G entries per host to PG_SRC_ENT_
From: Nikolay Aleksandrov
A block report can result in empty source and host sets for both include
and exclude groups so if there are no hosts left we can safely remove
the group. Pull the block group handling so it can cover both cases and
add a check if EHT requires the delete.
Signed-off-by
From: Nikolay Aleksandrov
We should be able to handle host filter mode changing. For exclude mode
we must create a zero-src entry so the group will be kept even without
any S,G entries (non-zero source sets). That entry doesn't count to the
entry limit and can always be created, its tim
From: Nikolay Aleksandrov
Now that we can delete set entries, we can use that to remove EHT hosts.
Since the group's host set entries exist only when there are related
source set entries we just have to flush all source set entries
joined by the host set entry and it will be automati
From: Nikolay Aleksandrov
Mark groups which were deleted due to fast leave/EHT.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 21 ++---
net/bridge/br_multicast_eht.c | 8
net/bridge/br_private.h | 3 ++-
3 files changed, 20 insertions
From: Nikolay Aleksandrov
Add EHT structures for tracking hosts and sources per group. We keep one
set for each host which has all of the host's S,G entries, and one set for
each multicast source which has all hosts that have joined that S,G. For
each host, source entry we record the filter
From: Nikolay Aleksandrov
Add support for IGMPv3/MLDv2 include and exclude EHT handling. Similar to
how the reports are processed we have 2 cases when the group is in include
or exclude mode, these are processed as follows:
- group include
- is_include: create missing entries
- to_include
From: Nikolay Aleksandrov
This is an optimization specifically for TO_INCLUDE which sends queries
for the older entries and thus lowers the S,G timers to LMQT. If we have
the following situation for a group in either include or exclude mode:
- host A was interested in srcs X and Y, but is
On 11/12/2020 11:26, Horatiu Vultur wrote:
> This patch tries to add vlan support to IGMP queries.
> It extends the function 'br_ip4_multicast_alloc_query' to add
> also a vlan tag if vlan is enabled. Therefore the bridge will send
> queries for each vlan the ports are in.
>
> There are few other
/* register of bridge completed, add sysfs entries */
> - br_sysfs_addbr(dev);
> + err = br_sysfs_addbr(dev);
> + if (err)
> + return notifier_from_errno(err);
> +
> return NOTIFY_DONE;
> }
> }
>
Patch looks good, I also tested it with a notifier error injecting.
Tested-by: Nikolay Aleksandrov
Acked-by: Nikolay Aleksandrov
On 13/12/2020 04:40, Vladimir Oltean wrote:
> Currently the bridge emits atomic switchdev notifications for
> dynamically learnt FDB entries. Monitoring these notifications works
> wonders for switchdev drivers that want to keep their hardware FDB in
> sync with the bridge's FDB.
>
> For example s
On 13/12/2020 15:22, Nikolay Aleksandrov wrote:
> On 13/12/2020 04:40, Vladimir Oltean wrote:
>> Currently the bridge emits atomic switchdev notifications for
>> dynamically learnt FDB entries. Monitoring these notifications works
>> wonders for switchdev drivers that want t
On 13/12/2020 15:55, Vladimir Oltean wrote:
> Hi Nik,
>
> On Sun, Dec 13, 2020 at 03:22:16PM +0200, Nikolay Aleksandrov wrote:
>> Hi Vladimir,
>> Thank you for the good explanation, it really helps a lot to understand the
>> issue.
>> Even though it's dece
On 03/12/2020 03:03, Jakub Kicinski wrote:
> On Tue, 1 Dec 2020 22:01:14 +0800 Wang Hai wrote:
>> If adding bridge sysfs fails, br->ifobj will be NULL, there is no
>> need to delete its non-existent sysfs when deleting the bridge device,
>> otherwise, it will cause a warning. So, when br->ifobj ==
t; br_ip6_multicast_leave_snoopers -> ipv6_dev_mc_dec -> igmp6_group_dropped ->
igmp6_leave_group ->
MLDv1 mode && last reporter -> igmp6_send() ?
I think it was saved by the fact that !br_opt_get(br, BROPT_MULTICAST_ENABLED)
would be true and the
multicast lock won't be acquired in the br_dev_xmit path? If so, I'd appreciate
a comment about that
because it's not really trivial to find out. :)
Anyhow, the patch is fine as-is too:
Acked-by: Nikolay Aleksandrov
Thanks,
Nik
On 04/12/2020 00:42, Huang, Joseph wrote:
>> From: Huang, Joseph
>> Sent: Thursday, December 3, 2020 4:53 PM
>> To: Nikolay Aleksandrov ; Jakub Kicinski
>>
>> Cc: Roopa Prabhu ; David S. Miller
>> ; bri...@lists.linux-foundation.org;
>> netdev@vger.kerne
{
> + err = -ENOMEM;
> goto out_filt;
> + }
> v->brvlan = masterv;
> if (br_opt_get(br, BROPT_VLAN_STATS_PER_PORT)) {
> v->stats = netdev_alloc_pcpu_stats(struct
> br_vlan_stats);
>
Acked-by: Nikolay Aleksandrov
On 04/12/2020 23:39, Joseph Huang wrote:
> When enabling multicast snooping, bridge module deadlocks on multicast_lock
> if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2
> network.
>
> The deadlock was caused by the following sequence: While holding the lock,
> br_multicas
ed-off-by: Joseph Huang
> ---
> net/bridge/br_device.c| 6 ++
> net/bridge/br_multicast.c | 34 +-
> net/bridge/br_private.h | 10 ++
> 3 files changed, 41 insertions(+), 9 deletions(-)
>
LGTM, thanks!
Acked-by: Nikolay Aleksandrov
On 23/11/2020 13:14, Horatiu Vultur wrote:
> Extend MRP to support LC mode(link check) for the interconnect port.
> This applies only to the interconnect ring.
>
> Opposite to RC mode(ring check) the LC mode is using CFM frames to
> detect when the link goes up or down and based on that the usersp
On 23/11/2020 14:31, Horatiu Vultur wrote:
> The 11/23/2020 14:13, Nikolay Aleksandrov wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>>
>> On 23/11/2020 13:14, Horatiu Vultur wrote:
>>> Extend MRP to
On 17/11/2020 02:56, David Ahern wrote:
> On 11/14/20 3:53 PM, Petr Machata wrote:
>> Two helpers, parse_on_off() and print_on_off(), have been recently added to
>> lib/utils.c. Convert a number of instances of the same effective behavior
>> to calls to these helpers.
>>
>> Petr Machata (7):
>> b
On 11/11/2020 21:37, Pablo Neira Ayuso wrote:
> Add .ndo_fill_forward_path for bridge devices.
>
> Signed-off-by: Pablo Neira Ayuso
> ---
> include/linux/netdevice.h | 1 +
> net/bridge/br_device.c| 24
> 2 files changed, 25 insertions(+)
>
> diff --git a/include/l
On 12/11/2020 02:53, Nikolay Aleksandrov wrote:
> On 11/11/2020 21:37, Pablo Neira Ayuso wrote:
>> Add .ndo_fill_forward_path for bridge devices.
>>
>> Signed-off-by: Pablo Neira Ayuso
>> ---
>> include/linux/netdevice.h | 1 +
>> net/bridge/br_device.c
On 08/01/2021 02:20, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> There is an effort to convert .ndo_get_stats64 to sleepable context, and
> for that to work, we need to prevent callers of dev_get_stats from using
> atomic locking.
>
> The bonding driver retrieves its statistics recursivel
On Sat, 2020-10-17 at 21:41 +0300, Vladimir Oltean wrote:
> From: Nikolay Aleksandrov
>
> Extend the bridge multicast control and data path to configure routes
> for L2 (non-IP) multicast groups.
>
> The uapi struct br_mdb_entry union u is extended with another variant
On Wed, 2020-10-21 at 09:17 +, Nikolay Aleksandrov wrote:
> On Sat, 2020-10-17 at 21:41 +0300, Vladimir Oltean wrote:
> > From: Nikolay Aleksandrov
> >
> > Extend the bridge multicast control and data path to configure routes
> > for L2 (non-IP) multicast group
On Thu, 2020-10-15 at 18:30 +0200, Pablo Neira Ayuso wrote:
> Add .ndo_fill_forward_path for bridge devices.
>
> Signed-off-by: Pablo Neira Ayuso
> ---
> v2: no changes
>
> include/linux/netdevice.h | 1 +
> net/bridge/br_device.c| 22 ++
> 2 files changed, 23 insertion
On Sun, 2020-10-25 at 06:59 +, Vladimir Oltean wrote:
> On Wed, Oct 21, 2020 at 09:17:07AM +0000, Nikolay Aleksandrov wrote:
> > > diff --git a/include/uapi/linux/if_bridge.h
> > > b/include/uapi/linux/if_bridge.h
> > > index 4c687686aa8f..a25f6f9aa8c3 100644
On Tue, 2020-10-27 at 07:59 -0700, Stephen Hemminger wrote:
> On Tue, 27 Oct 2020 10:02:42 +
> Henrik Bjoernlund via Bridge wrote:
>
> > +/* Return 0 if the frame was not processed otherwise 1
> > + * note: already called with rcu_read_lock
> > + */
> > +static int br_process_frame_type(struc
From: Nikolay Aleksandrov
Add helpers which will be used in subsequent tests, they are:
- check_sg_entries: check for proper source list and S,G entry
existence
- check_sg_fwding: check for proper traffic forwarding/blocking
- check_sg_state: check for proper blocked/forwarding entry state
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
INCLUDE (A)IS_EX (B) EXCLUDE (A*B,B-A) (B-A)=0
Delete (A-B
From: Nikolay Aleksandrov
To prepare the bridge_igmp.sh for IGMPv3 we need to rename the
current test to IGMPv2.
Signed-off-by: Nikolay Aleksandrov
---
tools/testing/selftests/net/forwarding/bridge_igmp.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools
From: Nikolay Aleksandrov
Hi,
This set adds tests for the bridge's new IGMPv3 support. The tests use
precooked packets which are sent via mausezahn and the resulting state
after each test is checked for proper X,Y sets, (*,G) source list, source
list entry timers, (S,G) existence and
From: Nikolay Aleksandrov
We have to specifically check for udp protocol in addition to the mac
address because in IGMPv3 tests group-specific queries will use the same
mac address.
Signed-off-by: Nikolay Aleksandrov
---
tools/testing/selftests/net/forwarding/bridge_igmp.sh | 2 +-
1 file
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
EXCLUDE (X,Y) IS_EX (A) EXCLUDE (A-Y,Y*A)(A-X-Y)=GMI
Delete (X-A
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
EXCLUDE (X,Y) BLOCK (A) EXCLUDE (X+(A-Y),Y) (A-X-Y)=Group Timer
Send Q(G,A-Y)
Signed-off-by: Nikolay
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
EXCLUDE (X,Y) IS_IN (A) EXCLUDE (X+A,Y-A) (A)=GMI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 27
From: Nikolay Aleksandrov
When we have *,G ports in exclude mode and a new S,G,port is added
the kernel has to automatically create an S,G entry for each exclude
port to get proper forwarding.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 31
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
INCLUDE (A)IS_IN (B) INCLUDE (A+B)(B)=GMI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 25
From: Nikolay Aleksandrov
Add support for one more argument which specifies the source address to
use. It will be later used for IGMPv3 S,G entry testing.
Signed-off-by: Nikolay Aleksandrov
---
.../testing/selftests/net/forwarding/bridge_igmp.sh | 13 +++--
1 file changed, 7
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
EXCLUDE (X,Y) TO_EX (A) EXCLUDE (A-Y,Y*A)(A-X-Y)=Group Timer
Delete (X-A
From: Nikolay Aleksandrov
Test that when a group in exclude mode expires it changes mode to
include and the blocked entries are deleted.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 49 ++-
1 file changed, 48 insertions(+), 1 deletion
From: Nikolay Aleksandrov
First we test is_include/include mode then we build on that with allow
effectively achieving:
state reportresult action
INCLUDE (A)ALLOW (B)INCLUDE (A+B) (B)=GMI
Signed-off-by: Nikolay Aleksandrov
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
INCLUDE (A)BLOCK (B) INCLUDE (A) Send Q(G,A*B)
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 33
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
INCLUDE (A)TO_EX (B) EXCLUDE (A*B,B-A) (B-A)=0
Delete (A-B
From: Nikolay Aleksandrov
The test checks for the following case:
state reportresult action
EXCLUDE (X,Y) ALLOW (A) EXCLUDE (X+A,Y-A) (A)=GMI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 83
On Wed, 2020-10-28 at 12:54 +0200, Vladimir Oltean wrote:
> From: Nikolay Aleksandrov
>
> Extend the bridge multicast control and data path to configure routes
> for L2 (non-IP) multicast groups.
>
> The uapi struct br_mdb_entry union u is extended with another variant,
>
st, &deleted_head);
> + br_opt_toggle(br, BROPT_MULTICAST_ENABLED, false);
> spin_unlock_bh(&br->multicast_lock);
>
> br_multicast_gc(&deleted_head);
This doesn't make any sense. It doesn't fix anything.
If 4.4 has a problem then the relevant patches should get backported to it.
We don't add random changes to fix older releases.
Cheers,
Nik
Nacked-by: Nikolay Aleksandrov
From: Nikolay Aleksandrov
Factor out mcast_packet_test into lib.sh so it can be later extended and
reused by MLDv2 tests.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 32 ---
tools/testing/selftests/net/forwarding/lib.sh | 32
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) IS_EX (A) EXCLUDE (A-Y, Y*A) (A-X-Y)=MALI
Delete (X-A
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) TO_EX (A) EXCLUDE (A-Y,Y*A)(A-X-Y) =
Filter Timer
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) ALLOW (B) INCLUDE (A+B)(B)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 29
From: Nikolay Aleksandrov
Add the initial setup for MLDv2 tests with the first test of a simple
is_include report. For MLDv2 we need to setup the bridge properly and we
also send the full precooked packets instead of relying on mausezahn to
fill in some parts. For verification we use the generic
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) IS_IN (A) EXCLUDE (X+A, Y-A) (A)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 30
From: Nikolay Aleksandrov
In order to test an IPv6 multicast packet we need to pass different tc
and mausezahn protocols only, so add a simple check for the destination
address which decides if we should generate an IPv4 or IPv6 mcast
packet.
Signed-off-by: Nikolay Aleksandrov
---
tools
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) BLOCK (A) EXCLUDE (X+(A-Y),Y) (A-X-Y) =
Filter Timer
From: Nikolay Aleksandrov
Hi,
This is the second selftests patch-set for the new multicast functionality
which adds tests for the bridge's MLDv2 support. The tests use full
precooked packets which are sent via mausezahn and the resulting state
after each test is checked for proper X,Y sets,
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) IS_IN (B) INCLUDE (A+B) (B)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 29
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) ALLOW (A) EXCLUDE (X+A,Y-A)(A)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 30
From: Nikolay Aleksandrov
When we have *,G ports in exclude mode and a new S,G,port is added
the kernel has to automatically create an S,G entry for each exclude
port to get proper forwarding.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 31
From: Nikolay Aleksandrov
Factor out S,G entry state checking functions for existence, forwarding,
blocking and timer to lib.sh so they can be later used by MLDv2 tests.
Add brmcast_ suffix to their name to make the relation to the bridge
explicit.
Signed-off-by: Nikolay Aleksandrov
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) TO_EX (B) EXCLUDE (A*B,B-A)(B-A)=0
Delete (A-B
From: Nikolay Aleksandrov
Test that when a group in exclude mode expires it changes mode to
include and the blocked entries are deleted.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 48 ++-
1 file changed, 47 insertions(+), 1 deletion
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) BLOCK (B) INCLUDE (A) Send Q(MA,A*B)
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 37
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) IS_EX (B) EXCLUDE (A*B, B-A) (B-A)=0
Delete (A-B
From: Nikolay Aleksandrov
Hi,
This set extends the bridge vlan code to use the new vlan RTM calls
which allow to dump detailed per-port, per-vlan information and also to
manipulate the per-vlan options. It also allows to monitor any vlan
changes (add/del/option change). The rtm vlan dumps have
From: Nikolay Aleksandrov
Rename print_portstate to print_stp_state in preparation for use by vlan
code as well (per-vlan state), and export it. To be in line with the new
naming rename also port_states to stp_states as they'll be used for
vlans, too.
Signed-off-by: Nikolay Aleksa
From: Nikolay Aleksandrov
Add a helper which parses an STP state string to its numeric value.
Signed-off-by: Nikolay Aleksandrov
---
bridge/br_common.h | 1 +
bridge/link.c | 22 +-
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/bridge/br_common.h b
From: Nikolay Aleksandrov
Use the new bridge vlan rtm dump helper to dump all of the available
vlan information when -details (-d) is used with vlan show. It is also
capable of dumping vlan stats if -statistics (-s) is added.
Currently this is the only interface capable of dumping per-vlan
From: Nikolay Aleksandrov
Add rtnl bridge vlan dump request helper which will be used to retrieve
bridge vlan information and options.
Signed-off-by: Nikolay Aleksandrov
---
include/libnetlink.h | 2 ++
lib/libnetlink.c | 19 +++
2 files changed, 21 insertions(+)
diff
From: Nikolay Aleksandrov
Add a new per-vlan option set command. It allows to manipulate vlan
options, those can be bridge-wide or per-port depending on what device
is specified. The first option that can be set is the vlan STP state,
it is identical to the bridge port STP state. The man page is
From: Nikolay Aleksandrov
Add support for vlan activity monitoring, we display vlan notifications on
vlan add/del/options change. The man page and help are also updated
accordingly.
Signed-off-by: Nikolay Aleksandrov
---
bridge/br_common.h | 2 +-
bridge/mdb.c | 2 +-
bridge/monitor.c
ekranz
> Reviewed-by: Vladimir Oltean
> Signed-off-by: Vladimir Oltean
> ---
> net/bridge/br_switchdev.c | 41 +++
> 1 file changed, 11 insertions(+), 30 deletions(-)
>
Acked-by: Nikolay Aleksandrov
| 2 +-
> 9 files changed, 15 insertions(+), 14 deletions(-)
>
For the bridge change:
Acked-by: Nikolay Aleksandrov
On 12/02/2021 07:20, Boris Pismenny wrote:
> Signed-off-by: Boris Pismenny
> Signed-off-by: Ben Ben-Ishay
> Signed-off-by: Or Gerlitz
> Signed-off-by: Yoray Zack
> ---
> Documentation/networking/index.rst | 1 +
> Documentation/networking/tcp-ddp-offload.rst | 296 +
; Patch is new.
>
> Changes in v2:
> Patch is new.
>
> net/bridge/br_netlink.c | 109 --
> net/bridge/br_switchdev.c | 6 ++-
> 2 files changed, 39 insertions(+), 76 deletions(-)
>
LGTM, thanks!
Acked-by: Nikolay Aleksandrov
itchdev_set_port_flag if already
> populated.
>
> net/bridge/br_netlink.c | 9 +
> net/bridge/br_private.h | 6 --
> net/bridge/br_switchdev.c | 13 +++--
> net/bridge/br_sysfs_if.c | 7 +--
> 4 files changed, 21 insertions(+), 14 deletions(-)
>
Acked-by: Nikolay Aleksandrov
1 - 100 of 1566 matches
Mail list logo
