[PATCH net 1/4] s390/qeth: handle limited IPv4 broadcast in L3 TX path

r IQD interfaces thus ended up on the wrong HW queue). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index 0271833da6a2..2df67abdfde7 100644 --- a/drivers/s39

[PATCH net 4/4] s390/qeth: handle error when updating TX queue count

netif_set_real_num_tx_queues() can return an error, deal with it. Fixes: 73dc2daf110f ("s390/qeth: add TX multiqueue support for OSA devices") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 22 -- 1 file changed, 16 insertions(+), 6 deletion

[PATCH net 2/4] s390/qeth: don't use obsolete dst entry

pe of RTN_BROADCAST. For IQD interfaces this causes us to place such skbs on the wrong HW queue, resulting in TX errors. Fix-up the various call sites to check whether the dst is obsolete, and fall back accordingly. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h| 2 +- drivers

[PATCH net 3/4] s390/qeth: fix VLAN attribute in bridge_hostnotify udev event

other OSs could register MACs with VID 0. Fixes: 9f48b9db9a22 ("qeth: bridgeport support - address notifications") Signed-off-by: Alexandra Winter Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH net 0/4] s390/qeth: fixes 2019-06-03

ssing error handling for qeth's new multiqueue code. Thanks, Julian Alexandra Winter (1): s390/qeth: fix VLAN attribute in bridge_hostnotify udev event Julian Wiedmann (3): s390/qeth: handle limited IPv4 broadcast in L3 TX path s390/qeth: don't use obsolete dst entry s390/qet

Re: [PATCH net 2/4] s390/qeth: don't use obsolete dst entry

On 03.06.19 21:43, David Miller wrote: > From: Julian Wiedmann > Date: Mon, 3 Jun 2019 17:04:44 +0200 > >> While qeth_l3 uses netif_keep_dst() to hold onto the dst, a skb's dst >> may still have been obsoleted (via dst_dev_put()) by the time that we >> end up

[PATCH v2 net 1/4] s390/qeth: handle limited IPv4 broadcast in L3 TX path

r IQD interfaces thus ended up on the wrong HW queue). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index 0271833da6a2..2df67abdfde7 100644 --- a/drivers/s39

[PATCH v2 net 3/4] s390/qeth: fix VLAN attribute in bridge_hostnotify udev event

other OSs could register MACs with VID 0. Fixes: 9f48b9db9a22 ("qeth: bridgeport support - address notifications") Signed-off-by: Alexandra Winter Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v2 net 0/4] s390/qeth: fixes 2019-06-04

attribute in bridge_hostnotify udev event Julian Wiedmann (3): s390/qeth: handle limited IPv4 broadcast in L3 TX path s390/qeth: check dst entry before use s390/qeth: handle error when updating TX queue count drivers/s390/net/qeth_core_main.c | 22 -- drivers/s390/net/qeth_l2_

[PATCH v2 net 4/4] s390/qeth: handle error when updating TX queue count

netif_set_real_num_tx_queues() can return an error, deal with it. Fixes: 73dc2daf110f ("s390/qeth: add TX multiqueue support for OSA devices") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 22 -- 1 file changed, 16 insertions(+), 6 deletion

[PATCH v2 net 2/4] s390/qeth: check dst entry before use

pe of RTN_BROADCAST. For IQD interfaces this causes us to place such skbs on the wrong HW queue, resulting in TX errors. Fix-up the various call sites to first validate the dst entry with dst_check(), and fall back accordingly. Signed-off-by: Julian Wiedmann --- v1 -> v2: prefer dst_check()

[PATCH v3 net 0/4] s390/qeth: fixes 2019-06-05

ted skbs. - Alexandra adds a sanity check when retrieving VLAN information from neighbour address events. - The last patch adds some missing error handling for qeth's new multiqueue code. Thanks, Julian Alexandra Winter (1): s390/qeth: fix VLAN attribute in bridge_hostnotify udev event Ju

[PATCH v3 net 4/4] s390/qeth: handle error when updating TX queue count

netif_set_real_num_tx_queues() can return an error, deal with it. Fixes: 73dc2daf110f ("s390/qeth: add TX multiqueue support for OSA devices") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 22 -- 1 file changed, 16 insertions(+), 6 deletion

[PATCH v3 net 1/4] s390/qeth: handle limited IPv4 broadcast in L3 TX path

r IQD interfaces thus ended up on the wrong HW queue). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index 0271833da6a2..2df67abdfde7 100644 --- a/drivers/s39

[PATCH v3 net 2/4] s390/qeth: check dst entry before use

pe of RTN_BROADCAST. For IQD interfaces this causes us to place such skbs on the wrong HW queue, resulting in TX errors. Fix-up the various call sites to first validate the dst entry with dst_check(), and fall back accordingly. Signed-off-by: Julian Wiedmann --- v1 -> v2: prefer dst_check()

[PATCH v3 net 3/4] s390/qeth: fix VLAN attribute in bridge_hostnotify udev event

other OSs could register MACs with VID 0. Fixes: 9f48b9db9a22 ("qeth: bridgeport support - address notifications") Signed-off-by: Alexandra Winter Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH net] s390/qeth: serialize cmd reply with concurrent timeout

g callback that still wants to run. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 1 + drivers/s390/net/qeth_core_main.c | 20 2 files changed, 21 insertions(+) diff --git a/drivers/s390/net/qeth_core.h b/drivers/s390/net/qeth_core.h index c7

Re: [PATCH] net: korina: remove busy skb free

On 13.12.20 18:20, Vincent Stehlé wrote: > The ndo_start_xmit() method must not attempt to free the skb to transmit > when returning NETDEV_TX_BUSY. Fix the korina_send_packet() function > accordingly. > > Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") > Signed-off-by: V

[PATCH net-next 6/6] s390/ctcm: Use GFP_ATOMIC in ctcmpc_tx().

Wiedmann Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Julian Wiedmann --- drivers/s390/net/ctcm_main.c | 2 +- drivers/s390/net/ctcm_main.h | 5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c index

[PATCH net-next 0/6] s390/ctcm: updates 2020-11-30

Hi Jakub, please apply the following patch series for ctcm to netdev's net-next tree. Some rare ctcm updates by Sebastian, who cleans up all places where in_interrupt() was used to determine the correct GFP_* mask for allocations. In the first three patches we can get rid of those allocations ent

[PATCH net-next 2/6] s390/ctcm: Avoid temporary allocation of struct qllc.

Avoid an allocation of struct qllc and use the resulting skb pointer instead. Signed-off-by: Sebastian Andrzej Siewior [jwi: remove a newline, reflow the commit msg] Signed-off-by: Julian Wiedmann --- drivers/s390/net/ctcm_mpc.c | 21 - 1 file changed, 4 insertions(+

[PATCH net-next 1/6] s390/ctcm: Avoid temporary allocation of struct th_header and th_sweep.

x27;s data part instead of using memcpy() for it. Avoid an allocation of struct th_sweep/th_header and use the resulting skb pointer instead. Signed-off-by: Sebastian Andrzej Siewior [jwi: use skb_put_zero(), instead of skb_put() + memset to 0] Signed-off-by: Julian Wiedmann --- drivers/s39

[PATCH net-next 4/6] s390/ctcm: Use explicit allocation mask in ctcmpc_unpack_skb().

argument passed by the caller, which usually knows the context. The call chain of ctcmpc_unpack_skb(): ctcmpc_bh() -> ctcmpc_unpack_skb() ctcmpc_bh() is a tasklet handler so GFP_ATOMIC is needed. Use GFP_ATOMIC as allocation type in ctcmpc_unpack_skb(). Reviewed-by: Julian Wiedmann Signed-

[PATCH net-next 3/6] s390/ctcm: Avoid temporary allocation of struct pdu.

id an allocation of struct pdu and use the resulting skb pointer instead. Signed-off-by: Sebastian Andrzej Siewior [jwi: Fix-up the pdu_offset, adjust skb->len for the pushed length. Reflow the commit msg.] Signed-off-by: Julian Wiedmann --- drivers/s390/net/ctcm_mai

[PATCH net-next 5/6] s390/ctcm: Use GFP_KERNEL in add_channel().

argument passed by the caller, which usually knows the context. The memory allocation of `ch' a few lines above is using GFP_KERNEL, also an allocation a few lines later is using GFP_KERNEL. Use GFP_KERNEL for the memory allocation. Reviewed-by: Julian Wiedmann Signed-off-by: Sebastian An

Re: [PATCH] net: 8021q: use netdev_info() instead of pr_info()

On 02.12.20 14:45, Enrico Weigelt, metux IT consult wrote: > Use netdev_info() instead of pr_info() for more consistent log output. > > Signed-off-by: Enrico Weigelt > --- > net/8021q/vlan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/8021q/vlan.c b/net/8021

[PATCH net-next] net/af_iucv: use DECLARE_SOCKADDR to cast from sockaddr

This gets us compile-time size checking. Signed-off-by: Julian Wiedmann --- net/iucv/af_iucv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index db7d888914fa..882f028992c3 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv

[PATCH net-next 2/6] s390/ccwgroup: use bus->dev_groups for bus-based sysfs attributes

GROUPS() to get rid of some boilerplate code. Signed-off-by: Julian Wiedmann Acked-by: Heiko Carstens --- drivers/s390/cio/ccwgroup.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c index 483a9ecfcbb1..444385

[PATCH net-next 5/6] s390/qeth: remove QETH_QDIO_BUF_HANDLED_DELAYED state

Reuse the QETH_QDIO_BUF_EMPTY state to indicate that a TX buffer has been completed with a QAOB notification, and may be cleaned up by qeth_cleanup_handled_pending(). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 -- drivers/s390/net/qeth_core_main.c | 5 ++--- 2

[PATCH net-next 3/6] s390/qeth: use dev->groups for common sysfs attributes

ned-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 6 ++--- drivers/s390/net/qeth_core_main.c | 7 -- drivers/s390/net/qeth_core_sys.c | 41 ++- drivers/s390/net/qeth_l2.h| 2 -- drivers/s390/net/qeth_l2_main.c | 4 +-- drivers/s390/

[PATCH net-next 4/6] s390/qeth: don't replace a fully completed async TX buffer

ration for qeth_init_qdio_out_buf(). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 89 ++- 1 file changed, 51 insertions(+), 38 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 05d0b16bd7d6..869694217

[PATCH net-next 0/6] s390/qeth: updates 2020-12-07

patch from the previous net-next submission. Thanks, Julian Julian Wiedmann (6): s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry s390/ccwgroup: use bus->dev_groups for bus-based sysfs attributes s390/qeth: use dev->groups for common sysfs attributes s390/qeth:

[PATCH net-next 6/6] s390/qeth: make qeth_qdio_handle_aob() more robust

igned-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index da27ef451d05..f4b60294a969 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers

[PATCH net-next 1/6] s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry

INIT_LIST_HEAD() only needs to be called on actual list heads. While at it clarify the naming of the field. Suggested-by: Vasily Gorbik Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 +- drivers/s390/net/qeth_core_main.c | 9 - 2 files changed, 5 insertions

Re: [PATCH net-next 0/6] s390/qeth: updates 2020-12-07

On 07.12.20 16:57, David Miller wrote: > From: Julian Wiedmann > Date: Mon, 7 Dec 2020 14:12:27 +0100 > >> Hi Jakub, >> >> please apply the following patch series for qeth to netdev's net-next tree. >> >> Some sysfs cleanups (with the prep wo

Re: [PATCH net-next 0/9] s390/qeth: updates 2020-11-17

On 19.11.20 03:35, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 17:15:11 +0100 Julian Wiedmann wrote: >> please apply the following patch series for qeth to netdev's net-next tree. >> >> This brings some cleanups, and a bunch of improvements for our >> .get_lin

[PATCH net 4/4] s390/qeth: fix tear down of async TX buffers

se it after a potential recovery has completed. The qeth_clear_output_buffer() in qeth_drain_output_queue() will ensure that it's in a clean state again. Fixes: 72861ae792c2 ("qeth: recovery through asynchronous delivery") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_cor

[PATCH net 2/4] s390/qeth: make af_iucv TX notification call more robust

Calling into socket code is ugly already, at least check whether we are dealing with the expected sk_family. Only looking at skb->protocol is bound to cause troubles (consider eg. af_packet). Fixes: b333293058aa ("qeth: add support for af_iucv HiperSockets transport") Signed-o

[PATCH net 1/4] s390/qeth: Remove pnso workaround

From: Alexandra Winter Remove workaround that supported early hardware implementations of PNSO OC3. Rely on the 'enarf' feature bit instead. Fixes: fa115adff2c1 ("s390/qeth: Detect PNSO OC3 capability") Signed-off-by: Alexandra Winter Reviewed-by: Julian Wiedmann [jwi: us

[PATCH net 3/4] s390/qeth: fix af_iucv notification race

tracking of pending transmits. Rework the notification code, so that qeth_qdio_handle_aob() defers its notification if the TX completion code is still active. Fixes: b333293058aa ("qeth: add support for af_iucv HiperSockets transport") Signed-off-by: Julian Wiedmann --- driver

[PATCH net 0/4] s390/qeth: fixes 2020-11-20

if there's any issues on their end. Thanks, Julian Alexandra Winter (1): s390/qeth: Remove pnso workaround Julian Wiedmann (3): s390/qeth: make af_iucv TX notification call more robust s390/qeth: fix af_iucv notification race s390/qeth: fix tear down of async TX buffers d

[PATCH net] net/af_iucv: set correct sk_protocol for child sockets

n skb_dump() right). Fixes: eac3731bd04c ("[S390]: Add AF_IUCV socket support") Signed-off-by: Julian Wiedmann --- net/iucv/af_iucv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 047238f01ba6..db7d888914fa 100

[PATCH net-next 6/9] s390/qeth: set static link info during initialization

uture type. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 1 + drivers/s390/net/qeth_core_main.c | 38 +++ drivers/s390/net/qeth_ethtool.c | 34 +++ 3 files changed, 42 insertions(+), 31 deletions(-) diff --git a/driver

[PATCH net-next 5/9] s390/qeth: improve QUERY CARD INFO processing

#x27; cases for SPEED_UNKNOWN, PORT_OTHER and DUPLEX_UNKNOWN. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 14 +++--- drivers/s390/net/qeth_core_main.c | 67 +--- drivers/s390/net/qeth_ethtool.c | 74 +-- 3 files changed

[PATCH net-next 8/9] s390/qeth: use QUERY OAT for initial link info

recent OSA adapter generations (where the .card_type field in QUERY CARD INFO is no longer sufficient). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 107 ++ drivers/s390/net/qeth_core_mpc.h | 40 ++- 2 files changed, 145 insertions(+), 2

[PATCH net-next 4/9] s390/qeth: tolerate error when querying card info

By the time that our .get_link_ksettings() code issues a QUERY CARD INFO cmd to get link-related information, we already set up a good amount of static link data. Return this data when the cmd fails, same as when the cmd is not supported. Signed-off-by: Julian Wiedmann --- drivers/s390/net

[PATCH net-next 0/9] s390/qeth: updates 2020-11-17

Hi Jakub, please apply the following patch series for qeth to netdev's net-next tree. This brings some cleanups, and a bunch of improvements for our .get_link_ksettings() code. Julian Wiedmann (8): s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry s390/qeth: reduce r

[PATCH net-next 9/9] s390/qeth: improve selection of ethtool link modes

ferentiate between 1baseSR and 1baseLR, use the detailed media_type information that QUERY OAT provides. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 7 ++ drivers/s390/net/qeth_core_main.c | 11 +++ drivers/s390/net/qeth_ethtool.c | 124 ++-

[PATCH net-next 1/9] s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry

INIT_LIST_HEAD() only needs to be called on actual list heads. While at it clarify the naming of the field. Suggested-by: Vasily Gorbik Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 +- drivers/s390/net/qeth_core_main.c | 9 - 2 files changed, 5 insertions

[PATCH net-next 2/9] s390/qeth: reduce rtnl locking for switchdev events

call_switchdev_notifiers() doesn't require holding the RTNL lock since commit ff5cf100110c ("net: switchdev: Change notifier chain to be atomic"). We still need it for the "lost event" slow path, to avoid racing against a concurrent .ndo_bridge_setlink(). Signed-off-by:

[PATCH net-next 3/9] s390/qeth: remove useless if/else

d-by: Tosk Robot Signed-off-by: Kaixu Xia [jwi: point to the commit that introduced this] Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_ma

[PATCH net-next 7/9] s390/qeth: clean up default cases for ethtool link mode

(ie. it's much more likely that any future link_type will represent a PORT_FIBRE link ...). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_ethtool.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/s390/net/qeth_ethtool.c b/d

[PATCH net-next] ppp: clean up endianness conversions

flavour of byte-swap. Use ntohs(), which of course gives the same result. Cc: Dmitry Kozlov Signed-off-by: Julian Wiedmann --- drivers/net/ppp/pptp.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c index ee5058445d06..0

[PATCH net-next] net: ip_tunnel: clean up endianness conversions

re.c:629:30:got restricted __be16 [usertype] The TUNNEL_* types are big-endian, so adjust the type of the local variable in ip_tun_parse_opts(). Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Signed-off-by: Julian Wiedmann --- net/ipv4/ip_tunnel_core.c | 9 + 1 file chan

Re: UBSAN: object-size-mismatch in wg_xmit

On 21.12.20 12:23, Jason A. Donenfeld wrote: > Hi Dmitry, > ... > fall on the border of a mapping? Is UBSAN non-deterministic as an > optimization? Or is there actually some mysterious UaF happening with > my usage of skbs that I shouldn't overlook? > One oddity is that wg_xmit() returns negat

[PATCH net 3/3] s390/qeth: fix L2 header access in qeth_l3_osa_features_check()

Fixes: f13ade199391 ("s390/qeth: run non-offload L3 traffic over common xmit path") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c ind

[PATCH net 0/3] s390/qeth: fixes 2021-01-07

Hi Dave & Jakub, please apply the following patch series to netdev's net tree. This brings two locking fixes for the device control path. Also one fix for a path where our .ndo_features_check() attempts to access a non-existent L2 header. Thanks, Julian Julian Wiedmann (3): s390/

[PATCH net 1/3] s390/qeth: fix deadlock during recovery

() itself is under no risk of having card->discipline ripped out while it's running, and thus doesn't need to take the discipline_mutex. Fixes: 9dc48ccc68b9 ("qeth: serialize sysfs-triggered device configurations") Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter

[PATCH net 2/3] s390/qeth: fix locking for discipline setup / removal

patch by Ursula Braun. Fixes: 9dc48ccc68b9 ("qeth: serialize sysfs-triggered device configurations") Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter --- drivers/s390/net/qeth_core_main.c | 7 +-- drivers/s390/net/qeth_l2_main.c | 5 + drivers/s390/net/qeth_l3_ma

Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with skb_cow_head for PTP

On 03.11.20 18:13, Vladimir Oltean wrote: > On Thu, Oct 29, 2020 at 10:10:56AM +0200, Claudiu Manoil wrote: >> When PTP timestamping is enabled on Tx, the controller >> inserts the Tx timestamp at the beginning of the frame >> buffer, between SFD and the L2 frame header. This means >> that the skb

[PATCH net 2/2] MAINTAINERS: remove Ursula Braun as s390 network maintainer

From: Ursula Braun I am retiring soon. Thus this patch removes myself from the MAINTAINERS file (s390 network). Signed-off-by: Ursula Braun [jwi: fix up the subject] Signed-off-by: Julian Wiedmann --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH net 0/2] net/iucv: fixes 2020-11-06

Hi Jakub, please apply the following patch series to netdev's net tree. One fix in the shutdown path for af_iucv sockets. This is relevant for stable as well. Also sending along an update for the Maintainers file. Thanks, Julian Ursula Braun (2): net/af_iucv: fix null pointer dereference on s

[PATCH net 1/2] net/af_iucv: fix null pointer dereference on shutdown

shutdown for HS transport") Reviewed-by: Vasily Gorbik Signed-off-by: Ursula Braun Signed-off-by: Julian Wiedmann --- net/iucv/af_iucv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index d80572074667..047238f01ba6 100644 ---

Re: [PATCH net 1/2] net/af_iucv: fix null pointer dereference on shutdown

On 06.11.20 18:59, Jakub Kicinski wrote: > On Fri, 6 Nov 2020 13:50:07 +0100 Julian Wiedmann wrote: >> From: Ursula Braun >> >> syzbot reported the following KASAN finding: >> >> BUG: KASAN: nullptr-dereference in iucv_send_ctrl+0x390/0x3f0 >> net/iucv/

[PATCH net v2 2/2] MAINTAINERS: remove Ursula Braun as s390 network maintainer

From: Ursula Braun I am retiring soon. Thus this patch removes myself from the MAINTAINERS file (s390 network). Signed-off-by: Ursula Braun [jwi: fix up the subject] Signed-off-by: Julian Wiedmann --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH net v2 1/2] net/af_iucv: fix null pointer dereference on shutdown

shutdown for HS transport") Reviewed-by: Vasily Gorbik Signed-off-by: Ursula Braun [jwi: correct one Fixes tag] Signed-off-by: Julian Wiedmann --- net/iucv/af_iucv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index d8057207

[PATCH net v2 0/2] net/iucv: fixes 2020-11-09

Hi Jakub, please apply the following patch series to netdev's net tree. One fix in the shutdown path for af_iucv sockets. This is relevant for stable as well. Also sending along an update for the Maintainers file. v1 -> v2: use the correct Fixes tag in patch 1 (Jakub) Thanks, Julian Ursula Bra

Re: [PATCH net v2] net: Reset MAC header for direct packet transmission

On 29.03.21 14:13, Eric Dumazet wrote: > On Mon, Mar 29, 2021 at 12:30 PM Kurt Kanzenbach wrote: >> >> On Mon Mar 29 2021, Eric Dumazet wrote: >>> Note that last year, I addressed the issue differently in commit >>> 96cc4b69581db68efc9749ef32e9cf8e0160c509 >>> ("macvlan: do not assume mac_header i

Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue

On 09.04.21 02:39, Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > The ethernet frame length is calculated incorrectly. Depending on > the value of RX_HEAD_PADDING, this may result in ethernet frames > that are too short (cut off at the end), or too long (garbage added > to the end). > >

Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue

On 14.04.21 15:19, Sven Van Asbroeck wrote: > Hi Julian, > > On Wed, Apr 14, 2021 at 8:53 AM Julian Wiedmann wrote: >> >> On a cursory glance, using __netdev_alloc_skb_ip_align() here should >> allow you to get rid of all the RX_HEAD_PADDING gymnastics. >> >&

[PATCH net-next 3/5] s390/qeth: pass proto to qeth_l3_get_cast_type()

qeth_l3_hard_start_xmit() already determined the skb's proto. Avoid doing so a second time when it calls qeth_l3_get_cast_type(). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/s39

[PATCH net-next 2/5] s390/qeth: remove qeth_get_ip_version()

statement. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 40 - drivers/s390/net/qeth_core_main.c | 18 +- drivers/s390/net/qeth_l2_main.c | 6 ++-- drivers/s390/net/qeth_l3_main.c | 60 ++- 4 files changed, 62

[PATCH net-next 4/5] s390/qeth: make cast type selection for af_iucv skbs robust

stead that does the right thing. When later building the HW header for such skbs, don't hard-code the cast type but follow the same path as for other protocol types. Here the cast type should naturally come from the skb's queue mapping. Signed-off-by: Julian Wiedmann --- d

[PATCH net-next 1/5] s390/qeth: clean up load/remove code for disciplines

We have two usage patterns: 1. get & ->setup() a new discipline, or 2. ->remove() & put the currently loaded one. Add corresponding helpers that hide the internals & error handling. Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter --- drivers/s390/net/qet

[PATCH net-next 5/5] s390/qeth: don't fake a TX completion interrupt after TX error

processing accordingly. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 34 --- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index de9d27e1c529..ea2e139cd592 10

[PATCH net-next 0/5] s390/qeth: updates 2021-01-28

Hi Dave & Jakub, please apply the following patch series for qeth to netdev's net-next tree. Nothing special, mostly fine-tuning and follow-on cleanups for earlier fixes. Thanks, Julian Julian Wiedmann (5): s390/qeth: clean up load/remove code for disciplines s390/qet

[PATCH net-next 0/5] net/iucv: updates 2021-01-28

an Alexander Egorenkov (1): net/af_iucv: remove WARN_ONCE on malformed RX packets Julian Wiedmann (4): net/af_iucv: don't lookup the socket on TX notification net/af_iucv: count packets in the xmit path net/af_iucv: don't track individual TX skbs for TRANS_HIPER sockets net/af_

[PATCH net-next 3/5] net/af_iucv: count packets in the xmit path

look at the skb list's fill level. Signed-off-by: Julian Wiedmann --- include/net/iucv/af_iucv.h | 1 + net/iucv/af_iucv.c | 30 -- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/include/net/iucv/af_iucv.h b/include/net/iucv/af_iucv.

[PATCH net-next 4/5] net/af_iucv: don't track individual TX skbs for TRANS_HIPER sockets

kbs' shinfo location) is frustratingly fragile, and breaks if the skb's head is mangled in any sort of way while passing from dev_queue_xmit() to the device's HW queue. Also adjust the interface for ->sk_txnotify(), to make clear that we don't actually care about any skb interna

[PATCH net-next 5/5] net/af_iucv: build SG skbs for TRANS_HIPER sockets

Signed-off-by: Julian Wiedmann --- net/iucv/af_iucv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 0e0656db4ae7..6092d5cb7168 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iucv.c @@ -256,7 +256,9 @@ static int afiucv

[PATCH net-next 1/5] net/af_iucv: remove WARN_ONCE on malformed RX packets

c4ab4>] system_call+0xe0/0x28c arch/s390/kernel/entry.S:415 Last Breaking-Event-Address: [<b8dc64d4>] __s390_indirect_jump_r14+0x0/0xc Malformed RX packets shouldn't generate any warnings because debugging info already flows to dropmon via the kfree_skb(). Signed-off-by: Alexander Egorenkov

[PATCH net-next 2/5] net/af_iucv: don't lookup the socket on TX notification

Whoever called iucv_sk(sk)->sk_txnotify() must already know that they're dealing with an af_iucv socket. Signed-off-by: Julian Wiedmann --- net/iucv/af_iucv.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv

Re: [PATCH net] net: lapb: Copy the skb before sending a packet

On 01.02.21 06:57, Xie He wrote: > When sending a packet, we will prepend it with an LAPB header. > This modifies the shared parts of a cloned skb, so we should copy the > skb rather than just clone it, before we prepend the header. > > In "Documentation/networking/driver.rst" (the 2nd point), it

[PATCH net 1/4] s390/qeth: fix memory leak after failed TX Buffer allocation

tput_queue(), and deal with such errors internally. Fixes: 0da9581ddb0f ("qeth: exploit asynchronous delivery of storage blocks") Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter --- drivers/s390/net/qeth_core_main.c | 35 +++ 1 file changed,

[PATCH net 3/4] s390/qeth: schedule TX NAPI on QAOB completion

storage blocks") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 3763cd6d14f8..d0a56afec028 100644 --

[PATCH net 2/4] s390/qeth: improve completion of pending TX buffers

queue list_head, and scan this list on every TX NAPI cycle. Fixes: 0da9581ddb0f ("qeth: exploit asynchronous delivery of storage blocks") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 3 +- drivers/s390/net/qeth_core_main.c | 69 +--

[PATCH net 4/4] s390/qeth: fix notification for pending buffers during teardown

completion path. Fixes: 8908f36d20d8 ("s390/qeth: fix af_iucv notification race") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_ma

[PATCH net 0/4] s390/qeth: fixes 2021-03-09

teardown path. Thanks, Julian Julian Wiedmann (4): s390/qeth: fix memory leak after failed TX Buffer allocation s390/qeth: improve completion of pending TX buffers s390/qeth: schedule TX NAPI on QAOB completion s390/qeth: fix notification for pending buffers during teardown drivers

Re: [PATCH net-next 8/8] mld: change context of mld module

On 08.02.21 18:59, Taehee Yoo wrote: > MLD module's context is atomic although most logic is called from > control-path, not data path. Only a few functions are called from > datapath, most of the functions are called from the control-path. > Furthermore, MLD's response is not processed immediately

[PATCH net-next 2/3] s390/qeth: enable napi_consume_skb() for pending TX buffers

Pending TX buffers are completed from the same NAPI code as normal TX buffers. Pass the NAPI budget to qeth_tx_complete_buf() so that the freeing of the completed skbs can be deferred. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 8 1 file changed, 4

[PATCH net-next 1/3] s390/qeth: allocate initial TX Buffer structs with GFP_KERNEL

name. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index a814698387bc..abd1e49cf97a 100644 --- a/drivers/s390/net/qeth_core_ma

[PATCH net-next 3/3] s390/qeth: remove RX VLAN filter stubs in L3 driver

The callbacks have been slimmed down to a level where they no longer do any actual work. So stop pretending that we support the NETIF_F_HW_VLAN_CTAG_FILTER feature. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l3_main.c | 25 + 1 file changed, 1 insertion

[PATCH net-next 0/3] s390/qeth: updates 2021-03-18

Hi Dave & Jakub, please apply the following patch series for qeth to netdev's net-next tree. This brings two small optimizations (replace a hard-coded GFP_ATOMIC, pass through the NAPI budget to enable napi_consume_skb()), and removes some redundant VLAN filter code. Thanks, Julia

[PATCH net-next 01/13] s390/qeth: don't mask TX errors on IQD devices

ssion make no sense anymore. Remove it. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index b1823d75dd35..cd9e2f70d8f6 100644 --- a/driver

[PATCH net-next 08/13] s390/qeth: convert device-specific trace entries

The vast majority of SETUP-classified trace entries can be moved to their device-specific trace file. This reduces pollution of the global SETUP file, and provides a consistent trace view of all activity on the device. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 196

[PATCH net-next 11/13] s390/qeth: convert RCD code to common IO infrastructure

annel, use the new qeth_alloc_cmd() helper. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 - drivers/s390/net/qeth_core_main.c | 132 +++--- drivers/s390/net/qeth_core_mpc.h | 2 - 3 files changed, 46 insertions(+), 90 deletions(-) diff --

[PATCH net-next 04/13] s390/qeth: restart pending READ cmd from callback

: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index feb9e1c9d506..fade84112e80 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net

[PATCH net-next 13/13] s390/qeth: allocate a single cmd on read channel

d can survive the IO completion. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 7 drivers/s390/net/qeth_core_main.c | 54 ++- drivers/s390/net/qeth_l2_main.c | 1 - drivers/s390/net/qeth_l3_main.c | 1 - 4 files changed, 39 insertions(+

[PATCH net-next 07/13] s390/qeth: remove OSN-specific IO code

the cmd has been successfully submitted to HW. Since the callback then immediately wakes up the reply-waiter object, we maintain the old behaviour of returning early without waiting for the response. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 1 + drivers/s390/

[PATCH net-next 12/13] s390/qeth: command-chain the IDX sequence

The current IDX sequence first sends one WRITE cmd to activate the device, and then sends a second cmd that READs the response. Using qeth_alloc_cmd(), we can combine this into a single IO with two command-chained CCWs. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 58

  1   2   3   4   5   6   7   >