Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > > Jarod Wilson wrote: > > > > >This comes from an end-user request, where they're running multiple VMs on > > >hosts with bonded

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Tue, Jan 12, 2021 at 01:39:10PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > >> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > >> > Jarod Wilson wrote: > >&

[PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-13 Thread Jarod Wilson
lav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink interfaces working, added Documentation, changed tx hash mode name to vlan+mac for consistency and clarity. Docume

[PATCH iproute2] bond: support xmit_hash_policy=vlan+mac

2021-01-13 Thread Jarod Wilson
width|count Cc: Stephen Hemminger Cc: Jay Vosburgh Signed-off-by: Jarod Wilson --- ip/iplink_bond.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c index 585b6be1..b9470b98 100644 --- a/ip/iplink_bond.c +++ b/ip/iplink_bond.c @@ -70,6

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > > This comes from an end-user request, where they're running multiple VMs on > > hosts with bonded interfaces connected to some interest switch topologie

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:23:14PM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 16:11:41 -0500 Jarod Wilson wrote: > > In truth, this code started out as a copy of bond_eth_hash(), which also > > only uses the last byte, though of both source and destination macs. In > >

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-15 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:54:31PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > >> On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > >> > This comes from an end-user request, w

Re: [PATCH iproute2] bond: support xmit_hash_policy=vlan+mac

2021-01-15 Thread Jarod Wilson
On Wed, Jan 13, 2021 at 06:41:17PM -0500, Jarod Wilson wrote: > There's a new transmit hash policy being added to the bonding driver that > is a simple XOR of vlan ID and source MAC, xmit_hash_policy vlan+mac. This > trivial patch makes it configurable and queryable via iproute

[PATCH iproute2 v2] bond: support xmit_hash_policy=vlan+srcmac

2021-01-15 Thread Jarod Wilson
table|bandwidth|count Cc: Stephen Hemminger Cc: Jay Vosburgh Signed-off-by: Jarod Wilson --- ip/iplink_bond.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c index 585b6be1..b9470b98 100644 --- a/ip/iplink_bond.c +++ b/ip/iplink_b

[PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-15 Thread Jarod Wilson
atch for iproute2 is also posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink inte

Re: [PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
On Mon, Jan 18, 2021 at 04:10:38PM -0700, David Ahern wrote: > On 1/15/21 12:21 PM, Jarod Wilson wrote: > > diff --git a/Documentation/networking/bonding.rst > > b/Documentation/networking/bonding.rst > > index adc314639085..36562dcd3e1e 100644 > > --- a/Documenta

[PATCH net-next v4] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
atch for iproute2 is also posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink inte

[RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2020-12-18 Thread Jarod Wilson
Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 27 +-- drivers/net/bonding/bond_options.c |

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-18 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: ... > >The addition of a case BOND_LINK_BACK in bond_miimon_commit() is somewhat > >separate from the fix for the actual hang, but it eliminates a constant > >"invalid new link 3 on slave&

[PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
van Vecera Suggested-by: Ivan Vecera Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 10 -- drivers/net/bon

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > + if (bond->dev->reg_state != NETREG_REGISTERED) > > + goto noreg; > > + > > if (newval->value == BOND_MODE_AC

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 12:55 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Don't try to adjust XFRM support flags if the bond device isn't yet > >registered. Bad things can currently happen when netdev_change_features() > >is called without havin

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 2:23 PM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 14:03:53 -0500 Jarod Wilson wrote: > > On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > > > > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > > > + if

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 3:17 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >On Wed, Dec 2, 2020 at 12:55 PM Jay Vosburgh > >wrote: > >> > >> Jarod Wilson wrote: > >> > >> >Don't try to adjust XFRM support flags if the bond d

[PATCH net v3] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
avid S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 10 -- drivers/net/bonding/bond_options.c | 19 ++- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/d

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-03 Thread Jarod Wilson
On Thu, Dec 3, 2020 at 11:50 AM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 19:43:57 -0500 Jarod Wilson wrote: > > bond_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4; > > -#ifdef CONFIG_XFRM_OFFLOAD > > - bond_dev->hw_features |= B

[PATCH net-next] bonding: set xfrm feature flags more sanely

2020-12-05 Thread Jarod Wilson
quot;David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bo

[PATCH net v4] bonding: fix feature flag setting at init time

2020-12-05 Thread Jarod Wilson
uot;) Reported-by: Ivan Vecera Suggested-by: Ivan Vecera Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: rework based on further testing and suggestions from

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-05 Thread Jarod Wilson
bond_dev->wanted_features |= BOND_XFRM_FEATURES; > + else > + bond_dev->wanted_features &= ~BOND_XFRM_FEATURES; > + > + netdev_update_features(bond_dev); > +} > > (Assuming BOND_XFRM_FEATURES doesn't itself hide under an ifdef.) It is, but doesn't need to be. I can mix these changes in as well. -- Jarod Wilson ja...@redhat.com

[PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-05 Thread Jarod Wilson
avid S. Miller" CC: Jakub Kicinski CC: Thomas Davis CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 26 ++ include/net/bonding.h | 38 + 2 files changed, 44 insertions(+), 20 deletions(

Re: LRO: creating vlan subports affects parent port's LRO settings

2020-12-05 Thread Jarod Wilson
at all other upper devices this excludes besides just vlan ports though, so perhaps safer add upper device types to not do feature sync on than to choose which ones to do them on? -- Jarod Wilson ja...@redhat.com

Re: LRO: creating vlan subports affects parent port's LRO settings

2020-12-06 Thread Jarod Wilson
On Sun, Dec 6, 2020 at 11:49 AM Michal Kubecek wrote: > > On Sat, Dec 05, 2020 at 07:04:06PM -0500, Jarod Wilson wrote: > > On Mon, Nov 23, 2020 at 7:27 PM Jakub Kicinski wrote: > > > > > > On Thu, 19 Nov 2020 20:37:27 -0500 Limin Wang wrote: > > >

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-09 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 2:38 PM Jakub Kicinski wrote: > > On Sat, 5 Dec 2020 18:43:54 -0500 Jarod Wilson wrote: > > I'm seeing a system get stuck unable to bring a downed interface back up > > when it's got an updelay value set, behavior which ceased when loggi

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-09 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >I'm seeing a system get stuck unable to bring a downed interface back up > >when it's got an updelay value set, behavior which ceased when logging > >spew was removed from bond_

[PATCH net] bonding: fix feature flag setting at init time

2020-11-22 Thread Jarod Wilson
urgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 10 -- drivers/net/bonding/bond_options.c | 14 +++--- 2 files

Re: [PATCH net-next v4 0/5] bonding: rename bond components

2020-11-22 Thread Jarod Wilson
On Wed, Nov 11, 2020 at 5:04 PM Jakub Kicinski wrote: > > On Wed, 11 Nov 2020 12:13:56 -0800 Jay Vosburgh wrote: > > Jarod Wilson wrote: > > > > >The bonding driver's use of master and slave, while largely understood > > >in technical circles, poses

Re: [PATCH net-next v4 0/5] bonding: rename bond components

2020-11-09 Thread Jarod Wilson
On Fri, Nov 6, 2020 at 9:44 PM Jakub Kicinski wrote: > > On Fri, 6 Nov 2020 15:04:31 -0500 Jarod Wilson wrote: > > The bonding driver's use of master and slave, while largely understood > > in technical circles, poses a barrier for inclusion to some potential > > m

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
nsider using team driver instead ? :) That's actually one of the things that was suggested, since team I believe already has support for this, but the user really wants to use bonding. We're finding that a lot of users really still prefer bonding over team. -- Jarod Wilson ja...@redhat.com

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >This comes from an end-user request, where they're running multiple VMs on > >hosts with bonded interfaces connected to some interest switch topologies, > >where 802.3ad isn&#

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-08 Thread Jarod Wilson
b w/o team's userspace footprint". I think this one is kind of hard for team to do anything about, bonding really does have a smaller userspace footprint, which is a plus for embedded type applications and high-security environments looking to keep things as minimal as possible. I think I've heard a few "we tried team years ago and it didn't work" as well, which of course is ridiculous as a reason not to try something again, since a lot can change in a few years in this world. -- Jarod Wilson ja...@redhat.com

[PATCH net-next v4 0/5] bonding: rename bond components

2020-11-06 Thread Jarod Wilson
Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Jarod Wilson (5): bonding: rename 802.3ad's struct port to ad_port bonding: replace use of the term master where possible bonding: rename

[PATCH 2/5] bonding: replace use of the term master where possible

2020-11-06 Thread Jarod Wilson
vid S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/lag.c | 2 +- drivers/infiniband/core/roce_gid_mgmt.c | 6 +-

[PATCH 1/5] bonding: rename 802.3ad's struct port to ad_port

2020-11-06 Thread Jarod Wilson
Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_3ad.c | 1307 drivers/net/bonding/bond_main.c|4 +- drivers/net/bon

[PATCH 5/5] bonding: update Documentation for port/bond terminology

2020-11-06 Thread Jarod Wilson
at it, also make some mention of NetworkManager's existence. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networki

[PATCH 4/5] bonding: rename bonding_sysfs_slave.c to _port.c

2020-11-06 Thread Jarod Wilson
Now that use of "slave" has been replaced by "port", rename this file too. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson ---

[PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-12 Thread Jarod Wilson
tialize wdev_id to 0, since it's value doesn't otherwise matter unless have_wdev_id is true. Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") CC: Johannes Berg CC: "David S. Miller" CC: Jakub Kicinski CC: linux-wirel...@vger.kernel.org CC:

Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-15 Thread Jarod Wilson
On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo wrote: > > Jarod Wilson writes: > > > Build currently fails with -Werror=maybe-uninitialized set: > > > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > > net/wireless/nl80211.c:124:44: err

Re: [RFC] bonding driver terminology change proposal

2020-08-12 Thread Jarod Wilson
On Thu, Jul 16, 2020 at 1:43 AM Jarod Wilson wrote: > > On Wed, Jul 15, 2020 at 11:18 PM Andrew Lunn wrote: ... > > I really think that before we consider changes like this, somebody > > needs to work on git tooling, so that it knows when mass renames have > > happened,

[PATCH net] bonding: show saner speed for broadcast mode

2020-08-12 Thread Jarod Wilson
etdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 5ad43aaf76e5..c853ca67058c 100644 --- a/drivers/ne

Re: [PATCH net] bonding: show saner speed for broadcast mode

2020-08-13 Thread Jarod Wilson
On Thu, Aug 13, 2020 at 1:30 AM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Broadcast mode bonds transmit a copy of all traffic simultaneously out of > >all interfaces, so the "speed" of the bond isn't really the aggregate of > >all interfaces,

[PATCH net v2] bonding: show saner speed for broadcast mode

2020-08-13 Thread Jarod Wilson
etdev@vger.kernel.org Acked-by: Jay Vosburgh Signed-off-by: Jarod Wilson --- v2: fix description to clarify speed == that of slowest active interface drivers/net/bonding/bond_main.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/bondin

[PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-10 Thread Jarod Wilson
should be left to the arp_interval code, so we can just make things much tidier here. Fixes: 3fe68df97c7f ("bonding: always set recv_probe to bond_arp_rcv in arp monitor") CC: Jay Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: netdev@vger.kernel.o

Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-10 Thread Jarod Wilson
On 5/10/19 6:53 PM, Jay Vosburgh wrote: Jarod Wilson wrote: There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=192.168.1

[PATCH net-next v3 1/5] bonding: rename 802.3ad's struct port to ad_port

2020-10-07 Thread Jarod Wilson
Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_3ad.c | 1307 drivers/net/bonding/bond_main.c|4 +- drivers/net/bon

[PATCH net-next v3 0/5] bonding: rename bond components

2020-10-07 Thread Jarod Wilson
Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Jarod Wilson (5): bonding: rename 802.3ad's struct port to ad_port bonding: replace use of the term master where possible bonding: rename slave to port where possible bonding: renam

[PATCH net-next v3 2/5] bonding: replace use of the term master where possible

2020-10-07 Thread Jarod Wilson
vid S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/lag.c | 2 +- drivers/infiniband/core/roce_gid_mgmt.c | 6 +-

[PATCH net-next v3 4/5] bonding: rename bonding_sysfs_slave.c to _port.c

2020-10-07 Thread Jarod Wilson
Now that use of "slave" has been replaced by "port", rename this file too. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson ---

[PATCH net-next v3 5/5] bonding: update Documentation for port/bond terminology

2020-10-07 Thread Jarod Wilson
at it, also make some mention of NetworkManager's existence. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networki

Re: [PATCH net-next v3 5/5] bonding: update Documentation for port/bond terminology

2020-10-07 Thread Jarod Wilson
On Wed, Oct 7, 2020 at 2:14 PM Jarod Wilson wrote: > > Swap in port/bond terminology where appropriate, leaving all legacy sysfs > and procfs interface mentions in place, but marked as deprecated. > Additionally, add more netlink/iproute2 documentation, and note that this > i

[RFC] bonding driver terminology change proposal

2020-07-13 Thread Jarod Wilson
work-in-progress adaptation from master/slave to bundle/cable has a diffstat that is currently summarized as: 37 files changed, 2607 insertions(+), 2571 deletions(-) -- Jarod Wilson ja...@redhat.com

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 5:36 PM Eric Dumazet wrote: > > On 7/13/20 11:51 AM, Jarod Wilson wrote: > > As part of an effort to help enact social change, Red Hat is > > committing to efforts to eliminate any problematic terminology from > > any of the software that it ships

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 6:00 PM Michal Kubecek wrote: > > On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: > > To start out with, I'd like to attempt to eliminate as much of the use > > of master and slave in the bonding driver as possible. For the most > &

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 8:55 PM Jay Vosburgh wrote: > > Stephen Hemminger wrote: > > >On Tue, 14 Jul 2020 00:00:16 +0200 > >Michal Kubecek wrote: > > > >> On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: > >> > To start out with, I&#

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Tue, Jul 14, 2020 at 4:39 PM Marcelo Ricardo Leitner wrote: > > On Tue, Jul 14, 2020 at 09:17:48PM +0200, Toke Høiland-Jørgensen wrote: > > Jarod Wilson writes: > > > > > As part of an effort to help enact social change, Red Hat is > > > committing to

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
mpact ongoing use of terms like "slave" might have on people that are actual descendants of slavery. Embracing and helping move forward social change seems like a responsible thing to do here, as long as we can do it without breaking the kernel and UAPI. -- Jarod Wilson ja...@redhat.com

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
hen straight cherry-picking. Dumping the patches, running a sed script over them, and then git am'ing them works pretty well though. I didn't try 4.19 (yet?), I assume it'll just be more of the same. -- Jarod Wilson ja...@redhat.com

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
tion here. Does the output of /proc/net/bonding/ fall under that umbrella as well? I'm sure there are people that do parse it for monitoring, and thus I assume that it does, but want to be certain. I think this is the only remaining thing I need to address in a local test conversion build. -- Jarod Wilson ja...@redhat.com

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
On Wed, Jul 15, 2020 at 11:18 PM Andrew Lunn wrote: > > On Wed, Jul 15, 2020 at 11:04:16PM -0400, Jarod Wilson wrote: > > On Mon, Jul 13, 2020 at 8:26 PM Andrew Lunn wrote: > > > > > > Hi Jarod > > > > > > Do you have this change scripted? Could yo

[PATCH net-next 0/5] bonding: rename bond components

2020-09-22 Thread Jarod Wilson
've manually operated on various bonds while working on this code, and have run it through multiple lnst test runs, which exercises the existing sysfs interfaces fairly extensively. As far as I can tell, there is no breakage of existing interfaces with this set, unless the user consciously opt

[PATCH net-next 5/5] bonding: update Documentation for link/aggregator terminology

2020-09-22 Thread Jarod Wilson
eslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networking/bonding.rst | 440 +-- 1 file changed, 220 insertions(+), 220 deletions(-

[PATCH net-next 1/5] bonding: rename struct slave member link to link_state

2020-09-22 Thread Jarod Wilson
Necessary prep work to recycle the name "link" as a replacement for "slave" in bonding driver terminology. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-

[PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Jarod Wilson
cinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/Kconfig | 12 drivers/net/bonding/bond_options.c| 4 ++-- drivers/net/bonding/bond_procfs.c | 14 ++ drivers/net/bonding/bond_sysfs.c

[PATCH net-next 3/5] bonding: rename master to aggregator where possible

2020-09-22 Thread Jarod Wilson
Getting rid of as much usage of "master" as we can here, without breaking any user-facing API. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson ---

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Jarod Wilson
On Tue, Sep 22, 2020 at 9:38 AM Jarod Wilson wrote: > > By default, enable retaining all user-facing API that includes the use of > master and slave, but add a Kconfig knob that allows those that wish to > remove it entirely do so in one shot. > diff --git a/drivers/net/bonding/bon

Re: [RFC PATCH] bonding: linkdesc can be static

2020-09-23 Thread Jarod Wilson
static const char *linkdesc = "Slave"; > #else > const char *linkdesc = "Link"; > #endif Good attempt, robot, but you missed the #else. Will fold a full version into my set. -- Jarod Wilson ja...@redhat.com

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-23 Thread Jarod Wilson
On Tue, Sep 22, 2020 at 8:01 PM Stephen Hemminger wrote: > > On Tue, 22 Sep 2020 16:47:07 -0700 > Jay Vosburgh wrote: > > > Stephen Hemminger wrote: > > > > >On Tue, 22 Sep 2020 09:37:30 -0400 > > >Jarod Wilson wrote: > > > > > >>

Re: [PATCH net-next 2/5] bonding: rename slave to link where possible

2020-09-25 Thread Jarod Wilson
ar means as num_grat_arp and num_unsol_na use currently. -- Jarod Wilson ja...@redhat.com

Re: [PATCH net-next 0/5] bonding: rename bond components

2020-09-25 Thread Jarod Wilson
On Tue, Sep 22, 2020 at 6:19 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >The bonding driver's use of master and slave, while largely understood > >in technical circles, poses a barrier for inclusion to some potential > >members of the development and user

[PATCH net-next v2 0/6] bonding: rename bond components

2020-10-02 Thread Jarod Wilson
The procfs interface legacy output is also duplicated or dropped, depending on Kconfig, rather than being replaced. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Jarod Wilson (6): bon

[PATCH net-next v2 1/6] bonding: rename 802.3ad's struct port to ad_port

2020-10-02 Thread Jarod Wilson
Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_3ad.c | 1307 drivers/net/bonding/bond_main.c|4 +- drivers/net/bon

[PATCH net-next v2 2/6] bonding: replace use of the term master where possible

2020-10-02 Thread Jarod Wilson
vid S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/lag.c | 2 +- drivers/infiniband/core/roce_gid_mgmt.c | 6 +-

[PATCH net-next v2 4/6] bonding: rename bonding_sysfs_slave.c to _port.c

2020-10-02 Thread Jarod Wilson
Now that use of "slave" has been replaced by "port", rename this file too. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson ---

[PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
eslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networking/bonding.rst | 440 +-- 1 file changed, 220 insertions(+), 220 deletions(-

[PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread Jarod Wilson
cinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/Kconfig | 12 drivers/net/bonding/bond_main.c | 4 ++-- drivers/net/bonding/bond_options.c| 4 ++-- drivers/net/bonding/bond_procfs.c | 8 drivers/n

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 3:11 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 13:40:00 -0400 > Jarod Wilson wrote: > > > @@ -265,7 +265,7 @@ ad_user_port_key > > This parameter has effect only in 802.3ad mode and is available > > thr

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 2:09 PM Andrew Lunn wrote: > > On Fri, Oct 02, 2020 at 01:40:00PM -0400, Jarod Wilson wrote: > > Point users to the new interface names instead of the old ones, where > > appropriate. Userspace bits referenced still include use of master/slave, >

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 13:40:01 -0400 > Jarod Wilson wrote: > > > By default, enable retaining all user-facing API that includes the use of > > master and slave, but add a Kconfig knob that allows those that wish t

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:55 PM David Miller wrote: > > From: Jarod Wilson > Date: Fri, 2 Oct 2020 16:12:49 -0400 > > > The documentation was updated to point to the new names, but the old > > ones still exist across the board, there should be no userspace > > b

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:57 PM David Miller wrote: > > From: Jarod Wilson > Date: Fri, 2 Oct 2020 16:23:46 -0400 > > > I'd had a bit of feedback that people would rather see both, and be > > able to toggle off the old ones, rather than only having one or the >

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:42 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 16:23:46 -0400 > Jarod Wilson wrote: > > > On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger > > wrote: > > > > > > On Fri, 2 Oct 2020 13:40:01 -0400 > > > Ja

[PATCH net-next] bonding/xfrm: use real_dev instead of slave_dev

2020-06-23 Thread Jarod Wilson
ub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org Suggested-by: Saeed Mahameed Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 6 +-- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 47 +-- .../mellanox/mlx5/core/en_accel/ips

[PATCH net-next 2/4] ixgbe_ipsec: become aware of when running as a bonding slave

2020-06-08 Thread Jarod Wilson
quot; CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-

[PATCH net-next 3/4] bonding: support hardware encryption offload to slaves

2020-06-08 Thread Jarod Wilson
rt CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson Signed-off-by: Jarod Wilson --- drivers/net/Kconfig | 11 drivers/net/bonding/bond_main.c | 111 +++- include/net/bonding.h

[PATCH net-next 4/4] mlx5: become aware of when running as a bonding slave

2020-06-08 Thread Jarod Wilson
h CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 6 ++ 1 file change

[PATCH net-next 1/4] xfrm: bail early on slave pass over skb

2020-06-08 Thread Jarod Wilson
CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- include/net/xfrm.h | 1 + net/xfrm/xfrm_dev

Re: [PATCH net-next 3/4] bonding: support hardware encryption offload to slaves

2020-06-08 Thread Jarod Wilson
On Mon, Jun 8, 2020 at 7:48 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Currently, this support is limited to active-backup mode, as I'm not sure > >about the feasilibity of mapping an xfrm_state's offload handle to > >multiple hardware devices simu

Re: [PATCH V7 mlx5-next 00/16] Add support to get xmit slave

2020-05-04 Thread Jarod Wilson
> The third part change the mlx5 driver driver to set the QP's affinity > port according to the slave which found by the .ndo. At a glance, I'm not sure why all the "get the xmit slave" functions are being passed an skb. None of them should be manipulating the skb, that sh

[RFC PATCH net-next 0/3] bonding: support hardware crypto offload

2020-05-04 Thread Jarod Wilson
'm hoping folks with more of an idea about xfrm have some thoughts on ways to make this cleaner, and possibly support more bonding modes, but I'm reasonably happy I've made it this far. :) Jarod Wilson (3): xfrm: bail early on slave pass over skb ixgbe_ipsec: become aware

[RFC PATCH net-next 3/3] bonding: support hardware encryption offload to slaves

2020-05-04 Thread Jarod Wilson
id-netperf. CC: Jay Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- drivers

[RFC PATCH net-next 1/3] xfrm: bail early on slave pass over skb

2020-05-04 Thread Jarod Wilson
CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- include/net/xfrm.h | 1 + net/xfrm/xfrm_dev

[RFC PATCH net-next 2/3] ixgbe_ipsec: become aware of when running as a bonding slave

2020-05-04 Thread Jarod Wilson
quot; CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-

Re: [PATCH V7 mlx5-next 00/16] Add support to get xmit slave

2020-05-04 Thread Jarod Wilson
On Mon, May 4, 2020 at 10:42 AM David Ahern wrote: > > On 5/4/20 8:36 AM, Jarod Wilson wrote: > > At a glance, I'm not sure why all the "get the xmit slave" functions > > are being passed an skb. None of them should be manipulating the skb, > > that sh

[RFC PATCH net-next v2 2/3] ixgbe_ipsec: become aware of when running as a bonding slave

2020-05-05 Thread Jarod Wilson
quot; CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-

[RFC PATCH net-next v2 3/3] bonding: support hardware encryption offload to slaves

2020-05-05 Thread Jarod Wilson
lists.osuosl.org Signed-off-by: Jarod Wilson Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 111 +++- include/net/bonding.h | 3 + 2 files changed, 111 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers

[RFC PATCH net-next v2 0/3] bonding: support hardware crypto offload

2020-05-05 Thread Jarod Wilson
nding changes CC: Jay Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: netdev@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Jarod Wilson (3): xfrm: bail early on slave pass

  1   2   3   4   >