On Fri, Oct 2, 2020 at 3:11 PM Stephen Hemminger <step...@networkplumber.org> wrote: > > On Fri, 2 Oct 2020 13:40:00 -0400 > Jarod Wilson <ja...@redhat.com> wrote: > > > @@ -265,7 +265,7 @@ ad_user_port_key > > This parameter has effect only in 802.3ad mode and is available > > through > > SysFs interface. > > > > -all_slaves_active > > +all_ports_active > > You can change internal variable names, comments, and documentation all you > want, thats great. > > But you can't change user API, that includes: > * definitions in uapi header > * module parameters > * sysfs file names or outputs
All of those are retained by default here in this set. There are 0 changes to the if_bonding.h uapi header, module parameters with 'port' in them have duplicates with the old terminology included, and all sysfs file names are duplicated (or aliased) as well. The documentation was updated to point to the new names, but the old ones still exist across the board, there should be no userspace breakage here. (My lnst bonding tests actually fall flat currently if the old names are gone). -- Jarod Wilson ja...@redhat.com
