Re: [PATCH net 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-22 Thread Jiri Pirko
Wed, May 22, 2024 at 05:45:48AM CEST, hen...@linux.alibaba.com wrote: >This reverts commit 4d4ac2ececd3c42a08dd32a6e3a4aaf25f7efe44. This commit does not exist in -net or -net-next. > >When the following snippet is run, lockdep will complain[1]. > > /* Acquire all queues dim_locks */ > for (i =

Re: [PATCH net 1/2] virtio_net: fix possible dim status unrecoverable

2024-05-22 Thread Jiri Pirko
Wed, May 22, 2024 at 05:45:47AM CEST, hen...@linux.alibaba.com wrote: >When the dim worker is scheduled, if it no longer needs to issue >commands, dim may not be able to return to the working state later. > >For example, the following single queue scenario: > 1. The dim worker of rxq0 is scheduled

Re: [PATCH net 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-22 Thread Heng Qi
On Wed, 22 May 2024 10:15:46 +0200, Jiri Pirko wrote: > Wed, May 22, 2024 at 05:45:48AM CEST, hen...@linux.alibaba.com wrote: > >This reverts commit 4d4ac2ececd3c42a08dd32a6e3a4aaf25f7efe44. > > This commit does not exist in -net or -net-next. It definitely exists in net-next :): https://git.ker

Re: [PATCH net 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2024 at 04:52:19PM +0800, Heng Qi wrote: > On Wed, 22 May 2024 10:15:46 +0200, Jiri Pirko wrote: > > Wed, May 22, 2024 at 05:45:48AM CEST, hen...@linux.alibaba.com wrote: > > >This reverts commit 4d4ac2ececd3c42a08dd32a6e3a4aaf25f7efe44. > > > > This commit does not exist in -net

Re: [PATCH net 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-22 Thread Heng Qi
On Wed, 22 May 2024 05:44:43 -0400, "Michael S. Tsirkin" wrote: > On Wed, May 22, 2024 at 04:52:19PM +0800, Heng Qi wrote: > > On Wed, 22 May 2024 10:15:46 +0200, Jiri Pirko wrote: > > > Wed, May 22, 2024 at 05:45:48AM CEST, hen...@linux.alibaba.com wrote: > > > >This reverts commit 4d4ac2ececd3

Re: [PATCH net 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-22 Thread Jiri Pirko
Wed, May 22, 2024 at 10:52:19AM CEST, hen...@linux.alibaba.com wrote: >On Wed, 22 May 2024 10:15:46 +0200, Jiri Pirko wrote: >> Wed, May 22, 2024 at 05:45:48AM CEST, hen...@linux.alibaba.com wrote: >> >This reverts commit 4d4ac2ececd3c42a08dd32a6e3a4aaf25f7efe44. >> >> This commit does not exist

Re: [PATCH net-next 0/7] virtnet_net: prepare for af-xdp

2024-05-22 Thread Xuan Zhuo
Any comments for this. Thanks. On Wed, 8 May 2024 16:05:07 +0800, Xuan Zhuo wrote: > This patch set prepares for supporting af-xdp zerocopy. > There is no feature change in this patch set. > I just want to reduce the patch num of the final patch set, > so I split the patch set. > > #1-#3 add i