Re: [RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-12 Thread René van Dorst
Hi Qingfang, Quoting DENG Qingfang : Add support for MediaTek PHYs found in MT7530 and MT7531 switches. The initialization procedure is from the vendor driver, but due to lack of documentation, the function of some register values remains unknown. Signed-off-by: DENG Qingfang --- RFC v3 -> RF

Re: [syzbot] KMSAN: uninit-value in INET_ECN_decapsulate (2)

2021-04-12 Thread Eric Dumazet
On 3/30/21 3:26 PM, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:29ad81a1 arch/x86: add missing include to sparsemem.h > git tree: https://github.com/google/kmsan.git master > console output: https://syzkaller.appspot.com/x/log.txt?x=166fe481d0

Re: BUG: unable to handle kernel paging request in bpf_check

2021-04-12 Thread Hao Sun
Besides, another similar bug occurred while fault injection was enabled. BUG: unable to handle kernel paging request in bpf_prog_alloc_no_stats RAX: ffda RBX: 0059c080 RCX: 0047338d RDX: 0078 RSI:

Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-12 Thread Jason Wang
在 2021/4/9 下午4:02, Yongji Xie 写道: +}; + +struct vduse_dev_config_data { + __u32 offset; /* offset from the beginning of config space */ + __u32 len; /* the length to read/write */ + __u8 data[VDUSE_CONFIG_DATA_LEN]; /* data buffer used to read/write */ Note that since VDUSE_CONFIG_

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:42:15AM -0500, Alex Elder wrote: > On 4/11/21 8:28 AM, Leon Romanovsky wrote: > >> I think *not* checking an available return value is questionable > >> practice. I'd really rather have a build option for a > >> "__need_not_check" tag and have "must_check" be the default

[PATCH v1 2/2] Bluetooth: Support the vendor specific debug events

2021-04-12 Thread Joseph Hwang
This patch allows a user space process to enable/disable the vendor specific (vs) debug events dynamically through the set experimental feature mgmt interface if CONFIG_BT_FEATURE_VS_DBG_EVT is enabled. Since the debug event feature needs to invoke the callback function provided by the driver, i.e

Re: [PATCH net-next 4/5] bnxt_en: Refactor __bnxt_vf_reps_destroy().

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:18:14PM -0400, Michael Chan wrote: > Add a new helper function __bnxt_free_one_vf_rep() to free one VF rep. > We also reintialize the VF rep fields to proper initial values so that > the function can be used without freeing the VF rep data structure. This > will be used

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-12 Thread Leon Romanovsky
On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote: > On Thu, Apr 8, 2021 at 5:14 PM Leon Romanovsky wrote: > > > > On Thu, Apr 08, 2021 at 05:06:24PM +0530, Devesh Sharma wrote: > > > On Sat, Apr 3, 2021 at 5:12 PM Leon Romanovsky wrote: > > > > > > > > On Sat, Apr 03, 2021 at 03:52:1

Re: [PATCH net-next v2 2/3] net: use skb_for_each_frag() helper where possible

2021-04-12 Thread Eric Dumazet
On 4/12/21 2:38 AM, Matteo Croce wrote: > From: Matteo Croce > > use the new helper macro skb_for_each_frag() which allows to iterate > through all the SKB fragments. > > The patch was created with Coccinelle, this was the semantic patch: > > @@ > struct sk_buff *skb; > identifier i; > state

[PATCH net-next] ibmvnic: clean up the remaining debugfs data structures

2021-04-12 Thread Lijun Pan
Commit e704f0434ea6 ("ibmvnic: Remove debugfs support") did not clean up everything. Remove the remaining code. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.h | 94 -- 1 file changed, 94 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b

[PATCH net-next 1/2] ibmvnic: print reset reason as a string

2021-04-12 Thread Lijun Pan
The reset reason can be added or deleted over different versions of the source code. Print a string instead of a number. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 35 -- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/drivers/net

[PATCH net-next 0/2] ibmvnic: improve error printing

2021-04-12 Thread Lijun Pan
Patch 1 prints reset reason as a string. Patch 2 prints adapter state as a string. Lijun Pan (2): ibmvnic: print reset reason as a string ibmvnic: print adapter state as a string drivers/net/ethernet/ibm/ibmvnic.c | 98 +++--- 1 file changed, 75 insertions(+), 23 dele

[PATCH net-next 2/2] ibmvnic: print adapter state as a string

2021-04-12 Thread Lijun Pan
The adapter state can be added or deleted over different versions of the source code. Print a string instead of a number. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 67 ++ 1 file changed, 49 insertions(+), 18 deletions(-) diff --git a/drivers/n

[PATCH net-next 0/2] ibmvnic: sysfs changes

2021-04-12 Thread Lijun Pan
Patch 1 improves the failover sysfs entry. Patch 2 adds sysfs entry for timeout and fatal resets. Lijun Pan (2): ibmvnic: improve failover sysfs entry ibmvnic: add sysfs entry for timeout and fatal reset drivers/net/ethernet/ibm/ibmvnic.c | 56 +++--- 1 file changed,

[PATCH net-next 1/2] ibmvnic: improve failover sysfs entry

2021-04-12 Thread Lijun Pan
The current implementation replies on H_IOCTL call to issue a H_SESSION_ERR_DETECTED command to let the hypervisor to send a failover signal. However, it may not work while the vnic is already in error state, e.g., "ibmvnic 3003 env3: rx buffer returned with rc 6". Add a last resort, that is to

[PATCH net-next 2/2] ibmvnic: add sysfs entry for timeout and fatal reset

2021-04-12 Thread Lijun Pan
Add timeout and fatal reset sysfs entries so that both functions can be triggered manually the tested. Otherwise, you have to run the program for enough time and check both randomly generated resets in the long long log. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 50 ++

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-12 Thread Alex Elder
On 4/12/21 2:26 AM, Leon Romanovsky wrote: On Sun, Apr 11, 2021 at 08:42:15AM -0500, Alex Elder wrote: On 4/11/21 8:28 AM, Leon Romanovsky wrote: I think *not* checking an available return value is questionable practice. I'd really rather have a build option for a "__need_not_check" tag and ha

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 07:34:55PM -0700, Dexuan Cui wrote: > Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be > available in the future. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Co-developed-by: Shachar Raindel > Signed-off-by: Shachar Raindel

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-12 Thread Arend van Spriel
On 08-04-2021 13:30, Shawn Guo wrote: Add optional brcm,ccode-map property to support translation from ISO3166 country code to brcmfmac firmware country code and revision. Reviewed-by: Arend van Spriel Signed-off-by: Shawn Guo --- .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-12 Thread Yongji Xie
On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: > > > 在 2021/4/9 下午4:02, Yongji Xie 写道: > > +}; > > + > > +struct vduse_dev_config_data { > > + __u32 offset; /* offset from the beginning of config space */ > > + __u32 len; /* the length to read/write */ > > +

Re: [Patch bpf-next] skmsg: pass psock pointer to ->psock_update_sk_prot()

2021-04-12 Thread Jakub Sitnicki
On Wed, Apr 07, 2021 at 05:21 AM CEST, Cong Wang wrote: > From: Cong Wang > > Using sk_psock() to retrieve psock pointer from sock requires > RCU read lock, but we already get psock pointer before calling > ->psock_update_sk_prot() in both cases, so we can just pass it > without bothering sk_psock

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-12 Thread Arend van Spriel
On 08-04-2021 13:30, Shawn Guo wrote: With any regulatory domain requests coming from either user space or 802.11 IE (Information Element), the country is coded in ISO3166 standard. It needs to be translated to firmware country code and revision with the mapping info in settings->country_codes t

Re: [PATCH v4 00/14] vdpa: add vdpa simulator for block device

2021-04-12 Thread Stefano Garzarella
Hi Michael, do you think this series is in an acceptable state to be queued for the next merge window? All patches should be already acked by Jason, let me know if I need to change anything. Thanks, Stefano On Mon, Mar 15, 2021 at 05:34:36PM +0100, Stefano Garzarella wrote: v4: - added sup

Re: [RFC v4 net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-12 Thread Marc Zyngier
On Mon, 12 Apr 2021 04:42:35 +0100, DENG Qingfang wrote: > > Add support for MT7530 interrupt controller to handle internal PHYs. > In order to assign an IRQ number to each PHY, the registration of MDIO bus > is also done in this driver. > > Signed-off-by: DENG Qingfang > --- > RFC v3 -> RFC v4

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-12 Thread Juergen Gross
On 12.04.21 03:04, Yunsheng Lin wrote: On 2021/4/9 13:31, Juergen Gross wrote: On 25.03.21 04:13, Yunsheng Lin wrote: Lockless qdisc has below concurrent problem: cpu0 cpu1 . . q->enqueue . . . qdisc_run

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-12 Thread Arend van Spriel
On 08-04-2021 13:30, Shawn Guo wrote: With any regulatory domain requests coming from either user space or 802.11 IE (Information Element), the country is coded in ISO3166 standard. It needs to be translated to firmware country code and revision with the mapping info in settings->country_codes t

Re: [PATCH v5 08/24] wfx: add bus_sdio.c

2021-04-12 Thread Ulf Hansson
On Wed, 7 Apr 2021 at 14:00, Kalle Valo wrote: > > Ulf Hansson writes: > > >> If I follow what has been done in other drivers I would write something > >> like: > >> > >> static int wfx_sdio_suspend(struct device *dev) > >> { > >> struct sdio_func *func = dev_to_sdio_func(dev); > >>

Re: [PATCH net-next 1/1] netfilter: flowtable: Make sure dst_cache is valid before using it

2021-04-12 Thread Roi Dayan
On 2021-04-11 1:58 PM, Pablo Neira Ayuso wrote: Hi Roi, On Sun, Apr 11, 2021 at 11:13:34AM +0300, Roi Dayan wrote: It could be dst_cache was not set so check it's not null before using it. Could you give a try to this fix? net/sched/act_ct.c leaves the xmit_type as FLOW_OFFLOAD_XMIT_UNSPE

RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Dexuan Cui
> From: Leon Romanovsky > Sent: Monday, April 12, 2021 12:46 AM > To: Dexuan Cui > > ... > > +#define ANA_MAJOR_VERSION 0 > > +#define ANA_MINOR_VERSION 1 > > +#define ANA_MICRO_VERSION 1 > > Please don't introduce drier versions. This is not the usual "driver version", though it's called "

Re: [PATCH] brcmfmac: Add support for BCM43596 PCIe Wi-Fi

2021-04-12 Thread Arend van Spriel
On 07-03-2021 12:35, Konrad Dybcio wrote: Add support for BCM43596 dual-band AC chip, found in SONY Xperia X Performance, XZ and XZs smartphones (and *possibly* other devices from other manufacturers). The chip doesn't require any special handling and seems to work just fine OOTB. PCIe IDs taken

Re: Bug Report Napi GRO ixgbe

2021-04-12 Thread Paolo Abeni
Hello, On Sat, 2021-04-10 at 14:22 +0300, Martin Zaharinov wrote: > Hi Team > > One report latest kernel 5.11.12 > > Please check and help to find and fix Please provide a complete splat, including the trapping instruction. > > Apr 10 12:46:25 [214315.519319][ T3345] R13: 8cf193ddf700 R

[PATCH 5.10 001/188] xfrm/compat: Cleanup WARN()s that can be user-triggered

2021-04-12 Thread Greg Kroah-Hartman
From: Dmitry Safonov commit ef19e111337f6c3dca7019a8bad5fbc6fb18d635 upstream. Replace WARN_ONCE() that can be triggered from userspace with pr_warn_once(). Those still give user a hint what's the issue. I've left WARN()s that are not possible to trigger with current code-base and that would me

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Leon Romanovsky
On Mon, Apr 12, 2021 at 08:35:32AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Monday, April 12, 2021 12:46 AM > > To: Dexuan Cui > > > ... > > > +#define ANA_MAJOR_VERSION0 > > > +#define ANA_MINOR_VERSION1 > > > +#define ANA_MICRO_VERSION1 > > > > Pleas

[net-next, v3, 0/2] enetc: support PTP Sync packet one-step timestamping

2021-04-12 Thread Yangbo Lu
This patch-set is to add support for PTP Sync packet one-step timestamping. Since ENETC single-step register has to be configured dynamically per packet for correctionField offeset and UDP checksum update, current one-step timestamping packet has to be sent only when the last one completes transmit

[net-next, v3, 1/2] enetc: mark TX timestamp type per skb

2021-04-12 Thread Yangbo Lu
Mark TX timestamp type per skb on skb->cb[0], instead of global variable for all skbs. This is a preparation for one step timestamp support. For one-step timestamping enablement, there will be both one-step and two-step PTP messages to transfer. And a skb queue is needed for one-step PTP messages

Re: [Patch bpf-next] sock_map: fix a potential use-after-free in sock_map_close()

2021-04-12 Thread Jakub Sitnicki
On Thu, Apr 08, 2021 at 05:05 AM CEST, Cong Wang wrote: > From: Cong Wang > > The last refcnt of the psock can be gone right after > sock_map_remove_links(), so sk_psock_stop() could trigger a UAF. > The reason why I placed sk_psock_stop() there is to avoid RCU read > critical section, and more im

Re: Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-12 Thread Michael S. Tsirkin
On Mon, Apr 12, 2021 at 10:29:17AM +0800, Yongji Xie wrote: > On Mon, Apr 12, 2021 at 4:49 AM Michael S. Tsirkin wrote: > > > > On Sun, Apr 11, 2021 at 01:36:18PM +0800, Yongji Xie wrote: > > > On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Mar 31, 2021

[net-next, v3, 2/2] enetc: support PTP Sync packet one-step timestamping

2021-04-12 Thread Yangbo Lu
This patch is to add support for PTP Sync packet one-step timestamping. Since ENETC single-step register has to be configured dynamically per packet for correctionField offeset and UDP checksum update, current one-step timestamping packet has to be sent only when the last one completes transmitting

[PATCH 5.11 001/210] xfrm/compat: Cleanup WARN()s that can be user-triggered

2021-04-12 Thread Greg Kroah-Hartman
From: Dmitry Safonov commit ef19e111337f6c3dca7019a8bad5fbc6fb18d635 upstream. Replace WARN_ONCE() that can be triggered from userspace with pr_warn_once(). Those still give user a hint what's the issue. I've left WARN()s that are not possible to trigger with current code-base and that would me

Re: linux-next: build failure after merge of the net-next tree

2021-04-12 Thread Florian Westphal
Stephen Rothwell wrote: > net/bridge/netfilter/ebtables.c:1248:33: error: 'struct netns_xt' has no > member named 'tables' > 1248 | list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) { > | ^ > include/linux/list.h:619:20: note: in definition of m

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-12 Thread Radu Nicolae Pirea (NXP OSS)
On Fri, 2021-04-09 at 21:18 +0200, Heiner Kallweit wrote: > On 09.04.2021 20:41, Radu Pirea (NXP OSS) wrote: > > Add driver for tja1103 driver and for future NXP C45 PHYs. > > > > Signed-off-by: Radu Pirea (NXP OSS) > > > > --- > >  MAINTAINERS   |   6 + > >  drivers/net/phy/Kconfig  

RE: [net-next, v2, 2/2] enetc: support PTP Sync packet one-step timestamping

2021-04-12 Thread Y.b. Lu
Hi Jakub and Claudiu, > -Original Message- > From: Jakub Kicinski > Sent: 2021年4月10日 3:44 > To: Claudiu Manoil > Cc: Claudiu Manoil ; Y.b. Lu ; > netdev@vger.kernel.org; David S . Miller ; Richard > Cochran ; Vladimir Oltean > ; Russell King > Subject: Re: [net-next, v2, 2/2] enetc: sup

Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces

2021-04-12 Thread Marc Kleine-Budde
On 10.04.2021 18:59:45, Vincent Mailhol wrote: > Here comes the 15th iteration of the patch. This new version addresses > the comments received from Marc (thanks again for the review!) and > simplify the device probing by using .driver_info. diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c

Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-12 Thread Jason Wang
在 2021/4/12 下午4:02, Yongji Xie 写道: On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: 在 2021/4/9 下午4:02, Yongji Xie 写道: +}; + +struct vduse_dev_config_data { + __u32 offset; /* offset from the beginning of config space */ + __u32 len; /* the length to read/write */ + __u8 data[VD

Re: [PATCH] vdpa/mlx5: Set err = -ENOMEM in case dma_map_sg_attrs fails

2021-04-12 Thread Jason Wang
在 2021/4/11 下午4:36, Eli Cohen 写道: Set err = -ENOMEM if dma_map_sg_attrs() fails so the function reutrns error. Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code") Signed-off-by: Eli Cohen Reported-by: kernel test robot Reported-by: Dan Carpenter --- drivers/vdpa/mlx5/co

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-12 Thread Russell King - ARM Linux admin
On Fri, Apr 09, 2021 at 09:41:06PM +0300, Radu Pirea (NXP OSS) wrote: > +#define B100T1_PMAPMD_CTL0x0834 > +#define B100T1_PMAPMD_CONFIG_EN BIT(15) > +#define B100T1_PMAPMD_MASTER BIT(14) > +#define MASTER_MODE (B100T1_PMAPMD_CONFIG_EN | > B100T1_P

[PATCH] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-12 Thread Xie Yongji
Protect vhost device iotlb by vhost_dev->mutex. Otherwise, it might cause corruption of the list and interval tree in struct vhost_iotlb if userspace sends the VHOST_IOTLB_MSG_V2 message concurrently. Fixes: 4c8cf318("vhost: introduce vDPA-based backend") Cc: sta...@vger.kernel.org Signed-off-by:

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-12 Thread Yongji Xie
On Mon, Apr 12, 2021 at 5:37 PM Jason Wang wrote: > > > 在 2021/4/12 下午4:02, Yongji Xie 写道: > > On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: > >> > >> 在 2021/4/9 下午4:02, Yongji Xie 写道: > >>> +}; > >>> + > >>> +struct vduse_dev_config_data { > >>> + __u32 offset; /* offset

Re: [PATCH 1/9] mm/page_alloc: Rename alloced to allocated

2021-04-12 Thread Vlastimil Babka
On 3/25/21 12:42 PM, Mel Gorman wrote: > Review feedback of the bulk allocator twice found problems with "alloced" > being a counter for pages allocated. The naming was based on the API name > "alloc" and was based on the idea that verbal communication about malloc > tends to use the fake word "mal

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-12 Thread Radu Nicolae Pirea (NXP OSS)
On Fri, 2021-04-09 at 21:36 +0200, Andrew Lunn wrote: > On Fri, Apr 09, 2021 at 09:41:06PM +0300, Radu Pirea (NXP OSS) wrote: > > Add driver for tja1103 driver and for future NXP C45 PHYs. > > So apart from c45 vs c22, how does this differ to nxp-tja11xx.c? > Do we really want two different driver

[PATCH RFC net] igb: Fix XDP with PTP enabled

2021-04-12 Thread Kurt Kanzenbach
When using native XDP with the igb driver, the XDP frame data doesn't point to the beginning of the packet. It's off by 16 bytes. Everything works as expected with XDP skb mode. Actually these 16 bytes are used to store the packet timestamps. Therefore, pull the timestamp before executing any XDP

Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-12 Thread Marc Kleine-Budde
On 4/9/21 3:40 PM, Aswath Govindraju wrote: > The driver adds support for generic CAN transceivers. Currently > the modes supported by this driver are standby and normal modes for TI > TCAN1042 and TCAN1043 CAN transceivers. > > The transceiver is modelled as a phy with pins controlled by gpios, t

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-12 Thread Marc Kleine-Budde
On 4/9/21 3:40 PM, Aswath Govindraju wrote: > Add binding documentation for TI TCAN104x CAN transceivers. > > Signed-off-by: Aswath Govindraju > --- > .../bindings/phy/ti,tcan104x-can.yaml | 56 +++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/de

Re: [PATCH RFC net-next 1/3] net: dsa: allow for multiple CPU ports

2021-04-12 Thread Ansuel Smith
On Mon, Apr 12, 2021 at 11:35:25AM +0800, DENG Qingfang wrote: > On Sat, Apr 10, 2021 at 03:34:47PM +0200, Ansuel Smith wrote: > > Allow for multiple CPU ports in a DSA switch tree. By default the first > > CPU port is assigned mimic the original assignement logic. A DSA driver > > can define a fun

Re: [PATCH 2/9] mm/page_alloc: Add a bulk page allocator

2021-04-12 Thread Vlastimil Babka
On 3/25/21 12:42 PM, Mel Gorman wrote: > This patch adds a new page allocator interface via alloc_pages_bulk, > and __alloc_pages_bulk_nodemask. A caller requests a number of pages > to be allocated and added to a list. > > The API is not guaranteed to return the requested number of pages and > ma

Re: [PATCH 4/4] can: m_can_platform: Add support for transceiver as phy

2021-04-12 Thread Marc Kleine-Budde
On 4/9/21 3:40 PM, Aswath Govindraju wrote: > From: Faiz Abbas > > Add support for implementing transceiver node as phy. The max_bitrate is > obtained by getting a phy attribute. > > Signed-off-by: Faiz Abbas > Signed-off-by: Aswath Govindraju > --- > drivers/net/can/m_can/m_can_platform.c |

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Ansuel Smith
On Sun, Apr 11, 2021 at 08:39:12PM +0200, Andrew Lunn wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > > On Sat, 10 Apr 2021 15:34:46 +0200 > > Ansuel Smith wrote: > > > > > Hi, > > > this is a respin of the Marek series in hope that this time we can > > > finally make some

Re: [RFC v4 net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding

2021-04-12 Thread Kurt Kanzenbach
On Mon Apr 12 2021, DENG Qingfang wrote: > Add device tree binding to support MT7530 interrupt controller. > > Signed-off-by: DENG Qingfang > Reviewed-by: Andrew Lunn > --- > RFC v3 -> RFC v4: > - Add #interrupt-cells property. > > Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++

Re: [PATCH 3/9] mm/page_alloc: Add an array-based interface to the bulk page allocator

2021-04-12 Thread Vlastimil Babka
On 3/25/21 12:42 PM, Mel Gorman wrote: > The proposed callers for the bulk allocator store pages from the bulk > allocator in an array. This patch adds an array-based interface to the API > to avoid multiple list iterations. The page list interface is preserved > to avoid requiring all users of the

Re: [ovs-dev] [PATCH] openvswitch: perform refragmentation for packets which pass through conntrack

2021-04-12 Thread Ilya Maximets
On 4/10/21 2:22 PM, Aaron Conole wrote: > Ilya Maximets writes: > >> On 4/8/21 10:41 PM, Aaron Conole wrote: >>> Joe Stringer writes: >>> Hey Aaron, long time no chat :) >>> >>> Same :) >>> On Fri, Mar 19, 2021 at 1:43 PM Aaron Conole wrote: > > When a user instructs a flow pi

Re: [PATCH 4/9] mm/page_alloc: optimize code layout for __alloc_pages_bulk

2021-04-12 Thread Vlastimil Babka
On 3/25/21 12:42 PM, Mel Gorman wrote: > From: Jesper Dangaard Brouer > > Looking at perf-report and ASM-code for __alloc_pages_bulk() it is clear > that the code activated is suboptimal. The compiler guesses wrong and > places unlikely code at the beginning. Due to the use of WARN_ON_ONCE() > ma

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Ansuel Smith
On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > > On Sat, 10 Apr 2021 15:34:46 +0200 > > Ansuel Smith wrote: > > > > > Hi, > > > this is a respin of the Marek series in hope that this time we can > > > finally make

Re: [PATCH] brcmfmac: Add support for BCM43596 PCIe Wi-Fi

2021-04-12 Thread AngeloGioacchino Del Regno
Il 12/04/21 10:36, Arend van Spriel ha scritto: On 07-03-2021 12:35, Konrad Dybcio wrote: Add support for BCM43596 dual-band AC chip, found in SONY Xperia X Performance, XZ and XZs smartphones (and *possibly* other devices from other manufacturers). The chip doesn't require any special handling

[PATCH] net: mac802154: fix WARNING in ieee802154_del_device

2021-04-12 Thread Pavel Skripkin
syzbot reported WARNING in ieee802154_del_device. The problem was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR mutex won't be initialized, but ieee802154_del_device() accessing it. Reported-by: syzbot+bf8b5834b7ec22948...@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin ---

Re: [PATCH 5/9] mm/page_alloc: inline __rmqueue_pcplist

2021-04-12 Thread Vlastimil Babka
On 3/25/21 12:42 PM, Mel Gorman wrote: > From: Jesper Dangaard Brouer > > When __alloc_pages_bulk() got introduced two callers of __rmqueue_pcplist > exist and the compiler chooses to not inline this function. > > ./scripts/bloat-o-meter vmlinux-before vmlinux-inline__rmqueue_pcplist > add/remo

Re: [PATCH 2/9] mm/page_alloc: Add a bulk page allocator

2021-04-12 Thread Mel Gorman
On Mon, Apr 12, 2021 at 12:21:42PM +0200, Vlastimil Babka wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 8a3e13277e22..eb547470a7e4 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -4965,6 +4965,124 @@ static inline bool prepare_alloc_pages(gfp_t > > gfp_mask,

[PATCH] mm/page_alloc: Add a bulk page allocator -fix -fix -fix

2021-04-12 Thread Mel Gorman
Vlastimil Babka noted that a comment is wrong, fix it. This is the third fix to the mmotm patch mm-page_alloc-add-a-bulk-page-allocator.patch. Signed-off-by: Mel Gorman --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index

Re: [PATCH 2/9] mm/page_alloc: Add a bulk page allocator

2021-04-12 Thread Mel Gorman
On Mon, Apr 12, 2021 at 11:59:38AM +0100, Mel Gorman wrote: > > I don't understand this comment. Only alloc_flags_nofragment() sets this > > flag > > and we don't use it here? > > > > It's there as a reminder that there are non-obvious consequences > to ALLOC_NOFRAGMENT that may affect the bulk

Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces

2021-04-12 Thread Vincent MAILHOL
Hi Marc, On Mon. 12 Apr 2021 at 18:20, Marc Kleine-Budde wrote: > On 10.04.2021 18:59:45, Vincent Mailhol wrote: > > Here comes the 15th iteration of the patch. This new version addresses > > the comments received from Marc (thanks again for the review!) and > > simplify the device probing by usi

Re: [PATCH net-next 1/1] netfilter: flowtable: Make sure dst_cache is valid before using it

2021-04-12 Thread Pablo Neira Ayuso
On Mon, Apr 12, 2021 at 11:26:35AM +0300, Roi Dayan wrote: > > > On 2021-04-11 1:58 PM, Pablo Neira Ayuso wrote: > > Hi Roi, > > > > On Sun, Apr 11, 2021 at 11:13:34AM +0300, Roi Dayan wrote: > > > It could be dst_cache was not set so check it's not null before using > > > it. > > > > Could you

Re: [PATCH] net: mac802154: fix WARNING in ieee802154_del_device

2021-04-12 Thread Alexander Aring
Hi, On Mon, 12 Apr 2021 at 06:58, Pavel Skripkin wrote: > > syzbot reported WARNING in ieee802154_del_device. The problem > was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR > mutex won't be initialized, but ieee802154_del_device() accessing it. > > Reported-by: syzbot+bf8b5834b7ec22

[PATCH 3/3] powerpc/ebpf32: Use standard function call for functions within 32M distance

2021-04-12 Thread Christophe Leroy
If the target of a function call is within 32 Mbytes distance, use a standard function call with 'bl' of the 'lis/ori/mtlr/blrl' sequence. In the first pass, no memory has been allocated yet and the code position is not known yet (image pointer is NULL). This pass is there to calculate the amount

[PATCH 1/3] powerpc/ebpf32: Fix comment on BPF_ALU{64} | BPF_LSH | BPF_K

2021-04-12 Thread Christophe Leroy
Replace <<== by <<= Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp32.c b/arch/powerpc/net/bpf_jit_comp32.c index 003843273b43..ca6fe1583460 100644 --- a/arch/powerpc/net/

[PATCH 2/3] powerpc/ebpf32: Rework 64 bits shifts to avoid tests and branches

2021-04-12 Thread Christophe Leroy
Re-implement BPF_ALU64 | BPF_{LSH/RSH/ARSH} | BPF_X with branchless implementation copied from misc_32.S. Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/arch/powerpc/net/b

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-12 Thread Kalle Valo
Shawn Guo writes: > On Sun, Apr 11, 2021 at 10:57:54AM +0300, Kalle Valo wrote: >> Shawn Guo writes: >> >> > Add optional brcm,ccode-map property to support translation from ISO3166 >> > country code to brcmfmac firmware country code and revision. >> > >> > Signed-off-by: Shawn Guo >> > --- >>

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-12 Thread Yunsheng Lin
On 2021/4/12 15:28, Hillf Danton wrote: > On Mon, 12 Apr 2021 11:37:24 Yunsheng Lin wrote: >> On 2021/4/12 11:21, Hillf Danton wrote: >>> On Mon, 12 Apr 2021 09:24:30 Yunsheng Lin wrote: On 2021/4/9 17:09, Hillf Danton wrote: > On Fri, 9 Apr 2021 07:31:03 Juergen Gross wrote: >> On 2

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Andrew Lunn
> > Currently the protocol versin is 0.1.1 You may ask why it's called > > "drv version" rather than "protocol version" -- it's because the PF driver > > calls it that way, so I think here the VF driver may as well use the same > > name. BTW, the "drv ver" info is passed to the PF driver in the bel

[PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
Since commit fee2d546414d ("net: phy: marvell: mv88e6390 temperature sensor reading"), Linux reports the temperature of Topaz hwmon as constant -75°C. This is because switches from the Topaz family (88E6141 / 88E6341) have the address of the temperature sensor register different from Peridot. Thi

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Andrew Lunn
> +static inline bool is_gdma_msg(const void *req) > +{ > + struct gdma_req_hdr *hdr = (struct gdma_req_hdr *)req; > + > + if (hdr->req.hdr_type == GDMA_STANDARD_HEADER_TYPE && > + hdr->resp.hdr_type == GDMA_STANDARD_HEADER_TYPE && > + hdr->req.msg_size >= sizeof(struct gdma

[PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-12 Thread Ivan Bornyakov
Some SFP modules uses RX_LOS for link indication. In such cases link will be always up, even without cable connected. RX_LOS changes will trigger link_up()/link_down() upstream operations. Thus, check that SFP link is operational before actual read link status. Signed-off-by: Ivan Bornyakov ---

[PATCH net-next 0/2] net: phy: marvell-88x2222: a couple of improvements

2021-04-12 Thread Ivan Bornyakov
First, there are some SFP modules that only uses RX_LOS for link indication. Add check that SFP link is operational before actual read of link status. Second, it is invalid to set 10G speed without autonegotiation, according to phy_ethtool_ksettings_set(). Implement switching between 10GBase-R and

[PATCH net-next 2/2] net: phy: marvell-88x2222: swap 1G/10G modes on autoneg

2021-04-12 Thread Ivan Bornyakov
Setting 10G without autonegotiation is invalid according to phy_ethtool_ksettings_set(). Thus, if autonegotiation can't complete for quite a time, but there is signal in line, switch line interface type to 10GBase-R, if supported, in hope for link to be established. And vice versa. Signed-off-by:

Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Andrew Lunn
> +static void mana_gd_deregiser_irq(struct gdma_queue *queue) > +{ > + struct gdma_dev *gd = queue->gdma_dev; > + struct gdma_irq_context *gic; > + struct gdma_context *gc; > + struct gdma_resource *r; > + unsigned int msix_index; > + unsigned long flags; > + > + /* At

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Sun, Apr 11, 2021 at 21:50, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: >> On Sat, 10 Apr 2021 15:34:46 +0200 >> Ansuel Smith wrote: >> >> > Hi, >> > this is a respin of the Marek series in hope that this time we can >> > finally make some progress wi

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-12 Thread Simo Sorce
On Fri, 2021-04-09 at 14:56 -0400, Simo Sorce wrote: > Hi Jason, > I can't speak for Hangbin, we do not work for the same company and I > was not aware of his efforts until this patch landed. Turns out I and Hangbin do work for the same company after all. Left hand is meeting right hand internally

Re: [PATCH] vdpa/mlx5: Set err = -ENOMEM in case dma_map_sg_attrs fails

2021-04-12 Thread Stefano Garzarella
On Sun, Apr 11, 2021 at 11:36:46AM +0300, Eli Cohen wrote: Set err = -ENOMEM if dma_map_sg_attrs() fails so the function reutrns error. Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code") Signed-off-by: Eli Cohen Reported-by: kernel test robot Reported-by: Dan Carpenter ---

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-12 Thread Andrew Lunn
On Mon, Apr 12, 2021 at 01:02:07PM +0300, Radu Nicolae Pirea (NXP OSS) wrote: > On Fri, 2021-04-09 at 21:36 +0200, Andrew Lunn wrote: > > On Fri, Apr 09, 2021 at 09:41:06PM +0300, Radu Pirea (NXP OSS) wrote: > > > Add driver for tja1103 driver and for future NXP C45 PHYs. > > > > So apart from c45

Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Andrew Lunn
> +static u16 mv88e6xxx_physid_for_family(enum mv88e6xxx_family family); > + No forward declaration please. Move the code around. It is often best to do that in a patch which just moves code, no other changes. It makes it easier to review. > static int mv88e6xxx_mdio_read(struct mii_bus *bus, in

Re: [RFC PATCH 1/3] dt-bindings: net: xilinx_axienet: convert bindings document to yaml

2021-04-12 Thread Rob Herring
On Fri, 09 Apr 2021 23:43:20 +0530, Radhey Shyam Pandey wrote: > Convert the bindings document for Xilinx AXI Ethernet Subsystem > from txt to yaml. No changes to existing binding description. > > Signed-off-by: Radhey Shyam Pandey > --- > Pending: Fix below remaining dt_binding_check warning: >

Re: linux-next: build failure after merge of the net-next tree

2021-04-12 Thread Pablo Neira Ayuso
On Mon, Apr 12, 2021 at 03:04:16PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from include/asm-generic/bug.h:20, > from arch/x86/include/asm/bug.h:93, >

[PATCH V4 1/2] dt-bindings: net: renesas,etheravb: Add additional clocks

2021-04-12 Thread Adam Ford
The AVB driver assumes there is an external crystal, but it could be clocked by other means. In order to enable a programmable clock, it needs to be added to the clocks list and enabled in the driver. Since there currently only one clock, there is no clock-names list either. Update bindings to a

[PATCH V4 2/2] net: ethernet: ravb: Enable optional refclk

2021-04-12 Thread Adam Ford
For devices that use a programmable clock for the AVB reference clock, the driver may need to enable them. Add code to find the optional clock and enable it when available. Signed-off-by: Adam Ford Reviewed-by: Andrew Lunn --- V4: Eliminate the NULL check when disabling refclk, and add a line

Broken imx6 to QCA8334 connection since PHYLIB to PHYLINK conversion

2021-04-12 Thread Michal Vokáč
Hi folks, I am working on kernel upgrade on our imx6dl-yapp4 platform and just realized that since v5.9 networking is broken. Git bisect brought me to commit b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB") Kernel v5.8 NFS boot without the offending commit: qca8k 2188000.et

Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
On Monday 12 April 2021 15:15:07 Andrew Lunn wrote: > > +static u16 mv88e6xxx_physid_for_family(enum mv88e6xxx_family family); > > + > > No forward declaration please. Move the code around. It is often best > to do that in a patch which just moves code, no other changes. It > makes it easier to re

From Michelle

2021-04-12 Thread Shayma
Witam, mam nadzieję, że otrzymałeś moją wiadomość. Potrzebuję szybkich reakcji Dziękuję Ci Michelle

Re: [ovs-dev] [PATCH] openvswitch: perform refragmentation for packets which pass through conntrack

2021-04-12 Thread Aaron Conole
Ilya Maximets writes: > On 4/10/21 2:22 PM, Aaron Conole wrote: >> Ilya Maximets writes: >> >>> On 4/8/21 10:41 PM, Aaron Conole wrote: Joe Stringer writes: > Hey Aaron, long time no chat :) Same :) > On Fri, Mar 19, 2021 at 1:43 PM Aaron Conole wrote: >>

[PATCH v2 net-next] net: multipath routing: configurable seed

2021-04-12 Thread Balaev Pavel
Ability for user to set seed value for multipath routing hashes. Now kernel uses random seed value: this is done to prevent hash-flooding DoS attacks, but it breaks some scenario, f.e: +---++--+++ | |-eth0---| FW0 |---eth0-|| | |+--+

Re: [External] Re: [RFC] vsock: add multiple transports support for dgram

2021-04-12 Thread Stefano Garzarella
Hi Jiang, thanks for re-starting the multi-transport support for dgram! On Wed, Apr 07, 2021 at 11:25:36AM -0700, Jiang Wang . wrote: On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: > On 6 Apr 2021, at 20:31, Jiang Wang wrote: > > From: "jiang.wang" > > Currently, only VMCI supports dg

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-12 Thread Radu Nicolae Pirea (NXP OSS)
On Mon, 2021-04-12 at 14:57 +0200, Andrew Lunn wrote: > On Mon, Apr 12, 2021 at 01:02:07PM +0300, Radu Nicolae Pirea (NXP > OSS) wrote: > > On Fri, 2021-04-09 at 21:36 +0200, Andrew Lunn wrote: > > > On Fri, Apr 09, 2021 at 09:41:06PM +0300, Radu Pirea (NXP OSS) > > > wrote: > > > > Add driver for

Re: [PATCH v2 bpf-next 0/2] xsk: introduce generic almost-zerocopy xmit

2021-04-12 Thread Magnus Karlsson
On Wed, Mar 31, 2021 at 2:27 PM Alexander Lobakin wrote: > > This series is based on the exceptional generic zerocopy xmit logics > initially introduced by Xuan Zhuo. It extends it the way that it > could cover all the sane drivers, not only the ones that are capable > of xmitting skbs with no lin

  1   2   3   4   5   >