On Thu, Feb 18, 2021 at 03:20:14PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
> ---
> drivers/
On Tue, Feb 16, 2021 at 08:48:24AM -0700, David Ahern wrote:
> On 2/15/21 11:16 PM, Leon Romanovsky wrote:
> > On Mon, Feb 15, 2021 at 06:56:26PM -0700, David Ahern wrote:
> >> On 2/14/21 10:40 PM, Leon Romanovsky wrote:
> >>> On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote:
> what
On Tue, Feb 16, 2021 at 12:18:13PM -0800, Xie He wrote:
> When sending packets, we will first hand over the (L3) packets to the
> LAPB module. The LAPB module will then hand over the corresponding LAPB
> (L2) frames back to us for us to transmit.
>
> The LAPB module can also emit LAPB (L2) frames a
On Thu, Feb 18, 2021 at 12:57 AM Leon Romanovsky wrote:
>
> It is nice that you are resending your patch without the resolution.
> However it will be awesome if you don't ignore review comments and fix this
> "3 - 1"
> by writing solid comment above.
I thought you already agreed with me? It look
Fix the following coccicheck warnings:
./tools/perf/util/machine.c:2000:9-10: WARNING: return of 0/1 in
function 'symbol__match_regex' with return type bool.
Reported-by: Abaci Robot
Signed-off-by: Jiapeng Chong
---
tools/perf/util/machine.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
On Wed, 17 Feb 2021 at 17:33, Ciara Loftus wrote:
>
> Prior to this commit individual xsk tests were launched from the
> shell script 'test_xsk.sh'. When adding a new test type, two new test
> configurations had to be added to this file - one for each of the
> supported XDP 'modes' (skb or drv). S
On Wed, Feb 17, 2021 at 12:02:39PM -0600, Bjorn Helgaas wrote:
> [+cc Greg in case he wants to chime in on the sysfs discussion.
> TL;DR: we're trying to add/remove sysfs files when a PCI driver that
> supports certain callbacks binds or unbinds; series at
> https://lore.kernel.org/r/20210209133445
This series introduces support for USB network devices that report
speed as a part of their protocol, not emulating an MII to be accessed
over MDIO.
v2: rebased on recent upstream changes
v3: incorporated hints on naming and comments
The old method for reporting network speed upwards
assumed that a device uses MDIO and uses the generic phy
functions based on that.
Add a a primitive internal version not making the assumption
reporting back directly what the status operations record.
v2: rebased on upstream
v3: changed names and
The old generic functions assume that the devices includes
an MDIO interface. This is true only for genuine ethernet.
Devices with a higher level of abstraction or based on different
technologies do not have it. So in preparation for
supporting that, we rename the old functions to something specifi
The driver has a status method for receiving speed updates.
The framework, however, had support functions only for devices
that reported their speed upon an explicit query over a MDIO
interface.
CDC_NCM however gets direct notifications from the device.
As new support functions have become availabl
On Thu, Feb 18, 2021 at 01:07:13AM -0800, Xie He wrote:
> On Thu, Feb 18, 2021 at 12:57 AM Leon Romanovsky wrote:
> >
> > It is nice that you are resending your patch without the resolution.
> > However it will be awesome if you don't ignore review comments and fix this
> > "3 - 1"
> > by writing
On Thu, Feb 18, 2021 at 4:28 AM Min Li wrote:
> > If the driver can use the same algorithm that is in your user space software
> > today, that would seem to be a nicer way to handle it than requiring a
> > separate application.
> >
>
> Hi Arnd
>
>
> What is the device driver that you are referring
Joe Stringer writes:
> On Wed, Feb 17, 2021 at 5:55 AM Toke Høiland-Jørgensen
> wrote:
>>
>> Joe Stringer writes:
>> > Given the relative success of the process around bpf-helpers(7) to
>> > encourage developers to document their user-facing changes, in this
>> > patch series I explore applyin
On Wed, 17 Feb 2021 16:17:58 +0100
Sascha Hauer wrote:
> This reverts commit a1e031ffb422bb89df9ad9c018420d0deff7f2e3.
>
> This commit introduces a:
>
> np = container_of(&portal, struct dpaa_napi_portal, p);
>
> Using container_of() on the address of a pointer doesn't make sense as
> th
The FIB lookup example[1] show how the IP-header field tot_len
(iph->tot_len) is used as input to perform the MTU check. The recently
added MTU check helper bpf_check_mtu() should also support this type
of MTU check.
Lets add this feature before merge window, please. This is a followup
to 34b2021c
The FIB lookup example[1] show how the IP-header field tot_len
(iph->tot_len) is used as input to perform the MTU check.
This patch extend the BPF-helper bpf_check_mtu() with the same ability
to provide the length as user parameter input, via mtu_len parameter.
[1] samples/bpf/xdp_fwd_kern.c
Sig
Add tests that use mtu_len as input parameter in BPF-helper
bpf_check_mtu().
The BPF-helper is avail from both XDP and TC context. Add two tests
per context, one that tests below MTU and one that exceeds the MTU.
Signed-off-by: Jesper Dangaard Brouer
Acked-by: John Fastabend
---
tools/testing/
The icmp{,v6}_send functions make all sorts of use of skb->cb, assuming
the skb to have come directly from the inet layer. But when the packet
comes from the ndo layer, especially when forwarded, there's no telling
what might be in skb->cb at that point. So, icmp{,v6}_ndo_send must zero
out its skb
sky2.c driver uses netdev_warn() before the net device is initialized.
Fix it by using dev_warn() instead.
Signed-off-by: Krzysztof Halasa
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -4806,12 +4806,11 @@ static struct net_device *sky2_init_netdev(struct
On Wed 2021-02-17 15:50:00, Andy Shevchenko wrote:
> On Wed, Feb 17, 2021 at 01:15:43PM +0100, Enrico Weigelt, metux IT consult
> wrote:
> > Under rare circumstances it may happen that a device node's name is NULL
> > (most likely kernel bug in some other place).
>
> What circumstances? How can I
On Wed, 2021-02-17 at 09:31 -0800, syzbot wrote:
> syzbot found the following issue on:
>
> HEAD commit:c48f8607 Merge branch 'PTP-for-DSA-tag_ocelot_8021q'
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=16525cb0d0
> kernel config: https://syzkaller
From: Stefan Chulski
PPv2 loopback port doesn't support RSS, so we should
skip RSS configurations for this port.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 25 +++-
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/
Em Fri, Feb 05, 2021 at 10:49:15AM +0100, Jiri Olsa escreveu:
> On Fri, Feb 05, 2021 at 11:54:15AM +0800, Jiapeng Chong wrote:
> > Fix the following coccicheck warnings:
> >
> > ./tools/perf/util/header.c:3809:18-20: WARNING !A || A && B is
> > equivalent to !A || B.
> >
> > Reported-by: Abaci Ro
> -Original Message-
> From: Jesper Dangaard Brouer
> Sent: Thursday, February 18, 2021 13:43
> To: Sascha Hauer
> Cc: bro...@redhat.com; netdev@vger.kernel.org; Camelia Alexandra Groza
> ; Madalin Bucur ;
> Jakub Kicinski ; ker...@pengutronix.de; Ioana Ciornei
> ; Ioana Ciocoi Radulescu
Hi Horatiu,
On Thu, Feb 18, 2021 at 12:47:26PM +0100, Horatiu Vultur wrote:
> This patch fixes the ocelot MRP switchdev driver such that also DSA
> driver can use these functions. Before the driver presumed that the
> net_device uses a 'struct ocelot_port_private' as priv which was wrong.
>
> The
On 2/17/21 11:23 PM, Kalle Valo wrote:
Shuah Khan wrote:
This reverts commit a56c14bb21b296fb6d395164ab62ef2e419e5069.
ath_tx_process_buffer() doesn't dereference or check sta and passes it
to ath_tx_complete_aggr() and ath_tx_complete_buf().
ath_tx_complete_aggr() checks the pointer before
syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch and the reproducer did not trigger any
> issue:
>
> Reported-and-tested-by: syzbot+b53bbea2ad64f9cf8...@syzkaller.appspotmail.com
#syz-fix: mptcp: reset last_snd on subflow close
[ This patch is currently in mptcp-next ]
On 2/17/2021 8:44 PM, Jason Wang wrote:
On 2021/2/10 下午4:59, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason
On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
wrote:
>
> Introduce fwnode_mdiobus_register_phy() to register PHYs on the
> mdiobus. From the compatible string, identify whether the PHY is
> c45 and based on this create a PHY device instance which is
> registered on the mdiobus.
Thanks for an upd
On Thu, Feb 18, 2021 at 7:31 AM Jason A. Donenfeld wrote:
>
> The icmp{,v6}_send functions make all sorts of use of skb->cb, assuming
Indeed that also casts skb->cb, to read IP6CB(skb)->iif, good catch.
Still, might be good to more precisely detail the relevant bug:
icmp_send casts the cb to an
In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a
node does not send any frame within this time, the sequence number check
for can be ignored. This solves communication issues with Cisco IE 2000
in Redbox mode.
Fixes: f421436a591d ("net/hsr: Add support for the High-availabi
For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
set) based on the type in the virtio net hdr, but the skb could contain
anything since it could come from packet_snd through a raw socket. If
there is a mismatch between what virtio_net_hdr_set_proto sets and
the actual protoc
On Thu, Feb 18, 2021 at 7:29 AM Calvin Johnson
wrote:
>
> Modify dpaa2_mac_get_node() to get the dpmac fwnode from either
> DT or ACPI.
>
> Modify dpaa2_mac_get_if_mode() to get interface mode from dpmac_node
> which is a fwnode.
>
> Modify dpaa2_pcs_create() to create pcs from dpmac_node fwnode.
Hi,
czw., 18 lut 2021 o 13:42 napisał(a):
>
> From: Stefan Chulski
>
> PPv2 loopback port doesn't support RSS, so we should
> skip RSS configurations for this port.
>
> Signed-off-by: Stefan Chulski
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 25 +++-
> 1 file ch
On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
wrote:
>
> Define acpi_mdiobus_register() to Register mii_bus and create PHYs for
> each ACPI child node.
> +#include
> +#include
Perhaps it's better to provide the headers that this file is direct
user of, i.e.
bits.h
dev_printk.h
module.h
ty
Hi Willem,
On Thu, Feb 18, 2021 at 3:57 PM Willem de Bruijn
wrote:
>
> On Thu, Feb 18, 2021 at 7:31 AM Jason A. Donenfeld wrote:
> >
> > The icmp{,v6}_send functions make all sorts of use of skb->cb, assuming
>
> Indeed that also casts skb->cb, to read IP6CB(skb)->iif, good catch.
>
> Still, mig
On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote:
>
> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> set) based on the type in the virtio net hdr, but the skb could contain
> anything since it could come from packet_snd through a raw socket. If
> there is a mismatch
> -Original Message-
> From: gre...@linuxfoundation.org
> Sent: Thursday, February 18, 2021 2:53 AM
> To: Chen, Mike Ximing
> Cc: netdev@vger.kernel.org; Linux Kernel Mailing List ker...@vger.kernel.org>; da...@davemloft.net; k...@kernel.org; a...@arndb.de;
> Williams, Dan J ;
> pier
On Thu, Feb 11, 2021 at 01:28:06AM +0300, Serge Semin wrote:
> On Tue, Feb 09, 2021 at 05:13:52PM -0600, Rob Herring wrote:
> > On Mon, Feb 08, 2021 at 05:08:05PM +0300, Serge Semin wrote:
> > > Synopsys DesignWare Ethernet controllers can be synthesized with
> > > General-Purpose IOs support. GPIO
On Thu, Feb 11, 2021 at 12:58:00AM +0300, Serge Semin wrote:
> On Tue, Feb 09, 2021 at 04:26:08PM -0600, Rob Herring wrote:
> > On Mon, Feb 08, 2021 at 04:55:48PM +0300, Serge Semin wrote:
> > > Currently the "snps,axi-config", "snps,mtl-rx-config" and
> > > "snps,mtl-tx-config" properties are decl
The icmp{,v6}_send functions make all sorts of use of skb->cb, casting
it with IPCB or IP6CB, assuming the skb to have come directly from the
inet layer. But when the packet comes from the ndo layer, especially
when forwarded, there's no telling what might be in skb->cb at that
point. As a result,
> -Original Message-
> From: Arnd Bergmann
> Sent: February 18, 2021 5:51 AM
> To: Min Li
> Cc: Derek Kiernan ; Dragan Cvetic
> ; Arnd Bergmann ; gregkh
> ; linux-ker...@vger.kernel.org; Networking
> ; Richard Cochran
> Subject: Re: [PATCH net-next] misc: Add Renesas Synchronization
>
On Thu, Feb 18, 2021 at 11:08 AM Jason A. Donenfeld wrote:
>
> The icmp{,v6}_send functions make all sorts of use of skb->cb, casting
> it with IPCB or IP6CB, assuming the skb to have come directly from the
> inet layer. But when the packet comes from the ndo layer, especially
> when forwarded, th
Thanks Daniel and Willem!
So sorry to reply to you late for I just took the Chinese Spring Festival
vacation.
I will resubmit this patch.
Thanks again!
> 2021年2月11日 下午11:26，Daniel Borkmann 写道：
>
> On 2/10/21 3:50 PM, Willem de Bruijn wrote:
>> On Wed, Feb 10, 2021 at 1:59 AM huangxuesen wro
From: Xuesen Huang
bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets
encapsulation. But that is not appropriate when pushing Ethernet header.
Add an option to further specify encap L2 type and set the inner_protocol
as ETH_P_TEB.
Suggested-by: Willem de Bruijn
Signed-off
On 11/12/2020 6:33 PM, Ido Schimmel wrote:
On Thu, Nov 12, 2020 at 05:54:30PM +0200, Tariq Toukan wrote:
On 11/12/2020 5:46 PM, Ido Schimmel wrote:
On Thu, Nov 12, 2020 at 05:38:44PM +0200, Tariq Toukan wrote:
Hi all,
In the past ~2-3 weeks, we started seeing the following WARNING and tr
Hello,
syzbot found the following issue on:
HEAD commit:57baf8cc net: axienet: Handle deferred probe on clock prop..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=16d83be2d0
kernel config: https://syzkaller.appspot.com/x/.config?x=8cb23303ddb9411f
dashboar
On Thu, Feb 18, 2021 at 9:01 AM Marco Wenzel wrote:
>
> In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a
> node does not send any frame within this time, the sequence number check
> for can be ignored. This solves communication issues with Cisco IE 2000
> in Redbox mode.
>
This patch fixes the ocelot MRP switchdev driver such that also DSA
driver can use these functions. Before the driver presumed that the
net_device uses a 'struct ocelot_port_private' as priv which was wrong.
The only reason for using ocelot_port_private was to access the
net_device, but this can b
Hello,
syzbot found the following issue on:
HEAD commit:b646acd5 net: re-solve some conflicts after net -> net-nex..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=129fbe04d0
kernel config: https://syzkaller.appspot.com/x/.config?x=dbc1ca9e55dc1f9f
das
On Thu, Feb 18, 2021 at 10:40 AM Jason A. Donenfeld wrote:
>
> Hi Willem,
>
> On Thu, Feb 18, 2021 at 3:57 PM Willem de Bruijn
> wrote:
> >
> > On Thu, Feb 18, 2021 at 7:31 AM Jason A. Donenfeld wrote:
> > >
> > > The icmp{,v6}_send functions make all sorts of use of skb->cb, assuming
> >
> > In
The recent addition of in_serving_softirq() to kconv.h results in
compile failure on PREEMPT_RT because it requires
task_struct::softirq_disable_cnt. This is not available if kconv.h is
included from sched.h.
It is not needed to include kconv.h from sched.h. All but the net/ user
already include t
On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn
wrote:
> Thanks for respinning.
>
> Making ipv4 and ipv6 more aligned is a good goal, but more for
> net-next than bug fixes that need to be backported to many stable
> branches.
>
> Beyond that, I'm not sure this fixes additional cases vs the previ
On Thu, Feb 18, 2021 at 2:37 AM Leon Romanovsky wrote:
>
> It is not me who didn't explain, it is you who didn't want to write clear
> comment that describes the headroom size without need of "3 - 1".
Why do I need to write unnecessary comments when "3 - 1" and the
current comment already explain
On Thu, 2021-02-18 at 18:31 +0100, Sebastian Andrzej Siewior wrote:
> The recent addition of in_serving_softirq() to kconv.h results in
You typo'ed "kconv.h" pretty consistently ;-)
But yes, that makes sense.
Acked-by: Johannes Berg
johannes
syzbot has bisected this issue to:
commit 40947e13997a1cba4e875893ca6e5d5e61a0689d
Author: Florian Westphal
Date: Fri Feb 12 23:59:56 2021 +
mptcp: schedule worker when subflow is closed
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=109b88f2d0
start commit: 9ec5ee
The current use of container_of is flawed and unnecessary. Obtain
the dpaa_napi_portal reference from the private percpu data instead.
Fixes: a1e031ffb422 ("dpaa_eth: add XDP_REDIRECT support")
Reported-by: Sascha Hauer
Signed-off-by: Camelia Groza
---
drivers/net/ethernet/freescale/dpaa/dpaa_e
Stephen Rothwell [s...@canb.auug.org.au] wrote:
> Hi all,
>
> Today's linux-next merge of the net-next tree got conflicts in:
>
> drivers/net/ethernet/ibm/ibmvnic.c
> drivers/net/ethernet/ibm/ibmvnic.h
>
> between commit:
>
> 4a41c421f367 ("ibmvnic: serialize access to work queue on remov
Add paging support to the QCA AR8031/33 PHY. This will be needed if we
add support for the .config_inband_aneg callback, see series [1].
The driver itself already accesses the fiber page (without proper locking).
The former version of this patchset converted the access to
phy_read_paged(), but Vla
The AR8031 has two register sets: Copper and Fiber. The fiber page is
used in case of 100Base-FX and 1000Base-X. But more importantly it is
also used for the SGMII link. Add support to switch between these two.
Signed-off-by: Michael Walle
---
drivers/net/phy/at803x.c | 35 ++
at803x_aneg_done() is pretty much dead code since the patch series
"net: phy: improve and simplify phylib state machine" [1]. Just remove
it.
[1]
https://lore.kernel.org/netdev/922c223b-7bc0-e0ec-345d-2034b796a...@gmail.com/
Suggested-by: Vladimir Oltean
Signed-off-by: Michael Walle
---
drive
On Thu, 18 Feb 2021 10:56:41 +0530 Calvin Johnson wrote:
> +/**
> + * fwnode_mdio_find_device - Given a fwnode, find the mdio_device
> + * @np: pointer to the mdio_device's fwnode
> + *
> + * If successful, returns a pointer to the mdio_device with the embedded
> + * struct device refcount incremen
>
> With the goal of enabling a generic infrastructure that allows NVMe/TCP
> offload devices like NICs to seamlessly plug into the NVMe-oF stack, this
> patch series introduces the nvme-tcp-offload ULP host layer, which will be a
> new transport type called "tcp-offload" and will serve as an abst
On Thu, 18 Feb 2021 11:20:36 +0100 Oliver Neukum wrote:
> The old generic functions assume that the devices includes
> an MDIO interface. This is true only for genuine ethernet.
> Devices with a higher level of abstraction or based on different
> technologies do not have it. So in preparation for
>
On Thu, 18 Feb 2021 11:20:37 +0100 Oliver Neukum wrote:
> The old method for reporting network speed upwards
> assumed that a device uses MDIO and uses the generic phy
> functions based on that.
> Add a a primitive internal version not making the assumption
> reporting back directly what the status
On Thu, 18 Feb 2021 13:30:53 +0100 Jason A. Donenfeld wrote:
> The icmp{,v6}_send functions make all sorts of use of skb->cb, assuming
> the skb to have come directly from the inet layer. But when the packet
> comes from the ndo layer, especially when forwarded, there's no telling
> what might be i
Hello,
syzbot found the following issue on:
HEAD commit:f40ddce8 Linux 5.11
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11261a4cd0
kernel config: https://syzkaller.appspot.com/x/.config?x=67894355b1dbeb07
dashboard link: https://syzkaller.appspot.co
On Thu, Feb 18, 2021 at 8:08 PM Jakub Kicinski wrote:
>
> On Thu, 18 Feb 2021 13:30:53 +0100 Jason A. Donenfeld wrote:
> > The icmp{,v6}_send functions make all sorts of use of skb->cb, assuming
> > the skb to have come directly from the inet layer. But when the packet
> > comes from the ndo layer
Joe Stringer writes:
> Hey Jon, thanks for the feedback. Absolutely, what you say makes
> sense. The intent here wasn't to come up with something new. Based on
> your prompt from this email (and a quick look at your KR '19
> presentation), I'm hearing a few observations:
> * Storing the documenta
On Thu, Feb 18, 2021 at 07:52:38PM +0100, Michael Walle wrote:
> Add paging support to the QCA AR8031/33 PHY. This will be needed if we
> add support for the .config_inband_aneg callback, see series [1].
>
> The driver itself already accesses the fiber page (without proper locking).
> The former ve
Oliver, Jakub,
Can I post v4 and deal with the issues below?
I can compile and test against ToT for now and I'll like to get this
mess behind me.
I still think the first patch in this series should revert my previous
change (de658a195ee23ca6aaffe197d1d2ea040beea0a2).
On Thu, Feb 18, 2021 at 10:2
Am 2021-02-18 20:26, schrieb Vladimir Oltean:
On Thu, Feb 18, 2021 at 07:52:38PM +0100, Michael Walle wrote:
Add paging support to the QCA AR8031/33 PHY. This will be needed if we
add support for the .config_inband_aneg callback, see series [1].
The driver itself already accesses the fiber page
On Wed, 17 Feb 2021 22:08:55 -0800 John Fastabend wrote:
> > Performance Testing
> >
> > The test environment is Aliyun ECS server.
> > Test cmd:
> > ```
> > xdpsock -i eth0 -t -S -s
> > ```
> >
> > Test result data:
> >
> > size64 512 10241500
>
On Thu, Feb 18, 2021 at 07:31:41PM +, Grant Grundler wrote:
> Oliver, Jakub,
> Can I post v4 and deal with the issues below?
You should probably wait for two weeks. We are far enough into the
merge window that i doubt it will get picked up. So please wait,
rebase, and then post.
> Nit: The v2
On Thu, Feb 18, 2021 at 09:36:54AM -0800, Xie He wrote:
> On Thu, Feb 18, 2021 at 2:37 AM Leon Romanovsky wrote:
> >
> > It is not me who didn't explain, it is you who didn't want to write clear
> > comment that describes the headroom size without need of "3 - 1".
>
> Why do I need to write unnece
syzbot has found a reproducer for the following issue on:
HEAD commit:3af409ca net: enetc: fix destroyed phylink dereference dur..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=12ee9f72d0
kernel config: https://syzkaller.appspot.com/x/.config?x=8cb23303ddb9
On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky wrote:
>
> This is how we write code, we use defines instead of constant numbers,
> comments to describe tricky parts and assign already preprocessed result.
>
> There is nothing I can do If you don't like or don't want to use Linux kernel
> style.
On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld wrote:
>
> On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn
> wrote:
> > Thanks for respinning.
> >
> > Making ipv4 and ipv6 more aligned is a good goal, but more for
> > net-next than bug fixes that need to be backported to many stable
> > bran
On Thu, Feb 18, 2021 at 12:06 PM Xie He wrote:
>
> On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky wrote:
> >
> > This is how we write code, we use defines instead of constant numbers,
> > comments to describe tricky parts and assign already preprocessed result.
> >
> > There is nothing I can do
On Thu, Feb 18, 2021 at 9:16 PM Willem de Bruijn
wrote:
>
> On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld wrote:
> >
> > On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn
> > wrote:
> > > Thanks for respinning.
> > >
> > > Making ipv4 and ipv6 more aligned is a good goal, but more for
> > >
The icmp{,v6}_send functions make all sorts of use of skb->cb, casting
it with IPCB or IP6CB, assuming the skb to have come directly from the
inet layer. But when the packet comes from the ndo layer, especially
when forwarded, there's no telling what might be in skb->cb at that
point. As a result,
On Thu, Feb 18, 2021 at 3:25 PM Jason A. Donenfeld wrote:
>
> On Thu, Feb 18, 2021 at 9:16 PM Willem de Bruijn
> wrote:
> >
> > On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld wrote:
> > >
> > > On Thu, Feb 18, 2021 at 5:34 PM Willem de Bruijn
> > > wrote:
> > > > Thanks for respinning.
> >
On Thu, Feb 18, 2021 at 9:37 PM Willem de Bruijn
wrote:
>
> On Thu, Feb 18, 2021 at 3:25 PM Jason A. Donenfeld wrote:
> >
> > On Thu, Feb 18, 2021 at 9:16 PM Willem de Bruijn
> > wrote:
> > >
> > > On Thu, Feb 18, 2021 at 12:58 PM Jason A. Donenfeld
> > > wrote:
> > > >
> > > > On Thu, Feb 18,
This series introduces XSK generic zerocopy xmit by adding XSK umem
pages as skb frags instead of copying data to linear space.
The only requirement for this for drivers is to be able to xmit skbs
with skb_headlen(skb) == 0, i.e. all data including hard headers
starts from frag 0.
To indicate wheth
This is harmless for now, but can be fatal for future refactors.
Fixes: 871b642adebe3 ("netdev: introduce ndo_set_rx_headroom")
Signed-off-by: Alexander Lobakin
Acked-by: John Fastabend
---
include/linux/netdevice.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/netdevice.h b
From: Xuan Zhuo
In some cases, we hope to construct skb directly based on the existing
memory without copying data. In this case, the page will be placed
directly in the skb, and the linear space of skb is empty. But
unfortunately, many the network card does not support this operation.
For exampl
From: Xuan Zhuo
Virtio net supports the case where the skb linear space is empty, so add
priv_flags.
Signed-off-by: Xuan Zhuo
Acked-by: Michael S. Tsirkin
Signed-off-by: Alexander Lobakin
Acked-by: John Fastabend
---
drivers/net/virtio_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 delet
xsk_generic_xmit() allocates a new skb and then queues it for
xmitting. The size of new skb's headroom is desc->len, so it comes
to the driver/device with no reserved headroom and/or tailroom.
Lots of drivers need some headroom (and sometimes tailroom) to
prepend (and/or append) some headers or dat
From: Xuan Zhuo
This patch is used to construct skb based on page to save memory copy
overhead.
This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the
network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to
directly construct skb. If this feature is not supported, it
Hi all,
After merging the net-next tree, today's linux-next build (htmldocs)
produced these warnings:
Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string
without end-string.
Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string
without end-s
From: Michael Walle
Date: Thu, 18 Feb 2021 20:46:10 +0100
> Am 2021-02-18 20:26, schrieb Vladimir Oltean:
>> On Thu, Feb 18, 2021 at 07:52:38PM +0100, Michael Walle wrote:
>>> Add paging support to the QCA AR8031/33 PHY. This will be needed if we
>>> add support for the .config_inband_aneg callba
Following a similar reinstate for the KSZ9031.
Older kernels would use the genphy_soft_reset if the PHY did not
implement a .soft_reset.
Bluntly removing that default may expose a lot of situations where
various PHYs/board implementations won't recover on various changes.
Like with implement
From: Steen Hegelund
Date: Thu, 18 Feb 2021 17:14:47 +0100
> Adding the Sparx5 Serdes driver
>
The net-next tree is closed so this will have to wait until the next merge
window.
Thanks.
Hi Kishon,
On Tue, 2021-02-16 at 15:54 +0530, Kishon Vijay Abraham I wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> Hi,
>
> On 16/02/21 2:07 pm, Steen Hegelund wrote:
> > Hi Andrew and Kishon,
> >
> > On Mon, 2021-02-15 at 15:07 +0100,
Adding the Sparx5 Serdes driver
This series of patches provides the serdes driver for the Microchip Sparx5
ethernet switch.
The serdes driver supports the 10G and 25G serdes instances available in the
Sparx5.
The Sparx5 serdes support several interface modes with several speeds and also
allows t
Document the Sparx5 ethernet serdes phy driver bindings.
Signed-off-by: Lars Povlsen
Signed-off-by: Steen Hegelund
Reviewed-by: Rob Herring
Reviewed-by: Andrew Lunn
Reviewed-by: Alexandre Belloni
---
.../bindings/phy/microchip,sparx5-serdes.yaml | 100 ++
1 file changed, 100
Add Sparx5 serdes driver node, and enable it generally for all
reference boards.
Signed-off-by: Lars Povlsen
Signed-off-by: Steen Hegelund
Reviewed-by: Andrew Lunn
Reviewed-by: Alexandre Belloni
---
arch/arm64/boot/dts/microchip/sparx5.dtsi | 8
1 file changed, 8 insertions(+)
diff
Provide new phy configuration interfaces for media type and speed that
allows e.g. PHYs used for ethernet to be configured with this
information.
Signed-off-by: Lars Povlsen
Signed-off-by: Steen Hegelund
Reviewed-by: Andrew Lunn
Reviewed-by: Alexandre Belloni
---
drivers/phy/phy-core.c | 30
On Thu, Feb 18, 2021 at 11:49 AM Jonathan Corbet wrote:
>
> Joe Stringer writes:
> > * The changes in patch 16 here extended Documentation/bpf/index.rst,
> > but to assist in improving the overall kernel documentation
> > organisation / hierarchy, you would prefer to instead introduce a
> > dedic
1 - 100 of 123 matches
Mail list logo
