Re: [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add"

2021-02-15 Thread Alexandra Winter
Thank you very much Vladimir for improving this man page. I am still struggling with the meaning of the bridge attributes and sometimes the man page has caused more confusion. In the section about 'bridge link set' Self vs master mention physical device vs software bridge. Would it make sense to

Re: [PATCH 1/2 net-next] net/mlx5e: TC: Fix IS_ERR() vs NULL checks

2021-02-15 Thread Dan Carpenter
On Mon, Sep 28, 2020 at 06:31:04PM +, Ariel Levkovich wrote: > On Sep 28, 2020, at 13:42, Dan Carpenter wrote: > > > > The mlx5_tc_ct_init() function doesn't return error pointers it returns > > NULL. Also we need to set the error codes on this path. > > > > Fixes: aedd133d17bc ("net/mlx5e

Re: [PATCH net-next V1] net: followup adjust net_device layout for cacheline usage

2021-02-15 Thread Jesper Dangaard Brouer
On Fri, 12 Feb 2021 18:03:44 +0100 Eric Dumazet wrote: > On 2/12/21 2:50 PM, Jesper Dangaard Brouer wrote: > > As Eric pointed out in response to commit 28af22c6c8df ("net: adjust > > net_device layout for cacheline usage") the netdev_features_t members > > wanted_features and hw_features are onl

Re: [RFC PATCH v4 07/17] af_vsock: rest of SEQPACKET support

2021-02-15 Thread Arseny Krasnov
On 11.02.2021 15:27, Stefano Garzarella wrote: > On Sun, Feb 07, 2021 at 06:16:12PM +0300, Arseny Krasnov wrote: >> This does rest of SOCK_SEQPACKET support: >> 1) Adds socket ops for SEQPACKET type. >> 2) Allows to create socket with SEQPACKET type. >> >> Signed-off-by: Arseny Krasnov >> --- >>

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > Hi, > > Thanks for your review. > > On Mon, Feb 15, 2021 at 08:07:21AM +0200, Leon Romanovsky wrote: > > On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > > > Add dwmac-visconti to the stmmac driver in Toshiba V

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Leon Romanovsky
On Sun, Feb 14, 2021 at 11:27:03PM -0800, Xie He wrote: > When sending packets, we will first hand over the (L3) packets to the > LAPB module. The LAPB module will then hand over the corresponding LAPB > (L2) frames back to us for us to transmit. > > The LAPB module can also emit LAPB (L2) frames a

Re: [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add"

2021-02-15 Thread Vladimir Oltean
Hi Alexandra, On Mon, Feb 15, 2021 at 09:22:47AM +0100, Alexandra Winter wrote: > In the section about 'bridge link set' Self vs master mention physical > device vs software bridge. Would it make sense to use the same > terminology here? You mean like this? .TP .B self operation is fulfilled by

Re: [Patch bpf-next v3 1/5] bpf: clean up sockmap related Kconfigs

2021-02-15 Thread Lorenz Bauer
On Sat, 13 Feb 2021 at 21:44, Cong Wang wrote: > > From: Cong Wang > > As suggested by John, clean up sockmap related Kconfigs: > > Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream > parser, to reflect its name. > > Make the rest sockmap code simply depend on CONFIG_BPF_SYSCALL. >

Re: [PATCH 1/2] lockdep: add lockdep_assert_not_held()

2021-02-15 Thread Peter Zijlstra
On Sun, Feb 14, 2021 at 06:53:01PM +0100, Peter Zijlstra wrote: > On Fri, Feb 12, 2021 at 04:28:42PM -0700, Shuah Khan wrote: > > > +#define lockdep_assert_not_held(l) do {\ > > + WARN_ON(debug_locks && lockdep_is_held(l)); \ > > + } while (0) > > + > > This th

Re: [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add"

2021-02-15 Thread Alexandra Winter
On 15.02.21 11:32, Vladimir Oltean wrote: > Hi Alexandra, > > On Mon, Feb 15, 2021 at 09:22:47AM +0100, Alexandra Winter wrote: >> In the section about 'bridge link set' Self vs master mention physical >> device vs software bridge. Would it make sense to use the same >> terminology here? > > Y

Re: linux-next: manual merge of the net-next tree with the net tree

2021-02-15 Thread Guillaume Nault
On Mon, Feb 15, 2021 at 11:43:54AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > tools/testing/selftests/net/forwarding/tc_flower.sh > > between commit: > > d2126838050c ("flow_dissector: fix TTL and TOS dissection on IPv4

Re: Regressions with VMBus/VSCs hardening changes

2021-02-15 Thread Wei Liu
On Fri, Feb 12, 2021 at 05:50:50PM +0100, Andrea Parri wrote: > Hi all, [...] > 2) IIUC a8c3209998afb5 could be dropped (after rebase) without further modi- >fications to hyperv-next. I've reverted the said patch from hyperv-next. Wei.

Re: linux-next: manual merge of the net-next tree with the net tree

2021-02-15 Thread Davide Caratti
On Mon, 2021-02-15 at 12:01 +0100, Guillaume Nault wrote: > Before these commits, ALL_TESTS listed the tests in the order they were > implemented in the rest of the file. So I'd rather continue following > this implicit rule, if at all possible. Also it makes sense to keep > grouping all match_ip_*

[PATCH net] cxgb4/chtls/cxgbit: Keeping the max ofld immediate data size same in cxgb4 and ulds

2021-02-15 Thread Ayush Sawal
The Max imm data size in cxgb4 is not similar to the max imm data size in the chtls. This caused an mismatch in output of is_ofld_imm() of cxgb4 and chtls. So fixed this by keeping the max wreq size of imm data same in both chtls and cxgb4 as MAX_IMM_OFLD_TX_DATA_WR_LEN. As cxgb4's max imm. data v

Re: [RFC PATCH 03/13] nexthop: Add netlink defines and enumerators for resilient NH groups

2021-02-15 Thread Petr Machata
Ido Schimmel writes: > On Sat, Feb 13, 2021 at 12:16:45PM -0700, David Ahern wrote: >> On 2/8/21 1:42 PM, Petr Machata wrote: >> > @@ -52,8 +53,50 @@ enum { >> >NHA_FDB,/* flag; nexthop belongs to a bridge fdb */ >> >/* if NHA_FDB is added, OIF, BLACKHOLE, ENCAP cannot be set */

Re: [RFC PATCH 04/13] nexthop: Add implementation of resilient next-hop groups

2021-02-15 Thread Petr Machata
David Ahern writes: > On 2/8/21 1:42 PM, Petr Machata wrote: >> @@ -212,7 +254,7 @@ static inline bool nexthop_is_multipath(const struct >> nexthop *nh) >> struct nh_group *nh_grp; >> >> nh_grp = rcu_dereference_rtnl(nh->nh_grp); >> -return nh_grp->mpath

Re: linux-next: manual merge of the net-next tree with the net tree

2021-02-15 Thread Stephen Rothwell
Hi Davide, On Mon, 15 Feb 2021 12:35:37 +0100 Davide Caratti wrote: > > On Mon, 2021-02-15 at 12:01 +0100, Guillaume Nault wrote: > > Before these commits, ALL_TESTS listed the tests in the order they were > > implemented in the rest of the file. So I'd rather continue following > > this implicit

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-15 Thread Kishon Vijay Abraham I
Hi Steen, On 12/02/21 6:35 pm, Steen Hegelund wrote: > Hi Kishon, > > On Fri, 2021-02-12 at 17:02 +0530, Kishon Vijay Abraham I wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> Hi Steen, >> >> On 10/02/21 2:22 pm, Steen Hegelund wrote:

Re: [net-next] tcp: Sanitize CMSG flags and reserved args in tcp_zerocopy_receive.

2021-02-15 Thread Dan Carpenter
Hi Arjun, url: https://github.com/0day-ci/linux/commits/Arjun-Roy/tcp-Sanitize-CMSG-flags-and-reserved-args-in-tcp_zerocopy_receive/20210212-052537 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e4b62cf7559f2ef9a022de235e5a09a8d7ded520 config: x86_64-randconfig-m00

[PATCH] b43: N-PHY: Fix the update of coef for the PHY revision >= 3case

2021-02-15 Thread Colin King
From: Colin Ian King The documentation for the PHY update [1] states: Loop 4 times with index i If PHY Revision >= 3 Copy table[i] to coef[i] Otherwise Set coef[i] to 0 the copy of the table to coef is currently implemented the wrong way around, table is being updated f

Re: [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add"

2021-02-15 Thread Vladimir Oltean
On Mon, Feb 15, 2021 at 11:53:42AM +0100, Alexandra Winter wrote: > Actually, I found your first (more verbose) proposal more helpful. Sorry, I don't understand. Do you want me to copy the whole explanation from bridge fdb add to bridge link set? > >> Maybe I misunderstand this sentence, but I ca

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Arnd Bergmann
On Mon, Feb 15, 2021 at 10:23 AM Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > Sorry, I sent the wrong patchset that didn't fix this point out. > > > > > I asked it before, but never received an answer. > > > > I have received your point out an

AW: HSR/PRP sequence counter issue with Cisco Redbox

2021-02-15 Thread Wenzel, Marco
> On Wed, Jan 27, 2021 at 6:32 AM Wenzel, Marco eberle.de> wrote: > > > > Hi, > > > > we have figured out an issue with the current PRP driver when trying to > communicate with Cisco IE 2000 industrial Ethernet switches in Redbox > mode. The Cisco always resets the HSR/PRP sequence counter to "1"

Re: [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add"

2021-02-15 Thread Alexandra Winter
On 15.02.21 13:13, Vladimir Oltean wrote: > On Mon, Feb 15, 2021 at 11:53:42AM +0100, Alexandra Winter wrote: >> Actually, I found your first (more verbose) proposal more helpful. > > Sorry, I don't understand. Do you want me to copy the whole explanation > from bridge fdb add to bridge link se

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-15 Thread Calvin Johnson
On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 08, 2021 at 08:42:44PM +0530, Calvin Johnson wrote: > > Modify dpaa2_mac_connect() to support ACPI along with DT. > > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > > DT or ACPI. > > >

Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville

2021-02-15 Thread Dan Carpenter
Hi Vladimir, url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b config: i386-randconfig-m031-20210209 (attached as .confi

Re: [PATCH 1/2] lockdep: add lockdep_assert_not_held()

2021-02-15 Thread Johannes Berg
On Mon, 2021-02-15 at 11:44 +0100, Peter Zijlstra wrote: > > I think something like so will work, but please double check. Yeah, that looks better. > +++ b/include/linux/lockdep.h > @@ -294,11 +294,15 @@ extern void lock_unpin_lock(struct lockdep_map *lock, > struct pin_cookie); > > #define

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-15 Thread Bjarni.Jonasson
On Fri, 2021-02-12 at 16:20 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote: > > +static u32 vsc85xx_csr_read(struct phy_device *phydev, > > +

Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville

2021-02-15 Thread Vladimir Oltean
Hi Dan, On Mon, Feb 15, 2021 at 04:00:04PM +0300, Dan Carpenter wrote: > db->index is less than db->num_ports which 32 or less but sometimes it > comes from the device tree so who knows. The destination port mask is copied into a 12-bit field of the packet, starting at bit offset 67 and ending at

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-15 Thread Bjarni.Jonasson
On Fri, 2021-02-12 at 16:54 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote: > > At Power-On Reset, transients may cause the LCPLL to lock onto a > > clock t

[PATCH net-next] net: mscc: ocelot: avoid type promotion when calling ocelot_ifh_set_dest

2021-02-15 Thread Vladimir Oltean
From: Vladimir Oltean Smatch is confused by the fact that a 32-bit BIT(port) macro is passed as argument to the ocelot_ifh_set_dest function and warns: ocelot_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type? seville_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type? Th

Re: [PATCH net v1 3/3] net: phy: mscc: coma mode disabled for VSC8514

2021-02-15 Thread Bjarni.Jonasson
On Fri, 2021-02-12 at 16:32 +, Vladimir Oltean wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Fri, Feb 12, 2021 at 03:06:43PM +0100, Bjarni Jonasson wrote: > > The 'coma mode' (configurable through sw or hw) provides an > > optional

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-15 Thread Bjarni.Jonasson
On Fri, 2021-02-12 at 10:53 -0800, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Fri, 12 Feb 2021 15:06:41 +0100 Bjarni Jonasson wrote: > > At Power-On Reset, transients may cause the LCPLL to lock onto a > > clock that

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Marek Behun
On Mon, 15 Feb 2021 06:15:59 + Nathan Rossi wrote: > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > b/drivers/net/dsa/mv88e6xxx/chip.c > index 54aa942eed..5c52906b29 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -650,6 +650,13 @@ static void m

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-15 Thread Andrew Lunn
On Mon, Feb 15, 2021 at 05:25:10PM +0530, Kishon Vijay Abraham I wrote: > Okay. Is it going to be some sort of manual negotiation where the > Ethernet controller invokes set_speed with different speeds? Or the > Ethernet controller will get the speed using some out of band mechanism > and invokes s

Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville

2021-02-15 Thread Dan Carpenter
On Mon, Feb 15, 2021 at 03:19:31PM +0200, Vladimir Oltean wrote: > Hi Dan, > > On Mon, Feb 15, 2021 at 04:00:04PM +0300, Dan Carpenter wrote: > > db->index is less than db->num_ports which 32 or less but sometimes it > > comes from the device tree so who knows. > > The destination port mask is co

[PATCH v1 2/3] string: Move onoff() helper under string.h hood

2021-02-15 Thread Andy Shevchenko
We have already an implementation and a lot of code that can benefit of the onoff() helper. Move it under string.h hood. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/i915_utils.h | 5 - include/linux/string.h| 5 + 2 files changed, 5 insertions(+), 5 deletions(-)

[PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
We have already few similar implementation and a lot of code that can benefit of the yesno() helper. Consolidate yesno() helpers under string.h hood. Signed-off-by: Andy Shevchenko --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 6 +- drivers/gpu/drm/i915/i915_utils.h

[PATCH v1 3/3] string: Move enableddisabled() helper under string.h hood

2021-02-15 Thread Andy Shevchenko
We have already an implementation and a lot of code that can benefit of the enableddisabled() helper. Move it under string.h hood. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/i915_utils.h | 5 - include/linux/string.h| 5 + 2 files changed, 5 insertions(+), 5 dele

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Christian König
Am 15.02.21 um 15:21 schrieb Andy Shevchenko: We have already few similar implementation and a lot of code that can benefit of the yesno() helper. Consolidate yesno() helpers under string.h hood. Signed-off-by: Andy Shevchenko Looks like a good idea to me, feel free to add an Acked-by: Chris

commit 0f0aefd733f7 to linux-firmware effectively broke all of the setups with old kernels

2021-02-15 Thread Andy Shevchenko
Hi! Seems the commit 0f0aefd733f7 to linux-firmware effectively broke all of the setups with the old kernels. Firmware name is an ABI (!) and replacing it like this will definitely break systems with older kernels. Linux firmware package likely, but unfortunately, should carry on both versions as

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Jani Nikula
On Mon, 15 Feb 2021, Andy Shevchenko wrote: > We have already few similar implementation and a lot of code that can benefit > of the yesno() helper. Consolidate yesno() helpers under string.h hood. Good luck. I gave up after just four versions. [1] Acked-by: Jani Nikula BR, Jani. [1] http:

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
+Cc: Sakari and printk people On Mon, Feb 15, 2021 at 4:28 PM Christian König wrote: > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood.

Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville

2021-02-15 Thread Vladimir Oltean
On Mon, Feb 15, 2021 at 05:15:21PM +0300, Dan Carpenter wrote: > On Mon, Feb 15, 2021 at 03:19:31PM +0200, Vladimir Oltean wrote: > > Hi Dan, > > > > On Mon, Feb 15, 2021 at 04:00:04PM +0300, Dan Carpenter wrote: > > > db->index is less than db->num_ports which 32 or less but sometimes it > > > com

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Russell King - ARM Linux admin
On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > On Mon, 15 Feb 2021 06:15:59 + > Nathan Rossi wrote: > > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > > b/drivers/net/dsa/mv88e6xxx/chip.c > > index 54aa942eed..5c52906b29 100644 > > --- a/drivers/net/dsa/mv88e6xxx/chip.c >

Re: [net-next] tcp: Sanitize CMSG flags and reserved args in tcp_zerocopy_receive.

2021-02-15 Thread David Ahern
On 2/15/21 5:03 AM, Dan Carpenter wrote: > Hi Arjun, > > url: > https://github.com/0day-ci/linux/commits/Arjun-Roy/tcp-Sanitize-CMSG-flags-and-reserved-args-in-tcp_zerocopy_receive/20210212-052537 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > e4b62cf7559f2ef9a

Re: [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-15 Thread Maxime Chevallier
Hi Pali, On Mon, 15 Feb 2021 00:50:58 +0100 Pali Rohár wrote: >> According to Errata #23 "The per-CPU GbE interrupt is limited to Core >> 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 >> familly. >> >> This is correctly checked for RSS configuration, but the initial queue

Re: [PATCH net-next 2/2] net: mvneta: Implement mqprio support

2021-02-15 Thread Maxime Chevallier
Hi Andrew, On Sat, 13 Feb 2021 20:45:25 +0100 Andrew Lunn wrote: >On Fri, Feb 12, 2021 at 04:12:20PM +0100, Maxime Chevallier wrote: >> +static void mvneta_setup_rx_prio_map(struct mvneta_port *pp) >> +{ >> +int i; >> +u32 val = 0; > >Hi Maxime > >Reverse Chrismtass tree please. Ah ye

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Andrew Lunn
> If we can't switch between 1000base-X and 2500base-X, then we should > not be calling phylink_helper_basex_speed() - and only one of those > two capabilities should be set in the validation callback. I thought > there were DSA switches where we could program the CMODE to switch > between these tw

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson wrote: > On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin > wrote: ... > I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > --- a/drivers/net/mdio/of_mdio.c > +++ b/drivers/net/mdio/of_mdio.c > @@ -439

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Nobuhiro Iwamatsu
Hi, On Mon, Feb 15, 2021 at 11:22:33AM +0200, Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > I have received your point out and have sent an email with the content > > to remove this line. But it may not have arrived yet... > > > > > Why did you

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 5:13 PM Andy Shevchenko wrote: > > On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson > wrote: > > On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin > > wrote: > > ... > > > I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > > > -

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Marek Behun
On Mon, 15 Feb 2021 14:57:57 + Russell King - ARM Linux admin wrote: > On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > > On Mon, 15 Feb 2021 06:15:59 + > > Nathan Rossi wrote: > > > > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > > > b/drivers/net/dsa/mv88e6xxx/chi

general protection fault in nl802154_add_llsec_key

2021-02-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:57baf8cc net: axienet: Handle deferred probe on clock prop.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=15c84ed2d0 kernel config: https://syzkaller.appspot.com/x/.config?x=8cb23303ddb9411f dashboar

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Nobuhiro Iwamatsu
Hi, On Mon, Feb 15, 2021 at 01:19:18PM +0100, Arnd Bergmann wrote: > On Mon, Feb 15, 2021 at 10:23 AM Leon Romanovsky wrote: > > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > > > Sorry, I sent the wrong patchset that didn't fix this point out. > > > > > > > I asked it

[net-next] net: mvpp2: Add TX flow control support for jumbo frames

2021-02-15 Thread stefanc
From: Stefan Chulski With MTU less than 1500B on all ports, the driver uses per CPU pool mode. If one of the ports set to jumbo frame MTU size, all ports move to shared pools mode. Here, buffer manager TX Flow Control reconfigured on all ports. Signed-off-by: Stefan Chulski --- drivers/net/eth

selftests: tls: multi_chunk_sendfile: Test terminated by timeout (constant failure)

2021-02-15 Thread Paolo Pisati
Hi Pooja, commit 0e6fbe39bdf71b4e665767bcbf53567a3e6d0623 Author: Pooja Trivedi Date: Fri Jun 5 16:01:18 2020 + net/tls(TLS_SW): Add selftest for 'chunked' sendfile test your multi_chunk_sendfile test is constantly failing for me (x86_64 defconfig + tools/testing/selftests/net/config

[PATCH v4 1/4] dt-bindings: net: Add DT bindings for Toshiba Visconti TMPV7700 SoC

2021-02-15 Thread Nobuhiro Iwamatsu
Add device tree bindings for ethernet controller of Toshiba Visconti TMPV7700 SoC series. Signed-off-by: Nobuhiro Iwamatsu --- .../bindings/net/toshiba,visconti-dwmac.yaml | 85 +++ 1 file changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/toshi

[PATCH v4 0/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Nobuhiro Iwamatsu
Hi, This series is the ethernet driver for Toshiba's ARM SoC, Visconti[0]. This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files. Best regards, Nobuhiro [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-

[PATCH v4 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Nobuhiro Iwamatsu
Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. This patch contains only the basic function of the device. There is no clock control, PM, etc. yet. These will be added in the future. Signed-off-by: Nobuhiro Iwamatsu --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 +

[PATCH v4 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller

2021-02-15 Thread Nobuhiro Iwamatsu
Add the ethernet controller node in Toshiba Visconti5 SoC-specific DT file. And enable this node in TMPV7708 RM main board's board-specific DT file. Signed-off-by: Nobuhiro Iwamatsu --- .../boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 18 + arch/arm64/boot/dts/toshiba/tmpv7708.dtsi

[PATCH v4 3/4] MAINTAINERS: Add entries for Toshiba Visconti ethernet controller

2021-02-15 Thread Nobuhiro Iwamatsu
Add entries for Toshiba Visconti ethernet controller binding and driver. Signed-off-by: Nobuhiro Iwamatsu --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cbf4b94f89d4..6be4bdaabf32 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2641,8 +2641,1

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Russell King - ARM Linux admin
On Mon, Feb 15, 2021 at 04:16:27PM +0100, Marek Behun wrote: > On Mon, 15 Feb 2021 14:57:57 + > Russell King - ARM Linux admin wrote: > > > On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > > > On Mon, 15 Feb 2021 06:15:59 + > > > Nathan Rossi wrote: > > > > > > > diff --

Re: [PATCH net-next 4/4] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge

2021-02-15 Thread George McCollister
On Sun, Feb 14, 2021 at 9:54 AM Vladimir Oltean wrote: [snip] > diff --git a/net/dsa/tag_xrs700x.c b/net/dsa/tag_xrs700x.c > index 858cdf9d2913..215ecceea89e 100644 > --- a/net/dsa/tag_xrs700x.c > +++ b/net/dsa/tag_xrs700x.c > @@ -45,8 +45,7 @@ static struct sk_buff *xrs700x_rcv(struct sk_buff *sk

[PATCH bpf-next V1 0/2] bpf: Updates for BPF-helper bpf_check_mtu

2021-02-15 Thread Jesper Dangaard Brouer
The FIB lookup example[1] show how the IP-header field tot_len (iph->tot_len) is used as input to perform the MTU check. The recently added MTU check helper bpf_check_mtu() should also support this type of MTU check. Lets add this feature before merge window, please. This is a followup to 34b2021c

[PATCH bpf-next V1 2/2] selftests/bpf: Tests using bpf_check_mtu BPF-helper input mtu_len param

2021-02-15 Thread Jesper Dangaard Brouer
Add tests that use mtu_len as input parameter in BPF-helper bpf_check_mtu(). The BPF-helper is avail from both XDP and TC context. Add two tests per context, one that tests below MTU and one that exceeds the MTU. Signed-off-by: Jesper Dangaard Brouer --- tools/testing/selftests/bpf/prog_tests/c

[PATCH bpf-next V1 1/2] bpf: BPF-helper for MTU checking add length input

2021-02-15 Thread Jesper Dangaard Brouer
The FIB lookup example[1] show how the IP-header field tot_len (iph->tot_len) is used as input to perform the MTU check. This patch extend the BPF-helper bpf_check_mtu() with the same ability to provide the length as user parameter input, via mtu_len parameter. [1] samples/bpf/xdp_fwd_kern.c Sig

[PATCH bpf-next 0/3] Introduce bpf_link in libbpf's xsk

2021-02-15 Thread Maciej Fijalkowski
Hi, This set is another approach towards addressing the below issue: // load xdp prog and xskmap and add entry to xskmap at idx 10 $ sudo ./xdpsock -i ens801f0 -t -q 10 // add entry to xskmap at idx 11 $ sudo ./xdpsock -i ens801f0 -t -q 11 terminate one of the processes and another one is unabl

[PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Maciej Fijalkowski
Currently, if there are multiple xdpsock instances running on a single interface and in case one of the instances is terminated, the rest of them are left in an inoperable state due to the fact of unloaded XDP prog from interface. To address that, step away from setting bpf prog in favour of bpf_l

[PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get_fecparam()

2021-02-15 Thread Dan Carpenter
The "<= FEC_MAX_INDEX" comparison should be "< FEC_MAX_INDEX". I did some cleanup in this function to hopefully make the code a bit clearer. There was no blank line after the declaration block. The closing curly brace on the fec[] declaration normally goes on a line by itself. And I removed the

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Marek Behun
On Mon, 15 Feb 2021 15:29:44 + Russell King - ARM Linux admin wrote: > On Mon, Feb 15, 2021 at 04:16:27PM +0100, Marek Behun wrote: > > On Mon, 15 Feb 2021 14:57:57 + > > Russell King - ARM Linux admin wrote: > > > > > On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > >

Re: [PATCH 1/2] lockdep: add lockdep_assert_not_held()

2021-02-15 Thread Peter Zijlstra
On Mon, Feb 15, 2021 at 02:12:30PM +0100, Johannes Berg wrote: > On Mon, 2021-02-15 at 11:44 +0100, Peter Zijlstra wrote: > > > > I think something like so will work, but please double check. > > Yeah, that looks better. > > > +++ b/include/linux/lockdep.h > > @@ -294,11 +294,15 @@ extern void l

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote: > On Mon, 15 Feb 2021, Andy Shevchenko > wrote: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. > > Good luck. I gave u

Re: [net-next] tcp: Sanitize CMSG flags and reserved args in tcp_zerocopy_receive.

2021-02-15 Thread Dan Carpenter
On Mon, Feb 15, 2021 at 08:04:11AM -0700, David Ahern wrote: > On 2/15/21 5:03 AM, Dan Carpenter wrote: > > Hi Arjun, > > > > url: > > https://github.com/0day-ci/linux/commits/Arjun-Roy/tcp-Sanitize-CMSG-flags-and-reserved-args-in-tcp_zerocopy_receive/20210212-052537 > > > > base: https://

Re: [PATCH bpf-next 0/3] Introduce bpf_link in libbpf's xsk

2021-02-15 Thread Björn Töpel
On 2021-02-15 16:46, Maciej Fijalkowski wrote: Hi, This set is another approach towards addressing the below issue: // load xdp prog and xskmap and add entry to xskmap at idx 10 $ sudo ./xdpsock -i ens801f0 -t -q 10 // add entry to xskmap at idx 11 $ sudo ./xdpsock -i ens801f0 -t -q 11 termin

[PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock

2021-02-15 Thread Maciej Fijalkowski
With the introduction of bpf_link in xsk's libbpf part, there's no further need for explicit unload of prog on xdpsock's termination. When process dies, the bpf_link's refcount will be decremented and resources will be unloaded/freed under the hood in case when there are no more active users. Whil

Re: [PATCH 1/2] lockdep: add lockdep_assert_not_held()

2021-02-15 Thread Johannes Berg
On Mon, 2021-02-15 at 17:04 +0100, Peter Zijlstra wrote: > On Mon, Feb 15, 2021 at 02:12:30PM +0100, Johannes Berg wrote: > > On Mon, 2021-02-15 at 11:44 +0100, Peter Zijlstra wrote: > > > I think something like so will work, but please double check. > > > > Yeah, that looks better. > > > > > +++

Re: [PATCH] b43: N-PHY: Fix the update of coef for the PHY revision >= 3case

2021-02-15 Thread Larry Finger
On 2/15/21 6:05 AM, Colin King wrote: From: Colin Ian King The documentation for the PHY update [1] states: Loop 4 times with index i If PHY Revision >= 3 Copy table[i] to coef[i] Otherwise Set coef[i] to 0 the copy of the table to coef is currently implemented th

[PATCH][next] i40e: Fix uninitialized variable mfs_max

2021-02-15 Thread Colin King
From: Colin Ian King The variable mfs_max is not initialized and is being compared to find the maximum value. Fix this by initializing it to 0. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 90bc8e003be2 ("i40e: Add hardware configuration for software based DCB") Signed-off-by: Col

[PATCH bpf-next 2/3] libbpf: clear map_info before each bpf_obj_get_info_by_fd

2021-02-15 Thread Maciej Fijalkowski
xsk_lookup_bpf_maps, based on prog_fd, looks whether current prog has a reference to XSKMAP. BPF prog can include insns that work on various BPF maps and this is covered by iterating through map_ids. The bpf_map_info that is passed to bpf_obj_get_info_by_fd for filling needs to be cleared at each

RE: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-02-15 Thread Stefan Chulski
> > > I discussed it with Andrew earlier last year, and his response was: > > > > > > DT configuration of pause for fixed link probably is sufficient. I > > > don't remember it ever been really discussed for DSA. It was a > > > Melanox discussion about limiting pause for the CPU. So I think it >

[PATCH] i40e: Fix incorrect use of ip6src due to copy-paste coding error

2021-02-15 Thread Colin King
From: Colin Ian King It appears that the call of ipv6_add_any for the destination address is using ip6src instead of ip6dst, this looks like a copy-paste coding error. Fix this by replacing ip6src with ip6dst. Addresses-Coverity: ("Copy-paste error") Fixes: efca91e89b67 ("i40e: Add flow director

Re: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-02-15 Thread Russell King - ARM Linux admin
On Mon, Feb 15, 2021 at 04:19:19PM +, Stefan Chulski wrote: > > > > I discussed it with Andrew earlier last year, and his response was: > > > > > > > > DT configuration of pause for fixed link probably is sufficient. I > > > > don't remember it ever been really discussed for DSA. It was a > >

Re: HSR/PRP sequence counter issue with Cisco Redbox

2021-02-15 Thread George McCollister
On Mon, Feb 15, 2021 at 6:30 AM Wenzel, Marco wrote: > > > On Wed, Jan 27, 2021 at 6:32 AM Wenzel, Marco > eberle.de> wrote: > > > > > > Hi, > > > > > > we have figured out an issue with the current PRP driver when trying to > > communicate with Cisco IE 2000 industrial Ethernet switches in Redbo

re: octeontx2-af: cn10k: MAC internal loopback support

2021-02-15 Thread Colin Ian King
Hi, Static analysis on linux-next today using Coverity found an issue in the following commit: commit 3ad3f8f93c81f81d6e28b2e286b03669cc1fb3b0 Author: Hariprasad Kelam Date: Thu Feb 11 21:28:34 2021 +0530 octeontx2-af: cn10k: MAC internal loopback support The analysis is as follows: 723

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Toke Høiland-Jørgensen
Maciej Fijalkowski writes: > Currently, if there are multiple xdpsock instances running on a single > interface and in case one of the instances is terminated, the rest of > them are left in an inoperable state due to the fact of unloaded XDP > prog from interface. > > To address that, step away

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Xie He
On Mon, Feb 15, 2021 at 1:25 AM Leon Romanovsky wrote: > > > + /* When transmitting data: > > + * first we'll remove a pseudo header of 1 byte, > > + * then the LAPB module will prepend an LAPB header of at most 3 > > bytes. > > + */ > > + dev->needed_headroom = 3 - 1; > >

Re: [PATCH net-next 4/4] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge

2021-02-15 Thread Vladimir Oltean
Hi George, On Mon, Feb 15, 2021 at 09:48:38AM -0600, George McCollister wrote: > On Sun, Feb 14, 2021 at 9:54 AM Vladimir Oltean wrote: > [snip] > > diff --git a/net/dsa/tag_xrs700x.c b/net/dsa/tag_xrs700x.c > > index 858cdf9d2913..215ecceea89e 100644 > > --- a/net/dsa/tag_xrs700x.c > > +++ b/net

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Björn Töpel
On 2021-02-15 18:07, Toke Høiland-Jørgensen wrote: Maciej Fijalkowski writes: Currently, if there are multiple xdpsock instances running on a single interface and in case one of the instances is terminated, the rest of them are left in an inoperable state due to the fact of unloaded XDP prog f

[net-next PATCH] octeontx2-af: cn10k: Fixes CN10K RPM reference issue

2021-02-15 Thread Geetha sowjanya
This patch fixes references to uninitialized variables and debugfs entry name for CN10K platform and HW_TSO flag check. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham This patch fixes the bug introduced by the commit 3ad3f8f93c81 ("octeontx2-af: cn10k: MAC internal loopback suppor

Re: [EXT] re: octeontx2-af: cn10k: MAC internal loopback support

2021-02-15 Thread Geethasowjanya Akula
Hi Colin, I have submitted the patch fixing the reported issue to net-next branch. Thank you, Geetha. From: Colin Ian King Sent: Monday, February 15, 2021 10:22 PM To: Hariprasad Kelam Cc: Sunil Kovvuri Goutham; Linu Cherian; Geethasowjanya Akula; Jerin

Re: commit 0f0aefd733f7 to linux-firmware effectively broke all of the setups with old kernels

2021-02-15 Thread Peter Robinson
> Seems the commit 0f0aefd733f7 to linux-firmware effectively broke all > of the setups with the old kernels. Firmware name is an ABI (!) and > replacing it like this will definitely break systems with older > kernels. Linux firmware package likely, but unfortunately, should > carry on both version

Re: [PATCH net-next v2 1/7] mld: convert from timer to delayed work

2021-02-15 Thread Cong Wang
On Sun, Feb 14, 2021 at 2:56 AM Taehee Yoo wrote: > > > > On 21. 2. 14. 오전 4:07, Cong Wang wrote: > > On Sat, Feb 13, 2021 at 9:51 AM Taehee Yoo wrote: > >> -static void mld_dad_start_timer(struct inet6_dev *idev, unsigned > long delay) > >> +static void mld_dad_start_work(struct inet6_dev *id

Re: [net-next PATCH] octeontx2-af: cn10k: Fixes CN10K RPM reference issue

2021-02-15 Thread Sunil Kovvuri
On Mon, Feb 15, 2021 at 11:27 PM Geetha sowjanya wrote: > > This patch fixes references to uninitialized variables and > debugfs entry name for CN10K platform and HW_TSO flag check. > > Signed-off-by: Geetha sowjanya > Signed-off-by: Sunil Goutham > > This patch fixes the bug introduced by the c

Re: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-02-15 Thread Andrew Lunn
On Mon, Feb 15, 2021 at 04:19:19PM +, Stefan Chulski wrote: > > > > I discussed it with Andrew earlier last year, and his response was: > > > > > > > > DT configuration of pause for fixed link probably is sufficient. I > > > > don't remember it ever been really discussed for DSA. It was a > >

Re: commit 0f0aefd733f7 to linux-firmware effectively broke all of the setups with old kernels

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 8:03 PM Peter Robinson wrote: > > > Seems the commit 0f0aefd733f7 to linux-firmware effectively broke all > > of the setups with the old kernels. Firmware name is an ABI (!) and > > replacing it like this will definitely break systems with older > > kernels. Linux firmware

RE: [Patch bpf-next v3 1/5] bpf: clean up sockmap related Kconfigs

2021-02-15 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > As suggested by John, clean up sockmap related Kconfigs: > > Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream > parser, to reflect its name. > > Make the rest sockmap code simply depend on CONFIG_BPF_SYSCALL. > And leave CONFIG_NET_SOCK_MSG

[PATCH AUTOSEL 5.10 2/6] NET: usb: qmi_wwan: Adding support for Cinterion MV31

2021-02-15 Thread Sasha Levin
From: Christoph Schemmel [ Upstream commit a4dc7eee9106a9d2a6e08b442db19677aa9699c7 ] Adding support for Cinterion MV31 with PID 0x00B7. T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 11 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 P: Vendor=1e2d ProdID=00b7 Re

[PATCH AUTOSEL 5.10 3/6] cxgb4: Add new T6 PCI device id 0x6092

2021-02-15 Thread Sasha Levin
From: Raju Rangoju [ Upstream commit 3401e4aa43a540881cc97190afead650e709c418 ] Signed-off-by: Raju Rangoju Link: https://lore.kernel.org/r/20210202182511.8109-1-ra...@chelsio.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h

[PATCH AUTOSEL 5.4 1/4] NET: usb: qmi_wwan: Adding support for Cinterion MV31

2021-02-15 Thread Sasha Levin
From: Christoph Schemmel [ Upstream commit a4dc7eee9106a9d2a6e08b442db19677aa9699c7 ] Adding support for Cinterion MV31 with PID 0x00B7. T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 11 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 P: Vendor=1e2d ProdID=00b7 Re

  1   2   3   >