[PATCH v2 3/4] net: ti: am65-cpsw-nuss: Add switchdev support

2021-02-11 Thread Vignesh Raghavendra
J721e, J7200 and AM64 have multi port switches which can work in multi mac mode and in switch mode. Add support for configuring this HW in switch mode using devlink and switchdev notifiers. Support is similar to existing CPSW switchdev implementation of TI's 32 bit platform like AM33/AM43/AM57. T

[PATCH v2 4/4] docs: networking: ti: Add driver doc for AM65 NUSS switch driver

2021-02-11 Thread Vignesh Raghavendra
J721e, J7200 and AM64 have multi port switches which can work in multi mac mode and in switch mode. Add documentation explaining how to use different modes. Borrowed from: Documentation/networking/device_drivers/ethernet/ti/cpsw_switchdev.rst Signed-off-by: Vignesh Raghavendra --- .../device_dr

[PATCH v2 0/4] net: ti: am65-cpsw-nuss: Add switchdev driver

2021-02-11 Thread Vignesh Raghavendra
This series adds switchdev support for AM65 CPSW NUSS driver to support multi port CPSW present on J721e and AM64 SoCs. It adds devlink hook to switch b/w switch mode and multi mac mode. v2: Rebased on latest net-next Update patch 1/4 with rationale for using devlink Vignesh Raghavendra (4): ne

Re: [RFC PATCH v4 12/17] virtio/vsock: rest of SOCK_SEQPACKET support

2021-02-11 Thread Arseny Krasnov
On 07.02.2021 18:17, Arseny Krasnov wrote: > This adds rest of logic for SEQPACKET: > 1) Packet's type is now set in 'virtio_send_pkt_info()' using >type of socket. > 2) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END. >Note that both functions may sleep to wait enough space for

Re: [PATCH netdev] virtio-net: support XDP_TX when not more queues

2021-02-11 Thread Jesper Dangaard Brouer
On Wed, 10 Feb 2021 16:40:41 -0500 "Michael S. Tsirkin" wrote: > On Wed, Jan 13, 2021 at 04:08:57PM +0800, Xuan Zhuo wrote: > > The number of queues implemented by many virtio backends is limited, > > especially some machines have a large number of CPUs. In this case, it > > is often impossible t

Re: [PATCH v13 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:48PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > Patch adds CM3 address space and PPv2.3 description. > > Signed-off-by: Stefan Chulski > Acked-by: Marcin Wojtas It seems this is missing the ack that you got from Rob in your previous posting. You

Re: [PATCH v13 net-next 03/15] net: mvpp2: add CM3 SRAM memory map

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:50PM +0200, stef...@marvell.com wrote: > +static int mvpp2_get_sram(struct platform_device *pdev, > + struct mvpp2 *priv) > +{ > + struct resource *res; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 2); > + if (!res) { > +

Re: [PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:51PM +0200, stef...@marvell.com wrote: > @@ -1199,7 +1199,7 @@ static bool mvpp2_port_supports_xlg(struct mvpp2_port > *port) > > static bool mvpp2_port_supports_rgmii(struct mvpp2_port *port) > { > - return !(port->priv->hw_version == MVPP22 && port->gop_id =

Re: [PATCH v13 net-next 06/15] net: mvpp2: increase BM pool and RXQ size

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:53PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > BM pool and RXQ size increased to support Firmware Flow Control. > Minimum depletion thresholds to support FC are 1024 buffers. > BM pool size increased to 2048 to have some 1024 buffers > space betwee

RE: [EXT] Re: [PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21

2021-02-11 Thread Stefan Chulski
> On Thu, Feb 11, 2021 at 12:48:51PM +0200, stef...@marvell.com wrote: > > @@ -1199,7 +1199,7 @@ static bool mvpp2_port_supports_xlg(struct > > mvpp2_port *port) > > > > static bool mvpp2_port_supports_rgmii(struct mvpp2_port *port) { > > - return !(port->priv->hw_version == MVPP22 && port->gop

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-11 Thread Kalle Valo
Shuah Khan writes: > On 2/10/21 1:25 AM, Kalle Valo wrote: >> Shuah Khan writes: >> >>> ath10k_drain_tx() must not be called with conf_mutex held as workers can >>> use that also. Add check to detect conf_mutex held calls. >>> >>> Signed-off-by: Shuah Khan >> >> The commit log does not answer t

Re: [PATCH 5/5] ath10k: reduce invalid ht params rate message noise

2021-02-11 Thread Kalle Valo
Shuah Khan writes: > On 2/10/21 1:28 AM, Kalle Valo wrote: >> Wen Gong writes: >> >>> On 2021-02-10 08:42, Shuah Khan wrote: ath10k_mac_get_rate_flags_ht() floods dmesg with the following messages, when it fails to find a match for mcs=7 and rate=1440. supported_ht_mcs_r

Re: [RFC PATCH v4 02/17] af_vsock: separate wait data loop

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:14:48PM +0300, Arseny Krasnov wrote: This moves wait loop for data to dedicated function, because later it will be used by SEQPACKET data receive loop. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 158 +-- 1 file chan

Re: [PATCH net-next] net: ipa: pass checksum trailer with received packets

2021-02-11 Thread Alex Elder
On 2/10/21 3:13 PM, Alex Elder wrote: For a QMAP RX endpoint, received packets will be passed to the RMNet driver. If RX checksum offload is enabled, the RMNet driver expects to find a trailer following each packet that contains computed checksum information. Currently the IPA driver is passing

Re: [PATCH net-next] net: initialize net->net_cookie at netns setup

2021-02-11 Thread Lorenz Bauer
On Wed, 10 Feb 2021 at 14:41, Eric Dumazet wrote: > > From: Eric Dumazet > > It is simpler to make net->net_cookie a plain u64 > written once in setup_net() instead of looping > and using atomic64 helpers. > > Lorenz Bauer wants to add SO_NETNS_COOKIE socket option > and this patch would makes hi

[PATCH net-next 0/3] Compile-flag for sock RX queue mapping

2021-02-11 Thread Tariq Toukan
Hi, Socket's RX queue mapping logic is useful also for non-XPS use cases. This series breaks the dependency between the two, introducing a new kernel config flag SOCK_RX_QUEUE_MAPPING. Here we select this new kernel flag from TLS_DEVICE, as well as XPS. Regards, Tariq Tariq Toukan (3): net/so

[PATCH net-next 1/3] net/sock: Add kernel config SOCK_RX_QUEUE_MAPPING

2021-02-11 Thread Tariq Toukan
Use a new config SOCK_RX_QUEUE_MAPPING to compile-in the socket RX queue field and logic, instead of the XPS config. This breaks dependency in XPS, and allows selecting it from non-XPS use cases, as we do in the next patch. In addition, use the new flag to wrap the logic in sk_rx_queue_get() and p

[PATCH net-next 3/3] net/mlx5: Remove TLS dependencies on XPS

2021-02-11 Thread Tariq Toukan
No real dependency on XPS, but on RX queue mapping, which is being selected by TLS_DEVICE. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core

[PATCH net-next 2/3] net/tls: Select SOCK_RX_QUEUE_MAPPING from TLS_DEVICE

2021-02-11 Thread Tariq Toukan
Compile-in the socket RX queue mapping field and logic when TLS_DEVICE is enabled. This allows device drivers to pick the recorded socket's RX queue and use it for streams distribution. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy --- net/tls/Kconfig | 1 + 1 file changed, 1 inse

Re: [RFC PATCH v4 03/17] af_vsock: separate receive data loop

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:15:05PM +0300, Arseny Krasnov wrote: This moves STREAM specific data receive logic to dedicated function: '__vsock_stream_recvmsg()', while checks that will be same for both types of socket are in shared function: 'vsock_connectible_recvmsg()'. Signed-off-by: Arseny Kr

Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:52PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > This patch add PPv23 version definition. > PPv23 is new packet processor in CP115. > Everything that supported by PPv22, also supported by PPv23. > No functional changes in this stage. > > Signed-off-

Re: [RFC PATCH v4 04/17] af_vsock: implement SEQPACKET receive loop

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:15:22PM +0300, Arseny Krasnov wrote: This adds receive loop for SEQPACKET. It looks like receive loop for STREAM, but there is a little bit difference: 1) It doesn't call notify callbacks. 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because there

RE: [EXT] Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition

2021-02-11 Thread Stefan Chulski
> -- > On Thu, Feb 11, 2021 at 12:48:52PM +0200, stef...@marvell.com wrote: > > From: Stefan Chulski > > > > This patch add PPv23 version definition. > > PPv23 is new packet processor in CP115. > > Everything that supported by PPv

[PATCH net-next 5.12 2/8] dt-bindings: net: bcm4908-enet: include ethernet-controller.yaml

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki It should be /included/ by every Ethernet controller binding. It adds support for various generic properties. Suggested-by: Rob Herring Signed-off-by: Rafał Miłecki --- Documentation/devicetree/bindings/net/brcm,bcm4908-enet.yaml | 3 +++ 1 file changed, 3 insertions(+) d

[PATCH net-next 5.12 0/8] bcm4908_enet: post-review fixes

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki V2 of my BCM4908 Ethernet patchset was applied to the net-next.git and it was later that is received some extra reviews. I'm sending patches that handle pointed out issues. David: earler I missed that V2 was applied and I sent V3 and V4 of my inital patchset. Sorry for that.

[PATCH net-next 5.12 1/8] dt-bindings: net: rename BCM4908 Ethernet binding

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki Rob pointed out that a normal convention is "brcm,bcm4908-enet" so update whole binding to match it. Suggested-by: Rob Herring Signed-off-by: Rafał Miłecki --- .../net/{brcm,bcm4908enet.yaml => brcm,bcm4908-enet.yaml} | 6 +++--- MAINTAINERS

[PATCH net-next 5.12 3/8] net: broadcom: rename BCM4908 driver & update DT binding

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki compatible string was updated to match normal naming convention so update driver as well Signed-off-by: Rafał Miłecki --- MAINTAINERS | 2 +- drivers/net/ethernet/broadcom/Kconfig | 2 +- drivers/net/ethernet/broadcom/Makefile

[PATCH net-next 5.12 4/8] net: broadcom: bcm4908_enet: drop unneeded memset()

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki dma_alloc_coherent takes care of zeroing allocated memory Suggested-by: Andrew Lunn Signed-off-by: Rafał Miłecki Reviewed-by: Andrew Lunn --- drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bc

[PATCH net-next 5.12 5/8] net: broadcom: bcm4908_enet: drop "inline" from C functions

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki It seems preferred to let compiler optimize code if applicable. While at it drop unused enet_umac_maskset(). Suggested-by: Andrew Lunn Signed-off-by: Rafał Miłecki Reviewed-by: Andrew Lunn --- drivers/net/ethernet/broadcom/bcm4908_enet.c | 19 +++ 1 file c

Re: [RFC PATCH v4 05/17] af_vsock: separate wait space loop

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:15:41PM +0300, Arseny Krasnov wrote: This moves loop that waits for space on send to separate function, because it will be used for SEQ_BEGIN/SEQ_END sending before and after data transmission. Waiting for SEQ_BEGIN/SEQ_END is needed because such packets carries SEQPACK

[PATCH net-next 5.12 6/8] net: broadcom: bcm4908_enet: fix minor typos

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki 1. Fix "ensable" typo noticed by Andrew 2. Fix chipset name in the struct net_device_ops variable Suggested-by: Andrew Lunn Signed-off-by: Rafał Miłecki Reviewed-by: Andrew Lunn --- drivers/net/ethernet/broadcom/bcm4908_enet.c | 10 +- 1 file changed, 5 insertions

[PATCH net-next 5.12 7/8] net: broadcom: bcm4908_enet: fix received skb length

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki Use ETH_FCS_LEN instead of magic value and drop incorrect + 2 Signed-off-by: Rafał Miłecki --- drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethern

[PATCH net-next 5.12 8/8] net: broadcom: bcm4908_enet: fix endianness in xmit code

2021-02-11 Thread Rafał Miłecki
From: Rafał Miłecki Use le32_to_cpu() for reading __le32 struct field filled by hw. Signed-off-by: Rafał Miłecki --- drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethe

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Pavel Machek
On Thu 2021-01-14 12:05:21, Heiner Kallweit wrote: > On 14.01.2021 11:41, claudiu.bez...@microchip.com wrote: > > > > > > On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: > >> > >> As I've said, if phylib/PHY driver is not restoring the state of the > >> PHY on resume from suspend-to-ra

Re: [RFC PATCH v4 06/17] af_vsock: implement send logic for SEQPACKET

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:15:57PM +0300, Arseny Krasnov wrote: This adds some logic to current stream enqueue function for SEQPACKET support: 1) Send record's begin/end marker. 2) Return value from enqueue function is whole record length or error for SOCK_SEQPACKET. Signed-off-by: Arseny Kras

Re: [PATCH bpf-next 4/4] kbuild: Add resolve_btfids clean to root clean target

2021-02-11 Thread Jiri Olsa
On Wed, Feb 10, 2021 at 11:26:28AM -0800, Andrii Nakryiko wrote: SNIP > > > > Can't reproduce it. It works in all kinds of variants (relative and > > > > absolute O=, clean and not clean trees, etc). Jiri, please check as > > > > well. > > > > > > > > > > Odd, this reproduces for me on a complete

Re: [RFC PATCH v4 07/17] af_vsock: rest of SEQPACKET support

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:16:12PM +0300, Arseny Krasnov wrote: This does rest of SOCK_SEQPACKET support: 1) Adds socket ops for SEQPACKET type. 2) Allows to create socket with SEQPACKET type. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 37 -

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Heiner Kallweit
On 11.02.2021 13:17, Pavel Machek wrote: > On Thu 2021-01-14 12:05:21, Heiner Kallweit wrote: >> On 14.01.2021 11:41, claudiu.bez...@microchip.com wrote: >>> >>> >>> On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: As I've said, if phylib/PHY driver is not restoring the state of

[PATCH bpf-next] kbuild: Do not clean resolve_btfids if the output does not exist

2021-02-11 Thread Jiri Olsa
Nathan reported issue with cleaning empty build directory: $ make -s O=build distclean ../../scripts/Makefile.include:4: *** \ O=/ho...build/tools/bpf/resolve_btfids does not exist. Stop. The problem that tools scripts require existing output directory, otherwise it fails. Adding check ar

Re: [PATCH v13 net-next 07/15] net: mvpp2: add FCA periodic timer configurations

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:54PM +0200, stef...@marvell.com wrote: > @@ -751,6 +760,10 @@ > #define MVPP2_TX_FIFO_THRESHOLD(kb) \ > ((kb) * 1024 - MVPP2_TX_FIFO_THRESHOLD_MIN) > > +/* MSS Flow control */ > +#define FC_QUANTA0x > +#define FC_CLK_DIVIDER

Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:55PM +0200, stef...@marvell.com wrote: > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 761f745..8b4073c 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethern

Re: [PATCH v13 net-next 09/15] net: mvpp2: enable global flow control

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:56PM +0200, stef...@marvell.com wrote: > +static void mvpp2_cm3_write(struct mvpp2 *priv, u32 offset, u32 data) > +{ > + writel(data, priv->cm3_base + offset); > +} > + > +static u32 mvpp2_cm3_read(struct mvpp2 *priv, u32 offset) > +{ > + return readl(priv->cm3

Re: [PATCH v4 net-next 08/11] skbuff: introduce {,__}napi_build_skb() which reuses NAPI cache heads

2021-02-11 Thread Jesper Dangaard Brouer
On Wed, 10 Feb 2021 16:30:23 + Alexander Lobakin wrote: > Instead of just bulk-flushing skbuff_heads queued up through > napi_consume_skb() or __kfree_skb_defer(), try to reuse them > on allocation path. Maybe you are already aware of this dynamics, but high speed NICs will usually run the T

Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:49:00PM +0200, stef...@marvell.com wrote: > +/* Configure Rx FIFO Flow control thresholds */ > +void mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en) > +{ > + int val; u32 ? > + > + val = mvpp2_read(priv, MVPP2_RX_FC_REG(port)); > + > + if

Re: [PATCH v13 net-next 14/15] net: mvpp2: set 802.3x GoP Flow Control mode

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:49:01PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > This patch fix GMAC TX flow control autoneg. > Flow control autoneg wrongly were disabled with enabled TX > flow control. > > Signed-off-by: Stefan Chulski > Acked-by: Marcin Wojtas Should this pat

RE: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Stefan Chulski
> -Original Message- > From: Russell King - ARM Linux admin > Sent: Thursday, February 11, 2021 2:50 PM > To: Stefan Chulski > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan > Markman ; linux-ker...@vger.kernel.org; > k...@kernel.org

RE: [EXT] Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control

2021-02-11 Thread Stefan Chulski
> > +/* Configure Rx FIFO Flow control thresholds */ void > > +mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en) { > > + int val; > > u32 ? OK. > > + > > + val = mvpp2_read(priv, MVPP2_RX_FC_REG(port)); > > + > > + if (en) > > + val |= MVPP2_RX_FC_EN; > > + el

Re: [RFC PATCH v4 08/17] af_vsock: update comments for stream sockets

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:16:29PM +0300, Arseny Krasnov wrote: This replaces 'stream' to 'connect oriented' in comments as SEQPACKET is also connect oriented. I'm not a native speaker but maybe is better 'connection oriented' or looking at socket(2) man page 'connection-based' is also fine.

RE: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Stefan Chulski
> Ditto. > > I don't think these need to be fixed in the net tree, but it would still be > nice > to fix the problem. Please do so, as an initial patch in your series - so we > can > then backport if it turns out to eventually be necessary. > > Thanks. My series already has 15 patches and patc

Re: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 01:02:14PM +, Stefan Chulski wrote: > > On Thu, Feb 11, 2021 at 12:48:55PM +0200, stef...@marvell.com wrote: > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > index 761f745..8b4073c 100644 > >

Re: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 01:22:35PM +, Stefan Chulski wrote: > > Ditto. > > > > I don't think these need to be fixed in the net tree, but it would still be > > nice > > to fix the problem. Please do so, as an initial patch in your series - so > > we can > > then backport if it turns out to ev

Re: [RFC PATCH v4 09/17] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:16:46PM +0300, Arseny Krasnov wrote: This adds transport callback and it's logic for SEQPACKET dequeue. Callback fetches RW packets from rx queue of socket until whole record is copied(if user's buffer is full, user is not woken up). This is done to not stall sender, be

Re: phy_attach_direct()'s use of device_bind_driver()

2021-02-11 Thread Andrew Lunn
> Yeah, I plan to fix this. So I have a few more questions. In the > example I gave, what should happen if the gpios listed in the phy's DT > node aren't ready yet? There are four different use cases for GPIO. 1) The GPIO is used to reset all devices on the MDIO bus. When the bus is registered wi

Re: [RFC PATCH v4 10/17] virtio/vsock: fetch length for SEQPACKET record

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:17:08PM +0300, Arseny Krasnov wrote: This adds transport callback which tries to fetch record begin marker from socket's rx queue. It is called from af_vsock.c before reading data packets of record. Signed-off-by: Arseny Krasnov --- include/linux/virtio_vsock.h

Re: phy_attach_direct()'s use of device_bind_driver()

2021-02-11 Thread Andrew Lunn
On Thu, Feb 11, 2021 at 10:21:03AM +, Jon Hunter wrote: > > On 10/02/2021 22:56, Andrew Lunn wrote: > > On Wed, Feb 10, 2021 at 02:13:48PM -0800, Saravana Kannan wrote: > >> Hi, > >> > >> This email was triggered by this other email[1]. > > > > And it appears the Tegra194 Jetson Xavier uses t

Re: [RFC PATCH v4 09/17] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-02-11 Thread Stefano Garzarella
On Thu, Feb 11, 2021 at 02:54:28PM +0100, Stefano Garzarella wrote: On Sun, Feb 07, 2021 at 06:16:46PM +0300, Arseny Krasnov wrote: This adds transport callback and it's logic for SEQPACKET dequeue. Callback fetches RW packets from rx queue of socket until whole record is copied(if user's buffer

RE: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case

2021-02-11 Thread Paul Durrant
> -Original Message- > From: Juergen Gross > Sent: 11 February 2021 10:16 > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org > Cc: Juergen Gross ; Wei Liu ; Paul > Durrant ; David > S. Miller ; Jakub Kicinski > Subject: [PATCH v2 4/8] xen/netbac

RE: [PATCH v2 5/8] xen/events: link interdomain events to associated xenbus device

2021-02-11 Thread Paul Durrant
> -Original Message- > From: Juergen Gross > Sent: 11 February 2021 10:16 > To: xen-de...@lists.xenproject.org; linux-bl...@vger.kernel.org; > linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; linux-s...@vger.kernel.org > Cc: Juergen Gross ; Konrad Rzeszutek Wilk > ; Roger Pau Monn

Re: [EXT] Re: [PATCH v12 net-next 12/15] net: mvpp2: add BM protection underrun feature support

2021-02-11 Thread Andrew Lunn
On Thu, Feb 11, 2021 at 08:22:19AM +, Stefan Chulski wrote: > > > > > -- > > From: > > Date: Wed, 10 Feb 2021 11:48:17 +0200 > > > > > > > > +static int bm_underrun_protect = 1; > > > + > > > +module_param(bm_underrun_prote

Re: [PATCH v4 net-next 09/11] skbuff: allow to optionally use NAPI cache from __alloc_skb()

2021-02-11 Thread Alexander Lobakin
From: Paolo Abeni Date: Thu, 11 Feb 2021 11:16:40 +0100 > On Wed, 2021-02-10 at 16:30 +, Alexander Lobakin wrote: > > Reuse the old and forgotten SKB_ALLOC_NAPI to add an option to get > > an skbuff_head from the NAPI cache instead of inplace allocation > > inside __alloc_skb(). > > This impl

Re: [RFC PATCH v4 12/17] virtio/vsock: rest of SOCK_SEQPACKET support

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:17:44PM +0300, Arseny Krasnov wrote: This adds rest of logic for SEQPACKET: 1) Packet's type is now set in 'virtio_send_pkt_info()' using type of socket. 2) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END. Note that both functions may sleep to wait enough

Re: [RFC PATCH v4 16/17] loopback/vsock: setup SEQPACKET ops for transport

2021-02-11 Thread Stefano Garzarella
Please move this patch before the test and I'd change the prefix in "vsock_loopback" or "vsock/loopback". Thanks, Stefano On Sun, Feb 07, 2021 at 06:18:48PM +0300, Arseny Krasnov wrote: This adds SEQPACKET ops for loopback transport Signed-off-by: Arseny Krasnov --- net/vmw_vsock/vsock_loopb

Re: [PATCH v4 net-next 08/11] skbuff: introduce {,__}napi_build_skb() which reuses NAPI cache heads

2021-02-11 Thread Alexander Lobakin
From: Jesper Dangaard Brouer Date: Thu, 11 Feb 2021 13:54:59 +0100 > On Wed, 10 Feb 2021 16:30:23 + > Alexander Lobakin wrote: > > > Instead of just bulk-flushing skbuff_heads queued up through > > napi_consume_skb() or __kfree_skb_defer(), try to reuse them > > on allocation path. > > May

Re: [RFC PATCH v4 17/17] virtio/vsock: simplify credit update function API

2021-02-11 Thread Stefano Garzarella
On Sun, Feb 07, 2021 at 06:19:03PM +0300, Arseny Krasnov wrote: 'virtio_transport_send_credit_update()' has some extra args: 1) 'type' may be set in 'virtio_transport_send_pkt_info()' using type of socket. 2) This function is static and 'hdr' arg was always NULL. Okay, I saw this patch after

Re: [RFC PATCH v4 00/17] virtio/vsock: introduce SOCK_SEQPACKET support

2021-02-11 Thread Stefano Garzarella
Hi Arseny, On Mon, Feb 08, 2021 at 09:32:59AM +0300, Arseny Krasnov wrote: On 07.02.2021 19:20, Michael S. Tsirkin wrote: On Sun, Feb 07, 2021 at 06:12:56PM +0300, Arseny Krasnov wrote: This patchset impelements support of SOCK_SEQPACKET for virtio transport. As SOCK_SEQPACKET

Re: [PATCH v4 net-next 09/11] skbuff: allow to optionally use NAPI cache from __alloc_skb()

2021-02-11 Thread Paolo Abeni
On Thu, 2021-02-11 at 14:28 +, Alexander Lobakin wrote: > From: Paolo Abeni on Thu, 11 Feb 2021 11:16:40 +0100 > wrote: > > What about changing __napi_alloc_skb() to always use > > the __napi_build_skb(), for both kmalloc and page backed skbs? That is, > > always doing the 'data' allocation i

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Jiri Olsa
On Wed, Feb 10, 2021 at 09:13:47PM +0100, Jiri Olsa wrote: > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > SNIP > > > > but below is change for checking that ftrace addrs are within elf > > > functions > > > > > > seems to work in my tests, I'll run some more tests and sen

Re: [RFC PATCH v4 02/17] af_vsock: separate wait data loop

2021-02-11 Thread Jorgen Hansen
> On 7 Feb 2021, at 16:14, Arseny Krasnov wrote: > > This moves wait loop for data to dedicated function, because later > it will be used by SEQPACKET data receive loop. > > Signed-off-by: Arseny Krasnov > --- > net/vmw_vsock/af_vsock.c | 158 +-- > 1 file c

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Claudiu.Beznea
Hi, Rafael, Pavel, I know you may be busy. Just a gentle ping on this topic. It would be nice to have your input in this. Thank you, Claudiu Beznea On 14.01.2021 13:05, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On

Re: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case

2021-02-11 Thread Wei Liu
On Thu, Feb 11, 2021 at 11:16:12AM +0100, Juergen Gross wrote: > In case of a common event for rx and tx queue the event should be > regarded to be spurious if no rx and no tx requests are pending. > > Unfortunately the condition for testing that is wrong causing to > decide a event being spurious

Re: [PATCH v4 net-next 09/11] skbuff: allow to optionally use NAPI cache from __alloc_skb()

2021-02-11 Thread Alexander Lobakin
From: Paolo Abeni Date: Thu, 11 Feb 2021 15:55:04 +0100 > On Thu, 2021-02-11 at 14:28 +, Alexander Lobakin wrote: > > From: Paolo Abeni on Thu, 11 Feb 2021 11:16:40 +0100 > > wrote: > > > What about changing __napi_alloc_skb() to always use > > > the __napi_build_skb(), for both kmalloc and

Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-11 Thread Daniel Borkmann
On 2/10/21 3:50 PM, Willem de Bruijn wrote: On Wed, Feb 10, 2021 at 1:59 AM huangxuesen wrote: From: huangxuesen bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets encapsulation. But that is not appropriate when pushing Ethernet header. Add an option to further specify

[net-next] net: mvpp2: fix interrupt mask/unmask skip condition

2021-02-11 Thread stefanc
From: Stefan Chulski The condition should be skipped if CPU ID equal to nthreads. The patch doesn't fix any actual issue since nthreads = min_t(unsigned int, num_present_cpus(), MVPP2_MAX_THREADS). On all current Armada platforms, the number of CPU's is less than MVPP2_MAX_THREADS. Fixes: e531f7

Re: [PATCH bpf v4] selftests/bpf: convert test_xdp_redirect.sh to bash

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Thu, 11 Feb 2021 09:20:29 +0100 you wrote: > From: Björn Töpel > > The test_xdp_redirect.sh script uses a bash feature, '&>'. On systems, > e.g. Debian, where '/bin/sh' is dash, this will not work as > expected. Use bash in th

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Sedat Dilek
On Thu, Feb 11, 2021 at 4:08 PM Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 09:13:47PM +0100, Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > but below is change for checking that ftrace addrs are within elf > > > > functions > > > >

[PATCH v2 net-next 0/2] pktgen: scripts improvements

2021-02-11 Thread Igor Russkikh
Hello netdev community, Please consider small improvements to pktgen scripts we use in our environment. Adding delay parameter through command line, Adding new -a (append) parameter to make flex runs v2: Review comments from Jesper CC: Jesper Dangaard Brouer Igor Russkikh (2): samples: pktg

[PATCH v2 net-next 2/2] samples: pktgen: new append mode

2021-02-11 Thread Igor Russkikh
To configure various complex flows we for sure can create custom pktgen init scripts, but sometimes thats not that easy. New "-a" (append) option in all the existing sample scripts allows to append more "devices" into pktgen threads. The most straightforward usecases for that are: - using multipl

[PATCH v2 net-next 1/2] samples: pktgen: allow to specify delay parameter via new opt

2021-02-11 Thread Igor Russkikh
DELAY may now be explicitly specified via common parameter -w Signed-off-by: Igor Russkikh --- samples/pktgen/parameters.sh | 10 +- samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 3 --- samples/pktgen/pktgen_bench_xmit_mode_queue_xmit.sh| 3 ---

[net-next v6 00/14] Add Marvell CN10K support

2021-02-11 Thread Geetha sowjanya
The current admin function (AF) driver and the netdev driver supports OcteonTx2 silicon variants. The same OcteonTx2's Resource Virtualization Unit (RVU) is carried forward to the next-gen silicon ie OcteonTx3, with some changes and feature enhancements. This patch set adds support for OcteonTx3 (

[net-next v6 03/14] octeontx2-af: cn10k: Update NIX/NPA context structure

2021-02-11 Thread Geetha sowjanya
NIX hardware context structure got changed to accommodate new features like bandwidth steering, L3/L4 outer/inner checksum enable/disable etc., on CN10K platform. This patch defines new mbox message NIX_CN10K_AQ_INST for new NIX context initialization. This patch also updates the NPA context struc

[net-next v6 02/14] octeontx2-pf: cn10k: Add mbox support for CN10K

2021-02-11 Thread Geetha sowjanya
From: Subbaraya Sundeep Firmware allocates memory regions for PFs and VFs in DRAM. The PFs memory region is used for AF-PF and PF-VF mailbox. This mbox facilitate communication between AF-PF and PF-VF. On CN10K platform: The DRAM region allocated to PF is enumerated as PF BAR4 memory. PF BAR4 co

[net-next v6 04/14] octeontx2-af: cn10k: Update NIX and NPA context in debugfs

2021-02-11 Thread Geetha sowjanya
On CN10K platform NPA and NIX context structure bit fields had changed to support new features like bandwidth steering etc. This patch dumps approprate context for CN10K platform. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham --- .../marvell/octeontx2/af/rvu_debugfs.c| 177

[net-next v6 01/14] octeontx2-af: cn10k: Add mbox support for CN10K platform

2021-02-11 Thread Geetha sowjanya
From: Subbaraya Sundeep Firmware allocates memory regions for PFs and VFs in DRAM. The PFs memory region is used for AF-PF and PF-VF mailbox. This mbox facilitates communication between AF-PF and PF-VF. On CN10K platform: The DRAM region allocated to PF is enumerated as PF BAR4 memory. PF BAR4 c

[net-next v6 05/14] octeontx2-pf: cn10k: Initialise NIX context

2021-02-11 Thread Geetha sowjanya
On CN10K platform NIX RQ and SQ context structure got changed. This patch uses new mbox message "NIX_CN10K_AQ_ENQ" for NIX context initialization on CN10K platform. This patch also updates the nix_rx_parse_s and nix_sqe_sg_s structures to add packet steering bit feilds. Signed-off-by: Geetha sowj

[net-next v6 07/14] octeontx2-pf: cn10k: Use LMTST lines for NPA/NIX operations

2021-02-11 Thread Geetha sowjanya
This patch adds support to use new LMTST lines for NPA batch free and burst SQE flush. Adds new dev_hw_ops structure to hold platform specific functions and create new files cn10k.c and cn10k.h. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham --- .../ethernet/marvell/octeontx2/nic/M

[net-next v6 06/14] octeontx2-pf: cn10k: Map LMTST region

2021-02-11 Thread Geetha sowjanya
On CN10K platform transmit/receive buffer alloc and free from/to hardware had changed to support burst operation. Whereas pervious silicon's only support single buffer free at a time. To Support the same firmware allocates a DRAM region for each PF/VF for storing LMTLINES. These LMTLINES are used f

[net-next v6 09/14] octeontx2-af: cn10k: Add support for programmable channels

2021-02-11 Thread Geetha sowjanya
From: Subbaraya Sundeep NIX uses unique channel numbers to identify the packet sources/sinks like CGX,LBK and SDP. The channel numbers assigned to each block are hardwired in CN9xxx silicon. The fixed channel numbers in CN9xxx are: 0x0 | a << 8 | b- LBK(0..3)_CH(0..63) 0x0 | a << 8

[net-next v6 08/14] octeontx2-af: cn10k: Add RPM MAC support

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam OcteonTx2's next gen platform the CN10K has RPM MAC which has a different serdes when compared to CGX MAC. Though the underlying HW is different, the CSR interface has been designed largely inline with CGX MAC, with few exceptions though. So we are using the same CGX driver

[net-next v6 10/14] octeontx2-af: cn10K: Add MTU configuration

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam OcteonTx3 CN10K silicon supports bigger MTU when compared to 9216 MTU supported by OcteonTx2 silicon variants. Lookback interface supports upto 64K and RPM LMAC interfaces support upto 16K. This patch does the necessary configuration and adds support for PF/VF drivers to r

[net-next v6 12/14] octeontx2-af: cn10k: Add RPM LMAC pause frame support

2021-02-11 Thread Geetha sowjanya
From: Rakesh Babu Flow control configuration is different for CGX(Octeontx2) and RPM(CN10K) functional blocks. This patch adds the necessary changes for RPM to support 802.3 pause frames configuration on cn10k platforms. Signed-off-by: Rakesh Babu Signed-off-by: Geetha sowjanya Signed-off-by:

[net-next v6 14/14] octeontx2-af: cn10k: MAC internal loopback support

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam MAC on CN10K silicon support loopback for selftest or debug purposes. This patch does necessary configuration to loopback packets upon receiving request from LMAC mapped RVU PF's netdev via mailbox. Also MAC (CGX) on OcteonTx2 silicon variants and MAC (RPM) on OcteonTx3 CN

[net-next v6 13/14] octeontx2-af: cn10k: Add RPM Rx/Tx stats support

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam RPM supports below list of counters as an extension to existing counters * class based flow control pause frames * vlan/jabber/fragmented packets * fcs/alignment/oversized error packets This patch adds support to display supported RPM counters via debugfs and define

[net-next v6 11/14] octeontx2-pf: cn10k: Get max mtu supported from admin function

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam CN10K supports max MTU of 16K on LMAC links and 64k on LBK links and Octeontx2 silicon supports 9K mtu on both links. Get the same from nix_get_hw_info mbox message in netdev probe. This patch also calculates receive buffer size required based on the MTU set. Signed-off-b

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Jiri Olsa
On Thu, Feb 11, 2021 at 04:43:48PM +0100, Sedat Dilek wrote: SNIP > > > filled with elf functions start/end values, right? > > > > > > > /* > > > > * We iterate over sorted array, so we can > > > > easily skip > > > > * no

[PATCH] enetc: auto select PHYLIB and MDIO_DEVRES

2021-02-11 Thread Tong Zhang
FSL_ENETC_MDIO use symbols from PHYLIB and MDIO_DEVRES, however they are not auto selected. ERROR: modpost: "__mdiobus_register" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! ERROR: modpost: "mdiobus_unregister" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undef

pull request: bluetooth-next 2021-02-11

2021-02-11 Thread Johan Hedberg
Hi Dave, Jakub, Here's the main bluetooth-next pull request for 5.12: - Add support for advertising monitor offliading using Microsoft vendor extensions - Add firmware download support for MediaTek MT7921U USB devices - Suspend-related fixes for Qualcomm devices - Add support for Intel Gar

[PATCH net-next v2 1/5] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-11 Thread Sven Van Asbroeck
From: Sven Van Asbroeck The buffers in the lan743x driver's receive ring are always 9K, even when the largest packet that can be received (the mtu) is much smaller. This performs particularly badly on cpu archs without dma cache snooping (such as ARM): each received packet results in a 9K dma_{ma

[PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-11 Thread Sven Van Asbroeck
From: Sven Van Asbroeck On cpu architectures w/o dma cache snooping, dma_unmap() is a is a very expensive operation, because its resulting sync needs to invalidate cpu caches. Increase efficiency/performance by syncing only those sections of the lan743x's rx ring buffers that are actually in use

[PATCH net-next v2 4/5] TEST ONLY: lan743x: skb_alloc failure test

2021-02-11 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Simulate low-memory in lan743x_rx_allocate_skb(): fail 10 allocations in a row in every 100. Signed-off-by: Sven Van Asbroeck --- To: Bryan Whitehead To: unglinuxdri...@microchip.com To: "David S. Miller" To: Jakub Kicinski Cc: Andrew Lunn Cc: Alexey Denisov Cc: Se

[PATCH net-next v2 0/5] lan743x speed boost

2021-02-11 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git # e4b62cf7559f v1 -> v2: - Andrew Lunn: + always keep to Reverse Christmas Tree. + "changing the cache operations to operate on the received length" should go in its own, separate patch

  1   2   3   4   >