Hi Greg,
in kernel 4.14 i have seen a NULL pointer deref in
[65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850
(i have a core dump and detailed analysis)
That looks like this patch could have prevented it:
https://www.spinics.net/lists/stable-commits/msg133055.html
this one was q
Lorenzo Bianconi writes:
>> So what's the plan? Is there going to be a followup patch? And should
>> that also go to v5.11 or can it wait v5.12?
>>
>> --
>> https://patchwork.kernel.org/project/linux-wireless/list/
>>
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatch
Cong Wang wrote:
> From: Cong Wang
>
> Before we add non-TCP support, it is necessary to rename
> BPF_STREAM_PARSER as it will be no longer specific to TCP,
> and it does not have to be a parser either.
>
> This patch renames BPF_STREAM_PARSER to BPF_SOCK_MAP, so
> that sock_map.c hopefully woul
On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner
wrote:
> Hi,
>
> I didn't receive the cover letter, so I'm replying on this one. :-)
>
> This is nice. One thing is not clear to me yet. From the samples on
> the cover letter:
>
> $ tc -s filter show dev enp8s0f0_1 ingress
> filter protocol
On Mon, Feb 08, 2021 at 08:37:04AM +0100, Uwe Kleine-König wrote:
> The driver core only calls a bus' remove function when there is actually
> a driver and a device. So drop the needless check and assign cldrv earlier.
>
> (Side note: The check for cldev being non-NULL is broken anyhow, because
>
On Feb 08, Kalle Valo wrote:
> Lorenzo Bianconi writes:
>
> >> So what's the plan? Is there going to be a followup patch? And should
> >> that also go to v5.11 or can it wait v5.12?
> >>
> >> --
> >> https://patchwork.kernel.org/project/linux-wireless/list/
> >>
> >> https://wireless.wiki.kernel.
Cong Wang wrote:
> From: Cong Wang
>
> These two ebpf programs are tied to BPF_SK_SKB_STREAM_PARSER
> and BPF_SK_SKB_STREAM_VERDICT, rename them to reflect the fact
> they are currently used for TCP. And save the generic name
> skb_verdict for general use.
>
> Cc: John Fastabend
> Cc: Daniel Bo
Cong Wang wrote:
> From: Cong Wang
>
> I was planning to reuse BPF_SK_SKB_STREAM_VERDICT but its name is
> confusing and more importantly it seems kTLS relies on it to deliver
> sk_msg too. To avoid messing up kTLS, we can just reuse the stream
> verdict code but introduce a new type of eBPF prog
From: Stefan Chulski
Patch adds CM3 address space and PPv2.3 description.
Signed-off-by: Stefan Chulski
---
Documentation/devicetree/bindings/net/marvell-pp2.txt | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt
b/D
From: Stefan Chulski
Armada hardware has a pause generation mechanism in GOP (MAC).
The GOP generate flow control frames based on an indication programmed in Ports
Control 0 Register. There is a bit per port.
However assertion of the PortX Pause bits in the ports control 0 register only
sends a
From: Stefan Chulski
This patch adds CM3 memory map and CM3 read/write callbacks.
Signed-off-by: Stefan Chulski
Reviewed-by: Andrew Lunn
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 +
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 26
2 files changed, 27 i
From: Konstantin Porotchkin
CM3 SRAM address space would be used for Flow Control configuration.
Signed-off-by: Stefan Chulski
Signed-off-by: Konstantin Porotchkin
---
arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/
From: Stefan Chulski
This patch add PPv23 version definition.
PPv23 is new packet processor in CP115.
Everything that supported by PPv22, also supported by PPv23.
No functional changes in this stage.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 +++
From: Stefan Chulski
Currently we have PP2v1 and PP2v2 hw-versions, with some different
handlers depending upon condition hw_version = MVPP21/MVPP22.
In a future there will be also PP2v3. Let's use now the generic
"if equal/notEqual MVPP21" for all cases instead of "if MVPP22".
This patch does n
From: Stefan Chulski
The firmware needs to monitor the RX Non-occupied descriptor
bits for flow control to move to XOFF mode.
These bits need to be unmasked to be functional, but they will
not raise interrupts as we leave the RX exception summary
bit in MVPP2_ISR_RX_TX_MASK_REG clear.
Signed-off
From: Stefan Chulski
BM pool and RXQ size increased to support Firmware Flow Control.
Minimum depletion thresholds to support FC are 1024 buffers.
BM pool size increased to 2048 to have some 1024 buffers
space between depletion thresholds and BM pool size.
Jumbo frames require a 9888B buffer, so
From: Stefan Chulski
Flow Control periodic timer would be used if port in
XOFF to transmit periodic XOFF frames.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 ++
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 45
2 files cha
From: Stefan Chulski
This patch enables global flow control in FW and in the phylink validate mask.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 11 +--
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 30 +++-
2 files changed, 37 ins
From: Stefan Chulski
This patch adds RXQ flow control configurations.
Flow control disabled by default.
Minimum ring size limited to 1024 descriptors.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 35 +-
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
From: Stefan Chulski
New FIFO flow control feature was added in PPv23.
PPv2 FIFO polled by HW and trigger pause frame if FIFO
fill level is below threshold.
FIFO HW flow control enabled with CM3 RXQ&BM flow
control with ethtool.
Current FIFO thresholds is:
9KB for port with maximum speed 10Gb/s
From: Stefan Chulski
The PP2v23 hardware supports a feature allowing to double the
size of BPPI by decreasing number of pools from 16 to 8.
Increasing of BPPI size protect BM drop from BPPI underrun.
Underrun could occurred due to stress on DDR and as result slow buffer
transition from BPPE to BP
From: Stefan Chulski
Patch check that TX FC firmware is running in CM3.
If not, global TX FC would be disabled.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 +
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 42
2 files changed,
From: Stefan Chulski
This patch fix GMAC TX flow control autoneg.
Flow control autoneg wrongly were disabled with enabled TX
flow control.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
From: Stefan Chulski
This patch add ethtool flow control configuration support.
Tx flow control retrieved correctly by ethtool get function.
FW per port ethtool configuration capability added.
Patch also takes care about mtu change procedure, if PPv2 switch
BM pools during mtu change.
Signed-o
Jakub Sitnicki wrote:
> On Wed, Feb 03, 2021 at 05:16 AM CET, Cong Wang wrote:
> > From: Cong Wang
> >
> > struct sk_psock_parser is embedded in sk_psock, it is
> > unnecessary as skb verdict also uses ->saved_data_ready.
> > We can simply fold these fields into sk_psock.
> >
> > Cc: John Fastaben
Fix the following coccicheck warning:
./tools/perf/builtin-script.c:2789:36-41: WARNING: conversion to bool
not needed here
./tools/perf/builtin-script.c:3237:48-53: WARNING: conversion to bool
not needed here
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
Change in v2:
-Change the subject
Hi,
pon., 8 lut 2021 o 09:33 napisał(a):
>
> From: Stefan Chulski
>
> This patch adds CM3 memory map and CM3 read/write callbacks.
The read/write callbacks are not added in this patch, please correct
the commit message.
Best regards,
Marcin
>
> Signed-off-by: Stefan Chulski
> Reviewed-by: An
Hi,
pon., 8 lut 2021 o 09:33 napisał(a):
>
> From: Stefan Chulski
>
> This patch add PPv23 version definition.
> PPv23 is new packet processor in CP115.
> Everything that supported by PPv22, also supported by PPv23.
> No functional changes in this stage.
>
> Signed-off-by: Stefan Chulski
> ---
On Mon, Feb 08, 2021 at 08:12:29AM +, Schmid, Carsten wrote:
> Hi Greg,
>
> in kernel 4.14 i have seen a NULL pointer deref in
> [65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850
> (i have a core dump and detailed analysis)
>
> That looks like this patch could have prevented i
On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote:
> On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote:
> > On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote:
> > > Hi Ido,
> > >
> > > On 1/30/2021 10:42 PM, Ido Schimmel wrote:
> > > > On Fri, Jan 29, 2021 at 12:30:0
On 2021/2/8 下午2:37, Eli Cohen wrote:
On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote:
On 2021/2/6 上午7:07, Si-Wei Liu wrote:
On 2/3/2021 11:36 PM, Eli Cohen wrote:
When a change of memory map occurs, the hardware resources are destroyed
and then re-created again with the new memor
On Mon, Feb 08, 2021 at 10:57:46AM +0200, Ido Schimmel wrote:
> On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote:
> > On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote:
> > > On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote:
> > > > Hi Ido,
> > > >
> > > > On 1/30/
On Wed, 3 Feb 2021 18:08:31 +0100 Jakub Kicinski wrote:
> Yup! I'm pretty sure it's my conversion. The full commit quote upstream:
>
> 40a98cb6f01f ("i40e: convert to new udp_tunnel infrastructure")
>
> It should trigger if you have vxlan module loaded (or built in)
> and then reload or re-probe
Hi Juergen,
On 07/02/2021 12:58, Jürgen Groß wrote:
On 06.02.21 19:46, Julien Grall wrote:
Hi Juergen,
On 06/02/2021 10:49, Juergen Gross wrote:
The first three patches are fixes for XSA-332. The avoid WARN splats
and a performance issue with interdomain events.
Thanks for helping to figure
> >
> > This commit introduces tracing infrastructure for AF_XDP sockets
> > (xsks) and a new trace event called 'xsk_packet_drop'. This trace
> > event is triggered when a packet cannot be processed by the socket
> > due to one of the following issues:
> > (1) packet exceeds the maximum permitted
On Wed, Feb 03, 2021 at 09:56:28AM +, Russell King - ARM Linux admin wrote:
> On Wed, Feb 03, 2021 at 10:18:55AM +0100, Oleksij Rempel wrote:
> > This fixup removes the Lpi_en bit.
> >
> > If this patch breaks functionality of your board, use following device
> > tree properties:
> >
> >
>> Hi Greg,
>>
>> in kernel 4.14 i have seen a NULL pointer deref in
>> [65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850
>> (i have a core dump and detailed analysis)
>>
>> That looks like this patch could have prevented it:
>>
>> https://www.spinics.net/lists/stable-commits/msg133
On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote:
>
> On 2021/2/8 下午2:37, Eli Cohen wrote:
> > On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote:
> > > On 2021/2/6 上午7:07, Si-Wei Liu wrote:
> > > >
> > > > On 2/3/2021 11:36 PM, Eli Cohen wrote:
> > > > > When a change of memory
Eliminate the following coccicheck warning:
./tools/testing/selftests/net/so_txtime.c:199:3-4: Unneeded semicolon
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
tools/testing/selftests/net/so_txtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftes
On Sat, Feb 06, 2021 at 12:13:22PM -0800, Jakub Kicinski wrote:
> On Sat, 6 Feb 2021 15:50:41 +0100 Lech Perczak wrote:
> > >> Cc: Bjørn Mork
> > >> Signed-off-by: Lech Perczak
> > > Patch looks fine to me. But I don't think you can submit a net and usb
> > > serial patch in a series. These are
This commit introduces tracing infrastructure for AF_XDP sockets
(xsks) and a new trace event called 'xsk_packet_drop'. This trace
event is triggered when a packet cannot be processed by the socket
due to one of the following issues:
(1) packet exceeds the maximum permitted size.
(2) invalid fill d
This series introduces tracing infrastructure for AF_XDP sockets (xsk).
A trace event 'xsk_packet_drop' is created which can be enabled by toggling
/sys/kernel/debug/tracing/events/xsk/xsk_packet_drop/enable
When enabled and packets or empty packet buffers are dropped in the kernel,
traces are ge
Prior to this, the packet count was fixed at 1 for every test.
Future tracing tests need to modify the count in order to ensure
the trace buffer does not become full. So, make it possible to set
the count from test_xsk.h using the -C opt.
Signed-off-by: Ciara Loftus
---
tools/testing/selftes
This commit introduces framework to the xsk selftests for
testing the xsk_packet_drop traces. The '-t' or '--trace-enable'
args enable the trace, and disable it on exit unless it was
already enabled before the test.
Signed-off-by: Ciara Loftus
---
tools/testing/selftests/bpf/xdpxceiver.c | 65 ++
This test increases the UMEM headroom to a size that will
cause packets to be dropped. Traces which report these
drops are expected which look like so:
xsk_packet_drop: netdev: ve3213 qid 0 reason: packet too big: \
len 60 max 1 not_used 0
The test validates that these traces were successfully
This test supplies invalid addresses to the fill
queue at init. On RX, traces are expected which report
the invalid address which look like so:
xsk_packet_drop: netdev: ve3213 qid 0 reason: invalid fill addr: \
addr 262144 not_used 0 not_used 0
The test validates that these traces were successf
This test sets the length of tx descriptors to an invalid
value. When the kernel tries to transmit these descriptors,
error traces are expected which look like so:
xsk_packet_drop: netdev: ve9266 qid 0 reason: invalid tx desc: \
addr 258048 len 4097 options 0
The test validates that these trace
On 08.02.21 10:11, Julien Grall wrote:
Hi Juergen,
On 07/02/2021 12:58, Jürgen Groß wrote:
On 06.02.21 19:46, Julien Grall wrote:
Hi Juergen,
On 06/02/2021 10:49, Juergen Gross wrote:
The first three patches are fixes for XSA-332. The avoid WARN splats
and a performance issue with interdomai
Fix the following coccicheck warning:
./tools/bpf/bpf_dbg.c:893:32-36: WARNING: Comparison to bool.
Reported-by: Abaci Robot
Signed-off-by: Jiapeng Chong
---
tools/bpf/bpf_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/bpf_dbg.c b/tools/bpf/bpf_dbg.c
index
On Mon, Feb 08, 2021 at 09:24:11AM +, Schmid, Carsten wrote:
> >> Hi Greg,
> >>
> >> in kernel 4.14 i have seen a NULL pointer deref in
> >> [65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850
> >> (i have a core dump and detailed analysis)
> >>
> >> That looks like this patch cou
On Sun, Feb 07, 2021 at 01:54:43AM +0100, Lech Perczak wrote:
> This patch prepares for qmi_wwan driver support for the device.
> Previously "option" driver mapped itself to interfaces 0 and 3 (matching
> ff/ff/ff), while interface 3 is in fact a QMI port.
> Interfaces 1 and 2 (matching ff/00/00) e
On 08/02/2021 09:41, Jürgen Groß wrote:
On 08.02.21 10:11, Julien Grall wrote:
Hi Juergen,
On 07/02/2021 12:58, Jürgen Groß wrote:
On 06.02.21 19:46, Julien Grall wrote:
Hi Juergen,
On 06/02/2021 10:49, Juergen Gross wrote:
The first three patches are fixes for XSA-332. The avoid WARN sp
Dear Friend,
I will be pleased if you can allow me to invest $104M Dollars in
Estate Management,in your company or any area you best that will be
of good profit to both of us
Please do well to respond including your information for more details.
Thanks.
Mr.Richard Thomas
On Wed, 3 Feb 2021 at 04:17, Cong Wang wrote:
>
> From: Cong Wang
>
> Cc: John Fastabend
> Cc: Daniel Borkmann
> Cc: Jakub Sitnicki
> Cc: Lorenz Bauer
> Signed-off-by: Cong Wang
> ---
> include/net/udp.h | 2 ++
> net/ipv4/af_inet.c | 1 +
> net/ipv4/udp.c | 34 ++
On Mon, 8 Feb 2021 at 08:21, John Fastabend wrote:
...
>
> Rather than rename this, lets reduce its scope to just the set
> of actions that need the STREAM_PARSER, this should be just the
> stream parser programs. We probably should have done this sooner,
> but doing it now will be fine.
So sockm
Matteo Croce writes:
> From: Matteo Croce
>
> The ieee80211 class registers a callback which actually does nothing.
> Given that the callback is optional, and all its accesses are protected
> by a NULL check, remove it entirely.
>
> Signed-off-by: Matteo Croce
> ---
> net/wireless/sysfs.c | 7
On Sun, Feb 07, 2021 at 11:03:30AM +0800, kernel test robot wrote:
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 79991caf5202c7989928be534727805f8f68bb8d ("vdpa_sim_net: Add support
> for user supported devices")
> https://git.kernel.org/cgit/linux/kerne
On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote:
>
> On 2021/2/8 下午2:37, Eli Cohen wrote:
> > On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote:
> > > On 2021/2/6 上午7:07, Si-Wei Liu wrote:
> > > >
> > > > On 2/3/2021 11:36 PM, Eli Cohen wrote:
> > > > > When a change of memory
On 08.02.21 10:54, Julien Grall wrote:
On 08/02/2021 09:41, Jürgen Groß wrote:
On 08.02.21 10:11, Julien Grall wrote:
Hi Juergen,
On 07/02/2021 12:58, Jürgen Groß wrote:
On 06.02.21 19:46, Julien Grall wrote:
Hi Juergen,
On 06/02/2021 10:49, Juergen Gross wrote:
The first three patches a
Eliminate the following coccicheck warning:
./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded
semicolon
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
tools/testing/selftests/bpf/test_flow_dissector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t
Jiapeng Zhong wrote:
> Fix the follow coccicheck warnings:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27:
> WARNING: Comparison of 0/1 to bool variable.
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26:
> WARNING: Comparison of 0/1 to bool variable.
>
>
Jiapeng Zhong wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
> WARNING: Comparison of 0/1 to bool variable
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Zhong
Please use your own email address and real name.
Patch se
Emil Renner Berthing wrote:
> In commit d3ccc14dfe95 most of the tasklets in this driver was
> updated to the new API. However for the rx_work_tasklet only the
> type of the callback was changed from
> void _rtl_rx_work(unsigned long data)
> to
> void _rtl_rx_work(struct tasklet_struct *t).
>
Colin King wrote:
> From: Colin Ian King
>
> The variable rtstatu is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian Ki
Hi Juergen,
On 08/02/2021 10:22, Jürgen Groß wrote:
On 08.02.21 10:54, Julien Grall wrote:
... I don't really see how the difference matter here. The idea is to
re-use what's already existing rather than trying to re-invent the
wheel with an extra lock (or whatever we can come up).
The diffe
This patch is for xdp multicast support. which has been discussed before[0],
The goal is to be able to implement an OVS-like data plane in XDP, i.e.,
a software switch that can forward XDP frames to multiple ports.
To achieve this, an application needs to specify a group of interfaces
to forward a
Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be
used when we want to allow NULL pointer for map parameter. The bpf helper
need to take care and check if the map is NULL when use this type.
Acked-by: Toke Høiland-Jørgensen
Acked-by: John Fastabend
Signed-off-by: Hangbin Liu
From: Jesper Dangaard Brouer
This changes the devmap XDP program support to run the program when the
bulk queue is flushed instead of before the frame is enqueued. This has
a couple of benefits:
- It "sorts" the packets by destination devmap entry, and then runs the
same BPF program on all the
This patch is for xdp multicast support, which has been discussed
before[0], The goal is to be able to implement an OVS-like data plane in
XDP, i.e., a software switch that can forward XDP frames to multiple ports.
To achieve this, an application needs to specify a group of interfaces
to forward a
This is a sample for xdp multicast. In the sample we could forward all
packets between given interfaces. There is also an option -X that could
enable 2nd xdp_prog on egress interface.
Acked-by: Toke Høiland-Jørgensen
Signed-off-by: Hangbin Liu
---
v16-v19: no update
v15: use bpf_object__find_pr
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this
test there are 3 forward groups and 1 exclude group. The test will
redirect each interface's packets to all the interfaces in the forward
group, and exclude the interface in exclude map.
Two maps (DEVMAP, DEVMAP_HASH) and two xdp
Use helper bpf_redirect_map() and bpf_redirect_map_multi() to test bpf
arg ARG_CONST_MAP_PTR and ARG_CONST_MAP_PTR_OR_NULL. Make sure the
map arg could be verified correctly when it is NULL or valid map
pointer.
Add devmap and devmap_hash in struct bpf_test due to bpf_redirect_{map,
map_multi} lim
Alvin Šipraga wrote:
> Add support for CQM RSSI measurement reporting and advertise the
> NL80211_EXT_FEATURE_CQM_RSSI_LIST feature. This enables a userspace
> supplicant such as iwd to be notified of changes in the RSSI for roaming
> and signal monitoring purposes.
>
> Signed-off-by: Alvin Šipr
samirweng1979 wrote:
> From: wengjianfeng
>
> -ENOMEM has been used as a return value,it is not necessary to
> assign it, and if kzalloc fail,not need free it,so just return
> -ENOMEM when kzalloc fail.
>
> Signed-off-by: wengjianfeng
You sent the previous version just five days ago:
https:
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> sturct d11txh contains a ieee80211_rts structure, which is required to
> have at least two byte alignment, and this conflicts with the __packed
> attribute:
>
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h:786:1: warning:
> alignment 1
Hello,
syzbot found the following issue on:
HEAD commit:13391c60 Merge branch 'linus' of git://git.kernel.org/pub/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15eb761b50
kernel config: https://syzkaller.appspot.com/x/.config?x=e7e6ee96c9292f22
das
On 07/02/2021 21:47, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Looking through patchwork I don't see that there was any consensus to
> use switchdev notifiers only in case of netlink provided port flags but
> not sysfs (as a sort of deprecation, punishment or anything like that),
> so we
Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun
Patch applied to wireless-drivers-next.git, thanks.
ae30a740a176 atmel: at76c50x: use DEFINE_MUTEX() for mutex lock
--
https
samirweng1979 wrote:
> From: wengjianfeng
>
> at first, ret was assigned to zero, but later assigned to
> a funciton,so the assignment to zero is no use, which can
> simple be removed instead.
>
> Signed-off-by: wengjianfeng
Patch applied to wireless-drivers-next.git, thanks.
199276b9bcef r
Colin King wrote:
> From: Colin Ian King
>
> The variable ret is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
Yen-lin Lai wrote:
> When a network is moved or reconfigured on the different channel, there
> can be multiple BSSes with the same BSSID and SSID in scan result
> before the old one expires. Then, it can cause cfg80211_connect_result
> to map current_bss to a bss with the wrong channel.
>
> Let
samirweng1979 wrote:
> From: wengjianfeng
>
> -ENOMEM has been used as a return value,it is not necessary to
> assign it, and if kzalloc fail,not need free it,so just return
> -ENOMEM when kzalloc fail.
>
> Signed-off-by: wengjianfeng
Patch applied to wireless-drivers-next.git, thanks.
05d7
samirweng1979 wrote:
> From: wengjianfeng
>
> define refilled and then assign value to it, which should do
> that at the same time.
>
> Signed-off-by: wengjianfeng
Patch applied to wireless-drivers-next.git, thanks.
bb779d476ff7 mwl8k: assign value when defining variables
--
https://patch
samirweng1979 wrote:
> From: wengjianfeng
>
> INVALID_QUEUE has been used as a return value,it is not necessary to
> assign it to q_num,so just return INVALID_QUEUE.
>
> Signed-off-by: wengjianfeng
Patch applied to wireless-drivers-next.git, thanks.
d48aea6054d0 rsi: remove redundant assign
samirweng1979 wrote:
> From: wengjianfeng
>
> remove duplicate word 'we' in comment
> change 'then' to 'than' in comment
>
> Signed-off-by: wengjianfeng
> Acked-by: Randy Dunlap
Patch applied to wireless-drivers-next.git, thanks.
cc1546d6850c rt2x00: remove duplicate word and fix typo in c
Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
> Acked-by: Stanislaw Gruszka
Patch applied to wireless
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> struct wl3501_80211_tx_hdr contains a ieee80211_hdr structure, which is
> required to have at least two byte alignment, and this conflicts with
> the __packed attribute:
>
> wireless/wl3501.h:553:1: warning: alignment 1 of 'struct wl3501_80211_tx_
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> sturct mwl8k_dma_data contains a ieee80211_hdr structure, which is required to
> have at least two byte alignment, and this conflicts with the __packed
> attribute:
>
> vers/net/wireless/marvell/mwl8k.c:811:1: warning: alignment 1 of 'struct
> mw
On Mon, 8 Feb 2021 10:59:54 + (UTC)
Kalle Valo wrote:
> samirweng1979 wrote:
>
> > From: wengjianfeng
> >
> > -ENOMEM has been used as a return value,it is not necessary to
> > assign it, and if kzalloc fail,not need free it,so just return
> > -ENOMEM when kzalloc fail.
> >
> > Signed-o
On 08/02/2021 01:21, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> It must first be admitted that switchdev device drivers have a life
> beyond the bridge, and when they aren't offloading the bridge driver
> they are operating with forwarding disabled between ports, emulating as
> closely as
From: huangxuesen
When pushing vxlan tunnel header, set inner protocol as ETH_P_TEB in skb
to avoid HW device disabling udp tunnel segmentation offload, just like
vxlan_build_skb does.
Drivers for NIC may invoke vxlan_features_check to check the
inner_protocol in skb for vxlan packets to decide
Parameter vf in hclge_vf_rate_param_check() is unused now,
so remove it.
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
b/driv
Since hns3_uninit_all_ring() only returns 0, so remove this
redundant return value and function declaration in hns3_enet.h.
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 12 +++-
drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 1 -
2 files changed,
From: Jian Shen
Since the real tx queue number and real rx queue number
always be updated when netdev opens, it's redundant
to call hclge_client_setup_tc to do the same thing.
So remove it.
Signed-off-by: Jian Shen
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hnae3.h
There are some cleanups for the HNS3 ethernet driver.
Huazhong Tan (2):
net: hns3: remove redundant return value of hns3_uninit_all_ring()
net: hns3: remove an unused parameter in hclge_vf_rate_param_check()
Jian Shen (2):
net: hns3: remove redundant client_setup_tc handle
net: hns3: clea
From: Jian Shen
Currently the RSS commands of VF are using host byte order.
According to the user manual, it should use little endian in
the command to firmware. For the host and firmware are both
using little endian, so it can work well in this case.
Do cleanup to make it more explicitly.
Sign
From: Peng Li
The type of parameter mpf_bd_num and pf_bd_num in
hclge_query_bd_num() should be u32* instead of int*,
so change them.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 4 ++--
1 file changed, 2 insertions(+), 2 delet
From: Peng Li
To make the code more readable, this patch adds a definition for
the magic number 126 used for the default shaper param ir_b, and
rename macro DIVISOR_IR_B_126.
No functional change.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3
From: Peng Li
The type of parameters in hclge_parse_speed() should be
unsigned type, so change them.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/e
From: Yufeng Mo
The parameters sent from VF may be unreliable. If these
parameters are used directly, memory overwriting may occur.
Therefore, we need to check parameters before using.
Signed-off-by: Yufeng Mo
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.c
1 - 100 of 481 matches
Mail list logo
