Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Marc Kleine-Budde
On 1/12/21 10:54 AM, Vincent Mailhol wrote: > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > tx timestamp gets attached on the skb. > > There two main reasons to include this call in can_put_echo_skb(): > > * It easily allow to enable the tx timestamp on all devices with

[PATCH v2 iproute2] tc: flower: fix json output with mpls lse

2021-01-12 Thread Guillaume Nault
The json output of the TCA_FLOWER_KEY_MPLS_OPTS attribute was invalid. Example: $ tc filter add dev eth0 ingress protocol mpls_uc flower mpls \ lse depth 1 label 100 \ lse depth 2 label 200 $ tc -json filter show dev eth0 ingress ...{"eth_t

[PATCH V3] drivers: net: marvell: Fixed two spellings,controling to controlling and oen to one

2021-01-12 Thread Bhaskar Chowdhury
s/oen/one/ s/controling/controlling/ Signed-off-by: Bhaskar Chowdhury --- Changes from V2 : Correct the versioning,mentioned both the changes drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvp

[PATCH iproute2 v4 1/1] build: Fix link errors on some systems

2021-01-12 Thread Roi Dayan
Since moving get_rate() and get_size() from tc to lib, on some systems we fail to link because of missing math lib. Move the functions that require math lib to their own c file and add -lm to dcb that now use those functions. ../lib/libutil.a(utils.o): In function `get_rate': utils.c:(.text+0x10dc

Re: [PATCH iproute2 v3 1/1] build: Fix link errors on some systems

2021-01-12 Thread Roi Dayan
On 2021-01-11 6:51 PM, Petr Machata wrote: Roi Dayan writes: diff --git a/lib/json_print_math.c b/lib/json_print_math.c new file mode 100644 index ..3d560defcd3e --- /dev/null +++ b/lib/json_print_math.c @@ -0,0 +1,46 @@ +/* + * json_print_math.c "print regular or jso

Re: [PATCH net-next v14 4/6] net: dsa: mv88e6xxx: wrap .set_egress_port method

2021-01-12 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 02:21:54AM +0100, Marek Behún wrote: > There are two implementations of the .set_egress_port method, and both > of them, if successful, set chip->*gress_dest_port variable. > > To avoid code repetition, wrap this method into > mv88e6xxx_set_egress_port. > > Signed-off-by:

Re: [PATCH net-next v14 3/6] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

2021-01-12 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 02:21:53AM +0100, Marek Behún wrote: > From: Pavana Sharma > > Returning 0 is no more an error case with MV88E6393 family > which has serdes lane numbers 0, 9 or 10. > So with this change .serdes_get_lane will return lane number > or -errno (-ENODEV or -EOPNOTSUPP). > > S

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-12 Thread Alexander Lobakin
From: Eric Dumazet Date: Tue, 12 Jan 2021 09:20:39 +0100 > On Mon, Jan 11, 2021 at 7:27 PM Alexander Lobakin wrote: >> >> Inspired by cpu_map_kthread_run() and _kfree_skb_defer() logics. >> >> Currently, all sorts of skb allocation always do allocate >> skbuff_heads one by one via kmem_cache_all

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-12 Thread Alexander Lobakin
From: Edward Cree Date: Tue, 12 Jan 2021 09:54:04 + > Without wishing to weigh in on whether this caching is a good idea... Well, we already have a cache to bulk flush "consumed" skbs, although kmem_cache_free() is generally lighter than kmem_cache_alloc(), and a page frag cache to allocate

Re: [PATCH net-next v14 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 02:21:55AM +0100, Marek Behún wrote: > From: Pavana Sharma > > The Marvell 88E6393X device is a single-chip integration of a 11-port > Ethernet switch with eight integrated Gigabit Ethernet (GbE) > transceivers and three 10-Gigabit interfaces. > > This patch adds function

[PATCH] brcmfmac: add support for CQM RSSI notifications

2021-01-12 Thread Alvin Šipraga
Add support for CQM RSSI measurement reporting and advertise the NL80211_EXT_FEATURE_CQM_RSSI_LIST feature. This enables a userspace supplicant such as iwd to be notified of changes in the RSSI for roaming and signal monitoring purposes. Signed-off-by: Alvin Šipraga --- .../broadcom/brcm80211/br

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2021-01-12 Thread Kalle Valo
(adding luca) Michal Kubecek writes: > FYI, there is a regression in iwlwifi driver caused by commit > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > reported at > > https://bugzilla.kernel.org/show_bug.cgi?id=210733 > https://bugzilla.suse.com/show_bug.cgi?id=1180344 > >

[PATCH V2 net 0/6] ethernet: fixes for stmmac driver

2021-01-12 Thread Joakim Zhang
Fixes for stmmac driver. --- ChangeLogs: V1->V2: * subject prefix: ethernet: stmmac: -> net: stmmac: * use dma_addr_t instead of unsigned int for physical address * use cpu_to_le32() Joakim Zhang (6): net: stmmac: remove redundant null check for ptp clock net: stmmac:

[PATCH V2 net 4/6] net: stmmac: fix dma physical address of descriptor when display ring

2021-01-12 Thread Joakim Zhang
Driver uses dma_alloc_coherent to allocate dma memory for descriptors, dma_alloc_coherent will return both the virtual address and physical address. AFAIK, virt_to_phys could not convert virtual address to physical address, for which memory is allocated by dma_alloc_coherent. Signed-off-by: Joakim

[PATCH V2 net 6/6] net: stmmac: re-init rx buffers when mac resume back

2021-01-12 Thread Joakim Zhang
During suspend/resume stress test, we found descriptor write back by DMA could exhibit unusual behavior, e.g.: 003 [0xc4310030]: 0x0 0x40 0x0 0xb5010040 We can see that desc3 write back is 0xb5010040, it is still ownd by DMA, so application would not recycle this buffer. It will trigger fa

[PATCH V2 net 2/6] net: stmmac: stop each tx channel independently

2021-01-12 Thread Joakim Zhang
If clear GMAC_CONFIG_TE bit, it would stop all tx channels, but users may only want to stop secific tx channel. Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 4 1 file changed, 4 deletions(-)

[PATCH V2 net 3/6] net: stmmac: fix watchdog timeout during suspend/resume stress test

2021-01-12 Thread Joakim Zhang
stmmac_xmit() call stmmac_tx_timer_arm() at the end to modify tx timer to do the transmission cleanup work. Imagine such a situation, stmmac enters suspend immediately after tx timer modified, it's expire callback stmmac_tx_clean() would not be invoked. This could affect BQL, since netdev_tx_sent_q

[PATCH V2 net 5/6] net: stmmac: fix wrongly set buffer2 valid when sph unsupport

2021-01-12 Thread Joakim Zhang
In current driver, buffer2 available only when hardware supports split header. Wrongly set buffer2 valid in stmmac_rx_refill when refill buffer address. You can see that desc3 is 0x8100 after initialization, but turn out to be 0x8300 after refill. Fixes: 67afd6d1cfdf ("net: stmmac: Add Spl

[PATCH V2 net 1/6] net: stmmac: remove redundant null check for ptp clock

2021-01-12 Thread Joakim Zhang
Remove redundant null check for ptp clock. Fixes: 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before clk_disable_unprepare()") Reviewed-by: Andrew Lunn Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 delet

Re: [Patch net] cls_flower: call nla_ok() before nla_next()

2021-01-12 Thread Xin Long
On Tue, Jan 12, 2021 at 10:56 AM Cong Wang wrote: > > From: Cong Wang > > fl_set_enc_opt() simply checks if there are still bytes left to parse, > but this is not sufficent as syzbot seems to be able to generate > malformatted netlink messages. nla_ok() is more strict so should be > used to valid

Re: [PATCH net v2] net: macb: Add default usrio config to default gem config

2021-01-12 Thread Nicolas Ferre
On 12/01/2021 at 02:47, Atish Patra wrote: There is no usrio config defined for default gem config leading to a kernel panic devices that don't define a data. This issue can be reproduced with microchip polar fire soc where compatible string is defined as "cdns,macb". Fixes: edac63861db7 ("net:

[PATCH iproute2] include: uapi: Carry dcbnl.h

2021-01-12 Thread Petr Machata
To allow building a new suite of DCB tools on an older kernel, carry a copy of dcbnl.h. Signed-off-by: Petr Machata --- include/uapi/linux/dcbnl.h | 769 + 1 file changed, 769 insertions(+) create mode 100644 include/uapi/linux/dcbnl.h diff --git a/include/u

Re: [PATCH iproute2 v4 1/1] build: Fix link errors on some systems

2021-01-12 Thread Petr Machata
Roi Dayan writes: > Since moving get_rate() and get_size() from tc to lib, on some > systems we fail to link because of missing math lib. > Move the functions that require math lib to their own c file > and add -lm to dcb that now use those functions. > > ../lib/libutil.a(utils.o): In function

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 12:33:14 +0100, Kalle Valo wrote: > > (adding luca) > > Michal Kubecek writes: > > > FYI, there is a regression in iwlwifi driver caused by commit > > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > > reported at > > > > https://bugzilla.kernel.org/show_

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2021-01-12 Thread Kalle Valo
Takashi Iwai writes: > On Tue, 12 Jan 2021 12:33:14 +0100, > Kalle Valo wrote: >> >> (adding luca) >> >> Michal Kubecek writes: >> >> > FYI, there is a regression in iwlwifi driver caused by commit >> > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") >> > reported at >> > >>

[PATCH AUTOSEL 5.10 08/51] netfilter: ipset: fixes possible oops in mtype_resize

2021-01-12 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 2b33d6ffa9e38f344418976b06057e2fc2aa9e2a ] currently mtype_resize() can cause oops t = ip_set_alloc(htable_size(htable_bits)); if (!t) { ret = -ENOMEM; goto out; } t->hregion = ip_set_alloc(aha

[PATCH AUTOSEL 5.10 23/51] CDC-NCM: remove "connected" log message

2021-01-12 Thread Sasha Levin
From: Roland Dreier [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ] The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices

[PATCH AUTOSEL 5.10 36/51] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-12 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 445c6198fe7be03b7d38e66fe8d4b3187bc251d4 ] Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-

[PATCH AUTOSEL 5.4 11/28] CDC-NCM: remove "connected" log message

2021-01-12 Thread Sasha Levin
From: Roland Dreier [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ] The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices

[PATCH AUTOSEL 4.4 5/8] misdn: dsp: select CONFIG_BITREVERSE

2021-01-12 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 51049bd903a81307f751babe15a1df8d197884e8 ] Without this, we run into a link error arm-linux-gnueabi-ld: drivers/isdn/mISDN/dsp_audio.o: in function `dsp_audio_generate_law_tables': (.text+0x30c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 13:45:33 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > On Tue, 12 Jan 2021 12:33:14 +0100, > > Kalle Valo wrote: > >> > >> (adding luca) > >> > >> Michal Kubecek writes: > >> > >> > FYI, there is a regression in iwlwifi driver caused by commit > >> > ba8f6f4ae25

[PATCH AUTOSEL 4.9 3/8] CDC-NCM: remove "connected" log message

2021-01-12 Thread Sasha Levin
From: Roland Dreier [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ] The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices

[PATCH AUTOSEL 4.4 6/8] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-12 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 445c6198fe7be03b7d38e66fe8d4b3187bc251d4 ] Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-

[PATCH AUTOSEL 4.9 6/8] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-12 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 445c6198fe7be03b7d38e66fe8d4b3187bc251d4 ] Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-

[PATCH AUTOSEL 4.9 5/8] misdn: dsp: select CONFIG_BITREVERSE

2021-01-12 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 51049bd903a81307f751babe15a1df8d197884e8 ] Without this, we run into a link error arm-linux-gnueabi-ld: drivers/isdn/mISDN/dsp_audio.o: in function `dsp_audio_generate_law_tables': (.text+0x30c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld

[PATCH AUTOSEL 4.4 2/8] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2021-01-12 Thread Sasha Levin
From: Rasmus Villemoes [ Upstream commit 887078de2a23689e29d6fa1b75d7cbc544c280be ] Table 8-53 in the QUICC Engine Reference manual shows definitions of fields up to a size of 192 bytes, not just 128. But in table 8-111, one does find the text Base Address of the Global Transmitter Parameter

[PATCH AUTOSEL 4.4 3/8] CDC-NCM: remove "connected" log message

2021-01-12 Thread Sasha Levin
From: Roland Dreier [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ] The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices

[PATCH AUTOSEL 4.9 2/8] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2021-01-12 Thread Sasha Levin
From: Rasmus Villemoes [ Upstream commit 887078de2a23689e29d6fa1b75d7cbc544c280be ] Table 8-53 in the QUICC Engine Reference manual shows definitions of fields up to a size of 192 bytes, not just 128. But in table 8-111, one does find the text Base Address of the Global Transmitter Parameter

[PATCH AUTOSEL 4.14 07/13] CDC-NCM: remove "connected" log message

2021-01-12 Thread Sasha Levin
From: Roland Dreier [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ] The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices

[PATCH AUTOSEL 4.14 08/13] net: usb: qmi_wwan: add Quectel EM160R-GL

2021-01-12 Thread Sasha Levin
From: Bjørn Mork [ Upstream commit cfd82dfc9799c53ef109343a23af006a0f6860a9 ] New modem using ff/ff/30 for QCDM, ff/00/00 for AT and NMEA, and ff/ff/ff for RMNET/QMI. T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 P:

[PATCH AUTOSEL 4.14 10/13] misdn: dsp: select CONFIG_BITREVERSE

2021-01-12 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 51049bd903a81307f751babe15a1df8d197884e8 ] Without this, we run into a link error arm-linux-gnueabi-ld: drivers/isdn/mISDN/dsp_audio.o: in function `dsp_audio_generate_law_tables': (.text+0x30c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld

[PATCH AUTOSEL 4.14 11/13] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-12 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 445c6198fe7be03b7d38e66fe8d4b3187bc251d4 ] Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-

[PATCH AUTOSEL 4.19 13/16] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-12 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 445c6198fe7be03b7d38e66fe8d4b3187bc251d4 ] Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-

[PATCH AUTOSEL 4.14 06/13] qede: fix offload for IPIP tunnel packets

2021-01-12 Thread Sasha Levin
From: Manish Chopra [ Upstream commit 5d5647dad259bb416fd5d3d87012760386d97530 ] IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by:

[PATCH AUTOSEL 4.14 05/13] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2021-01-12 Thread Sasha Levin
From: Rasmus Villemoes [ Upstream commit 887078de2a23689e29d6fa1b75d7cbc544c280be ] Table 8-53 in the QUICC Engine Reference manual shows definitions of fields up to a size of 192 bytes, not just 128. But in table 8-111, one does find the text Base Address of the Global Transmitter Parameter

[PATCH AUTOSEL 4.19 12/16] misdn: dsp: select CONFIG_BITREVERSE

2021-01-12 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 51049bd903a81307f751babe15a1df8d197884e8 ] Without this, we run into a link error arm-linux-gnueabi-ld: drivers/isdn/mISDN/dsp_audio.o: in function `dsp_audio_generate_law_tables': (.text+0x30c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld

[PATCH AUTOSEL 4.19 07/16] CDC-NCM: remove "connected" log message

2021-01-12 Thread Sasha Levin
From: Roland Dreier [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ] The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices

[PATCH AUTOSEL 4.19 09/16] net: usb: qmi_wwan: add Quectel EM160R-GL

2021-01-12 Thread Sasha Levin
From: Bjørn Mork [ Upstream commit cfd82dfc9799c53ef109343a23af006a0f6860a9 ] New modem using ff/ff/30 for QCDM, ff/00/00 for AT and NMEA, and ff/ff/ff for RMNET/QMI. T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 P:

[PATCH AUTOSEL 4.19 05/16] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2021-01-12 Thread Sasha Levin
From: Rasmus Villemoes [ Upstream commit 887078de2a23689e29d6fa1b75d7cbc544c280be ] Table 8-53 in the QUICC Engine Reference manual shows definitions of fields up to a size of 192 bytes, not just 128. But in table 8-111, one does find the text Base Address of the Global Transmitter Parameter

[PATCH v10 0/1] add support for ETAS ES58X CAN USB interfaces

2021-01-12 Thread Vincent Mailhol
Here is the v10 of the patch. Hope that we are now close to a release. Thanks for your comments! Yours sincerely, Vincent --- Changes in v10 (2021-01-12): - Rebased on linux-can-next/testing and modified according to latest BQL patches. Reference: https://lore.kernel.org/linux-can/20210

[PATCH AUTOSEL 4.19 06/16] qede: fix offload for IPIP tunnel packets

2021-01-12 Thread Sasha Levin
From: Manish Chopra [ Upstream commit 5d5647dad259bb416fd5d3d87012760386d97530 ] IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by:

[PATCH AUTOSEL 5.4 19/28] misdn: dsp: select CONFIG_BITREVERSE

2021-01-12 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 51049bd903a81307f751babe15a1df8d197884e8 ] Without this, we run into a link error arm-linux-gnueabi-ld: drivers/isdn/mISDN/dsp_audio.o: in function `dsp_audio_generate_law_tables': (.text+0x30c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld

[PATCH AUTOSEL 5.4 20/28] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-12 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 445c6198fe7be03b7d38e66fe8d4b3187bc251d4 ] Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-

[PATCH AUTOSEL 5.4 09/28] qede: fix offload for IPIP tunnel packets

2021-01-12 Thread Sasha Levin
From: Manish Chopra [ Upstream commit 5d5647dad259bb416fd5d3d87012760386d97530 ] IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by:

Re: [PATCH AUTOSEL 5.10 23/51] CDC-NCM: remove "connected" log message

2021-01-12 Thread Greg Kroah-Hartman
On Tue, Jan 12, 2021 at 07:55:05AM -0500, Sasha Levin wrote: > From: Roland Dreier > > [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ] > > The cdc_ncm driver passes network connection notifications up to > usbnet_link_change(), which is the right place for any logging. > Remove the

[PATCH AUTOSEL 5.4 21/28] selftests: fix the return value for UDP GRO test

2021-01-12 Thread Sasha Levin
From: Po-Hsu Lin [ Upstream commit 3503ee6c0bec5f173d606359e6384a5ef85492fb ] The udpgro.sh will always return 0 (unless the bpf selftest was not build first) even if there are some failed sub test-cases. Therefore the kselftest framework will report this case is OK. Check and return the exit

[PATCH AUTOSEL 5.4 16/28] net: usb: qmi_wwan: add Quectel EM160R-GL

2021-01-12 Thread Sasha Levin
From: Bjørn Mork [ Upstream commit cfd82dfc9799c53ef109343a23af006a0f6860a9 ] New modem using ff/ff/30 for QCDM, ff/00/00 for AT and NMEA, and ff/ff/ff for RMNET/QMI. T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 P:

[PATCH AUTOSEL 5.4 05/28] netfilter: ipset: fixes possible oops in mtype_resize

2021-01-12 Thread Sasha Levin
From: Vasily Averin [ Upstream commit 2b33d6ffa9e38f344418976b06057e2fc2aa9e2a ] currently mtype_resize() can cause oops t = ip_set_alloc(htable_size(htable_bits)); if (!t) { ret = -ENOMEM; goto out; } t->hregion = ip_set_alloc(aha

[PATCH AUTOSEL 5.10 35/51] misdn: dsp: select CONFIG_BITREVERSE

2021-01-12 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 51049bd903a81307f751babe15a1df8d197884e8 ] Without this, we run into a link error arm-linux-gnueabi-ld: drivers/isdn/mISDN/dsp_audio.o: in function `dsp_audio_generate_law_tables': (.text+0x30c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld

[PATCH AUTOSEL 5.4 08/28] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2021-01-12 Thread Sasha Levin
From: Rasmus Villemoes [ Upstream commit 887078de2a23689e29d6fa1b75d7cbc544c280be ] Table 8-53 in the QUICC Engine Reference manual shows definitions of fields up to a size of 192 bytes, not just 128. But in table 8-111, one does find the text Base Address of the Global Transmitter Parameter

[PATCH AUTOSEL 5.10 31/51] net: usb: qmi_wwan: add Quectel EM160R-GL

2021-01-12 Thread Sasha Levin
From: Bjørn Mork [ Upstream commit cfd82dfc9799c53ef109343a23af006a0f6860a9 ] New modem using ff/ff/30 for QCDM, ff/00/00 for AT and NMEA, and ff/ff/ff for RMNET/QMI. T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 P:

[PATCH AUTOSEL 5.10 16/51] qede: fix offload for IPIP tunnel packets

2021-01-12 Thread Sasha Levin
From: Manish Chopra [ Upstream commit 5d5647dad259bb416fd5d3d87012760386d97530 ] IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by:

[PATCH AUTOSEL 5.10 37/51] selftests: fix the return value for UDP GRO test

2021-01-12 Thread Sasha Levin
From: Po-Hsu Lin [ Upstream commit 3503ee6c0bec5f173d606359e6384a5ef85492fb ] The udpgro.sh will always return 0 (unless the bpf selftest was not build first) even if there are some failed sub test-cases. Therefore the kselftest framework will report this case is OK. Check and return the exit

[PATCH AUTOSEL 5.10 18/51] e1000e: Only run S0ix flows if shutdown succeeded

2021-01-12 Thread Sasha Levin
From: Mario Limonciello [ Upstream commit 808e0d8832cc81738f3e8df12dff0688352baf50 ] If the shutdown failed, the part will be thawed and running S0ix flows will put it into an undefined state. Reported-by: Alexander Duyck Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello Tested-b

[PATCH AUTOSEL 5.10 14/51] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2021-01-12 Thread Sasha Levin
From: Rasmus Villemoes [ Upstream commit 887078de2a23689e29d6fa1b75d7cbc544c280be ] Table 8-53 in the QUICC Engine Reference manual shows definitions of fields up to a size of 192 bytes, not just 128. But in table 8-111, one does find the text Base Address of the Global Transmitter Parameter

[PATCH AUTOSEL 5.10 17/51] stmmac: intel: Add PCI IDs for TGL-H platform

2021-01-12 Thread Sasha Levin
From: Noor Azura Ahmad Tarmizi [ Upstream commit 8450e23f142f629e40bd67afc8375c86c7fbf8f1 ] Add TGL-H PCI info and PCI IDs for the new TSN Controller to the list of supported devices. Signed-off-by: Noor Azura Ahmad Tarmizi Signed-off-by: Voon Weifeng Signed-off-by: Muhammad Husaini Zulkifli

[PATCH AUTOSEL 5.10 06/51] ath11k: fix crash caused by NULL rx_channel

2021-01-12 Thread Sasha Levin
From: Carl Huang [ Upstream commit 3597010630d0aa96f5778901e691c6068bb86318 ] During connect and disconnect stress test, crashed happened because ar->rx_channel is NULL. Fix it by checking whether ar->rx_channel is NULL. Crash stack is as below: RIP: 0010:ath11k_dp_rx_h_ppdu+0x110/0x230 [ath11k

[PATCH AUTOSEL 5.10 07/51] rtlwifi: rise completion at the last step of firmware callback

2021-01-12 Thread Sasha Levin
From: Ping-Ke Shih [ Upstream commit 4dfde294b9792dcf8615b55c58f093d544f472f0 ] request_firmware_nowait() which schedules another work is used to load firmware when USB is probing. If USB is unplugged before running the firmware work, it goes disconnect ops, and then causes use-after-free. Thoug

[PATCH AUTOSEL 5.10 09/51] ath11k: qmi: try to allocate a big block of DMA memory first

2021-01-12 Thread Sasha Levin
From: Carl Huang [ Upstream commit f6f92968e1e5a7a9d211faaebefc26ebe408dad7 ] Not all firmware versions support allocating DMA memory in smaller blocks so first try to allocate big block of DMA memory for QMI. If the allocation fails, let firmware request multiple blocks of DMA memory with small

Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

2021-01-12 Thread Pkshih
On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: > WARNING: Comparison of 0/1 to bool variable > > Reported-by: Abaci Robot > Signed-off-by: YANG LI > I think your name of Signed-off-by

[PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-12 Thread Takashi Iwai
The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") added a termination of name string just to be sure, and this seems causing a regression, a GPF triggered at firmware loading. Basically we shouldn't modify the firmware data that may be provided as read-only. This patch dr

[PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Takashi Iwai
The ucode TLV data may be read-only and should be treated as const pointers, but currently a few code forcibly cast to the writable pointer unnecessarily. This gave developers a wrong impression as if it can be modified, resulting in crashing regressions already a couple of times. This patch adds

[PATCH 0/2] iwlwifi: Fix a crash at loading

2021-01-12 Thread Takashi Iwai
Hi, this is the fix for the recently introduced regression of iwlwifi driver (since 5.10), a crash at the module loading [1][2]. The first patch actually fixes the bug, and this should go to 5.11-rc. The second patch is an enhancement to make pointers const for safety. Takashi [1] https://bugzi

Re: [PATCH] wireless: realtek: Simplify bool comparison

2021-01-12 Thread Pkshih
On Tue, 2021-01-12 at 16:39 +0800, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING: > Comparison to bool > > Reported-by: Abaci Robot > Signed-off-by: YANG LI > --- >  drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++-- >  1 f

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-12 Thread Pali Rohár
On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > This is a third version of patches which add workarounds for > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > Russel's PATCH v2 2/3 was dropped from this patch series as > it is being handled separately. > > Pali Rohár (2): >

[net-next PATCH v3 00/15] ACPI support for dpaa2 driver

2021-01-12 Thread Calvin Johnson
This patch set provides ACPI support to DPAA2 network drivers. It also introduces new fwnode based APIs to support phylink and phy layers Following functions are defined: phylink_fwnode_phy_connect() fwnode_mdiobus_register_phy() fwnode_mdiobus_register() fwnode_get_p

[net-next PATCH v3 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-01-12 Thread Calvin Johnson
Introduce ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. Describe properties "phy-handle" and "phy-mode". Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: - Updated with more description in document Documentation/firmware-guide

[net-next PATCH v3 03/15] net: phy: Introduce phy related fwnode functions

2021-01-12 Thread Calvin Johnson
Define fwnode_phy_find_device() to iterate an mdiobus and find the phy device of the provided phy fwnode. Additionally define device_phy_find_device() to find phy device of provided device. Define fwnode_get_phy_node() to get phy_node using named reference. Signed-off-by: Calvin Johnson --- Cha

[net-next PATCH v3 06/15] of: mdio: Refactor of_get_phy_id()

2021-01-12 Thread Calvin Johnson
With the introduction of fwnode_get_phy_id(), refactor of_get_phy_id() to use fwnode equivalent. Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None drivers/net/mdio/of_mdio.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/mdi

[net-next PATCH v3 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

2021-01-12 Thread Calvin Johnson
Introduce fwnode_mdiobus_register_phy() to register PHYs on the mdiobus. From the compatible string, identify whether the PHY is c45 and based on this create a PHY device instance which is registered on the mdiobus. Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None driv

[net-next PATCH v3 02/15] net: phy: Introduce fwnode_mdio_find_device()

2021-01-12 Thread Calvin Johnson
Define fwnode_mdio_find_device() to get a pointer to the mdio_device from fwnode passed to the function. Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None drivers/net/mdio/of_mdio.c | 11 +-- drivers/net/phy/phy_device.c | 23 +++ include/l

[net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-12 Thread Calvin Johnson
Using fwnode_get_id(), get the reg property value for DT node or get the _ADR object value for ACPI node. Signed-off-by: Calvin Johnson --- Changes in v3: - Modified to retrieve reg property value for ACPI as well - Resolved compilation issue with CONFIG_ACPI = n - Added more info into documenta

[net-next PATCH v3 10/15] net: mdio: Add ACPI support code for mdio

2021-01-12 Thread Calvin Johnson
Define acpi_mdiobus_register() to Register mii_bus and create PHYs for each ACPI child node. Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None MAINTAINERS | 1 + drivers/net/mdio/Kconfig | 7 ++ drivers/net/mdio/Makefile| 1 + drivers/net

[net-next PATCH v3 04/15] of: mdio: Refactor of_phy_find_device()

2021-01-12 Thread Calvin Johnson
Refactor of_phy_find_device() to use fwnode_phy_find_device(). Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None drivers/net/mdio/of_mdio.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of

[net-next PATCH v3 11/15] net: mdiobus: Introduce fwnode_mdiobus_register()

2021-01-12 Thread Calvin Johnson
Introduce fwnode_mdiobus_register() to register PHYs on the mdiobus. If the fwnode is DT node, then call of_mdiobus_register(). If it is an ACPI node, then call acpi_mdiobus_register(). Signed-off-by: Calvin Johnson --- Changes in v3: - Use acpi_mdiobus_register() Changes in v2: None drivers

[net-next PATCH v3 12/15] net/fsl: Use fwnode_mdiobus_register()

2021-01-12 Thread Calvin Johnson
fwnode_mdiobus_register() internally takes care of both DT and ACPI cases to register mdiobus. Replace existing of_mdiobus_register() with fwnode_mdiobus_register(). Note: For both ACPI and DT cases, endianness of MDIO controller need to be specified using "little-endian" property. Signed-off-by:

[net-next PATCH v3 13/15] phylink: introduce phylink_fwnode_phy_connect()

2021-01-12 Thread Calvin Johnson
Define phylink_fwnode_phy_connect() to connect phy specified by a fwnode to a phylink instance. Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None drivers/net/phy/phylink.c | 54 +++ include/linux/phylink.h | 3 +++ 2 files changed,

[net-next PATCH v3 05/15] net: phy: Introduce fwnode_get_phy_id()

2021-01-12 Thread Calvin Johnson
Extract phy_id from compatible string. This will be used by fwnode_mdiobus_register_phy() to create phy device using the phy_id. Signed-off-by: Calvin Johnson --- Changes in v3: - Use traditional comparison pattern - Use GENMASK Changes in v2: None drivers/net/phy/phy_device.c | 21 ++

[net-next PATCH v3 08/15] of: mdio: Refactor of_mdiobus_register_phy()

2021-01-12 Thread Calvin Johnson
Refactor of_mdiobus_register_phy() to use fwnode_mdiobus_register_phy(). Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None drivers/net/mdio/of_mdio.c | 40 +- 1 file changed, 1 insertion(+), 39 deletions(-) diff --git a/drivers/net/m

[net-next PATCH v3 14/15] net: phylink: Refactor phylink_of_phy_connect()

2021-01-12 Thread Calvin Johnson
Refactor phylink_of_phy_connect() to use phylink_fwnode_phy_connect(). Signed-off-by: Calvin Johnson --- Changes in v3: None Changes in v2: None drivers/net/phy/phylink.c | 39 +-- 1 file changed, 1 insertion(+), 38 deletions(-) diff --git a/drivers/net/phy

[net-next PATCH v3 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-01-12 Thread Calvin Johnson
Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode with fwnode_get_phy_mode to get phy-mode for a dpmac_node. Use helper function phylink_fwnode_phy_connect() to find phy_dev and connect to

Re: [PATCH v6 net-next 03/15] net: procfs: hold netif_lists_lock when retrieving device statistics

2021-01-12 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 03:46:32PM -0800, Saeed Mahameed wrote: > This can be very costly, holding a mutex while traversing the whole > netedv lists and reading their stats, we need to at least allow > multiple readers to enter as it was before, so maybe you want to use > rw_semaphore instead of th

Re: [PATCH net-next v3 2/2] net: flow_dissector: Parse PTP L2 packet header

2021-01-12 Thread Richard Cochran
On Mon, Jan 11, 2021 at 08:17:48PM +0200, Eran Ben Elisha wrote: > Add support for parsing PTP L2 packet header. Such packet consists > of an L2 header (with ethertype of ETH_P_1588), PTP header, body > and an optional suffix. > > Signed-off-by: Eran Ben Elisha > Reviewed-by: Tariq Toukan > ---

Re: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-12 Thread Andrew Lunn
On Tue, Jan 12, 2021 at 05:14:21AM +, ashid...@fujitsu.com wrote: > > For T1, it seems like Master is pretty important. Do you have > > information to be able to return the current Master/slave > > configuration, or allow it to be configured? See the nxp-tja11xx.c > > for an example. > > I thi

Re: [PATCH bpf 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

2021-01-12 Thread KP Singh
On Tue, Jan 12, 2021 at 10:14 AM Gilad Reti wrote: > > Add support for pointer to mem register spilling, to allow the verifier > to track pointer to valid memory addresses. Such pointers are returned nit: pointers > for example by a successful call of the bpf_ringbuf_reserve helper. > > This pat

Re: [PATCH V2 net 4/6] net: stmmac: fix dma physical address of descriptor when display ring

2021-01-12 Thread kernel test robot
Hi Joakim, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Joakim-Zhang/ethernet-fixes-for-stmmac-driver/20210112-193904 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Andrew Lunn
> I'd think that mdio-i2c.c is for generic code. When adding a > vendor-specific protocol, wouldn't it make sense to use a dedicated > source file for it? Hi Heiner There is no standardised way to access MDIO over i2c. So the existing code is vendor code, even if it is used by a few different ven

[PATCH net] net: stmmac: use __napi_schedule() for PREEMPT_RT

2021-01-12 Thread Sebastien Laveze
From: Seb Laveze Use of __napi_schedule_irqoff() is not safe with PREEMPT_RT in which hard interrupts are not disabled while running the threaded interrupt. Using __napi_schedule() works for both PREEMPT_RT and mainline Linux, just at the cost of an additional check if interrupts are disabled fo

Re: [PATCH net-next v3 2/2] net: flow_dissector: Parse PTP L2 packet header

2021-01-12 Thread Eran Ben Elisha
On 1/12/2021 3:49 PM, Richard Cochran wrote: On Mon, Jan 11, 2021 at 08:17:48PM +0200, Eran Ben Elisha wrote: Add support for parsing PTP L2 packet header. Such packet consists of an L2 header (with ethertype of ETH_P_1588), PTP header, body and an optional suffix. Signed-off-by: Eran Ben El

Re: [PATCH bpf 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

2021-01-12 Thread Gilad Reti
On Tue, Jan 12, 2021 at 3:57 PM KP Singh wrote: > > On Tue, Jan 12, 2021 at 10:14 AM Gilad Reti wrote: > > > > Add support for pointer to mem register spilling, to allow the verifier > > to track pointer to valid memory addresses. Such pointers are returned > > nit: pointers Thanks > > > for ex

<    1   2   3   4   5   >