Hi Joakim,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]

url:    
https://github.com/0day-ci/linux/commits/Joakim-Zhang/ethernet-fixes-for-stmmac-driver/20210112-193904
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 
1ee527a79fa6d0a85425cafc1632e09bd8d3dca7
config: i386-randconfig-a004-20210112 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # 
https://github.com/0day-ci/linux/commit/7464ee433bef5bfbed3649c3bb4fb47815de1d26
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Joakim-Zhang/ethernet-fixes-for-stmmac-driver/20210112-193904
        git checkout 7464ee433bef5bfbed3649c3bb4fb47815de1d26
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 
'sysfs_display_ring':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4341:30: warning: format 
>> '%llx' expects argument of type 'long long unsigned int', but argument 4 has 
>> type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
    4341 |    seq_printf(seq, "%d [0x%llx]: 0x%x 0x%x 0x%x 0x%x\n",
         |                           ~~~^
         |                              |
         |                              long long unsigned int
         |                           %x
    4342 |        i, dma_phy_addr + i * sizeof(ep),
         |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                        |
         |                        dma_addr_t {aka unsigned int}
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4349:30: warning: format 
'%llx' expects argument of type 'long long unsigned int', but argument 4 has 
type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
    4349 |    seq_printf(seq, "%d [0x%llx]: 0x%x 0x%x 0x%x 0x%x\n",
         |                           ~~~^
         |                              |
         |                              long long unsigned int
         |                           %x
    4350 |        i, dma_phy_addr + i * sizeof(p),
         |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                        |
         |                        dma_addr_t {aka unsigned int}


vim +4341 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

  4331  
  4332  static void sysfs_display_ring(void *head, int size, int extend_desc,
  4333                                 struct seq_file *seq, dma_addr_t 
dma_phy_addr)
  4334  {
  4335          int i;
  4336          struct dma_extended_desc *ep = (struct dma_extended_desc *)head;
  4337          struct dma_desc *p = (struct dma_desc *)head;
  4338  
  4339          for (i = 0; i < size; i++) {
  4340                  if (extend_desc) {
> 4341                          seq_printf(seq, "%d [0x%llx]: 0x%x 0x%x 0x%x 
> 0x%x\n",
  4342                                     i, dma_phy_addr + i * sizeof(ep),
  4343                                     le32_to_cpu(ep->basic.des0),
  4344                                     le32_to_cpu(ep->basic.des1),
  4345                                     le32_to_cpu(ep->basic.des2),
  4346                                     le32_to_cpu(ep->basic.des3));
  4347                          ep++;
  4348                  } else {
  4349                          seq_printf(seq, "%d [0x%llx]: 0x%x 0x%x 0x%x 
0x%x\n",
  4350                                     i, dma_phy_addr + i * sizeof(p),
  4351                                     le32_to_cpu(p->des0), 
le32_to_cpu(p->des1),
  4352                                     le32_to_cpu(p->des2), 
le32_to_cpu(p->des3));
  4353                          p++;
  4354                  }
  4355                  seq_printf(seq, "\n");
  4356          }
  4357  }
  4358  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to