Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode

2021-01-11 Thread Michał Mirosław
pon., 11 sty 2021 o 14:54 Bjarni Jonasson napisał(a): > Sparx-5 supports this mode and it is missing in the PHY core. > > Signed-off-by: Bjarni Jonasson > --- > include/linux/phy.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 5656

Re: [PATCH 5/7] ibmvnic: use a lock to serialize remove/reset

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 19:52:25 -0800 Sukadev Bhattiprolu wrote: > Jakub Kicinski [k...@kernel.org] wrote: > > On Thu, 7 Jan 2021 23:12:34 -0800 Sukadev Bhattiprolu wrote: > > > Use a separate lock to serialze ibmvnic_reset() and ibmvnic_remove() > > > functions. ibmvnic_reset() schedules work for

Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 20:21:23 +0100 Felix Fietkau wrote: > On 2021-01-11 18:41, Jakub Kicinski wrote: > > On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote: > >> On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote: > >> > Drop Felix from Mediatek Ethernet driver maintainers. > >> > We hav

net: macb: can macb use __napi_schedule_irqoff() instead of __napi_schedule()

2021-01-11 Thread Paul Thomas
Hello, recently I was doing a lot of tracing/profiling to understand an issue we were having. Anyway, during this I ran across __napi_schedule_irqoff() where the comment in dev.c says "Variant of __napi_schedule() assuming hard irqs are masked". It looks like the queue_writel(queue, IDR, bp->rx_in

Re: [PATCH net] i40e: fix potential NULL pointer dereferencing

2021-01-11 Thread Björn Töpel
On 2021-01-11 19:11, Cristian Dumitrescu wrote: Currently, the function i40e_construct_skb_zc only frees the input xdp buffer when the output skb is successfully built. On error, the function i40e_clean_rx_irq_zc does not commit anything for the current packet descriptor and simply exits the pack

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Masahiro Yamada
On Tue, Jan 12, 2021 at 4:34 AM Nathan Chancellor wrote: > > On Tue, Jan 12, 2021 at 04:19:01AM +0900, Masahiro Yamada wrote: > > On Tue, Jan 12, 2021 at 3:06 AM Nathan Chancellor > > wrote: > > > > > > After commit da5fb18225b4 ("bpf: Support pre-2.25-binutils objcopy for > > > vmlinux BTF"), ha

[PATCH] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Atish Patra
There is no usrio config defined for default gem config leading to a kernel panic devices that don't define a data. This issue can be reprdouced with microchip polar fire soc where compatible string is defined as "cdns,macb". Fixes: edac63861db7 ("add userio bits as platform configuration") Signe

Re: [PATCH 2/7] ibmvnic: update reset function prototypes

2021-01-11 Thread Sukadev Bhattiprolu
Jakub Kicinski [k...@kernel.org] wrote: > On Sun, 10 Jan 2021 19:12:21 -0800 Sukadev Bhattiprolu wrote: > > Jakub Kicinski [k...@kernel.org] wrote: > > > On Thu, 7 Jan 2021 23:12:31 -0800 Sukadev Bhattiprolu wrote: > > > > The reset functions need just the 'reset reason' parameter and not > > >

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Nathan Chancellor
On Tue, Jan 12, 2021 at 04:50:50AM +0900, Masahiro Yamada wrote: > On Tue, Jan 12, 2021 at 4:34 AM Nathan Chancellor > wrote: > > > > On Tue, Jan 12, 2021 at 04:19:01AM +0900, Masahiro Yamada wrote: > > > On Tue, Jan 12, 2021 at 3:06 AM Nathan Chancellor > > > wrote: > > > > > > > > After commit

Re: [PATCH bpf-next 1/2] bpf: allow to retrieve sol_socket opts from sock_addr progs

2021-01-11 Thread Yonghong Song
On 1/11/21 8:17 AM, Daniel Borkmann wrote: The _bpf_setsockopt() is able to set some of the SOL_SOCKET level options, however, _bpf_getsockopt() has little support to actually retrieve them. This small patch adds few misc options such as SO_MARK, SO_PRIORITY and SO_BINDTOIFINDEX. For the latte

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Toke Høiland-Jørgensen
Jiri Olsa writes: > The bpf_tracing_prog_attach error path calls bpf_prog_put > on prog, which causes refcount underflow when it's called > from link_create function. > > link_create > prog = bpf_prog_get <-- get > ... > tracing_bpf_link_attach(prog.. > bpf_tracin

Re: [PATCH bpf-next 2/2] bpf: extend bind v4/v6 selftests for mark/prio/bindtoifindex

2021-01-11 Thread Yonghong Song
On 1/11/21 8:17 AM, Daniel Borkmann wrote: Extend existing cgroup bind4/bind6 tests to add coverage for setting and retrieving SO_MARK, SO_PRIORITY and SO_BINDTOIFINDEX at the bind hook. Signed-off-by: Daniel Borkmann Ack with a minor comments below. Acked-by: Yonghong Song --- .../t

Re: [PATCH 5/7] ibmvnic: use a lock to serialize remove/reset

2021-01-11 Thread Sukadev Bhattiprolu
Jakub Kicinski [k...@kernel.org] wrote: > On Sun, 10 Jan 2021 19:52:25 -0800 Sukadev Bhattiprolu wrote: > > Jakub Kicinski [k...@kernel.org] wrote: > > > On Thu, 7 Jan 2021 23:12:34 -0800 Sukadev Bhattiprolu wrote: > > > > Use a separate lock to serialze ibmvnic_reset() and ibmvnic_remove() > >

[PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement. Router Advertisement.

2021-01-11 Thread Praveen Chaudhary
Fix: For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config etc/network/interfaces. But for IPv6, default route can be learned via RA, for which, currently a fixed metric value 1024 is used. Ideally, user should be able to configure metric on default route

[PATCH v0 net-next 0/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-11 Thread Praveen Chaudhary
Allow user to set metric on default route learned via Router Advertisement. Note: RFC 4191 does not say anything for metric for IPv6 default route. Fix: For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config in etc/network/interfaces. But for IPv6, default

Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks

2021-01-11 Thread Rob Herring
On Mon, 28 Dec 2020 15:31:17 -0600, Adam Ford wrote: > The AVB driver assumes there is an external clock, but it could > be driven by an external clock. In order to enable a programmable > clock, it needs to be added to the clocks list and enabled in the > driver. Since there currently only one c

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 11:18 AM Jiri Olsa wrote: > > The bpf_tracing_prog_attach error path calls bpf_prog_put > on prog, which causes refcount underflow when it's called > from link_create function. > > link_create > prog = bpf_prog_get <-- get > ... > tracing_bpf_link

Re: [PATCH] Signed-off-by: giladreti

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 8:06 AM Gilad Reti wrote: > > On Mon, Jan 11, 2021, 17:55 Daniel Borkmann wrote: > > > > Hello Gilad, > > > > On 1/11/21 4:31 PM, giladreti wrote: > > > Added support for pointer to mem register spilling, to allow the verifier > > > to track pointer to valid memory address

Re: [PATCH] wireguard: netlink: add multicast notification for peer changes

2021-01-11 Thread kernel test robot
Hi Linus, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc3 next-20210111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH bpf 2/2] libbpf: allow loading empty BTFs

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 10:13 AM Yonghong Song wrote: > > > > On 1/9/21 11:03 PM, Andrii Nakryiko wrote: > > Empty BTFs do come up (e.g., simple kernel modules with no new types and > > strings, compared to the vmlinux BTF) and there is nothing technically wrong > > with them. So remove unnecessar

Re: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-11 Thread Alexander Duyck
On Wed, Jan 6, 2021 at 7:53 PM Li RongQing wrote: > > The page recycle code, incorrectly, relied on that a page fragment > could not be freed inside xdp_do_redirect(). This assumption leads to > that page fragments that are used by the stack/XDP redirect can be > reused and overwritten. > > To avo

[Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue

2021-01-11 Thread Hongwei Zhang
> > Hi Hongwei, > > The NCSI should run on 3.3V RMII. According your log, you enabled NCSI on > ftgmac100@1e66 which can only support 1.8V I/O voltage. > Did you observe the same error on ftgmac100@1e67 (MAC3) or > ftgmac100@1e69 (MAC4)? > Hi Dylan, Thanks for your review and in

[Aspeed,ncsi-rx, v2 1/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue

2021-01-11 Thread Hongwei Zhang
> > From: Jakub Kicinski > Sent: Monday, December 21, 2020 5:10 PM > To: Hongwei Zhang > > On Mon, 21 Dec 2020 14:40:26 -0500 Hongwei Zhang wrote: > > When FTGMAC100 driver is used on other NCSI Ethernet controllers, few > > When you say NCSI Ethernet controller here you mean the main system

Re: [PATCH bpf-next 2/2] bpf: extend bind v4/v6 selftests for mark/prio/bindtoifindex

2021-01-11 Thread Daniel Borkmann
On 1/11/21 9:15 PM, Yonghong Song wrote: On 1/11/21 8:17 AM, Daniel Borkmann wrote: Extend existing cgroup bind4/bind6 tests to add coverage for setting and retrieving SO_MARK, SO_PRIORITY and SO_BINDTOIFINDEX at the bind hook. Signed-off-by: Daniel Borkmann Ack with a minor comments below.

Re: [PATCH net-next 1/5] skbuff: rename fields of struct napi_alloc_cache to be more intuitive

2021-01-11 Thread Alexander Lobakin
From: Jonathan Lemon Date: Mon, 11 Jan 2021 10:49:45 -0800 > On Mon, Jan 11, 2021 at 06:28:21PM +, Alexander Lobakin wrote: >> skb_cache and skb_count fields are used to store skbuff_heads queued >> for freeing to flush them by bulks, and aren't related to allocation >> path. Give them more o

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Jiri Olsa
On Mon, Jan 11, 2021 at 12:34:48PM -0800, Andrii Nakryiko wrote: > On Mon, Jan 11, 2021 at 11:18 AM Jiri Olsa wrote: > > > > The bpf_tracing_prog_attach error path calls bpf_prog_put > > on prog, which causes refcount underflow when it's called > > from link_create function. > > > > link_create

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 12:00 PM Nathan Chancellor wrote: > > On Tue, Jan 12, 2021 at 04:50:50AM +0900, Masahiro Yamada wrote: > > On Tue, Jan 12, 2021 at 4:34 AM Nathan Chancellor > > wrote: > > > > > > On Tue, Jan 12, 2021 at 04:19:01AM +0900, Masahiro Yamada wrote: > > > > On Tue, Jan 12, 2021

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 1:17 PM Jiri Olsa wrote: > > On Mon, Jan 11, 2021 at 12:34:48PM -0800, Andrii Nakryiko wrote: > > On Mon, Jan 11, 2021 at 11:18 AM Jiri Olsa wrote: > > > > > > The bpf_tracing_prog_attach error path calls bpf_prog_put > > > on prog, which causes refcount underflow when it'

Re: [PATCH v2 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-11 Thread Andrii Nakryiko
On Sun, Jan 10, 2021 at 8:13 PM Yonghong Song wrote: > > > > On 1/8/21 2:09 PM, Andrii Nakryiko wrote: > > Add support for directly accessing kernel module variables from BPF programs > > using special ldimm64 instructions. This functionality builds upon vmlinux > > ksym support, but extends ldimm

Re: [PATCH v2 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 11:00 AM Hao Luo wrote: > > Acked-by: Hao Luo , with a suggestion on adding a comment. > top posting your Ack? :) > On Fri, Jan 8, 2021 at 2:09 PM Andrii Nakryiko wrote: > > > > Add support for directly accessing kernel module variables from BPF programs > > using speci

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread KP Singh
On Mon, Jan 11, 2021 at 7:57 PM Martin KaFai Lau wrote: > > On Fri, Jan 08, 2021 at 03:19:47PM -0800, Song Liu wrote: > > [ ... ] > > > diff --git a/kernel/bpf/bpf_local_storage.c b/kernel/bpf/bpf_local_storage.c > > index dd5aedee99e73..9bd47ad2b26f1 100644 > > --- a/kernel/bpf/bpf_local_storage.

Re: net: macb: can macb use __napi_schedule_irqoff() instead of __napi_schedule()

2021-01-11 Thread Heiner Kallweit
On 11.01.2021 20:45, Paul Thomas wrote: > Hello, recently I was doing a lot of tracing/profiling to understand > an issue we were having. Anyway, during this I ran across > __napi_schedule_irqoff() where the comment in dev.c says "Variant of > __napi_schedule() assuming hard irqs are masked". > >

Re: [PATCH v2 bpf-next 6/7] libbpf: support kernel module ksym externs

2021-01-11 Thread Andrii Nakryiko
On Sun, Jan 10, 2021 at 8:15 PM Yonghong Song wrote: > > > > On 1/8/21 2:09 PM, Andrii Nakryiko wrote: > > Add support for searching for ksym externs not just in vmlinux BTF, but > > across > > all module BTFs, similarly to how it's done for CO-RE relocations. Kernels > > that expose module BTFs

Re: [PATCH v2 bpf-next 6/7] libbpf: support kernel module ksym externs

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 11:00 AM Hao Luo wrote: > > Acked-by: Hao Luo , with a couple of nits. > > On Fri, Jan 8, 2021 at 2:09 PM Andrii Nakryiko wrote: > > > > Add support for searching for ksym externs not just in vmlinux BTF, but > > across > > all module BTFs, similarly to how it's done for

Re: [PATCH v2 bpf-next 7/7] selftests/bpf: test kernel module ksym externs

2021-01-11 Thread Andrii Nakryiko
On Sun, Jan 10, 2021 at 8:18 PM Yonghong Song wrote: > > > > On 1/8/21 2:09 PM, Andrii Nakryiko wrote: > > Add per-CPU variable to bpf_testmod.ko and use those from new selftest to > > validate it works end-to-end. > > > > Signed-off-by: Andrii Nakryiko > > Ack with a nit below. > > Acked-by: Yon

[PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-11 Thread Praveen Chaudhary
For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config etc/network/interfaces. But for IPv6, default route can be learned via RA, for which, currently a fixed metric value 1024 is used. Ideally, user should be able to configure metric on default route for I

[PATCH v0 net-next 0/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-11 Thread Praveen Chaudhary
Allow user to set metric on default route learned via Router Advertisement. Note: RFC 4191 does not say anything for metric for IPv6 default route. Fix: For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config in etc/network/interfaces. But for IPv6, default

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread Martin KaFai Lau
On Mon, Jan 11, 2021 at 10:35:43PM +0100, KP Singh wrote: > On Mon, Jan 11, 2021 at 7:57 PM Martin KaFai Lau wrote: > > > > On Fri, Jan 08, 2021 at 03:19:47PM -0800, Song Liu wrote: > > > > [ ... ] > > > > > diff --git a/kernel/bpf/bpf_local_storage.c > > > b/kernel/bpf/bpf_local_storage.c > > >

Re: [PATCH v6 net-next 07/15] net: remove return value from dev_get_stats

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > After commit 28172739f0a2 ("net: fix 64 bit counters on 32 bit > arches"), > dev_get_stats got an additional argument for storage of statistics. > At > this point, dev_get_stats could return either the passed "s

Re: net: macb: can macb use __napi_schedule_irqoff() instead of __napi_schedule()

2021-01-11 Thread Paul Thomas
On Mon, Jan 11, 2021 at 4:35 PM Heiner Kallweit wrote: > > On 11.01.2021 20:45, Paul Thomas wrote: > > Hello, recently I was doing a lot of tracing/profiling to understand > > an issue we were having. Anyway, during this I ran across > > __napi_schedule_irqoff() where the comment in dev.c says "Va

Re: [PATCH 5/6] ethernet: stmmac: fix wrongly set buffer2 valid when sph unsupport

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:35:37 +0800 Joakim Zhang wrote: > In current driver, buffer2 available only when hardware supports split > header. Wrongly set buffer2 valid in stmmac_rx_refill when refill buffer > address. You can see that desc3 is 0x8100 after initialization, but > turn out to be 0x830

Re: [PATCH v6 net-next 08/15] net: allow ndo_get_stats64 to return an int error code

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Some drivers need to do special tricks to comply with the new policy > of > ndo_get_stats64 being sleepable. For example, the bonding driver, > which > derives its stats from its lower interfaces, must recurse w

Re: [PATCH 1/2] dt-bindings: net: bluetooth: Add rtl8723ds-bluetooth

2021-01-11 Thread Rob Herring
On Sat, 02 Jan 2021 22:38:03 +0100, John-Eric Kamps wrote: > Add binding documentation for bluetooth part of RTL8723DS > > Signed-off-by: John-Eric Kamps > --- > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Acked-by

Re: [PATCH bpf] bpf: don't leak memory in bpf getsockopt when optlen == 0

2021-01-11 Thread Martin KaFai Lau
On Mon, Jan 11, 2021 at 11:47:38AM -0800, Stanislav Fomichev wrote: > optlen == 0 indicates that the kernel should ignore BPF buffer > and use the original one from the user. We, however, forget > to free the temporary buffer that we've allocated for BPF. > > Reported-by: Martin KaFai Lau > Fixes

Re: [PATCH net-next] net: phy: at803x: use phy_modify_mmd()

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 17:51:30 +0100 Andrew Lunn wrote: > On Sun, Jan 10, 2021 at 02:54:36PM +, Russell King wrote: > > Convert at803x_clk_out_config() to use phy_modify_mmd(). > > > > Signed-off-by: Russell King > > Reviewed-by: Andrew Lunn Applied, thanks!

Re: [PATCH net] net: dsa: unbind all switches from tree when DSA master unbinds

2021-01-11 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 03:40:46PM -0800, Florian Fainelli wrote: > == > [ 61.359856] BUG: KASAN: use-after-free in devlink_nl_port_fill+0x578/0x7a8 > [ 61.366847] Read of size 4 at addr c7cf00a8 by task sh/249 > [ 61.372413] > [

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-11 Thread Marcelo Ricardo Leitner
On Sun, Jan 10, 2021 at 09:52:55AM +0200, Roi Dayan wrote: > > > On 2021-01-10 9:45 AM, Roi Dayan wrote: > > > > > > On 2021-01-08 11:48 PM, Marcelo Ricardo Leitner wrote: > > > Hi, > > > > > > On Thu, Jan 07, 2021 at 09:30:47PM -0800, Saeed Mahameed wrote: > > > > From: Roi Dayan > > > > >

Re: [PATCH v6 net-next 03/15] net: procfs: hold netif_lists_lock when retrieving device statistics

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > In the effort of making .ndo_get_stats64 be able to sleep, we need to > ensure the callers of dev_get_stats do not use atomic context. > > The /proc/net/dev file uses an RCU read-side critical section to > ensu

Re: [PATCH net-next v2 06/11] selftests: Use separate stdout and stderr buffers in nettest

2021-01-11 Thread Jakub Kicinski
On Sat, 9 Jan 2021 17:18:47 -0700 David Ahern wrote: > From: David Ahern > > When a single instance of nettest is doing both client and > server modes, stdout and stderr messages can get interlaced > and become unreadable. Allocate a new set of buffers for the > child process handling server mod

Re: KMSAN: kernel-infoleak in move_addr_to_user (4)

2021-01-11 Thread Cong Wang
On Mon, Jan 11, 2021 at 11:33 AM Jakub Kicinski wrote: > > Looks like a AF_CAN socket: > > r0 = socket(0x1d, 0x2, 0x6) > getsockname$packet(r0, &(0x7f000100)={0x11, 0x0, 0x0, 0x1, 0x0, 0x6, > @broadcast}, &(0x7f00)=0x14) > Right, it seems we need a memset(0) in isotp_getname(). Than

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Vincent MAILHOL
On Tue. 12 Jan 2021 at 02:11, Richard Cochran wrote: > > On Sun, Jan 10, 2021 at 09:49:03PM +0900, Vincent Mailhol wrote: > > * The hardware rx timestamp of a local loopback message is the > > hardware tx timestamp. This means that there are no needs to > > implement SOF_TIMESTAMPING_TX_

Re: [PATCH v6 net-next 11/15] net: catch errors from dev_get_stats

2021-01-11 Thread Saeed Mahameed
On Tue, 2021-01-12 at 01:15 +0200, Vladimir Oltean wrote: > On Mon, Jan 11, 2021 at 02:54:50PM -0800, Saeed Mahameed wrote: > > On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > dev_get_stats can now return error codes. Convert all remaining > > > c

Re: [PATCH v4 net-next 00/11] Get rid of the switchdev transactional model

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 9 Jan 2021 02:01:45 +0200 you wrote: > From: Vladimir Oltean > > Changes in v4: > - Fixed build error in dsa_loop and build warning in hellcreek driver. > - Scheduling the mlxsw SPAN work item regardless of the

Re: [PATCH net-next] net: sfp: extend bitrate-derived mode for 2500BASE-X

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 17:49:54 +0100 Andrew Lunn wrote: > On Sun, Jan 10, 2021 at 10:58:37AM +, Russell King wrote: > > Extend the bitrate-derived support to include 2500BASE-X for modules > > that report a bitrate of 2500Mbaud. > > > > Signed-off-by: Russell King > > Reviewed-by: Andrew Lun

Re: [PATCH net-next] net: sfp: cope with SFPs that set both LOS normal and LOS inverted

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 17:48:15 +0100 Andrew Lunn wrote: > On Sun, Jan 10, 2021 at 10:58:32AM +, Russell King wrote: > > The SFP MSA defines two option bits in byte 65 to indicate how the > > Rx_LOS signal on SFP pin 8 behaves: > > > > bit 2 - Loss of Signal implemented, signal inverted from stan

Re: [PATCH net-next] net: dsa: felix: the switch does not support DMA

2021-01-11 Thread Jakub Kicinski
On Sat, 9 Jan 2021 17:24:39 -0800 Florian Fainelli wrote: > On 1/9/2021 12:34 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > The code that sets the DMA mask to 64 bits is bogus, it is taken from > > the enetc driver together with the rest of the PCI probing boilerplate. > > > > Sin

Re: [PATCH net-next v2 06/11] selftests: Use separate stdout and stderr buffers in nettest

2021-01-11 Thread David Ahern
On 1/11/21 5:15 PM, Jakub Kicinski wrote: >> diff --git a/tools/testing/selftests/net/nettest.c >> b/tools/testing/selftests/net/nettest.c >> index 0e4196027d63..13c74774e357 100644 >> --- a/tools/testing/selftests/net/nettest.c >> +++ b/tools/testing/selftests/net/nettest.c >> @@ -1705,9 +1705,27

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 1:58 PM, Martin Lau wrote: > > On Mon, Jan 11, 2021 at 10:35:43PM +0100, KP Singh wrote: >> On Mon, Jan 11, 2021 at 7:57 PM Martin KaFai Lau wrote: >>> >>> On Fri, Jan 08, 2021 at 03:19:47PM -0800, Song Liu wrote: >>> >>> [ ... ] >>> diff --git a/kernel/bpf/bpf_l

Re: [PATCH v2 net-next] r8169: deprecate support for RTL_GIGA_MAC_VER_27

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 10 Jan 2021 13:17:52 +0100 you wrote: > RTL8168dp is ancient anyway, and I haven't seen any trace of its early > version 27 yet. This chip versions needs quite some special handling, > therefore it would facilitate

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Mon, 11 Jan 2021 20:16:50 +0100 you wrote: > The bpf_tracing_prog_attach error path calls bpf_prog_put > on prog, which causes refcount underflow when it's called > from link_create function. > > link_create > prog = bpf_

Re: [PATCH v6 net-next 14/15] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > There is an effort to convert .ndo_get_stats64 to sleepable context, > and > for that to work, we need to prevent callers of dev_get_stats from > using > atomic locking. > > The bonding driver retrieves its sta

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 10:56 AM, Martin Lau wrote: > > On Fri, Jan 08, 2021 at 03:19:47PM -0800, Song Liu wrote: > > [ ... ] > >> diff --git a/kernel/bpf/bpf_local_storage.c b/kernel/bpf/bpf_local_storage.c >> index dd5aedee99e73..9bd47ad2b26f1 100644 >> --- a/kernel/bpf/bpf_local_storage.c >

Re: [PATCH v1 net] dt-bindings: net: dwmac: fix queue priority documentation

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 11 Jan 2021 09:14:07 +0100 you wrote: > From: Seb Laveze > > The priority field is not the queue priority (queue priority is fixed) > but a bitmask of priorities assigned to this queue. > > In receive, priorities rela

Re: [PATCH] Revert "tcp: simplify window probe aborting on USER_TIMEOUT"

2021-01-11 Thread Enke Chen
Hi, Neal: Thank you for testing the reverted patch, and provding the detailed analysis of the underline issue with the original patch. Let me go back to the simple and clean approach using a separate counter, as we were discussing before. -- Enke On Mon, Jan 11, 2021 at 09:58:33AM -0500, Neal C

Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 13:58:29 -0800 Praveen Chaudhary wrote: > For IPv4, default route is learned via DHCPv4 and user is allowed to change > metric using config etc/network/interfaces. But for IPv6, default route can > be learned via RA, for which, currently a fixed metric value 1024 is used. > > I

Re: [PATCH v6 net-next 11/15] net: catch errors from dev_get_stats

2021-01-11 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 02:54:50PM -0800, Saeed Mahameed wrote: > On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > dev_get_stats can now return error codes. Convert all remaining call > > sites to look at that error code and stop processing. > > > > The e

Re: [PATCH net] net: dsa: unbind all switches from tree when DSA master unbinds

2021-01-11 Thread Florian Fainelli
On 1/11/21 3:09 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently the following happens when a DSA master driver unbinds while > there are DSA switches attached to it: > > $ echo :00:00.5 > /sys/bus/pci/drivers/mscc_felix/unbind > [ cut here ] > WARNING

Re: [PATCH] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > There is no usrio config defined for default gem config leading to > a kernel panic devices that don't define a data. This issue can be > reprdouced with microchip polar fire soc where compatible string > is defined as "cdns,macb". > > Fixes:

Re: [PATCH bpf] bpf: don't leak memory in bpf getsockopt when optlen == 0

2021-01-11 Thread Martin KaFai Lau
On Mon, Jan 11, 2021 at 02:38:02PM -0800, Stanislav Fomichev wrote: > On Mon, Jan 11, 2021 at 2:32 PM Martin KaFai Lau wrote: > > > > On Mon, Jan 11, 2021 at 11:47:38AM -0800, Stanislav Fomichev wrote: > > > optlen == 0 indicates that the kernel should ignore BPF buffer > > > and use the original

[PATCH net] net: dsa: unbind all switches from tree when DSA master unbinds

2021-01-11 Thread Vladimir Oltean
From: Vladimir Oltean Currently the following happens when a DSA master driver unbinds while there are DSA switches attached to it: $ echo :00:00.5 > /sys/bus/pci/drivers/mscc_felix/unbind [ cut here ] WARNING: CPU: 0 PID: 392 at net/core/dev.c:9507 Call trace: rollb

[PATCH bpf-next v2 2/2] bpf: extend bind v4/v6 selftests for mark/prio/bindtoifindex

2021-01-11 Thread Daniel Borkmann
Extend existing cgroup bind4/bind6 tests to add coverage for setting and retrieving SO_MARK, SO_PRIORITY and SO_BINDTOIFINDEX at the bind hook. Signed-off-by: Daniel Borkmann Acked-by: Yonghong Song --- v1 -> v2: - Add comment on old vs new optval (Yonghong), rest as-is .../testing/selftests/

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 2:14 AM, KP Singh wrote: > > On Sat, Jan 9, 2021 at 12:35 AM Song Liu wrote: >> >> To access per-task data, BPF program typically creates a hash table with >> pid as the key. This is not ideal because: >> 1. The use need to estimate requires size of the hash table, with

[PATCH bpf-next v2 1/2] bpf: allow to retrieve sol_socket opts from sock_addr progs

2021-01-11 Thread Daniel Borkmann
The _bpf_setsockopt() is able to set some of the SOL_SOCKET level options, however, _bpf_getsockopt() has little support to actually retrieve them. This small patch adds few misc options such as SO_MARK, SO_PRIORITY and SO_BINDTOIFINDEX. For the latter getter and setter are added. The mark and prio

[PATCH net-next 0/4] Fix receive window restriction

2021-01-11 Thread Heath Caldwell
This patch series addresses bugs in the calculations for receive buffer restriction and the TCP window scale value and removes a limit on the initially advertised receive window for TCP connections. These changes make the receive buffer size and window scale calculations more consistent and facili

[PATCH net-next 1/4] net: account for overhead when restricting SO_RCVBUF

2021-01-11 Thread Heath Caldwell
When restricting the value supplied for SO_RCVBUF to be no greater than what is specified by sysctl_rmem_max, properly cap the value to the *available* space that sysctl_rmem_max would provide, rather than to the raw value of sysctl_rmem_max. Without this change, it is possible to cause sk_rcvbuf

[PATCH net-next 2/4] net: tcp: consistently account for overhead for SO_RCVBUF for TCP

2021-01-11 Thread Heath Caldwell
When setting SO_RCVBUF for TCP sockets, account for overhead in accord with sysctl_tcp_adv_win_scale. This makes the receive buffer overhead accounting for SO_RCVBUF consistent with how it is accounted elsewhere for TCP sockets. Signed-off-by: Heath Caldwell --- include/net/tcp.h | 17 +

[PATCH net-next 4/4] tcp: remove limit on initial receive window

2021-01-11 Thread Heath Caldwell
Remove the 64KB limit imposed on the initial receive window. The limit was added by commit a337531b942b ("tcp: up initial rmem to 128KB and SYN rwin to around 64KB"). This change removes that limit so that the initial receive window can be arbitrarily large (within existing limits and depending o

Re: [PATCH bpf-next 4/4] bpf: runqslower: use task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:49 AM, Yonghong Song wrote: > > > > On 1/8/21 3:19 PM, Song Liu wrote: >> Replace hashtab with task local storage in runqslower. This improves the >> performance of these BPF programs. The following table summarizes average >> runtime of these programs, in nanoseconds

Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:30 AM, Yonghong Song wrote: > > > > On 1/8/21 3:19 PM, Song Liu wrote: >> Task local storage is enabled for tracing programs. Add a test for it >> without CONFIG_BPF_LSM. >> Signed-off-by: Song Liu >> --- >> .../bpf/prog_tests/test_task_local_storage.c | 34 +++

Re: [PATCH v6 net-next 11/15] net: catch errors from dev_get_stats

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > dev_get_stats can now return error codes. Convert all remaining call > sites to look at that error code and stop processing. > > The effects of simulating a kernel error (returning -ENOMEM) upon > existing prog

[PATCH net-next 3/4] tcp: consistently account for overhead in rcv_wscale calculation

2021-01-11 Thread Heath Caldwell
When calculating the window scale to use for the advertised window for a TCP connection, adjust the size values used to extend the maximum possible window value so that overhead is properly accounted. In other words: convert the maximum value candidates from buffer size space into advertised windo

Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:44 AM, KP Singh wrote: > > On Mon, Jan 11, 2021 at 6:31 PM Yonghong Song wrote: >> >> >> >> On 1/8/21 3:19 PM, Song Liu wrote: >>> Task local storage is enabled for tracing programs. Add a test for it >>> without CONFIG_BPF_LSM. > > Can you also explain what the te

Re: [PATCH v6 net-next 08/15] net: allow ndo_get_stats64 to return an int error code

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Some drivers need to do special tricks to comply with the new policy > of > ndo_get_stats64 being sleepable. For example, the bonding driver, > which > derives its stats from its lower interfaces, must recurse w

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > From: Stefan Chulski > > Packet Processor hardware not connected to MAC flow control unit and > cannot support TX flow control. > This patch disable flow control support. > > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvel

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Andrew Lunn
On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote: > On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > > From: Stefan Chulski > > > > Packet Processor hardware not connected to MAC flow control unit and > > cannot support TX flow control. > > This patch disable flow con

[PATCH net] net: dsa: clear devlink port type before unregistering slave netdevs

2021-01-11 Thread Vladimir Oltean
From: Vladimir Oltean Florian reported a use-after-free bug in devlink_nl_port_fill found with KASAN: (devlink_nl_port_fill) (devlink_port_notify) (devlink_port_unregister) (dsa_switch_teardown.part.3) (dsa_tree_teardown_switches) (dsa_unregister_switch) (bcm_sf2_sw_remove) (platform_remove) (de

Re: [PATCH net-next] net: marvell: prestera: Correct typo

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 21:06:22 -0800 you wrote: > The function was incorrectly named with a trailing 'r' at the end of > prestera. > > Signed-off-by: Florian Fainelli > --- > Jakub, David, > > [...] Here is the summary wi

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Jakub Kicinski
On Tue, 12 Jan 2021 01:47:27 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote: > > On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > > > From: Stefan Chulski > > > > > > Packet Processor hardware not connected to MAC flow control unit and >

Re: [PATCH net-next 0/2] r8169: improve jumbo configuration

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 9 Jan 2021 22:59:08 +0100 you wrote: > Small improvements to jumbo configuration. > > Heiner Kallweit (2): > r8169: align RTL8168e jumbo pcie read request size with vendor driver > r8169: tweak max read reques

Re: [PATCH net-next] r8169: make use of the unaligned access helpers

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 9 Jan 2021 23:53:26 +0100 you wrote: > Instead of open-coding unaligned access let's use the predefined > unaligned access helpers. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169_ma

Re: [PATCH bpf 2/2] libbpf: allow loading empty BTFs

2021-01-11 Thread Yonghong Song
On 1/11/21 12:51 PM, Andrii Nakryiko wrote: On Mon, Jan 11, 2021 at 10:13 AM Yonghong Song wrote: On 1/9/21 11:03 PM, Andrii Nakryiko wrote: Empty BTFs do come up (e.g., simple kernel modules with no new types and strings, compared to the vmlinux BTF) and there is nothing technically wro

Re: [PATCH net-next] net: bareudp: simplify error paths calling dellink

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 10 Jan 2021 21:29:22 -0800 you wrote: > bareudp_dellink() only needs the device list to hand it to > unregister_netdevice_queue(). We can pass NULL in, and > unregister_netdevice_queue() will do the unregistering. >

Re: [PATCH net-next 0/3] r8169: improve PLL power-down handling

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 10 Jan 2021 20:46:58 +0100 you wrote: > This series includes improvements to handling of PLL power-down. > > Heiner Kallweit (3): > r8169: enable PLL power-down for chip versions 34, 35, 36, 42 > r8169: improv

[no subject]

2021-01-11 Thread Mrs.Isabella .Helmreich
-- Não sei se você vê minha mensagem?

Re: [PATCH v2 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-11 Thread Yonghong Song
On 1/11/21 1:29 PM, Andrii Nakryiko wrote: On Sun, Jan 10, 2021 at 8:13 PM Yonghong Song wrote: On 1/8/21 2:09 PM, Andrii Nakryiko wrote: Add support for directly accessing kernel module variables from BPF programs using special ldimm64 instructions. This functionality builds upon vmlinu

Re: [PATCH] Fix whitespace in uapi/linux/tcp.h.

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 22:21:04 + you wrote: > From: Danilo Carvalho > > List of things fixed: > - Two of the socket options were idented with spaces instead of tabs. > - Trailing whitespace in some lines. > - Impr

Re: [PATCH v2 bpf-next 6/7] libbpf: support kernel module ksym externs

2021-01-11 Thread Yonghong Song
On 1/11/21 1:37 PM, Andrii Nakryiko wrote: On Sun, Jan 10, 2021 at 8:15 PM Yonghong Song wrote: On 1/8/21 2:09 PM, Andrii Nakryiko wrote: Add support for searching for ksym externs not just in vmlinux BTF, but across all module BTFs, similarly to how it's done for CO-RE relocations. Kern

RE: [PATCH 4/6] ethernet: stmmac: fix dma physical address of descriptor when display ring

2021-01-11 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年1月12日 1:30 > To: Joakim Zhang ; peppe.cavall...@st.com; > alexandre.tor...@st.com; joab...@synopsys.com; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH 4/6] ethernet: stmma

[PATCH net v2] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Atish Patra
There is no usrio config defined for default gem config leading to a kernel panic devices that don't define a data. This issue can be reprdouced with microchip polar fire soc where compatible string is defined as "cdns,macb". Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem

Re: [PATCH] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Atish Patra
On Mon, 2021-01-11 at 15:13 -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > > There is no usrio config defined for default gem config leading to > > a kernel panic devices that don't define a data. This issue can be > > reprdouced with microchip polar fire soc

<    1   2   3   4   >