Re: mlx5 error when the skb linear space is empty

2021-01-11 Thread Magnus Karlsson
On Tue, Jan 5, 2021 at 9:51 PM Saeed Mahameed wrote: > > On Mon, 2021-01-04 at 18:59 +0800, Xuan Zhuo wrote: > > hi > > > > In the process of developing xdp socket, we tried to directly use > > page to > > construct skb directly, to avoid data copy. And the MAC information > > is also in > > the p

Re: [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation

2021-01-11 Thread Sebastien Laveze
On Sat, 2021-01-09 at 19:16 -0800, Jakub Kicinski wrote: > Hi Sebastien, looks like this no longer applies to net could you > rebase? Hi Jakub, Sure, no problem.

Re: [PATCH] mt76: Fix queue ID variable types after mcu queue split

2021-01-11 Thread Kalle Valo
Lorenzo Bianconi writes: >> Clang warns in both mt7615 and mt7915: >> >> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:271:9: warning: implicit >> conversion from enumeration type 'enum mt76_mcuq_id' to different >> enumeration type 'enum mt76_txq_id' [-Wenum-conversion] >> txq

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Marc Kleine-Budde
On 1/10/21 1:49 PM, Vincent Mailhol wrote: > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > tx timestamp gets attached on the skb. > > There two main reasons to include this call in can_put_echo_skb(): > > * It easily allow to enable the tx timestamp on all devices with

Re: [PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set

2021-01-11 Thread Holger Assmann
On Thu, 17.12.20 um 02:13 Jakub Kicinski wrote: Thanks for the patch, minor nits below. Thanks for the Feedback! I will work it in for my v2. + + if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)) !a && !b reads better IMHO We've chosen this variant because it is already

[PATCH v1 net] dt-bindings: net: dwmac: fix queue priority documentation

2021-01-11 Thread Sebastien Laveze
From: Seb Laveze The priority field is not the queue priority (queue priority is fixed) but a bitmask of priorities assigned to this queue. In receive, priorities relate to tagged frames priorities. In transmit, priorities relate to PFC frames. Signed-off-by: Seb Laveze --- Documentation/dev

[QUESTION] build errors and warnings when make M=samples/bpf

2021-01-11 Thread Tiezhu Yang
Hi all, I found the following build errors and warnings when make M=samples/bpf on the Loongson 3A3000 platform which belongs to MIPS arch. Are theseknown issues? Should I submit patches to fix them? (1) fatal error: 'asm/rwonce.h' file not found CLANG-bpf samples/bpf/xdpsock_kern.o In file i

Re: [PATCH ipsec-next] xfrm: interface: enable TSO on xfrm interfaces

2021-01-11 Thread Steffen Klassert
On Wed, Jan 06, 2021 at 08:10:46AM +0200, Eyal Birger wrote: > Underlying xfrm output supports gso packets. > Declare support in hw_features and adapt the xmit MTU check to pass GSO > packets. > > Signed-off-by: Eyal Birger Applied, thanks a lot Eyal!

Re: [PATCH net v2 3/3] esp: avoid unneeded kmap_atomic call

2021-01-11 Thread Steffen Klassert
On Sat, Jan 09, 2021 at 05:18:34PM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > esp(6)_output_head uses skb_page_frag_refill to allocate a buffer for > the esp trailer. > > It accesses the page with kmap_atomic to handle highmem. But > skb_page_frag_refill can return compound page

Re: [RFC PATCH net] udp: check sk for UDP GRO fraglist

2021-01-11 Thread Steffen Klassert
On Mon, Jan 11, 2021 at 11:02:42AM +0900, Dongseok Yi wrote: > On 2021-01-08 22:35, Steffen Klassert wrote: > > On Fri, Jan 08, 2021 at 09:52:28PM +0900, Dongseok Yi wrote: > > > It is a workaround patch. > > > > > > UDP/IP header of UDP GROed frag_skbs are not updated even after NAT > > > forwardi

[PATCH] net: phy: smsc: fix clk error handling

2021-01-11 Thread Marco Felsch
Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") added the phy clk support. The commit already checks if clk_get_optional() throw an error but instead of returning the error it ignores it. Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") Su

[PATCH net-next] fsl/fman: Add MII mode support.

2021-01-11 Thread Maxim Kochetkov
Set proper value to IF_MODE register for MII mode. Signed-off-by: Maxim Kochetkov --- drivers/net/ethernet/freescale/fman/fman_memac.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c inde

[PATCH] rtw88: debug: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING: Comparison of 0/1 to bool variable Signed-off-by: YANG LI Reported-by: Abaci Robot --- drivers/net/wireless/realtek/rtw88/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH] hci: llc_shdlc: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./net/nfc/hci/llc_shdlc.c:239:5-21: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot --- net/nfc/hci/llc_shdlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c

[PATCH net 0/2] bnxt_en: Bug fixes.

2021-01-11 Thread Michael Chan
This series has 2 fixes. The first one fixes a resource accounting error with the RDMA driver loaded and the second one fixes the firmware flashing sequence after defragmentation. Please queue the 1st one for -stable. Thanks. Michael Chan (1): bnxt_en: Improve stats context resource accountin

[PATCH net 2/2] bnxt_en: Clear DEFRAG flag in firmware message when retry flashing.

2021-01-11 Thread Michael Chan
From: Pavan Chebbi When the FW tells the driver to retry the INSTALL_UPDATE command after it has cleared the NVM area, the driver is not clearing the previously used ALLOWED_TO_DEFRAG flag. As a result the FW tries to defrag the NVM area a second time in a loop and can fail the request. Fixes: 1

[PATCH net 1/2] bnxt_en: Improve stats context resource accounting with RDMA driver loaded.

2021-01-11 Thread Michael Chan
The function bnxt_get_ulp_stat_ctxs() does not count the stats contexts used by the RDMA driver correctly when the RDMA driver is freeing the MSIX vectors. It assumes that if the RDMA driver is registered, the additional stats contexts will be needed. This is not true when the RDMA driver is abou

[PATCH] scsi: qedf: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drive

RE: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison

2021-01-11 Thread Saurav Kashyap
Hi, Thanks for a patch. > -Original Message- > From: YANG LI > Sent: Monday, January 11, 2021 2:59 PM > To: j...@linux.ibm.com > Cc: martin.peter...@oracle.com; Saurav Kashyap ; > Javed Hasan ; GR-QLogic-Storage-Upstream qlogic-storage-upstr...@marvell.com>; li...@armlinux.org.uk; linux-

[PATCH net-next v2 1/2] net: vlan: Add parse protocol header ops

2021-01-11 Thread Eran Ben Elisha
Add parse protocol header ops for vlan device. Before this patch, vlan tagged packet transmitted by af_packet had skb->protocol unset. Some kernel methods (like __skb_flow_dissect()) rely on this missing information for its packet processing. Signed-off-by: Eran Ben Elisha Reviewed-by: Tariq Touk

[PATCH net-next v2 0/2] Dissect PTP L2 packet header

2021-01-11 Thread Eran Ben Elisha
Hi Jakub, Dave, This series adds support for dissecting PTP L2 packet header (EtherType 0x88F7). For packet header dissecting, skb->protocol is needed. Add protocol parsing operation to vlan ops, to guarantee skb->protocol is set, as EtherType 0x88F7 occasionally follows a vlan header. Changelog

[PATCH net-next v2 2/2] net: flow_dissector: Parse PTP L2 packet header

2021-01-11 Thread Eran Ben Elisha
Add support for parsing PTP L2 packet header. Such packet consists of an L2 header (with ethertype of ETH_P_1588), PTP header, body and an optional suffix. Signed-off-by: Eran Ben Elisha Reviewed-by: Tariq Toukan --- net/core/flow_dissector.c | 16 1 file changed, 16 insertions

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-11 Thread Sebastian A. Siewior
On 2020-12-22 10:03:37 [+0100], Ahmed S. Darwish wrote: > 2) arcnet_close() contains a del_timer_sync(). If the irq handler > interrupts the to-be-deleted timer then call del_timer_sync(), it > will just loop forever. del_timer_sync() will trigger a warning if invoked from interrupt ha

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread KP Singh
On Sat, Jan 9, 2021 at 12:35 AM Song Liu wrote: > > To access per-task data, BPF program typically creates a hash table with > pid as the key. This is not ideal because: > 1. The use need to estimate requires size of the hash table, with may be > inaccurate; > 2. Big hash tables are slow; >

Re: [patch 02/30] genirq: Move status flag checks to core

2021-01-11 Thread Thomas Gleixner
On Sun, Dec 27 2020 at 11:20, Guenter Roeck wrote: > On Thu, Dec 10, 2020 at 08:25:38PM +0100, Thomas Gleixner wrote: > Yes, but that means that irq_check_status_bit() may be called from modules, > but it is not exported, resulting in build errors such as the following. > > arm64:allmodconfig: > >

Re: [PATCH net-next 2/2] virtio_net: Implement XDP_FLAGS_NO_TX support

2021-01-11 Thread Shay Agroskin
Charlie Somerville writes: On Mon, Jan 11, 2021, at 04:31, Shay Agroskin wrote: Is this addition needed ? Seems like we don't set VIRTIO_XDP_TX bit in case of virtnet_xdp_xmit() failure, so the surrounding 'if' won't be taken. Good catch, it looks like you're right. I'm happy to remove

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread KP Singh
On Mon, Jan 11, 2021 at 7:27 AM Yonghong Song wrote: > > > > On 1/8/21 3:19 PM, Song Liu wrote: > > To access per-task data, BPF program typically creates a hash table with > > pid as the key. This is not ideal because: > > 1. The use need to estimate requires size of the hash table, with may be

KASAN: use-after-free Read in hci_dev_do_open

2021-01-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:71c061d2 Merge tag 'for-5.11-rc2-tag' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1612b248d0 kernel config: https://syzkaller.appspot.com/x/.config?x=8aa30b9da402d224 das

Re: [PATCH net v3] ppp: fix refcount underflow on channel unbridge

2021-01-11 Thread Tom Parkin
On Fri, Jan 08, 2021 at 21:57:50 +0100, Guillaume Nault wrote: > On Thu, Jan 07, 2021 at 06:13:15PM +, Tom Parkin wrote: > > When setting up a channel bridge, ppp_bridge_channels sets the > > pch->bridge field before taking the associated reference on the bridge > > file instance. > > > > Thi

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-11 Thread Oleksij Rempel
On Sat, Jan 09, 2021 at 02:21:43AM +0200, Vladimir Oltean wrote: > On Fri, Jan 08, 2021 at 06:32:28AM +0100, Oleksij Rempel wrote: > > May be the "net: dsa: add optional stats64 support" can already be > > taken? > > I'm not sure that I see the point. David and Jakub won't cherry-pick > partial se

Re: [RFC PATCH 2/3] chelsio: cxgb: Move slow interrupt handling to threaded irqs

2021-01-11 Thread Sebastian A. Siewior
On 2020-12-24 14:11:47 [+0100], Ahmed S. Darwish wrote: > --- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c > +++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c > @@ -211,9 +211,9 @@ static int cxgb_up(struct adapter *adapter) > t1_interrupts_clear(adapter); > > adapter->params.has_msi = !

[PATCH net-next] net: core: use eth_type_vlan in __netif_receive_skb_core

2021-01-11 Thread menglong8 . dong
From: Menglong Dong Replace the check for ETH_P_8021Q and ETH_P_8021AD in __netif_receive_skb_core with eth_type_vlan. Signed-off-by: Menglong Dong --- net/core/dev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index e4d77c8abe76..2

[PATCH net-next v8 0/2] net: dsa: add stats64 support

2021-01-11 Thread Oleksij Rempel
changes v8: - stats.no_handler should not be assigned from HW stats changes v7: - move raw.filtered from rx_errors to rx_dropped counter changes v6: - move stats64 callback to ethtool section - ar9331: diff. fixes - ar9331: move stats calculation to the worker - ar9331: extend rx/tx error counte

[PATCH net-next v8 1/2] net: dsa: add optional stats64 support

2021-01-11 Thread Oleksij Rempel
Allow DSA drivers to export stats64 Signed-off-by: Oleksij Rempel Reviewed-by: Vladimir Oltean --- include/net/dsa.h | 4 +++- net/dsa/slave.c | 14 +- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index 4e60d2610f20..c50abb

[PATCH net-next v8 2/2] net: dsa: qca: ar9331: export stats64

2021-01-11 Thread Oleksij Rempel
Add stats support for the ar9331 switch. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/qca/ar9331.c | 163 ++- 1 file changed, 162 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index 4d49c5f2b790..1e3706

Re: [PATCH v5 net-next 11/16] net: propagate errors from dev_get_stats

2021-01-11 Thread Dan Carpenter
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Make-ndo_get_stats64-sleepable/20210109-003617 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [PATCH iproute2] tc: flower: fix json output with mpls lse

2021-01-11 Thread Guillaume Nault
On Thu, Jan 07, 2021 at 10:39:03AM -0700, David Ahern wrote: > On 1/7/21 10:13 AM, Jakub Kicinski wrote: > > On Thu, 7 Jan 2021 17:48:56 +0100 Guillaume Nault wrote: > >> On Fri, Dec 18, 2020 at 11:25:32PM +0100, Guillaume Nault wrote: > >>> The json output of the TCA_FLOWER_KEY_MPLS_OPTS attribute

Re: [PATCH v5 net-next 11/16] net: propagate errors from dev_get_stats

2021-01-11 Thread Vladimir Oltean
Hi Dan, On Mon, Jan 11, 2021 at 01:55:16PM +0300, Dan Carpenter wrote: > Hi Vladimir, > > New smatch warnings: > net/core/rtnetlink.c:1821 rtnl_fill_ifinfo() warn: missing error code 'err' > > vim +/err +1821 net/core/rtnetlink.c > > static int rtnl_fill_ifinfo(struct sk_buff *skb, >

Re: [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support

2021-01-11 Thread Russell King - ARM Linux admin
On Mon, Jan 11, 2021 at 01:44:28PM +0800, DENG Qingfang wrote: > +static int > +mt7530_gpio_direction_output(struct gpio_chip *gc, unsigned int offset, int > value) > +{ > + struct mt7530_priv *priv = gpiochip_get_data(gc); > + u32 bit = mt7530_gpio_to_bit(offset); > + > + mt7530_set(p

Re: [PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-11 Thread Toke Høiland-Jørgensen
Charlie Somerville writes: > This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents > the allocation of additional send queues for XDP programs. > > Included in this patch series is an implementation of XDP_FLAGS_NO_TX > for the virtio_net driver. This flag is intended to be advis

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Marcin Wojtas
niedz., 10 sty 2021 o 20:25 napisał(a): > > From: Stefan Chulski > > Packet Processor hardware not connected to MAC flow control unit and > cannot support TX flow control. > This patch disable flow control support. > > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network

[PATCH] octeontx2-pf: Add flow classification using IP next level protocol

2021-01-11 Thread Naveen Mamindlapalli
This patch adds support to install flow rules using ipv4 proto or ipv6 next header field to distinguish between tcp/udp/sctp/esp/ah flows when user doesn't specify the other match creteria related to the flow such as tcp/udp/sctp source port and destination port, ah/esp spi value. This is achieved

[PATCH 0/6] ethernet: fixes for stmmac driver

2021-01-11 Thread Joakim Zhang
Fixes for stmmac driver. Joakim Zhang (6): ethernet: stmmac: remove redundant null check for ptp clock ethernet: stmmac: stop each tx channal independently ethernet: stmmac: fix watchdog timeout during suspend/resume stress test ethernet: stmmac: fix dma physical address of descriptor

[PATCH 4/6] ethernet: stmmac: fix dma physical address of descriptor when display ring

2021-01-11 Thread Joakim Zhang
Driver uses dma_alloc_coherent to allocate dma memory for descriptors, dma_alloc_coherent will return both the virtual address and physical address. AFAIK, virt_to_phys could not convert virtual address to physical address, for which memory is allocated by dma_alloc_coherent. Signed-off-by: Joakim

[PATCH 2/6] ethernet: stmmac: stop each tx channal independently

2021-01-11 Thread Joakim Zhang
If clear GMAC_CONFIG_TE bit, it would stop all tx channals, but users may only want to stop secific tx channel. Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 4 1 file changed, 4 deletions(-)

[PATCH 1/6] ethernet: stmmac: remove redundant null check for ptp clock

2021-01-11 Thread Joakim Zhang
Remove redundant null check for ptp clock. Fixes: 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before clk_disable_unprepare()") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driv

[PATCH 5/6] ethernet: stmmac: fix wrongly set buffer2 valid when sph unsupport

2021-01-11 Thread Joakim Zhang
In current driver, buffer2 available only when hardware supports split header. Wrongly set buffer2 valid in stmmac_rx_refill when refill buffer address. You can see that desc3 is 0x8100 after initialization, but turn out to be 0x8300 after refill. Fixes: 67afd6d1cfdf ("net: stmmac: Add Spl

[PATCH 3/6] ethernet: stmmac: fix watchdog timeout during suspend/resume stress test

2021-01-11 Thread Joakim Zhang
stmmac_xmit() call stmmac_tx_timer_arm() at the end to modify tx timer to do the transmission cleanup work. Imagine such a situation, stmmac enters suspend immediately after tx timer modified, it's expire callback stmmac_tx_clean() would not be invoked. This could affect BQL, since netdev_tx_sent_q

[PATCH 6/6] ethernet: stmmac: re-init rx buffers when mac resume back

2021-01-11 Thread Joakim Zhang
During suspend/resume stress test, we found descriptor write back by DMA could exhibit unusual behavior, e.g.: 003 [0xc4310030]: 0x0 0x40 0x0 0xb5010040 We can see that desc3 write back is 0xb5010040, it is still ownd by DMA, so application would not recycle this buffer. It will trigger fa

[PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-11 Thread Pali Rohár
This is a third version of patches which add workarounds for RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. Russel's PATCH v2 2/3 was dropped from this patch series as it is being handled separately. Pali Rohár (2): net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips n

[PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-11 Thread Pali Rohár
Workaround for GPON SFP modules based on VSOL V2801F brand was added in commit 0d035bed2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround"). But it works only for ids explicitly added to the list. As there are more rebraded VSOL V2801F modules and OEM vendors are putting into

[PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-11 Thread Pali Rohár
SFP GPON module Ubiquiti U-Fiber Instant has in its EEPROM stored nonsense information. It claims that support all transceiver types including 10G Ethernet which is not truth. So clear all claimed modes and set only one mode which module supports: 1000baseX_Full. Also this module have set SFF phys

Re: [PATCH] mt76: fix enum conversion warning

2021-01-11 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > A recent patch changed some enum values, but not the type > declaration for the assignment: > > drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:238:9: error: implicit > conversion from enumeration type 'enum mt76_mcuq_id' to different enumeration

Re: [PATCH 4/7] wil6210: select CONFIG_CRC32

2021-01-11 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > Without crc32, the driver fails to link: > > arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o: in function > `wil_fw_verify': > fw.c:(.text+0x74c): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: > drivers/net/wireless/ath/wi

Re: [PATCH 2/3] usbnet: add method for reporting speed without MDIO

2021-01-11 Thread Oliver Neukum
Am Donnerstag, den 07.01.2021, 20:27 +0100 schrieb Andrew Lunn: > On Thu, Jan 07, 2021 at 12:35:17PM +0100, Oliver Neukum wrote: > > Hi Oliver > > > +++ b/include/linux/usb/usbnet.h > > @@ -53,6 +53,8 @@ struct usbnet { > > u32 hard_mtu; /* count any extra framing */

Re: [RFC PATCH net] udp: check sk for UDP GRO fraglist

2021-01-11 Thread Alexander Lobakin
From: Steffen Klassert Date: Mon, 11 Jan 2021 09:43:22 +0100 > On Mon, Jan 11, 2021 at 11:02:42AM +0900, Dongseok Yi wrote: >> On 2021-01-08 22:35, Steffen Klassert wrote: >>> On Fri, Jan 08, 2021 at 09:52:28PM +0900, Dongseok Yi wrote: It is a workaround patch. UDP/IP header of UD

Re: [PATCH 21/21] vdpasim: control virtqueue support

2021-01-11 Thread Eli Cohen
On Wed, Dec 16, 2020 at 02:48:18PM +0800, Jason Wang wrote: > This patch introduces the control virtqueue support for vDPA > simulator. This is a requirement for supporting advanced features like > multiqueue. > > A requirement for control virtqueue is to isolate its memory access > from the rx/tx

[PATCH net-next 0/2] net: enable udp v6 sockets receiving v4 packets with UDP GRO

2021-01-11 Thread Xin Long
Currently, udp v6 socket can not process v4 packets with UDP GRO, as udp_encap_needed_key is not increased when udp_tunnel_encap_enable() is called for v6 socket. This patchset is to increase it and remove the unnecessary code in bareudp. Xin Long (2): udp: call udp_encap_enable for v6 sockets w

[PATCH net-next 1/2] udp: call udp_encap_enable for v6 sockets when enabling encap

2021-01-11 Thread Xin Long
When enabling encap for a ipv6 socket without udp_encap_needed_key increased, UDP GRO won't work for v4 mapped v6 address packets as sk will be NULL in udp4_gro_receive(). This patch is to enable it by increasing udp_encap_needed_key for v6 sockets in udp_tunnel_encap_enable(), and correspondingly

[PATCH net-next 2/2] Revert "bareudp: Fixed bareudp receive handling"

2021-01-11 Thread Xin Long
As udp_encap_enable() is already called in udp_tunnel_encap_enable() since the last patch, and we don't need it any more. So remove it by reverting commit 81f954a44567567c7d74a97b1db78fb43afc253d. --- drivers/net/bareudp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/bareud

[PATCH net-next 1/2] net: move the hsize check to the else block in skb_segment

2021-01-11 Thread Xin Long
After commit 89319d3801d1 ("net: Add frag_list support to skb_segment"), it goes to process frag_list when !hsize in skb_segment(). However, when using skb frag_list, sg normally should not be set. In this case, hsize will be set with len right before !hsize check, then it won't go to frag_list pro

[PATCH net-next 0/2] net: fix the features flag in sctp_gso_segment

2021-01-11 Thread Xin Long
Patch 1/2 is to improve the code in skb_segment(), and it is needed by Patch 2/2. Xin Long (2): net: move the hsize check to the else block in skb_segment sctp: remove the NETIF_F_SG flag before calling skb_segment net/core/skbuff.c | 5 +++-- net/sctp/offload.c | 2 +- 2 files changed, 4 i

[PATCH net-next 2/2] sctp: remove the NETIF_F_SG flag before calling skb_segment

2021-01-11 Thread Xin Long
It makes more sense to clear NETIF_F_SG instead of set it when calling skb_segment() in sctp_gso_segment(), since SCTP GSO is using head_skb's fraglist, of which all frags are linear skbs. This will make SCTP GSO code more understandable. Suggested-by: Alexander Duyck Signed-off-by: Xin Long --

[PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig

2021-01-11 Thread Marek Vasut
The PHYLIB must be selected to provide mdiobus_*() functions, and the MICREL_PHY is necessary too, as that is the only possible PHY attached to the KS8851 (it is the internal PHY). Fixes: ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY") Signed-off-by: Marek Vasut Cc: Andrew Lu

[PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-11 Thread Marek Vasut
Unless the internal PHY is connected and started, the phylib will not poll the PHY for state and produce state updates. Connect the PHY and start/stop it. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Heiner Kallweit Cc: Lukas Wunner --- drivers/net/ethernet/micrel/ks8851.h| 2 ++ d

[PATCH 4.4 12/38] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit bd1248f1ddbc48b0c30565fce897a3b6423313b8 ] Check Scell_log shift size in red_check_params() and modify all callers of red_check_params() to pass Scell_log. This prevents a shift out-of-bounds as detected by UBSAN: UBSAN: shift-out-of-bounds in ./include/ne

[PATCH 4.14 23/57] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit bd1248f1ddbc48b0c30565fce897a3b6423313b8 ] Check Scell_log shift size in red_check_params() and modify all callers of red_check_params() to pass Scell_log. This prevents a shift out-of-bounds as detected by UBSAN: UBSAN: shift-out-of-bounds in ./include/ne

[PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-11 Thread Xin Long
This patch is to let it always do CRC checksum in sctp_gso_segment() by removing CRC flag from the dev features in gre_gso_segment() for SCTP over GRE, just as it does in Commit 527beb8ef9c0 ("udp: support sctp over udp in skb_udp_tunnel_segment") for SCTP over UDP. It could set csum/csum_start in

Re: [PATCH v4 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls

2021-01-11 Thread Simon Chopin
Hello, Le 10/12/2020 à 16:50, Tom Parkin a écrit : > This new ioctl pair allows two ppp channels to be bridged together: > frames arriving in one channel are transmitted in the other channel > and vice versa. > > The practical use for this is primarily to support the L2TP Access > Concentrator us

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-11 Thread Heiner Kallweit
On 11.01.2021 13:53, Marek Vasut wrote: > Unless the internal PHY is connected and started, the phylib will not > poll the PHY for state and produce state updates. Connect the PHY and > start/stop it. > > Signed-off-by: Marek Vasut > Cc: Andrew Lunn > Cc: Heiner Kallweit > Cc: Lukas Wunner > -

Re: Security issue with vmxnet3 and e100 for AMD SEV(-SNP) / Intel TDX

2021-01-11 Thread Kirill A. Shutemov
On Fri, Jan 08, 2021 at 03:31:56PM +, Radev, Martin wrote: > Just noticed that Intel TDX already does the device filtering. Check: > https://github.com/intel/tdx/commit/6789eee52aab8985e49b362379fab73aa3eecde2 > > CC-ing Kirill and Kuppuswamy from Intel in case they want to be part of the >

[PATCH 5.10 035/145] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit bd1248f1ddbc48b0c30565fce897a3b6423313b8 ] Check Scell_log shift size in red_check_params() and modify all callers of red_check_params() to pass Scell_log. This prevents a shift out-of-bounds as detected by UBSAN: UBSAN: shift-out-of-bounds in ./include/ne

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-11 Thread Marek Vasut
On 1/11/21 2:26 PM, Heiner Kallweit wrote: [...] LGTM. When having a brief look at the driver I stumbled across two things: 1. Do MAC/PHY support any pause mode? Then a call to phy_support_(a)sym_pause() would be missing. https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8851-16MLL-Sing

Re: [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support

2021-01-11 Thread DENG Qingfang
On Mon, Jan 11, 2021 at 7:04 PM Russell King - ARM Linux admin wrote: > > FYI, Documentation/driver-api/gpio/consumer.rst says: > > For output GPIOs, the value provided becomes the initial output value. > This helps avoid signal glitching during system startup. > > Setting the pin to be an out

[PATCH 5.4 34/92] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit bd1248f1ddbc48b0c30565fce897a3b6423313b8 ] Check Scell_log shift size in red_check_params() and modify all callers of red_check_params() to pass Scell_log. This prevents a shift out-of-bounds as detected by UBSAN: UBSAN: shift-out-of-bounds in ./include/ne

Re: [PATCH net-next 0/2] dsa: add MT7530 GPIO support

2021-01-11 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 01:44:26PM +0800, DENG Qingfang wrote: > MT7530's LED controller can be used as GPIO controller. Add support for > it. > > DENG Qingfang (2): > dt-bindings: net: dsa: add MT7530 GPIO controller binding > drivers: net: dsa: mt7530: MT7530 optional GPIO support > > .../

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-11 Thread Heiner Kallweit
On 11.01.2021 14:38, Marek Vasut wrote: > On 1/11/21 2:26 PM, Heiner Kallweit wrote: > [...] > >> LGTM. When having a brief look at the driver I stumbled across two things: >> >> 1. Do MAC/PHY support any pause mode? Then a call to >>     phy_support_(a)sym_pause() would be missing. > > https://w

[PATCH 4.19 35/77] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit bd1248f1ddbc48b0c30565fce897a3b6423313b8 ] Check Scell_log shift size in red_check_params() and modify all callers of red_check_params() to pass Scell_log. This prevents a shift out-of-bounds as detected by UBSAN: UBSAN: shift-out-of-bounds in ./include/ne

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-11 Thread Ahmed S. Darwish
Hi, On Tue, Dec 22, 2020 at 10:03:37AM +0100, Ahmed S. Darwish wrote: ... > > Included is an RFC patch to fix the points above: if the RESET flag is > encountered, a workqueue is scheduled to run the generic reset sequence. > ... Kind reminder.

Re: [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support

2021-01-11 Thread Russell King - ARM Linux admin
On Mon, Jan 11, 2021 at 09:40:00PM +0800, DENG Qingfang wrote: > On Mon, Jan 11, 2021 at 7:04 PM Russell King - ARM Linux admin > wrote: > > > > FYI, Documentation/driver-api/gpio/consumer.rst says: > > > > For output GPIOs, the value provided becomes the initial output value. > > This helps a

RE: [PATCH net-next repost v2 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-11 Thread Danielle Ratson
> -Original Message- > From: Jakub Kicinski > Sent: Friday, January 8, 2021 2:35 AM > To: Danielle Ratson > Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko > ; and...@lunn.ch; f.faine...@gmail.com; > mkube...@suse.cz; mlxsw ; Ido Schimmel ; > Danielle Ratson > Subject: R

Re: Security issue with vmxnet3 and e100 for AMD SEV(-SNP) / Intel TDX

2021-01-11 Thread Robert Buhren
On 1/11/21 2:26 PM, Kirill A. Shutemov wrote: > On Fri, Jan 08, 2021 at 03:31:56PM +, Radev, Martin wrote: >> Just noticed that Intel TDX already does the device filtering. Check: >> https://github.com/intel/tdx/commit/6789eee52aab8985e49b362379fab73aa3eecde2 >> >> CC-ing Kirill and Kuppuswa

[PATCH 4.9 15/45] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit bd1248f1ddbc48b0c30565fce897a3b6423313b8 ] Check Scell_log shift size in red_check_params() and modify all callers of red_check_params() to pass Scell_log. This prevents a shift out-of-bounds as detected by UBSAN: UBSAN: shift-out-of-bounds in ./include/ne

Re: [PATCH net] net: ipa: modem: add missing SET_NETDEV_DEV() for proper sysfs links

2021-01-11 Thread Alex Elder
On 1/7/21 8:46 PM, Jakub Kicinski wrote: On Wed, 6 Jan 2021 11:07:55 +0100 Stephan Gerhold wrote: At the moment it is quite hard to identify the network interface provided by IPA in userspace components: The network interface is created as virtual device, without any link to the IPA device. The

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-11 Thread Marek Vasut
On 1/11/21 2:50 PM, Heiner Kallweit wrote: On 11.01.2021 14:38, Marek Vasut wrote: On 1/11/21 2:26 PM, Heiner Kallweit wrote: [...] LGTM. When having a brief look at the driver I stumbled across two things: 1. Do MAC/PHY support any pause mode? Then a call to     phy_support_(a)sym_pause() w

Re: [PATCH] net: phy: smsc: fix clk error handling

2021-01-11 Thread Andrew Lunn
On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote: > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > support") added the phy clk support. The commit already checks if > clk_get_optional() throw an error but instead of returning the error it > ignores it. > > Fixes:

Re: [PATCH v1 0/2] Add 100 base-x mode

2021-01-11 Thread Russell King - ARM Linux admin
On Mon, Jan 11, 2021 at 02:06:55PM +0100, Bjarni Jonasson wrote: > Adding support for 100 base-x in phylink. > The Sparx5 switch supports 100 base-x pcs (IEEE 802.3 Clause 24) 4b5b encoded. > These patches adds phylink support for that mode. > > Tested in Sparx5, using sfp modules: > Axcen 100fx A

Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode

2021-01-11 Thread Russell King - ARM Linux admin
On Mon, Jan 11, 2021 at 02:06:56PM +0100, Bjarni Jonasson wrote: > Sparx-5 supports this mode and it is missing in the PHY core. > > Signed-off-by: Bjarni Jonasson Looks good, thanks. Reviewed-by: Russell King > --- > include/linux/phy.h | 4 > 1 file changed, 4 insertions(+) > > diff

Re: [PATCH v1 2/2] sfp: add support for 100 base-x SFPs

2021-01-11 Thread Russell King - ARM Linux admin
On Mon, Jan 11, 2021 at 02:06:57PM +0100, Bjarni Jonasson wrote: > Add support for 100Base-FX, 100Base-LX, 100Base-PX and 100Base-BX10 modules > This is needed for Sparx-5 switch. > > Signed-off-by: Bjarni Jonasson > --- > drivers/net/phy/sfp-bus.c | 9 + > 1 file changed, 9 insertions(+

Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode

2021-01-11 Thread Andrew Lunn
On Mon, Jan 11, 2021 at 02:06:56PM +0100, Bjarni Jonasson wrote: > Sparx-5 supports this mode and it is missing in the PHY core. > > Signed-off-by: Bjarni Jonasson Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v4 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls

2021-01-11 Thread Guillaume Nault
On Mon, Jan 11, 2021 at 02:17:13PM +0100, Simon Chopin wrote: > Hello, > > Le 10/12/2020 à 16:50, Tom Parkin a écrit : > > This new ioctl pair allows two ppp channels to be bridged together: > > frames arriving in one channel are transmitted in the other channel > > and vice versa. > > > > The pr

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-11 Thread Heiner Kallweit
On 11.01.2021 15:10, Marek Vasut wrote: > On 1/11/21 2:50 PM, Heiner Kallweit wrote: >> On 11.01.2021 14:38, Marek Vasut wrote: >>> On 1/11/21 2:26 PM, Heiner Kallweit wrote: >>> [...] >>> LGTM. When having a brief look at the driver I stumbled across two things: 1. Do MAC/PHY suppor

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-11 Thread Andrew Lunn
On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote: > Unless the internal PHY is connected and started, the phylib will not > poll the PHY for state and produce state updates. Connect the PHY and > start/stop it. Hi Marek Please continue the conversion and remove all mii_calls. ks8851_s

Re: [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig

2021-01-11 Thread Andrew Lunn
On Mon, Jan 11, 2021 at 01:50:46PM +0100, Marek Vasut wrote: > The PHYLIB must be selected to provide mdiobus_*() functions, and the > MICREL_PHY is necessary too, as that is the only possible PHY attached > to the KS8851 (it is the internal PHY). > > Fixes: ef3631220d2b ("net: ks8851: Register MD

Re: [PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-11 Thread Marek Behún
Hi Pali, I have rewritten the commit message a little: The workaround for VSOL V2801F brand based GPON SFP modules added in commit 0d035bed2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") works only for IDs added explicitly to the list. Since there are rebranded modules w

KMSAN: uninit-value in __nla_validate_parse (2)

2021-01-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=153a38f750 kernel config: https://syzkaller.appspot.co

Re: [PATCH iproute2] tc: flower: fix json output with mpls lse

2021-01-11 Thread David Ahern
On 1/11/21 3:57 AM, Guillaume Nault wrote: > Okay, but, in the end, should I repost this patch? I think your patches are covered, but you should check the repo to make sure.

[PATCH] Signed-off-by: giladreti

2021-01-11 Thread giladreti
Added support for pointer to mem register spilling, to allow the verifier to track pointer to valid memory addresses. Such pointers are returned for example by a successful call of the bpf_ringbuf_reserve helper. This patch was suggested as a solution by Yonghong Song. --- kernel/bpf/verifier.c |

Re: [PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-11 Thread Marek Behún
On Mon, 11 Jan 2021 12:39:09 +0100 Pali Rohár wrote: > SFP GPON module Ubiquiti U-Fiber Instant has in its EEPROM stored nonsense > information. It claims that support all transceiver types including 10G > Ethernet which is not truth. So clear all claimed modes and set only one > mode which modul

Re: [net-next 15/19] can: tcan4x5x: rework SPI access

2021-01-11 Thread Ahmad Fatoum
Hello Jakub, On 08.01.21 17:32, Jakub Kicinski wrote: > On Fri, 8 Jan 2021 11:07:26 +0100 Ahmad Fatoum wrote: > +struct __packed tcan4x5x_map_buf { > + struct tcan4x5x_buf_cmd cmd; > + u8 data[256 * sizeof(u32)]; > +} cacheline_aligned; Due to the packing of t

  1   2   3   4   >