[PATCH] qtnfmac_pcie: Use module_pci_driver

2020-12-21 Thread Amey Narkhede
Use module_pci_driver for drivers whose init and exit functions only register and unregister, respectively. Signed-off-by: Amey Narkhede --- drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/wireless/q

Re: [PATCH v4 bpf-next 1/2] net: xdp: introduce xdp_init_buff utility routine

2020-12-21 Thread Jesper Dangaard Brouer
On Sat, 19 Dec 2020 18:55:00 +0100 Lorenzo Bianconi wrote: > diff --git a/include/net/xdp.h b/include/net/xdp.h > index 11ec93f827c0..323340caef88 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -76,6 +76,13 @@ struct xdp_buff { > u32 frame_sz; /* frame size to deduce data_h

Re: [PATCHv12 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2020-12-21 Thread Hangbin Liu
Hi David, I just aware that, On Thu, Dec 17, 2020 at 09:07:03AM -0700, David Ahern wrote: > > +static int dev_map_bpf_prog_run(struct bpf_prog *xdp_prog, > > + struct xdp_frame **frames, int n, > > + struct net_device *dev) > > +{ > > + struct

[PATCH] net/mlx5e: Fix two double free cases

2020-12-21 Thread Dinghao Liu
mlx5e_create_ttc_table_groups() frees ft->g on failure of kvzalloc(), but such failure will be caught by its caller in mlx5e_create_ttc_table() and ft->g will be freed again in mlx5e_destroy_flow_table(). The same issue also occurs in mlx5e_create_ttc_table_groups(). Signed-off-by: Dinghao Liu --

Re: [PATCH v3 1/5] Bluetooth: advmon offload MSFT add rssi support

2020-12-21 Thread Marcel Holtmann
Hi Archie, > MSFT needs rssi parameter for monitoring advertisement packet, > therefore we should supply them from mgmt. This adds a new opcode > to add advertisement monitor with rssi parameters. > > Signed-off-by: Archie Pusaka > Reviewed-by: Manish Mandlik > Reviewed-by: Miao-chen Chou > Re

Re: [PATCH v3 4/5] Bluetooth: advmon offload MSFT handle controller reset

2020-12-21 Thread Marcel Holtmann
Hi Archie, > When the controller is powered off, the registered advertising monitor > is removed from the controller. This patch handles the re-registration > of those monitors when the power is on. > > Signed-off-by: Archie Pusaka > Reviewed-by: Miao-chen Chou > Reviewed-by: Yun-Hao Chung >

Re: [PATCH v3 2/5] Bluetooth: advmon offload MSFT add monitor

2020-12-21 Thread Marcel Holtmann
Hi Archie, > Enables advertising monitor offloading to the controller, if MSFT > extension is supported. The kernel won't adjust the monitor parameters > to match what the controller supports - that is the user space's > responsibility. > > This patch only manages the addition of monitors. Monito

[GIT PULL] 9p update for 5.11-rc1

2020-12-21 Thread Dominique Martinet
Hi Linus, here's this cycle's update, finally finished on some very old patches (originally april 2015!) to allow fixing open-unlink-fgetattr pattern. Thanks to Eric, Greg and Jianyong for the bulk of the work, and Dan for static analysis fixes on -next. The following changes since commit 3ce

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-21 Thread Jesper Dangaard Brouer
On Sat, 19 Dec 2020 10:30:57 -0500 Jamal Hadi Salim wrote: > On 2020-12-19 9:53 a.m., Shay Agroskin wrote: > > > > Lorenzo Bianconi writes: > > > > >> for the moment I do not know if this area is used for other purposes. > >> Do you think there are other use-cases for it? Yes, all the sa

Re: [PATCH v4 bpf-next 1/2] net: xdp: introduce xdp_init_buff utility routine

2020-12-21 Thread Lorenzo Bianconi
On Mon, Dec 21, 2020 at 9:37 AM Jesper Dangaard Brouer wrote: > > On Sat, 19 Dec 2020 18:55:00 +0100 > Lorenzo Bianconi wrote: > > > diff --git a/include/net/xdp.h b/include/net/xdp.h > > index 11ec93f827c0..323340caef88 100644 > > --- a/include/net/xdp.h > > +++ b/include/net/xdp.h > > @@ -76,6

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-21 Thread Guenter Roeck
On 12/20/20 10:18 PM, Masahiro Yamada wrote: > On Mon, Dec 14, 2020 at 12:27 AM Miguel Ojeda > wrote: >> >> On Sun, Dec 13, 2020 at 4:16 PM Greg KH wrote: >>> >>> Because if you get a report of something breaking for your change, you >>> need to work to resolve it, not argue about it. Otherwise

Reporting SFP presence status

2020-12-21 Thread Martin Hundebøll
Hi Andrew, I've browsed the code in drivers/net/phy, but haven't found a place where the SFP module status/change is reported to user-space. Is there a "standard" way to report insert/remove events for SFP modules, or should we just add a custom sysfs attribute to our driver? Thanks, Martin

Re: UBSAN: object-size-mismatch in wg_xmit

2020-12-21 Thread Jason A. Donenfeld
Hi Dmitry, On Mon, Dec 21, 2020 at 10:14 AM Dmitry Vyukov wrote: > Hi Jason, > > Thanks for looking into this. > > Reading clang docs for ubsan: > > https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html > -fsanitize=object-size: An attempt to potentially use bytes which the > optimizer can

[PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups

2020-12-21 Thread Dinghao Liu
When mlx5_create_flow_group() fails, ft->g should be freed just like when kvzalloc() fails. The caller of mlx5e_create_l2_table_groups() does not catch this issue on failure, which leads to memleak. Signed-off-by: Dinghao Liu --- drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 1 + 1 file chan

Re: general protection fault in j1939_netdev_notify (2)

2020-12-21 Thread Oliver Hartkopp
On 20.12.20 15:37, Oleksij Rempel wrote: Hello Oliver, On Sun, Dec 20, 2020 at 02:18:27PM +0100, Oliver Hartkopp wrote: Hello Oleksij, I assume there is some ndev->ml_priv value set - but not from a CAN netdevice. it is kind of CAN device :) No, it is not. Team and bonding devices copy

[PATCHv13 bpf-next 0/6] xdp: add a new helper for dev map multicast support

2020-12-21 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv13 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test

2020-12-21 Thread Hangbin Liu
This is a sample for xdp multicast. In the sample we could forward all packets between given interfaces. There is also an option -X that could enable 2nd xdp_prog on egress interface. Signed-off-by: Hangbin Liu --- v12: add devmap xdp_prog on egress support v10-v11: no update v9: use NULL direct

[PATCHv13 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2020-12-21 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv13 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2020-12-21 Thread Hangbin Liu
Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. [1] https://lore.kernel.org/bpf/20200715070001.2048207-1-liuhang...@gmail.com/ Signed-o

[PATCHv13 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2020-12-21 Thread Hangbin Liu
From: Jesper Dangaard Brouer This changes the devmap XDP program support to run the program when the bulk queue is flushed instead of before the frame is enqueued. This has a couple of benefits: - It "sorts" the packets by destination devmap entry, and then runs the same BPF program on all the

[PATCHv13 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test

2020-12-21 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test we have 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. We will also test both DEVMAP and DEVMAP_HASH

[PATCHv13 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL

2020-12-21 Thread Hangbin Liu
Use helper bpf_redirect_map() and bpf_redirect_map_multi() to test bpf arg ARG_CONST_MAP_PTR and ARG_CONST_MAP_PTR_OR_NULL. Make sure the map arg could be verified correctly when it is NULL or valid map pointer. Add devmap and devmap_hash in struct bpf_test due to bpf_redirect_{map, map_multi} lim

Re: WARNING in isotp_tx_timer_handler

2020-12-21 Thread Oliver Hartkopp
Hello Hillf, On 21.12.20 06:40, Hillf Danton wrote: Sun, 20 Dec 2020 11:24:13 -0800 syzbot found the following issue on: HEAD commit:5e60366d Merge tag 'fallthrough-fixes-clang-5.11-rc1' of g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=179a22875

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-21 Thread Jamal Hadi Salim
On 2020-12-21 4:01 a.m., Jesper Dangaard Brouer wrote: On Sat, 19 Dec 2020 10:30:57 -0500 Sorry to interject: Does it make sense to use it to store arbitrary metadata or a scratchpad in this space? Something equivalent to skb->cb which is lacking in XDP. Well, XDP have the data_meta area. B

[PATCH v2] net: neighbor: fix a crash caused by mod zero

2020-12-21 Thread weichenchen
pneigh_enqueue() tries to obtain a random delay by mod NEIGH_VAR(p, PROXY_DELAY). However, NEIGH_VAR(p, PROXY_DELAY) migth be zero at that point because someone could write zero to /proc/sys/net/ipv4/neigh/[device]/proxy_delay after the callers check it. This patch double-checks NEIGH_VAR(p, PROXY

Re: [RFC PATCH v2 1/8] dt-bindings: net: sparx5: Add sparx5-switch bindings

2020-12-21 Thread Steen Hegelund
On Sun, 2020-12-20 at 16:55 -0800, Florian Fainelli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On 12/16/2020 11:51 PM, Steen Hegelund wrote: > > Document the Sparx5 switch device driver bindings > > > > Signed-off-by: Steen Hegelund

[PATCH net 1/1] qede: fix offload for IPIP tunnel packets

2020-12-21 Thread Manish Chopra
IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by: Sudarsana Kalluru Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/q

Re: [PATCH v3 1/4] lib: vsprintf: scanf: Negative number must have field width > 1

2020-12-21 Thread Petr Mladek
On Thu 2020-12-17 18:00:54, Richard Fitzgerald wrote: > If a signed number field starts with a '-' the field width must be > 1, > or unlimited, to allow at least one digit after the '-'. > > This patch adds a check for this. If a signed field starts with '-' > and field_width == 1 the scanf will q

Re: Reporting SFP presence status

2020-12-21 Thread Andrew Lunn
On Mon, Dec 21, 2020 at 11:37:55AM +0100, Martin Hundebøll wrote: > Hi Andrew, > > I've browsed the code in drivers/net/phy, but haven't found a place where > the SFP module status/change is reported to user-space. Is there a > "standard" way to report insert/remove events for SFP modules, or shou

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Andrew Lunn
On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > The declaration of request_irq() in is marked as > __must_check. > > Without the return value check, I see the following warnings: > > drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_hw_init': > drivers/net/ethernet/lan

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Masahiro Yamada
On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > The declaration of request_irq() in is marked as > > __must_check. > > > > Without the return value check, I see the following warnings: > > > > drivers/net/ethernet/lantiq

[PATCH ghak90 v10 01/11] audit: collect audit task parameters

2020-12-21 Thread Richard Guy Briggs
The audit-related parameters in struct task_struct should ideally be collected together and accessed through a standard audit API and the audit structures made opaque to other kernel subsystems. Collect the existing loginuid, sessionid and audit_context together in a new opaque struct audit_task_i

[PATCH ghak90 v10 00/11] audit: implement container identifier

2020-12-21 Thread Richard Guy Briggs
Implement kernel audit container identifier. This patchset is an eighth based on the proposal document (V4) posted: https://www.redhat.com/archives/linux-audit/2019-September/msg00052.html The first patch was the last patch from ghak81 that was absorbed into this patchset since its primar

[PATCH ghak90 v10 02/11] audit: add container id

2020-12-21 Thread Richard Guy Briggs
Implement the proc fs write to set the audit container identifier of a process, emitting an AUDIT_CONTAINER_OP record to document the event. This is a write from the container orchestrator task to a proc entry of the form /proc/PID/audit_containerid where PID is the process ID of the newly created

[PATCH ghak90 v10 04/11] audit: add contid support for signalling the audit daemon

2020-12-21 Thread Richard Guy Briggs
Add audit container identifier support to the action of signalling the audit daemon. Since this would need to add an element to the audit_sig_info struct, a new record type AUDIT_SIGNAL_INFO2 was created with a new audit_sig_info2 struct. Corresponding support is required in the userspace code to

[PATCH ghak90 v10 03/11] audit: log container info of syscalls

2020-12-21 Thread Richard Guy Briggs
Create a new audit record AUDIT_CONTAINER_ID to document the audit container identifier of a process if it is present. Called from audit_log_exit(), syscalls are covered. Include target_cid references from ptrace and signal. A sample raw event: time->Thu Nov 26 10:24:40 2020 type=PROCTITLE msg=a

[PATCH ghak90 v10 06/11] audit: add containerid support for user records

2020-12-21 Thread Richard Guy Briggs
Add audit container identifier auxiliary record to user event standalone records. Signed-off-by: Richard Guy Briggs Acked-by: Neil Horman Reviewed-by: Ondrej Mosnacek --- kernel/audit.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/kernel/audit.c b/kernel/aud

[PATCH ghak90 v10 05/11] audit: add support for non-syscall auxiliary records

2020-12-21 Thread Richard Guy Briggs
Standalone audit records have the timestamp and serial number generated on the fly and as such are unique, making them standalone. This new function audit_alloc_local() generates a local audit context that will be used only for a standalone record and its auxiliary record(s). The context is disca

[PATCH ghak90 v10 07/11] audit: add containerid filtering

2020-12-21 Thread Richard Guy Briggs
Implement audit container identifier filtering using the AUDIT_CONTID field name to send an 8-character string representing a u64 since the value field is only u32. Sending it as two u32 was considered, but gathering and comparing two fields was more complex. The feature indicator is AUDIT_FEATUR

[PATCH ghak90 v10 08/11] audit: add support for containerid to network namespaces

2020-12-21 Thread Richard Guy Briggs
This also adds support to qualify NETFILTER_PKT records. Audit events could happen in a network namespace outside of a task context due to packets received from the net that trigger an auditing rule prior to being associated with a running task. The network namespace could be in use by multiple c

[PATCH ghak90 v10 10/11] audit: track container nesting

2020-12-21 Thread Richard Guy Briggs
Track the parent container of a container to be able to filter and report nesting. Now that we have a way to track and check the parent container of a container, modify the contid field format to be able to report that nesting using a carrat ("^") modifier to indicate nesting. The original field

[PATCH ghak90 v10 09/11] audit: contid check descendancy and nesting

2020-12-21 Thread Richard Guy Briggs
Require the target task to be a descendant of the container orchestrator/engine. You would only change the audit container ID from one set or inherited value to another if you were nesting containers. If changing the contid, the container orchestrator/engine must be a descendant and not same orch

[PATCH ghak90 v10 11/11] audit: add capcontid to set contid outside init_user_ns

2020-12-21 Thread Richard Guy Briggs
Provide a mechanism similar to CAP_AUDIT_CONTROL to explicitly give a process in a non-init user namespace the capability to set audit container identifiers of individual children. Provide the /proc/$PID/audit_capcontid interface to capcontid. Valid values are: 1==enabled, 0==disabled Writing a "

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Andrew Lunn
On Tue, Dec 22, 2020 at 12:59:08AM +0900, Masahiro Yamada wrote: > On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > > The declaration of request_irq() in is marked as > > > __must_check. > > > > > > Without the return

[Aspeed,ncsi-rx, v1 1/1] net: ftgmac100: Fix AST2600 EVB NCSI RX issue

2020-12-21 Thread Hongwei Zhang
When FTGMAC100 driver is used on other NCSI Ethernet controllers, few controllers have compatible issue, removing FTGMAC100_RXDES0_RX_ERR bit from RXDES0_ANY_ERROR can fix the issue. Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system") Signed-off-by: Hongwei Zhang --- drivers/net/e

[Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue

2020-12-21 Thread Hongwei Zhang
Hi Andrew, > From: Andrew Jeffery > > > Fix AST2600 EVB NCSI RX timeout issue by removing > > FTGMAC100_RXDES0_RX_ERR bit from macro RXDES0_ANY_ERROR. > > But why? What is wrong with the EVB that this change resolves? Which revision > of the EVB? > > The change affects all designs using the

[Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue

2020-12-21 Thread Hongwei Zhang
Dear Reviewer, When FTGMAC100 driver is used on other NCSI Ethernet controllers, few controllers have compatible issue. One example is Intel I210 Ethernet controller on AST2600 BMC, with FTGMAC100 driver, it always trigger RXDES0_RX_ERR error, cause NCSI initialization failure, removing FTGMAC100_

[Aspeed,ncsi-rx, v1] Answer to initial submission

2020-12-21 Thread Hongwei Zhang
Hi Jakub, > From: Jakub Kicinski > > > ... > > Signed-off-by: Hongwei Zhang > > Thanks for the patch. Please repost CCing the netdev mailing list so it can > be merged to the networking > tree (which I assume is your intent). > Please also include a Fixes tag pointing to the commit where th

Re: [PATCH ghak90 v10 01/11] audit: collect audit task parameters

2020-12-21 Thread Richard Guy Briggs
On 2020-12-21 12:14, Paul Moore wrote: > On Mon, Dec 21, 2020 at 11:57 AM Richard Guy Briggs wrote: > > > > The audit-related parameters in struct task_struct should ideally be > > collected together and accessed through a standard audit API and the audit > > structures made opaque to other kernel

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Miguel Ojeda
On Mon, Dec 21, 2020 at 6:01 PM Andrew Lunn wrote: > > So please leave the warning in place, and maybe somebody else will > fully fix it. For context: the plan is to enable the warning unconditionally starting with 5.11. After that, the idea is making it an error as soon as reasonable (e.g. 5.12

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Andrew Lunn
On Tue, Dec 22, 2020 at 12:59:08AM +0900, Masahiro Yamada wrote: > On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > > The declaration of request_irq() in is marked as > > > __must_check. > > > > > > Without the return

Re: [PATCH v1] Bluetooth: Set missing suspend task bits

2020-12-21 Thread Abhishek Pandit-Subedi
Hi Dmitry, https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=295fa2a5647b13681594bb1bcc76c74619035218 should fix this issue. Your issue seems the same as the one I encountered -- the SUSPEND_DISABLE bit (0x4) wasn't being cleared by the request completion han

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-21 Thread Miguel Ojeda
On Mon, Dec 21, 2020 at 7:20 AM Masahiro Yamada wrote: > > Sorry for the delay. No problem! > Now I sent out the fix for lantiq_etop.c > > https://lore.kernel.org/patchwork/patch/1355595/ I saw it, thanks for the Cc! > The reason of the complication was > I was trying to merge the following pa

Re: [PATCH ghak90 v10 01/11] audit: collect audit task parameters

2020-12-21 Thread Paul Moore
On Mon, Dec 21, 2020 at 11:57 AM Richard Guy Briggs wrote: > > The audit-related parameters in struct task_struct should ideally be > collected together and accessed through a standard audit API and the audit > structures made opaque to other kernel subsystems. > > Collect the existing loginuid, s

Re: [PATCH] net: ath10k: santity check for ep connectivity

2020-12-21 Thread Kalle Valo
Zekun Shen writes: > Function ep_rx_complete is being called without NULL checking > in ath10k_htc_rx_completion_handler. Without such check, mal- > formed packet is able to cause jump to NULL. > > ep->service_id seems a good candidate for sanity check as it is > used in usb.c. > > Signed-off-by:

Re: [PATCH v1] Bluetooth: Set missing suspend task bits

2020-12-21 Thread Dmitry Osipenko
21.12.2020 20:58, Abhishek Pandit-Subedi пишет: > Hi Dmitry, > > https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=295fa2a5647b13681594bb1bcc76c74619035218 > should fix this issue. > > Your issue seems the same as the one I encountered -- the > SUSPEND_DISABL

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Jakub Kicinski
On Sun, 20 Dec 2020 18:08:19 +0100 Marcin Wojtas wrote: > > > > > >> > > This patch fixes a regression that was introduced in v5.3: > > > > > >> > > Commit 44cc27e43fa3 ("net: phylink: Add struct phylink_config > > > > > >> > > to PHYLINK API") > > > > > >> > > > > > > > >> > > Above results in a

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Russell King - ARM Linux admin
On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > We need to work with stable maintainers on this, let's see.. > > Greg asked for a clear description of what happens, from your > previous response it sounds like a null-deref in mvpp2_mac_config(). > Is the netdev -> config -> net

Re: [RFC PATCH v2 0/8] Adding the Sparx5 Switch Driver

2020-12-21 Thread Steen Hegelund
Hi Florian, On Sun, 2020-12-20 at 16:58 -0800, Florian Fainelli wrote: > > > > The Sparx5 Switch chip register model can be browsed here: > > Link: > > https://microchip-ung.github.io/sparx-5_reginfo/reginfo_sparx-5.html > > Out of curiosity, what tool was used to generate the register > infor

Re: [PATCH net] docs: netdev-FAQ: add missing underlines to questions

2020-12-21 Thread Jakub Kicinski
On Sun, 20 Dec 2020 10:29:12 +0200 Baruch Siach wrote: > > I think this and the following fixes should be folded into a single > > line (unless it's possible in RST for header to span multiple lines): > > > > I sent a patch and I'm wondering what happened to it - how can I tell > > whether it got

Re: [PATCH v1] Bluetooth: Set missing suspend task bits

2020-12-21 Thread Dmitry Osipenko
04.12.2020 06:14, Howard Chung пишет: > From: Abhishek Pandit-Subedi > > When suspending, mark SUSPEND_SCAN_ENABLE and SUSPEND_SCAN_DISABLE tasks > correctly when either classic or le scanning is modified. > > Signed-off-by: Abhishek Pandit-Subedi > Signed-off-by: Howard Chung > Reviewed-by: A

Re: [GIT PULL] 9p update for 5.11-rc1

2020-12-21 Thread pr-tracker-bot
The pull request you sent on Mon, 21 Dec 2020 10:48:28 +0100: > https://github.com/martinetd/linux tags/9p-for-5.11-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/70990afa34fbac03ade78e2ad0ccd418acecfc04 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Jakub Kicinski
On Mon, 21 Dec 2020 18:30:32 + Russell King - ARM Linux admin wrote: > On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > > We need to work with stable maintainers on this, let's see.. > > > > Greg asked for a clear description of what happens, from your > > previous response i

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-21 Thread Mark Brown
On Fri, Dec 18, 2020 at 04:58:56PM -0400, Jason Gunthorpe wrote: > On Fri, Dec 18, 2020 at 08:32:11PM +, Mark Brown wrote: > > > Historically people did try to create custom bus types, as I have > > pointed out before there was then pushback that these were duplicating > > the platform bus so

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-21 Thread Jakub Kicinski
On Mon, 21 Dec 2020 19:46:23 +0100 Eric Dumazet wrote: > So maybe the issue is coming from traffic coming from a VM through a > tun device or something, > and our handling of GSO_ROBUST / DODGY never cared about setting > SKB_GSO_TCPV4 or SKB_GSO_TCPV6 if not already given by user space ? > > Or a

Re: [EXT] Re: [PATCH net-next] net: mvpp2: prs: improve ipv4 parse flow

2020-12-21 Thread Jakub Kicinski
On Sun, 20 Dec 2020 11:11:35 + Stefan Chulski wrote: > > RFC patches sent for review only are obviously welcome at any time. > > If I post RFC patches for review only, should I add some prefix or tag for > this? Include RFC in the tag: [RFC net-next] or [PATCH RFC net-next], this way patch

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Sasha Levin
On Mon, Dec 21, 2020 at 10:47:57AM -0800, Jakub Kicinski wrote: On Mon, 21 Dec 2020 18:30:32 + Russell King - ARM Linux admin wrote: On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > We need to work with stable maintainers on this, let's see.. > > Greg asked for a clear descr

Re: [PATCH AUTOSEL 5.4 08/10] selftests/bpf: Fix array access with signed variable test

2020-12-21 Thread Sasha Levin
On Sun, Dec 20, 2020 at 01:05:19PM +0100, Jean-Philippe Brucker wrote: Hi, On Sat, Dec 19, 2020 at 10:34:55PM -0500, Sasha Levin wrote: From: Jean-Philippe Brucker [ Upstream commit 77ce220c0549dcc3db8226c61c60e83fc59dfafc ] The test fails because of a recent fix to the verifier, even though

Re: [PATCH v4 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema

2020-12-21 Thread Rob Herring
On Wed, Dec 16, 2020 at 05:30:02PM +0800, Chunfeng Yun wrote: > Convert usb-device.txt to YAML schema usb-device.yaml > > Signed-off-by: Chunfeng Yun > --- > v4: no changes, update dependent series: > https://patchwork.kernel.org/project/linux-usb/list/?series=399561 > [v6,00/19] dt-bindi

Re: [PATCH v4 02/11] dt-bindings: net: btusb: change reference file name

2020-12-21 Thread Rob Herring
On Wed, 16 Dec 2020 17:30:03 +0800, Chunfeng Yun wrote: > Due to usb-device.txt is converted into usb-device.yaml, > so modify reference file names at the same time. > > Signed-off-by: Chunfeng Yun > --- > v2~v4: no changes > --- > Documentation/devicetree/bindings/net/btusb.txt | 2 +- > 1 file

Re: [PATCH v4 07/11] dt-bindings: phy: convert MIPI DSI PHY binding to YAML schema

2020-12-21 Thread Rob Herring
On Wed, 16 Dec 2020 17:30:08 +0800, Chunfeng Yun wrote: > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > v4: > 1. add maintainer Philipp add support mt8183 suggested by Chun-Kuang > 2. use key

[PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller

2020-12-21 Thread Nick Lowe
The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) queues. It should not be excluded from having this feature enabled. Via commit c883de9fd787b6f49bf825f3de3601aeb78a7114 E1000_MRQC_ENABLE_RSS_4Q was renamed to E1000_MRQC_ENABLE_RSS_MQ to indicate that this is a generic bit f

Re: [PATCH 3/9 v1 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put()

2020-12-21 Thread Jonathan Lemon
On Sat, Dec 19, 2020 at 01:46:13PM -0500, Willem de Bruijn wrote: > On Fri, Dec 18, 2020 at 3:20 PM Jonathan Lemon > wrote: > > > > From: Jonathan Lemon > > > > In preparation for further work, the zcopy* routines will > > become basic building blocks, while the zerocopy* ones will > > be specif

Re: [PATCH v4 09/11] dt-bindings: usb: convert mediatek,mtk-xhci.txt to YAML schema

2020-12-21 Thread Rob Herring
On Wed, Dec 16, 2020 at 05:30:10PM +0800, Chunfeng Yun wrote: > Convert mediatek,mtk-xhci.txt to YAML schema mediatek,mtk-xhci.yaml > > Signed-off-by: Chunfeng Yun > --- > v4: update it according to Rob's suggestion > 1. modify dictionary of phys > 2. fix endentation in "mediatek,syscon-wakeu

[PATCH bpf] bpf: add schedule point in htab_init_buckets()

2020-12-21 Thread Eric Dumazet
From: Eric Dumazet We noticed that with a LOCKDEP enabled kernel, allocating a hash table with 65536 buckets would use more than 60ms. htab_init_buckets() runs from process context, it is safe to schedule to avoid latency spikes. Fixes: c50eb518e262 ("bpf: Use separate lockdep class for each ha

Re: [PATCH v4 10/11] dt-bindings: usb: convert mediatek,mtu3.txt to YAML schema

2020-12-21 Thread Rob Herring
On Wed, Dec 16, 2020 at 05:30:11PM +0800, Chunfeng Yun wrote: > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > Signed-off-by: Chunfeng Yun > --- > v4: > 1. refer to usb-drd.yaml insstead of usb/generic.txt > the following ones suggested by Rob: > 2. add the number of phys s

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-21 Thread Miguel Ojeda
On Mon, Dec 21, 2020 at 11:02 AM Guenter Roeck wrote: > > On 12/20/20 10:18 PM, Masahiro Yamada wrote: > With a change like this, I'd have expected that there is a coccinelle > script or similar to ensure that claims made in the commit message > are true. It is only a warning -- the compiler alre

Re: [PATCH v2] net: neighbor: fix a crash caused by mod zero

2020-12-21 Thread Jakub Kicinski
On Mon, 21 Dec 2020 21:07:44 +0800 weichenchen wrote: > pneigh_enqueue() tries to obtain a random delay by mod > NEIGH_VAR(p, PROXY_DELAY). However, NEIGH_VAR(p, PROXY_DELAY) > migth be zero at that point because someone could write zero > to /proc/sys/net/ipv4/neigh/[device]/proxy_delay after the

[PATCH net v2 0/3] net-sysfs: fix race conditions in the xps code

2020-12-21 Thread Antoine Tenart
Hello all, This series fixes race conditions in the xps code, where out of bound accesses can occur when dev->num_tc is updated, triggering oops. The root cause is linked to lock issues. An explanation is given in each of the commit logs. Reviews in v1 suggested to use the xps_map_mutex to protec

[PATCH net v2 1/3] net: fix race conditions in xps by locking the maps and dev->tc_num

2020-12-21 Thread Antoine Tenart
Two race conditions can be triggered in xps, resulting in various oops and invalid memory accesses: 1. Calling netdev_set_num_tc while netif_set_xps_queue: - netdev_set_num_tc sets dev->tc_num. - netif_set_xps_queue uses dev->tc_num as one of the parameters to compute the size of new_

[PATCH net v2 3/3] net: move the xps rxqs retrieval out of net-sysfs

2020-12-21 Thread Antoine Tenart
Accesses to dev->xps_rxqs_map (when using dev->num_tc) should be protected by the xps_map mutex, to avoid possible race conditions when dev->num_tc is updated while the map is accessed. Make use of the now available netif_show_xps_queue helper which does just that. This also helps to keep xps_cpus

[PATCH net v2 2/3] net: move the xps cpus retrieval out of net-sysfs

2020-12-21 Thread Antoine Tenart
Accesses to dev->xps_cpus_map (when using dev->num_tc) should be protected by the xps_map mutex, to avoid possible race conditions when dev->num_tc is updated while the map is accessed. This patch moves the logic accessing dev->xps_cpu_map and dev->num_tc to net/core/dev.c, where the xps_map mutex

[Aspeed,ncsi-rx, v2 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue

2020-12-21 Thread Hongwei Zhang
Dear Reviewer, When FTGMAC100 driver is used on other NCSI Ethernet controllers, few controllers have compatible issue. One example is Intel I210 Ethernet controller on AST2600 BMC, with FTGMAC100 driver, it always trigger RXDES0_RX_ERR error, cause NCSI initialization failure, removing FTGMAC100_

[Aspeed,ncsi-rx, v2 1/1] net: ftgmac100: Fix AST2600 EVB NCSI RX issue

2020-12-21 Thread Hongwei Zhang
When FTGMAC100 driver is used on other NCSI Ethernet controllers, few controllers have compatible issue, removing FTGMAC100_RXDES0_RX_ERR bit from RXDES0_ANY_ERROR can fix the issue. Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system") Signed-off-by: Hongwei Zhang --- drivers/net/e

Re: [PATCH 0/9 v1 RFC] Generic zcopy_* functions

2020-12-21 Thread Jonathan Lemon
On Sat, Dec 19, 2020 at 02:00:55PM -0500, Willem de Bruijn wrote: > On Fri, Dec 18, 2020 at 4:27 PM Jonathan Lemon > wrote: > > > > On Fri, Dec 18, 2020 at 03:49:44PM -0500, Willem de Bruijn wrote: > > > On Fri, Dec 18, 2020 at 3:23 PM Jonathan Lemon > > > wrote: > > > > > > > > From: Jonathan

Re: [PATCH] net: stmmac: dwmac-meson8b: ignore the second clock input

2020-12-21 Thread Thomas Graichen
On Sat, Dec 19, 2020 at 2:52 PM Martin Blumenstingl wrote: > > The dwmac glue registers on Amlogic Meson8b and newer SoCs has two clock > inputs: > - Meson8b and Meson8m2: MPLL2 and MPLL2 (the same parent is wired to > both inputs) > - GXBB, GXL, GXM, AXG, G12A, G12B, SM1: FCLK_DIV2 and MPLL2 >

[Aspeed, v1 0/1] net: ftgmac100: Change the order of getting MAC address

2020-12-21 Thread Hongwei Zhang
Dear Reviewer, Use native MAC address is preferred over other choices, thus change the order of reading MAC address, try to read it from MAC chip first, if it's not availabe, then try to read it from device tree. Hongwei Zhang (1): net: ftgmac100: Change the order of getting MAC address driv

[Aspeed, v1 1/1] net: ftgmac100: Change the order of getting MAC address

2020-12-21 Thread Hongwei Zhang
Change the order of reading MAC address, try to read it from MAC chip first, if it's not availabe, then try to read it from device tree. Fixes: 35c54922dc97 ("ARM: dts: tacoma: Add reserved memory for ramoops") Signed-off-by: Hongwei Zhang --- drivers/net/ethernet/faraday/ftgmac100.c | 22 ++

Re: [PATCH bpf] bpf: add schedule point in htab_init_buckets()

2020-12-21 Thread Song Liu
> On Dec 21, 2020, at 11:25 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > We noticed that with a LOCKDEP enabled kernel, > allocating a hash table with 65536 buckets would > use more than 60ms. > > htab_init_buckets() runs from process context, > it is safe to schedule to avoid latency

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-21 Thread Shay Agroskin
Lorenzo Bianconi writes: Lorenzo Bianconi writes: >> On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: >> > Introduce xdp_shared_info data structure to contain info >> > about >> > "non-linear" xdp frame. xdp_shared_info will alias >> > skb_shared_info >> > allowing to keep most

[PATCH net] net: mptcp: cap forward allocation to 1M

2020-12-21 Thread Davide Caratti
the following syzkaller reproducer: r0 = socket$inet_mptcp(0x2, 0x1, 0x106) bind$inet(r0, &(0x7f80)={0x2, 0x4e24, @multicast2}, 0x10) connect$inet(r0, &(0x7f000480)={0x2, 0x4e24, @local}, 0x10) sendto$inet(r0, &(0x7f000100)="f6", 0xffe7, 0xc000, 0x0, 0x0) systematically tr

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Marcin Wojtas
pon., 21 gru 2020 o 20:07 Sasha Levin napisał(a): > > On Mon, Dec 21, 2020 at 10:47:57AM -0800, Jakub Kicinski wrote: > >On Mon, 21 Dec 2020 18:30:32 + Russell King - ARM Linux admin wrote: > >> On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > >> > We need to work with stable

Re: [Aspeed, v1 1/1] net: ftgmac100: Change the order of getting MAC address

2020-12-21 Thread Heiner Kallweit
Am 21.12.2020 um 21:51 schrieb Hongwei Zhang: > Change the order of reading MAC address, try to read it from MAC chip > first, if it's not availabe, then try to read it from device tree. > This commit message leaves a number of questions. It seems the change isn't related at all to the change that

Re: [RFC PATCH v2 1/8] dt-bindings: net: sparx5: Add sparx5-switch bindings

2020-12-21 Thread Rob Herring
On Thu, Dec 17, 2020 at 08:51:27AM +0100, Steen Hegelund wrote: > Document the Sparx5 switch device driver bindings > > Signed-off-by: Steen Hegelund > Signed-off-by: Lars Povlsen > --- > .../bindings/net/microchip,sparx5-switch.yaml | 178 ++ > 1 file changed, 178 insertions(+)

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-21 Thread Florian Fainelli
On 12/18/2020 1:17 PM, Florian Fainelli wrote: >>> SYSTEMPORT Lite does not actually validate the frame length, so setting >>> a maximum number to the buffer size we allocate could work, but I don't >>> see a reason to differentiate the two types of MACs here. >> >> And if th

Re: [Aspeed,ncsi-rx, v2 1/1] net: ftgmac100: Fix AST2600 EVB NCSI RX issue

2020-12-21 Thread Jakub Kicinski
On Mon, 21 Dec 2020 14:40:26 -0500 Hongwei Zhang wrote: > When FTGMAC100 driver is used on other NCSI Ethernet controllers, few When you say NCSI Ethernet controller here you mean the main system NIC, right? The MAC on the NCSI side is FTGMAC100, correct? In that case I'm not sure how user is sup

Re: [PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller

2020-12-21 Thread Jakub Kicinski
On Mon, 21 Dec 2020 19:15:49 + Nick Lowe wrote: > The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) > queues. > It should not be excluded from having this feature enabled. > > Via commit c883de9fd787b6f49bf825f3de3601aeb78a7114 > E1000_MRQC_ENABLE_RSS_4Q was renamed to

Re: [PATCH bpf-next 1/2] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt

2020-12-21 Thread Song Liu
On Thu, Dec 17, 2020 at 9:24 AM Stanislav Fomichev wrote: > > When we attach a bpf program to cgroup/getsockopt any other getsockopt() > syscall starts incurring kzalloc/kfree cost. While, in general, it's > not an issue, sometimes it is, like in the case of TCP_ZEROCOPY_RECEIVE. > TCP_ZEROCOPY_RE

[PATCH v10 bpf-next] bpf/selftests: fold test_current_pid_tgid_new_ns into test_progs.

2020-12-21 Thread Carlos Neira
Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs. This change folds test cases into test_progs. Changes from v9: - Added test in root namespace. - Fixed changed tracepoint from sys_enter to sys_usleep. - Fixed pid, tgid values were inverted. - Used CLONE(2) for namespa

[PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller

2020-12-21 Thread Nick Lowe
The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) queues. It should not be excluded from having this feature enabled. Via commit c883de9fd787b6f49bf825f3de3601aeb78a7114 E1000_MRQC_ENABLE_RSS_4Q was renamed to E1000_MRQC_ENABLE_RSS_MQ to indicate that this is a generic bit f

  1   2   >