[net-next PATCH v2 13/14] net: phy: Introduce fwnode_mdio_find_device()

2020-12-15 Thread Calvin Johnson
Define fwnode_mdio_find_device() to get a pointer to the mdio_device from fwnode passed to the function. Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/mdio/of_mdio.c | 11 +-- drivers/net/phy/phy_device.c | 23 +++ include/linux/phy.h

Re: [RFC PATCH net-next 09/16] net: mscc: ocelot: use "lag" variable name in ocelot_bridge_stp_state_set

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:55+0200, Vladimir Oltean wrote: > In anticipation of further simplification, make it more clear what we're > iterating over. > > Signed-off-by: Vladimir Oltean Reviewed-by: Alexandre Belloni > --- > drivers/net/ethernet/mscc/ocelot.c | 11 +++ > 1 file changed, 7 in

[PATCH net 1/2] docs: networking: packet_mmap: fix formatting for C macros

2020-12-15 Thread Baruch Siach
The citation of macro definitions should appear in a code block. Signed-off-by: Baruch Siach --- Documentation/networking/packet_mmap.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/packet_mmap.rst b/Documentation/networking/packet_mmap.rst index

[PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP

2020-12-15 Thread Baruch Siach
Before commit 889b8f964f2f ("packet: Kill CONFIG_PACKET_MMAP.") there used to be a CONFIG_PACKET_MMAP config symbol that depended on CONFIG_PACKET. The text still refers to PACKET_MMAP as the name of this feature, implying that it can be disabled. Another naming variant is "Packet MMAP". Use "PACK

[net-next PATCH v2 09/14] net/fsl: Use fwnode_mdiobus_register()

2020-12-15 Thread Calvin Johnson
fwnode_mdiobus_register() internally takes care of both DT and ACPI cases to register mdiobus. Replace existing of_mdiobus_register() with fwnode_mdiobus_register(). Note: For both ACPI and DT cases, endianness of MDIO controller need to be specified using "little-endian" property. Signed-off-by:

[net-next PATCH v2 06/14] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

2020-12-15 Thread Calvin Johnson
Introduce fwnode_mdiobus_register_phy() to register PHYs on the mdiobus. From the compatible string, identify whether the PHY is c45 and based on this create a PHY device instance which is registered on the mdiobus. Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/phy/mdio_bus

[net-next PATCH v2 03/14] of: mdio: Refactor of_phy_find_device()

2020-12-15 Thread Calvin Johnson
Refactor of_phy_find_device() to use fwnode_phy_find_device(). Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/mdio/of_mdio.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c index 4daf94

[net-next PATCH v2 07/14] of: mdio: Refactor of_mdiobus_register_phy()

2020-12-15 Thread Calvin Johnson
Refactor of_mdiobus_register_phy() to use fwnode_mdiobus_register_phy(). Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/mdio/of_mdio.c | 43 +++--- include/linux/of_mdio.h| 6 +- 2 files changed, 8 insertions(+), 41 deletions(-) diff

[net-next PATCH v2 04/14] net: phy: Introduce fwnode_get_phy_id()

2020-12-15 Thread Calvin Johnson
Extract phy_id from compatible string. This will be used by fwnode_mdiobus_register_phy() to create phy device using the phy_id. Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/phy/phy_device.c | 21 + include/linux/phy.h | 5 + 2 files chang

[net-next PATCH v2 05/14] of: mdio: Refactor of_get_phy_id()

2020-12-15 Thread Calvin Johnson
With the introduction of fwnode_get_phy_id(), refactor of_get_phy_id() to use fwnode equivalent. Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/mdio/of_mdio.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/mdio/of_mdio.c b/driver

RE: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Parav Pandit
> From: Alexander Duyck > Sent: Tuesday, December 15, 2020 9:47 PM > > On Mon, Dec 14, 2020 at 6:44 PM David Ahern wrote: > > > > On 12/14/20 6:53 PM, Alexander Duyck wrote: > > >> example subfunction usage sequence: > > >> --- > > >> Change device to switchdev

Re: [net-next PATCH v2 10/14] device property: Introduce fwnode_get_id()

2020-12-15 Thread Laurent Pinchart
Hi Calvin, Thank you for the patch. On Tue, Dec 15, 2020 at 10:13:11PM +0530, Calvin Johnson wrote: > Using fwnode_get_id(), get the reg property value for DT node > and get the _ADR object value for ACPI node. > > Signed-off-by: Calvin Johnson > --- > > Changes in v2: None > > drivers/base/

net-next is CLOSED

2020-12-15 Thread Jakub Kicinski
The 5.10 PR went out yesterday, you know the drill. There are a few things (Vladimir's DSA+non-DSA bridging series, mlx5 SF patches, Intel's S0ix fixes, Octeon multi-group RSS, threaded NAPI) which we may include in the Thu PR if there is enough confidence. Any other new feature should be posted a

Re: [PATCH 02/25] dt-bindings: net: dwmac: Extend number of PBL values

2020-12-15 Thread Rob Herring
On Mon, 14 Dec 2020 12:15:52 +0300, Serge Semin wrote: > In accordance with [1] the permitted PBL values can be set as one of > [1, 2, 4, 8, 16, 32]. The rest of the values results in undefined > behavior. At the same time some of the permitted values can be also > invalid depending on the controll

Re: [PATCH 01/25] dt-bindings: net: dwmac: Validate PBL for all IP-cores

2020-12-15 Thread Rob Herring
On Mon, 14 Dec 2020 12:15:51 +0300, Serge Semin wrote: > Indeed the maximum DMA burst length can be programmed not only for DW > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > the property and then ap

[PATCH net] docs: netdev-FAQ: add missing underlines to questions

2020-12-15 Thread Baruch Siach
Signed-off-by: Baruch Siach --- Documentation/networking/netdev-FAQ.rst | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/Documentation/networking/netdev-FAQ.rst b/Documentation/networking/netdev-FAQ.rst index 4b9ed5874d5a..4ef90fe26640 100644 --- a/Document

RE: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Limonciello, Mario
> > Absolutely - I'll ask them to look into this again. > > > we need to explain why on Windows systems required 1s and on Linux > systems up to 2.5s - otherwise it is not reliable approach - you will > encounter others buggy system. > (ME not POR on the Linux systems - is only one possible answer

Re: [PATCH 03/25] dt-bindings: net: dwmac: Fix the TSO property declaration

2020-12-15 Thread Rob Herring
On Mon, Dec 14, 2020 at 12:15:53PM +0300, Serge Semin wrote: > Indeed the STMMAC driver doesn't take the vendor-specific compatible > string into account to parse the "snps,tso" boolean property. It just > makes sure the node is compatible with DW MAC 4.x, 5.x and DW xGMAC > IP-cores. Fix the condi

[PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-15 Thread Youghandhar Chintala
From: Rakesh Pillai Currently in case of target hardware restart ,we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted. Many ath10k wifi chipsets have sequence numbers for the data packets assigned by firmware and

Re: [net-next PATCH v2 02/14] net: phy: Introduce phy related fwnode functions

2020-12-15 Thread Andy Shevchenko
On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson wrote: > > Define fwnode_phy_find_device() to iterate an mdiobus and find the > phy device of the provided phy fwnode. Additionally define > device_phy_find_device() to find phy device of provided device. > > Define fwnode_get_phy_node() to get phy_no

[PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2020-12-15 Thread Youghandhar Chintala
Currently in case of target hardware restart, we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted. Many ath10k wifi chipsets have sequence numbers for the data packets assigned by firmware and the mac sequence numb

[PATCH 1/3] cfg80211: Add wiphy flag to trigger STA disconnect after hardware restart

2020-12-15 Thread Youghandhar Chintala
Many wifi drivers (e.g. ath10k using qualcomm wifi chipsets) support silent target hardware restart/recovery. Out of these drivers which support target hw restart, certain chipsets have the wifi mac sequence number addition for transmitted frames done by the firmware. For such chipsets, a silent ta

[PATCH 3/3] ath10k: Set wiphy flag to trigger sta disconnect on hardware restart

2020-12-15 Thread Youghandhar Chintala
From: Rakesh Pillai Currently after the hardware restart triggered from the driver, the station interface connection remains intact, since a disconnect trigger is not sent to userspace. This can lead to a problem in hardwares where the wifi mac sequence is added by the firmware. After the firmwa

Re: [net-next PATCH v2 04/14] net: phy: Introduce fwnode_get_phy_id()

2020-12-15 Thread Andy Shevchenko
On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson wrote: > > Extract phy_id from compatible string. This will be used by > fwnode_mdiobus_register_phy() to create phy device using the > phy_id. ... > + if (sscanf(cp, "ethernet-phy-id%4x.%4x", &upper, &lower) == 2) { > + *phy_id

[PATCH 1/3] cfg80211: Add wiphy flag to trigger STA disconnect after hardware restart

2020-12-15 Thread Youghandhar Chintala
Many wifi drivers (e.g. ath10k using qualcomm wifi chipsets) support silent target hardware restart/recovery. Out of these drivers which support target hw restart, certain chipsets have the wifi mac sequence number addition for transmitted frames done by the firmware. For such chipsets, a silent ta

Re: [PATCH 06/25] dt-bindings: net: dwmac: Add Tx/Rx clock sources

2020-12-15 Thread Rob Herring
On Mon, 14 Dec 2020 12:15:56 +0300, Serge Semin wrote: > Generic DW *MAC can be connected to an external Tramit and Receive clock > generators. Add the corresponding clocks description and clock-names to > the generic bindings schema so new DW *MAC-based bindings wouldn't declare > its own names of

Re: [net-next PATCH v2 06/14] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

2020-12-15 Thread Andy Shevchenko
On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson wrote: > > Introduce fwnode_mdiobus_register_phy() to register PHYs on the > mdiobus. From the compatible string, identify whether the PHY is > c45 and based on this create a PHY device instance which is > registered on the mdiobus. ... > +int fwnod

Re: [PATCH 06/25] dt-bindings: net: dwmac: Add Tx/Rx clock sources

2020-12-15 Thread Rob Herring
On Mon, Dec 14, 2020 at 12:15:56PM +0300, Serge Semin wrote: > Generic DW *MAC can be connected to an external Tramit and Receive clock s/Tramit/Transmit/ > generators. Add the corresponding clocks description and clock-names to > the generic bindings schema so new DW *MAC-based bindings wouldn't

Re: general protection fault in taprio_dequeue_soft

2020-12-15 Thread syzbot
syzbot has bisected this issue to: commit b5b73b26b3ca34574124ed7ae9c5ba8391a7f176 Author: Vinicius Costa Gomes Date: Thu Sep 10 00:03:11 2020 + taprio: Fix allowing too small intervals bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13c8eadf50 start commit: 7f376f1

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2020-12-15 Thread Felix Fietkau
On 2020-12-15 18:23, Youghandhar Chintala wrote: > Currently in case of target hardware restart, we just reconfig and > re-enable the security keys and enable the network queues to start > data traffic back from where it was interrupted. > > Many ath10k wifi chipsets have sequence numbers for th

[PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-15 Thread Youghandhar Chintala
From: Rakesh Pillai Currently in case of target hardware restart ,we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted. Many ath10k wifi chipsets have sequence numbers for the data packets assigned by firmware and

Re: [PATCH 05/25] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk description

2020-12-15 Thread Rob Herring
On Mon, 14 Dec 2020 12:15:55 +0300, Serge Semin wrote: > Current clocks description doesn't provide a comprehensive notion about > what "stmmaceth" and "pclk" actually represent from the IP-core manual > point of view. The bindings file states: > stmmaceth - "GMAC main clock", > apb - "Peripheral r

Re: [net-next PATCH v2 10/14] device property: Introduce fwnode_get_id()

2020-12-15 Thread Andy Shevchenko
On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson wrote: > > Using fwnode_get_id(), get the reg property value for DT node > and get the _ADR object value for ACPI node. and -> or ... > +/** > + * fwnode_get_id - Get the id of a fwnode. > + * @fwnode: firmware node > + * @id: id of the fwnode > +

Re: [net-next PATCH v2 10/14] device property: Introduce fwnode_get_id()

2020-12-15 Thread Andy Shevchenko
On Tue, Dec 15, 2020 at 7:00 PM Laurent Pinchart wrote: > On Tue, Dec 15, 2020 at 10:13:11PM +0530, Calvin Johnson wrote: > > Using fwnode_get_id(), get the reg property value for DT node > > and get the _ADR object value for ACPI node. ... > > +/** > > + * fwnode_get_id - Get the id of a fwnode

Re: [PATCH 07/25] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

2020-12-15 Thread Rob Herring
On Mon, Dec 14, 2020 at 12:15:57PM +0300, Serge Semin wrote: > Currently the snps,dwmac.yaml DT bindings file is used for both DT nodes > describing generic DW MAC devices and as DT schema with common properties > to be evaluated against a vendor-specific DW MAC IP-cores. Due to such > dual-purpose

Re: [net-next PATCH v2 08/14] net: mdiobus: Introduce fwnode_mdiobus_register()

2020-12-15 Thread Andy Shevchenko
On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson wrote: > > Introduce fwnode_mdiobus_register() to register PHYs on the mdiobus. > If the fwnode is DT node, then call of_mdiobus_register(). > If it is an ACPI node, then: > - disable auto probing of mdiobus > - register mdiobus >

Re: [net-next PATCH v2 09/14] net/fsl: Use fwnode_mdiobus_register()

2020-12-15 Thread Andy Shevchenko
On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson wrote: > > fwnode_mdiobus_register() internally takes care of both DT > and ACPI cases to register mdiobus. Replace existing > of_mdiobus_register() with fwnode_mdiobus_register(). > > Note: For both ACPI and DT cases, endianness of MDIO controller >

Re: [PATCH] net: phy: fix kernel-doc for .config_intr()

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 10:42:40 +0200 Ioana Ciornei wrote: > On Tue, Dec 15, 2020 at 10:37:51AM +0200, Ioana Ciornei wrote: > > From: Ioana Ciornei > > > > Fix the kernel-doc for .config_intr() so that we do not trigger a > > warning like below. > > > > include/linux/phy.h:869: warning: Function pa

Re: [PATCH v5 bpf-next 13/14] bpf: add new frame_length field to the XDP ctx

2020-12-15 Thread Maciej Fijalkowski
On Tue, Dec 15, 2020 at 02:28:39PM +0100, Eelco Chaudron wrote: > > > On 9 Dec 2020, at 13:07, Eelco Chaudron wrote: > > > On 9 Dec 2020, at 12:10, Maciej Fijalkowski wrote: > > > > > > > > > + > > > > > > + ctx_reg = (si->src_reg == si->dst_reg) ? scratch_reg - > > > > > > 1 : > >

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Christophe JAILLET
Le 15/12/2020 à 12:37, Maxime Ripard a écrit : On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: Hi, On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: 'irq_of_parse_and_map()' should be balanced by a

[PATCH v2] selftests/bpf: clarify build error if no vmlinux

2020-12-15 Thread Kamal Mostafa
If Makefile cannot find any of the vmlinux's in its VMLINUX_BTF_PATHS list, it tries to run btftool incorrectly, with VMLINUX_BTF unset: bpftool btf dump file $(VMLINUX_BTF) format c Such that the keyword 'format' is misinterpreted as the path to vmlinux. The resulting build error message is

Re: [stabe-rc 5.9 ] sched: core.c:7270 Illegal context switch in RCU-bh read-side critical section!

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 06:45:31 -0800 Paul E. McKenney wrote: > > Crash log: > > -- > > # selftests: bpf: test_tc_edt.sh > > [ 503.796362] > > [ 503.797960] = > > [ 503.802131] WARNING: suspicious RCU usage > > [ 503.806232] 5.9.15-rc1 #1 Tainted: GW

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-15 Thread Ben Greear
On 12/15/20 9:21 AM, Youghandhar Chintala wrote: From: Rakesh Pillai Currently in case of target hardware restart ,we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted. Are there any known mac80211 radios/drive

Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Neftin, Sasha
On 12/15/2020 19:20, Limonciello, Mario wrote: Absolutely - I'll ask them to look into this again. we need to explain why on Windows systems required 1s and on Linux systems up to 2.5s - otherwise it is not reliable approach - you will encounter others buggy system. (ME not POR on the Linux s

Re: [RFC PATCH 0/7] Share events between metrics

2020-12-15 Thread Andi Kleen
> Or, is the concern more about trying to time-slice the results in a > fairly granular way and expecting accurate results then? Usually the later. It's especially important for divisions. You want both divisor and dividend to be in the same time slice, otherwise the result usually doesn't make a

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Alexander Duyck
On Mon, Dec 14, 2020 at 9:48 PM Parav Pandit wrote: > > > > From: Alexander Duyck > > Sent: Tuesday, December 15, 2020 7:24 AM > > > > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > > wrote: > > > > > > Hi Dave, Jakub, Jason, > > > > > > > Just to clarify a few things for myself. You mention v

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-15 Thread Edward Cree
On 15/12/2020 09:43, Jesper Dangaard Brouer wrote: > On Mon, 14 Dec 2020 17:29:06 -0800 > Ivan Babrou wrote: > >> Without this change the driver tries to allocate too many queues, >> breaching the number of available msi-x interrupts on machines >> with many logical cpus and default adapter setti

Re: [PATCH v8 bpf-next] bpf/selftests: fold test_current_pid_tgid_new_ns into test_progs.

2020-12-15 Thread Andrii Nakryiko
On Mon, Dec 14, 2020 at 10:39 AM Carlos Neira wrote: > > Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs. > This change folds test cases into test_progs. > > Changes from V7: > - Rebased changes. > - Changed function scope. > > Signed-off-by: Carlos Neira > Acked-by: An

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Alexander Duyck
On Mon, Dec 14, 2020 at 10:15 PM Saeed Mahameed wrote: > > On Mon, 2020-12-14 at 17:53 -0800, Alexander Duyck wrote: > > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > > wrote: > > > Hi Dave, Jakub, Jason, > > > > > > This series form Parav was the theme of this mlx5 release cycle, > > > we've

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Maxime Ripard
On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: > Le 15/12/2020 à 12:37, Maxime Ripard a écrit : > > On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > > > On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Mon, Dec 14, 2

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Andrii Nakryiko
On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: > > From: Cong Wang > > This borrows the idea from conntrack and will be used for conntrack in > bpf too. Each element in a timeout map has a user-specified timeout > in secs, after it expires it will be automatically removed from the map. > > The

Re: [Patch bpf-next v2 0/5] bpf: introduce timeout map

2020-12-15 Thread Andrii Nakryiko
On Mon, Dec 14, 2020 at 12:13 PM Cong Wang wrote: > > From: Cong Wang > > This patchset introduces a new bpf hash map which has timeout. It's a bit too short a cover letter for a pretty major new type of hash maps. Please expand on the problem it's trying to solve, how you tested and benchmarked

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Dan Carpenter
On Tue, Dec 15, 2020 at 08:08:15PM +0100, Maxime Ripard wrote: > On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: > > Le 15/12/2020 à 12:37, Maxime Ripard a écrit : > > > On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > > > > On Tue, Dec 15, 2020 at 09:56:55AM +01

Re: [PATCH bpf-next 1/4] bpf: introduce task_vma bpf_iter

2020-12-15 Thread Yonghong Song
On 12/11/20 6:48 PM, Song Liu wrote: Introduce task_vma bpf_iter to print memory information of a process. It can be used to print customized information similar to /proc//maps. task_vma iterator releases mmap_lock before calling the BPF program. Therefore, we cannot pass vm_area_struct direc

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Saeed Mahameed
On Tue, 2020-12-15 at 10:47 -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2020 at 9:48 PM Parav Pandit > wrote: > > > > > From: Alexander Duyck > > > Sent: Tuesday, December 15, 2020 7:24 AM > > > > > > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > > > wrote: > > > > Hi Dave, Jakub, Jason

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko wrote: > > On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: > > > > From: Cong Wang > > > > This borrows the idea from conntrack and will be used for conntrack in > > bpf too. Each element in a timeout map has a user-specified timeout > > in secs

[PATCH v4] lan743x: fix for potential NULL pointer dereference with bare card

2020-12-15 Thread Sergej Bauer
This is the 4th revision of the patch fix for potential null pointer dereference with lan743x card. The simpliest way to reproduce: boot with bare lan743x and issue "ethtool ethN" command where ethN is the interface with lan743x card. Example: $ sudo ethtool eth7 dmesg: [ 103.510336] BUG: kernel

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Christophe JAILLET
Le 15/12/2020 à 20:35, Dan Carpenter a écrit : On Tue, Dec 15, 2020 at 08:08:15PM +0100, Maxime Ripard wrote: On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: Le 15/12/2020 à 12:37, Maxime Ripard a écrit : On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: On Tu

Re: [Patch bpf-next v2 0/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 11:29 AM Andrii Nakryiko wrote: > > On Mon, Dec 14, 2020 at 12:13 PM Cong Wang wrote: > > > > From: Cong Wang > > > > This patchset introduces a new bpf hash map which has timeout. > > It's a bit too short a cover letter for a pretty major new type of > hash maps. Please

Re: [PATCH bpf-next 4/4] selftests/bpf: add test for bpf_iter_task_vma

2020-12-15 Thread Yonghong Song
On 12/11/20 6:48 PM, Song Liu wrote: The test dumps information similar to /proc/pid/maps. The first line of the output is compared against the /proc file to make sure they match. Signed-off-by: Song Liu --- .../selftests/bpf/prog_tests/bpf_iter.c | 106 -- tools/tes

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Saeed Mahameed
On Tue, 2020-12-15 at 11:12 -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2020 at 10:15 PM Saeed Mahameed > wrote: > > On Mon, 2020-12-14 at 17:53 -0800, Alexander Duyck wrote: > > > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > > > wrote: > > > > Hi Dave, Jakub, Jason, > > > > > > > > This

Re: [PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-15 Thread Lorenzo Bianconi
> On Tue, Dec 15, 2020 at 04:06:20PM +0100, Lorenzo Bianconi wrote: > > > On 12/15/20 2:47 PM, Lorenzo Bianconi wrote: > > > [...] > > > > > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > > > > > > index 329397c60d84..61d3f5f8b7f3 100644 > > > > > > --- a/drivers/net/xen-n

Re: [PATCH] atm: horizon: remove h from printk format specifier

2020-12-15 Thread Joe Perches
On Tue, 2020-12-15 at 06:24 -0800, t...@redhat.com wrote: > From: Tom Rix > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. > > Signed-off-by: Tom Rix > --- >  drivers/atm/horizon.c | 6 +++--- Chas? Madge has been out of busine

Re: [PATCH v8 bpf-next] bpf/selftests: fold test_current_pid_tgid_new_ns into test_progs.

2020-12-15 Thread Carlos Antonio Neira Bustos
Andrii, Thank you very much for checking this out!, you were right the test was incorrect. I'll work on your feedback and resend. Thanks! On Tue, Dec 15, 2020 at 11:05:50AM -0800, Andrii Nakryiko wrote: > On Mon, Dec 14, 2020 at 10:39 AM Carlos Neira wrote: > > > > Currently tests for bpf_get_

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread David Ahern
On 12/14/20 10:48 PM, Parav Pandit wrote: > >> From: Alexander Duyck >> Sent: Tuesday, December 15, 2020 7:24 AM >> >> On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed >> wrote: >>> >>> Hi Dave, Jakub, Jason, >>> >> >> Just to clarify a few things for myself. You mention virtualization and >> SR-

Re: [PATCH bpf-next 4/4] selftests/bpf: add test for bpf_iter_task_vma

2020-12-15 Thread Song Liu
> On Dec 15, 2020, at 12:21 PM, Yonghong Song wrote: > > > > On 12/11/20 6:48 PM, Song Liu wrote: >> The test dumps information similar to /proc/pid/maps. The first line of >> the output is compared against the /proc file to make sure they match. >> Signed-off-by: Song Liu >> --- >> .../se

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Jason Gunthorpe
On Tue, Dec 15, 2020 at 10:47:36AM -0800, Alexander Duyck wrote: > > Jason and Saeed explained this in great detail few weeks back in v0 version > > of the patchset at [1], [2] and [3]. > > I better not repeat all of it here again. Please go through it. > > If you may want to read precursor to it

[PATCH net-next 2/4] enetc: don't use macro magic for the readx_poll_timeout() callback

2020-12-15 Thread Michael Walle
The macro enetc_mdio_rd_reg() is just used in that particular case and has a hardcoded parameter name "mdio_priv". Define a specific function to use for readx_poll_timeout() instead. Also drop the TIMEOUT macro since it is used just once. Signed-off-by: Michael Walle --- drivers/net/ethernet/fre

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 12:35:20 -0800 Saeed Mahameed wrote: > > I think the big thing we really should do if we are going to go this > > route is to look at standardizing what the flavours are that get > > created by the parent netdevice. Otherwise we are just creating the > > same mess we had with SR

Re: [GIT PULL] Networking updates for 5.11

2020-12-15 Thread pr-tracker-bot
The pull request you sent on Mon, 14 Dec 2020 23:28:50 -0800: > https://lore.kernel.org/linux-next/20201126162248.7e796...@canb.auug.org.au/ > mm has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d635a69dd4981cc51f90293f5f64268620ed1565 Thank you! -- Deet-doot-dot, I

Re: [PATCH net-next] bonding: correct rr balancing during link failure

2020-12-15 Thread Lars Everbrand
On Sat, Dec 05, 2020 at 11:45:13AM -0800, Jakub Kicinski wrote: > Thanks for the patch! Kind words for my first attempt at this. Sorry for answering a bit late, proton-bridge is not my best friend lately. > > Looking at the code in question it feels a little like we're breaking > abstractions if w

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Alexander Duyck
On Tue, Dec 15, 2020 at 12:35 PM Saeed Mahameed wrote: > > On Tue, 2020-12-15 at 11:12 -0800, Alexander Duyck wrote: > > On Mon, Dec 14, 2020 at 10:15 PM Saeed Mahameed > > wrote: > > > On Mon, 2020-12-14 at 17:53 -0800, Alexander Duyck wrote: > > > > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahamee

[PATCH net-next 3/4] enetc: drop MDIO_DATA() macro

2020-12-15 Thread Michael Walle
value is u16, masking with 0x is a nop. Drop it. Signed-off-by: Michael Walle --- drivers/net/ethernet/freescale/enetc/enetc_mdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_mdio.c b/drivers/net/ethernet/freescale/enetc/

[PATCH net-next 4/4] enetc: reorder macros and functions

2020-12-15 Thread Michael Walle
Now that there aren't any more macros with parameters, move the macros above any functions. Signed-off-by: Michael Walle --- .../net/ethernet/freescale/enetc/enetc_mdio.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/freescale/enet

[PATCH net-next 0/4] enetc: code cleanups

2020-12-15 Thread Michael Walle
This are some code cleanups in the MDIO part of the enetc. They are intended to make the code more readable. Michael Walle (4): enetc: drop unneeded indirection enetc: don't use macro magic for the readx_poll_timeout() callback enetc: drop MDIO_DATA() macro enetc: reorder macros and functi

Re: [PATCH net-next] bonding: correct rr balancing during link failure

2020-12-15 Thread Lars Everbrand
On Tue, Dec 08, 2020 at 01:46:09PM -0800, Jay Vosburgh wrote: > > Jakub Kicinski wrote: > > >On Wed, 02 Dec 2020 20:55:57 + Lars Everbrand wrote: > Are these bandwidth numbers from observation of the actual > behavior? I'm not sure the real system would behave this way; my > suspicion

[PATCH net-next 1/4] enetc: drop unneeded indirection

2020-12-15 Thread Michael Walle
Before commit 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl") these macros actually had some benefits. But after the commit it just makes the code hard to read. Drop the macro indirections. Signed-off-by: Michael Walle --- .../net/ethernet/freescale/enetc

Re: [PATCH iproute2] ss: mptcp: fix add_addr_accepted stat print

2020-12-15 Thread Stephen Hemminger
On Wed, 18 Nov 2020 15:24:18 +0100 Andrea Claudi wrote: > add_addr_accepted value is not printed if add_addr_signal value is 0. > Fix this properly looking for add_addr_accepted value, instead. > > Fixes: 9c3be2c0eee01 ("ss: mptcp: add msk diag interface support") > Signed-off-by: Andrea Claudi

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Andrii Nakryiko
On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: > > On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko > wrote: > > > > On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: > > > > > > From: Cong Wang > > > > > > This borrows the idea from conntrack and will be used for conntrack in > > > bpf too.

Re: [PATCH] samples/bpf/Makefile: Create tools/testing/selftests/bpf dir

2020-12-15 Thread Andrii Nakryiko
On Mon, Dec 14, 2020 at 2:57 AM Hui Zhu wrote: > > From: Hui Zhu > > Got an error when I built samples/bpf in a separate directory: > make O=../bk/ defconfig > make -j64 bzImage > make headers_install > make V=1 M=samples/bpf > ... > ... > make -C /home/teawater/kernel/linux/samples/bpf/../..//to

Re: [PATCH iproute2-next] tc/htb: Hierarchical QoS hardware offload

2020-12-15 Thread Stephen Hemminger
On Tue, 15 Dec 2020 09:42:08 +0200 Maxim Mikityanskiy wrote: > + print_uint(PRINT_ANY, "offload", " offload %d", !!tb[TCA_HTB_OFFLOAD]); This is not the best way to represent a boolean flag in JSON. Also it breaks the "output should be the same as command line" mantra. My preference is jso

one prog multi fentry. Was: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-15 Thread Alexei Starovoitov
On Wed, Dec 09, 2020 at 11:21:43PM +, Alan Maguire wrote: Right, that's exactly it. A pair of generic tracing BPF programs are used, and they attach to kprobe/kretprobes, and when they run they use the arguments plus the map details about BTF ids of those arguments to run bpf_snprintf_btf()

Re: [PATCH net-next V8] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-12-15 Thread David Miller
From: Dmytro Shytyi Date: Wed, 09 Dec 2020 04:27:54 +0100 > Variable SLAAC [Can be activated via sysctl]: > SLAAC with prefixes of arbitrary length in PIO (randomly > generated hostID or stable privacy + privacy extensions). > The main problem is that SLAAC RA or PD allocates a /64 by the Wirele

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Daniel Borkmann
On 12/15/20 11:03 PM, Andrii Nakryiko wrote: On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko wrote: On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: From: Cong Wang This borrows the idea from conntrack and will be used for conntrack i

Re: [net-next v5 03/15] devlink: Introduce PCI SF port flavour and port attribute

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 01:03:46 -0800 Saeed Mahameed wrote: > + * devlink_port_attrs_pci_sf_set - Set PCI SF port attributes > + * > + * @devlink_port: devlink port > + * @controller: associated controller number for the devlink port instance > + * @pf: associated PF for the devlink port insta

[PATCH v2 bpf-next 0/4] introduce bpf_iter for task_vma

2020-12-15 Thread Song Liu
This set introduces bpf_iter for task_vma, which can be used to generate information similar to /proc/pid/maps or /proc/pid/smaps. Patch 4/4 adds an example that mimics /proc/pid/maps. Changes v1 => v2: 1. Small fixes in task_iter.c and the selftests. (Yonghong) Song Liu (4): bpf: introduce t

[PATCH v2 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2020-12-15 Thread Song Liu
Introduce task_vma bpf_iter to print memory information of a process. It can be used to print customized information similar to /proc//maps. task_vma iterator releases mmap_lock before calling the BPF program. Therefore, we cannot pass vm_area_struct directly to the BPF program. A new __vm_area_st

[PATCH v2 bpf-next 2/4] bpf: allow bpf_d_path in sleepable bpf_iter program

2020-12-15 Thread Song Liu
task_file and task_vma iter programs have access to file->f_path. Enable bpf_d_path to print paths of these file. bpf_iter programs are generally called in sleepable context. However, it is still necessary to diffientiate sleepable and non-sleepable bpf_iter programs: sleepable programs have acces

Re: [PATCH v4] lan743x: fix for potential NULL pointer dereference with bare card

2020-12-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Tue, 15 Dec 2020 19:12:45 +0300 you wrote: > This is the 4th revision of the patch fix for potential null pointer > dereference > with lan743x card. > > The simpliest way to reproduce: boot with bare lan743x and issue "ethtool

[PATCH v2 bpf-next 3/4] libbpf: introduce section "iter.s/" for sleepable bpf_iter program

2020-12-15 Thread Song Liu
Sleepable iterator program have access to helper functions like bpf_d_path. Signed-off-by: Song Liu --- tools/lib/bpf/libbpf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 6ae748f6ea118..12ad4593a91cb 100644 --- a/tools/lib/bpf/li

[PATCH v2 bpf-next 4/4] selftests/bpf: add test for bpf_iter_task_vma

2020-12-15 Thread Song Liu
The test dumps information similar to /proc/pid/maps. The first line of the output is compared against the /proc file to make sure they match. Signed-off-by: Song Liu --- .../selftests/bpf/prog_tests/bpf_iter.c | 106 -- tools/testing/selftests/bpf/progs/bpf_iter.h | 9 +

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-15 Thread Bjorn Helgaas
On Tue, Dec 15, 2020 at 02:09:12PM +0100, Ian Kumlien wrote: > On Tue, Dec 15, 2020 at 1:40 AM Bjorn Helgaas wrote: > > > > On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kumlien wrote: > > > On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > > > > > If you're interested, you could probably

Re: [MPTCP][PATCH net-next] mptcp: clear use_ack and use_map when dropping other suboptions

2020-12-15 Thread Mat Martineau
On Tue, 15 Dec 2020, Geliang Tang wrote: This patch cleared use_ack and use_map when dropping other suboptions to fix the following syzkaller BUG: [ 15.223006] BUG: unable to handle page fault for address: 00223b10 [ 15.223700] #PF: supervisor read access in kernel mode [ 15.224

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 2:08 PM Andrii Nakryiko wrote: > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: > > > > On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko > > wrote: > > > > > > On Mon, Dec 14, 2020 at 12:17 PM Cong Wang > > > wrote: > > > > > > > > From: Cong Wang > > > > > > > >

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Jason Gunthorpe
On Tue, Dec 15, 2020 at 01:41:04PM -0800, Alexander Duyck wrote: > > not just devlink and switchdev, auxbus was also introduced to > > standardize some of the interfaces. > > The auxbus is just there to make up for the fact that there isn't > another bus type for this though. I would imagine othe

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 3:23 PM Daniel Borkmann wrote: > > On 12/15/20 11:03 PM, Andrii Nakryiko wrote: > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: > >> > >> On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko > >> wrote: > >>> > >>> On Mon, Dec 14, 2020 at 12:17 PM Cong Wang > >>> wrot

Re: [net-next v5 04/15] devlink: Support add and delete devlink port

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 01:03:47 -0800 Saeed Mahameed wrote: > From: Parav Pandit > > Extended devlink interface for the user to add and delete port. > Extend devlink to connect user requests to driver to add/delete > such port in the device. > > When driver routines are invoked, devlink instance lo

Re: [net-next v5 05/15] devlink: Support get and set state of port function

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 01:03:48 -0800 Saeed Mahameed wrote: > From: Parav Pandit > > devlink port function can be in active or inactive state. > Allow users to get and set port function's state. > > When the port function it activated, its operational state may change > after a while when the devic

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-15 Thread Lukasz Stelmach
It was <2020-12-04 pią 19:37>, when Jakub Kicinski wrote: > On Wed, 2 Dec 2020 22:47:09 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> Before we

Re: [net-next v5 07/15] net/mlx5: SF, Add auxiliary device support

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 01:03:50 -0800 Saeed Mahameed wrote: > +static ssize_t sfnum_show(struct device *dev, struct device_attribute *attr, > char *buf) > +{ > + struct auxiliary_device *adev = container_of(dev, struct > auxiliary_device, dev); > + struct mlx5_sf_dev *sf_dev = container_of(a

<    1   2   3   >