> From: Alexander Duyck <alexander.du...@gmail.com> > Sent: Tuesday, December 15, 2020 9:47 PM > > On Mon, Dec 14, 2020 at 6:44 PM David Ahern <dsah...@gmail.com> wrote: > > > > On 12/14/20 6:53 PM, Alexander Duyck wrote: > > >> example subfunction usage sequence: > > >> ----------------------------------- > > >> Change device to switchdev mode: > > >> $ devlink dev eswitch set pci/0000:06:00.0 mode switchdev > > >> > > >> Add a devlink port of subfunction flaovur: > > >> $ devlink port add pci/0000:06:00.0 flavour pcisf pfnum 0 sfnum 88 > > > > > > Typo in your description. Also I don't know if you want to stick > > > with "flavour" or just shorten it to the U.S. spelling which is "flavor". > > > > The term exists in devlink today (since 2018). When support was added > > to > > iproute2 I decided there was no reason to require the US spelling over > > the British spelling, so I accepted the patch. > > Okay. The only reason why I noticed is because "flaovur" is definitely a wrong > spelling. If it is already in the interface then no need to change it. I am using to write "flavor" and I realized that I should probably say "flavour" because in devlink it is that way. So I added 'u' and typo added it at wrong location. :-) Thanks for catching it. Saeed sent the v5 fixing this along with few more English corrections.
- [net-next v4 10/15] net/mlx5: E-switch, Add eswitch helper... Saeed Mahameed
- [net-next v4 01/15] net/mlx5: Fix compilation warning for ... Saeed Mahameed
- Re: [net-next v4 01/15] net/mlx5: Fix compilation war... Alexander Duyck
- Re: [net-next v4 01/15] net/mlx5: Fix compilation... Saeed Mahameed
- Re: [net-next v4 01/15] net/mlx5: Fix compilation... Leon Romanovsky
- [net-next v4 03/15] devlink: Introduce PCI SF port flavour... Saeed Mahameed
- [net-next v4 02/15] devlink: Prepare code to fill multiple... Saeed Mahameed
- Re: [net-next v4 00/15] Add mlx5 subfunction support Alexander Duyck
- Re: [net-next v4 00/15] Add mlx5 subfunction support David Ahern
- Re: [net-next v4 00/15] Add mlx5 subfunction supp... Alexander Duyck
- RE: [net-next v4 00/15] Add mlx5 subfunction ... Parav Pandit
- RE: [net-next v4 00/15] Add mlx5 subfunction support Parav Pandit
- Re: [net-next v4 00/15] Add mlx5 subfunction supp... Alexander Duyck
- Re: [net-next v4 00/15] Add mlx5 subfunction ... Saeed Mahameed
- Re: [net-next v4 00/15] Add mlx5 subfunction ... Jason Gunthorpe
- Re: [net-next v4 00/15] Add mlx5 subfunction ... Edwin Peer
- Re: [net-next v4 00/15] Add mlx5 subfunct... Jason Gunthorpe
- Re: [net-next v4 00/15] Add mlx5 subfunct... Alexander Duyck
- Re: [net-next v4 00/15] Add mlx5 subfunction supp... David Ahern
- Re: [net-next v4 00/15] Add mlx5 subfunction support Saeed Mahameed
- Re: [net-next v4 00/15] Add mlx5 subfunction supp... Alexander Duyck