[net-next v4 00/15] Add mlx5 subfunction support

2020-12-14 Thread Saeed Mahameed
Hi Dave, Jakub, Jason, This series form Parav was the theme of this mlx5 release cycle, we've been waiting anxiously for the auxbus infrastructure to make it into the kernel, and now as the auxbus is in and all the stars are aligned, I can finally submit this V2 of the devlink and mlx5 subfunction

[net-next v4 09/15] net/mlx5: E-switch, Prepare eswitch to handle SF vport

2020-12-14 Thread Saeed Mahameed
From: Vu Pham Prepare eswitch to handle SF vport during (a) querying eswitch functions (b) egress ACL creation (c) account for SF vports in total vports calculation Assign a dedicated placeholder for SFs vports and their representors. They are placed after VFs vports and before ECPF vports as be

[net-next v4 05/15] devlink: Support get and set state of port function

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit devlink port function can be in active or inactive state. Allow users to get and set port function's state. When the port function it activated, its operational state may change after a while when the device is created and driver binds to it. Similarly on deactivation flow. T

[net-next v4 07/15] net/mlx5: SF, Add auxiliary device support

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Introduce API to add and delete an auxiliary device for an SF. Each SF has its own dedicated window in the PCI BAR 2. SF device is similar to PCI PF and VF that supports multiple class of devices such as net, rdma and vdpa. SF device will be added or removed in subsequent pat

[net-next v4 08/15] net/mlx5: SF, Add auxiliary device driver

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Add auxiliary device driver for mlx5 subfunction auxiliary device. A mlx5 subfunction is similar to PCI PF and VF. For a subfunction an auxiliary device is created. As a result, when mlx5 SF auxiliary device binds to the driver, its netdev and rdma device are created, they ap

[net-next v4 11/15] net/mlx5: SF, Add port add delete functionality

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit To handle SF port management outside of the eswitch as independent software layer, introduce eswitch notifier APIs so that upper layer who wish to support sf port management in switchdev mode can perform its task whenever eswitch mode is set to switchdev or before eswitch is di

[net-next v4 13/15] devlink: Add devlink port documentation

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Added documentation for devlink port and port function related commands. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Jacob Keller Signed-off-by: Saeed Mahameed --- .../networking/devlink/devlink-port.rst | 118 ++ Documentation/n

[net-next v4 14/15] devlink: Extend devlink port documentation for subfunctions

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Add devlink port documentation for subfunction management. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- Documentation/driver-api/auxiliary_bus.rst| 2 + .../networking/devlink/devlink-port.rst | 89 ++- 2 files changed, 87 inserti

[net-next v4 15/15] net/mlx5: Add devlink subfunction port documentation

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Add documentation for subfunction management using devlink port. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../device_drivers/ethernet/mellanox/mlx5.rst | 204 ++ 1 file changed, 204 insertions(+) diff --git a/Documentation/networking/de

[net-next v4 06/15] net/mlx5: Introduce vhca state event notifier

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit vhca state events indicates change in the state of the vhca that may occur due to a SF allocation, deallocation or enabling/disabling the SF HCA. Introduce vhca state event handler which will be used by SF devlink port manager and SF hardware id allocator in subsequent patches

[net-next v4 12/15] net/mlx5: SF, Port function state change support

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Support changing the state of the SF port's function through devlink. When activating the SF port's function, enable the hca in the device followed by adding its auxiliary device. When deactivating the SF port's function, delete its auxiliary device followed by disabling the vH

[net-next v4 10/15] net/mlx5: E-switch, Add eswitch helpers for SF vport

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Add helpers to enable/disable eswitch port, register its devlink port and load its representor. Signed-off-by: Vu Pham Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/esw/devlink_port.c | 41 +

[net-next v4 01/15] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field. Defining an enum for such bit fields on 32-bit platform results in below warning. ./include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] ^ ./include/li

[net-next v4 03/15] devlink: Introduce PCI SF port flavour and port attribute

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit A PCI sub-function (SF) represents a portion of the device similar to PCI VF. In an eswitch, PCI SF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with SF, and its representor netdevice, int

[net-next v4 02/15] devlink: Prepare code to fill multiple port function attributes

2020-12-14 Thread Saeed Mahameed
From: Parav Pandit Prepare code to fill zero or more port function optional attributes. Subsequent patch makes use of this to fill more port function attributes. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- net/core/devlink.c | 6

[PATCH v2 net-next] net: phy: mchp: Add 1588 support for LAN8814 Quad PHY

2020-12-14 Thread Divya Koppera
This patch add supports for 1588 Hardware Timestamping support to LAN8814 Quad Phy. It supports L2 and Ipv4 encapsulations. Signed-off-by: Divya Koppera --- v1 -> v2 * Fixed warnings Reported-by: kernel test robot --- drivers/net/phy/micrel.c | 1054 +- 1 fi

Re: [net-next v4 01/15] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-14 Thread Alexander Duyck
On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed wrote: > > From: Parav Pandit > > MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field. > > Defining an enum for such bit fields on 32-bit platform results in below > warning. > > ./include/vdso/bits.h:7:26: warning: left shift count >= width of

Re: [PATCH bpf-next 1/4] bpf: introduce task_vma bpf_iter

2020-12-14 Thread Song Liu
> On Dec 13, 2020, at 11:13 PM, Yonghong Song wrote: > > > > On 12/11/20 6:48 PM, Song Liu wrote: >> Introduce task_vma bpf_iter to print memory information of a process. It >> can be used to print customized information similar to /proc//maps. >> task_vma iterator releases mmap_lock before

[PATCH][next] selftests/bpf: fix spelling mistake "tranmission" -> "transmission"

2020-12-14 Thread Colin King
From: Colin Ian King There are two spelling mistakes in output messages. Fix these. Signed-off-by: Colin Ian King --- tools/testing/selftests/bpf/xdpxceiver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selft

Re: [net-next v4 01/15] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-14 Thread Saeed Mahameed
On Mon, 2020-12-14 at 14:31 -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed > wrote: > > From: Parav Pandit > > > > MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field. > > > > Defining an enum for such bit fields on 32-bit platform results in > > below > > w

Re: [PATCH] net: mscc: ocelot: Fix a resource leak in the error handling path of the probe function

2020-12-14 Thread Alexandre Belloni
On 13/12/2020 12:48:38+0100, Christophe JAILLET wrote: > In case of error after calling 'ocelot_init()', it must be undone by a > corresponding 'ocelot_deinit()' call, as already done in the remove > function. > > Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") > Signed-off-by

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > On Mon, Dec 14, 2020 at 04:47:32PM +0100, Ian Kumlien wrote: > > On Mon, Dec 14, 2020 at 3:02 PM Bjorn Helgaas wrote: > > > On Mon, Dec 14, 2020 at 10:14:18AM +0100, Ian Kumlien wrote: > > > > On Mon, Dec 14, 2020 at 6:44 AM Bjorn Helgaas

Re: [net-next PATCH v12 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-12-14 Thread Rob Herring
On Fri, 11 Dec 2020 22:46:04 +1000, Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH v2 net-next] net: phy: mchp: Add 1588 support for LAN8814 Quad PHY

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 23:26:58 +0530 Divya Koppera wrote: > This patch add supports for 1588 Hardware Timestamping support > to LAN8814 Quad Phy. It supports L2 and Ipv4 encapsulations. > > Signed-off-by: Divya Koppera > --- > v1 -> v2 > * Fixed warnings > Reported-by: kernel test robot Still do

Re: [PATCH net-next v2 3/3] use __netdev_notify_peers in hyperv

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 15:19:30 -0600 Lijun Pan wrote: > Start to use the lockless version of netdev_notify_peers. > Call the helper where notify variable used to be set true. > Remove the notify bool variable and sort the variables > in reverse Christmas tree order. > > Cc: Haiyang Zhang > Signed-o

[PATCH][next] ath11k: add missing null check on allocated skb

2020-12-14 Thread Colin King
From: Colin Ian King Currently the null check on a newly allocated skb is missing and this can lead to a null pointer dereference is the allocation fails. Fix this by adding a null check and returning -ENOMEM. Addresses-Coverity: ("Dereference null return") Fixes: 43ed15e1ee01 ("ath11k: put hw t

[PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-14 Thread Colin King
From: Colin Ian King The intention of the err_expr cleanup path is to iterate over the allocated expr_array objects and free them, starting from i - 1 and working down to the start of the array. Currently the loop counter is being incremented instead of decremented and also the index i is being u

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 11:30:08 +0100 Vasyl Gomonovych wrote: > It is fix for semantic patch warning available in > scripts/coccinelle/misc/boolinit.cocci > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable > Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable > > Signed

[PATCH][next] net: hns3: fix expression that is currently always true

2020-12-14 Thread Colin King
From: Colin Ian King The || condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE || hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because hdev->fd_active_type cannot be equal to two different values at the same time. The expression is always true which is not correct. Fix t

Re: [net-next 2/2] tcp: Add receive timestamp support for receive zerocopy.

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 10:44:19 -0800 Arjun Roy wrote: > From: Arjun Roy > > tcp_recvmsg() uses the CMSG mechanism to receive control information > like packet receive timestamps. This patch adds CMSG fields to > struct tcp_zerocopy_receive, and provides receive timestamps > if available to the user

Re: [net-next 0/2] Adds CMSG+rx timestamps to TCP rx. zerocopy

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 10:44:17 -0800 Arjun Roy wrote: > From: Arjun Roy > > This patch series provides CMSG and receive timestamp support to TCP > receive zerocopy. Patch 1 refactors CMSG pending state for > tcp_recvmsg() to avoid the use of magic numbers; patch 2 implements > receive timestamp via

Re: [PATCH] devlink: use _BITUL() macro instead of BIT() in the UAPI header

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 12:21:57 +0100 Tobias Klauser wrote: > The BIT() macro is not available for the UAPI headers. Moreover, it can > be defined differently in user space headers. Thus, replace its usage > with the _BITUL() macro which is already used in other macro definitions > in . > > Fixes: dc

Re: [PATCH][c89] wrong usage of compiler constants

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 16:30:01 + sylvain.bertr...@legeek.net wrote: > From: Sylvain BERTRAND > > Using a c89 compiler fails due some wrong usage of compiler constants. Are you saying it fails on some known compilers in the code you're fixing? We have a strong preference to ask contributors to

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Bjorn Helgaas
On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kumlien wrote: > On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > If you're interested, you could probably unload the Realtek drivers, > > remove the devices, and set the PCI_EXP_LNKCTL_LD (Link Disable) bit > > in 02:04.0, e.g., > > > > # R

Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Vincent Stehlé
On Mon, Dec 14, 2020 at 11:03:12AM +0100, Julian Wiedmann wrote: > On 13.12.20 18:20, Vincent Stehlé wrote: ... > > @@ -216,7 +216,6 @@ static int korina_send_packet(struct sk_buff *skb, > > struct net_device *dev) > > netif_stop_queue(dev); > > else { > >

[PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-14 Thread Ivan Babrou
Without this change the driver tries to allocate too many queues, breaching the number of available msi-x interrupts on machines with many logical cpus and default adapter settings: Insufficient resources for 12 XDP event queues (24 other channels, max 32) Which in turn triggers EINVAL on XDP pro

Re: [PATCH] net: mhi: Fix unexpected queue wake

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 10 Dec 2020 12:25:07 +0100 you wrote: > This patch checks that MHI queue is not full before waking up the net > queue. This fix sporadic MHI queueing issues in xmit. Indeed xmit and > its symmetric complete callback

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Roman Gushchin
On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > Hi all, > > On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the akpm-current tree got conflicts in: > > > > include/linux/memcontrol.h > > mm/memcontrol.c > > > > between com

Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Vincent Stehlé
On Mon, Dec 14, 2020 at 01:08:32PM -0800, Jakub Kicinski wrote: > On Mon, 14 Dec 2020 11:03:12 +0100 Julian Wiedmann wrote: > > > diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c > > > index bf48f0ded9c7d..9d84191de6824 100644 > > > --- a/drivers/net/ethernet/korina.c > >

Re: [PATCH][next] net: hns3: fix expression that is currently always true

2020-12-14 Thread Huazhong Tan
On 2020/12/15 8:00, Colin King wrote: From: Colin Ian King The || condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE || hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because hdev->fd_active_type cannot be equal to two different values at the same time. The expression i

Re: [PATCH] selftests/bpf: clarify build error if no vmlinux

2020-12-14 Thread Andrii Nakryiko
On Mon, Dec 14, 2020 at 12:21 PM Kamal Mostafa wrote: > > If Makefile cannot find any of the vmlinux's in its VMLINUX_BTF_PATHS list, > it tries to run btftool incorrectly, with VMLINUX_BTF unset: > > bpftool btf dump file $(VMLINUX_BTF) format c > > Such that the keyword 'format' is misinterp

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Andrew Morton
On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > Hi all, > > > > On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell > > wrote: > > > > > > Today's linux-next merge of the akpm-current tree got conflicts in: > > >

[PATCH net 0/2] fixes for vhost_net

2020-12-14 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for vhost_net. Yunjian Wang (2): vhost_net: fix ubuf refcount incorrectly when sendmsg fails vhost_net: fix high cpu load when sendmsg fails drivers/vhost/net.c | 27 --- 1 file changed, 12 insertions(+), 15 d

[PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-14 Thread wangyunjian
From: Yunjian Wang Currently the vhost_zerocopy_callback() maybe be called to decrease the refcount when sendmsg fails in tun. The error handling in vhost handle_tx_zerocopy() will try to decrease the same refcount again. This is wrong. To fix this issue, we only call vhost_net_ubuf_put() when vq

[PATCH net 2/2] vhost_net: fix high cpu load when sendmsg fails

2020-12-14 Thread wangyunjian
From: Yunjian Wang Currently we break the loop and wake up the vhost_worker when sendmsg fails. When the worker wakes up again, we'll meet the same error. This will cause high CPU load. To fix this issue, we can skip this description by ignoring the error. When we exceeds sndbuf, the return value

Re: [PATCH] bpf,x64: pad NOPs to make images converge more easily

2020-12-14 Thread Gary Lin
On Mon, Dec 14, 2020 at 04:31:44PM +0100, Daniel Borkmann wrote: > On 12/14/20 9:15 AM, Gary Lin wrote: > > On Mon, Dec 14, 2020 at 11:56:22AM +0800, Gary Lin wrote: > > > On Fri, Dec 11, 2020 at 09:05:05PM +0100, Daniel Borkmann wrote: > > > > On 12/11/20 9:19 AM, Gary Lin wrote: > > > > > The x64

Re: [PATCHv2] selftests: test_vxlan_under_vrf: mute unnecessary error message

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 11 Dec 2020 12:24:20 +0800 you wrote: > The cleanup function in this script that tries to delete hv-1 / hv-2 > vm-1 / vm-2 netns will generate some uncessary error messages: > > Cannot remove namespace file "/run/netn

Re: [PATCH net-next 0/9] mptcp: Another set of miscellaneous MPTCP fixes

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 10 Dec 2020 14:24:57 -0800 you wrote: > This is another collection of MPTCP fixes and enhancements that we have > tested in the MPTCP tree: > > Patch 1 cleans up cgroup attachment for in-kernel subflow sockets. > >

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-14 Thread Alexander Duyck
On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed wrote: > > Hi Dave, Jakub, Jason, > > This series form Parav was the theme of this mlx5 release cycle, > we've been waiting anxiously for the auxbus infrastructure to make it into > the kernel, and now as the auxbus is in and all the stars are aligned

Re: [PATCH net-next] net/mediatek: simplify the mediatek code return expression

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 16:38:01 +0800 you wrote: > Simplify the return expression at mtk_eth_path.c file, simplify this all. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/ethernet/mediatek/mtk_eth_path.c | 16 ---

Re: [PATCHv6 net-next 0/3] Add devlink and devlink health reporters to

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 11:55:23 +0530 you wrote: > Add basic devlink and devlink health reporters. > Devlink health reporters are added for NPA block. > > Address Jakub's comment to add devlink support for error reporting. >

Re: [PATCH v2 net-next] ice, xsk: Move Rx allocation out of while-loop

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 09:54:10 +0100 you wrote: > From: Björn Töpel > > Instead doing the check for allocation in each loop, move it outside > the while loop and do it every NAPI loop. > > This change boosts the xdpsock rx

[PATCH] net: core: fix msleep() is not accurate

2020-12-14 Thread Yejune Deng
See Documentation/timers/timers-howto.rst, msleep() is not for (1ms - 20ms), use usleep_range() instead. Signed-off-by: Yejune Deng --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index d33099f..c0aa52f 100644 --- a/net/c

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 17:40:21 -0800 Andrew Morton wrote: > On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > > On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell > > > wrote: > > > > Today's linux-next merge of t

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-14 Thread Jakub Kicinski
On Sun, 13 Dec 2020 21:59:45 +0800 Cambda Zhu wrote: > > On Dec 13, 2020, at 06:32, Jakub Kicinski wrote: > > On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > >> For each TCP zero window probe, the icsk_backoff is increased by one and > >> its max value is tcp_retries2. If tcp_retries2 is

Re: pull-request: bpf-next 2020-12-14

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 22:43:16 +0100 Daniel Borkmann wrote: > 1) Expose bpf_sk_storage_*() helpers to iterator programs, from Florent > Revest. > > 2) Add AF_XDP selftests based on veth devs to BPF selftests, from Weqaar > Janjua. > > 3) Support for finding BTF based kernel attach targets through

Re: [PATCH net-next 00/10] Netfilter/IPVS updates for net-next

2020-12-14 Thread Jakub Kicinski
On Sun, 13 Dec 2020 00:05:03 +0100 Pablo Neira Ayuso wrote: > 1) Missing dependencies in NFT_BRIDGE_REJECT, from Randy Dunlap. > > 2) Use atomic_inc_return() instead of atomic_add_return() in IPVS, >from Yejune Deng. > > 3) Simplify check for overquota in xt_nfacct, from Kaixu Xia. > > 4) Mo

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Andrew Morton
On Mon, 14 Dec 2020 18:06:29 -0800 Jakub Kicinski wrote: > On Mon, 14 Dec 2020 17:40:21 -0800 Andrew Morton wrote: > > On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > > > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > > > On Fri, 4 Dec 2020 20:20:05 +1100 Step

Re: [PATCH net v2] net: openvswitch: fix TTL decrement exception action execution

2020-12-14 Thread Jakub Kicinski
On Mon, 7 Dec 2020 05:08:39 -0500 Eelco Chaudron wrote: > Currently, the exception actions are not processed correctly as the wrong > dataset is passed. This change fixes this, including the misleading > comment. > > In addition, a check was added to make sure we work on an IPv4 packet, > and not

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 18:11:21 -0800 Andrew Morton wrote: > On Mon, 14 Dec 2020 18:06:29 -0800 Jakub Kicinski wrote: > > Hm. The code is in net-next by now. I was thinking of sending the > > Networking PR later today (tonight?) as well. I'm happy to hold off > > or do whatever you require, but I'd

[PATCH v2] net: korina: fix return value

2020-12-14 Thread Vincent Stehlé
The ndo_start_xmit() method must not attempt to free the skb to transmit when returning NETDEV_TX_BUSY. Therefore, make sure the korina_send_packet() function returns NETDEV_TX_OK when it frees a packet. Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") Suggested-by: Jakub

Re: [PATCH net-next v2] net: dsa: mv88e6xxx: don't set non-existing learn2all bit for 6220/6250

2020-12-14 Thread Jakub Kicinski
On Thu, 10 Dec 2020 12:06:44 +0100 Rasmus Villemoes wrote: > The 6220 and 6250 switches do not have a learn2all bit in global1, ATU > control register; bit 3 is reserverd. > > On the switches that do have that bit, it is used to control whether > learning frames are sent out the ports that have th

[stabe-rc 5.9 ] sched: core.c:7270 Illegal context switch in RCU-bh read-side critical section!

2020-12-14 Thread Naresh Kamboju
There are two warnings "WARNING: suspicious RCU usage" noticed on arm64 juno-r2 device while running selftest bpf test_tc_edt.sh and net: udpgro_bench.sh. These warnings are occurring intermittently. metadata: git branch: linux-5.9.y git repo: https://git.kernel.org/pub/scm/linux/kernel/git/s

Re: [PATCH v2] net: bridge: Fix a warning when del bridge sysfs

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 20:29:21 +0800 you wrote: > I got a warining report: > > br_sysfs_addbr: can't create group bridge4/bridge > [ cut here ] > sysfs group 'bridge' not found for kobject 'bridge4' >

Re: [PATCH net] nfp: do not send control messages during cleanup

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 10:27:38 +0100 Simon Horman wrote: > On cleanup the txbufs are freed before app cleanup. But app clean-up may > result in control messages due to use of common control paths. There is no > need to clean-up the NIC in such cases so simply discard requests. Without > such a check

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Stephen Rothwell
Hi Jakub, On Mon, 14 Dec 2020 18:06:29 -0800 Jakub Kicinski wrote: > > AFAIU all we can do is tell Linus about the merge issue, and point > at Stephen's resolution. This is the correct response. -- Cheers, Stephen Rothwell pgpnhmtyKgstY.pgp Description: OpenPGP digital signature

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-14 Thread David Ahern
On 12/14/20 6:53 PM, Alexander Duyck wrote: >> example subfunction usage sequence: >> --- >> Change device to switchdev mode: >> $ devlink dev eswitch set pci/:06:00.0 mode switchdev >> >> Add a devlink port of subfunction flaovur: >> $ devlink port add pci/:

Re: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-14 Thread Willem de Bruijn
On Mon, Dec 14, 2020 at 8:59 PM wangyunjian wrote: > > From: Yunjian Wang > > Currently the vhost_zerocopy_callback() maybe be called to decrease > the refcount when sendmsg fails in tun. The error handling in vhost > handle_tx_zerocopy() will try to decrease the same refcount again. > This is wr

Re: [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests.

2020-12-14 Thread Martin KaFai Lau
On Tue, Dec 15, 2020 at 02:03:13AM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Thu, 10 Dec 2020 10:49:15 -0800 > > On Thu, Dec 10, 2020 at 02:15:38PM +0900, Kuniyuki Iwashima wrote: > > > From: Martin KaFai Lau > > > Date: Wed, 9 Dec 2020 16:07:07 -0800 > > > > On Tue

Re: [linux-nfc] [PATCH net-next] MAINTAINERS: Update maintainer for SAMSUNG S3FWRN5 NFC

2020-12-14 Thread Bongsu Jeon
On Tue, Dec 15, 2020 at 12:44 AM Krzysztof Kozlowski wrote: > > On Mon, Dec 14, 2020 at 09:28:23PM +0900, Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > add an email to look after the SAMSUNG NFC driver. > > Hi Bongsu, > > Review and testing is always appreciated. However before adding an entry

Re: [PATCH v2] MAINTAINERS: add mvpp2 driver entry

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 17:51:14 +0100 you wrote: > Since its creation Marvell NIC driver for Armada 375/7k8k and > CN913x SoC families mvpp2 has been lacking an entry in MAINTAINERS, > which sometimes lead to unhandled bugs th

Re: [PATCH net-next v3] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 15:26:38 +0100 you wrote: > Jakub pointed out that the IP_ECN_set* helpers basically open-code > csum16_add(), so let's switch them over to using the helper instead. > > v2: > - Use __be16 for check_add

Re: [PATCH v2] net: drop bogus skb with CHECKSUM_PARTIAL and offset beyond end of trimmed packet

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 22:07:39 +0300 you wrote: > syzbot reproduces BUG_ON in skb_checksum_help(): > tun creates (bogus) skb with huge partial-checksummed area and > small ip packet inside. Then ip_rcv trims the skb based on

Re: [PATCH net-next 0/5] bnxt_en: Improve firmware flashing.

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 13 Dec 2020 06:51:41 -0500 you wrote: > This patchset improves firmware flashing in 2 ways: > > - If firmware returns NO_SPACE error during flashing, the driver will > create the UPDATE directory with more staging

Re: [PATCH net-next v2 00/15] mlxsw: Introduce initial XM router support

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 13:30:26 +0200 you wrote: > From: Ido Schimmel > > This patch set implements initial eXtended Mezzanine (XM) router > support. > > The XM is an external device connected to the Spectrum-{2,3} ASICs u

Re: pull-request: can-next 2020-12-14

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 14:31:38 +0100 you wrote: > Hello Jakub, hello David, > > this is a series of 7 patches for net-next/master. > > All 7 patches are by me and target the m_can driver. First there are 4 cleanup >

Re: [PATCH] net/connector: Add const qualifier to cb_id

2020-12-14 Thread Jakub Kicinski
On Sat, 12 Dec 2020 18:47:01 -0800 Geoff Levand wrote: > The connector driver never modifies any cb_id passed to it, so add a const > qualifier to those arguments so callers can declare their struct cb_id as a > constant object. > > Fixes build warnings like these when passing a constant struct cb

Re: [PATCH net-next v2 0/4] net: avoid indirect calls in dst functions

2020-12-14 Thread Jakub Kicinski
On Fri, 11 Dec 2020 23:33:36 + Brian Vazquez wrote: > From: brianvv We'd prefer you to use your normal name rather than just "brianvv". > Use of the indirect call wrappers in some dst related functions for the > ipv6/ipv4 case. This is a small improvent for CONFIG_RETPOLINE=y Any numbers yo

Re: [PATCH net-next] net: vxget: clean up sparse warnings

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 15:44:26 -0800 you wrote: > This code is copying strings in 64 bit quantities, the device > returns them in big endian. As long as we store in big endian > IOW endian on both sides matches, we're good, s

Re: [PATCH net-next] nfc: s3fwrn5: Release the nfc firmware

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 13 Dec 2020 18:58:50 +0900 you wrote: > From: Bongsu Jeon > > add the code to release the nfc firmware when the firmware image size is > wrong. > > Signed-off-by: Bongsu Jeon > > [...] Here is the summary with

[PATCH] tipc: do sanity check payload of a netlink message

2020-12-14 Thread Hoang Huu Le
From: Hoang Le When we initialize nlmsghdr with no payload inside tipc_nl_compat_dumpit() the parsing function returns -EINVAL. We fix it by making the parsing call conditional. Acked-by: Jon Maloy Signed-off-by: Hoang Le --- net/tipc/netlink_compat.c | 12 +++- 1 file changed, 7 inse

[net-next] tipc: do sanity check payload of a netlink message

2020-12-14 Thread Hoang Huu Le
From: Hoang Le When we initialize nlmsghdr with no payload inside tipc_nl_compat_dumpit() the parsing function returns -EINVAL. We fix it by making the parsing call conditional. Acked-by: Jon Maloy Signed-off-by: Hoang Le --- net/tipc/netlink_compat.c | 12 +++- 1 file changed, 7 inse

Re: [PATCH net-next] nfc: s3fwrn5: Remove unused nci prop commands

2020-12-14 Thread Bongsu Jeon
On Tue, Dec 15, 2020 at 1:02 AM Krzysztof Kozlowski wrote: > > On Mon, Dec 14, 2020 at 08:46:58PM +0900, Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > remove the unused nci prop commands that samsung driver doesn't use. > > Don't send patches one-by-one, but group them in a patchset. > > Previ

Re: [PATCH v4 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 21:16:12 +0200 you wrote: > Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has > a very nice ocelot_mact_wait_for_completion at the end. Introduced in > commit 639c1b2625af ("net: m

Re: [PATCH net V3] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 13 Dec 2020 16:39:29 +0200 you wrote: > With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be > logically done when HW_CSUM offload is off. > > Fixes: 2342a8512a1e ("net: Add TLS TX offload features")

Re: [PATCH -next] nfc/pn533/usb: convert comma to semicolon

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 21:43:14 +0800 you wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/nfc/pn533/usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH v2 1/1] net: Fix use of proc_fs

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 22:25:50 +0200 Yonatan Linik wrote: > proc_fs was used, in af_packet, without a surrounding #ifdef, > although there is no hard dependency on proc_fs. > That caused the initialization of the af_packet module to fail > when CONFIG_PROC_FS=n. > > Specifically, proc_create_net() w

Re: [net-next PATCH v3] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 12:31:24 -0800 you wrote: > From: Alexander Duyck > > There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG > message in the case of IPv6 or a fragmentation request in the case of > IPv

Re: [PATCH net-next v4 0/5] vsock: Add flags field in the vsock address

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Dec 2020 18:11:17 +0200 you wrote: > vsock enables communication between virtual machines and the host they are > running on. Nested VMs can be setup to use vsock channels, as the multi > transport support has b

Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

2020-12-14 Thread Pravin Shelar
On Mon, Dec 14, 2020 at 12:29 AM Jonas Bonn wrote: > > Hi Pravin, > > On 13/12/2020 20:32, Pravin Shelar wrote: > > On Sat, Dec 12, 2020 at 11:56 PM Jonas Bonn wrote: > >> > >> Hi Pravin, > >> > >> I've been thinking a bit about this and find it more and more > >> interesting. Could you post a b

Re: [PATCH][next] net: hns3: fix expression that is currently always true

2020-12-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 15 Dec 2020 00:00:33 + you wrote: > From: Colin Ian King > > The || condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE || > hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because > hdev

[PATCH net-next v4] GTP: add support for flow based tunneling API

2020-12-14 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- v3-v4: - add check for non-zero dst port v2-v3: - Fi

Re: [PATCH net 2/2] vhost_net: fix high cpu load when sendmsg fails

2020-12-14 Thread Jason Wang
On 2020/12/15 上午9:48, wangyunjian wrote: From: Yunjian Wang Currently we break the loop and wake up the vhost_worker when sendmsg fails. When the worker wakes up again, we'll meet the same error. This will cause high CPU load. To fix this issue, we can skip this description by ignoring the er

[PATCHv4 net-next] octeontx2-pf: Add RSS multi group support

2020-12-14 Thread Geetha sowjanya
Hardware supports 8 RSS groups per interface. Currently we are using only group '0'. This patch allows user to create new RSS groups/contexts and use the same as destination for flow steering rules. usage: To steer the traffic to RQ 2,3 ethtool -X eth0 weight 0 0 1 1 context new (It will print th

Re: BUG: soft lockup in mac80211_hwsim_beacon

2020-12-14 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:2c85ebc5 Linux 5.10 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148fcc1350 kernel config: https://syzkaller.appspot.com/x/.config?x=8aff533d6c635e6 dashboard link: https://syzkalle

Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

2020-12-14 Thread Jakub Kicinski
On Sat, 12 Dec 2020 02:00:05 +0100 Andrea Mayer wrote: > The set of required attributes for a given SRv6 behavior is identified > using a bitmap stored in an unsigned long, since the initial design of > SRv6 networking in Linux. Recently the same approach has been used for > identifying the optiona

Re: [net-next v4 01/15] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 02:31:25PM -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2020 at 1:49 PM Saeed Mahameed wrote: > > > > From: Parav Pandit > > > > MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field. > > > > Defining an enum for such bit fields on 32-bit platform results in below >

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-14 Thread David Ahern
On 12/13/20 11:21 AM, Boris Pismenny wrote: >>> as zerocopy for the following reasons: >>> (1) The former places buffers *exactly* where the user requests >>> regardless of the order of response arrivals, while the latter places >>> packets >>> in anonymous buffers according to packet arrival orde

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote: > > > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote: > > > > It is fix for semantic patch warning

[PATCH v2] net/connector: Add const qualifier to cb_id

2020-12-14 Thread Geoff Levand
The connector driver never modifies any cb_id passed to it, so add a const qualifier to those arguments so callers can declare their struct cb_id as a constant object. Fixes build warnings like these when passing a constant struct cb_id: warning: passing argument 1 of ‘cn_add_callback’ discards

<    1   2   3   4   >