From: Magnus Karlsson
Rollback the reservation in the completion ring when we get a
NETDEV_TX_BUSY. When this error is received from the driver, we are
supposed to let the user application retry the transmit again. And in
order to do this, we need to roll back the failed send so it can be
retried
Hi Divya,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201214-205209
base: https://git.kernel.org/pub/scm/linux/kernel
This patch set contains two bug fixes to the Tx SKB path. Details can
be found in the individual commit messages. Special thanks to Xuan
Zhuo for spotting both of them.
Thanks: Magnus
Magnus Karlsson (2):
xsk: fix race in SKB mode transmit with shared cq
xsk: rollback reservation at NETDEV_TX
Hi Divya,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201214-205209
base: https://git.kernel.org/pub/scm/linux/kernel
On 12/14/20 9:15 AM, Gary Lin wrote:
On Mon, Dec 14, 2020 at 11:56:22AM +0800, Gary Lin wrote:
On Fri, Dec 11, 2020 at 09:05:05PM +0100, Daniel Borkmann wrote:
On 12/11/20 9:19 AM, Gary Lin wrote:
The x64 bpf jit expects bpf images converge within the given passes, but
it could fail to do so w
On Mon, Dec 14, 2020 at 12:25:16PM +0300, Serge Semin wrote:
> Hello folks,
>
> I've got a problem, which has been blowing by head up for more than three
> weeks now, and I'm desperately need your help in that matter. See our
> Baikal-T1 SoC is created with two DW GMAC v3.73a IP-cores. Each core
>
On Sat, Dec 12, 2020 at 06:41:47PM +0100, Lorenzo Bianconi wrote:
> Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize
> xdp_buff data structure and remove duplicated code in all XDP capable
> drivers.
>
> Changes since v2:
> - precompute xdp->data as hard_start + headroom
This flag can be used by an end user to disable S0ix flows on a
buggy system or by an OEM for development purposes.
If you need this flag to be persisted across reboots, it's suggested
to use a udev rule to call adjust it until the kernel could have your
configuration in a disallow list.
Signed-o
Per guidance from Intel ethernet architecture team, it may take
up to 1 second for unconfiguring ULP mode.
Suggested-by: Aaron Ma
Suggested-by: Sasha Netfin
Fixes: f15bb6dde738cc8fa0 ("e1000e: Add support for S0ix")
BugLink: https://bugs.launchpad.net/bugs/1865570
Link:
https://patchwork.ozlabs
If the shutdown failed, the part will be thawed and running
S0ix flows will put it into an undefined state.
Reported-by: Alexander Duyck
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --gi
commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
disabled s0ix flows for systems that have various incarnations of the
i219-LM ethernet controller. This was done because of some regressions
caused by an earlier
commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable
commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
disabled s0ix flows for systems that have various incarnations of the
i219-LM ethernet controller. This changed caused power consumption regressions
on the following shipping Dell Comet Lake based laptops:
* Latitude
On Mon, Dec 14, 2020 at 09:28:23PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon
>
> add an email to look after the SAMSUNG NFC driver.
Hi Bongsu,
Review and testing is always appreciated. However before adding an entry
to Maintainers, I would prefer to see some activity in maintainer-like
task
On Mon, Dec 14, 2020 at 3:02 PM Bjorn Helgaas wrote:
>
> On Mon, Dec 14, 2020 at 10:14:18AM +0100, Ian Kumlien wrote:
> > On Mon, Dec 14, 2020 at 6:44 AM Bjorn Helgaas wrote:
> > >
> > > [+cc Jesse, Tony, David, Jakub, Heiner, lists in case there's an ASPM
> > > issue with I211 or Realtek NICs.
On Sun, Dec 13, 2020 at 06:58:50PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon
>
> add the code to release the nfc firmware when the firmware image size is
> wrong.
s/add/Add/
s/nfc/NFC/
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
Hello:
This series was applied to bpf/bpf-next.git (refs/heads/master):
On Fri, 11 Dec 2020 13:58:23 -0800 you wrote:
> Add support for finding BTF-based kernel attach targets (fentry/fexit
> functions, tp_btf tracepoints, etc) with programmatic
> bpf_program__set_attach_target() API. It is now a
On Sun, Dec 13, 2020 at 07:12:38PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon
>
> remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Please start sentences with capital letter.
s/nfc/NFC/ (here and in subject)
This explanation is very vague. Please rephrase it.
Best re
On Sat, 12 Dec 2020 20:07:16 +
Witold Baryluk wrote:
> iproute 5.9.0
>
> Apparently ip -c is a shortcut to ip -color
>
> but in tc, tc -c doesn't work, one needs to say tc -col or tc -color
>
> I understand there is tc -conf, which has tc -c.
>
> But:
>
> Help says:
>
> root@debian:~# t
On Mon, Dec 14, 2020 at 08:46:58PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon
>
> remove the unused nci prop commands that samsung driver doesn't use.
Don't send patches one-by-one, but group them in a patchset.
Previous comments apply here as well - NCI is acronym, start with
capital letter
MHI net is protocol agnostic, the payload protocol depends on the modem
configuration, which can be either RMNET (IP muxing and aggregation) or
raw IP. This patch adds support for incomming IPv4/IPv6 packets, that
was previously unconditionnaly reported as RMNET packets.
Signed-off-by: Loic Poulai
vsock enables communication between virtual machines and the host they
are running on. With the multi transport support (guest->host and
host->guest), nested VMs can also use vsock channels for communication.
In addition to this, by default, all the vsock packets are forwarded to
the host, if no h
The vsock flags can be set during the connect() setup logic, when
initializing the vsock address data structure variable. Then the vsock
transport is assigned, also considering this flags field.
The vsock transport is also assigned on the (listen) receive path. The
flags field needs to be set cons
The vsock flags field can be set in the connect path (user space app)
and the (listen) receive path (kernel space logic).
When the vsock transport is assigned, the remote CID is used to
distinguish between types of connection.
Use the vsock flags value (in addition to the CID) from the remote
add
vsock enables communication between virtual machines and the host they are
running on. Nested VMs can be setup to use vsock channels, as the multi
transport support has been available in the mainline since the v5.5 Linux kernel
has been released.
Implicitly, if no host->guest vsock transport is lo
Check if the provided flags value from the vsock address data structure
includes the supported flags in the corresponding kernel version.
The first byte of the "svm_zero" field is used as "svm_flags", so add
the flags check instead.
Changelog
v3 -> v4
* New patch in v4.
Signed-off-by: Andra Pa
On 14/12/2020 10:13, Stefano Garzarella wrote:
On Sat, Dec 12, 2020 at 09:16:08AM -0800, Jakub Kicinski wrote:
On Fri, 11 Dec 2020 16:24:13 +0100 Stefano Garzarella wrote:
On Fri, Dec 11, 2020 at 12:32:37PM +0200, Andra Paraschiv wrote:
>vsock enables communication between virtual machines a
Add VMADDR_FLAG_TO_HOST vsock flag that is used to setup a vsock
connection where all the packets are forwarded to the host.
Then, using this type of vsock channel, vsock communication between
sibling VMs can be built on top of it.
Changelog
v3 -> v4
* Update the "VMADDR_FLAG_TO_HOST" value, as
On Mon, Dec 14, 2020 at 7:35 AM Mario Limonciello
wrote:
>
> commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME
> systems")
> disabled s0ix flows for systems that have various incarnations of the
> i219-LM ethernet controller. This was done because of some regressions
> cause
On Thu, Dec 10, 2020 at 09:16:24AM +0200, Martin Zaharinov wrote:
> And one other
> From other mailing I see you send patch to Denys Fedoryshchenko this patch is
> :
>
> diff --git a/drivers/net/ppp/ppp_generic.c
> b/drivers/net/ppp/ppp_generic.c
>
> index 255a5def56e9..2acf4b0eabd1 100644
>
This patch add supports for 1588 Hardware Timestamping support
to LAN8814 Quad Phy. It supports L2 and Ipv4 encapsulations.
Signed-off-by: Divya Koppera
---
drivers/net/phy/micrel.c | 1054 +-
1 file changed, 1048 insertions(+), 6 deletions(-)
diff --git a/dri
From: Sylvain BERTRAND
Using a c89 compiler fails due some wrong usage of compiler constants.
Trivial and harmless fixes.
Signed-off-by: Sylvain BERTRAND
---
work based on mainline 9c87c9f41245baa3fc4716cf39141439cf405b01:
(will enable an IP/USB-ethernet kernel to be compilable and runnable)
On 12/10/20 4:02 PM, Petr Machata wrote:
> Add support to the dcb tool for the following three DCB objects:
>
> - PFC, for "Priority-based Flow Control", allows configuration of priority
> lossiness, and related toggles.
>
> - DCBNL buffer interfaces are an extension to the 802.1q DCB interface
From: Martin KaFai Lau
Date: Thu, 10 Dec 2020 10:49:15 -0800
> On Thu, Dec 10, 2020 at 02:15:38PM +0900, Kuniyuki Iwashima wrote:
> > From: Martin KaFai Lau
> > Date: Wed, 9 Dec 2020 16:07:07 -0800
> > > On Tue, Dec 01, 2020 at 11:44:12PM +0900, Kuniyuki Iwashima wrote:
> > > > This patch
On 12/14/20 3:42 AM, Thomas Karlsson wrote:
> This patch allows the user to set and retrieve the
> IFLA_MACVLAN_BC_QUEUE_LEN parameter via the bcqueuelen
> command line argument
>
> This parameter controls the requested size of the queue for
> broadcast and multicast packages in the macvlan driver
On Mon, Dec 14, 2020 at 06:11:20PM +0200, Andra Paraschiv wrote:
Check if the provided flags value from the vsock address data structure
includes the supported flags in the corresponding kernel version.
The first byte of the "svm_zero" field is used as "svm_flags", so add
the flags check instead
On Mon, Dec 14, 2020 at 06:11:17PM +0200, Andra Paraschiv wrote:
vsock enables communication between virtual machines and the host they are
running on. Nested VMs can be setup to use vsock channels, as the multi
transport support has been available in the mainline since the v5.5 Linux kernel
has
On Wed, Dec 09, 2020 at 09:12:18PM +0200, Martin Zaharinov wrote:
>
>
> > On 9 Dec 2020, at 20:10, Guillaume Nault wrote:
> >
> > On Wed, Dec 09, 2020 at 06:57:44PM +0200, Martin Zaharinov wrote:
> >>> On 9 Dec 2020, at 18:40, Guillaume Nault wrote:
> >>> On Wed, Dec 09, 2020 at 04:47:52PM +02
Match all MPLS fields using smallest and highest possible values.
Test the two ways of specifying MPLS header matching:
* with the basic mpls_{label,tc,bos,ttl} keywords (match only on the
first LSE),
* with the more generic "lse" keyword (allows matching at different
depth of the MPL
From: Martin KaFai Lau
Date: Thu, 10 Dec 2020 11:33:40 -0800
> On Thu, Dec 10, 2020 at 02:58:10PM +0900, Kuniyuki Iwashima wrote:
>
> [ ... ]
>
> > > > I've implemented one-by-one migration only for the accept queue for now.
> > > > In addition to the concern about TFO queue,
> > > You meant
Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs.
This change folds test cases into test_progs.
Changes from V7:
- Rebased changes.
- Changed function scope.
Signed-off-by: Carlos Neira
Acked-by: Andrii Nakryiko
---
tools/testing/selftests/bpf/.gitignore| 1
On 2020-12-14 18:03, David Ahern wrote:
> On 12/14/20 3:42 AM, Thomas Karlsson wrote:
>> This patch allows the user to set and retrieve the
>> IFLA_MACVLAN_BC_QUEUE_LEN parameter via the bcqueuelen
>> command line argument
>>
>> This parameter controls the requested size of the queue for
>> broadca
> -Original Message-
> From: Lorenzo Bianconi
> Sent: Saturday, December 12, 2020 19:42
> To: b...@vger.kernel.org; netdev@vger.kernel.org
> Cc: da...@davemloft.net; k...@kernel.org; a...@kernel.org;
> dan...@iogearbox.net; bro...@redhat.com; lorenzo.bianc...@redhat.com;
> alexander.du...@
On 14/12/2020 19:09, Stefano Garzarella wrote:
On Mon, Dec 14, 2020 at 06:11:17PM +0200, Andra Paraschiv wrote:
vsock enables communication between virtual machines and the host
they are
running on. Nested VMs can be setup to use vsock channels, as the multi
transport support has been availa
Hi All,
Sasha (and the other intel-wired-lan folks), thank you for investigating this
further and for coming up with a better solution.
Mario, thank you for implementing the new scheme.
I've tested this patch set on a Lenovo X1C8 with vPRO and AMT enabled in the
BIOS
(the previous issues were s
Hi,
On 12/14/20 4:34 PM, Mario Limonciello wrote:
> This flag can be used by an end user to disable S0ix flows on a
> buggy system or by an OEM for development purposes.
>
> If you need this flag to be persisted across reboots, it's suggested
> to use a udev rule to call adjust it until the kerne
On Sun, Dec 13, 2020 at 5:33 PM Andrey Ignatov wrote:
>
> Cong Wang [Sat, 2020-12-12 15:18 -0800]:
> > On Sat, Dec 12, 2020 at 2:25 PM Cong Wang wrote:
> > >
> > > On Fri, Dec 11, 2020 at 11:55 AM Andrii Nakryiko
> > > wrote:
> > > >
> > > > On Fri, Dec 11, 2020 at 2:28 AM Cong Wang
> > > > w
Thanks Hans
On 14/12/2020 13:31, Mark Pearson wrote:
>
>
>
> *From:* Hans de Goede
> *Sent:* December 14, 2020 13:24
> *To:* Mario Limonciello ; Jeff Kirsher
> ; Tony Nguyen ;
> intel-wired-...@lists.osuosl.org ;
> David M
On Mon, 14 Dec 2020 09:59:21 -0800 Wei Wang wrote:
> On Sat, Dec 12, 2020 at 2:55 PM Jakub Kicinski wrote:
> >
> > On Sat, 12 Dec 2020 14:50:22 -0800 Jakub Kicinski wrote:
> > > > @@ -6731,6 +6790,7 @@ void napi_disable(struct napi_struct *n)
> > > > msleep(1);
> > > >
> > > > hr
On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote:
> On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote:
> > It is fix for semantic patch warning available in
> > scripts/coccinelle/misc/boolinit.cocci
> > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable
> > Fi
> +static int lan8814_read_page_reg(struct phy_device *phydev,
> + int page, u32 addr)
> +{
> + u32 data;
> +
> + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_CONTROL, page);
> + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_ADDRESS_DATA, addr);
> + phy_write(phydev, K
On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote:
> On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote:
> > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote:
> > > It is fix for semantic patch warning available in
> > > scripts/coccinelle/misc/boolinit.cocci
> > > Fix e
syzbot reproduces BUG_ON in skb_checksum_help():
tun creates (bogus) skb with huge partial-checksummed area and
small ip packet inside. Then ip_rcv trims the skb based on size
of internal ip packet, after that csum offset points beyond of
trimmed skb. Then checksum_tg() called via netfilter hook
tr
On Sun, 13 Dec 2020 11:48:15 +0200 Yonatan Linik wrote:
> > You're right, on a closer look most of the places have a larger #ifdef
> > block (which my grep didn't catch) or are under Kconfig. Of those I
> > checked only TLS looks wrong (good job me) - would you care to fix that
> > one as well, or
On Mon, Dec 14, 2020 at 11:26:58PM +0530, Divya Koppera wrote:
> This patch add supports for 1588 Hardware Timestamping support
> to LAN8814 Quad Phy. It supports L2 and Ipv4 encapsulations.
Please could you break this patch up a bit. Add support for link
up/down interrupts in one patch. Then add
On Mon, Dec 14, 2020 at 04:47:32PM +0100, Ian Kumlien wrote:
> On Mon, Dec 14, 2020 at 3:02 PM Bjorn Helgaas wrote:
> > On Mon, Dec 14, 2020 at 10:14:18AM +0100, Ian Kumlien wrote:
> > > On Mon, Dec 14, 2020 at 6:44 AM Bjorn Helgaas wrote:
> > > >
> > > > [+cc Jesse, Tony, David, Jakub, Heiner, l
From: Randy Dunlap
[ Upstream commit 98701a2a861fa87a5055cf2809758e8725e8b146 ]
drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select
VHOST_IOTLB to make them be built.
However, if VHOST_IOTLB is the only VHOST symbol that is
set/enabled, the object file still won't be built because
driv
From: Randy Dunlap
[ Upstream commit 14483cbf040fcb38113497161088a1ce8ce5d713 ]
The CNIC kconfig symbol selects UIO and UIO depends on MMU.
Since 'select' does not follow dependency chains, add the same MMU
dependency to CNIC.
Quietens this kconfig warning:
WARNING: unmet direct dependencies d
> +struct lan8814_priv {
> + const struct kszphy_type *type;
> + int led_mode;
> + bool rmii_ref_clk_sel;
> + bool rmii_ref_clk_sel_val;
> + u64 stats[ARRAY_SIZE(kszphy_hw_stats)];
> + struct mii_timestamper mii_ts;
> + struct phy_device *phydev;
> + struct lan8814_p
commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
disabled s0ix flows for systems that have various incarnations of the
i219-LM ethernet controller. This was done because of some regressions
caused by an earlier
commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable
This flag can be used by an end user to disable S0ix flows on a
buggy system or by an OEM for development purposes.
If you need this flag to be persisted across reboots, it's suggested
to use a udev rule to call adjust it until the kernel could have your
configuration in a disallow list.
Signed-o
commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
disabled s0ix flows for systems that have various incarnations of the
i219-LM ethernet controller. This changed caused power consumption regressions
on the following shipping Dell Comet Lake based laptops:
* Latitude
If the shutdown failed, the part will be thawed and running
S0ix flows will put it into an undefined state.
Reported-by: Alexander Duyck
Reviewed-by: Alexander Duyck
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++--
1 file changed, 7 insertions
On Mon, Dec 14, 2020 at 7:13 AM Maxim Mikityanskiy wrote:
>
> On 2020-12-11 21:16, Cong Wang wrote:
> > On Fri, Dec 11, 2020 at 7:26 AM Maxim Mikityanskiy
> > wrote:
> >>
> >> HTB doesn't scale well because of contention on a single lock, and it
> >> also consumes CPU. This patch adds support fo
> Hi All,
>
> Sasha (and the other intel-wired-lan folks), thank you for investigating this
> further and for coming up with a better solution.
>
> Mario, thank you for implementing the new scheme.
>
Sure.
> I've tested this patch set on a Lenovo X1C8 with vPRO and AMT enabled in the
> BIOS
>
Per guidance from Intel ethernet architecture team, it may take
up to 1 second for unconfiguring ULP mode.
However in practice this seems to be taking up to 2 seconds on
some Lenovo machines. Detect scenarios that take more than 1 second
but less than 2.5 seconds and emit a warning on resume for
On Mon, 14 Dec 2020 10:19:07 +0100 Loic Poulain wrote:
> On Sat, 12 Dec 2020 at 21:55, Jakub Kicinski wrote:
> > On Thu, 10 Dec 2020 12:15:51 +0100 Loic Poulain wrote:
> > > The buffer allocation for RX path is currently done by a work executed
> > > in the system workqueue. The work to do is qu
Hi all,
On Thu, 26 Nov 2020 17:40:57 +1100 Stephen Rothwell
wrote:
>
> After merging the net-next tree, today's linux-next build (htmldocs)
> produced this warning:
>
> include/linux/phy.h:869: warning: Function parameter or member 'config_intr'
> not described in 'phy_driver'
>
> Introduced
Le 14/12/2020 à 12:48, Dan Carpenter a écrit :
On Sun, Dec 13, 2020 at 12:48:38PM +0100, Christophe JAILLET wrote:
In case of error after calling 'ocelot_init()', it must be undone by a
corresponding 'ocelot_deinit()' call, as already done in the remove
function.
This changes the behavior sli
Hi all,
On Thu, 26 Nov 2020 16:22:48 +1100 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the userns tree got a conflict in:
>
> kernel/bpf/task_iter.c
>
> between commit:
>
> 91b2db27d3ff ("bpf: Simplify task_file_seq_get_next()")
>
> from the bpf-next tree and commit:
>
> e
On Mon, 2020-12-14 at 03:25 +, Parav Pandit wrote:
> > From: Leon Romanovsky
> > Sent: Sunday, December 13, 2020 5:39 PM
> >
> > On Sat, Dec 12, 2020 at 12:25:18PM -0800, Jakub Kicinski wrote:
> > > On Fri, 11 Dec 2020 22:12:11 -0800 Saeed Mahameed wrote:
> > > > Hi Dave, Jakub, Jason,
> > >
On Sun, 2020-12-13 at 14:36 +0200, Leon Romanovsky wrote:
> On Sun, Dec 13, 2020 at 02:06:41PM +0200, Leon Romanovsky wrote:
> > From: Parav Pandit
> >
> > MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field.
> >
> > Defining an enum for such bit fields on 32-bit platform results in
> > bel
From: Cong Wang
In map ptr test, a hard-coded 64 is used to check hash element size.
Increase it to 72 as we increase the size of struct htab_elem. It
seems struct htab_elem is not visible here.
Cc: Andrey Ignatov
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Cc: Dongdong Wang
Signed-off-by: Co
From: Cong Wang
This borrows the idea from conntrack and will be used for conntrack in
bpf too. Each element in a timeout map has a user-specified timeout
in secs, after it expires it will be automatically removed from the map.
There are two cases here:
1. When the timeout map is idle, that is,
From: Cong Wang
Similar to regular hashmap test.
Cc: Andrey Ignatov
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Cc: Dongdong Wang
Signed-off-by: Cong Wang
---
.../selftests/bpf/progs/map_ptr_kern.c| 20 +++
1 file changed, 20 insertions(+)
diff --git a/tools/testing
From: Cong Wang
Add a test case in test_maps.c for timeout map, which focuses
on testing timeout.
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Cc: Dongdong Wang
Signed-off-by: Cong Wang
---
tools/testing/selftests/bpf/test_maps.c | 41 +
1 file changed, 41 insertions(+
From: Cong Wang
This patchset introduces a new bpf hash map which has timeout.
Patch 1 is a preparation, patch 2 is the implementation of timeout
map, patch 3 updates an existing hash map ptr test, patch 4 and
patch 5 contain two test cases for timeout map.
Please check each patch description fo
From: Cong Wang
Commit 20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked")
introduced a percpu counter map_locked to bail out NMI case. It uses
the hash of each bucket for indexing, which requires callers of
htab_lock_bucket()/htab_unlock_bucket() to pass it in. But hash value
is not alw
If Makefile cannot find any of the vmlinux's in its VMLINUX_BTF_PATHS list,
it tries to run btftool incorrectly, with VMLINUX_BTF unset:
bpftool btf dump file $(VMLINUX_BTF) format c
Such that the keyword 'format' is misinterpreted as the path to vmlinux.
The resulting build error message is
'irq_of_parse_and_map()' should be balanced by a corresponding
'irq_dispose_mapping()' call. Otherwise, there is some resources leaks.
Add such a call in the error handling path of the probe function and in the
remove function.
Fixes: 492205050d77 ("net: Add EMAC ethernet driver found on Allwinne
Hi all,
On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the akpm-current tree got conflicts in:
>
> include/linux/memcontrol.h
> mm/memcontrol.c
>
> between commit:
>
> bcfe06bf2622 ("mm: memcontrol: Use helpers to read page's memcg data")
>
>
Hi all,
On Mon, 7 Dec 2020 14:09:51 +1100 Stephen Rothwell
wrote:
>
> After merging the block tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/io_uring.c: In function 'io_shutdown':
> fs/io_uring.c:3782:9: error: too many arguments to function 'sock_from_file'
This patch fixes the failure of af_packet module initialization when
CONFIG_PROC_FS=n.
The commit message itself has a pretty thorough explanation.
I will just add that I made sure this fixes the problem, both by
using socket from userspace and by looking at kernel logs.
This also fixes a similar
proc_fs was used, in af_packet, without a surrounding #ifdef,
although there is no hard dependency on proc_fs.
That caused the initialization of the af_packet module to fail
when CONFIG_PROC_FS=n.
Specifically, proc_create_net() was used in af_packet.c,
and when it fails, packet_net_init() returns
On 2020-12-14 21:35, Cong Wang wrote:
On Mon, Dec 14, 2020 at 7:13 AM Maxim Mikityanskiy wrote:
On 2020-12-11 21:16, Cong Wang wrote:
On Fri, Dec 11, 2020 at 7:26 AM Maxim Mikityanskiy wrote:
HTB doesn't scale well because of contention on a single lock, and it
also consumes CPU. This patc
On Mon, 14 Dec 2020 11:45:43 -0800 Wei Wang wrote:
> > It is quite an annoying problem to address, given all relevant NAPI
> > helpers seem to return void :/ But we're pushing the problem onto the
> > user just because of internal API structure.
> >
> > This reminds me of PTP / timestamping issues
Cong Wang [Mon, 2020-12-14 12:11 -0800]:
> From: Cong Wang
>
> In map ptr test, a hard-coded 64 is used to check hash element size.
> Increase it to 72 as we increase the size of struct htab_elem. It
> seems struct htab_elem is not visible here.
>
> Cc: Andrey Ignatov
> Cc: Alexei Starovoitov
Cong Wang [Mon, 2020-12-14 12:11 -0800]:
> From: Cong Wang
>
> Similar to regular hashmap test.
>
> Cc: Andrey Ignatov
> Cc: Alexei Starovoitov
> Cc: Daniel Borkmann
> Cc: Dongdong Wang
> Signed-off-by: Cong Wang
Thanks.
Acked-by: Andrey Ignatov
> ---
> .../selftests/bpf/progs/map_ptr
On Sun, 13 Dec 2020 20:59:54 -0500 Willem de Bruijn wrote:
> On Sun, Dec 13, 2020 at 2:37 PM Vasily Averin wrote:
> > >> On 12/11/20 6:37 PM, Vasily Averin wrote:
> > >>> It seems for me the similar problem can happen in __skb_trim_rcsum().
> > >>> Also I doubt that that skb_checksum_start_offse
On Mon, Dec 14, 2020 at 2:21 PM Vasily Averin wrote:
>
> syzbot reproduces BUG_ON in skb_checksum_help():
> tun creates (bogus) skb with huge partial-checksummed area and
> small ip packet inside. Then ip_rcv trims the skb based on size
> of internal ip packet, after that csum offset points beyond
On Thu, 2020-12-10 at 20:25 +0100, Thomas Gleixner wrote:
> Using the interrupt affinity mask for checking locality is not really
> working well on architectures which support effective affinity masks.
>
> The affinity mask is either the system wide default or set by user
> space,
> but the archit
On Mon, Dec 14, 2020 at 3:56 PM Jakub Kicinski wrote:
>
> On Sun, 13 Dec 2020 20:59:54 -0500 Willem de Bruijn wrote:
> > On Sun, Dec 13, 2020 at 2:37 PM Vasily Averin wrote:
> > > >> On 12/11/20 6:37 PM, Vasily Averin wrote:
> > > >>> It seems for me the similar problem can happen in __skb_trim_r
On Mon, 14 Dec 2020 11:03:12 +0100 Julian Wiedmann wrote:
> > diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
> > index bf48f0ded9c7d..9d84191de6824 100644
> > --- a/drivers/net/ethernet/korina.c
> > +++ b/drivers/net/ethernet/korina.c
> > @@ -216,7 +216,6 @@ static int k
On Thu, 2020-12-10 at 20:25 +0100, Thomas Gleixner wrote:
> No driver has any business with the internals of an interrupt
> descriptor. Storing a pointer to it just to use yet another helper at
> the
> actual usage site to retrieve the affinity mask is creative at best.
> Just
> because C does not
There are some use cases for netdev_notify_peers in the context
when rtnl lock is already held. Introduce lockless version
of netdev_notify_peers call to save the extra code to call
call_netdevice_notifiers(NETDEV_NOTIFY_PEERS, dev);
call_netdevice_notifiers(NETDEV_RESEND_IGMP, dev)
Start to use the lockless version of netdev_notify_peers.
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ibm/ibmvnic.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index a2191392ca4f..f302
This series introduce the lockless version of netdev_notify_peers
and then apply it to the relevant drivers.
In v1, a more appropriate name __netdev_notify_peers is used;
netdev_notify_peers is converted to call the new helper.
In v2, patch 3 calls the new helper where notify variable used
to be s
Start to use the lockless version of netdev_notify_peers.
Call the helper where notify variable used to be set true.
Remove the notify bool variable and sort the variables
in reverse Christmas tree order.
Cc: Haiyang Zhang
Signed-off-by: Lijun Pan
---
v2: call the helper where notify variable us
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jakub Kicinski
> Sent: czwartek, 3 grudnia 2020 18:41
> To: Nguyen, Anthony L
> Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Pawlak, Jakub
>
> Subject: Re: [Intel-wired-lan] [PATCH net] iavf: fix double-relea
Hi David, hi Jakub,
The following pull-request contains BPF updates for your *net-next* tree.
We've added 31 non-merge commits during the last 11 day(s) which contain
a total of 40 files changed, 2063 insertions(+), 114 deletions(-).
The main changes are:
1) Expose bpf_sk_storage_*() helpers to
From: Parav Pandit
Extended devlink interface for the user to add and delete port.
Extend devlink to connect user requests to driver to add/delete
such port in the device.
When driver routines are invoked, devlink instance lock is not held.
This enables driver to perform several devlink objects
101 - 200 of 319 matches
Mail list logo
