[PATCH v3 6/8] dt-bindings: add documentation for sama7g5 gigabit ethernet interface

2020-12-09 Thread Claudiu Beznea
Add documentation for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bind

[PATCH v3 0/8] net: macb: add support for sama7g5

2020-12-09 Thread Claudiu Beznea
Hi, This series adds support for SAMA7G5 Ethernet interfaces: one 10/100Mbps and one 1Gbps interfaces. Along with it I also included a fix to disable clocks for SiFive FU540-C000 on failure path of fu540_c000_clk_init(). Thank you, Claudiu Beznea Changed in v3: - use clk_bulk_disable_unprepare

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-09 Thread Saeed Mahameed
On Wed, 2020-12-09 at 08:41 -0700, David Ahern wrote: > On 12/9/20 4:52 AM, Jesper Dangaard Brouer wrote: > > > > still load and either share queues across multiple cores or > > > > restirct > > > > down to a subset of CPUs. > > > > > > And that's the missing piece of logic, I suppose. > > > >

Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)

2020-12-09 Thread Jakub Kicinski
Eric, could this possibly be commit 4179b00c04d1 ("geneve: pull IP header before ECN decapsulation")? On Wed, 9 Dec 2020 10:05:14 +0800 Jianlin Shi wrote: > Hi , > > I reported a bug in bugzilla.kernel.org for geneve issue: > https://bugzilla.kernel.org/show_bug.cgi?id=210569 > > Thanks & Best R

Re: [PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

2020-12-09 Thread Florian Fainelli
On 12/9/20 1:26 AM, Zheng Yongjun wrote: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Reviewed-by: Florian Fainelli -- Florian

Re: Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Martin Zaharinov
I make diff linux 4.14.211 and 4.15 kernel And changes is: atomic_inc to refcount_inc And on other part of code in ppp_generic.c remove skb_free …. You see diff down : --- linux-4.14.211/drivers/net/ppp/ppp_generic.c2020-12-08 09:17:35.0 + +++ linux-4.15/drivers/net/p

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 17:17:56 +0200 Paraschiv, Andra-Irina wrote: > > I agree that could be a problem, but here some considerations: > > - I checked some applications (qemu-guest-agent, ncat, iperf-vsock) and > >   all use the same pattern: allocate memory, initialize all the > >   sockaddr_vm to zer

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Willem de Bruijn
On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez wrote: > > > On 09/12/2020 15:48, Willem de Bruijn wrote: > > On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: > >> > >> Configure and send TX sending hardware timestamp from > >> user space application to the socket layer, > >> to provide to the TC E

Re: [PATCH] dt-bindings::Add compatible strings

2020-12-09 Thread Rob Herring
On Tue, 01 Dec 2020 21:26:10 -1000, xiao.ma wrote: > From: "xiao.ma" > > Add delta,q54sj108a2 to trivial-devices.yaml. > > Signed-off-by: xiao.ma > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Applied with subject fixed. 'git log --

Re: [PATCH 1/1] fix possible array overflow on receiving too many fragments for a packet

2020-12-09 Thread Shannon Nelson
On 12/7/20 8:06 PM, Xiaohui Zhang wrote: From: Zhang Xiaohui If the hardware receives an oversized packet with too many rx fragments, skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. This becomes especially visible if it corrupts the freelist pointer of a slab page. I f

Re: [PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set_rxfh()

2020-12-09 Thread Shannon Nelson
On 12/8/20 5:53 AM, Zheng Yongjun wrote: Simplify the return expression. Signed-off-by: Zheng Yongjun Acked-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/pensando/

Re: Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Guillaume Nault
On Wed, Dec 09, 2020 at 06:57:44PM +0200, Martin Zaharinov wrote: > > On 9 Dec 2020, at 18:40, Guillaume Nault wrote: > > On Wed, Dec 09, 2020 at 04:47:52PM +0200, Martin Zaharinov wrote: > >> Hi All > >> > >> I have problem with latest kernel release > >> And the problem is base on this late pr

Re: [net-next v3 05/15] ice: create flow profile

2020-12-09 Thread Nguyen, Anthony L
On Tue, 2020-12-08 at 14:22 -0800, Alexander Duyck wrote: > On Tue, Dec 8, 2020 at 2:01 PM Nguyen, Anthony L > wrote: > > > > On Tue, 2020-12-08 at 11:00 -0800, Alexander Duyck wrote: > > > On Tue, Dec 8, 2020 at 8:58 AM Nguyen, Anthony L > > > wrote: > > > > > > > > On Mon, 2020-11-23 at 17:11

Re: [PATCH v3 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 01:56:14 + Vladimir Oltean wrote: > On Mon, Dec 07, 2020 at 05:09:37PM -0800, Jakub Kicinski wrote: > > > + ocelot->owq = alloc_ordered_workqueue("ocelot-owq", WQ_MEM_RECLAIM); > > > > Why MEM_RECLAIM ? > > Ok, fine, I admit, I copied it. > > After reading the documenta

Re: [PATCH bpf-next v4 2/5] selftests/bpf: xsk selftests - SKB POLL, NOPOLL

2020-12-09 Thread Yonghong Song
On 12/7/20 1:53 PM, Weqaar Janjua wrote: Adds following tests: 1. AF_XDP SKB mode Generic mode XDP is driver independent, used when the driver does not have support for XDP. Works on any netdevice using sockets and generic XDP path. XDP hook from netif_receive_skb(). a. nopoll

Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)

2020-12-09 Thread Saeed Mahameed
On Wed, 2020-12-09 at 19:05 +0100, Eric Dumazet wrote: > On Wed, Dec 9, 2020 at 6:35 PM Eric Dumazet > wrote: > > Hmm... maybe the ECN stuff has always been buggy then, and nobody > > cared... > > > > Wait a minute, maybe this part was not needed, > > diff --git a/drivers/net/geneve.c b/drivers

[PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2020-12-09 Thread Willy Tarreau
This reverts commit 0a4e9ce17ba77847e5a9f87eed3c0ba46e3f82eb. The code was developed and tested on an MSC313E SoC, which seems to be half-way between the AT91RM9200 and the AT91SAM9260 in that it supports both the 2-descriptors mode and a Tx ring. It turns out that after the code was merged I cou

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-09 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 09 December 2020 16:17 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource > region reservation >

Re: [PATCH 3/3] net: mhi: Add dedicated alloc thread

2020-12-09 Thread Hemant Kumar
On 12/9/20 7:03 AM, Loic Poulain wrote: The buffer allocation for RX path is currently done by a work executed in the system workqueue. The work to do is quite simple and consists mostly in allocating and queueing as much as possible buffers to the MHI queuing RX channel. It appears that us

Re: [PATCH v2 bpf-next] bpf: increment and use correct thread iterator

2020-12-09 Thread Yonghong Song
On 12/4/20 9:14 AM, Jonathan Lemon wrote: On Fri, Dec 04, 2020 at 12:01:53AM -0800, Yonghong Song wrote: On 12/3/20 7:43 PM, Jonathan Lemon wrote: From: Jonathan Lemon Could you explain in the commit log what problem this patch tries to solve? What bad things could happen without this p

Re: [Intel-wired-lan] [PATCH v2 bpf 2/5] drivers/net: turn XDP properties on

2020-12-09 Thread kernel test robot
config: x86_64-randconfig-a003-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin

Re: [PATCHv3 net-next] octeontx2-pf: Add RSS multi group support

2020-12-09 Thread Saeed Mahameed
On Wed, 2020-12-09 at 22:39 +0530, Geetha sowjanya wrote: > Hardware supports 8 RSS groups per interface. Currently we are using > only group '0'. This patch allows user to create new RSS > groups/contexts > and use the same as destination for flow steering rules. > > usage: > To steer the traffic

Re: Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Martin Zaharinov
> On 9 Dec 2020, at 20:10, Guillaume Nault wrote: > > On Wed, Dec 09, 2020 at 06:57:44PM +0200, Martin Zaharinov wrote: >>> On 9 Dec 2020, at 18:40, Guillaume Nault wrote: >>> On Wed, Dec 09, 2020 at 04:47:52PM +0200, Martin Zaharinov wrote: Hi All I have problem with latest k

[PATCH] mt76: Fixed kernel test robot warning

2020-12-09 Thread Souptick Joarder
Kernel test robot throws below warning -> drivers/net/wireless/mediatek/mt76/tx.c: In function 'mt76_txq_schedule': >> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' >> set but not used [-Wunused-but-set-variable] 499 | struct mt76_queue *q; |

Re: [PATCH v11 0/4] Add support for mv88e6393x family of Marvell

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 15:02:54 +1000 Pavana Sharma wrote: > Updated patchset after incorporating feedback. This set does not apply to net-next. Please rebase.

Re: [PATCH net-next] net: sja1105: simplify the return sja1105_cls_flower_stats()

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 17:25:04 +0800 Zheng Yongjun wrote: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Looks like this one doesn't apply cleanly to net-next.

Re: [PATCHv3 net-next] octeontx2-pf: Add RSS multi group support

2020-12-09 Thread Jakub Kicinski
On Wed, 09 Dec 2020 11:08:24 -0800 Saeed Mahameed wrote: > > -/* Configure RSS table and hash key */ > > -static int otx2_set_rxfh(struct net_device *dev, const u32 *indir, > > -const u8 *hkey, const u8 hfunc) > > +static int otx2_get_rxfh_context(struct net_device *dev, u32 *in

Re: [PATCH net-next] vrf: handle CONFIG_IPV6 not set for vrf_add_mac_header_if_unset()

2020-12-09 Thread Jakub Kicinski
On Tue, 8 Dec 2020 12:51:55 -0700 David Ahern wrote: > On 12/8/20 10:52 AM, Andrea Mayer wrote: > > The vrf_add_mac_header_if_unset() is defined within a conditional > > compilation block which depends on the CONFIG_IPV6 macro. > > However, the vrf_add_mac_header_if_unset() needs to be called also

Re: [PATCH net-next v5 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property

2020-12-09 Thread Rob Herring
On Thu, 03 Dec 2020 11:21:10 +0100, Christian Eggers wrote: > The devices have an optional interrupt line. > > Signed-off-by: Christian Eggers > --- > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring

Re: linux-next: Tree for Dec 9 (ethernet/mellanox/mlx5)

2020-12-09 Thread Randy Dunlap
On 12/9/20 2:44 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20201208: > on i386: I see this warning:/note: repeated 106 times on i386 build: from ../drivers/net/ethernet/mellanox/mlx5/core/alloc.c:34: ../include/vdso/bits.h:7:26: warning: left shift count >= width

Re: [PATCH net-next] net: x25: Fix handling of Restart Request and Restart Confirmation

2020-12-09 Thread Xie He
On Wed, Dec 9, 2020 at 2:31 AM Martin Schiller wrote: > > >> 1. When the x25 module gets loaded, layer 2 may already be running and > >> connected. In this case, although we are in X25_LINK_STATE_0, we still > >> need to handle the Restart Request received, rather than ignore it. > > > > Hmm... I'

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Geva, Erez
On 09/12/2020 18:37, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez wrote: >> >> >> On 09/12/2020 15:48, Willem de Bruijn wrote: >>> On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: Configure and send TX sending hardware timestamp from user space applicatio

Re: [PATCH bpf-next] selftests/bpf: Fix selftest compilation on clang 11

2020-12-09 Thread Andrii Nakryiko
On Wed, Dec 9, 2020 at 7:16 AM Jiri Olsa wrote: > > We can't compile test_core_reloc_module.c selftest with clang 11, > compile fails with: > > CLNG-LLC [test_maps] test_core_reloc_module.o > progs/test_core_reloc_module.c:57:21: error: use of unknown builtin \ > '__builtin_preserve_type_inf

Fw: [Bug 210569] New: ping over geneve would fail

2020-12-09 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 09 Dec 2020 02:04:16 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 210569] New: ping over geneve would fail https://bugzilla.kernel.org/show_bug.cgi?id=210569 Bug ID: 210569 Summary: pin

Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)

2020-12-09 Thread Vlad Buslov
On Wed 09 Dec 2020 at 20:50, Eric Dumazet wrote: > On Wed, Dec 9, 2020 at 7:34 PM Saeed Mahameed wrote: >> >> On Wed, 2020-12-09 at 19:05 +0100, Eric Dumazet wrote: >> > On Wed, Dec 9, 2020 at 6:35 PM Eric Dumazet >> > wrote: >> > > Hmm... maybe the ECN stuff has always been buggy then, and nobo

Re: [PATCH -next] net/mlx5_core: remove unused including

2020-12-09 Thread Jason Gunthorpe
On Wed, Dec 09, 2020 at 09:04:46AM -0800, Jakub Kicinski wrote: > On Wed, 9 Dec 2020 08:21:00 +0200 Leon Romanovsky wrote: > > On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > > > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > > > Remove including that don't need it. > > >

[net-next v4 9/9] ice: Add space to unknown speed

2020-12-09 Thread Tony Nguyen
From: Simon Perron Caissy Add space to the end of 'Unknown' string in order to avoid concatenation with 'bps' string when formatting netdev log message. Signed-off-by: Simon Perron Caissy Tested-by: Aaron Brown Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +-

[net-next v4 5/9] ice: Remove vlan_ena from vsi structure

2020-12-09 Thread Tony Nguyen
From: Nick Nunley vlan_ena was introduced to track whether VLAN filters are enabled on the device, but 1) checking for num_vlan > 1 already gives us this information, and is currently used in this way throughout the code 2) the logic for vlan_ena is broken when multiple VLANs are active Just rem

[net-next v4 7/9] ice: silence static analysis warning

2020-12-09 Thread Tony Nguyen
From: Bruce Allan sparse warns about cast to/from restricted types which is not an actual problem; silence the warning. Signed-off-by: Bruce Allan Tested-by: Aaron Brown Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_nvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[net-next v4 1/9] ice: cleanup stack hog

2020-12-09 Thread Tony Nguyen
From: Bruce Allan In ice_flow_add_prof_sync(), struct ice_flow_prof_params has recently grown in size hogging stack space when allocated there. Hogging stack space should be avoided. Change allocation to be on the heap when needed. Signed-off-by: Bruce Allan Tested-by: Harikumar Bokkena Sign

[net-next v4 6/9] ice: cleanup misleading comment

2020-12-09 Thread Tony Nguyen
From: Bruce Allan The maximum Admin Queue buffer size and NVM shadow RAM sector size are both 4 Kilobytes. Some comments refer to those as 4Kb which can be confused with 4 Kilobits. Update the comments to use the commonly used KB symbol instead. Signed-off-by: Bruce Allan Tested-by: Aaron Brown

[net-next v4 2/9] ice: don't always return an error for Get PHY Abilities AQ command

2020-12-09 Thread Tony Nguyen
From: Paul M Stillwell Jr There are times when the driver shouldn't return an error when the Get PHY abilities AQ command (0x0600) returns an error. Instead the driver should log that the error occurred and continue on. This allows the driver to load even though the AQ command failed. The user ca

[net-next v4 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2020-12-09

2020-12-09 Thread Tony Nguyen
This series contains updates to ice driver only. Bruce changes the allocation of ice_flow_prof_params from stack to heap to avoid excessive stack usage. Corrects a misleading comment and silences a sparse warning that is not a problem. Paul allows for HW initialization to continue if PHY abilitie

[net-next v4 3/9] ice: Enable Support for FW Override (E82X)

2020-12-09 Thread Tony Nguyen
From: Jeb Cramer The driver is able to override the firmware when it comes to supporting a more lenient link mode. This feature was limited to E810 devices. It is now extended to E82X devices. Signed-off-by: Jeb Cramer Tested-by: Aaron Brown Signed-off-by: Tony Nguyen --- drivers/net/ether

[net-next v4 4/9] ice: Remove gate to OROM init

2020-12-09 Thread Tony Nguyen
From: Jeb Cramer Remove the gate that prevents the OROM and netlist info from being populated. The NVM now has the appropriate section for software to reference the versioning info. Signed-off-by: Jeb Cramer Tested-by: Aaron Brown Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ic

[net-next v4 8/9] ice: join format strings to same line as ice_debug

2020-12-09 Thread Tony Nguyen
From: Jacob Keller When printing messages with ice_debug, align the printed string to the origin line of the message in order to ease debugging and tracking messages back to their source. Signed-off-by: Jacob Keller Tested-by: Aaron Brown Signed-off-by: Tony Nguyen --- drivers/net/ethernet/i

RE: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-09 Thread David Laight
From: Xie He > Sent: 09 December 2020 03:34 > > According to the X.25 documentation, there was a plan to implement > X.25-over-802.2-LLC. It never finished but left various code stubs in the > X.25 code. At this time it is unlikely that it would ever finish so it > may be better to remove those co

RE: [EXT] Re: [PATCH v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-09 Thread Mickey Rachamim
Hi Andrew, > > You can see that only yesterday (Dec 8th) we had the first official > > merge on this repo - this is the reason for the lack of commits. > > Marvell Switching group took strategic decision to open some aspects > > of the Prestera family devices with the Open Source community and

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Tobias Waldekranz
On Wed, Dec 09, 2020 at 18:04, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 03:11:41PM +0100, Tobias Waldekranz wrote: >> On Wed, Dec 09, 2020 at 12:53, Vladimir Oltean wrote: >> > And I think that .port_lag_change passes more arguments than needed to >> > the driver. >> >> You mean the `str

Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

2020-12-09 Thread Xie He
On Wed, Dec 9, 2020 at 1:47 AM Xie He wrote: > > On Wed, Dec 9, 2020 at 1:41 AM Martin Schiller wrote: > > > > Right. > > By the way: A "Restart Collision" is in practice a very common event to > > establish the Layer 3. > > Oh, I see. Thanks! Hi Martin, When you submit future patch series, can

[PATCH net 1/4] netfilter: x_tables: Switch synchronization to RCU

2020-12-09 Thread Pablo Neira Ayuso
From: Subash Abhinov Kasiviswanathan When running concurrent iptables rules replacement with data, the per CPU sequence count is checked after the assignment of the new information. The sequence count is used to synchronize with the packet path without the use of any explicit locking. If there ar

[PATCH net 4/4] netfilter: nft_ct: Remove confirmation check for NFT_CT_ID

2020-12-09 Thread Pablo Neira Ayuso
From: Brett Mastbergen Since commit 656c8e9cc1ba ("netfilter: conntrack: Use consistent ct id hash calculation") the ct id will not change from initialization to confirmation. Removing the confirmation check allows for things like adding an element to a 'typeof ct id' set in prerouting upon rece

[PATCH net 2/4] netfilter: nft_dynset: fix timeouts later than 23 days

2020-12-09 Thread Pablo Neira Ayuso
Use nf_msecs_to_jiffies64 and nf_jiffies64_to_msecs as provided by 8e1102d5a159 ("netfilter: nf_tables: support timeouts larger than 23 days"), otherwise ruleset listing breaks. Fixes: a8b1e36d0d1d ("netfilter: nft_dynset: fix element timeout for HZ != 1000") Signed-off-by: Pablo Neira Ayuso ---

[PATCH net 3/4] netfilter: nftables: comment indirect serialization of commit_mutex with rtnl_mutex

2020-12-09 Thread Pablo Neira Ayuso
Add an explicit comment in the code to describe the indirect serialization of the holders of the commit_mutex with the rtnl_mutex. Commit 90d2723c6d4c ("netfilter: nf_tables: do not hold reference on netdevice from preparation phase") already describes this, but a comment in this case is better for

[PATCH net 0/4] Netfilter fixes for net

2020-12-09 Thread Pablo Neira Ayuso
Hi Jakub, David, The following patchset contains Netfilter fixes for net: 1) Switch to RCU in x_tables to fix possible NULL pointer dereference, from Subash Abhinov Kasiviswanathan. 2) Fix netlink dump of dynset timeouts later than 23 days. 3) Add comment for the indirect serialization of th

Re: linux-next: Tree for Dec 9 (ethernet/mellanox/mlx5)

2020-12-09 Thread Stephen Rothwell
Hi all, On Wed, 9 Dec 2020 12:14:39 -0800 Randy Dunlap wrote: > > On 12/9/20 2:44 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20201208: > > > > on i386: > > I see this warning:/note: repeated 106 times on i386 build: > > from ../drivers/net/ethernet/mella

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 11:01:25PM +0100, Tobias Waldekranz wrote: > It is not the Fibonacci sequence or anything, it is an integer in the > range 0..num_lags-1. I realize that some hardware probably allocate IDs > from some shared (and thus possibly non-contiguous) pool. Maybe ocelot > works like

Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 22:54:40 +0200 Vlad Buslov wrote: > > Yes, I think the patch I sent should fix this, ETH_P_ARP should not be > > dropped ;) > > > > I am testing this before offical patch submission. > > Your patch fixed TC geneve tests for me, but some of more complex OVS > tests are still fail

Re: [EXT] Re: [PATCH v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 09:38:52PM +, Mickey Rachamim wrote: > Hi Andrew, > > > > You can see that only yesterday (Dec 8th) we had the first official > > > merge on this repo - this is the reason for the lack of commits. > > > Marvell Switching group took strategic decision to open some aspe

RE: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

2020-12-09 Thread Wong, Vee Khee
> -Original Message- > From: Andrew Lunn > Sent: Thursday, December 10, 2020 12:09 AM > To: Wong, Vee Khee > Cc: Giuseppe Cavallaro ; Alexandre Torgue > ; Jose Abreu ; David > S . Miller ; Jakub Kicinski ; > Maxime Coquelin ; Voon, Weifeng > ; netdev@vger.kernel.org; linux- > ker...@vg

BPF selftests build failure in 5.10-rc

2020-12-09 Thread Seth Forshee
Building the BPF selftests with clang 11, I'm getting the following error: CLNG-LLC [test_maps] profiler1.o In file included from progs/profiler1.c:6: progs/profiler.inc.h:260:17: error: use of unknown builtin '__builtin_preserve_enum_value' [-Wimplicit-function-declaration]

[PATCH v2 net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

2020-12-09 Thread Wong Vee Khee
Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45. This extended the probing of C45 PHY devices on the MDIO bus. Signed-off-by: Wong Vee Khee --- v2 changelog: - Added conditional check for gmac4. --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 +++ 1 file changed, 3 inser

Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 22:07:54 +0100 Eric Dumazet wrote: > > Your patch fixed TC geneve tests for me, but some of more complex OVS > > tests are still failing. I'll try to provide details tomorrow. > > I think I need to study a bit more the original syzbot report. > > Apparently, network header shou

Re: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-09 Thread Xie He
On Wed, Dec 9, 2020 at 1:21 PM David Laight wrote: > > I always wondered about running Class 2 transport directly over LLC2 > (rather than Class 4 over LLC1). > But the only LLC2 user was netbios - and microsoft's LLC2 was broken. > Not to mention the window probing needed to handle systems that >

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Andrew Lunn
> so basically my point was that I think you are adding a lot of infra > in core DSA that only mv88e6xxx will use. That is true already, since mv88e6xxx is currently the only driver which supports D in DSA. And it has been Marvell devices which initially inspired the DSA framework, and has pushed

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 04:21:31PM +0100, Tobias Waldekranz wrote: > On Wed, Dec 09, 2020 at 15:27, Andrew Lunn wrote: > >> I disagree. A LAG is one type of netdev that a DSA port can offload. The > >> other one is the DSA port's own netdev, i.e. what we have had since time > >> immemorial. > >>

Re: [PATCH 0/2] Add LED mode behavior/select properties and handle

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 05:04:59PM +0300, Ivan Mikhaylov wrote: > In KSZ9131 PHY it is possible to control LEDs blink behavior via > LED mode behavior and select registers. Add DTS properties plus handles > of them inside micrel PHY driver. > > I've some concerns about passing raw register values

Re: [PATCH net-next 1/4] ptp: clockmatrix: reset device and check BOOT_STATUS

2020-12-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 8 Dec 2020 10:41:54 -0500 you wrote: > From: Min Li > > SM_RESET device only when loading full configuration and check > for BOOT_STATUS. Also remove polling for write trigger done in > _idtcm_settime(). > > Cha

Re: [PATCH v2 bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-09 Thread Alan Maguire
On Tue, 8 Dec 2020, Andrii Nakryiko wrote: > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE relocation, > put module BTF FD, containing target type, into upper 32 bits of imm64. > > Because this FD is internal to libbpf, it's very cumbersome to test this in > selftests. Manual

Re: [PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 03:03:47PM +1000, Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 03:23:40PM +0100, Andrew Lunn wrote: > On Wed, Dec 09, 2020 at 12:53:26PM +0200, Vladimir Oltean wrote: > > On Wed, Dec 09, 2020 at 09:37:39AM +0100, Tobias Waldekranz wrote: > > > I will remove `struct dsa_lag` in v4. > > > > Ok, thanks. > > It would be nice if you could al

Re: [PATCH 1/1] net/ipv4/inet_fragment: Batch fqdir destroy works

2020-12-09 Thread Jakub Kicinski
On Tue, 8 Dec 2020 10:45:29 +0100 SeongJae Park wrote: > From: SeongJae Park > > In 'fqdir_exit()', a work for destruction of the 'fqdir' is enqueued. > The work function, 'fqdir_work_fn()', calls 'rcu_barrier()'. In case of > intensive 'fqdir_exit()' (e.g., frequent 'unshare(CLONE_NEWNET)' > sy

Re: [PATCH v11 2/4] net: phy: Add 5GBASER interface mode

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 03:04:23PM +1000, Pavana Sharma wrote: > Add 5GBASE-R phy interface mode > > Signed-off-by: Pavana Sharma > --- > include/linux/phy.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 56563e5e0dc7..8151e6ecf1b

Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-09 Thread Alan Maguire
On Tue, 8 Dec 2020, Alexei Starovoitov wrote: > On Tue, Dec 08, 2020 at 10:13:35PM +, Alan Maguire wrote: > > > > Does this approach prevent more complex run-time specification of BTF > > object fd though? For example, I've been working on a simple tracer > > focused on kernel debugging; i

Re: [PATCH v11 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

2020-12-09 Thread Andrew Lunn
>On Wed, Dec 09, 2020 at 03:05:17PM +1000, Pavana Sharma wrote: > Returning 0 is no more an error case with MV88E6393 family > which has serdes lane numbers 0, 9 or 10. > So with this change .serdes_get_lane will return lane number > or -errno (-ENODEV or -EOPNOTSUPP). > > Signed-off-by: Pavana Sh

Re: [PATCH v11 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-12-09 Thread Andrew Lunn
> +/* Support 10, 100, 200, 1000, 2500, 5000, 1 Mbps (e.g. 88E6393X) > + * This function adds new speed 5000 supported by Amethyst family. > + * Function mv88e6xxx_port_set_speed_duplex() can't be used as the register > + * values for speeds 2500 & 5000 conflict. > + */ Thanks, that should sto

Re: [PATCH RESEND] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-09 Thread Jakub Kicinski
On Tue, 8 Dec 2020 12:56:32 -0600 Mario Limonciello wrote: > From: Vitaly Lifshits > > Changed a configuration in the flows to align with > architecture requirements to achieve S0i3.2 substate. > > This helps both i219V and i219LM configurations. > > Also fixed a typo in the previous commit 63

Re: [PATCH net] net: sched: incorrect Kconfig dependencies on Netfilter modules

2020-12-09 Thread Jakub Kicinski
On Tue, 8 Dec 2020 21:47:07 +0100 Pablo Neira Ayuso wrote: > - NET_ACT_CONNMARK and NET_ACT_CTINFO only require conntrack support. > - NET_ACT_IPT only requires NETFILTER_XTABLES symbols, not > IP_NF_IPTABLES. After this patch, NET_ACT_IPT becomes consistent > with NET_EMATCH_IPT. NET_ACT_IPT

Re: [PATCH net-next v5 0/9] XDP Redirect implementation for ENA driver

2020-12-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 8 Dec 2020 20:01:59 +0200 you wrote: > Hi all, > ENA is adding XDP Redirect support for its driver and some other > small tweaks. > > This series adds the following: > > - Make log messages in the driver have a u

[PATCH net-next 00/11] mptcp: Add port parameter to ADD_ADDR option

2020-12-09 Thread Mat Martineau
The ADD_ADDR MPTCP option is used to announce available IP addresses that a peer may connect to when adding more TCP subflows to an existing MPTCP connection. There is an optional port number field in that ADD_ADDR header, and this patch set adds capability for that port number to be sent and recei

[PATCH net-next 01/11] mptcp: unify ADD_ADDR and echo suboptions writing

2020-12-09 Thread Mat Martineau
From: Geliang Tang There are two differences between ADD_ADDR suboption and ADD_ADDR echo suboption: The length of the former is 8 octets longer than the length of the latter. The former's echo-flag is 0, and latter's echo-flag is 1. This patch added two local variables, len and echo, to unify A

[PATCH net-next 02/11] mptcp: unify ADD_ADDR and ADD_ADDR6 suboptions writing

2020-12-09 Thread Mat Martineau
From: Geliang Tang The length of ADD_ADDR6 is 12 octets longer than ADD_ADDR. That's the only difference between them. This patch dropped the duplicate code between ADD_ADDR and ADD_ADDR6 suboptions writing, and unify them into one. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau ---

Re: [PATCH net-next 4/4] net/mlx5e: Support HTB offload

2020-12-09 Thread kernel test robot
Hi Maxim, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100

<    1   2   3   4