On Wed, 2020-12-09 at 19:05 +0100, Eric Dumazet wrote:
> On Wed, Dec 9, 2020 at 6:35 PM Eric Dumazet <eduma...@google.com>
> wrote:
> > Hmm... maybe the ECN stuff has always been buggy then, and nobody
> > cared...
> >
>
> Wait a minute, maybe this part was not needed,
>
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index
> 8ae9ce2014a4a3ba7b962a209e28d1f65d4a83bd..896a7eb61d70340f69b9d3be0f7
> 95fbaab1458dd
> 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -270,7 +270,7 @@ static void geneve_rx(struct geneve_dev *geneve,
> struct geneve_sock *gs,
> goto rx_error;
> break;
> default:
> - goto rx_error;
> + break;
> }
> oiph = skb_network_header(skb);
> skb_reset_network_header(skb);
>
>
> > On Wed, Dec 9, 2020 at 6:20 PM Jakub Kicinski <k...@kernel.org>
> > wrote:
> > > Eric, could this possibly be commit 4179b00c04d1 ("geneve: pull
> > > IP
> > > header before ECN decapsulation")?
> > >
We've bisected an issue in our CI to this patch, something about geneve
TC offload traffic not passing, I don't have all the details, Maybe
Vlad can chime in.
