Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-07 Thread Alexei Starovoitov
On Mon, Dec 07, 2020 at 04:38:16PM +, Alan Maguire wrote: > On Fri, 4 Dec 2020, Andrii Nakryiko wrote: > > > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE > > relocation, > > put module BTF FD, containing target type, into upper 32 bits of imm64. > > > > Because this FD i

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Andrii Nakryiko
On Sun, Dec 6, 2020 at 9:21 PM wrote: > > From: Saeed Mahameed > > While playing with BTF for modules, i noticed that executing the command: > $ bpftool btf dump id > > Fails due to lack of information in the BTF data. > > Maybe I am missing a step but actually adding the support for this is > v

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-07 Thread Alexander Duyck
On Mon, Dec 7, 2020 at 3:03 PM Saeed Mahameed wrote: > > On Mon, 2020-12-07 at 13:16 -0800, Alexander Duyck wrote: > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > > wrote: > > > Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data > > > structure > > > in order to specify if this is

Re: [PATCH net-next v10 0/4] GVE Raw Addressing

2020-12-07 Thread Alexander Duyck
On Mon, Dec 7, 2020 at 2:45 PM David Awogbemila wrote: > > Patchset description: > This patchset introduces "raw addressing" mode to the GVE driver. > Previously (in "queue_page_list" or "qpl" mode), the driver would > pre-allocate and dma_map buffers to be used on egress and ingress. > On egress

Re: [PATCH] bpf: propagate __user annotations properly

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 7 Dec 2020 13:37:20 +0100 you wrote: > __htab_map_lookup_and_delete_batch() stores a user pointer in the local > variable ubatch and uses that in copy_{from,to}_user(), but ubatch misses a > __user annotation. > > So

Re: [pull request][for-next V2] mlx5-next auxbus support

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Sun, 6 Dec 2020 21:33:49 -0800 you wrote: > Hi Jakub, Jason > > v1->v2: Fix compilation warning when compiling with W=1 in the mlx5 > patches. > > This pull request is targeting net-next and rdma-next branches.

Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-07 Thread Andrii Nakryiko
On Sat, Dec 5, 2020 at 4:38 PM Alan Maguire wrote: > > On Fri, 4 Dec 2020, Andrii Nakryiko wrote: > > > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE > > relocation, > > put module BTF FD, containing target type, into upper 32 bits of imm64. > > > > Because this FD is internal

Re: [PATCH bpf] tools/bpftool: fix PID fetching with a lot of results

2020-12-07 Thread Yonghong Song
On 12/7/20 6:55 PM, Andrii Nakryiko wrote: On Sat, Dec 5, 2020 at 11:11 AM Yonghong Song wrote: On 12/4/20 3:20 PM, Andrii Nakryiko wrote: In case of having so many PID results that they don't fit into a singe page (4096) bytes, bpftool will erroneously conclude that it got corrupted dat

Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-07 Thread Andrii Nakryiko
On Mon, Dec 7, 2020 at 7:12 PM Alexei Starovoitov wrote: > > On Mon, Dec 07, 2020 at 04:38:16PM +, Alan Maguire wrote: > > On Fri, 4 Dec 2020, Andrii Nakryiko wrote: > > > > > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE > > > relocation, > > > put module BTF FD, containi

Re: [PATCH v2 bpf-next 0/3] bpf: support module BTF in BTF display helpers

2020-12-07 Thread Andrii Nakryiko
On Sat, Dec 5, 2020 at 4:44 PM Alan Maguire wrote: > > > On Sat, 5 Dec 2020, Yonghong Song wrote: > > > > > > > __builtin_btf_type_id() is really only supported in llvm12 > > and 64bit return value support is pushed to llvm12 trunk > > a while back. The builtin is introduced in llvm11 but has a >

Re: [PATCH bpf-next v3 1/5] selftests/bpf: xsk selftests framework

2020-12-07 Thread Yonghong Song
On 12/7/20 1:55 PM, Weqaar Janjua wrote: On Sat, 28 Nov 2020 at 03:13, Yonghong Song wrote: On 11/27/20 9:54 AM, Weqaar Janjua wrote: On Fri, 27 Nov 2020 at 04:19, Yonghong Song wrote: On 11/26/20 1:22 PM, Weqaar Janjua wrote: On Thu, 26 Nov 2020 at 09:01, Björn Töpel wrote: On

Refcount mismatch when unregistering netdevice from kernel

2020-12-07 Thread stranche
Hi everyone, We've recently been investigating a refcount problem when unregistering a netdevice from the kernel. It seems that the IPv6 module is still holding various references to the inet6_dev associated with the main netdevice struct that are not being released, preventing the unregistra

Re: [PATCH bpf-next v4 0/5] selftests/bpf: xsk selftests

2020-12-07 Thread Yonghong Song
On 12/7/20 1:53 PM, Weqaar Janjua wrote: This patch set adds AF_XDP selftests based on veth to selftests/bpf. # Topology: # - # --- # _ | Process | _ # / --- \ # /|\ #/ |

Re: [PATCH v2] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2020-12-07 Thread Andrea Parri
> > @@ -419,17 +446,52 @@ static u32 hv_pkt_iter_avail(const struct > > hv_ring_buffer_info *rbi) > > struct vmpacket_descriptor *hv_pkt_iter_first(struct vmbus_channel > > *channel) > > { > > struct hv_ring_buffer_info *rbi = &channel->inbound; > > - struct vmpacket_descriptor *desc; > >

[PATCH v3] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2020-12-07 Thread Andrea Parri (Microsoft)
From: Andres Beltran Pointers to ring-buffer packets sent by Hyper-V are used within the guest VM. Hyper-V can send packets with erroneous values or modify packet fields after they are processed by the guest. To defend against these scenarios, return a copy of the incoming VMBus packet after vali

Re: (subset) [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-07 Thread Martin K. Petersen
On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto/return/fal

RE: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Rakesh Pillai
Hi, > -Original Message- > From: Abhishek Kumar > Sent: Tuesday, December 8, 2020 4:50 AM > To: kv...@codeaurora.org > Cc: linux-ker...@vger.kernel.org; kua...@chromium.org; linux- > wirel...@vger.kernel.org; ath...@lists.infradead.org; > pill...@codeaurora.org; briannor...@chromium.org;

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-07 Thread Neftin, Sasha
On 12/7/2020 17:41, Limonciello, Mario wrote: First of all thank you for working on this. I must say though that I don't like the approach taken here very much. This is not so much a criticism of this series as it is a criticism of the earlier decision to simply disable s0ix on all devices with

Re: macb: should we revert 0a4e9ce17ba7 ("macb: support the two tx descriptors on at91rm9200") ?

2020-12-07 Thread Willy Tarreau
On Mon, Dec 07, 2020 at 03:40:42PM -0800, Jakub Kicinski wrote: > Thanks for the report, I remember that one. In hindsight maybe we > should have punted it to 5.11... Well, not necessarily as it was simple, well documented and *appeared* to work fine. > Let's revert ASAP, 5.10 is going to be LTS,

[PATCH] [v10] wireless: Initial driver submission for pureLiFi STA devices

2020-12-07 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in ARM

RE: [PATCH net-next v5] devlink: Add devlink port documentation

2020-12-07 Thread Parav Pandit
Hi Randy, > From: Randy Dunlap > Sent: Tuesday, December 8, 2020 6:45 AM > > > +An eswitch on the PCI device may suppport ports of multiple controllers. > > support > > > + > > +An example view of two controller systems:: > > I think that this is > > An

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Michal Kubecek
On Mon, Dec 07, 2020 at 02:11:48PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> + * expressed in terms of X in '(1 + X)*64 + 4' > > > > Is this way of expressing the min frag size from the standard? > >

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > From: Saeed Mahameed > > > > While playing with BTF for modules, i noticed that executing the > > command: > > $ bpftool btf dump id > > > > Fails due to lack of information in the BTF data. >

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Mon, 7 Dec 2020 12:14:38 -0800 > On Sun, Dec 06, 2020 at 01:03:07AM +0900, Kuniyuki Iwashima wrote: > > From: Martin KaFai Lau > > Date: Fri, 4 Dec 2020 17:42:41 -0800 > > > On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: > > > [ ... ] > > >

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Mon, 7 Dec 2020 12:33:15 -0800 > On Thu, Dec 03, 2020 at 11:14:24PM +0900, Kuniyuki Iwashima wrote: > > From: Eric Dumazet > > Date: Tue, 1 Dec 2020 16:25:51 +0100 > > > On 12/1/20 3:44 PM, Kuniyuki Iwashima wrote: > > > > This patch lets reuseport_detach_sock

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Andrii Nakryiko
On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed wrote: > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > > From: Saeed Mahameed > > > > > > While playing with BTF for modules, i noticed that executing the > > > command: > > > $ bpftool btf

[PATCH v2 bpf-next] bpf: return -ENOTSUPP when attaching to non-kernel BTF

2020-12-07 Thread Andrii Nakryiko
Return -ENOTSUPP if tracing BPF program is attempted to be attached with specified attach_btf_obj_fd pointing to non-kernel (neither vmlinux nor module) BTF object. This scenario might be supported in the future and isn't outright invalid, so -EINVAL isn't the most appropriate error code. Suggeste

Re: [RFC PATCH net-next 01/13] RDMA/mlx4: remove bogus dev_base_lock usage

2020-12-07 Thread Leon Romanovsky
On Mon, Dec 07, 2020 at 01:59:07AM +0200, Vladimir Oltean wrote: > The dev_base_lock does not protect dev->dev_addr, so it serves no > purpose here. > > Cc: Leon Romanovsky > Signed-off-by: Vladimir Oltean > --- > drivers/infiniband/hw/mlx4/main.c | 3 --- > 1 file changed, 3 deletions(-) Agree

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 22:38 -0800, Andrii Nakryiko wrote: > On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed > wrote: > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > > > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > > > From: Saeed Mahameed > > > > [...] > > > > > > > > I am not sure

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Andrii Nakryiko
On Mon, Dec 7, 2020 at 10:45 PM Saeed Mahameed wrote: > > On Mon, 2020-12-07 at 22:38 -0800, Andrii Nakryiko wrote: > > On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed > > wrote: > > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nakryiko wrote: > > > > On Sun, Dec 6, 2020 at 9:21 PM wrote: > > > >

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 19:16 -0800, Alexander Duyck wrote: > On Mon, Dec 7, 2020 at 3:03 PM Saeed Mahameed > wrote: > > On Mon, 2020-12-07 at 13:16 -0800, Alexander Duyck wrote: > > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi < > > > lore...@kernel.org> > > > wrote: > > > > Introduce multi-bu

RE: [PATCH net-next v5] devlink: Add devlink port documentation

2020-12-07 Thread Parav Pandit
> From: Randy Dunlap > Sent: Tuesday, December 8, 2020 6:45 AM > > Hi-- > > On 12/7/20 2:13 PM, Parav Pandit wrote: > > Added documentation for devlink port and port function related > commands. > > > > Signed-off-by: Parav Pandit > > Reviewed-by: Jiri Pirko > > Reviewed-by: Jacob Keller >

Re: [PATCH bpf] tools/bpftool: Add/Fix support for modules btf dump

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 22:48 -0800, Andrii Nakryiko wrote: > On Mon, Dec 7, 2020 at 10:45 PM Saeed Mahameed > wrote: > > On Mon, 2020-12-07 at 22:38 -0800, Andrii Nakryiko wrote: > > > On Mon, Dec 7, 2020 at 10:26 PM Saeed Mahameed > > > wrote: > > > > On Mon, 2020-12-07 at 19:14 -0800, Andrii Nak

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Martin KaFai Lau
On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: > @@ -242,8 +244,12 @@ void reuseport_detach_sock(struct sock *sk) > > reuse->num_socks--; > reuse->socks[i] = reuse->socks[reuse->num_socks]; > + prog = rcu_dereference(reuse->prog); > >

[PATCH net-next] net: dsa: mt7530: support setting ageing time

2020-12-07 Thread DENG Qingfang
MT7530 has a global address age control register, so use it to set ageing time. The applied timer is (AGE_CNT + 1) * (AGE_UNIT + 1) seconds Signed-off-by: DENG Qingfang --- drivers/net/dsa/mt7530.c | 41 drivers/net/dsa/mt7530.h | 13 + 2 fil

Re: [PATCH bpf-next v4 0/5] selftests/bpf: xsk selftests

2020-12-07 Thread Björn Töpel
On 2020-12-08 04:56, Yonghong Song wrote: On 12/7/20 1:53 PM, Weqaar Janjua wrote: This patch set adds AF_XDP selftests based on veth to selftests/bpf. [...] All tests passed in my environment. Tested-by: Yonghong Song Thanks for the hard work, Weqaar! And thanks Yonghong for testing/feed

Re: pull-request: wireless-drivers-next-2020-12-03

2020-12-07 Thread Emmanuel Grumbach
On Mon, Dec 7, 2020 at 10:14 PM Jakub Kicinski wrote: > > On Mon, 7 Dec 2020 11:35:53 -0800 Brian Norris wrote: > > On Mon, Dec 7, 2020 at 2:42 AM Kalle Valo wrote: > > > Jakub Kicinski writes: > > > > On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote: > > > > There's also a patch which

Re: BUG: unable to handle kernel paging request in bpf_lru_populate

2020-12-07 Thread Dmitry Vyukov
On Mon, Dec 7, 2020 at 12:43 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:bcd684aa net/nfc/nci: Support NCI 2.x initial sequence > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=12001bd350 > kernel config: https

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start

2020-12-07 Thread Kalle Valo
Xiaohui Zhang wrote: > From: Zhang Xiaohui > > mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary code. > Fix it by putting the length

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Martin KaFai Lau
On Tue, Dec 08, 2020 at 03:31:34PM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Mon, 7 Dec 2020 12:33:15 -0800 > > On Thu, Dec 03, 2020 at 11:14:24PM +0900, Kuniyuki Iwashima wrote: > > > From: Eric Dumazet > > > Date: Tue, 1 Dec 2020 16:25:51 +0100 > > > > On 12/1/20

[PATCH v2 1/1] xdp: avoid calling kfree twice

2020-12-07 Thread Zhu Yanjun
In the function xdp_umem_pin_pages, if npgs != umem->npgs and npgs >= 0, the function xdp_umem_unpin_pages is called. In this function, kfree is called to handle umem->pgs, and then in the function xdp_umem_pin_pages, kfree is called again to handle umem->pgs. Eventually, umem->pgs is freed twice.

general protection fault in hci_chan_del

2020-12-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b3298500 Merge tag 'for-5.10/dm-fixes' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=144f0bf750 kernel config: https://syzkaller.appspot.com/x/.config?x=e49433cfed49b7d9 das

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Mon, 7 Dec 2020 22:54:18 -0800 > On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: > > > @@ -242,8 +244,12 @@ void reuseport_detach_sock(struct sock *sk) > > > > reuse->num_socks--; > > reuse->socks[i] = reuse->socks[reus

Re: [PATCH] net: carl9170: remove trailing semicolon in macro definition

2020-12-07 Thread Kalle Valo
t...@redhat.com wrote: > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e65e8b608f68 carl9170: remove trailing semicolon in macro definition -- https://patchwork.kernel.org/project/linu

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-07 Thread Enrico Weigelt, metux IT consult
On 05.12.20 08:06, Sven Eckelmann wrote: Hi, > Is there some explanation besides an opinion? Some kind goal which you want > to > achieve with it maybe? Just a cleanup. I've been under the impression that this version is just an relic from oot times. > At least for us it was an easy way to qu

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Kalle Valo
Abhishek Kumar wrote: > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option looks as follows > board name 'bus=sn

<    1   2   3   4