> From: Randy Dunlap <rdun...@infradead.org>
> Sent: Tuesday, December 8, 2020 6:45 AM
>
> Hi--
>
> On 12/7/20 2:13 PM, Parav Pandit wrote:
> > Added documentation for devlink port and port function related
> commands.
> >
> > Signed-off-by: Parav Pandit <pa...@nvidia.com>
> > Reviewed-by: Jiri Pirko <j...@nvidia.com>
> > Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>
> > ---
> > Changelog:
> > v4->v5:
> > - described logically ingress and egress point of devlink port
> > - removed networking from devlink port description
> > - rephrased port type description
> > - introdue PCI controller section and description
>
> introduce
>
> > - rephrased controller, device, function description
> > - removed confusing eswitch to system wording
> > - rephrased port function description
> > - added example of mac address in port function attribute description
>
> > ---
> > .../networking/devlink/devlink-port.rst | 116 ++++++++++++++++++
> > Documentation/networking/devlink/index.rst | 1 +
> > 2 files changed, 117 insertions(+)
> > create mode 100644 Documentation/networking/devlink/devlink-port.rst
> >
> > diff --git a/Documentation/networking/devlink/devlink-port.rst
> > b/Documentation/networking/devlink/devlink-port.rst
> > new file mode 100644
> > index 000000000000..dce87d2c07ac
> > --- /dev/null
> > +++ b/Documentation/networking/devlink/devlink-port.rst
> > @@ -0,0 +1,116 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +============
> > +Devlink Port
> > +============
> > +
> > +``devlink-port`` is a port that exists on the device. It has a
> > +logically separate ingress/egress point of the device. A devlink port
> > +can be of one
>
> port can be any one
> of many flavours.
>
> > +among many flavours. A devlink port flavour along with port
> > +attributes describe what a port represents.
> > +
> > +A device driver that intends to publish a devlink port sets the
> > +devlink port attributes and registers the devlink port.
> > +
> > +Devlink port flavours are described below.
> > +
> > +.. list-table:: List of devlink port flavours
> > + :widths: 33 90
> > +
> > + * - Flavour
> > + - Description
> > + * - ``DEVLINK_PORT_FLAVOUR_PHYSICAL``
> > + - Any kind of physical networking port. This can be an eswitch
> > physical
> > + port or any other physical port on the device.
> > + * - ``DEVLINK_PORT_FLAVOUR_DSA``
> > + - This indicates a DSA interconnect port.
> > + * - ``DEVLINK_PORT_FLAVOUR_CPU``
> > + - This indicates a CPU port applicable only to DSA.
> > + * - ``DEVLINK_PORT_FLAVOUR_PCI_PF``
> > + - This indicates an eswitch port representing a networking port of
> > + PCI physical function (PF).
I forgot to remove 'networking' from the networking port here.
Will include this fix this in v6 in Saeed's subfunction patchset along with
addressing Randy's comments.
