Re: [PATCH] [v9] wireless: Initial driver submission for pureLiFi STA devices

2020-12-03 Thread Joe Perches
On Thu, 2020-12-03 at 10:39 +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. The below is a trivial readability possible enhancement and should not hinder this patch being applied. > diff --git a/drivers/net/wireless/purelifi/

[PATCH net-next] tun: fix ubuf refcount incorrectly on error path

2020-12-03 Thread wangyunjian
From: Yunjian Wang After setting callback for ubuf_info of skb, the callback (vhost_net_zerocopy_callback) will be called to decrease the refcount when freeing skb. But when an exception occurs afterwards, the error handling in vhost handle_tx() will try to decrease the same refcount again. This

[PATCH] net: phy: adin: add signal mean square error registers to phy-stats

2020-12-03 Thread Alexandru Ardelean
When the link is up on the ADIN1300/ADIN1200, the signal quality on each pair is indicated in the mean square error register for each pair (MSE_A, MSE_B, MSE_C, and MSE_D registers, Address 0x8402 to Address 0x8405, Bits[7:0]). These values can be useful for some industrial applications. This cha

Re: [PATCH v3 net-next 1/4] net: bonding: Notify ports about their initial state

2020-12-03 Thread Tobias Waldekranz
On Wed, Dec 02, 2020 at 16:39, Jay Vosburgh wrote: > Tobias Waldekranz wrote: >>I could look at hoisting up the linking op before the first >>notification. My main concern is that this is a new subsystem to me, so >>I am not sure how to determine the adequate test coverage for a change >>like thi

Re: [PATCH v3] net/af_unix: don't create a path for a binded socket

2020-12-03 Thread Denis Kirjanov
On 12/1/20, Jakub Kicinski wrote: > On Tue, 1 Dec 2020 12:33:06 +0300 Denis Kirjanov wrote: >> in the case of the socket which is bound to an adress >> there is no sense to create a path in the next attempts >> >> here is a program that shows the issue: >> >> int main() >> { >> int s; >>

[PATCH v4] net/af_unix: don't create a path for a bound socket

2020-12-03 Thread Denis Kirjanov
in the case of a socket which is already bound to an adress there is no sense to create a path in the next attempts here is a program that shows the issue: int main() { int s; struct sockaddr_un a; s = socket(AF_UNIX, SOCK_STREAM, 0); if (s<0) perror("socket() failed\n");

Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support

2020-12-03 Thread Vignesh Raghavendra
Hi Andrew, On 11/30/20 9:20 PM, Andrew Lunn wrote: > On Mon, Nov 30, 2020 at 01:50:43PM +0530, Vignesh Raghavendra wrote: >> AM65 NUSS ethernet switch on K3 devices can be configured to work either >> in independent mac mode where each port acts as independent network >> interface (multi mac) or s

[PATCH net] chelsio/chtls: fix a double free in chtls_setkey()

2020-12-03 Thread Dan Carpenter
The "skb" is freed by the transmit code in cxgb4_ofld_send() and we shouldn't use it again. But in the current code, if we hit an error later on in the function then the clean up code will call kfree_skb(skb) and so it causes a double free. Set the "skb" to NULL and that makes the kfree_skb() a n

RE: [PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-03 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 02 December 2020 18:16 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Patrick Havelange > Subject: [PATCH 2/4] net: freescale/fman-port: remove direct use of > _

Re: Long delay on estimation_timer causes packet latency

2020-12-03 Thread Julian Anastasov
Hello, On Thu, 3 Dec 2020, dust.li wrote: > Hi Yunhong & Julian, any updates ? > > > We've encountered the same problem. With lots of ipvs > > services plus many CPUs, it's easy to reproduce this issue. > > I have a simple script to reproduce: > > First add many ipvs services: > >

Re: [PATCH v3 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-03 Thread Oleksij Rempel
Hello Jakub and Andrew, > Ah, I missed the v3 (like most reviewers it seems :)). No problem, I moved your replies from v2 tread to this mail. On Wed, Dec 02, 2020 at 10:42:07AM -0800, Jakub Kicinski wrote: > On Wed, 2 Dec 2020 15:09:04 +0100 Oleksij Rempel wrote: > > Add stats support for the a

Re: [PATCH net-next v1 0/3] vsock: Add flag field in the vsock address

2020-12-03 Thread Stefano Garzarella
On Wed, Dec 02, 2020 at 06:18:15PM +0200, Paraschiv, Andra-Irina wrote: On 02/12/2020 15:37, Stefano Garzarella wrote: Hi Andra, On Tue, Dec 01, 2020 at 05:25:02PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. Nested VM

[PATCH v7 bpf-next 0/2] libbpf: add support for privileged/unprivileged control separation

2020-12-03 Thread mariusz . dudek
From: Mariusz Dudek This patch series adds support for separation of eBPF program load and xsk socket creation. In for example a Kubernetes environment you can have an AF_XDP CNI or daemonset that is responsible for launching pods that execute an application using AF_XDP sockets. It is desirabl

[PATCH v7 bpf-next 1/2] libbpf: separate XDP program load with xsk socket creation

2020-12-03 Thread mariusz . dudek
From: Mariusz Dudek Add support for separation of eBPF program load and xsk socket creation. This is needed for use-case when you want to privide as little privileges as possible to the data plane application that will handle xsk socket creation and incoming traffic. With this patch the data en

[PATCH v7 bpf-next 2/2] samples/bpf: sample application for eBPF load and socket creation split

2020-12-03 Thread mariusz . dudek
From: Mariusz Dudek Introduce a sample program to demonstrate the control and data plane split. For the control plane part a new program called xdpsock_ctrl_proc is introduced. For the data plane part, some code was added to xdpsock_user.c to act as the data plane entity. Application xdpsock_ctr

Re: [Intel-wired-lan] [PATCH] igc: Report speed and duplex as unknown when device is runtime suspended

2020-12-03 Thread Neftin, Sasha
On 12/2/2020 09:50, Kai-Heng Feng wrote: Similar to commit 165ae7a8feb5 ("igb: Report speed and duplex as unknown when device is runtime suspended"), if we try to read speed and duplex sysfs while the device is runtime suspeneded, igc will complain and stops working: [ 123.449883] igc :03:0

[PATCH] bpf, x64: bump the number of passes to 64

2020-12-03 Thread Gary Lin
The x64 bpf jit expects bpf images converge within the given passes, but it could fail to do so with some corner cases. For example: l0: ldh [4] l1: jeq #0x537d, l2, l40 l2: ld [0] l3: jeq #0xfa163e0d, l4, l40 l4: ldh [12] l5: ldx #0xe

[PATCH bpf v3] libbpf: sanitise map names before pinning

2020-12-03 Thread Toke Høiland-Jørgensen
When we added sanitising of map names before loading programs to libbpf, we still allowed periods in the name. While the kernel will accept these for the map names themselves, they are not allowed in file names when pinning maps. This means that bpf_object__pin_maps() will fail if called on an obje

Re: [PATCH bpf v2] libbpf: sanitise map names before pinning

2020-12-03 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Wed, Dec 2, 2020 at 3:19 AM Toke Høiland-Jørgensen wrote: >> >> When we added sanitising of map names before loading programs to libbpf, we >> still allowed periods in the name. While the kernel will accept these for >> the map names themselves, they are not allowed

Re: [PATCH 2/5] gtp: include role in link info

2020-12-03 Thread Jeremy Sowden
On 2020-12-02, at 13:33:42 +0100, Jonas Bonn wrote: > Querying link info for the GTP interface doesn't reveal in which > "role" the > device is set to operate. Include this information in the info query > result. > > Signed-off-by: Jonas Bonn > --- > drivers/net/gtp.c | 5 - > 1 file changed

[PATCH net v2] net/sched: act_mpls: ensure LSE is pullable before reading it

2020-12-03 Thread Davide Caratti
when 'act_mpls' is used to mangle the LSE, the current value is read from the packet dereferencing 4 bytes at mpls_hdr(): ensure that the label is contained in the skb "linear" area. Found by code inspection. v2: - use MPLS_HLEN instead of sizeof(new_lse), thanks to Jakub Kicinski Fixes: 2a2ea5

Re: [PATCH net-next v1 1/3] vm_sockets: Include flag field in the vsock address data structure

2020-12-03 Thread Stefan Hajnoczi
On Tue, Dec 01, 2020 at 05:25:03PM +0200, Andra Paraschiv wrote: > vsock enables communication between virtual machines and the host they > are running on. With the multi transport support (guest->host and > host->guest), nested VMs can also use vsock channels for communication. > > In addition to

Re: Linux IPV6 TCP egress path device passed for LOCAL_OUT hook is incorrect

2020-12-03 Thread Preethi Ramachandra
Thanks David for the response. Our local kernel doesn’t have vrf_ip6_out_direct patch. I will pick this change from upstream to fix the firewall issue. Thanks, Preethi On 03/12/20, 5:42 AM, "David Ahern" wrote: [External Email. Be cautious of content] On 12/2/20 4:31 AM, Preethi Ram

[PATCH net] net: openvswitch: ensure LSE is pullable before reading it

2020-12-03 Thread Davide Caratti
when openvswitch is configured to mangle the LSE, the current value is read from the packet dereferencing 4 bytes at mpls_hdr(): ensure that the label is contained in the skb "linear" area. Found by code inspection. Fixes: d27cf5c59a12 ("net: core: add MPLS update core helper and use in OvS") Sig

[PATCH net] net: skbuff: ensure LSE is pullable before decrementing the MPLS ttl

2020-12-03 Thread Davide Caratti
skb_mpls_dec_ttl() reads the LSE without ensuring that it is contained in the skb "linear" area. Fix this calling pskb_may_pull() before reading the current ttl. Found by code inspection. Fixes: 2a2ea50870ba ("net: sched: add mpls manipulation actions to TC") Reported-by: Marcelo Ricardo Leitner

[PATCH] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-03 Thread Mickey Rachamim
Add maintainers info for new Marvell Prestera Ethernet switch driver. Signed-off-by: Mickey Rachamim --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a7bdebf955bb..04a27eb89428 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10540,6 +105

[PATCH net-next v5 0/9] net: dsa: microchip: PTP support for KSZ956x

2020-12-03 Thread Christian Eggers
[1] http://ww1.microchip.com/downloads/en/DeviceDoc/KSZ9563R-Data-Sheet-DS2419D.pdf Changes from v4 --> v5 [8/9]- Fix compile error reported by kernel test robot (NET_DSA_TAG_KSZ must select NET_PTP_CLASSIFY) Changes from v3 --> v4 -

[PATCH net-next v5 1/9] net: dsa: microchip: rename ksz9477.c to ksz9477_main.c

2020-12-03 Thread Christian Eggers
PTP functionality will be built into a separate source file (ksz9477_ptp.c). Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/microchip/{ksz9477.c => ksz9477_main.c} | 0 2 files changed, 1 insertion(

[PATCH net-next v5 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property

2020-12-03 Thread Christian Eggers
The devices have an optional interrupt line. Signed-off-by: Christian Eggers --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings

[PATCH net-next v5 3/9] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init()

2020-12-03 Thread Christian Eggers
The next patch will add basic interrupt support. Chip reset must be performed before requesting the IRQ, so move this from ksz9477_setup() to ksz9477_init(). Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz9477_main.c | 15 +++ 1 file ch

[PATCH net-next v5 4/9] net: dsa: microchip: ksz9477: basic interrupt support

2020-12-03 Thread Christian Eggers
Interrupts are required for TX time stamping. Probably they could also be used for PHY connection status. This patch only adds the basic infrastructure for interrupts, no interrupts are finally enabled nor handled. Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- Changes in v4:

[PATCH net-next v5 5/9] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock

2020-12-03 Thread Christian Eggers
Implement routines (adjfine, adjtime, gettime and settime) for manipulating the chip's PTP clock. Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/Kconfig| 8 + drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/microchip/ksz947

[PATCH net-next v5 6/9] net: ptp: add helper for one-step P2P clocks

2020-12-03 Thread Christian Eggers
For P2P delay measurement, the ingress time stamp of the PDelay_Req is required for the correction field of the PDelay_Resp. The application echoes back the correction field of the PDelay_Req when sending the PDelay_Resp. Some hardware (like the ZHAW InES PTP time stamping IP core) subtracts the i

[PATCH net-next v5 7/9] net: dsa: microchip: ksz9477: initial hardware time stamping support

2020-12-03 Thread Christian Eggers
Add control routines required for TX hardware time stamping. The KSZ9563 only supports one step time stamping (HWTSTAMP_TX_ONESTEP_P2P), which requires linuxptp-2.0 or later. Currently, only P2P delay measurement is supported. See patchwork discussion and comments in ksz9477_ptp_init() for detail

[PATCH net-next v5 8/9] net: dsa: microchip: ksz9477: remaining hardware time stamping support

2020-12-03 Thread Christian Eggers
Add data path routines required for TX hardware time stamping. PTP mode is enabled depending on the filter setup (changes tail tag). TX time stamps are reported via an interrupt / device registers whilst RX time stamps are reported via an additional tail tag. One step TX time stamping of PDelay_R

[PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Christian Eggers
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to generate periodic signals. The pulse length can be altered via a device attribute. Tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- Changes in v4: -- - 80 chars per line - reverse christmas tre

Re: [PATCH net-next v1 1/3] vm_sockets: Include flag field in the vsock address data structure

2020-12-03 Thread Paraschiv, Andra-Irina
On 03/12/2020 11:21, Stefan Hajnoczi wrote: On Tue, Dec 01, 2020 at 05:25:03PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. With the multi transport support (guest->host and host->guest), nested VMs can also use vsock cha

Re: [PATCH net] net: bridge: Fix a warning when del bridge sysfs

2020-12-03 Thread Nikolay Aleksandrov
On 03/12/2020 03:03, Jakub Kicinski wrote: > On Tue, 1 Dec 2020 22:01:14 +0800 Wang Hai wrote: >> If adding bridge sysfs fails, br->ifobj will be NULL, there is no >> need to delete its non-existent sysfs when deleting the bridge device, >> otherwise, it will cause a warning. So, when br->ifobj ==

Re: [PATCH] bpf, x64: bump the number of passes to 64

2020-12-03 Thread Eric Dumazet
On 12/3/20 10:12 AM, Gary Lin wrote: > The x64 bpf jit expects bpf images converge within the given passes, but > it could fail to do so with some corner cases. For example: > > l0: ldh [4] > l1: jeq #0x537d, l2, l40 > l2: ld [0] > l3: jeq #0xfa163e0d, l4

RE: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-12-03 Thread Rakesh Pillai
> -Original Message- > From: Doug Anderson > Sent: Tuesday, December 1, 2020 12:49 AM > To: Rakesh Pillai > Cc: Abhishek Kumar ; Kalle Valo > ; LKML ; ath10k > ; Brian Norris ; > linux-wireless ; David S. Miller > ; Jakub Kicinski ; netdev > > Subject: Re: [PATCH v2 1/1] ath10k: add o

[PATCH][next] samples/bpf: Fix spelling mistake "recieving" -> "receiving"

2020-12-03 Thread Colin King
From: Colin Ian King There is a spelling mistake in an error message. Fix it. Signed-off-by: Colin Ian King --- samples/bpf/xdpsock_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index 0fee7f3aef3c..9553c7c47fc

Re: [PATCH v2 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls

2020-12-03 Thread Tom Parkin
On Thu, Dec 03, 2020 at 01:23:18 +0100, Guillaume Nault wrote: > On Tue, Dec 01, 2020 at 11:52:49AM +, Tom Parkin wrote: > > +static int ppp_bridge_channels(struct channel *pch, struct channel *pchb) > > +{ > > + write_lock_bh(&pch->upl); > > + if (pch->ppp || pch->bridge) { > > Since ->b

Re: [PATCH v7 0/4] Adding the Sparx5 Serdes driver

2020-12-03 Thread Steen Hegelund
On 03.12.2020 00:21, Vladimir Oltean wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hi Steen, On Wed, Dec 02, 2020 at 02:04:34PM +0100, Steen Hegelund wrote: Adding the Sparx5 Serdes driver ... -- 2.29.2 I think this series is interesti

[PATCH net-next 0/3] net: hns3: updates for -next

2020-12-03 Thread Huazhong Tan
There are some updates for the HNS3 ethernet driver. #1 supports an extended promiscuous command which makes promiscuous configuration more flexible, #2 adds ethtool private flags to control whether enable tx unicast promisc. #3 refine the vlan tag handling for port based vlan. Guojia Liao (2):

[PATCH net-next 3/3] net: hns3: refine the VLAN tag handle for port based VLAN

2020-12-03 Thread Huazhong Tan
From: Guojia Liao For DEVICE_VERSION_V2, the hardware only supports max two layer VLAN tags, including port based tag inserted by hardware, tag in tx buffer descriptor(get from skb->tci) and tag in packet. For tranmist packet: If port based VLAN disabled, and vf driver gets a VLAN tag from skb,

[PATCH net-next 1/3] net: hns3: add support for extended promiscuous command

2020-12-03 Thread Huazhong Tan
From: Guojia Liao For DEVICE_VERSION_V2, the hardware supports enable tx and rx promiscuous separately. But tx or rx promiscuous is active for unicast, multicast and broadcast promiscuous simultaneously. To support traffics between functions belong to the same port, we always enable tx promiscuou

[PATCH net-next 2/3] net: hns3: add priv flags support to switch limit promisc mode

2020-12-03 Thread Huazhong Tan
From: Jian Shen Currently, the tx unicast promisc is always enabled when promisc mode on. If tx unicast promisc on, a function will receive all unicast packet from other functions belong to the same port. Adds a ethtool private flags to control whether enable tx unicast promisc. Then the function

Re: [PATCH v6 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-12-03 Thread Marcel Holtmann
Hi Daniel, > This patch series defines the new two-call MGMT interface for adding > new advertising instances. Similarly to the hci advertising commands, a > mgmt call to set parameters is expected to be first, followed by a mgmt > call to set advertising data/scan response. The members of the > p

[PATCH 07/11] drivers: staging: vc04_services: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose. For in-tree drivers, the kernel version really matters. OTOH, the module version doesn't seem to be actively maintained - the code received changes while the version remained constant. Signed-off-by: Enrico Weigelt --- dr

[PATCH 09/11] drivers: staging: rtl8192e: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose: the driver has received lots of changes, while the module version remained constant. Unmaintained version numbers aren't actually useful. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1

[PATCH 02/11] drivers: staging: gasket: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code has received lots of changes, w/o the versions being actively maintained, so it doesn't seem to have much practical meaning. Signed-off-by: Enrico Weigelt --- dri

[PATCH 11/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. The driver received lots of changes, but module remained constant since it landed in mainline, several years ago. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1 del

[PATCH 10/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any pratical purpose. The code received lots of huge changes, but module version remained constant, since it landed in mainline tree, back 11 years go. Unmaintained version numbers aren't actually useful. For in-tree drivers, the kernel version re

[PATCH 08/11] drivers: staging: rtl8188eu: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters most. The driver received lots of changes, while module version remained constant, since it landed in mainline, back 7 years ago. Signed-off-by: Enrico Weigelt --- driver

[PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose. For in-kernel drivers, the kernel version matters. The driver received lots of changes, but version number has remained the same since it's introducing into mainline, seven years ago. So, it doesn't seem to have much practi

[PATCH 05/11] drivers: staging: media: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code received lots of changes, but module version remained constant, since the driver landed in mainline. So, this version doesn't seem have any practical meaning anymore

[PATCH 03/11] drivers: staging: gdm724x: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters. And the code has received lots of changes, without the version ever been touched (remained constant since landing in the mainline tree), so it doesn't seem to have any prac

[PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The drivers have received lots of changes, without the module version (or the underlying DRV_VERSION macro) ever changed, since the code landed in the kernel tree. So, it do

[PATCH 06/11] drivers: staging: qlge: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version really matters. The module version doesn't seem to be maintained and having much practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/qlge/qlge_main.c | 1 -

Re: VRF NS for lladdr sent on the wrong interface

2020-12-03 Thread Stephen Suryaputra
On Tue, Dec 01, 2020 at 06:06:53PM -0700, David Ahern wrote: > >> > >> With your patch does ping from both hosts work? > > > > Yes, it does. > > > >> What about all of the tests in > >> tools/testing/selftests/net/fcnal-test.sh? specifically curious about > >> the 'LLA to GUA' tests (link local t

Re: [PATCH v11 1/5] Bluetooth: Interleave with allowlist scan

2020-12-03 Thread Marcel Holtmann
Hi Howard, > This patch implements the interleaving between allowlist scan and > no-filter scan. It'll be used to save power when at least one monitor is > registered and at least one pending connection or one device to be > scanned for. > > The durations of the allowlist scan and the no-filter s

Re: [PATCH v11 4/5] Bluetooth: Refactor read default sys config for various types

2020-12-03 Thread Marcel Holtmann
Hi Howard, > Refactor read default system configuration function so that it's capable > of returning different types than u16 > > Signed-off-by: Howard Chung > --- > > (no changes since v8) > > Changes in v8: > - Update the commit title and message > > net/bluetooth/mgmt_config.c | 140 ++

Re: [PATCH v11 3/5] Bluetooth: Handle active scan case

2020-12-03 Thread Marcel Holtmann
Hi Howard, > This patch adds code to handle the active scan during interleave > scan. The interleave scan will be canceled when users start active scan, > and it will be restarted after active scan stopped. > > Signed-off-by: Howard Chung > Reviewed-by: Alain Michaud > Reviewed-by: Manish Mandl

Re: [PATCH v11 5/5] Bluetooth: Add toggle to switch off interleave scan

2020-12-03 Thread Marcel Holtmann
Hi Howard, > This patch add a configurable parameter to switch off the interleave > scan feature. > > Signed-off-by: Howard Chung > Reviewed-by: Alain Michaud > --- > > (no changes since v9) > > Changes in v9: > - Update and rename the macro TLV_GET_LE8 > > Changes in v7: > - Fix bt_dev_warn

Re: [PATCH v11 2/5] Bluetooth: Handle system suspend resume case

2020-12-03 Thread Marcel Holtmann
Hi Howard, > This patch adds code to handle the system suspension during interleave > scan. The interleave scan will be canceled when the system is going to > sleep, and will be restarted after waking up. > > Signed-off-by: Howard Chung > Reviewed-by: Alain Michaud > Reviewed-by: Manish Mandlik

Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Greg KH
On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it doesn't seem to serve any practical > purpose. For in-tree drivers, the kernel version matters. > > The drivers have received lots of changes, without the module version > (or the un

[PATCH AUTOSEL 5.9 03/39] iwlwifi: pcie: limit memory read spin time

2020-12-03 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 04516706bb99889986ddfa3a769ed50d2dc7ac13 ] When we read device memory, we lock a spinlock, write the address we want to read from the device and then spin in a loop reading the data in 32-bit quantities from another register. As the description makes clear,

[PATCH AUTOSEL 5.9 08/39] iwlwifi: mvm: fix kernel panic in case of assert during CSA

2020-12-03 Thread Sasha Levin
From: Sara Sharon [ Upstream commit fe56d05ee6c87f6a1a8c7267affd92c9438249cc ] During CSA, we briefly nullify the phy context, in __iwl_mvm_unassign_vif_chanctx. In case we have a FW assert right after it, it remains NULL though. We end up running into endless loop due to mac80211 trying repeat

[PATCH AUTOSEL 5.9 38/39] can: m_can: m_can_dev_setup(): add support for bosch mcan version 3.3.0

2020-12-03 Thread Sasha Levin
From: Pankaj Sharma [ Upstream commit 5c7d55bded77da6db7c5d249610e3a2eed730b3c ] Add support for mcan bit timing and control mode according to bosch mcan IP version 3.3.0. The mcan version read from the Core Release field of CREL register would be 33. Accordingly the properties are to be set for

[PATCH AUTOSEL 5.9 39/39] can: af_can: can_rx_unregister(): remove WARN() statement from list operation sanity check

2020-12-03 Thread Sasha Levin
From: Oliver Hartkopp [ Upstream commit d73ff9b7c4eacaba0fd956d14882bcae970f8307 ] To detect potential bugs in CAN protocol implementations (double removal of receiver entries) a WARN() statement has been used if no matching list item was found for removal. The fault injection issued by syzkall

[PATCH AUTOSEL 5.9 18/39] ibmvnic: skip tx timeout reset while in resetting

2020-12-03 Thread Sasha Levin
From: Lijun Pan [ Upstream commit 855a631a4c11458a9cef1ab79c1530436aa95fae ] Sometimes it takes longer than 5 seconds (watchdog timeout) to complete failover, migration, and other resets. In stead of scheduling another timeout reset, we wait for the current one to complete. Suggested-by: Brian

[PATCH AUTOSEL 5.4 03/23] iwlwifi: pcie: set LTR to avoid completion timeout

2020-12-03 Thread Sasha Levin
From: Johannes Berg [ Upstream commit edb625208d84aef179e3f16590c1c582fc5fdae6 ] On some platforms, the preset values aren't correct and then we may get a completion timeout in the firmware. Change the LTR configuration to avoid that. The firmware will do some more complex reinit of this later,

[PATCH AUTOSEL 5.4 11/23] tun: honor IOCB_NOWAIT flag

2020-12-03 Thread Sasha Levin
From: Jens Axboe [ Upstream commit 5aac0390a63b8718237a61dd0d24a29201d1c94a ] tun only checks the file O_NONBLOCK flag, but it should also be checking the iocb IOCB_NOWAIT flag. Any fops using ->read/write_iter() should check both, otherwise it breaks users that correctly expect O_NONBLOCK seman

[PATCH AUTOSEL 5.4 10/23] usbnet: ipheth: fix connectivity with iOS 14

2020-12-03 Thread Sasha Levin
From: Yves-Alexis Perez [ Upstream commit f33d9e2b48a34e1558b67a473a1fc1d6e793f93c ] Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic

[PATCH AUTOSEL 4.4 2/3] usbnet: ipheth: fix connectivity with iOS 14

2020-12-03 Thread Sasha Levin
From: Yves-Alexis Perez [ Upstream commit f33d9e2b48a34e1558b67a473a1fc1d6e793f93c ] Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic

[PATCH AUTOSEL 5.4 01/23] iwlwifi: pcie: limit memory read spin time

2020-12-03 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 04516706bb99889986ddfa3a769ed50d2dc7ac13 ] When we read device memory, we lock a spinlock, write the address we want to read from the device and then spin in a loop reading the data in 32-bit quantities from another register. As the description makes clear,

[PATCH AUTOSEL 5.4 23/23] can: af_can: can_rx_unregister(): remove WARN() statement from list operation sanity check

2020-12-03 Thread Sasha Levin
From: Oliver Hartkopp [ Upstream commit d73ff9b7c4eacaba0fd956d14882bcae970f8307 ] To detect potential bugs in CAN protocol implementations (double removal of receiver entries) a WARN() statement has been used if no matching list item was found for removal. The fault injection issued by syzkall

[PATCH AUTOSEL 4.9 4/5] usbnet: ipheth: fix connectivity with iOS 14

2020-12-03 Thread Sasha Levin
From: Yves-Alexis Perez [ Upstream commit f33d9e2b48a34e1558b67a473a1fc1d6e793f93c ] Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic

[PATCH AUTOSEL 4.9 1/5] iwlwifi: pcie: limit memory read spin time

2020-12-03 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 04516706bb99889986ddfa3a769ed50d2dc7ac13 ] When we read device memory, we lock a spinlock, write the address we want to read from the device and then spin in a loop reading the data in 32-bit quantities from another register. As the description makes clear,

[PATCH AUTOSEL 4.19 08/14] tun: honor IOCB_NOWAIT flag

2020-12-03 Thread Sasha Levin
From: Jens Axboe [ Upstream commit 5aac0390a63b8718237a61dd0d24a29201d1c94a ] tun only checks the file O_NONBLOCK flag, but it should also be checking the iocb IOCB_NOWAIT flag. Any fops using ->read/write_iter() should check both, otherwise it breaks users that correctly expect O_NONBLOCK seman

[PATCH AUTOSEL 4.14 7/9] tun: honor IOCB_NOWAIT flag

2020-12-03 Thread Sasha Levin
From: Jens Axboe [ Upstream commit 5aac0390a63b8718237a61dd0d24a29201d1c94a ] tun only checks the file O_NONBLOCK flag, but it should also be checking the iocb IOCB_NOWAIT flag. Any fops using ->read/write_iter() should check both, otherwise it breaks users that correctly expect O_NONBLOCK seman

[PATCH AUTOSEL 4.14 3/9] iwlwifi: mvm: fix kernel panic in case of assert during CSA

2020-12-03 Thread Sasha Levin
From: Sara Sharon [ Upstream commit fe56d05ee6c87f6a1a8c7267affd92c9438249cc ] During CSA, we briefly nullify the phy context, in __iwl_mvm_unassign_vif_chanctx. In case we have a FW assert right after it, it remains NULL though. We end up running into endless loop due to mac80211 trying repeat

[PATCH AUTOSEL 4.14 6/9] usbnet: ipheth: fix connectivity with iOS 14

2020-12-03 Thread Sasha Levin
From: Yves-Alexis Perez [ Upstream commit f33d9e2b48a34e1558b67a473a1fc1d6e793f93c ] Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic

[PATCH AUTOSEL 4.19 07/14] usbnet: ipheth: fix connectivity with iOS 14

2020-12-03 Thread Sasha Levin
From: Yves-Alexis Perez [ Upstream commit f33d9e2b48a34e1558b67a473a1fc1d6e793f93c ] Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic

[PATCH AUTOSEL 4.19 03/14] iwlwifi: mvm: fix kernel panic in case of assert during CSA

2020-12-03 Thread Sasha Levin
From: Sara Sharon [ Upstream commit fe56d05ee6c87f6a1a8c7267affd92c9438249cc ] During CSA, we briefly nullify the phy context, in __iwl_mvm_unassign_vif_chanctx. In case we have a FW assert right after it, it remains NULL though. We end up running into endless loop due to mac80211 trying repeat

[PATCH AUTOSEL 4.14 1/9] iwlwifi: pcie: limit memory read spin time

2020-12-03 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 04516706bb99889986ddfa3a769ed50d2dc7ac13 ] When we read device memory, we lock a spinlock, write the address we want to read from the device and then spin in a loop reading the data in 32-bit quantities from another register. As the description makes clear,

[PATCH AUTOSEL 5.4 12/23] ibmvnic: skip tx timeout reset while in resetting

2020-12-03 Thread Sasha Levin
From: Lijun Pan [ Upstream commit 855a631a4c11458a9cef1ab79c1530436aa95fae ] Sometimes it takes longer than 5 seconds (watchdog timeout) to complete failover, migration, and other resets. In stead of scheduling another timeout reset, we wait for the current one to complete. Suggested-by: Brian

[PATCH AUTOSEL 5.4 22/23] can: m_can: m_can_dev_setup(): add support for bosch mcan version 3.3.0

2020-12-03 Thread Sasha Levin
From: Pankaj Sharma [ Upstream commit 5c7d55bded77da6db7c5d249610e3a2eed730b3c ] Add support for mcan bit timing and control mode according to bosch mcan IP version 3.3.0. The mcan version read from the Core Release field of CREL register would be 33. Accordingly the properties are to be set for

[PATCH AUTOSEL 4.19 01/14] iwlwifi: pcie: limit memory read spin time

2020-12-03 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 04516706bb99889986ddfa3a769ed50d2dc7ac13 ] When we read device memory, we lock a spinlock, write the address we want to read from the device and then spin in a loop reading the data in 32-bit quantities from another register. As the description makes clear,

[PATCH AUTOSEL 5.4 04/23] iwlwifi: mvm: fix kernel panic in case of assert during CSA

2020-12-03 Thread Sasha Levin
From: Sara Sharon [ Upstream commit fe56d05ee6c87f6a1a8c7267affd92c9438249cc ] During CSA, we briefly nullify the phy context, in __iwl_mvm_unassign_vif_chanctx. In case we have a FW assert right after it, it remains NULL though. We end up running into endless loop due to mac80211 trying repeat

[PATCH AUTOSEL 5.9 06/39] iwlwifi: sta: set max HE max A-MPDU according to HE capa

2020-12-03 Thread Sasha Levin
From: Mordechay Goodstein [ Upstream commit c8a2e7a29702fe4626b7aa81149b7b7164e20606 ] Currently, our max tpt is limited to max HT A-MPDU for LB, and max VHT A-MPDU for HB. Configure HE exponent value correctly to achieve HE max A-MPDU, both on LB and HB. Signed-off-by: Mordechay Goodstein Sig

[PATCH AUTOSEL 5.9 07/39] iwlwifi: pcie: set LTR to avoid completion timeout

2020-12-03 Thread Sasha Levin
From: Johannes Berg [ Upstream commit edb625208d84aef179e3f16590c1c582fc5fdae6 ] On some platforms, the preset values aren't correct and then we may get a completion timeout in the firmware. Change the LTR configuration to avoid that. The firmware will do some more complex reinit of this later,

[PATCH AUTOSEL 5.9 16/39] usbnet: ipheth: fix connectivity with iOS 14

2020-12-03 Thread Sasha Levin
From: Yves-Alexis Perez [ Upstream commit f33d9e2b48a34e1558b67a473a1fc1d6e793f93c ] Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic

Re: [PATCH net-next v1 1/3] vm_sockets: Include flag field in the vsock address data structure

2020-12-03 Thread Stefano Garzarella
On Thu, Dec 03, 2020 at 12:32:08PM +0200, Paraschiv, Andra-Irina wrote: On 03/12/2020 11:21, Stefan Hajnoczi wrote: On Tue, Dec 01, 2020 at 05:25:03PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. With the multi transport

[PATCH AUTOSEL 5.9 17/39] tun: honor IOCB_NOWAIT flag

2020-12-03 Thread Sasha Levin
From: Jens Axboe [ Upstream commit 5aac0390a63b8718237a61dd0d24a29201d1c94a ] tun only checks the file O_NONBLOCK flag, but it should also be checking the iocb IOCB_NOWAIT flag. Any fops using ->read/write_iter() should check both, otherwise it breaks users that correctly expect O_NONBLOCK seman

Re: [PATCH net] net: bridge: Fix a warning when del bridge sysfs

2020-12-03 Thread wanghai (M)
在 2020/12/3 18:34, Nikolay Aleksandrov 写道: On 03/12/2020 03:03, Jakub Kicinski wrote: On Tue, 1 Dec 2020 22:01:14 +0800 Wang Hai wrote: If adding bridge sysfs fails, br->ifobj will be NULL, there is no need to delete its non-existent sysfs when deleting the bridge device, otherwise, it will c

Re: [PATCH 3/4] net: ti: am65-cpsw-nuss: Add switchdev support

2020-12-03 Thread Vignesh Raghavendra
On 11/30/20 10:50 PM, Andrew Lunn wrote: >> +static int am65_cpsw_port_stp_state_set(struct am65_cpsw_port *port, >> +struct switchdev_trans *trans, u8 state) >> +{ >> +struct am65_cpsw_common *cpsw = port->common; >> +u8 cpsw_state; >> +int ret =

[PATCH net 0/4] freescale/fman: remove usage of __devm_request_region

2020-12-03 Thread Patrick Havelange
Hello, This patch series is solving a bug inside ethernet/freescale/fman/fman_port.c caused by an incorrect usage of __devm_request_region. The bug came from the fact that the resource given as parameter to the function __devm_request_region is on the stack, leading to an invalid pointer being s

[PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-03 Thread Patrick Havelange
The main fman driver is only using some parts of the fman memory region. Split the reservation of the main region in 2, so that the other regions that will be used by fman-port and fman-mac drivers can be reserved properly and not be in conflict with the main fman reservation. Signed-off-by: Patri

[PATCH net 3/4] net: freescale/fman-mac: remove direct use of __devm_request_region

2020-12-03 Thread Patrick Havelange
Since the main fman driver is no longer reserving the complete fman memory region, it is no longer needed to use a custom call to __devm_request_region, so replace it with devm_request_mem_region Signed-off-by: Patrick Havelange --- drivers/net/ethernet/freescale/fman/mac.c | 8 +++- 1 file

  1   2   3   4   >