This series replaces further driver internal enumeration / uses of magic
numbers with the newly introduced PTP_MSGTYPE_* defines.
On Friday, 20 November 2020, 23:39:10 CET, Vladimir Oltean wrote:
> On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote:
> > This series introduces commen
Use recently introduced PTP wide defines instead of a driver internal
enumeration.
Signed-off-by: Christian Eggers
Cc: Petr Machata
Cc: Jiri Pirko
Cc: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c | 8
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h | 7 -
Use recently introduced PTP_MSGTYPE_SYNC and PTP_MSGTYPE_DELAY_REQ
defines instead of a driver internal enumeration.
Signed-off-by: Christian Eggers
Cc: Quentin Schulz
Cc: Antoine Tenart
Cc: Antoine Tenart
---
drivers/net/phy/mscc/mscc_ptp.c | 14 +++---
drivers/net/phy/mscc/mscc_ptp.
Replace use of magic number with recently introduced define.
Signed-off-by: Christian Eggers
Cc: Kurt Kanzenbach
---
drivers/net/phy/dp83640.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index f2caccaf4408..9757ca
On 11/20/2020 8:31 PM, Gustavo A. R. Silva wrote:
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gusta
From: Zhu Yanjun
The function xsk_map_inc always returns zero. As such, changing the
return type to void and removing the test code.
Signed-off-by: Zhu Yanjun
Signed-off-by: Zhu Yanjun
---
net/xdp/xsk.c|1 -
net/xdp/xsk.h|2 +-
net/xdp/xskmap.c | 10 ++
3 files chang
Hi Christian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Christian-Eggers/net-ptp-use-common-defines-for-PTP-message-types-in-further-drivers/20201122-163319
base: https://git.kernel.org/pub
From: Pablo Neira Ayuso
Date: Fri, 20 Nov 2020 13:49:12 +0100
> Hi,
>
> The following patchset augments the Netfilter flowtable fastpath to
> support for network topologies that combine IP forwarding, bridge and
> VLAN devices.
>
> This v5 includes updates for:
>
> - Patch #2: fix incorrect xm
On Sat, Nov 21, 2020 at 04:44:42PM -0800, Jakub Kicinski wrote:
> On Sat, 21 Nov 2020 13:35:58 +0100 Pablo Neira Ayuso wrote:
> > If the address type is missing through the control dissector, then
> > matching on IPv4 and IPv6 addresses does not work.
>
> Doesn't work where? Are you talking about
Hi Alexei,
On Sat, Nov 21, 2020 at 07:24:24PM -0800, Alexei Starovoitov wrote:
> On Sat, Nov 21, 2020 at 10:59 AM Pablo Neira Ayuso
> wrote:
> >
> > We're lately discussing more and more usecases in the NFWS meetings
> > where the egress can get really useful.
>
> We also discussed in the meeti
> -Original Message-
> From: Stefano Garzarella
> Sent: Friday, November 20, 2020 6:48 PM
> To: netdev@vger.kernel.org
> Cc: Sergio Lopez ; David S. Miller ;
> Stefano Garzarella ; Justin He ;
> k...@vger.kernel.org; linux-ker...@vger.kernel.org; Stefan Hajnoczi
> ; virtualizat...@lists
On Sat, Nov 21, 2020 at 10:49 PM Jakub Kicinski wrote:
>
> We're about to do reshuffling in networking headers and
> eliminate some implicit includes. This results in:
>
> In file included from ../net/ipv4/netfilter/arp_tables.c:26:
> include/net/compat.h:60:40: error: unknown type name ‘compat_up
Hi Jakub,
On Sat, Nov 21, 2020 at 11:23:48AM -0800, Jakub Kicinski wrote:
> On Sat, 21 Nov 2020 19:56:21 +0100 Pablo Neira Ayuso wrote:
> > > Please gather some review tags from senior netdev developers. I don't
> > > feel confident enough to apply this as 100% my own decision.
> >
> > Fair eno
On Sun, Nov 22, 2020 at 10:26:16AM +, Alexander Lobakin wrote:
> From: Pablo Neira Ayuso
> Date: Fri, 20 Nov 2020 13:49:12 +0100
[...]
> > Something like this:
> >
> >fast path
> > ..
> >/
enable the DEBUG in source code, and it will compile fail,
modify the DEBUG macro, to adapt the compile
Signed-off-by: hby
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/
On 11/19/2020 6:38 PM, Jakub Kicinski wrote:
On Thu, 19 Nov 2020 17:59:38 +0200 Tariq Toukan wrote:
On 11/19/2020 2:02 AM, Jakub Kicinski wrote:
On Sun, 15 Nov 2020 15:42:49 +0200 Tariq Toukan wrote:
This series opens TLS TX HW offload for bond interfaces.
This allows bond interfaces to ben
On Tue, Nov 17, 2020 at 10:57:52PM +0200, Julian Anastasov wrote:
>
> Hello,
>
> On Mon, 16 Nov 2020, Yejune Deng wrote:
>
> > atomic_inc_return() looks better
> >
> > Signed-off-by: Yejune Deng
>
> Looks good to me for -next, thanks!
>
> Acked-by: Julian Anastasov
Applied, tha
It is possible to fail receiving packets after calling
xsk_ring_cons__peek, at this condition, cached_cons has
been advanced, should be cancelled.
Signed-off-by: Li RongQing
---
tools/lib/bpf/xsk.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/lib/bpf/xsk.h b/tools/lib/bpf/xsk.
syzbot has found a reproducer for the following issue on:
HEAD commit:a349e4c6 Merge tag 'xfs-5.10-fixes-7' of git://git.kernel...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=144e1e9950
kernel config: https://syzkaller.appspot.com/x/.config?x=330f343
On 11/21/20 7:23 PM, Matthew Wilcox wrote:
> On Sat, Nov 21, 2020 at 08:50:58AM -0800, t...@redhat.com wrote:
>> The fixer review is
>> https://reviews.llvm.org/D91789
>>
>> A run over allyesconfig for x86_64 finds 62 issues, 5 are false positives.
>> The false positives are caused by macros pass
From: Pablo Neira Ayuso
Date: Sun, 22 Nov 2020 12:42:19 +0100
> On Sun, Nov 22, 2020 at 10:26:16AM +, Alexander Lobakin wrote:
>> From: Pablo Neira Ayuso
>> Date: Fri, 20 Nov 2020 13:49:12 +0100
> [...]
>>> Something like this:
>>>
>>>fast path
>>> .--
On Sun, Nov 22, 2020 at 06:46:46AM -0800, Tom Rix wrote:
>
> On 11/21/20 7:23 PM, Matthew Wilcox wrote:
> > On Sat, Nov 21, 2020 at 08:50:58AM -0800, t...@redhat.com wrote:
> >> The fixer review is
> >> https://reviews.llvm.org/D91789
> >>
> >> A run over allyesconfig for x86_64 finds 62 issues, 5
On 2020-11-21 15:36, Jakub Kicinski wrote:
On Fri, 20 Nov 2020 16:40:36 -0600 Lijun Pan wrote:
From: Dany Madden
Currently ibmvnic does not support the disable vnic command from the
Hardware Management Console. This patch enables ibmvnic to process
CRQ message 0x07, disable vnic adapter.
Wha
On 11/22/2020 1:58 AM, Jakub Kicinski wrote:
On Fri, 20 Nov 2020 15:03:32 -0800 Saeed Mahameed wrote:
From: Aya Levin
Expose FW indication that it supports stateless offloads for IP over IP
tunneled packets per direction. In some HW like ConnectX-4 IP-in-IP
support is not symmetric, it supp
On 11/22/20 6:56 AM, Matthew Wilcox wrote:
> On Sun, Nov 22, 2020 at 06:46:46AM -0800, Tom Rix wrote:
>> On 11/21/20 7:23 PM, Matthew Wilcox wrote:
>>> On Sat, Nov 21, 2020 at 08:50:58AM -0800, t...@redhat.com wrote:
The fixer review is
https://reviews.llvm.org/D91789
A run ov
On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote:
> > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote:
> > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote:
> > > > This series aims to fix almost all
On 11/21/20 9:10 AM, Joe Perches wrote:
> On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
>> A difficult part of automating commits is composing the subsystem
>> preamble in the commit log. For the ongoing effort of a fixer producing
>> one or two fixes a release the use of 'treewide:'
On Sun, 2020-11-22 at 08:10 -0800, Tom Rix wrote:
> On 11/22/20 6:56 AM, Matthew Wilcox wrote:
> > On Sun, Nov 22, 2020 at 06:46:46AM -0800, Tom Rix wrote:
> > > On 11/21/20 7:23 PM, Matthew Wilcox wrote:
> > > > On Sat, Nov 21, 2020 at 08:50:58AM -0800, t...@redhat.com
> > > > wrote:
> > > > > The
Should an error occur after calling 'ath10k_usb_create()', it should be
undone by a corresponding 'ath10k_usb_destroy()' call
Fixes: 4db66499df91 ("ath10k: add initial USB support")
Signed-off-by: Christophe JAILLET
---
This patch is speculative and compile tested only.
---
drivers/net/wireless/
If 'ath10k_usb_create()' fails, we should release some resources and report
an error instead of silently continuing.
Fixes: 4db66499df91 ("ath10k: add initial USB support")
Signed-off-by: Christophe JAILLET
---
drivers/net/wireless/ath/ath10k/usb.c | 2 ++
1 file changed, 2 insertions(+)
diff -
On Sat, Nov 21, 2020 at 11:22:49PM +0100, Florian Westphal wrote:
Cong Wang wrote:
From: Cong Wang
NF_HOOK_LIST() uses list_del() to remove skb from the linked list,
however, it is not sufficient as skb->next still points to other
skb. We should just call skb_list_del_init() to clear skb->nex
Do not hardcode /usr/lib/ip as a path and allow libraries path
configuration in run-time.
Signed-off-by: Sergey Ryazanov
---
ip/ip.c| 15 +++
ip/ip_common.h | 2 ++
ip/iplink.c| 5 +
3 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/ip/ip.c b/ip/ip.c
i
If 'kzalloc' fails, we must return an error code.
While at it, remove a useless initialization of 'err' which could hide the
issue.
Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Christophe JAILLET
---
drivers/net/wireless/ath/ath11k/qmi.c | 6 --
1
s/tranport/transport/
Signed-off-by: Christophe JAILLET
---
net/sctp/transport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sctp/transport.c b/net/sctp/transport.c
index 60fcf31cdcfb..bf0ac467e757 100644
--- a/net/sctp/transport.c
+++ b/net/sctp/transport.c
@@ -8
On Sun, 2020-11-22 at 08:17 -0800, Kees Cook wrote:
> On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> > On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote:
> > > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote:
> > > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R
On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote:
> On 11/21/20 9:10 AM, Joe Perches wrote:
> > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
> > > A difficult part of automating commits is composing the subsystem
> > > preamble in the commit log. For the ongoing effort of a fixer prod
On Sun, 2020-11-22 at 08:49 -0800, James Bottomley wrote:
> We can enforce sysfs_emit going forwards
> using tools like checkpatch
It's not really possible for checkpatch to find or warn about
sysfs uses of sprintf. checkpatch is really just a trivial
line-by-line parser and it has no concept of c
On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> Please tell me
> our reward for all this effort isn't a single missing error print.
There were quite literally dozens of logical defects found
by the fallthrough additions. Very few were logging only.
On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
> On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> > Please tell me our reward for all this effort isn't a single
> > missing error print.
>
> There were quite literally dozens of logical defects found
> by the fallthrough additions.
On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
> On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
> > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> > > Please tell me our reward for all this effort isn't a single
> > > missing error print.
> >
> > There were quite lit
'--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Li-RongQing/libbpf-add-support-for-canceling-cached_cons-advance/20201122-212415
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
conf
On 11/19/20 6:57 AM, Ido Schimmel wrote:
> From: Ido Schimmel
>
> Patch #1 prints the recently added 'RTNH_F_TRAP' flag.
>
> Patch #2 makes sure that nexthop flags are always printed for nexthop
> objects. Even when the nexthop does not have a device, such as a
> blackhole nexthop or a group.
>
On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote:
> On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
> > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
> > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> > > > Please tell me our reward for all this effort isn't a s
On Sun, Nov 22, 2020 at 08:29:22PM +0100, Christian Eggers wrote:
> On Sunday, 22 November 2020, 15:35:55 CET, Ido Schimmel wrote:
> > On Sun, Nov 22, 2020 at 09:26:35AM +0100, Christian Eggers wrote:
> > > Use recently introduced PTP wide defines instead of a driver internal
> > > enumeration.
> >
On Sun, Nov 22, 2020 at 02:51:18PM +, Alexander Lobakin wrote:
> From: Pablo Neira Ayuso
> Date: Sun, 22 Nov 2020 12:42:19 +0100
>
> > On Sun, Nov 22, 2020 at 10:26:16AM +, Alexander Lobakin wrote:
> >> From: Pablo Neira Ayuso
> >> Date: Fri, 20 Nov 2020 13:49:12 +0100
> > [...]
> >>> So
On Sun, Nov 22, 2020 at 7:22 PM James Bottomley
wrote:
>
> Well, it's a problem in an error leg, sure, but it's not a really
> compelling reason for a 141 patch series, is it? All that fixing this
> error will do is get the driver to print "oh dear there's a problem"
> under four more conditions
Fix build when CONFIG_IPV6 is not enabled by making a function
be built conditionally.
Fixes these build errors and warnings:
../drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c: In function
'accel_fs_tcp_set_ipv6_flow':
../include/net/sock.h:380:34: error: 'struct sock_common' has no m
> Align continuations of the lines under '(' like:
Oh... I didn't run the patch checker over this revised patch. In this case, I
am only changing the leading indent. Am I still expected to satisfy the patch
checker?
The current patch is very clear about what is happening if you do a diff -w but
On Sun, Nov 22, 2020 at 08:29:22PM +0100, Christian Eggers wrote:
> this was also not by intention. Vladimir found some files I missed in the
> first series. As the whole first series had already been reviewed at that
> time,
> I wasn't sure whether I am allowed to add further patches to it. Addit
Hi James.
> > > If none of the 140 patches here fix a real bug, and there is no
> > > change to machine code then it sounds to me like a W=2 kind of a
> > > warning.
> >
> > FWIW, this series has found at least one bug so far:
> > https://lore.kernel.org/lkml/CAFCwf11izHF=g1mGry1fE5kvFFFrxzhPSM6q
On Sun, 22 Nov 2020, Joe Perches wrote:
> On Sun, 2020-11-22 at 08:49 -0800, James Bottomley wrote:
> > We can enforce sysfs_emit going forwards
> > using tools like checkpatch
>
> It's not really possible for checkpatch to find or warn about
> sysfs uses of sprintf. checkpatch is really just a
On Sun, 2020-11-22 at 21:35 +0100, Miguel Ojeda wrote:
> On Sun, Nov 22, 2020 at 7:22 PM James Bottomley
> wrote:
> > Well, it's a problem in an error leg, sure, but it's not a really
> > compelling reason for a 141 patch series, is it? All that fixing
> > this error will do is get the driver to
> (Next time please include in the subject the tree that you're targetting
> the patch)
I guess you mean like [PATCH master v5] ? Should I be targeting something other
than the master branch on the main git repo?
(https://github.com/torvalds/linux.git)
> please add a From: line at the beginning
On Sun, 22 Nov 2020, Miguel Ojeda wrote:
>
> It isn't that much effort, isn't it? Plus we need to take into account
> the future mistakes that it might prevent, too.
We should also take into account optimisim about future improvements in
tooling.
> So even if there were zero problems found
On Mon, 2020-11-23 at 09:54 +1100, Finn Thain wrote:
> But is anyone keeping score of the regressions? If unreported bugs
> count, what about unreported regressions?
Well, I was curious about the former (obviously no tool will tell me
about the latter), so I asked git what patches had a fall-throu
Hi Kurt,
On Sat, Nov 21, 2020 at 12:57:03PM +0100, Kurt Kanzenbach wrote:
> The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic
> schedules may be configured individually on each front port. Each port has
> eight
> egress queues. The traffic is mapped to a traffic class respe
On Sat, Nov 21, 2020 at 12:44:54PM +0100, Kurt Kanzenbach wrote:
> Remove unused and add needed includes. No functional change.
>
> Suggested-by: Vladimir Oltean
> Signed-off-by: Kurt Kanzenbach
> ---
Reviewed-by: Vladimir Oltean
On Sat, Nov 21, 2020 at 12:44:55PM +0100, Kurt Kanzenbach wrote:
> When DSA is not loaded when the driver is probed an error message is
> printed. But, that's not really an error, just a defer. Use dev_err_probe()
> instead.
>
> Signed-off-by: Kurt Kanzenbach
> ---
Reviewed-by: Vladimir Oltean
Hi George,
On Fri, Nov 20, 2020 at 12:16:26PM -0600, George McCollister wrote:
> Add a driver with initial support for the Arrow SpeedChips XRS7000
> series of gigabit Ethernet switch chips which are typically used in
> critical networking applications.
>
> The switches have up to three RGMII por
Constify a couple of static qmi_ops and qmi_msg_handler structs that are
never modified.
Rikard Falkeborn (2):
soc: qcom: ipa: Constify static qmi structs
ath10k: Constify static qmi structs
drivers/net/ipa/ipa_qmi.c | 8
drivers/net/wireless/ath/ath10k/qmi.c | 4 ++--
qmi_msg_handler[] and ath10k_qmi_ops are only used as input arguments
to qmi_handle_init() which accepts const pointers to both qmi_ops and
qmi_msg_handler. Make them const to allow the compiler to put them in
read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/wireless/ath/ath10k/
These are only used as input arguments to qmi_handle_init() which
accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
const to allow the compiler to put them in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/ipa/ipa_qmi.c | 8
1 file changed, 4 inser
On 2020-11-21 11:09 a.m., Vlad Buslov wrote:
Currently both filter and action flags use same "TCA_" prefix which makes
them hard to distinguish to code and confusing for users. Create aliases
for existing action flags constants with "TCA_ACT_" prefix.
Signed-off-by: Vlad Buslov
LGTM, thanks f
On Sat, Nov 21, 2020 at 07:13:22PM +0900, Kuniyuki Iwashima wrote:
> From: Martin KaFai Lau
> Date: Thu, 19 Nov 2020 17:53:46 -0800
> > On Fri, Nov 20, 2020 at 07:09:22AM +0900, Kuniyuki Iwashima wrote:
> > > From: Martin KaFai Lau
> > > Date: Wed, 18 Nov 2020 15:50:17 -0800
> > > > On Tue, N
On Mon, 2020-11-23 at 09:33 +1100, Finn Thain wrote:
> On Sun, 22 Nov 2020, Joe Perches wrote:
> > But provably correct conversions IMO _should_ be done and IMO churn
> > considerations should generally have less importance.
[]
> Moreover, the patch review workload for skilled humans is being gen
Hi Jakub,
Sorry for the inconvenience, we have optimized the build bot to avoid
this situation.
Best Regards,
Rong Chen
On 11/14/20 12:57 AM, Jakub Kicinski wrote:
Good people of build bot,
would you mind shedding some light on this one? It was also reported on
v1, and Andrea said it's impo
Switch to using the new API kobj_to_dev().
Signed-off-by: Tian Tao
---
drivers/net/wireless/ti/wlcore/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wlcore/sysfs.c
b/drivers/net/wireless/ti/wlcore/sysfs.c
index 7ac1814..5cf0379 100644
--- a/d
> -Original Message-
> From: Jiri Pirko
> Sent: Saturday, November 21, 2020 7:44 PM
> To: George Cherian
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> k...@kernel.org; da...@davemloft.net; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> Geethasowjanya Akula ; masahi...@kerne
Have run into a case where bond_option_mode_set() gets called before
hw_features has been filled in, and very bad things happen when
netdev_change_features() then gets called, because the empty hw_features
wipes out almost all features. Further reading of netdev feature flag
documentation suggests
On Sun, Nov 22, 2020 at 5:45 AM Miguel Ojeda
wrote:
>
> On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote:
> >
> > Our goal is to always enable __must_check where appreciate, so this
> > CONFIG option is no longer needed.
>
> This would be great. It also implies we can then move it to
> `comp
On Wed, Nov 11, 2020 at 5:04 PM Jakub Kicinski wrote:
>
> On Wed, 11 Nov 2020 12:13:56 -0800 Jay Vosburgh wrote:
> > Jarod Wilson wrote:
> >
> > >The bonding driver's use of master and slave, while largely understood
> > >in technical circles, poses a barrier for inclusion to some potential
> > >
MT762x HW, except for MT7628, supports frame length up to 2048
(maximum length on GDM), so allow setting MTU up to 2030.
Signed-off-by: DENG Qingfang
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 36 -
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 11 +--
2 files chan
> Yep, that could be the only way to fix this for now.
> Have you tried to estimate any performance drops from this?
Unfortunately, I am not in a very good position to do this. The 10G interfaces
on our device don't actually have enough raw PCI bandwidth available to hit 10G
transfer rates.
I d
On 11/22/2020 12:53 AM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Fri, 20 Nov 2020 15:40:37 +0200 Moshe Shemesh wrote:
Fix reload stats structure exposed to the user. Change stats structure
hierarchy to have the reload action as a parent of the stat en
Fix reload stats structure exposed to the user. Change stats structure
hierarchy to have the reload action as a parent of the stat entry and
then stat entry includes value per limit. This will also help to avoid
string concatenation on iproute2 output.
Reload stats structure before this fix:
"stat
On 2020-11-20 19:28, Jakub Kicinski wrote:
On Wed, 18 Nov 2020 07:39:19 +0100 Martin Schiller wrote:
Call netdev notifiers before and after changing the device type.
Signed-off-by: Martin Schiller
This is a fix, right? Can you give an example of something that goes
wrong without this patch?
On 2020-11-21 00:50, Xie He wrote:
On Fri, Nov 20, 2020 at 3:11 PM Xie He wrote:
Should we also handle the NETDEV_UP event here? In previous versions
of this patch series you seemed to want to establish the L2 connection
on device-up. But in this patch, you didn't handle NETDEV_UP.
Maybe on d
On Sun, Nov 22, 2020 at 04:35:58PM +0200, Ido Schimmel wrote:
> Anyway, I added all six patches to our regression as we have some PTP
> tests. Will let you know tomorrow.
Looks good
From: Ido Schimmel
Unresolved nexthops are currently written to the adjacency table with a
discard action. Packets hitting such entries are trapped to the CPU via
the 'DISCARD_ROUTER3' trap which can be enabled or disabled on demand,
but is always enabled in order to ensure the kernel can resolve
From: Ido Schimmel
This patch set adds support for blackhole nexthops in mlxsw. These
nexthops are exactly the same as other nexthops, but instead of
forwarding packets to an egress router interface (RIF), they are
programmed to silently drop them.
Patches #1-#4 are preparations.
Patch #5 adds
From: Ido Schimmel
The two are the same, but for blackhole nexthops we will not have an
associated neighbour struct, so resolve the RIF from the nexthop struct
itself instead.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
From: Ido Schimmel
Add support for blackhole nexthops by programming them to the adjacency
table with a discard action.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
.../ethernet/mellanox/mlxsw/spectrum_dpipe.c | 9 ++--
.../ethernet/mellanox/mlxsw/spectrum_router.c | 48 +
From: Ido Schimmel
Test that IPv4 and IPv6 ping fail when the route is using a blackhole
nexthop or a group with a blackhole nexthop. Test that ping passes when
the route starts using a valid nexthop.
Signed-off-by: Ido Schimmel
---
.../net/forwarding/router_mpath_nh.sh | 58 ++
From: Ido Schimmel
Register with devlink the blackhole_nexthop trap so that mlxsw will be
able to report packets dropped due to a blackhole nexthop.
The internal trap identifier is "DISCARD_ROUTER3", which traps packets
dropped in the adjacency table.
Signed-off-by: Ido Schimmel
Reviewed-by: J
From: Ido Schimmel
Test that packets hitting a blackhole nexthop are trapped to the CPU
when the trap is enabled. Test that packets are not reported when the
trap is disabled.
Signed-off-by: Ido Schimmel
---
.../net/mlxsw/devlink_trap_l3_drops.sh| 36 +++
1 file changed
From: Ido Schimmel
Now that the driver creates a loopback RIF during its initialization, it
can be used to program the adjacency entries for unresolved nexthops
instead of other RIFs. The loopback RIF is guaranteed to exist for the
entire life time of the driver, unlike other RIFs that come and g
From: Ido Schimmel
Test the mlxsw allows blackhole nexthops to be installed and that the
nexthops are marked as offloaded.
Signed-off-by: Ido Schimmel
---
.../selftests/drivers/net/mlxsw/rtnetlink.sh | 25 ---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/tool
From: Ido Schimmel
Add a packet trap to report packets that were dropped due to a
blackhole nexthop.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
Documentation/networking/devlink/devlink-trap.rst | 4
include/net/devlink.h | 4 +++-
net/core/devlink
From: Ido Schimmel
Up until now RIFs (router interfaces) were created on demand (e.g.,
when an IP address was added to a netdev). However, sometimes the device
needs to be provided with a RIF when one might not be available.
For example, adjacency entries that drop packets need to be programmed
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindin
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 uses NCI protocol and supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/Kconfig | 12 ++
drivers/nfc/s3fwrn5/Makefile | 2 +
drivers/nfc/s3fwrn5/uart.c | 250
91 matches
Mail list logo
