On Sun, Nov 22, 2020 at 08:29:22PM +0100, Christian Eggers wrote: > On Sunday, 22 November 2020, 15:35:55 CET, Ido Schimmel wrote: > > On Sun, Nov 22, 2020 at 09:26:35AM +0100, Christian Eggers wrote: > > > Use recently introduced PTP wide defines instead of a driver internal > > > enumeration. > > > > > > Signed-off-by: Christian Eggers <cegg...@gmx.de> > > > Cc: Petr Machata <pe...@mellanox.com> > > > Cc: Jiri Pirko <j...@nvidia.com> > > > Cc: Ido Schimmel <ido...@nvidia.com> > > > > Reviewed-by: Ido Schimmel <ido...@nvidia.com> > > > > But: > > > > 1. Checkpatch complains about: > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Christian > > Eggers <cegg...@arri.de>' != 'Signed-off-by: Christian Eggers > > <cegg...@gmx.de>' > unfortunately I changed this after running checkpatch. My intention was to > separate my (private) weekend work from the patches I do while I'm on the job.
No problem. Just make sure that authorship and Signed-off-by agree. You can use: # git commit --amend --author="Christian Eggers <cegg...@gmx.de>" > > > 2. This series does not build, which fails the CI [1][2] and also > > required me to fetch the dependencies that are currently under review > > [3]. I believe it is generally discouraged to create dependencies > > between patch sets that are under review for exactly these reasons. > this was also not by intention. Vladimir found some files I missed in the > first series. As the whole first series had already been reviewed at that > time, > I wasn't sure whether I am allowed to add further patches to it. Additionally > I didn't concern that although my local build is successful, I should wait > until the first series is applied... Yea, I saw that, no problem :) > > > I don't know what are Jakub's preferences, but had this happened on our > > internal patchwork instance, I would just ask the author to submit > > another version with all the patches. > Please let me know how I shall proceed... Jakub has the final say, so I assume he will comment on that. Regardless, thanks for the patches.
