Re: [PATCH net-next V6] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-19 Thread Dmytro Shytyi
On Thu, 19 Nov 2020 19:44:13 +0100 Jakub Kicinski wrote > On Thu, 19 Nov 2020 14:37:35 +0100 Dmytro Shytyi wrote: > > +struct inet6_ifaddr *ipv6_cmp_rcvd_prsnt_prfxs(struct inet6_ifaddr *ifp, > > + struct inet6_dev *in6_dev, > > +

Re: violating function pointer signature

2020-11-19 Thread Segher Boessenkool
On Thu, Nov 19, 2020 at 05:42:34PM +, David Laight wrote: > From: Segher Boessenkool > > Sent: 19 November 2020 16:35 > > I just meant "valid C language code as defined by the standards". Many > > people want all UB to just go away, while that is *impossible* to do for > > many compilers: for

Re: [PATCH V1 net 2/4] net: ena: set initial DMA width to avoid intel iommu issue

2020-11-19 Thread Heiner Kallweit
Am 19.11.2020 um 20:18 schrieb Shay Agroskin: > > Heiner Kallweit writes: > >> Am 18.11.2020 um 23:35 schrieb Heiner Kallweit: >>> Am 18.11.2020 um 22:59 schrieb Shay Agroskin: The ENA driver uses the readless mechanism, which uses DMA, to find out what the DMA mask is supposed to be.

[PATCH net-next 04/10] selftests: mptcp: add link failure test case

2020-11-19 Thread Mat Martineau
From: Florian Westphal Add a test case where a link fails with multiple subflows. The expectation is that MPTCP will transmit any data that could not be delivered via the failed link on another subflow. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Florian Westphal

[PATCH net-next 08/10] selftests: mptcp: add ADD_ADDR IPv6 test cases

2020-11-19 Thread Mat Martineau
From: Geliang Tang This patch added IPv6 support for do_transfer, and the test cases for ADD_ADDR IPv6. Acked-by: Paolo Abeni Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp/mptcp_join.sh | 70 ++- 1 file changed, 69 insertions(+),

[PATCH net-next 00/10] mptcp: More miscellaneous MPTCP fixes

2020-11-19 Thread Mat Martineau
Here's another batch of fixup and enhancement patches that we have collected in the MPTCP tree. Patch 1 removes an unnecessary flag and related code. Patch 2 fixes a bug encountered when closing fallback sockets. Patches 3 and 4 choose a better transmit subflow, with a self test. Patch 5 adjust

[PATCH net-next 07/10] mptcp: send out dedicated ADD_ADDR packet

2020-11-19 Thread Mat Martineau
From: Geliang Tang When ADD_ADDR suboption includes an IPv6 address, the size is 28 octets. It will not fit when other MPTCP suboptions are included in this packet, e.g. DSS. So here we send out an ADD_ADDR dedicated packet to carry only ADD_ADDR suboption, no other MPTCP suboptions. In mptcp_pm

[PATCH net-next 09/10] mptcp: track window announced to peer

2020-11-19 Thread Mat Martineau
From: Florian Westphal OoO handling attempts to detect when packet is out-of-window by testing current ack sequence and remaining space vs. sequence number. This doesn't work reliably. Store the highest allowed sequence number that we've announced and use it to detect oow packets. Do this when

[PATCH net-next 03/10] mptcp: skip to next candidate if subflow has unacked data

2020-11-19 Thread Mat Martineau
From: Florian Westphal In case a subflow path is blocked, MPTCP-level retransmit may not take place anymore because such subflow is likely to have unacked data left in its write queue. Ignore subflows that have experienced loss and test next candidate. Fixes: 3b1d6210a95773691 ("mptcp: implemen

[PATCH net-next 10/10] mptcp: refine MPTCP-level ack scheduling

2020-11-19 Thread Mat Martineau
From: Paolo Abeni Send timely MPTCP-level ack is somewhat difficult when the insertion into the msk receive level is performed by the worker. It needs TCP-level dup-ack to notify the MPTCP-level ack_seq increase, as both the TCP-level ack seq and the rcv window are unchanged. We can actually av

[PATCH net-next 06/10] mptcp: change add_addr_signal type

2020-11-19 Thread Mat Martineau
From: Geliang Tang This patch changed the 'add_addr_signal' type from bool to char, so that we could encode the addr type there. Suggested-by: Paolo Abeni Acked-by: Paolo Abeni Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/pm.c | 15 +-- net/mptcp/

[PATCH net-next 02/10] mptcp: fix state tracking for fallback socket

2020-11-19 Thread Mat Martineau
From: Paolo Abeni We need to cope with some more state transition for fallback sockets, or could still end-up moving to TCP_CLOSE too early and avoid spooling some pending data Fixes: e16163b6e2b7 ("mptcp: refactor shutdown and close") Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --

[PATCH net-next 05/10] mptcp: keep unaccepted MPC subflow into join list

2020-11-19 Thread Mat Martineau
From: Paolo Abeni This will simplify all operation dealing with subflows before accept time (e.g. data fin processing, add_addr). The join list is already flushed by mptcp_stream_accept() before returning the newly created msk to the user space. This also fixes an potential bug present into the

[PATCH net-next 01/10] mptcp: drop WORKER_RUNNING status bit

2020-11-19 Thread Mat Martineau
From: Paolo Abeni Only mptcp_close() can actually cancel the workqueue, no need to add and use this flag. Reviewed-by: Matthieu Baerts Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 8 +--- net/mptcp/protocol.h | 1 - 2 files changed, 1 insertion(+), 8

pull-request: bpf 2020-11-19

2020-11-19 Thread Alexei Starovoitov
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net* tree. We've added 18 non-merge commits during the last 12 day(s) which contain a total of 17 files changed, 301 insertions(+), 49 deletions(-). The main changes are: 1) libbpf should not attempt to load unused su

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-19 Thread Christian Eggers
Hi Tristram, thank you for joining this thread. On Thursday, 19 November 2020, 19:51:15 CET, tristram...@microchip.com wrote: > > On Thursday, 19 November 2020, 00:40:18 CET, Vladimir Oltean wrote: > > > On Wed, Nov 18, 2020 at 09:30:01PM +0100, Christian Eggers wrote: > > > [...] > > [...] > The

Re: [PATCH net-next v7 1/4] gve: Add support for raw addressing device option

2020-11-19 Thread Saeed Mahameed
On Wed, 2020-11-18 at 15:20 -0800, David Awogbemila wrote: > From: Catherine Sullivan > > Add support to describe device for parsing device options. As > the first device option, add raw addressing. > > "Raw Addressing" mode (as opposed to the current "qpl" mode) is an > operational mode which a

Re: [PATCH net-next v3 01/12] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-11-19 Thread Christian Eggers
On Thursday, 19 November 2020, 14:48:01 CET, Rob Herring wrote: > On Wed, Nov 18, 2020 at 09:30:02PM +0100, Christian Eggers wrote: > > Convert the bindings document for Microchip KSZ Series Ethernet switches > > from txt to yaml. > > > > Signed-off-by: Christian Eggers > > --- > > > > .../devi

[PATCH V2 net 0/4] Fixes for ENA driver

2020-11-19 Thread Shay Agroskin
Hi all, This series fixes some issues in the ENA driver: - fix wrong data offset on machines that support rx offset - work-around Intel iommu issue - fix out of bound access when request id is wrong - return error code if XDP TX xmit fails Changes from previous version: v1->v2: switched to using

[PATCH V2 net 1/4] net: ena: handle bad request id in ena_netdev

2020-11-19 Thread Shay Agroskin
After request id is checked in validate_rx_req_id() its value is still used in the line rx_ring->free_ids[next_to_clean] = rx_ring->ena_bufs[i].req_id; even if it was found to be out-of-bound for the array free_ids. The patch moves the request id to

[PATCH V2 net 2/4] net: ena: set initial DMA width to avoid intel iommu issue

2020-11-19 Thread Shay Agroskin
The ENA driver uses the readless mechanism, which uses DMA, to find out what the DMA mask is supposed to be. If DMA is used without setting the dma_mask first, it causes the Intel IOMMU driver to think that ENA is a 32-bit device and therefore disables IOMMU passthrough permanently. This patch se

[PATCH V2 net 4/4] net: ena: return error code from ena_xdp_xmit_buff

2020-11-19 Thread Shay Agroskin
The function mistakenly returns NETDEV_TX_OK regardless of the transmission success. This patch fixes this behavior by returning the error code from the function. Fixes: 548c4940b9f1 ("net: ena: Implement XDP_TX action") Signed-off-by: Shay Agroskin --- drivers/net/ethernet/amazon/ena/ena_netdev

[PATCH V2 net 3/4] net: ena: fix packet's addresses for rx_offset feature

2020-11-19 Thread Shay Agroskin
This patch fixes two lines in which the rx_offset received by the device wasn't taken into account: - prefetch function: In our driver the copied data would reside in rx_info->page + rx_headroom + rx_offset so the prefetch function is changed accordingly. - setting page_o

[PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which from: __mdiobus_register() |-devm_gpiod_get_optional() without actually identifying error code. "mdio_bus 4a101000.mdio: mii_bus 4a101000.mdio co

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-11-19 Thread Edwin Peer
On Sat, Oct 10, 2020 at 3:54 PM Ido Schimmel wrote: > Add 'ETHTOOL_A_LINKMODES_LANES' attribute and expand 'struct > ethtool_link_settings' with lanes field in order to implement a new > lanes-selector that will enable the user to advertise a specific number > of lanes as well. Why can't this be

Re: [PATCH net-next v2 9/9] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-19 Thread ljp
On 2020-11-19 14:26, Thomas Falcon wrote: On 11/19/20 3:43 AM, ljp wrote: On 2020-11-18 19:12, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case hal

Re: XDP maintainer match (Was [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring)

2020-11-19 Thread Jesper Dangaard Brouer
On Thu, 19 Nov 2020 09:59:28 -0800 Jakub Kicinski wrote: > On Thu, 19 Nov 2020 09:09:53 -0800 Joe Perches wrote: > > On Thu, 2020-11-19 at 17:35 +0100, Jesper Dangaard Brouer wrote: > > > On Thu, 19 Nov 2020 07:46:34 -0800 Jakub Kicinski > > > wrote: > > > > > I think it is a good idea

[PATCH net-next V2] MAINTAINERS: Update XDP and AF_XDP entries

2020-11-19 Thread Jesper Dangaard Brouer
Getting too many false positive matches with current use of the content regex K: and file regex N: patterns. This patch drops file match N: and makes K: more restricted. Some more normal F: file wildcards are added. Notice that AF_XDP forgot to some F: files that is also updated in this patch. S

Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries

2020-11-19 Thread Jesper Dangaard Brouer
On Thu, 19 Nov 2020 10:02:10 -0800 Jakub Kicinski wrote: > On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote: > > Getting too many false positive matches with current use > > of the content regex K: and file regex N: patterns. > > > > This patch drops file match N: and makes K: mor

Re: [PATCH net-next v2 9/9] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-19 Thread Thomas Falcon
On 11/19/20 2:38 PM, ljp wrote: On 2020-11-19 14:26, Thomas Falcon wrote: On 11/19/20 3:43 AM, ljp wrote: On 2020-11-18 19:12, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a ce

[PATCH net-next] r8169: reduce number of workaround doorbell rings

2020-11-19 Thread Heiner Kallweit
Some chip versions have a hw bug resulting in lost door bell rings. To work around this the doorbell is also rung whenever we still have tx descriptors in flight after having cleaned up tx descriptors. These PCI(e) writes come at a cost, therefore let's reduce the number of extra doorbell rings. If

[PATCH net-next] r8169: use dev_err_probe in rtl_get_ether_clk

2020-11-19 Thread Heiner Kallweit
Tiny improvement, let dev_err_probe() deal with EPROBE_DEFER. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Heiner Kallweit
Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: > The mdio_bus may have dependencies from GPIO controller and so got > deferred. Now it will print error message every time -EPROBE_DEFER is > returned which from: > __mdiobus_register() > |-devm_gpiod_get_optional() > without actually identifying

[GIT PULL] Networking

2020-11-19 Thread Jakub Kicinski
The following changes since commit db7c953555388571a96ed8783ff6c5745ba18ab9: Merge tag 'net-5.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2020-11-12 14:02:04 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
On 19/11/2020 23:11, Heiner Kallweit wrote: Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which from: __mdiobus_register() |-devm_gpiod_get_o

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Heiner Kallweit
Am 19.11.2020 um 22:17 schrieb Grygorii Strashko: > > > On 19/11/2020 23:11, Heiner Kallweit wrote: >> Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: >>> The mdio_bus may have dependencies from GPIO controller and so got >>> deferred. Now it will print error message every time -EPROBE_DEFER is

[net PATCH 0/2] tcp: Address issues with ECT0 not being set in DCTCP packets

2020-11-19 Thread Alexander Duyck
This patch set is meant to address issues seen with SYN/ACK packets not containing the ECT0 bit when DCTCP is configured as the congestion control algorithm for a TCP socket. A simple test using "tcpdump" and "test_progs -t bpf_tcp_ca" makes the issue obvious. Looking at the packets will result in

[net PATCH 1/2] tcp: Allow full IP tos/IPv6 tclass to be reflected in L3 header

2020-11-19 Thread Alexander Duyck
From: Alexander Duyck An issue was recently found where DCTCP SYN/ACK packets did not have the ECT bit set in the L3 header. A bit of code review found that the recent change referenced below had gone though and added a mask that prevented the ECN bits from being populated in the L3 header. This

[net PATCH 2/2] tcp: Set INET_ECN_xmit configuration in tcp_reinit_congestion_control

2020-11-19 Thread Alexander Duyck
From: Alexander Duyck When setting congestion control via a BPF program it is seen that the SYN/ACK for packets within a given flow will not include the ECT0 flag. A bit of simple printk debugging shows that when this is configured without BPF we will see the value INET_ECN_xmit value initialized

Re: pull-request: bpf 2020-11-19

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 12:07:21 -0800 Alexei Starovoitov wrote: > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > We've added 18 non-merge commits during the last 12 day(s) which contain > a total of 17 files changed, 301 insertions(+), 49 deletions(-

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Andrew Lunn
> >> Doesn't checkpatch complain about line length > 80 here? > > > > :) > > > > commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > Author: Joe Perches > > Date:   Fri May 29 16:12:21 2020 -0700 > > > >     checkpatch/coding-style: deprecate 80-column warning > > > > Ah, again something lear

Re: [PATCH v2 1/5] net: Remove the err argument from sock_from_file

2020-11-19 Thread KP Singh
I think you meant to send these as [PATCH bpf-next] for bpf-next. I guess we can do a round of reviews and update the next revision (if any) with the correct prefixes. On Thu, Nov 19, 2020 at 5:27 PM Florent Revest wrote: > > From: Florent Revest > > Currently, the sock_from_file prototype take

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread Michal Kubecek
On Thu, Nov 19, 2020 at 05:15:57AM +0100, Andrew Lunn wrote: > > diff --git a/include/uapi/linux/ethtool_netlink.h > > b/include/uapi/linux/ethtool_netlink.h > > index e2bf36e..e3458d9 100644 > > --- a/include/uapi/linux/ethtool_netlink.h > > +++ b/include/uapi/linux/ethtool_netlink.h > > @@ -366,

Re: [PATCH v2 net-next 3/3] net/sched: sch_frag: add generic packet fragment support.

2020-11-19 Thread Cong Wang
On Wed, Nov 18, 2020 at 12:04 AM wenxu wrote: > > > 在 2020/11/18 15:00, Cong Wang 写道: > > On Tue, Nov 17, 2020 at 5:37 PM wrote: > >> From: wenxu > >> > >> Currently kernel tc subsystem can do conntrack in cat_ct. But when several > >> fragment packets go through the act_ct, function tcf_ct_hand

Re: [PATCH net-next 1/4] net: bonding: Notify ports about their initial state

2020-11-19 Thread Tobias Waldekranz
On Thu Nov 19, 2020 at 11:18 AM CET, Jay Vosburgh wrote: > Tobias Waldekranz wrote: > > >When creating a static bond (e.g. balance-xor), all ports will always > >be enabled. This is set, and the corresponding notification is sent > >out, before the port is linked to the bond upper. > > > >In the o

Re: [PATCH v2 2/5] bpf: Add a bpf_sock_from_file helper

2020-11-19 Thread KP Singh
On Thu, Nov 19, 2020 at 5:27 PM Florent Revest wrote: > > From: Florent Revest > > While eBPF programs can check whether a file is a socket by file->f_op > == &socket_file_ops, they cannot convert the void private_data pointer > to a struct socket BTF pointer. In order to do this a new helper > w

[PATCH] aquantia: Remove the build_skb path

2020-11-19 Thread Ramsay, Lincoln
The build_skb path fails to allow for an SKB header, but the hardware buffer it is built around won't allow for this anyway. Just always use the slower codepath that copies memory into an allocated SKB. Signed-off-by: Lincoln Ramsay --- .../net/ethernet/aquantia/atlantic/aq_ring.c | 118 ++

RE: [RFC PATCH bpf-next 0/8] Socket migration for SO_REUSEPORT.

2020-11-19 Thread Kuniyuki Iwashima
From: David Laight Date: Wed, 18 Nov 2020 09:18:24 + > From: Kuniyuki Iwashima > > Sent: 17 November 2020 09:40 > > > > The SO_REUSEPORT option allows sockets to listen on the same port and to > > accept connections evenly. However, there is a defect in the current > > implementation. Whe

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread Michal Kubecek
On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote: > On 2020/11/19 12:15, Andrew Lunn wrote: > > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > > > index 9ca87bc..afd8de2 100644 > > > --- a/include/uapi/linux/ethtool.h > > > +++ b/include/uapi/linux/ethtool.h

RE: [PATCH 08/11] net: dsa: microchip: ksz8795: align port_cnt usage with other microchip drivers

2020-11-19 Thread Tristram.Ha
> On Wed, Nov 18, 2020 at 11:03:54PM +0100, Michael Grzeschik wrote: > > The ksz8795 driver is using port_cnt differently to the other microchip > > DSA drivers. It sets it to the external physical port count, than the > > whole port count (including the cpu port). This patch is aligning the > > va

Re: [RFC PATCH bpf-next 0/8] Socket migration for SO_REUSEPORT.

2020-11-19 Thread Kuniyuki Iwashima
From: Eric Dumazet Date: Wed, 18 Nov 2020 17:25:44 +0100 > On 11/17/20 10:40 AM, Kuniyuki Iwashima wrote: > > The SO_REUSEPORT option allows sockets to listen on the same port and to > > accept connections evenly. However, there is a defect in the current > > implementation. When a SYN packet

Re: [PATCH v2 3/5] bpf: Expose bpf_sk_storage_* to iterator programs

2020-11-19 Thread KP Singh
On Thu, Nov 19, 2020 at 5:27 PM Florent Revest wrote: > > From: Florent Revest > > Iterators are currently used to expose kernel information to userspace > over fast procfs-like files but iterators could also be used to > manipulate local storage. For example, the task_file iterator could be > us

[PATCH v2] aquantia: Remove the build_skb path

2020-11-19 Thread Ramsay, Lincoln
The build_skb path fails to allow for an SKB header, but the hardware buffer it is built around won't allow for this anyway. Just always use the slower codepath that copies memory into an allocated SKB. Signed-off-by: Lincoln Ramsay --- This patch is against the master branch rather than the 5.

Re: [RFC PATCH bpf-next 3/8] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-11-19 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Wed, 18 Nov 2020 15:50:17 -0800 > On Tue, Nov 17, 2020 at 06:40:18PM +0900, Kuniyuki Iwashima wrote: > > This patch lets reuseport_detach_sock() return a pointer of struct sock, > > which is used only by inet_unhash(). If it is not NULL, > > inet_csk_reqsk_queue_migrat

Re: [RFC PATCH bpf-next 6/8] bpf: Add cookie in sk_reuseport_md.

2020-11-19 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Wed, 18 Nov 2020 16:11:54 -0800 > On Tue, Nov 17, 2020 at 06:40:21PM +0900, Kuniyuki Iwashima wrote: > > We will call sock_reuseport.prog for socket migration in the next commit, > > so the eBPF program has to know which listener is closing in order to > > select t

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Heiner Kallweit
Am 19.11.2020 um 22:41 schrieb Andrew Lunn: Doesn't checkpatch complain about line length > 80 here? >>> >>> :) >>> >>> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 >>> Author: Joe Perches >>> Date:   Fri May 29 16:12:21 2020 -0700 >>> >>>     checkpatch/coding-style: deprecate 80-column w

Re: [RFC PATCH bpf-next 7/8] bpf: Call bpf_run_sk_reuseport() for socket migration.

2020-11-19 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Wed, 18 Nov 2020 17:00:45 -0800 > On Tue, Nov 17, 2020 at 06:40:22PM +0900, Kuniyuki Iwashima wrote: > > This patch makes it possible to select a new listener for socket migration > > by eBPF. > > > > The noteworthy point is that we select a listening socket in >

Re: [PATCH v2] aquantia: Remove the build_skb path

2020-11-19 Thread Florian Westphal
Ramsay, Lincoln wrote: > The build_skb path fails to allow for an SKB header, but the hardware > buffer it is built around won't allow for this anyway. What problem is being resolved here?

Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries

2020-11-19 Thread Joe Perches
On Thu, 2020-11-19 at 21:50 +0100, Jesper Dangaard Brouer wrote: > On Thu, 19 Nov 2020 10:02:10 -0800 > Jakub Kicinski wrote: > > > On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote: > > > Getting too many false positive matches with current use > > > of the content regex K: and fil

Re: [RFC PATCH bpf-next 0/8] Socket migration for SO_REUSEPORT.

2020-11-19 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Wed, 18 Nov 2020 17:49:13 -0800 > On Tue, Nov 17, 2020 at 06:40:15PM +0900, Kuniyuki Iwashima wrote: > > The SO_REUSEPORT option allows sockets to listen on the same port and to > > accept connections evenly. However, there is a defect in the current > > implementa

[PATCH v2] aquantia: Remove the build_skb path

2020-11-19 Thread Ramsay, Lincoln
> Ramsay, Lincoln wrote: > > The build_skb path fails to allow for an SKB header, but the hardware > > buffer it is built around won't allow for this anyway. > > What problem is being resolved here? Sorry... Do I need to re-post the context? (I thought the reply headers would have kept this wit

Re: [PATCH v2] aquantia: Remove the build_skb path

2020-11-19 Thread Florian Westphal
Ramsay, Lincoln wrote: > > Ramsay, Lincoln wrote: > > > The build_skb path fails to allow for an SKB header, but the hardware > > > buffer it is built around won't allow for this anyway. > > > > What problem is being resolved here? > > Sorry... Do I need to re-post the context? (I thought the r

[PATCH v3] aquantia: Remove the build_skb path

2020-11-19 Thread Ramsay, Lincoln
When performing IPv6 forwarding, there is an expectation that SKBs will have some headroom. When forwarding a packet from the aquantia driver, this does not always happen, triggering a kernel warning. The build_skb path fails to allow for an SKB header, but the hardware buffer it is built around w

[PATCH net-next 1/3] net: ipa: define clock and interconnect data

2020-11-19 Thread Alex Elder
Define a new type of configuration data, used to initialize the IPA core clock and interconnects. This is the first of three patches, and defines the data types and interface but doesn't yet use them. Switch the return value if there is no matching configuration data to ENODEV instead of ENOTSUPP

[PATCH net-next 3/3] net: ipa: use config data for clocking

2020-11-19 Thread Alex Elder
Stop assuming a fixed IPA core clock rate and interconnect bandwidths. Use the configuration data defined for these things instead. Get rid of the previously-used constants. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_clock.c | 40 ++--- 1 file changed, 20

[PATCH net-next 2/3] net: ipa: populate clock and interconnect data

2020-11-19 Thread Alex Elder
Populate the core clock rate and interconnect average and peak bandwidth data for SDM845 and SC7180 in their configuration data files. At this point we still don't *use* this data. Note that SC7180 actually defines a new core clock rate (100 MHz instead of 75 MHz) and new interconnect bandwidth v

[PATCH net-next 0/3] net: ipa: platform-specific clock and interconnect rates

2020-11-19 Thread Alex Elder
This series changes the way the IPA core clock rate and the bandwidth parameters for interconnects are specified. Previously these were specified with hard-wired constants, with the same values used for the SDM845 and SC7180 platforms. Now these parameters are recorded in platform-specific config

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Tobias Waldekranz
On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier wrote: > I don't think we have a way to distinguish from the DT if we are in > SGMII-to-Fibre or in SGMII-to-{Copper + Fibre}, since the description is > the same, we don't have any information in DT about wether or not the > PHY is wired to a Copp

[PATCH net-next 0/6] net: ipa: add a driver shutdown callback

2020-11-19 Thread Alex Elder
The final patch in this series adds a driver shutdown callback for the IPA driver. The patches leading up to that address some issues encountered while ensuring that callback worked as expected: - The first just reports a little more information when channels or event rings are in unexpected

[PATCH net-next 6/6] net: ipa: add driver shutdown callback

2020-11-19 Thread Alex Elder
A system shutdown can happen at essentially any time, and it's possible that the IPA driver is busy when a shutdown is underway. IPA hardware accesses IMEM and SMEM memory regions using an IOMMU, and at some point during shutdown, needed I/O mappings could become invalid. This could be disastrous

[PATCH net-next 3/6] net: ipa: ignore CHANNEL_NOT_RUNNING errors

2020-11-19 Thread Alex Elder
IPA v4.2 has a hardware quirk that requires the AP to allocate GSI channels for the modem to use. It is recommended that these modem channels get stopped (with a HALT generic command) by the AP when its IPA driver gets removed. The AP has no way of knowing the current state of a modem channel. So

[PATCH net-next 5/6] net: ipa: retry modem stop if busy

2020-11-19 Thread Alex Elder
The IPA driver remove callback, ipa_remove(), calls ipa_modem_stop() if the setup stage of initialization is complete. If a concurrent call to ipa_modem_start() or ipa_modem_stop() has begin but not completed, ipa_modem_stop() can return an error (-EBUSY). The next patch adds a driver shutdown ca

[PATCH net-next 4/6] net: ipa: support retries on generic GSI commands

2020-11-19 Thread Alex Elder
When stopping an AP RX channel, there can be a transient period while the channel enters STOP_IN_PROC state before reaching the final STOPPED state. In that case we make another attempt to stop the channel. Similarly, when stopping a modem channel (using a GSI generic command issued from the AP),

[PATCH net-next 1/6] net: ipa: print channel/event ring number on error

2020-11-19 Thread Alex Elder
When a GSI command is used to change the state of a channel or event ring we check the state before and after the command to ensure it is as expected. If not, we print an error message, but it does not include the channel or event ring id, and it easily can. Add the channel or event ring id to th

[PATCH net-next 2/6] net: ipa: don't reset an ALLOCATED channel

2020-11-19 Thread Alex Elder
If the rmnet_ipa0 network device has not been opened at the time we remove or shut down the IPA driver, its underlying TX and RX GSI channels will not have been started, and they will still be in ALLOCATED state. The RESET command on a channel is meant to return a channel to ALLOCATED state after

RE: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-19 Thread Tristram.Ha
> On Thursday, 19 November 2020, 00:40:18 CET, Vladimir Oltean wrote: > > On Wed, Nov 18, 2020 at 09:30:01PM +0100, Christian Eggers wrote: > > > This series adds support for PTP to the KSZ956x and KSZ9477 devices. > > > > > > There is only little documentation for PTP available on the data sheet >

Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-19 Thread Maciej Fijalkowski
On Thu, Nov 19, 2020 at 10:34:48PM +, Ramsay, Lincoln wrote: > When performing IPv6 forwarding, there is an expectation that SKBs > will have some headroom. When forwarding a packet from the aquantia > driver, this does not always happen, triggering a kernel warning. > > The build_skb path fai

Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-19 Thread Florian Westphal
Ramsay, Lincoln wrote: > When performing IPv6 forwarding, there is an expectation that SKBs > will have some headroom. When forwarding a packet from the aquantia > driver, this does not always happen, triggering a kernel warning. > > The build_skb path fails to allow for an SKB header, but the ha

Re: [GIT PULL] Networking

2020-11-19 Thread pr-tracker-bot
The pull request you sent on Thu, 19 Nov 2020 13:15:31 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git tags/net-5.10-rc5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4d02da974ea85a62074efedf354e82778f910d82 Thank you! -- Deet-doot-dot, I am a

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Russell King - ARM Linux admin
On Thu, Nov 19, 2020 at 11:43:39PM +0100, Tobias Waldekranz wrote: > On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier > wrote: > > I don't think we have a way to distinguish from the DT if we are in > > SGMII-to-Fibre or in SGMII-to-{Copper + Fibre}, since the description is > > the same, we don'

[PATCH bpf-next 0/6] libbpf: add support for kernel module BTF CO-RE relocations

2020-11-19 Thread Andrii Nakryiko
Implement libbpf support for performing CO-RE relocations against types in kernel module BTFs, in addition to existing vmlinux BTF support. This is a first step towards fully supporting kernel module BTFs. Subsequent patch sets will expand kernel and libbpf sides to allow using other BTF-powered c

[PATCH bpf-next 1/6] bpf: fix bpf_put_raw_tracepoint()'s use of __module_address()

2020-11-19 Thread Andrii Nakryiko
__module_address() needs to be called with preemption disabled or with module_mutex taken. preempt_disable() is enough for read-only uses, which is what this fix does. Fixes: a38d1107f937 ("bpf: support raw tracepoints in modules") Signed-off-by: Andrii Nakryiko --- kernel/trace/bpf_trace.c | 6

[PATCH bpf-next 6/6] selftests/bpf: add CO-RE relocs selftest relying on kernel module BTF

2020-11-19 Thread Andrii Nakryiko
Add a self-tests validating libbpf is able to perform CO-RE relocations against the type defined in kernel module BTF. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 72 --- .../selftests/bpf/progs/core_reloc_types.h| 17 + .../bpf/prog

[PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-19 Thread Andrii Nakryiko
Teach libbpf to search for candidate types for CO-RE relocations across kernel modules BTFs, in addition to vmlinux BTF. If at least one candidate type is found in vmlinux BTF, kernel module BTFs are not iterated. If vmlinux BTF has no matching candidates, then find all kernel module BTFs and searc

[PATCH bpf-next 5/6] selftests/bpf: add bpf_sidecar kernel module for testing

2020-11-19 Thread Andrii Nakryiko
Add bpf_sidecar module, which is conceptually out-of-tree module and provides ways for selftests/bpf to test various kernel module-related functionality: raw tracepoint, fentry/fexit/fmod_ret, etc. This module will be auto-loaded by test_progs test runner and expected by some of selftests to be pre

[PATCH bpf-next 3/6] libbpf: refactor CO-RE relocs to not assume a single BTF object

2020-11-19 Thread Andrii Nakryiko
Refactor CO-RE relocation candidate search to not expect a single BTF, rather return all candidate types with their corresponding BTF objects. This will allow to extend CO-RE relocations to accommodate kernel module BTFs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 187 ++

[PATCH bpf-next 2/6] libbpf: add internal helper to load BTF data by FD

2020-11-19 Thread Andrii Nakryiko
Add a btf_get_from_fd() helper, which constructs struct btf from in-kernel BTF data by FD. This is used for loading module BTFs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 61 +++-- tools/lib/bpf/libbpf_internal.h | 1 + 2 files changed, 36

Re: [PATCH v2 2/5] bpf: Add a bpf_sock_from_file helper

2020-11-19 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 05:26:51PM +0100, Florent Revest wrote: > From: Florent Revest > > While eBPF programs can check whether a file is a socket by file->f_op > == &socket_file_ops, they cannot convert the void private_data pointer > to a struct socket BTF pointer. In order to do this a new he

Re: [PATCH v3 07/11] dt-bindings: phy: convert MIP DSI PHY binding to YAML schema

2020-11-19 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年11月18日 週三 下午4:21寫道: > > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > > Cc: Chun-Kuang Hu > Signed-off-by: Chunfeng Yun > --- > v3: new patch > --- > .../display/mediatek/mediatek,dsi.txt | 18 +--- > .../bindings/phy/mediatek,dsi

Re: [PATCH v3 06/11] dt-bindings: phy: convert HDMI PHY binding to YAML schema

2020-11-19 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年11月18日 週三 下午4:21寫道: > > Convert HDMI PHY binding to YAML schema mediatek,hdmi-phy.yaml > > Cc: Chun-Kuang Hu > Signed-off-by: Chunfeng Yun > Reviewed-by: Rob Herring > --- > v3: add Reviewed-by Rob > v2: fix binding check warning of reg in example > --- > ...

Re: [PATCH v2 3/5] bpf: Expose bpf_sk_storage_* to iterator programs

2020-11-19 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 05:26:52PM +0100, Florent Revest wrote: > From: Florent Revest > > Iterators are currently used to expose kernel information to userspace > over fast procfs-like files but iterators could also be used to > manipulate local storage. For example, the task_file iterator could

[PATCH v4] aquantia: Remove the build_skb path

2020-11-19 Thread Ramsay, Lincoln
When performing IPv6 forwarding, there is an expectation that SKBs will have some headroom. When forwarding a packet from the aquantia driver, this does not always happen, triggering a kernel warning. aq_ring.c has this code (edited slightly for brevity): if (buff->is_eop && buff->len <= AQ_CFG_R

Re: [PATCH net-next v3 4/7] dpaa_eth: add XDP_TX support

2020-11-19 Thread Maciej Fijalkowski
On Thu, Nov 19, 2020 at 06:29:33PM +0200, Camelia Groza wrote: > Use an xdp_frame structure for managing the frame. Store a backpointer to > the structure at the start of the buffer before enqueueing. Use the XDP > API for freeing the buffer when it returns to the driver on the TX > confirmation pa

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Andrew Lunn
> E.g. at Westermo we make switches with M12/M12X connectors [1] that > sometimes have a 1G PHY behind a 2-pair M12 connector (for complicated > legacy reasons). In such cases we have to remove 1000-HD/FD from the > advertised link modes. Being able to describe that in the DT with > something like:

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Tobias Waldekranz
On Thu, Nov 19, 2020 at 23:16, Russell King - ARM Linux admin wrote: > On Thu, Nov 19, 2020 at 11:43:39PM +0100, Tobias Waldekranz wrote: >> On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier >> wrote: >> > I don't think we have a way to distinguish from the DT if we are in >> > SGMII-to-Fibre or

[PATCH v3 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit

2020-11-19 Thread wenxu
From: wenxu This one is prepare for the next patch. Signed-off-by: wenxu --- v3: no change include/net/sch_generic.h | 5 - net/sched/act_mirred.c| 21 +++-- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_g

[PATCH v3 net-next 0/3] net/sched: fix over mtu packet of defrag in

2020-11-19 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in act_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH v3 net-next 3/3] net/sched: sch_frag: add generic packet fragment support.

2020-11-19 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in cat_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH v3 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb

2020-11-19 Thread wenxu
From: wenxu The mru in the qdisc_skb_cb should be init as 0. Only defrag packets in the act_ct will set the value. Fixes: 038ebb1a713d ("net/sched: act_ct: fix miss set mru for ovs after defrag in act_ct") Signed-off-by: wenxu --- v3: no change net/core/dev.c | 2 ++ 1 file changed, 2 insert

Re: [PATCH v4] aquantia: Remove the build_skb path

2020-11-19 Thread Florian Westphal
Ramsay, Lincoln wrote: [ patch looks good to me, I have no further comments ] > > For build_skb path to work the buffer scheme would need to be changed > > to reserve headroom, so yes, I think that the proposed patch is the > > most convenient solution. > > I don't know about benefits/feasibili

<    1   2   3   4   >