On Fri, Nov 06, 2020 at 03:55:47PM +0800, Hangbin Liu wrote:
> > > - key.remote_ipv6[0] = bpf_htonl(0x2401db00);
> > > - key.tunnel_ttl = 64;
>
> The code logic is same. It set tunnel remote addr to dst IPv6 address, as
> they are both testing IP(v4 or v6) over IPv6 tunnel.
OK, I decide to keep t
withing should be within.
Signed-off-by: Wang Qing
---
net/core/flow_dissector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index e21950a..6f1adba
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -48
Signed-off-by: Alex Shi
Cc: Alexander Aring
Cc: Stefan Schmidt
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-w...@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
---
net/ieee802154/nl802154.c | 4
1 file changed, 4 deletions(-)
diff --git a/net/ie
On Fri, 6 Nov 2020 at 08:41, Xuan Zhuo wrote:
>
> By default, off xdp is implemented by actively calling netlink on the
> command line or in the program. This is very inconvenient for apps based
> on xdp. For example, an app based on xdp + xsk exits abnormally, but xdp
> is still working, which ma
On Thu, 5 Nov 2020 14:57:13 -0800, Jakub Kicinski wrote:
> If you're saying the driver message would still be there if
> verification or translation failed that's perfectly fine, we
> can definitely adjust the test. But some check that driver
> message reporting is working is needed, don't just r
On Thu, 5 Nov 2020 13:22:12 -0800, Andrii Nakryiko wrote:
> test_progs is the only test runner that's run continuously on every
> patch. libbpf CI also runs test_maps and test_verifier. All the other
> test binaries/scripts rely on humans to not forget about them. Which
> works so-so, as you can se
On 06.11.2020 08:48, Heiner Kallweit wrote:
> On 06.11.2020 02:14, Jakub Kicinski wrote:
>> On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote:
>>> @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb,
>>> struct net_device *dev)
>>> return NETDEV_TX_OK;
>>>
>>> dr
在 2020/11/6 下午2:36, Joe Perches 写道:
> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
>> There are some macros unused, they causes much gcc warnings. Let's
>> remove them to tame gcc.
>
> I believe these to be essentially poor warnings.
>
> Aren't these warnings generated only when adding
On 11/5/20 7:14 PM, Manivannan Sadhasivam wrote:
> On Thu, Nov 05, 2020 at 05:39:31PM +0100, Marc Kleine-Budde wrote:
>> On 11/5/20 5:24 PM, Manivannan Sadhasivam wrote:
>>> Hi Marc,
>>>
>>> On Tue, Nov 03, 2020 at 11:06:30PM +0100, Marc Kleine-Budde wrote:
During debugging it turned out that
net/netfilter/ipset/ip_set_core.c:1416:0: warning: macro "DUMP_INIT" is
not used [-Wunused-macros]
This macro unused and cause above warning. So let's remove it.
Signed-off-by: Alex Shi
Cc: Pablo Neira Ayuso
Cc: Jozsef Kadlecsik
Cc: Florian Westphal
Cc: "David S. Miller"
Cc: netfilter-de
From: Jakub Kicinski
> Sent: 05 November 2020 22:47
>
> On Wed, 4 Nov 2020 16:48:57 +0100 Andrew Lunn wrote:
> > - buf = (char*)((u32)skb->data & ~0x3);
> > - len = (skb->len + 3 + ((u32)skb->data & 3)) & ~0x3;
> > - cmdA = (((u32)skb->data & 0x3) << 16) |
> > + offset = (unsigned long)sk
On Thu, 5 Nov 2020 12:19:00 -0800, Andrii Nakryiko wrote:
> I'll just quote myself here for your convenience.
Sorry, I missed your original email for some reason.
> Submodule is a way that I know of to make this better for end users.
> If there are other ways to pull this off with shared libr
On Thu, Nov 05, 2020 at 11:39:47AM +0100, Petr Malat wrote:
> Function sctp_dst_mtu() never returns lower MTU than
> SCTP_TRUNC4(SCTP_DEFAULT_MINSEGMENT) even when the actual MTU is less,
> in which case we rely on the IP fragmentation and must enable it.
This should be being handled at sctp_packe
Fix smatch warning.
Signed-off-by: Wang Qing
---
kernel/trace/bpf_trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index 4517c8b..2cb9c45
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -1198,7 +1198,
From: Jakub Kicinski
> Sent: 05 November 2020 22:38
> On Wed, 4 Nov 2020 16:48:52 +0100 Andrew Lunn wrote:
> > drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set
> > but not used [-Wunused-
> but-set-variable]
> > 706 | unsigned int saved_packet, packet_no, tx_status, p
On Fri, 2020-11-06 at 16:28 +0800, Alex Shi wrote:
>
> 在 2020/11/6 下午2:36, Joe Perches 写道:
> > On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > > There are some macros unused, they causes much gcc warnings. Let's
> > > remove them to tame gcc.
> >
> > I believe these to be essentially poor
On Tue, 3 Nov 2020 16:27:23 +0100
Andrew Lunn wrote:
> On Tue, Nov 03, 2020 at 01:47:12PM +0100, Juerg Haefliger wrote:
> > On Fri, 23 Oct 2020 15:05:19 +0200
> > Andrew Lunn wrote:
> >
> > > On Fri, Oct 23, 2020 at 08:29:59AM +0200, Juerg Haefliger wrote:
> > > > On Wed, 21 Oct 2020 21:35:
On Thu, Nov 05, 2020 at 06:41:33PM +0800, we...@ucloud.cn wrote:
> From: wenxu
I see Davide's and Jakub's comments. Other than those, I don't have
further comments. LGTM!
在 2020/11/6 下午4:52, Joe Perches 写道:
> On Fri, 2020-11-06 at 16:28 +0800, Alex Shi wrote:
>>
>> 在 2020/11/6 下午2:36, Joe Perches 写道:
>>> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
There are some macros unused, they causes much gcc warnings. Let's
remove them to tame gcc.
>>>
>>>
On Thu, 5 Nov 2020 12:45:39 -0800, Andrii Nakryiko wrote:
> That's not true. If you need new functionality like BTF, CO-RE,
> function-by-function verification, etc., then yes, you have to update
> kernel, compiler, libbpf, sometimes pahole. But if you have an BPF
> application that doesn't use and
In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6,
ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82
("selftests/bpf: bpf tunnel test.") when we moved it to the current
folder, we missed some points:
1. ip6ip6 test is not added
2. forgot to remove test_ipip.sh
In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6,
ip6ip6 test") we added ip6ip6 test for bpf tunnel testing. But in commit
933a741e3b82 ("selftests/bpf: bpf tunnel test.") when we moved it to
the current folder, we didn't add it.
This patch add the ip6ip6 test back to bpf tunne
The tcbpf2_kern.o and related kernel sections are moved to bpf
selftest folder since b05cd7404323 ("samples/bpf: remove the bpf tunnel
testsuite."). Remove this one as well.
Fixes: b05cd7404323 ("samples/bpf: remove the bpf tunnel testsuite.")
Signed-off-by: Hangbin Liu
---
v2: move test_tunnel_
From: Xie He
> Sent: 05 November 2020 22:47
>
> On Thu, Nov 5, 2020 at 12:40 PM Arnd Bergmann wrote:
> >
> > > I think this driver never worked. Looking at the original code in
> > > Linux 2.1.31, it already has the problems I fixed in commit
> > > 8fdcabeac398.
> > >
> > > I guess when people (o
From: wenxu
This one is prepare for the next patch.
Signed-off-by: wenxu
---
v4: no change
include/net/sch_generic.h | 5 -
net/sched/act_mirred.c| 21 +++--
2 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/include/net/sch_generic.h b/include/net/sch_g
From: wenxu
Currently kernel tc subsystem can do conntrack in act_ct. But when several
fragment packets go through the act_ct, function tcf_ct_handle_fragments
will defrag the packets to a big one. But the last action will redirect
mirred to a device which maybe lead the reassembly big packet ove
From: Menglong Dong
Obviously, 'bpf/bpf.h' in 'samples/bpf/hbm.c' is duplicated.
Signed-off-by: Menglong Dong
---
samples/bpf/hbm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/samples/bpf/hbm.c b/samples/bpf/hbm.c
index ff4c533..400e741 100644
--- a/samples/bpf/hbm.c
+++ b/samples/bpf/h
On Fri, Nov 06, 2020 at 05:14:15PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> This one is prepare for the next patch.
>
> Signed-off-by: wenxu
Acked-by: Marcelo Ricardo Leitner
From: Joe Perches
> Sent: 06 November 2020 06:36
>
> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > There are some macros unused, they causes much gcc warnings. Let's
> > remove them to tame gcc.
>
> I believe these to be essentially poor warnings.
Indeed.
One 'solution' is to move the
On Fri, Nov 06, 2020 at 05:14:16PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will
From: Voon Weifeng
Set all EHL/TGL phy_addr to -1 so that the driver will automatically
detect it at run-time by probing all the possible 32 addresses.
Signed-off-by: Voon Weifeng
Signed-off-by: Wong Vee Khee
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 6 +-
1 file changed, 1
On Fri, Nov 06, 2020 at 05:46:34AM -0300, Marcelo Ricardo Leitner wrote:
> On Thu, Nov 05, 2020 at 11:39:47AM +0100, Petr Malat wrote:
> > Function sctp_dst_mtu() never returns lower MTU than
> > SCTP_TRUNC4(SCTP_DEFAULT_MINSEGMENT) even when the actual MTU is less,
> > in which case we rely on the
On Fri, Nov 06, 2020 at 10:48:24AM +0100, Petr Malat wrote:
> On Fri, Nov 06, 2020 at 05:46:34AM -0300, Marcelo Ricardo Leitner wrote:
> > On Thu, Nov 05, 2020 at 11:39:47AM +0100, Petr Malat wrote:
> > > Function sctp_dst_mtu() never returns lower MTU than
> > > SCTP_TRUNC4(SCTP_DEFAULT_MINSEGMENT
Hello,
syzbot found the following issue on:
HEAD commit:cb5dc5b0 Merge branch 'bpf: safeguard hashtab locking in N..
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13498a0c50
kernel config: https://syzkaller.appspot.com/x/.config?x=58a4ca757d776bfe
das
For SoCs with SCU support, need setup stop mode via SCU firmware,
so this property can help indicate a resource in SCU firmware.
Signed-off-by: Joakim Zhang
---
.../devicetree/bindings/net/can/fsl,flexcan.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/de
This patch intends to rename FLEXCAN_QUIRK_SETUP_STOP_MODE quirk
to FLEXCAN_QUIRK_SETUP_STOP_MODE_GRP for non-scu SoCs, coming patch will
add quirk for scu SoCs.
For non-scu SoCs, setup stop mode with GPR register.
For scu SoCs, setup stop mode with SCU firmware.
Signed-off-by: Joakim Zhang
---
The System Controller Firmware (SCFW) is a low-level system function
which runs on a dedicated Cortex-M core to provide power, clock, and
resource management. It exists on some i.MX8 processors. e.g. i.MX8QM
(QM, QP), and i.MX8QX (QXP, DX). SCU driver manages the IPC interface
between host CPU and
Add IMX_SC_R_CAN(x) macro for CAN.
Suggested-by: Marc Kleine-Budde
Acked-by: Shawn Guo
Signed-off-by: Joakim Zhang
---
include/dt-bindings/firmware/imx/rsrc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/firmware/imx/rsrc.h
b/include/dt-bindings/firmware/imx/rsrc.h
Add stop mode support for i.MX8QM.
ChangeLogs:
V4->V5:
* remove patch:firmware: imx: always export SCU symbols, since
it done by commit: 95de5094f5ac firmware: imx: add dummy functions
* rebase to fsl,flexcan.yaml
V3->V4:
* can_idx->scu_idx.
* return imx_sc
Correct fsl,clk-source example since flexcan driver uses "of_property_read_u8"
to get this property.
Fixes: 9d733992772d ("dt-bindings: can: flexcan: add PE clock source property
to device tree")
Signed-off-by: Joakim Zhang
---
Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 4 ++--
On Fri, Nov 6, 2020 at 1:03 AM David Laight wrote:
>
> Hmmm LAPB would expect to have an X.25 level 3 and maybe ISO
> transport (class 0, 2 or 3) sat on top of it.
I actually used AF_PACKET sockets to transport data directly over LAPB
and it worked.
LAPB doesn't need anything from layer 3. I
#syz fix: afs: Fix cell removal
On 11/6/20 11:56 AM, Joakim Zhang wrote:
> Add stop mode support for i.MX8QM.
>
> ChangeLogs:
> V4->V5:
> * remove patch:firmware: imx: always export SCU symbols, since
> it done by commit: 95de5094f5ac firmware: imx: add dummy functions
> * rebase to fsl,flexcan.yaml
>
> V3->V4
On 06/11/2020 09:56, Wang Qing wrote:
We always have to update the value of ret, otherwise the
error value may be the previous one.
Signed-off-by: Wang Qing
---
drivers/net/ethernet/ti/am65-cpts.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet
#syz fix: afs: Fix cell removal
On Fri, Nov 6, 2020 at 12:35 PM Grygorii Strashko
wrote:
> On 06/11/2020 09:56, Wang Qing wrote:
> > +++ b/drivers/net/ethernet/ti/am65-cpts.c
> > @@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct device
> > *dev, void __iomem *regs,
>
> there is
> cpts->ptp_clock = ptp_clo
From: Ursula Braun
I am retiring soon. Thus this patch removes myself from the
MAINTAINERS file (s390 network).
Signed-off-by: Ursula Braun
[jwi: fix up the subject]
Signed-off-by: Julian Wiedmann
---
MAINTAINERS | 3 ---
1 file changed, 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
Hi Jakub,
please apply the following patch series to netdev's net tree.
One fix in the shutdown path for af_iucv sockets. This is relevant for
stable as well.
Also sending along an update for the Maintainers file.
Thanks,
Julian
Ursula Braun (2):
net/af_iucv: fix null pointer dereference on s
From: Ursula Braun
syzbot reported the following KASAN finding:
BUG: KASAN: nullptr-dereference in iucv_send_ctrl+0x390/0x3f0
net/iucv/af_iucv.c:385
Read of size 2 at addr 021e by task syz-executor907/519
CPU: 0 PID: 519 Comm: syz-executor907 Not tainted
5.9.0-syzkaller-07043-gbcf
On Fri Nov 06 2020, Arnd Bergmann wrote:
> On Fri, Nov 6, 2020 at 12:35 PM Grygorii Strashko
> wrote:
>> On 06/11/2020 09:56, Wang Qing wrote:
>
>> > +++ b/drivers/net/ethernet/ti/am65-cpts.c
>> > @@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct device
>> > *dev, void __iomem *regs
Packets are processed even though the first fragment don't include all
headers through the upper layer header. This breaks TAHI IPv6 Core
Conformance Test v6LC.1.3.6.
Referring to RFC8200 SECTION 4.5: "If the first fragment does not include
all headers through an Upper-Layer header, then that frag
On Thu, Nov 05, 2020 at 04:48:18PM -0800, Jakub Kicinski wrote:
> On Tue, 3 Nov 2020 14:48:23 +0530 Allen Pais wrote:
> > From: Allen Pais
> >
> > In preparation for unconditionally passing the
> > struct tasklet_struct pointer to all tasklet
> > callbacks, switch to using the new tasklet_setup(
Hello.
On 06.11.20 09:10, Alex Shi wrote:
Signed-off-by: Alex Shi
Cc: Alexander Aring
Cc: Stefan Schmidt
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-w...@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
---
net/ieee802154/nl802154.c | 4
1 file chan
On 05/11/2020 at 18:58, Parshuram Thombare wrote:
This patch fixes NULL pointer dereference due to NULL pcs_config
in pcs_ops.
Reported-by: Nicolas Ferre
Link:
https://lore.kernel.org/netdev/2db854c7-9ffb-328a-f346-f68982723...@microchip.com/
Signed-off-by: Parshuram Thombare
Acked-by: Nico
From: Sven Van Asbroeck
Commit 6f197fb63850 ("lan743x: Added fixed link and RGMII support")
assumes that chips with an internal PHY will never have a devicetree
entry. This is incorrect: even for these chips, a devicetree entry
can be useful e.g. to pass the mac address from bootloader to chip:
On Fri, Nov 06, 2020 at 01:37:30PM +0800, Alex Shi wrote:
> There are some macros unused, they causes much gcc warnings. Let's
> remove them to tame gcc.
>
> net/dsa/tag_brcm.c:51:0: warning: macro "BRCM_EG_RC_SWITCH" is not used
> [-Wunused-macros]
> net/dsa/tag_brcm.c:53:0: warning: macro "BRCM_
On 06/11/2020 14:58, Kurt Kanzenbach wrote:
On Fri Nov 06 2020, Arnd Bergmann wrote:
On Fri, Nov 6, 2020 at 12:35 PM Grygorii Strashko
wrote:
On 06/11/2020 09:56, Wang Qing wrote:
+++ b/drivers/net/ethernet/ti/am65-cpts.c
@@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct de
On Fri, 6 Nov 2020, David Laight wrote:
> From: Jakub Kicinski
> > Sent: 05 November 2020 22:47
> >
> > On Wed, 4 Nov 2020 16:48:57 +0100 Andrew Lunn wrote:
> > > - buf = (char*)((u32)skb->data & ~0x3);
> > > - len = (skb->len + 3 + ((u32)skb->data & 3)) & ~0x3;
> > > - cmdA = (((u32)skb->data &
Hi Randy,
Randy Dunlap writes:
> On 11/2/20 11:19 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20201102:
>>
>
> on x86_64:
>
> when CONFIG_BRIDGE=m:
>
> ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function
> `prestera_bridge_port_event':
> prestera_switc
On 2020-11-05 4:01 p.m., Andrii Nakryiko wrote:
On Thu, Nov 5, 2020 at 6:05 AM Jamal Hadi Salim wrote:
On 2020-11-04 10:19 p.m., David Ahern wrote:
[..]
[..]
2cents feedback from a dabbler in ebpf on user experience:
What David described above *has held me back*.
Over time it seems thing
From: Nicolas Pitre
> Sent: 06 November 2020 15:06
>
> On Fri, 6 Nov 2020, David Laight wrote:
>
> > From: Jakub Kicinski
> > > Sent: 05 November 2020 22:47
> > >
> > > On Wed, 4 Nov 2020 16:48:57 +0100 Andrew Lunn wrote:
> > > > - buf = (char*)((u32)skb->data & ~0x3);
> > > > - len
On Tue, Oct 20, 2020 at 12:04:57PM +0800, Xiaoliang Yang wrote:
> +static int vsc9959_port_get_preempt(struct ocelot *ocelot, int port,
> + struct ethtool_fp *fpcmd)
> +{
> + struct ocelot_port *ocelot_port = ocelot->ports[port];
> + u32 val;
> +
> + val
A common operation for userspace applications managing ipvs is to dump all
services and all destinations and then sort out what needs to be done.
Previously this could only be accomplished by issuing 1 netlink
IPVS_CMD_GET_SERVICE dump command followed by N IPVS_CMD_GET_DEST dump
commands. For a dy
On Fri, 6 Nov 2020, David Laight wrote:
> From: Nicolas Pitre
> > Sent: 06 November 2020 15:06
> >
> > On Fri, 6 Nov 2020, David Laight wrote:
> >
> > > From: Jakub Kicinski
> > > > Sent: 05 November 2020 22:47
> > > >
> > > > On Wed, 4 Nov 2020 16:48:57 +0100 Andrew Lunn wrote:
> > > > > -
On Fri, 6 Nov 2020 10:43:53 +0530 Manivannan Sadhasivam wrote:
> On Thu, Nov 05, 2020 at 04:57:08PM -0800, Jakub Kicinski wrote:
> > On Tue, 3 Nov 2020 18:23:53 +0100 Loic Poulain wrote:
> > > This function can be used by client driver to determine whether it's
> > > possible to queue new elemen
On Fri, 06 Nov 2020 07:23:05 +0100 Martin Schiller wrote:
> On 2020-10-06 07:45, Martin Schiller wrote:
> > This fixes a regression for blocking connects introduced by commit
> > 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25
> > disconnect").
> >
> > The x25->neighbour is already set
With CONFIG_BRIDGE=m the compilation fails:
ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function
`prestera_bridge_port_event':
prestera_switchdev.c:(.text+0x2ebd): undefined reference to
`br_vlan_enabled'
in case the driver is statically enabled.
Fix it by adding
On Fri, 6 Nov 2020 13:43:51 +0800
Alex Shi wrote:
> To tame gcc warning on it:
> net/core/xdp.c:20:0: warning: macro "REG_STATE_NEW" is not used
> [-Wunused-macros]
Hmm... REG_STATE_NEW is zero, so it is implicitly set via memset zero.
But it is true that it is technically not directly used or
On 11/5/20 7:11 PM, Jamie Iles wrote:
> Hi Eric,
>
> On Thu, Nov 05, 2020 at 01:49:03PM +0100, Eric Dumazet wrote:
>> On 11/5/20 9:41 AM, Jamie Iles wrote:
>>> syzkaller found that with CONFIG_DEBUG_KOBJECT_RELEASE=y, releasing a
>>> struct slave device could result in the following splat:
>>>
On Fri, 6 Nov 2020 09:27:45 +0100 Heiner Kallweit wrote:
> On 06.11.2020 08:48, Heiner Kallweit wrote:
> > On 06.11.2020 02:14, Jakub Kicinski wrote:
> >> On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote:
> >>> @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff
> >>> *
On 6 November 2020 9:34:45 PM IST, Jakub Kicinski wrote:
>On Fri, 6 Nov 2020 10:43:53 +0530 Manivannan Sadhasivam wrote:
>> On Thu, Nov 05, 2020 at 04:57:08PM -0800, Jakub Kicinski wrote:
>> > On Tue, 3 Nov 2020 18:23:53 +0100 Loic Poulain wrote:
>> > > This function can be used by client dr
On Fri, 06 Nov 2020 21:58:12 +0530 Manivannan Sadhasivam wrote:
>>> Since you've applied now, what would you propose?
>>
>> Do you need mhi_queue_is_full() in other branches, or are you just
>> concerned about the conflicts?
>
> Yes, I need this patch in mhi-next.
>
>> I'm assuming the concern
On 11/6/2020 6:18 AM, Andrew Lunn wrote:
> On Fri, Nov 06, 2020 at 01:37:30PM +0800, Alex Shi wrote:
>> There are some macros unused, they causes much gcc warnings. Let's
>> remove them to tame gcc.
>>
>> net/dsa/tag_brcm.c:51:0: warning: macro "BRCM_EG_RC_SWITCH" is not used
>> [-Wunused-macros
On 10/29/20 4:28 PM, Vladimir Oltean wrote:
> @@ -168,9 +176,14 @@ static void print_mdb_entry(FILE *f, int ifindex, const
> struct br_mdb_entry *e,
> print_string(PRINT_ANY, "port", " port %s",
>ll_index_to_name(e->ifindex));
>
> + if (af == AF_INET || af == AF_INE
> -Original Message-
> From: Andrew Lunn
> Sent: Wednesday, November 4, 2020 4:58 AM
> To: Radhey Shyam Pandey
> Cc: Michal Simek ; Jakub Kicinski ;
> netdev
> Subject: Re: [PATCH net-next 2/3] drivers: net: xilinx_emaclite: Fix
> -Wpointer-
> to-int-cast warnings with W=1
>
> > > > /
On Fri, 6 Nov 2020 14:08:03 +0100 Georg Kohmann wrote:
> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
> index c8cf1bb..e6173f5 100644
> --- a/net/ipv6/reassembly.c
> +++ b/net/ipv6/reassembly.c
> @@ -325,7 +325,7 @@ static int ipv6_frag_rcv(struct sk_buff *skb)
> const struct i
On Fri, 6 Nov 2020 13:50:07 +0100 Julian Wiedmann wrote:
> From: Ursula Braun
>
> syzbot reported the following KASAN finding:
>
> BUG: KASAN: nullptr-dereference in iucv_send_ctrl+0x390/0x3f0
> net/iucv/af_iucv.c:385
> Read of size 2 at addr 021e by task syz-executor907/519
>
> C
Jianlin reports that a bridged IPv6 VXLAN endpoint, carrying IPv6
packets over a link with a PMTU estimation of exactly 1350 bytes,
won't trigger ICMPv6 Packet Too Big replies when the encapsulated
datagrams exceed said PMTU value. VXLAN over IPv6 adds 70 bytes of
overhead, so an ICMPv6 reply indic
On Thu, 5 Nov 2020 16:12:18 -0800 Shannon Nelson wrote:
> + work = kzalloc(sizeof(*work), GFP_ATOMIC);
> + if (!work) {
> + netdev_err(lif->netdev, "%s OOM\n", __func__);
> + return;
> +
On 11/6/20 9:03 AM, Jakub Kicinski wrote:
On Thu, 5 Nov 2020 16:12:18 -0800 Shannon Nelson wrote:
+ work = kzalloc(sizeof(*work), GFP_ATOMIC);
+ if (!work) {
+ netdev_err(lif->netdev, "%s OOM\n", __func__);
+
The port ID for control messages was uncorrectly set with broadcast
node ID value, causing message to be dropped on remote side since
not passing packet filtering (cb->dst_port != QRTR_PORT_CTRL).
Fixes: d27e77a3de28 ("net: qrtr: Reset the node and port ID of broadcast
messages")
Signed-off-by: L
QRTR protocol allows a node to communicate with an other non-immediate
node via an intermdediate immediate node acting as a 'bridge':
node-0 <=> node-1 <=> node-2
This is currently not supported in this upstream version and this
series aim to fix that.
This series is V2 because changes 1, 2 and
A remote endpoint (immediate neighbors node) can forward services
from other nodes (non-immadiate), in that case ctrl packet node ID
(offering distant service) can differ from the qrtr source node
(forwarding the packet).
Signed-off-by: Loic Poulain
Reviewed-by: Bjorn Andersson
Reviewed-by: Mani
Distant QRTR nodes can be accessed via an other node that acts as
a bridge. When the a QRTR endpoint associated to a bridge node is
released, all the linked distant nodes should also be released.
This patch fixes endpoint release by:
- Submitting QRTR BYE message locally on behalf of all the nodes
This will be requested for allocating control packet in atomic context.
Signed-off-by: Loic Poulain
---
net/qrtr/qrtr.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index 1d12408..a05d01e 100644
--- a/net/qrtr/qrtr.c
+++ b/net
In order to reach non-immediate remote node services that are
accessed through an intermediate node, the route to the remote
node needs to be saved.
E.g for a [node1 <=> node2 <=> node3] network
- node2 forwards node3 service to node1
- node1 must save node2 as route for reaching node3
Signed-off
From: Arnd Bergmann
SIOCGIFMAP and SIOCSIFMAP currently require compat_alloc_user_space()
and copy_in_user() for compat mode.
Move the compat handling into the location where the structures are
actually used, to avoid using those interfaces and get a clearer
implementation.
Signed-off-by: Arnd
From: Arnd Bergmann
The dev_ifconf() calling conventions make compat handling
more complicated than necessary, simplify this by moving
the in_compat_syscall() check into the function.
The implementation can be simplified further, based on the
knowledge that the dynamic registration is only ever u
From: Arnd Bergmann
This is the third version of my seires, now spanning four patches
instead of two, with a new approach for handling struct ifreq
compatibility after I realized that my earlier approach introduces
additional problems.
The idea here is to always push down the compat conversion
d
From: Arnd Bergmann
The ethtool compat ioctl handling is hidden away in net/socket.c,
which introduces a couple of minor oddities:
- The implementation may end up diverging, as seen in the RXNFC
extension in commit 84a1d9c48200 ("net: ethtool: extend RXNFC
API to support RSS spreading of fil
From: Arnd Bergmann
compat_ifreq_ioctl() is one of the last users of copy_in_user() and
compat_alloc_user_space(), as it attempts to convert the 'struct ifreq'
arguments from 32-bit to 64-bit format as used by dev_ioctl() and a
couple of socket family specific interpretations.
The current implem
On Fri, 6 Nov 2020 08:48:47 + David Laight wrote:
> > > +#define SMC_GET_PKT_HDR_STATUS(lp, status)
> > > \
> > > + do {\
> > > + if (SMC_32BIT(lp)) {\
> > > +
On 06.11.2020 17:58, Jakub Kicinski wrote:
> On Fri, 6 Nov 2020 14:08:03 +0100 Georg Kohmann wrote:
>> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
>> index c8cf1bb..e6173f5 100644
>> --- a/net/ipv6/reassembly.c
>> +++ b/net/ipv6/reassembly.c
>> @@ -325,7 +325,7 @@ static int ipv6_fr
From: Tanner Love
Add an additional control test that verifies:
-specifying two different max_num_members values fails
-specifying max_num_members > PACKET_FANOUT_MAX fails
In datapath tests, set max_num_members to PACKET_FANOUT_MAX.
Signed-off-by: Tanner Love
---
tools/testing/selftests/net/
From: Tanner Love
First patch makes the change; second patch adds unit tests.
Tanner Love (2):
net/packet: make packet_fanout.arr size configurable up to 64K
selftests/net: test max_num_members, fanout_args in psock_fanout
include/uapi/linux/if_packet.h | 12
net/packet/af
From: Tanner Love
One use case of PACKET_FANOUT is lockless reception with one socket
per CPU. 256 is a practical limit on increasingly many machines.
Increase PACKET_FANOUT_MAX to 64K. Expand setsockopt PACKET_FANOUT to
take an extra argument max_num_members. Also explicitly define a
fanout_arg
On Fri 06 Nov 2020 at 11:14, we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redirect
> mi
XDP bulk APIs introduce a defer/flush mechanism to return
pages belonging to the same xdp_mem_allocator object
(identified via the mem.id field) in bulk to optimize
I-cache and D-cache since xdp_return_frame is usually run
inside the driver NAPI tx completion loop.
Convert mvneta, mvpp2 and mlx5 dr
Introduce the capability to batch page_pool ptr_ring refill since it is
usually run inside the driver NAPI tx completion loop.
Suggested-by: Jesper Dangaard Brouer
Signed-off-by: Lorenzo Bianconi
---
include/net/page_pool.h | 26
net/core/page_pool.c| 66 +++
Convert mlx5 driver to xdp_return_frame_bulk APIs.
XDP_REDIRECT (upstream codepath): 8.5Mpps
XDP_REDIRECT (upstream codepath + bulking APIs): 10.1Mpps
Signed-off-by: Lorenzo Bianconi
---
drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
1 - 100 of 238 matches
Mail list logo
