From: Arnd Bergmann <a...@arndb.de> This is the third version of my seires, now spanning four patches instead of two, with a new approach for handling struct ifreq compatibility after I realized that my earlier approach introduces additional problems.
The idea here is to always push down the compat conversion deeper into the call stack: rather than pretending to be native mode with a modified copy of the original data on the user space stack, have the code that actually works on the data understand the difference between native and compat versions. I have spent a long time looking at all drivers that implement an ndo_do_ioctl callback to verify that my assumptions are correct. This has led to a series of 29 additional patches that I am not including here but will post separately, fixing a number of bugs in SIOCDEVPRIVATE ioctls, removing dead code, and splitting ndo_do_ioctl into two new ndo callbacks for private and ethernet specific commands. Arnd Arnd Bergmann (4): ethtool: improve compat ioctl handling net: socket: rework SIOC?IFMAP ioctls net: socket: simplify dev_ifconf handling net: socket: rework compat_ifreq_ioctl() include/linux/compat.h | 18 +-- include/linux/ethtool.h | 4 - include/linux/inetdevice.h | 8 + include/linux/netdevice.h | 12 +- net/appletalk/ddp.c | 4 +- net/core/dev_ioctl.c | 156 +++++++++++--------- net/ethtool/ioctl.c | 143 ++++++++++++++++-- net/ieee802154/socket.c | 4 +- net/ipv4/af_inet.c | 6 +- net/ipv4/devinet.c | 4 +- net/qrtr/qrtr.c | 4 +- net/socket.c | 291 +++++++++---------------------------- 12 files changed, 311 insertions(+), 343 deletions(-) Cc: "David S. Miller" <da...@davemloft.net> Cc: Jakub Kicinski <k...@kernel.org> Cc: Christoph Hellwig <h...@infradead.org> Cc: Jiri Pirko <j...@mellanox.com> Cc: Taehee Yoo <ap420...@gmail.com> Cc: Eric Dumazet <eduma...@google.com> Cc: Alexei Starovoitov <a...@kernel.org> Cc: Andrew Lunn <and...@lunn.ch> Cc: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org -- 2.27.0