Re: [PATCH net] net: fix pos incrementment in ipv6_route_seq_next

2020-10-13 Thread Yonghong Song
On 10/12/20 11:56 PM, Vasily Averin wrote: Dear Yonghong Song, thank you for reporting the problem. As far as I understand the problem here is that pos is incremented in .start function. Yes. I do not,like an idea to avoid increment in ipv6_route_seq_next() however ipv6_route_seq_start c

[PATCHv3 net-next 02/16] udp6: move the mss check after udp gso tunnel processing

2020-10-13 Thread Xin Long
For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for gso_size. When using UDP to encapsulate its packet, it will return error in udp6_ufo_fragment() as skb->len < gso_size, and it will never go to the gso tunnel processing. So we should move this check after udp gso tunnel processing, t

[PATCHv3 net-next 01/16] udp: check udp sock encap_type in __udp_lib_err

2020-10-13 Thread Xin Long
There is a chance that __udp4/6_lib_lookup() returns a udp encap sock in __udp_lib_err(), like the udp encap listening sock may use the same port as remote encap port, in which case it should go to __udp4/6_lib_err_encap() for more validation before processing the icmp packet. This patch is to che

[PATCHv3 net-next 00/16] sctp: Implement RFC6951: UDP Encapsulation of SCTP

2020-10-13 Thread Xin Long
Description From the RFC: The Main Reasons: o To allow SCTP traffic to pass through legacy NATs, which do not provide native SCTP support as specified in [BEHAVE] and [NATSUPP]. o To allow SCTP to be implemented on hosts that do not provide direct access to the IP la

[PATCHv3 net-next 05/16] sctp: create udp6 sock and set its encap_rcv

2020-10-13 Thread Xin Long
This patch is to add the udp6 sock part in sctp_udp_sock_start/stop(). udp_conf.use_udp6_rx_checksums is set to true, as: "The SCTP checksum MUST be computed for IPv4 and IPv6, and the UDP checksum SHOULD be computed for IPv4 and IPv6" says in rfc6951#section-5.3. v1->v2: - Add pr_err()

[PATCHv3 net-next 03/16] udp: support sctp over udp in skb_udp_tunnel_segment

2020-10-13 Thread Xin Long
For the gso of sctp over udp packets, sctp_gso_segment() will be called in skb_udp_tunnel_segment(), we need to set transport_header to sctp header. As all the current HWs can't handle both crc checksum and udp checksum at the same time, the crc checksum has to be done in sctp_gso_segment() by rem

[PATCHv3 net-next 09/16] sctp: allow changing transport encap_port by peer packets

2020-10-13 Thread Xin Long
As rfc6951#section-5.4 says: "After finding the SCTP association (which includes checking the verification tag), the UDP source port MUST be stored as the encapsulation port for the destination address the SCTP packet is received from (see Section 5.1). When a non-encapsulated SCTP

[PATCHv3 net-next 04/16] sctp: create udp4 sock and add its encap_rcv

2020-10-13 Thread Xin Long
This patch is to add the functions to create/release udp4 sock, and set the sock's encap_rcv to process the incoming udp encap sctp packets. In sctp_udp_rcv(), as we can see, all we need to do is fix the transport header for sctp_rcv(), then it would implement the part of rfc6951#section-5.4: "W

[PATCHv3 net-next 10/16] sctp: add udphdr to overhead when udp_port is set

2020-10-13 Thread Xin Long
sctp_mtu_payload() is for calculating the frag size before making chunks from a msg. So we should only add udphdr size to overhead when udp socks are listening, as only then sctp can handle the incoming sctp over udp packets and outgoing sctp over udp packets will be possible. Note that we can't d

[PATCHv3 net-next 08/16] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt

2020-10-13 Thread Xin Long
This patch is to implement: rfc6951#section-6.1: Get or Set the Remote UDP Encapsulation Port Number with the param of the struct: struct sctp_udpencaps { sctp_assoc_t sue_assoc_id; struct sockaddr_storage sue_address; uint16_t sue_port; }; the encap_port of sock, assoc or tra

[PATCHv3 net-next 11/16] sctp: call sk_setup_caps in sctp_packet_transmit instead

2020-10-13 Thread Xin Long
sk_setup_caps() was originally called in Commit 90017accff61 ("sctp: Add GSO support"), as: "We have to refresh this in case we are xmiting to more than one transport at a time" This actually happens in the loop of sctp_outq_flush_transports(), and it shouldn't be tied to gso, so move it out

[PATCHv3 net-next 07/16] sctp: add encap_port for netns sock asoc and transport

2020-10-13 Thread Xin Long
encap_port is added as per netns/sock/assoc/transport, and the latter one's encap_port inherits the former one's by default. The transport's encap_port value would mostly decide if one packet should go out with udp encapsulated or not. This patch also allows users to set netns' encap_port by sysct

[PATCHv3 net-next 06/16] sctp: add encap_err_lookup for udp encap socks

2020-10-13 Thread Xin Long
As it says in rfc6951#section-5.5: "When receiving ICMP or ICMPv6 response packets, there might not be enough bytes in the payload to identify the SCTP association that the SCTP packet triggering the ICMP or ICMPv6 packet belongs to. If a received ICMP or ICMPv6 packet cannot be relate

[PATCHv3 net-next 15/16] sctp: handle the init chunk matching an existing asoc

2020-10-13 Thread Xin Long
This is from Section 4 of draft-tuexen-tsvwg-sctp-udp-encaps-cons-03, and it requires responding with an abort chunk with an error cause when the udp source port of the received init chunk doesn't match the encap port of the transport. Signed-off-by: Xin Long --- net/sctp/sm_statefuns.c | 50 +++

[PATCHv3 net-next 13/16] sctp: support for sending packet over udp6 sock

2020-10-13 Thread Xin Long
This one basically does the similar things in sctp_v6_xmit as does for udp4 sock in the last patch, just note that: 1. label needs to be calculated, as it's the param of udp_tunnel6_xmit_skb(). 2. The 'nocheck' param of udp_tunnel6_xmit_skb() is false, as required by RFC. v1->v2:

[PATCHv3 net-next 16/16] sctp: enable udp tunneling socks

2020-10-13 Thread Xin Long
This patch is to enable udp tunneling socks by calling sctp_udp_sock_start() in sctp_ctrlsock_init(), and sctp_udp_sock_stop() in sctp_ctrlsock_exit(). Also add sysctl udp_port to allow changing the listening sock's port by users. Wit this patch, the whole sctp over udp feature can be enabled and

[PATCHv3 net-next 14/16] sctp: add the error cause for new encapsulation port restart

2020-10-13 Thread Xin Long
This patch is to add the function to make the abort chunk with the error cause for new encapsulation port restart, defined on Section 4.4 in draft-tuexen-tsvwg-sctp-udp-encaps-cons-03. v1->v2: - no change. v2->v3: - no need to call htons() when setting nep.cur_port/new_port. Signed-off-by: Xi

[PATCHv3 net-next 12/16] sctp: support for sending packet over udp4 sock

2020-10-13 Thread Xin Long
This patch does what the rfc6951#section-5.3 says for ipv4: "Within the UDP header, the source port MUST be the local UDP encapsulation port number of the SCTP stack, and the destination port MUST be the remote UDP encapsulation port number maintained for the association and the destina

Re: [PATCH v2 2/4] dt-bindings: usb: add properties for hard wired devices

2020-10-13 Thread Chunfeng Yun
On Mon, 2020-10-12 at 11:00 -0500, Rob Herring wrote: > On Sat, Oct 10, 2020 at 04:43:12PM +0800, Chunfeng Yun wrote: > > Add some optional properties which are needed for hard wired devices > > > > Signed-off-by: Chunfeng Yun > > --- > > v2 changes suggested by Rob: > >1. modify pattern to s

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Mike Rapoport
On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: > On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: > > > > On 10/12/20 10:39 AM, Muchun Song wrote: > > > On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: > > >> > > >> On Mon, Oct 12, 2020 at 6:22 AM Muchun Song > > >> wrote: >

Re: Linux mvneta driver unable to read MAC address from HW

2020-10-13 Thread Ezra Buehler
Hi Thomas, On 13 Oct 2020, at 08:35, Thomas Petazzoni wrote: > I suspect you have the mvneta driver as a module ? If this is the case, > then indeed, the MAC address is lost because Linux turns of all unused > clocks at the end of the boot. When the driver is built-in, there is a > driver adding

Re: [PATCH ipsec] xfrm: interface: fix the priorities for ipip and ipv6 tunnels

2020-10-13 Thread Steffen Klassert
On Thu, Oct 08, 2020 at 04:13:24PM +0800, Xin Long wrote: > As Nicolas noticed in his case, when xfrm_interface module is installed > the standard IP tunnels will break in receiving packets. > > This is caused by the IP tunnel handlers with a higher priority in xfrm > interface processing incoming

Re: vxlan_asymmetric.sh test failed every time

2020-10-13 Thread Ido Schimmel
On Tue, Oct 13, 2020 at 12:39:43PM +0800, Hangbin Liu wrote: > Hi Ido, > > When run vxlan_asymmetric.sh on RHEL8, It failed every time. I though that > it may failed because the kernel version is too old. But today I tried with > latest kernel, it still failed. Would you please help check if I mis

[PATCH net-next] cxgb4: handle 4-tuple PEDIT to NAT mode translation

2020-10-13 Thread Herat Ramani
The 4-tuple NAT offload via PEDIT always overwrites all the 4-tuple fields even if they had not been explicitly enabled. If any fields in the 4-tuple are not enabled, then the hardware overwrites the disabled fields with zeros, instead of ignoring them. So, add a parser that can translate the enab

[net-next PATCH 03/10] octeontx2-af: Initialize NIX1 block

2020-10-13 Thread sundeep . lkml
From: Rakesh Babu This patch modifies NIX functions to operate with nix_hw context so that existing functions can be used for both NIX0 and NIX1 blocks. And the NIX blocks present in the system are initialized during driver init and freed during exit. Signed-off-by: Rakesh Babu Signed-off-by: S

[net-next PATCH 05/10] octeontx2-af: Setup MCE context for assigned NIX

2020-10-13 Thread sundeep . lkml
From: Subbaraya Sundeep Initialize MCE context for the assigned NIX0/1 block for a CGX mapped PF. Modified rvu_nix_aq_enq_inst function to work with nix_hw so that MCE contexts for both NIX blocks can be inited. Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham Signed-off-by: Rakes

[net-next PATCH 04/10] octeontx2-af: Map NIX block from CGX connection

2020-10-13 Thread sundeep . lkml
From: Subbaraya Sundeep Firmware configures NIX block mapping for all CGXs to achieve maximum throughput. This patch reads the configuration and create mapping between RVU PF and NIX blocks. And for LBK VFs assign NIX0 for even numbered VFs and NIX1 for odd numbered VFs. Signed-off-by: Subbaraya

[net-next PATCH 02/10] octeontx2-af: Manage new blocks in 98xx

2020-10-13 Thread sundeep . lkml
From: Rakesh Babu AF manages the tasks of allocating, freeing LFs from RVU blocks to PF and VFs. With new NIX1 and CPT1 blocks in 98xx, this patch adds support for handling new blocks too. Co-developed-by: Subbaraya Sundeep Signed-off-by: Subbaraya Sundeep Signed-off-by: Rakesh Babu Signed-of

[net-next PATCH 01/10] octeontx2-af: Update get/set resource count functions

2020-10-13 Thread sundeep . lkml
From: Subbaraya Sundeep Since multiple blocks of same type are present in 98xx, modify functions which get resource count and which update resource count to work with individual block address instead of block type. Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham Signed-off-by: Ra

Re: [bpf-next PATCH v3 4/6] bpf, sockmap: remove dropped data on errors in redirect case

2020-10-13 Thread Jakub Sitnicki
On Mon, Oct 12, 2020 at 07:19 PM CEST, John Fastabend wrote: > Jakub Sitnicki wrote: >> On Fri, Oct 09, 2020 at 08:37 PM CEST, John Fastabend wrote: >> > In the sk_skb redirect case we didn't handle the case where we overrun >> > the sk_rmem_alloc entry on ingress redirect or sk_wmem_alloc on egres

[net-next PATCH 06/10] octeontx2-af: Add NIX1 interfaces to NPC

2020-10-13 Thread sundeep . lkml
From: Subbaraya Sundeep On 98xx silicon, NPC block has additional mcam entries, counters and NIX1 interfaces. Extended set of registers are present for the new mcam entries and counters. This patch does the following: - updates the register accessing macros to use extended set if present. - con

[net-next PATCH 00/10] Support for OcteonTx2 98xx silcion

2020-10-13 Thread sundeep . lkml
From: Subbaraya Sundeep OcteonTx2 series of silicons have multiple variants, the 98xx variant has two network interface controllers (NIX blocks) each of which supports upto 100Gbps. Similarly 98xx supports two crypto blocks (CPT) to double the crypto performance. The current RVU drivers support a

[net-next PATCH 07/10] octeontx2-af: Mbox changes for 98xx

2020-10-13 Thread sundeep . lkml
From: Subbaraya Sundeep This patch puts together all mailbox changes for 98xx silicon: Attach -> Modify resource attach mailbox handler to request LFs from a block address out of multiple blocks of same type. If a PF/VF need LFs from two blocks of same type then attach mbox should be called twic

[net-next PATCH 08/10] octeontx2-pf: Calculate LBK link instead of hardcoding

2020-10-13 Thread sundeep . lkml
From: Subbaraya Sundeep CGX links are followed by LBK links but number of CGX and LBK links varies between platforms. Hence get the number of links present in hardware from AF and use it to calculate LBK link number. Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham Signed-off-by:

[net-next PATCH 09/10] octeontx2-af: Display NIX1 also in debugfs

2020-10-13 Thread sundeep . lkml
From: Rakesh Babu If NIX1 block is also implemented then add a new directory for NIX1 in debugfs root. Stats of NIX1 block can be read/writen from/to the files in directory "/sys/kernel/debug/octeontx2/nix1/". Signed-off-by: Rakesh Babu Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Gou

[net-next PATCH 10/10] octeontx2-af: Display CGX, NIX and PF map in debugfs.

2020-10-13 Thread sundeep . lkml
From: Rakesh Babu Unlike earlier silicon variants, OcteonTx2 98xx silicon has 2 NIX blocks and each of the CGX is mapped to either of the NIX blocks. Each NIX block supports 100G. Mapping btw NIX blocks and CGX is done by firmware based on CGX speed config to have a maximum possible network bandw

net: sctp: Fix negotiation of the number of data streams - backport request

2020-10-13 Thread David Laight
This commit needs backporting to 5.1 through 5.8. Do you need me to find the patch email or is this with the full commit id enough? David commit ab921f3cdbec01c68705a7ade8bec628d541fc2b (patch) The number of output and input streams was never being reduced, eg when processing received I

Re: [PATCH RFC PKS/PMEM 24/58] fs/freevxfs: Utilize new kmap_thread()

2020-10-13 Thread Christoph Hellwig
> - kaddr = kmap(pp); > + kaddr = kmap_thread(pp); > memcpy(kaddr, vip->vii_immed.vi_immed + offset, PAGE_SIZE); > - kunmap(pp); > + kunmap_thread(pp); You only Cced me on this particular patch, which means I have absolutely no idea what kmap_thread and kunmap_thread actually

[PATCH v6 68/80] nl80211: docs: add a description for s1g_cap parameter

2020-10-13 Thread Mauro Carvalho Chehab
Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") added a new parameter, but didn't add the corresponding kernel-doc markup, as repoted when doing "make htmldocs": ./include/net/cfg80211.h:471: warning: Function parameter or member 's1g_cap' not described in 'ieee80211_

[PATCH v6 57/80] net: appletalk: Kconfig: Fix docs location

2020-10-13 Thread Mauro Carvalho Chehab
The location of ltpc.rst changed. Update it at Kconfig. Fixes: 4daedf7abb41 ("docs: networking: move AppleTalk / LocalTalk drivers to the hw driver section") Signed-off-by: Mauro Carvalho Chehab --- drivers/net/appletalk/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v6 58/80] drivers: net: hamradio: fix document location

2020-10-13 Thread Mauro Carvalho Chehab
The hamradio docs were moved to a different dir. Update its location accordingly. Fixes: 14474950252c ("docs: networking: move z8530 to the hw driver section") Signed-off-by: Mauro Carvalho Chehab --- drivers/net/hamradio/scc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v6 26/80] docs: net: ieee802154.rst: fix C expressions

2020-10-13 Thread Mauro Carvalho Chehab
There are some warnings produced with Sphinx 3.x: Documentation/networking/ieee802154.rst:29: WARNING: Error in declarator or parameters Invalid C declaration: Expecting "(" in parameters. [error at 7] int sd = socket(PF_IEEE802154, SOCK_DGRAM, 0); ---^

[PATCH v2 22/24] ice: docs fix a devlink info that broke a table

2020-10-13 Thread Mauro Carvalho Chehab
Changeset 410d06879c01 ("ice: add the DDP Track ID to devlink info") added description for a new devlink field, but forgot to add one of its columns, causing it to break: .../Documentation/networking/devlink/ice.rst:15: WARNING: Error parsing content block for the "list-table" directive:

[PATCH v2 19/24] net: phy: remove kernel-doc duplication

2020-10-13 Thread Mauro Carvalho Chehab
Sphinx 3 now checks for duplicated function declarations: .../Documentation/networking/kapi:143: ../include/linux/phy.h:163: WARNING: Duplicate C declaration, also defined in 'networking/kapi'. Declaration is 'unsigned int phy_supported_speeds (struct phy_device *phy, unsigned in

[PATCH v2 15/24] docs: net: statistics.rst: remove a duplicated kernel-doc

2020-10-13 Thread Mauro Carvalho Chehab
include/linux/ethtool.h is included twice with kernel-doc, both to document ethtool_pause_stats(). The first one is at statistics.rst, and the second one at ethtool-netlink.rst. Replace one of the references to use the name of the function. The automarkup.py extension should create the cross-refer

[PATCH net V2] netfilter: Drop fragmented ndisc packets assembled in netfilter

2020-10-13 Thread Georg Kohmann
Fragmented ndisc packets assembled in netfilter not dropped as specified in RFC 6980, section 5. This behaviour breaks TAHI IPv6 Core Conformance Tests v6LC.2.1.22/23, V6LC.2.2.26/27 and V6LC.2.3.18. Setting IP6SKB_FRAGMENTED flag during reassembly. References: commit b800c3b966bc ("ipv6: drop fr

Re: [PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-13 Thread Richard Cochran
On Mon, Oct 12, 2020 at 09:07:30PM -0700, Tom Rix wrote: > calling function is a print information only function that returns void. That is fine. > I do think not adding error handling is worth it. > > I could change the return and then the calls if if you like. How about printing the version s

Re: [PATCH ipsec] xfrm: interface: fix the priorities for ipip and ipv6 tunnels

2020-10-13 Thread Nicolas Dichtel
Le 13/10/2020 à 11:28, Steffen Klassert a écrit : > On Thu, Oct 08, 2020 at 04:13:24PM +0800, Xin Long wrote: >> As Nicolas noticed in his case, when xfrm_interface module is installed >> the standard IP tunnels will break in receiving packets. >> >> This is caused by the IP tunnel handlers with a

[PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-13 Thread Eelco Chaudron
The flow_lookup() function uses per CPU variables, which must not be preempted. However, this is fine in the general napi use case where the local BH is disabled. But, it's also called in the netlink context, which is preemptible. The below patch makes sure that even in the netlink path, preemption

[PATCH 0/1] add ast2400/2500 phy-handle support

2020-10-13 Thread Ivan Mikhaylov
This patch introduces ast2400/2500 phy-handle support with an embedded MDIO controller. At the current moment it is not possible to set options with this format on ast2400/2500: mac { phy-handle = <&phy>; phy-mode = "rgmii"; mdio { #address-cells = <1>;

[PATCH 1/1] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-13 Thread Ivan Mikhaylov
phy-handle can't be handled well for ast2400/2500 which has an embedded MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize PHYs from mdio child node with of_mdiobus_register. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c | 114 ++---

[PATCH] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-13 Thread Reji Thomas
Currently End.X action doesn't consider the outgoing interface while looking up the nexthop.This breaks packet path functionality specifically while using link local address as the End.X nexthop. The patch fixes this by enforcing End.X action to have both nh6 and oif and using oif in lookup.It seem

Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-13 Thread Sebastian Andrzej Siewior
On 2020-10-13 14:44:19 [+0200], Eelco Chaudron wrote: > The flow_lookup() function uses per CPU variables, which must not be > preempted. However, this is fine in the general napi use case where > the local BH is disabled. But, it's also called in the netlink > context, which is preemptible. The be

[RFC PATCH 00/10] Configuring congestion watermarks on ocelot switch using devlink-sb

2020-10-13 Thread Vladimir Oltean
In some applications, it is important to create resource reservations in the Ethernet switches, to prevent background traffic, or deliberate attacks, from inducing denial of service into the high-priority traffic. These patches give the user some knobs to turn. The ocelot switches support per-port

[RFC PATCH 01/10] net: mscc: ocelot: auto-detect packet buffer size and number of frame references

2020-10-13 Thread Vladimir Oltean
Instead of reading these values from the reference manual and writing them down into the driver, it appears that the hardware gives us the option of detecting them dynamically. The number of frame references corresponds to what the reference manual notes, however it seems that the frame buffers ar

[RFC PATCH 02/10] net: mscc: ocelot: add ops for decoding watermark threshold and occupancy

2020-10-13 Thread Vladimir Oltean
We'll need to read back the watermark thresholds and occupancy from hardware (for devlink-sb integration), not only to write them as we did so far in ocelot_port_set_maxlen. So introduce 2 new functions in struct ocelot_ops, similar to wm_enc, and implement them for the 3 supported mscc_ocelot swit

[RFC PATCH 03/10] net: dsa: add ops for devlink-sb

2020-10-13 Thread Vladimir Oltean
Switches that care about QoS might have hardware support for reserving buffer pools for individual ports or traffic classes, and configuring their sizes and thresholds. Through devlink-sb (shared buffers), this is all configurable, as well as their occupancy being viewable. Add the plumbing in DSA

[RFC PATCH 07/10] net: mscc: ocelot: delete unused ocelot_set_cpu_port prototype

2020-10-13 Thread Vladimir Oltean
This is a leftover of commit 69df578c5f4b ("net: mscc: ocelot: eliminate confusion between CPU and NPI port") which renamed that function. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot

[RFC PATCH 04/10] net: dsa: felix: reindent struct dsa_switch_ops

2020-10-13 Thread Vladimir Oltean
The devlink function pointer names are super long, and they would break the alignment. So reindent the existing ops now by adding one tab. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/felix.c | 78 +- 1 file changed, 39 insertions(+), 39 deletions(-)

[RFC PATCH 09/10] net: mscc: ocelot: initialize watermarks to sane defaults

2020-10-13 Thread Vladimir Oltean
This is meant to be a gentle introduction into the world of watermarks on ocelot. The code is placed in ocelot_devlink.c because it will be integrated with devlink, even if it isn't right now. My first step was intended to be to replicate the default configuration of the congestion watermarks prog

[RFC PATCH 08/10] net: mscc: ocelot: register devlink ports

2020-10-13 Thread Vladimir Oltean
Add devlink integration into the mscc_ocelot switchdev driver. Only the probed interfaces are registered with devlink, because for convenience, struct devlink_port was included into struct ocelot_port_private, which is only initialized for the ports that are used. Note that the felix DSA driver is

[RFC PATCH 10/10] net: mscc: ocelot: configure watermarks using devlink-sb

2020-10-13 Thread Vladimir Oltean
Using devlink-sb, we can configure 12/16 (the important 75%) of the switch's controlling watermarks for congestion drops, and we can monitor 50% of the watermark occupancies (we can monitor the reservation watermarks, but not the sharing watermarks, which are exposed as pool sizes). The following

[RFC PATCH 05/10] net: dsa: felix: perform teardown in reverse order of setup

2020-10-13 Thread Vladimir Oltean
In general it is desirable that cleanup is the reverse process of setup. In this case I am not seeing any particular issue, but with the introduction of devlink-sb for felix, a non-obvious decision had to be made as to where to put its cleanup method. When there's a convention in place, that decisi

[RFC PATCH 06/10] net: mscc: ocelot: export NUM_TC constant from felix to common switch lib

2020-10-13 Thread Vladimir Oltean
We should be moving anything that isn't DSA-specific or SoC-specific out of the felix DSA driver, and into the common mscc_ocelot switch library. The number of traffic classes is one of the aspects that is common between all ocelot switches, so it belongs in the library. This patch also makes sev

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-10-13 Thread Paul Moore
On Mon, Oct 12, 2020 at 5:40 AM Harald Welte wrote: > > Hi Paul, > > On Sun, Oct 11, 2020 at 10:09:11PM -0400, Paul Moore wrote: > > Harald, Pablo - I know you both suggested taking a slow iterative > > approach to merging functionality, perhaps you could also help those > > of us on the SELinux s

Re: [RFC PATCH 08/10] net: mscc: ocelot: register devlink ports

2020-10-13 Thread Jiri Pirko
Tue, Oct 13, 2020 at 03:48:47PM CEST, vladimir.olt...@nxp.com wrote: >Add devlink integration into the mscc_ocelot switchdev driver. Only the >probed interfaces are registered with devlink, because for convenience, >struct devlink_port was included into struct ocelot_port_private, which >is only in

[PATCH] can: Explain PDU in CAN_ISOTP help text

2020-10-13 Thread Geert Uytterhoeven
The help text for the CAN_ISOTP config symbol uses the acronym "PDU". However, this acronym is not explained here, nor in Documentation/networking/can.rst. Expand the acronym to make it easier for users to decide if they need to enable the CAN_ISOTP option or not. Signed-off-by: Geert Uytterhoeven

Ip Rule For GRE Tunnel‏

2020-10-13 Thread לירן אודיז
Hi, Is it possible to set IP rule for GRE tunnel? in the IP rule man there is missing information about the "tun_id" selector parameter, what is the meaning of this parameter? How can i set IP rule for the following GRE tunnel? [root@localhost /]# ip tunnel show gre0: gre/ip remote any local an

RE: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-13 Thread Danielle Ratson
> -Original Message- > From: Jakub Kicinski > Sent: Monday, October 12, 2020 6:58 PM > To: Danielle Ratson > Cc: Ido Schimmel ; netdev@vger.kernel.org; > da...@davemloft.net; Jiri Pirko ; and...@lunn.ch; > f.faine...@gmail.com; mkube...@suse.cz; mlxsw ; Ido > Schimmel ; johan...@sipsol

[PATCH iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions

2020-10-13 Thread Guillaume Nault
Add support for the new TCA_VLAN_ACT_POP_ETH and TCA_VLAN_ACT_PUSH_ETH actions (kernel commit 19fbcb36a39e ("net/sched: act_vlan: Add {POP,PUSH}_ETH actions"). These action let TC remove or add the Ethernet at the head of a frame. Drop an Ethernet header: # tc filter add dev ethX matchall action

[PATCH iproute2-next 0/2] tc: support for new MPLS L2 VPN actions

2020-10-13 Thread Guillaume Nault
This patch series adds the possibility for TC to tunnel Ethernet frames over MPLS. Patch 1 allows adding or removing the Ethernet header. Patch 2 allows pushing an MPLS LSE before the MAC header. By combining these actions, it becomes possible to encapsulate an entire Ethernet frame into MPLS, th

[PATCH iproute2-next 2/2] m_mpls: add mac_push action

2020-10-13 Thread Guillaume Nault
Add support for the new TCA_MPLS_ACT_MAC_PUSH action (kernel commit a45294af9e96 ("net/sched: act_mpls: Add action to push MPLS LSE before Ethernet header")). This action let TC push an MPLS header before the MAC header of a frame. Example (encapsulate all outgoing frames with label 20, then add a

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Randy Dunlap
On 10/13/20 1:09 AM, Mike Rapoport wrote: > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: >> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: >>> >>> On 10/12/20 10:39 AM, Muchun Song wrote: On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: > > On Mon, Oct 12, 202

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Mike Rapoport
On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: > On 10/13/20 1:09 AM, Mike Rapoport wrote: > > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: > >> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet > >> wrote: > >>> > >>> On 10/12/20 10:39 AM, Muchun Song wrote: > On M

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Randy Dunlap
On 10/13/20 8:12 AM, Mike Rapoport wrote: > On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: >> On 10/13/20 1:09 AM, Mike Rapoport wrote: >>> On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: > > On 10/1

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Muchun Song
On Tue, Oct 13, 2020 at 4:09 PM Mike Rapoport wrote: > > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: > > On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: > > > > > > On 10/12/20 10:39 AM, Muchun Song wrote: > > > > On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet > > > > wrote:

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 14:29:29 + Danielle Ratson wrote: > > On Mon, 12 Oct 2020 15:33:45 + Danielle Ratson wrote: > > > > What's the use for this in practical terms? Isn't the lane count > > > > basically implied by the module that gets plugged in? > > > > > > The use is to enable the use

Re: [PATCH v1] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml

2020-10-13 Thread Rob Herring
On Fri, Oct 09, 2020 at 03:29:12PM +0200, Oleksij Rempel wrote: > In order to automate the verification of DT nodes convert > fsl-flexcan.txt to fsl,flexcan.yaml > > Signed-off-by: Oleksij Rempel > --- > .../bindings/net/can/fsl,flexcan.yaml | 137 ++ > .../bindings/net/c

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-13 Thread Aleksandr Nogikh
On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > > On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicinski wrote: [...] > > > > Could you use skb_extensions for this? > > > > >

[RFC PATCH] IPv6: sr: seg6_strict_lookup_nexthop() can be static

2020-10-13 Thread kernel test robot
Signed-off-by: kernel test robot --- seg6_local.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c index 1a669f12d56c9d..e949d24036c2cd 100644 --- a/net/ipv6/seg6_local.c +++ b/net/ipv6/seg6_local.c @@ -219,8 +219,8 @@ int

Re: [PATCH] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-13 Thread kernel test robot
Hi Reji, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9 next-20201013] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-13 Thread Pierre-Louis Bossart
+config SND_SOC_SOF_CLIENT +    tristate +    select ANCILLARY_BUS +    help +  This option is not user-selectable but automagically handled by +  'select' statements at a higher level + +config SND_SOC_SOF_CLIENT_SUPPORT +    bool "SOF enable clients" Tell users what "SOF" means.

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-10-13 Thread Richard Haines
On Tue, 2020-10-13 at 09:55 -0400, Paul Moore wrote: > On Mon, Oct 12, 2020 at 5:40 AM Harald Welte > wrote: > > Hi Paul, > > > > On Sun, Oct 11, 2020 at 10:09:11PM -0400, Paul Moore wrote: > > > Harald, Pablo - I know you both suggested taking a slow iterative > > > approach to merging functiona

Re: [PATCH v2] net: Add mhi-net driver

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 17:26:03 +0200 Loic Poulain wrote: > This patch adds a new network driver implementing MHI transport for > network packets. Packets can be in any format, though QMAP (rmnet) > is the usual protocol (flow control + PDN mux). > > It support two MHI devices, IP_HW0 which is, the p

Re: [PATCH] can: Explain PDU in CAN_ISOTP help text

2020-10-13 Thread Oliver Hartkopp
On 13.10.20 16:13, Geert Uytterhoeven wrote: The help text for the CAN_ISOTP config symbol uses the acronym "PDU". However, this acronym is not explained here, nor in Documentation/networking/can.rst. Expand the acronym to make it easier for users to decide if they need to enable the CAN_ISOTP

Re: [PATCH 01/23] dt-bindings: introduce silabs,wfx.yaml

2020-10-13 Thread Rob Herring
On Mon, Oct 12, 2020 at 12:46:26PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 125 ++ > 1 file changed, 125 insertions(+) > create mode 100644 > Documentation/devicetree/bindi

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 18:59:28 +0300 Aleksandr Nogikh wrote: > On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > > > On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicin

Re: [PATCH v6 68/80] nl80211: docs: add a description for s1g_cap parameter

2020-10-13 Thread Thomas Pedersen
On 2020-10-13 04:54, Mauro Carvalho Chehab wrote: Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") added a new parameter, but didn't add the corresponding kernel-doc markup, as repoted when doing "make htmldocs": ./include/net/cfg80211.h:471: warning: Function paramet

Re: [PATCH] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 17:31:51 +0530 Reji Thomas wrote: > Currently End.X action doesn't consider the outgoing interface > while looking up the nexthop.This breaks packet path functionality > specifically while using link local address as the End.X nexthop. > The patch fixes this by enforcing End.X a

[PATCH 0/2] net: dccp: fix structure use-after-free

2020-10-13 Thread Kleber Sacilotto de Souza
This patchset addresses the following CVE: CVE-2020-16119 - DCCP CCID structure use-after-free Hadar Manor reported that by reusing a socket with an attached dccps_hc_tx_ccid as a listener, it will be used after being released, leading to DoS and potentially code execution. The first patch moves

[PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-13 Thread Kleber Sacilotto de Souza
From: Thadeu Lima de Souza Cascardo When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason del_timer_sync can't be used is because this relies on keeping a reference to struct sock. But as we keep a pointer to dccps_hc_tx_ccid and free that during disconnect, the timer should r

[PATCH 2/2] Revert "dccp: don't free ccid2_hc_tx_sock struct in dccp_disconnect()"

2020-10-13 Thread Kleber Sacilotto de Souza
From: Thadeu Lima de Souza Cascardo This reverts commit 2677d20677314101293e6da0094ede7b5526d2b1. This fixes an issue that after disconnect, dccps_hc_tx_ccid will still be kept, allowing the socket to be reused as a listener socket, and the cloned socket will free its dccps_hc_tx_ccid, leading t

Re: [PATCHv3 net-next 02/16] udp6: move the mss check after udp gso tunnel processing

2020-10-13 Thread Willem de Bruijn
On Tue, Oct 13, 2020 at 3:28 AM Xin Long wrote: > > For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for > gso_size. When using UDP to encapsulate its packet, it will > return error in udp6_ufo_fragment() as skb->len < gso_size, > and it will never go to the gso tunnel processing. > > S

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-13 Thread David Ahern
On 10/12/20 11:30 AM, Keller, Jacob E wrote: > Ah. Good point. This should use CLOCK_MONOTONIC instead, right? that or MONOTONIC_RAW.

[PATCH net v2] net: fix pos incrementment in ipv6_route_seq_next

2020-10-13 Thread Yonghong Song
Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") tried to fix the issue where seq_file pos is not increased if a NULL element is returned with seq_ops->next(). See bug https://bugzilla.kernel.org/show_bug.cgi?id=206283 The commit effectively does: - increase pos for al

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Dan Williams
On Fri, Oct 9, 2020 at 12:52 PM wrote: > > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Nicolas Pitre > Signed-off-by: Ira Weiny > --- > fs/cramfs/inode.c | 10 +---

Re: [PATCH v6 68/80] nl80211: docs: add a description for s1g_cap parameter

2020-10-13 Thread Johannes Berg
Thanks Mauro. On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote: > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") > added a new parameter, but didn't add the corresponding kernel-doc > markup, as repoted when doing "make htmldocs": > > ./include/net/cfg80

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Nicolas Pitre
On Fri, 9 Oct 2020, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Nicolas Pitre > Signed-off-by: Ira Weiny Acked-by: Nicolas Pitre > fs

Re: [PATCH 2/2] Revert "dccp: don't free ccid2_hc_tx_sock struct in dccp_disconnect()"

2020-10-13 Thread Richard Sailer
On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote: > rom: Thadeu Lima de Souza Cascardo > > This reverts commit 2677d20677314101293e6da0094ede7b5526d2b1. > > This fixes an issue that after disconnect, dccps_hc_tx_ccid will still be > kept, allowing the socket to be reused as a listener socket

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-13 Thread Richard Sailer
On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > del_timer_sync can't be used is because this relies on keeping a reference > to struct sock. But as we keep a pointer to dccp

  1   2   >