On Fri, Oct 09, 2020 at 12:05:15PM +0800, Jason Wang wrote:
>
> On 2020/10/9 上午4:42, Stefano Garzarella wrote:
> > If riov and wiov are both defined and they point to different
> > objects, only riov is initialized. If the wiov is not initialized
> > by the caller, the function fails returning -EI
Adding support for TCP_NOTSENT_LOWAT sockoption
(https://lwn.net/Articles/560082/) in tcpbpf
v1->v2:
- addressing yhs@ comments. explicitly defining TCP_NOTSENT_LOWAT in
selftests if it is not defined in the system
Signed-off-by: Nikita V. Shirokov
---
include/uapi/linux/bpf.h
Hi Florian,
On Thu, Oct 08, 2020 at 07:26:44PM -0700, Florian Fainelli wrote:
>
>
> On 10/8/2020 7:20 PM, Calvin Johnson wrote:
> > Hi Rob,
> >
> > On Thu, Oct 08, 2020 at 11:35:07AM -0500, Rob Herring wrote:
> > > On Thu, Oct 8, 2020 at 9:47 AM Calvin Johnson
> > > wrote:
> > > >
> > > > Bet
On 10/9/20 2:51 AM, Jakub Kicinski wrote:
> On Tue, 6 Oct 2020 15:52:53 +0200 Marek Vasut wrote:
>> The phy_reset_after_clk_enable() does a PHY reset, which means the PHY
>> loses its register settings. The fec_enet_mii_probe() starts the PHY
>> and does the necessary calls to configure the PHY vi
On 10/9/20 2:46 AM, Jakub Kicinski wrote:
> On Wed, 7 Oct 2020 00:02:42 +0200 Marek Vasut wrote:
>> On 10/6/20 11:09 PM, Florian Fainelli wrote:
>>> On 10/6/2020 1:20 PM, Marek Vasut wrote:
The phy_reset_after_clk_enable() is always called with ndev->phydev,
however that pointer may be
Hi John,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/John-Fastabend/sockmap-sk_skb-program-memory-acct-fixes/20201009-124625
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf
Hi John,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/John-Fastabend/sockmap-sk_skb-program-memory-acct-fixes/20201009-124625
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf
On Fri, 2020-10-09 at 07:09 +0200, Nicolai Stange wrote:
> Johannes Berg writes:
>
> > On Thu, 2020-10-08 at 15:59 +, David Laight wrote:
> > > From: Taehee Yoo
> > > > Sent: 08 October 2020 16:49
> > > >
> > > > When debugfs file is opened, its module should not be removed until
> > > > it'
[RFF = Request For Flaming]
THIS IS PROBABLY COMPLETELY CRAZY.
Currently, if a module is unloaded while debugfs files are being
kept open, things crash since the ->release() method is called
only at the actual release, despite the proxy_fops, and then the
code is no longer around.
The correct wa
Fix follow warnings:
[net/9p/trans_xen.c:454]: (warning) %u in format string (no. 1) requires
'unsigned int' but the argument type is 'int'.
[net/9p/trans_xen.c:460]: (warning) %u in format string (no. 1) requires
'unsigned int' but the argument type is 'int'.
Reported-by: Hulk Robot
Signed-off-b
On Fri, Oct 09, 2020 at 09:53:06AM +0200, Johannes Berg wrote:
> [RFF = Request For Flaming]
>
> THIS IS PROBABLY COMPLETELY CRAZY.
>
> Currently, if a module is unloaded while debugfs files are being
> kept open, things crash since the ->release() method is called
> only at the actual release, d
Hello,
syzbot found the following issue on:
HEAD commit:c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1658aa8b90
kernel config: https://syzkaller.appspot.com/x/.config?x=c06bcf3cc963d91c
das
On Fri, 2020-10-09 at 10:03 +0200, Greg KH wrote:
> For lots of debugfs files, .owner should already be set, if you use the
> DEFINE_SIMPLE_ATTRIBUTE() or DEFINE_DEBUGFS_ATTRIBUTE() macros.
>
> But yes, not all.
Right.
You didn't see the original thread:
https://lore.kernel.org/netdev/20201008
On Fri, Oct 09, 2020 at 10:06:14AM +0200, Johannes Berg wrote:
> We used to say the proxy_fops weren't needed and it wasn't an issue, and
> then still implemented it. Dunno. I'm not really too concerned about it
> myself, only root can hold the files open and remove modules ...
proxy_fops were nee
On Fri, 2020-10-09 at 10:16 +0200, Greg KH wrote:
> On Fri, Oct 09, 2020 at 10:06:14AM +0200, Johannes Berg wrote:
> > We used to say the proxy_fops weren't needed and it wasn't an issue, and
> > then still implemented it. Dunno. I'm not really too concerned about it
> > myself, only root can hold
On 10/8/20 10:54 PM, Heiner Kallweit wrote:
> On 08.10.2020 21:07, Eric Dumazet wrote:
>>
>>
>> On 10/8/20 8:50 PM, Eric Dumazet wrote:
>>>
>>>
>>> OK, it would be nice to know what is the input interface
>>>
>>> if4 -> look at "ip link | grep 4:"
>>>
>>> Then identifying the driver that built s
From: Johannes Berg
> Sent: 09 October 2020 09:19
>
> On Fri, 2020-10-09 at 10:16 +0200, Greg KH wrote:
> > On Fri, Oct 09, 2020 at 10:06:14AM +0200, Johannes Berg wrote:
> > > We used to say the proxy_fops weren't needed and it wasn't an issue, and
> > > then still implemented it. Dunno. I'm not
On Fri, 2020-10-09 at 08:34 +, David Laight wrote:
>
> > I think adding the .owner everywhere would be good, and perhaps we can
> > somehow put a check somewhere like
> >
> > WARN_ON(is_module_address((unsigned long)fops) && !fops->owner);
> >
> > to prevent the issue in the future?
>
>
On Fri, Oct 09, 2020 at 10:19:02AM +0200, Johannes Berg wrote:
> On Fri, 2020-10-09 at 10:16 +0200, Greg KH wrote:
> > On Fri, Oct 09, 2020 at 10:06:14AM +0200, Johannes Berg wrote:
> > > We used to say the proxy_fops weren't needed and it wasn't an issue, and
> > > then still implemented it. Dunno
On Fri, 2020-10-09 at 10:47 +0200, Greg KH wrote:
> > I think adding the .owner everywhere would be good, and perhaps we can
> > somehow put a check somewhere like
> >
> > WARN_ON(is_module_address((unsigned long)fops) && !fops->owner);
> >
> > to prevent the issue in the future?
>
> That w
From: Johannes Berg
> Sent: 09 October 2020 09:45
>
> On Fri, 2020-10-09 at 08:34 +, David Laight wrote:
> >
...
> > Does it ever make any sense to set .owner to anything other than
> > THIS_MODULE?
>
> No. But I believe THIS_MODULE is NULL for built-in code, so we can't
> just WARN_ON(!fops-
Hello Greg,
On 10/01/2020 13:48, Greg Kroah-Hartman wrote:
> On Wed, Jan 08, 2020 at 05:10:42PM +0100, Alexander X Sverdlin wrote:
>> From: Alexander Sverdlin
>>
>> Currently in case of alignment or FCS error if the packet cannot be
>> corrected it's still not dropped. Report the error properly a
On Fri, Oct 09, 2020 at 11:34:47AM +0200, Alexander Sverdlin wrote:
> Hello Greg,
>
> On 10/01/2020 13:48, Greg Kroah-Hartman wrote:
> > On Wed, Jan 08, 2020 at 05:10:42PM +0100, Alexander X Sverdlin wrote:
> >> From: Alexander Sverdlin
> >>
> >> Currently in case of alignment or FCS error if the
Hello Greg, Dave and all,
the below patch is still applicable as-is, would you please re-consider it now,
as the driver has been undeleted?
On 08/01/2020 17:09, Alexander X Sverdlin wrote:
> From: Alexander Sverdlin
>
> The PHYs must be registered once in device probe function, not in device
>
From: Alexander Sverdlin
The PHYs must be registered once in device probe function, not in device
open callback because it's only possible to register them once.
Fixes: a25e278020 ("staging: octeon: support fixed-link phys")
Signed-off-by: Alexander Sverdlin
---
drivers/staging/octeon/ethernet
From: Alexander Sverdlin
Currently in case of alignment or FCS error if the packet cannot be
corrected it's still not dropped. Report the error properly and drop the
packet while making the code around a little bit more readable.
Signed-off-by: Alexander Sverdlin
Fixes: 80ff0fd3ab ("Staging: Ad
From: Alexander Sverdlin
The PHYs must be registered once in device probe function, not in device
open callback because it's only possible to register them once.
Fixes: a25e278020 ("staging: octeon: support fixed-link phys")
Signed-off-by: Alexander Sverdlin
---
drivers/staging/octeon/ethernet
On Fri, Oct 09, 2020 at 11:40:24AM +0200, Alexander Sverdlin wrote:
> Hello Greg, Dave and all,
>
> the below patch is still applicable as-is, would you please re-consider it
> now,
> as the driver has been undeleted?
>
> On 08/01/2020 17:09, Alexander X Sverdlin wrote:
Why would we have a patc
On Fri, 9 Oct 2020 02:46:09 +0300
Vladimir Oltean wrote:
> On Thu, Oct 08, 2020 at 05:27:49PM +0100, John Keeping wrote:
> > With threadirqs, stmmac_interrupt() is called on a thread with hardirqs
> > enabled so we cannot call __napi_schedule_irqoff(). Under lockdep it
> > leads to:
> >
> >
On Fri, 9 Oct 2020 at 14:39, Nicolai Stange wrote:
>
Hi Nicolai,
Thank you for the review!
> Taehee Yoo writes:
>
> > On Fri, 9 Oct 2020 at 01:14, Johannes Berg
> > wrote:
> > On Thu, 2020-10-08 at 15:59 +, David Laight wrote:
> >
> >> From: Taehee Yoo
> >> > Sent: 08 October 2020 16:49
>
On Thu, Oct 08, 2020 at 11:47:00AM +0200, Eric Dumazet wrote:
>
>
> On 10/8/20 10:30 AM, Hangbin Liu wrote:
> >>> @@ -282,6 +285,21 @@ static struct sk_buff *ip6_rcv_core(struct sk_buff
> >>> *skb, struct net_device *dev,
> >>> }
> >>> }
> >>>
> >>> + /* RFC 8200, Section 4.5 Fragm
On Fri, Oct 09, 2020 at 10:59:45AM +0100, John Keeping wrote:
> No, it's not, although I would have saved several days debugging if it
> was! I backported the lockdep warning to prove that it caught this
> issue.
>
> The evidence it is possible to see on vanilla 5.4.x is:
>
> $ trace-cmd rep
The bpf_fib_lookup() helper performs a neighbour lookup for the destination
IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with the expectation
that the BPF program will pass the packet up the stack in this case.
However, with the addition of bpf_redirect_neigh() that can be used instead
to pe
On Fri, 9 Oct 2020 at 16:45, Johannes Berg wrote:
>
Hi Johannes,
Thank you for the review!
> On Fri, 2020-10-09 at 07:09 +0200, Nicolai Stange wrote:
> > Johannes Berg writes:
> >
> > > On Thu, 2020-10-08 at 15:59 +, David Laight wrote:
> > > > From: Taehee Yoo
> > > > > Sent: 08 October 20
On Fri, 2020-10-09 at 19:15 +0900, Taehee Yoo wrote:
>
> Okay, as you mentioned earlier in 001/117 patch thread,
> I will squash patches into per-driver/subsystem then send them as v2.
Give me a bit. I think I figured out a less intrusive way that at least
means we don't have to do it if the fops
I just realized all my messages were bounced by mail server, this is
last try
This fix works, however they should be applied for each of ipvs_xmit
functions (e.g. ip_vs_nat_xmit(), ip_vs_dr_xmit(), etc.)
I look forward to seeing the patch in ml-5.x
Thank you!
On 9/30/2020 8:17 PM, Julian
The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around,
so SOCK_TSTAMP_NEW will first be set and than reset again. Additionally
move it out of the test for SOF_TIMESTAMPING_RX_SOFTWARE as this seems
unrelated.
This problem happens on 32 bit platforms were the libc has already
switc
SOCK_TSTAMP_NEW (timespec64 instead of timespec) is also used for
hardware time stamps (configured via SO_TIMESTAMPING_NEW).
User space (ptp4l) first configures hardware time stamping via
SO_TIMESTAMPING_NEW which sets SOCK_TSTAMP_NEW. In the next step, ptp4l
disables SO_TIMESTAMPNS(_NEW) (softwar
From: Johannes Berg
Currently, things will crash (or at least UAF) in release() when
a module owning a debugfs file, but that didn't set the fops.owner,
is removed while the offending debugfs file is open.
Since we have the proxy_fops, we can break that down into two
different cases:
If the fop
On Fri, 2020-10-09 at 12:41 +0200, Johannes Berg wrote:
> If the fops doesn't have a release method, we don't even need
> to keep a reference to the real_fops, we can just fops_put()
> them already in debugfs remove, and a later full_proxy_release()
> won't call anything anyway - this just crashed
From: Johannes Berg
> Sent: 09 October 2020 11:48
>
> On Fri, 2020-10-09 at 12:41 +0200, Johannes Berg wrote:
>
> > If the fops doesn't have a release method, we don't even need
> > to keep a reference to the real_fops, we can just fops_put()
> > them already in debugfs remove, and a later full_p
On Fri, 2020-10-09 at 10:56 +, David Laight wrote:
> From: Johannes Berg
> > Sent: 09 October 2020 11:48
> >
> > On Fri, 2020-10-09 at 12:41 +0200, Johannes Berg wrote:
> >
> > > If the fops doesn't have a release method, we don't even need
> > > to keep a reference to the real_fops, we can j
syzbot suspects this issue was fixed by commit:
commit bb8872a1e6bc911869a729240781076ed950764b
Author: Tuong Lien
Date: Sat Aug 29 19:37:55 2020 +
tipc: fix using smp_processor_id() in preemptible
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=100f5bb850
start commi
Jozsef Kadlecsik wrote:
> > Any comments?
> > Here is a simple reproducer. The idea is to show that keepalive packets
> > in an idle tcp connection will be dropped (and the connection will time
> > out) if conntrack hooks are de-registered and then re-registered. The
> > reproducer has two file
On Fri, Oct 09, 2020 at 10:56:16AM +, David Laight wrote:
> From: Johannes Berg
> > Sent: 09 October 2020 11:48
> >
> > On Fri, 2020-10-09 at 12:41 +0200, Johannes Berg wrote:
> >
> > > If the fops doesn't have a release method, we don't even need
> > > to keep a reference to the real_fops, w
Hello Mr Gleixner,
thanks for your feedback we'll fix the issues not related to the time scale
topic as soon as possible.
Regarding your concerns about not using TAI timescale, we do admit that in many
situations TAI makes a lot of things way more easy and therefore is the way to
go.
Yet we do
Hi Alexander,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Alexander-A-Sverdlin/staging-octeon-repair-fixed-link-support/20201009-174828
base: https://git.kernel.org/pub/scm/linux/kernel/git
On Thu, Oct 08, 2020 at 08:29:00AM -0500, Pierre-Louis Bossart wrote:
>
> > > > > > But ... since the init() function is performing both device_init and
> > > > > > device_add - it should probably be called ancillary_device_register,
> > > > > > and we are back to a single exported API for both reg
Hello,
syzbot found the following issue on:
HEAD commit:5edb1df2 kmsan: drop the _nosanitize string functions
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=155a804f90
kernel config: https://syzkaller.appspot.com/x/.co
On 2020-10-08 11:34 a.m., Vlad Buslov wrote:
On Thu 08 Oct 2020 at 15:58, Jamal Hadi Salim wrote:
Hi Jamal,
The existing terse dump tdc tests will have to be changed according with
new iproute2 tc syntax for brief(terse) output.
Which test(s)?
I see for example d45e mentioning terse but i
Obviously this driver version doesn't make sense. Go with the default
and let ethtool display the kernel version.
Signed-off-by: Heiner Kallweit
---
drivers/net/usb/usbnet.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index bf6c58240
On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim wrote:
> On 2020-10-08 11:34 a.m., Vlad Buslov wrote:
>>
>> On Thu 08 Oct 2020 at 15:58, Jamal Hadi Salim wrote:
>>
>>
>> Hi Jamal,
>>
>> The existing terse dump tdc tests will have to be changed according with
>> new iproute2 tc syntax for brief(te
On Fri, Oct 09, 2020 at 11:46:05AM +0200, Alexander A Sverdlin wrote:
> --- a/drivers/staging/octeon/ethernet-rx.c
> +++ b/drivers/staging/octeon/ethernet-rx.c
> @@ -69,14 +69,16 @@ static inline int cvm_oct_check_rcv_error(struct cvmx_wqe
> *work)
> else
> port = work->word1.c
Hi Hongbo,
On Thu, Sep 17, 2020 at 02:37:59AM +, Hongbo Wang wrote:
> > On Wed, Sep 16, 2020 at 10:28:38AM +, Hongbo Wang wrote:
> > > Hi Vladimir,
> > >
> > > if swp0 connects with customer, and swp1 connects with ISP, According
> > > to the VSC99599_1_00_TS.pdf, swp0 and swp1 will have d
On 2020-10-09 8:15 a.m., Vlad Buslov wrote:
On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim wrote:
Which test(s)?
I see for example d45e mentioning terse but i dont see corresponding
code in the iproute2 tree i just pulled.
Yes. The tests d45e and 7c65 were added as a part of kernel series,
On 10/9/20 12:12 AM, Hoang Huu Le wrote:
Hi Jon, Jakub,
I tried with your comment. But looks like we got into circular locking and
deadlock could happen like this:
CPU0CPU1
lock(&n->lock#2);
To everyone (PC, organizing committee, speakers, workshop chairs,
Tutors, sponsors, and attendees) - thank one more time
for making the conference the success it was!
The videos are now up.
The sessions page is at:
https://netdevconf.info/0x14/accepted-sessions.html
The videos can be viewed d
On Fri, Oct 09, 2020 at 02:10:57PM +0200, Heiner Kallweit wrote:
> Obviously this driver version doesn't make sense. Go with the default
> and let ethtool display the kernel version.
>
> Signed-off-by: Heiner Kallweit
Reviewed-by: Greg Kroah-Hartman
On Fri, Oct 09, 2020 at 11:47:39AM +0200, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin
>
> The PHYs must be registered once in device probe function, not in device
> open callback because it's only possible to register them once.
>
> Fixes: a25e278020 ("staging: octeon: support fixed-l
In order to automate the verification of DT nodes convert
fsl-flexcan.txt to fsl,flexcan.yaml
Signed-off-by: Oleksij Rempel
---
.../bindings/net/can/fsl,flexcan.yaml | 137 ++
.../bindings/net/can/fsl-flexcan.txt | 57
2 files changed, 137 insertions(+)
On Thu, Oct 8, 2020 at 9:19 PM Tonghao Zhang wrote:
>
> On Wed, Sep 30, 2020 at 6:05 PM Willem de Bruijn
> wrote:
> >
> > On Wed, Sep 30, 2020 at 4:05 AM wrote:
> > >
> > > From: Tonghao Zhang
> > >
> > > Allow user configuring RXCSUM separately with ethtool -K,
> > > reusing the existing virtn
On Thu, Oct 8, 2020 at 9:49 PM Xin Long wrote:
>
> On Thu, Oct 8, 2020 at 8:45 PM Willem de Bruijn
> wrote:
> >
> > On Thu, Oct 8, 2020 at 5:48 AM Xin Long wrote:
> > >
> > > For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for
> > > gso_size. When using UDP to encapsulate its packet,
Recent work in f4d05259213f ("bpf: Add map_meta_equal map ops") and 134fede4eecf
("bpf: Relax max_entries check for most of the inner map types") added support
for dynamic inner max elements for most map-in-map types. Exceptions were maps
like array or prog array where the map_gen_lookup() callback
Add an efficient ingress to ingress netns switch that can be used out of tc BPF
programs in order to redirect traffic from host ns ingress into a container
veth device ingress without having to go via CPU backlog queue [0]. For local
containers this can also be utilized and path via CPU backlog que
Follow-up to address David's feedback that we should better describe internals
of the bpf_redirect_neigh() helper.
Suggested-by: David Ahern
Signed-off-by: Daniel Borkmann
Reviewed-by: David Ahern
---
include/uapi/linux/bpf.h | 10 +++---
tools/include/uapi/linux/bpf.h | 10 +++--
Rename into test_tc_redirect.sh and move setup and test code into separate
functions so they can be reused for newly added tests in here. Also remove
the crude hack to override ifindex inside the object file via xxd and sed
and just use a simple map instead. Map given iproute2 does not support BTF
This series addresses most of the feedback [0] that was to be followed
up from the last series, that is, UAPI helper comment improvements and
getting rid of the ifindex obj file hacks in the selftest by using a
BPF map instead. The __sk_buff data/data_end pointer work, I'm planning
to do in a later
Extend the "diff_size" subtest to also include a non-inlined array map variant
where dynamic inner #elems are possible.
Signed-off-by: Daniel Borkmann
Acked-by: Yonghong Song
---
.../selftests/bpf/prog_tests/btf_map_in_map.c | 39 -
.../selftests/bpf/progs/test_btf_map_in_map.c
Extend the test_tc_redirect test and add a small test that exercises the new
redirect_peer() helper for the IPv4 and IPv6 case.
Signed-off-by: Daniel Borkmann
---
.../selftests/bpf/progs/test_tc_peer.c| 45 +++
.../testing/selftests/bpf/test_tc_redirect.sh | 25 +++---
Factor out handling the private packet/byte counters to new
functions rtl_get_priv_stats() and rtl_inc_priv_stats().
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169_main.c | 46 ---
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git a/drivers/
Hi Fabio and Oleksij
Den ons. 7. okt. 2020 kl. 11.50 skrev Fabio Estevam :
>
> Hi Oleksij,
>
> On Tue, Oct 6, 2020 at 5:05 AM Oleksij Rempel wrote:
> >
> > Hello PHY experts,
> >
> > Short version:
> > what is the proper way to handle the PHY reset before identifying PHY?
> >
> > Long version:
>
+
+ ancildrv->driver.owner = owner;
+ ancildrv->driver.bus = &ancillary_bus_type;
+ ancildrv->driver.probe = ancillary_probe_driver;
+ ancildrv->driver.remove = ancillary_remove_driver;
+ ancildrv->driver.shutdown = ancillary_shutdown_driver;
+
I think that this part is wrong, prob
Hi Alexander,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Alexander-A-Sverdlin/staging-octeon-repair-fixed-link-support/20201009-174828
base: https://git.kernel.org/pub/scm/linux/kernel/git
On 08.10.2020 18:27, John Keeping wrote:
> With threadirqs, stmmac_interrupt() is called on a thread with hardirqs
> enabled so we cannot call __napi_schedule_irqoff(). Under lockdep it
> leads to:
>
> [ cut here ]
> WARNING: CPU: 0 PID: 285 at kernel/softirq.c
On 10/8/20 4:12 PM, Magnus Karlsson wrote:
From: Magnus Karlsson
Introduce one cache line worth of padding between the producer and
consumer pointers in all the lockless rings. This so that the HW
adjacency prefetcher will not prefetch the consumer pointer when the
producer pointer is used and
On 10/9/20 12:03 AM, Nikita V. Shirokov wrote:
Adding support for TCP_NOTSENT_LOWAT sockoption
(https://lwn.net/Articles/560082/ ) in tcpbpf
v1->v2:
- addressing yhs@ comments. explicitly defining TCP_NOTSENT_LOWAT in
selftests if it is not defined in the system
Signed-off-by: Nikita V. S
On Thu, Oct 8, 2020 at 11:49 PM Yonghong Song wrote:
> >
> > profiler[23].c may fail on older llvm that don't have:
> > https://reviews.llvm.org/D85570
>
> Not sure but the below equivalent URL may be more intuitive:
>https://reviews.llvm.org/D85570
It's the same URL :)
See it unmangled here:
Johannes Berg writes:
> On Thu, 2020-10-08 at 15:50 +, Taehee Yoo wrote:
>> If THIS_MODULE is not set, the module would be removed while debugfs is
>> being used.
>> It eventually makes kernel panic.
>>
> Wow, 117 practically identical patches? No thanks ...
>
> Can you merge the ones that b
On 10/9/20 8:08 AM, Alexei Starovoitov wrote:
On Thu, Oct 8, 2020 at 11:49 PM Yonghong Song wrote:
profiler[23].c may fail on older llvm that don't have:
https://reviews.llvm.org/D85570
Not sure but the below equivalent URL may be more intuitive:
https://reviews.llvm.org/D85570
It's
On Fri, 9 Oct 2020 09:20:30 +0200 Marek Vasut wrote:
> > Can you describe your problem in detail?
>
> Yes, I tried to do that in the commit message and the extra detailed
> comment above the code. What exactly do you not understand from that?
Why it's not bound on the first open (I'm guessing i
On 10/9/20 5:06 PM, Yonghong Song wrote:
On 10/9/20 12:03 AM, Nikita V. Shirokov wrote:
Adding support for TCP_NOTSENT_LOWAT sockoption
(https://lwn.net/Articles/560082/ ) in tcpbpf
v1->v2:
- addressing yhs@ comments. explicitly defining TCP_NOTSENT_LOWAT in
selftests if it is not defined in
On Fri, 9 Oct 2020 09:21:06 +0200 Marek Vasut wrote:
> On 10/9/20 2:51 AM, Jakub Kicinski wrote:
> > On Tue, 6 Oct 2020 15:52:53 +0200 Marek Vasut wrote:
> >> The phy_reset_after_clk_enable() does a PHY reset, which means the PHY
> >> loses its register settings. The fec_enet_mii_probe() starts
On Fri, Oct 9, 2020 at 3:22 AM Johannes Berg wrote:
>
> On Fri, 2020-10-09 at 19:15 +0900, Taehee Yoo wrote:
> >
> > Okay, as you mentioned earlier in 001/117 patch thread,
> > I will squash patches into per-driver/subsystem then send them as v2.
>
> Give me a bit. I think I figured out a less int
This series introduces crypto(CPT) drivers(PF & VF) for Marvell OcteonTX2
CN96XX Soc.
OcteonTX2 SOC's resource virtualization unit (RVU) supports multiple
physical and virtual functions. Each of the PF/VF's functionality is
determined by what kind of resources are attached to it. When the CPT
bloc
On OcteonTX2 platform CPT instruction enqueue and NIX
packet send are only possible via LMTST operations which
uses LDEOR instruction. This patch moves lmt flush
function from OcteonTX2 nic driver to include/linux/soc
since it will be used by OcteonTX2 CPT and NIC driver for
LMTST.
Signed-off-by:
On OcteonTX2 SoC, the admin function (AF) is the only one with all
priviliges to configure HW and alloc resources, PFs and it's VFs
have to request AF via mailbox for all their needs. This patch adds
a mailbox interface for CPT PFs and VFs to allocate resources
for cryptography and inline-IPsec.
In
Add entries to debugfs at /sys/kernel/debug/octeontx2/cpt.
cpt_pc: dump cpt performance HW registers.
Usage: cat /sys/kernel/debug/octeontx2/cpt/cpt_pc
cpt_engines_sts: show cpt engines current state (busy/free status)
Usage:
echo "AE/SE/IE/all" > /sys/kernel/debug/octeontx2/cpt/cpt_engines_sts
In the resource virtualization unit (RVU) each of the PF and AF
(admin function) share a 64KB of reserved memory region for
communication. This patch initializes PF <=> AF mailbox IRQs,
registers handlers for processing these communication messages.
Signed-off-by: Suheil Chandran
Signed-off-by: S
Adds 'sriov_configure' to enable/disable virtual functions (VFs).
Also Initializes VF<=>PF mailbox IRQs, register handlers for
processing these mailbox messages.
Admin function (AF) handles resource allocation and configuration for
PFs and their VFs. PFs request the AF directly, via mailboxes.
Unl
Adds skeleton for the Marvell OcteonTX2 CPT physical function
driver which includes probe, PCI specific initialization and
hardware register defines.
RVU defines are present in AF driver
(drivers/net/ethernet/marvell/octeontx2/af), header files from
AF driver are included here to avoid duplication.
Adds support to get engine capabilities and adds a new mailbox
to share the engine capabilities to CPT VFIO drivers.
Signed-off-by: Suheil Chandran
Signed-off-by: Srujana Challa
---
.../marvell/octeontx2/otx2_cpt_common.h | 36
.../marvell/octeontx2/otx2_cpt_reqmgr.h | 51 +++
On Tue, 6 Oct 2020 18:26:17 +0200 Davide Caratti wrote:
> using packetdrill it's possible to observe the same MPTCP DSN being acked
> by different subflows with DACK4 and DACK8. This is in contrast with what
> specified in RFC8684 §3.3.2: if an MPTCP endpoint transmits a 64-bit wide
> DSN, it MUST
CPT RVU Local Functions(LFs) needs to be attached to the PF/VF to
submit the instructions to CPT. This patch adds the interface to
initialize and attach the LFs. It also adds interface to register
the LF's interrupts.
Signed-off-by: Suheil Chandran
Signed-off-by: Srujana Challa
---
drivers/cryp
Add support for the Marvell OcteonTX2 CPT virtual function driver.
This patch includes probe, PCI specific initialization and interrupt
handling.
Signed-off-by: Suheil Chandran
Signed-off-by: Srujana Challa
---
drivers/crypto/marvell/octeontx2/Makefile | 4 +-
.../marvell/octeontx2/otx2_c
CPT includes microcoded GigaCypher symmetric engines(SEs), IPsec
symmetric engines(IEs), and asymmetric engines (AEs).
Each engine receives CPT instructions from the engine groups it has
subscribed to. This patch loads microcode, configures three engine
groups(one for SEs, one for IEs and one for A
Add new mailbox message to configure a LF for RX inline-IPsec.
This message is added to serve Marvell CPT VFIO driver, since
a VF can not send mailbox messages to admin function(AF)
directly.
Signed-off-by: Suheil Chandran
Signed-off-by: Srujana Challa
---
.../marvell/octeontx2/otx2_cpt_common.
CPT offload module utilises the linux crypto framework to offload
crypto processing. This patch registers supported algorithms by
calling registration functions provided by the kernel crypto API.
The module currently supports:
- AES block cipher in CBC,ECB,XTS and CFB mode.
- 3DES block cipher in
Attach LFs to CPT VF to process the crypto requests and register LF
interrupts.
Signed-off-by: Suheil Chandran
Signed-off-by: Srujana Challa
---
drivers/crypto/marvell/octeontx2/Makefile | 2 +-
.../marvell/octeontx2/otx2_cpt_reqmgr.h | 145 +
drivers/crypto/marvell/octeontx2/ot
On Fri, 9 Oct 2020 09:35:03 +0200 Eric Dumazet wrote:
> On Fri, Oct 9, 2020 at 2:18 AM Jakub Kicinski wrote:
> >
> > On Wed, 7 Oct 2020 09:51:11 -0700 Eric Dumazet wrote:
> > > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
> > > index
> > > 6c762457122fd0091cb0f2bf41bda73b
Andreas,
On Fri, Oct 09 2020 at 11:17, Andreas Meisinger wrote:
please do not top-post and trim your replies.
> Yet we do already have usecases where this can't be done. Additionally
> a lot of discussions at this topic are ongoing in 60802 profile
> creation too. Some of our usecases do requir
1 - 100 of 338 matches
Mail list logo
