On Wed, Oct 07, 2020 at 11:32:11PM -0700, Dan Williams wrote:
> On Wed, Oct 7, 2020 at 10:21 PM Leon Romanovsky wrote:
> >
> > On Wed, Oct 07, 2020 at 08:46:45PM +, Ertman, David M wrote:
> > > > -Original Message-
> > > > From: Parav Pandit
> > > > Sent: Wednesday, October 7, 2020 1:
> From: Leon Romanovsky
> Sent: Thursday, October 8, 2020 10:56 AM
>
> On Thu, Oct 08, 2020 at 04:56:01AM +, Parav Pandit wrote:
> >
> >
> > > From: Pierre-Louis Bossart
> > > Sent: Thursday, October 8, 2020 3:20 AM
> > >
> > >
> > > On 10/7/20 4:22 PM, Ertman, David M wrote:
> > > >> ---
On Thu, Oct 08, 2020 at 08:47:33AM +0200, Wilken Gottwalt wrote:
> On Tue, 6 Oct 2020 09:02:01 +0200
> Johan Hovold wrote:
>
> > On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote:
> > > On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin wrote:
> > > > It is very likely that Cellient has
Luca Coelho writes:
> On Tue, 2020-10-06 at 10:10 +0300, Kalle Valo wrote:
>> Lee Jones writes:
>>
>> > On Tue, 06 Oct 2020, Kalle Valo wrote:
>> >
>> > > Lee Jones writes:
>> > >
>> > > > On Thu, 10 Sep 2020, Lee Jones wrote:
>> > > >
>> > > > > This is a rebased/re-worked set of patches w
Add the Cellient MPL200 card to usb/qmi_wwan and serial/option. The
serial/option patch got already applied.
Changes v2:
Picked proper subject for qmi_wwan patch, moved the MPL200 device to
the section of the combined devices and changed the comment about the
device to be more precise.
Wilken Got
Add usb ids of the Cellient MPL200 card.
Signed-off-by: Wilken Gottwalt
---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 07c42c0719f5..5ca1356b8656 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/driver
Add usb ids of the Cellient MPL200 card.
Signed-off-by: Wilken Gottwalt
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 0c6f160a214a..a65e620b2277 100644
--- a/drivers/usb/serial/option.c
+++ b
Greg Kroah-Hartman writes:
> On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote:
>> From: Jérôme Pouiller
>>
>> I think the wfx driver is now mature enough to be accepted in the
>> drivers/net/wireless directory.
>>
>> There is still one item on the TODO list. It is an idea to imp
On Thu, Oct 08, 2020 at 09:22:19AM +0200, Wilken Gottwalt wrote:
> Add usb ids of the Cellient MPL200 card.
>
> Signed-off-by: Wilken Gottwalt
> ---
So I had already applied this one (which didn't change since v1).
Thanks again.
Johan
In the function node_lost_contact(), we call __skb_queue_purge() without
grabbing the list->lock. This can cause to a race-condition why processing
the list 'namedq' in calling path tipc_named_rcv()->tipc_named_dequeue().
[] BUG: kernel NULL pointer dereference, address:
[
On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
[..]
> All stated above is my opinion, it can be different from yours.
Yes, but we need to converge to move this forward. Jason was involved
in the current organization for registration, Greg was angling for
this to be core functionality. I h
Wed, Oct 07, 2020 at 08:00:44AM CEST, mo...@mellanox.com wrote:
>Add reload limit to demand restrictions on reload actions.
>Reload limits supported:
>no_reset: No reset allowed, no down time allowed, no link flap and no
> configuration is lost.
>
>By default reload limit is unspecified an
Hello,
syzbot found the following issue on:
HEAD commit:c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15b2b40050
kernel config: https://syzkaller.appspot.com/x/.config?x=de7f697da23057c7
das
On Thu, Oct 08, 2020 at 07:14:17AM +, Parav Pandit wrote:
>
>
> > From: Leon Romanovsky
> > Sent: Thursday, October 8, 2020 10:56 AM
> >
> > On Thu, Oct 08, 2020 at 04:56:01AM +, Parav Pandit wrote:
> > >
> > >
> > > > From: Pierre-Louis Bossart
> > > > Sent: Thursday, October 8, 2020 3:2
On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
> [..]
> > All stated above is my opinion, it can be different from yours.
>
> Yes, but we need to converge to move this forward. Jason was involved
> in the current organization
On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
> [..]
> > All stated above is my opinion, it can be different from yours.
>
> Yes, but we need to converge to move this forward. Jason was involved
> in the current organization
Lorenzo Bianconi writes:
Introduce the capability to allocate a xdp multi-buff in
bpf_prog_test_run_xdp routine. This is a preliminary patch to
introduce
the selftests for new xdp multi-buff ebpf helpers
Signed-off-by: Lorenzo Bianconi
---
net/bpf/test_run.c | 51
++
Wilken Gottwalt writes:
> Add usb ids of the Cellient MPL200 card.
>
> Signed-off-by: Wilken Gottwalt
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 07c42c0719f5..5ca1356b8656 100644
> -
On Wed, 07 Oct 2020 20:19:39 -0700
John Fastabend wrote:
> Maciej Żenczykowski wrote:
> > On Wed, Oct 7, 2020 at 3:37 PM John Fastabend
> > wrote:
> > >
> > > Daniel Borkmann wrote:
> > > > On 10/7/20 6:23 PM, Jesper Dangaard Brouer wrote:
> > > > [...]
> > > > > net/core/dev.c | 24 +
On Thu, Oct 8, 2020 at 1:00 AM Leon Romanovsky wrote:
>
> On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> > On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
> > [..]
> > > All stated above is my opinion, it can be different from yours.
> >
> > Yes, but we need to converge to
As Nicolas noticed in his case, when xfrm_interface module is installed
the standard IP tunnels will break in receiving packets.
This is caused by the IP tunnel handlers with a higher priority in xfrm
interface processing incoming packets by xfrm_input(), which would drop
the packets and return 0
On 10/8/20 10:07 AM, Jesper Dangaard Brouer wrote:
[...]
However, due to both gso and vlan offload, even this is not trivial to do...
The mtu is L3, but drivers/hardware/the wire usually care about L2...
If net_device->mtu is L3 (1500) and XDP (and TC, right?) operate at L2,
that likely means t
Hi Eric,
Thanks for the comments. I should add "RFC" in subject next time for the
uncertain fix patch.
On Wed, Oct 07, 2020 at 11:35:41AM +0200, Eric Dumazet wrote:
>
>
> On 10/7/20 5:55 AM, Hangbin Liu wrote:
>
> > kfree_skb(skb);
> > @@ -282,6 +285,21 @@ static struct sk_buff *ip
On Wed, 7 Oct 2020 23:37:00 +0200
Daniel Borkmann wrote:
> On 10/7/20 6:23 PM, Jesper Dangaard Brouer wrote:
> [...]
> > net/core/dev.c | 24 ++--
> > 1 file changed, 22 insertions(+), 2 deletions(-)
> >
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index b4330988
On Wed Oct 07 2020, Vladimir Oltean wrote:
> On Wed, Oct 07, 2020 at 12:39:49PM +0200, Kurt Kanzenbach wrote:
>> For instance the hellcreek switch has actually three ptp hardware
>> clocks and the time stamping can be configured to use either one of
>> them.
>
> The sja1105 also has a corrected and
On Wed, Oct 07, 2020 at 07:58:07AM -0700, Jakub Kicinski wrote:
> On Wed, 7 Oct 2020 11:55:02 +0800 Hangbin Liu wrote:
> > Based on RFC 8200, Section 4.5 Fragment Header:
> >
> > - If the first fragment does not include all headers through an
> > Upper-Layer header, then that fragment sho
From: Eric Dumazet
After freeing ep->auth_hmacs we have to clear the pointer
or risk use-after-free as reported by syzbot:
BUG: KASAN: use-after-free in sctp_auth_destroy_hmacs net/sctp/auth.c:509
[inline]
BUG: KASAN: use-after-free in sctp_auth_destroy_hmacs net/sctp/auth.c:501
[inline]
BUG:
On Thu, Oct 8, 2020 at 12:12 PM Cong Wang wrote:
>
> skb_unshare() drops a reference count on the old skb unconditionally,
> so in the failure case, we end up freeing the skb twice here.
> And because the skb is allocated in fclone and cloned by caller
> tipc_msg_reassemble(), the consequence is a
Hello,
syzbot found the following issue on:
HEAD commit:5edb1df2 kmsan: drop the _nosanitize string functions
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=1279b1c050
kernel config: https://syzkaller.appspot.com/x/.co
Fix comment typo.
s/abitrary/arbitrary/
Signed-off-by: Naoki Hayama
---
drivers/net/ethernet/ti/tlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index 76a342ea3797..e922258cae3f 100644
--- a/drivers/net/eth
I found some typos related to "arbitrary".
s/abitrary/arbitrary/
s/arbitary/arbitrary/
This series fixes them.
These typos have been reported in the past in other codes, but
correction 'abitrary||arbitrary' wasn't added to scripts/spelling.txt.
Therefore, PATCH #6 adds it to spelling.txt.
Naok
On 10/6/20 12:07 AM, Jakub Kicinski wrote:
> Since ethtool uses strict attribute validation there's no need
> to initialize all attributes in policy tables. 0 is NLA_UNSPEC
> which is going to be rejected. Remove the NLA_REJECTs.
>
> Similarly attributes above maxattrs are rejected, so there's
On Thu, 2020-10-08 at 11:12 +0200, Eric Dumazet wrote:
>
> On 10/6/20 12:07 AM, Jakub Kicinski wrote:
> > Since ethtool uses strict attribute validation there's no need
> > to initialize all attributes in policy tables. 0 is NLA_UNSPEC
> > which is going to be rejected. Remove the NLA_REJECTs.
> >
On Thu, 2020-10-08 at 11:13 +0200, Johannes Berg wrote:
> > This implies that all policy tables must be 'complete'.
Also, yes they had to be complete already, perhaps *except* for NLA_FLAG
like this below use ...
> > So when later strset_parse_request() does :
> >
> > req_info->counts_only = tb
The MTU setting for this DSA switch is global so we need
to keep track of the MTU set for each port, then as soon
as any MTU changes, roof the MTU to the biggest common
denominator and poke that into the switch MTU setting.
To achieve this we need a per-chip-variant state container
for the RTL8366
On Tue, Oct 6, 2020 at 3:01 AM Marcelo Ricardo Leitner
wrote:
>
> On Sat, Oct 03, 2020 at 08:24:34PM +0800, Xin Long wrote:
> > On Sat, Oct 3, 2020 at 7:23 PM Xin Long wrote:
> > >
> > > On Sat, Oct 3, 2020 at 4:12 PM Xin Long wrote:
> > > >
> > > > On Sat, Oct 3, 2020 at 12:08 PM Marcelo Ricard
On Thu, Oct 08, 2020 at 10:34:11AM +0200, Kurt Kanzenbach wrote:
> On Wed Oct 07 2020, Vladimir Oltean wrote:
> > On Wed, Oct 07, 2020 at 12:39:49PM +0200, Kurt Kanzenbach wrote:
> >> For instance the hellcreek switch has actually three ptp hardware
> >> clocks and the time stamping can be configur
> From: Leon Romanovsky
> Sent: Thursday, October 8, 2020 1:15 PM
>
> On Thu, Oct 08, 2020 at 07:14:17AM +, Parav Pandit wrote:
> >
> >
> > > From: Leon Romanovsky
> > > Sent: Thursday, October 8, 2020 10:56 AM
> > >
> > > On Thu, Oct 08, 2020 at 04:56:01AM +, Parav Pandit wrote:
> >
On 10/8/20 10:30 AM, Hangbin Liu wrote:
> Hi Eric,
>
> Thanks for the comments. I should add "RFC" in subject next time for the
> uncertain fix patch.
>
> On Wed, Oct 07, 2020 at 11:35:41AM +0200, Eric Dumazet wrote:
>>
>>
>> On 10/7/20 5:55 AM, Hangbin Liu wrote:
>>
>>> kfree_skb(
For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for
gso_size. When using UDP to encapsulate its packet, it will
return error in udp6_ufo_fragment() as skb->len < gso_size,
and it will never go to the gso tunnel processing.
So we should move this check after udp gso tunnel processing,
t
There is a chance that __udp4/6_lib_lookup() returns a udp encap
sock in __udp_lib_err(), like the udp encap listening sock may
use the same port as remote encap port, in which case it should
go to __udp4/6_lib_err_encap() for more validation before
processing the icmp packet.
This patch is to che
To call sctp_gso_segment() properly in skb_udp_tunnel_segment() for sctp
over udp packets, we need to set transport_header to sctp header. When
skb->ip_summed == CHECKSUM_PARTIAL, skb_crc32c_csum_help() should be
called for the inner sctp packet.
Cc: Tom Herbert
Signed-off-by: Xin Long
---
net/
This patch is to add the functions to create/release udp4 sock,
and set the sock's encap_rcv to process the incoming udp encap
sctp packets. In sctp_udp_rcv(), as we can see, all we need to
do is fix the transport header for sctp_rcv(), then it would
implement the part of rfc6951#section-5.4:
"W
Description From the RFC:
The Main Reasons:
o To allow SCTP traffic to pass through legacy NATs, which do not
provide native SCTP support as specified in [BEHAVE] and
[NATSUPP].
o To allow SCTP to be implemented on hosts that do not provide
direct access to the IP la
This patch fixes two things:
When skb->ip_summed == CHECKSUM_PARTIAL, skb_checksum_help() should be
called do the checksum, instead of gso_make_checksum(), which is used
to do the checksum for current proto after calling skb_segment(), not
after the inner proto's gso_segment().
When off
This patch is to add the udp6 sock part in sctp_udp_sock_start/stop().
udp_conf.use_udp6_rx_checksums is set to true, as:
"The SCTP checksum MUST be computed for IPv4 and IPv6, and the UDP
checksum SHOULD be computed for IPv4 and IPv6"
says in rfc6951#section-5.3.
v1->v2:
- Add pr_err()
As rfc6951#section-5.4 says:
"After finding the SCTP association (which
includes checking the verification tag), the UDP source port MUST be
stored as the encapsulation port for the destination address the SCTP
packet is received from (see Section 5.1).
When a non-encapsulated SCTP
As it says in rfc6951#section-5.5:
"When receiving ICMP or ICMPv6 response packets, there might not be
enough bytes in the payload to identify the SCTP association that the
SCTP packet triggering the ICMP or ICMPv6 packet belongs to. If a
received ICMP or ICMPv6 packet cannot be relate
This patch is to implement:
rfc6951#section-6.1: Get or Set the Remote UDP Encapsulation Port Number
with the param of the struct:
struct sctp_udpencaps {
sctp_assoc_t sue_assoc_id;
struct sockaddr_storage sue_address;
uint16_t sue_port;
};
the encap_port of sock, assoc or tra
sctp_mtu_payload() is for calculating the frag size before making
chunks from a msg. So we should only add udphdr size to overhead
when udp socks are listening, as only then sctp can handle the
incoming sctp over udp packets and outgoing sctp over udp packets
will be possible.
Note that we can't d
sk_setup_caps() was originally called in Commit 90017accff61 ("sctp:
Add GSO support"), as:
"We have to refresh this in case we are xmiting to more than one
transport at a time"
This actually happens in the loop of sctp_outq_flush_transports(),
and it shouldn't be tied to gso, so move it out
This patch does what the rfc6951#section-5.3 says for ipv4:
"Within the UDP header, the source port MUST be the local UDP
encapsulation port number of the SCTP stack, and the destination port
MUST be the remote UDP encapsulation port number maintained for the
association and the destina
encap_port is added as per netns/sock/assoc/transport, and the
latter one's encap_port inherits the former one's by default.
The transport's encap_port value would mostly decide if one
packet should go out with udp encapsulated or not.
This patch also allows users to set netns' encap_port by sysct
This one basically does the similar things in sctp_v6_xmit as does for
udp4 sock in the last patch, just note that:
1. label needs to be calculated, as it's the param of
udp_tunnel6_xmit_skb().
2. The 'nocheck' param of udp_tunnel6_xmit_skb() is false, as
required by RFC.
v1->v2:
This is from Section 4 of draft-tuexen-tsvwg-sctp-udp-encaps-cons-03,
and it requires responding with an abort chunk with an error cause
when the udp source port of the received init chunk doesn't match the
encap port of the transport.
Signed-off-by: Xin Long
---
net/sctp/sm_statefuns.c | 50 +++
Kalle Valo writes:
> Greg Kroah-Hartman writes:
>
>> On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote:
>>> From: Jérôme Pouiller
>>>
>>> I think the wfx driver is now mature enough to be accepted in the
>>> drivers/net/wireless directory.
>>>
>>> There is still one item on the
This patch is to add the function to make the abort chunk with
the error cause for new encapsulation port restart, defined
on Section 4.4 in draft-tuexen-tsvwg-sctp-udp-encaps-cons-03.
Signed-off-by: Xin Long
---
include/linux/sctp.h | 20
include/net/sctp/sm.h| 3 +
This patch is to enable udp tunneling socks by calling
sctp_udp_sock_start() in sctp_ctrlsock_init(), and
sctp_udp_sock_stop() in sctp_ctrlsock_exit().
Also add sysctl udp_port to allow changing the listening
sock's port by users.
Wit this patch, the whole sctp over udp feature can be
enabled and
On Thu Oct 08 2020, Vladimir Oltean wrote:
> On Thu, Oct 08, 2020 at 10:34:11AM +0200, Kurt Kanzenbach wrote:
>> On Wed Oct 07 2020, Vladimir Oltean wrote:
>> > On Wed, Oct 07, 2020 at 12:39:49PM +0200, Kurt Kanzenbach wrote:
>> >> For instance the hellcreek switch has actually three ptp hardware
>
CCing Tom Herbert
On Thu, Oct 8, 2020 at 5:48 PM Xin Long wrote:
>
> To call sctp_gso_segment() properly in skb_udp_tunnel_segment() for sctp
> over udp packets, we need to set transport_header to sctp header. When
> skb->ip_summed == CHECKSUM_PARTIAL, skb_crc32c_csum_help() should be
> called fo
CCing Tom Herbert
On Thu, Oct 8, 2020 at 5:48 PM Xin Long wrote:
>
> This patch fixes two things:
>
> When skb->ip_summed == CHECKSUM_PARTIAL, skb_checksum_help() should be
> called do the checksum, instead of gso_make_checksum(), which is used
> to do the checksum for current proto after c
On Thursday 8 October 2020 09:30:06 CEST Kalle Valo wrote:
[...]
> Yes, the driver needs to be reviewed in linux-wireless list. I recommend
> submitting the whole driver in a patchset with one file per patch, which
> seems to be the easiest way to review a full driver. The final move will
> be in j
On Thu, Oct 08, 2020 at 09:45:29AM +, Parav Pandit wrote:
>
>
> > From: Leon Romanovsky
> > Sent: Thursday, October 8, 2020 1:15 PM
> >
> > On Thu, Oct 08, 2020 at 07:14:17AM +, Parav Pandit wrote:
> > >
> > >
> > > > From: Leon Romanovsky
> > > > Sent: Thursday, October 8, 2020 10:56 AM
On Wed, 2020-10-07 at 14:49 +, Nikolay Aleksandrov wrote:
> On Wed, 2020-10-07 at 12:07 +, Henrik Bjoernlund wrote:
> > This commit is correcting NETLINK br_fill_ifinfo() to be able to
> > handle 'filter_mask' with multiple flags asserted.
> >
> > Fixes: 36a8e8e265420 ("bridge: Extend br_f
Hello Andrii,
On Wed, Oct 7, 2020 at 8:01 PM Andrii Nakryiko
wrote:
>
> On Wed, Oct 7, 2020 at 10:56 AM Luka Perkov wrote:
> >
> > Hello Andrii,
> >
> > On Fri, Oct 2, 2020 at 3:09 AM Andrii Nakryiko wrote:
> > > Patch set implements logic in libbpf to auto-adjust memory size (1-, 2-,
> > > 4-
Hi Dave,
Not sure you were still planning to send anything to Linus,
but even if not this single fix seemed appropriate for net.
Seems to be a long-standing issue.
Please pull and let me know if there's any problem.
Thanks,
johannes
The following changes since commit d91dc434f2baa592e97935974
Hi Dave,
And also a few more patches for net-next, mostly fixes
for the work that recently landed there.
Please pull and let me know if there's any problem.
Thanks,
johannes
The following changes since commit 9faebeb2d80065926dfbc09cb73b1bb7779a89cd:
Merge branch 'ethtool-allow-dumping-pol
Lee Jones wrote:
> None of these headers attempt to document any function parameters.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/intel/iwlwifi/dvm/main.c:388: warning: Function
> parameter or member 't' not described in 'iwl_bg_statistics_periodic'
> driver
Export the policy used for attribute validation when it fails,
so e.g. for an out-of-range attribute userspace immediately gets
the valid ranges back.
v2 incorporates the suggestion from Jakub to have a function to
estimate the size (netlink_policy_dump_attr_size_estimate()) and
check that it does
From: Johannes Berg
Refactor the per-attribute policy writing into a new
helper function, to be used later for dumping out the
policy of a rejected attribute.
v2:
- fix some indentation
v3:
- change variable order in netlink_policy_dump_write()
Reviewed-by: Jakub Kicinski
Signed-off-by: Joha
From: Johannes Berg
Add a new attribute NLMSGERR_ATTR_POLICY to the extended ACK
to advertise the policy, e.g. if an attribute was out of range,
you'll know the range that's permissible.
Add new NL_SET_ERR_MSG_ATTR_POL() and NL_SET_ERR_MSG_ATTR_POL()
macros to set this, since realistically it's
Alex Dewar wrote:
> In ath11k_mac_setup_iface_combinations(), if memory cannot be assigned
> for the variable limits, then the memory assigned to combinations will
> be leaked. Fix this.
>
> Addresses-Coverity-ID: 1497534 ("Resource leaks")
> Fixes: 2626c269702e ("ath11k: add interface_modes to
On Thu, 8 Oct 2020 11:06:14 +0300
Shay Agroskin wrote:
> Lorenzo Bianconi writes:
>
> > Introduce the capability to allocate a xdp multi-buff in
> > bpf_prog_test_run_xdp routine. This is a preliminary patch to
> > introduce
> > the selftests for new xdp multi-buff ebpf helpers
> >
> > Signed-
t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analysis reports this problem:
>
> sdio.c:2403:3: warning: Attempt to free released memory
> kfree(card->mpa_rx.buf);
> ^~~
>
> When mwifiex_init_sdio() fails in its first call to
> mwifiex_alloc_sdio_m
Chris Chiu wrote:
> From: Chris Chiu
>
> The legacy_httxpowerdiff in rtl8192se is pretty much the same as
> the legacy_ht_txpowerdiff for other chips. Use the same name to
> keep the consistency.
>
> Signed-off-by: Chris Chiu
Patch applied to wireless-drivers-next.git, thanks.
8b2426c50f20
Colin King wrote:
> From: Colin Ian King
>
> Currently the error return path when 'limits' fails to allocate
> does not free the memory allocated for 'combinations'. Fix this
> by adding a kfree before returning.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 2626c269702e ("ath11k: add int
Jérôme Pouiller writes:
> On Thursday 8 October 2020 09:30:06 CEST Kalle Valo wrote:
> [...]
>> Yes, the driver needs to be reviewed in linux-wireless list. I recommend
>> submitting the whole driver in a patchset with one file per patch, which
>> seems to be the easiest way to review a full driv
On Wed, 7 Oct 2020 16:46:10 -0700
Maciej Żenczykowski wrote:
> > static u32 __bpf_skb_max_len(const struct sk_buff *skb)
> > {
> > - return skb->dev ? skb->dev->mtu + skb->dev->hard_header_len :
> > - SKB_MAX_ALLOC;
> > + return IP_MAX_MTU;
> > }
>
> Shou
neighbours table dump supports today two filtering:
* based on interface index
* based on master index
This patch adds a new filtering, based on layer two address. That will
help to replace something like it:
ip neigh show | grep aa:11:22:bb:ee:ff
by a better command:
ip neigh show lladdr a
> From: gre...@linuxfoundation.org
> Sent: Thursday, October 8, 2020 1:21 PM
>
> On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> > On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky
> wrote:
> > [..]
> > > All stated above is my opinion, it can be different from yours.
> >
> > Yes
On Wed, Oct 7, 2020 at 9:22 PM Cong Wang wrote:
>
> GRE tunnel has its own header_ops, ipgre_header_ops, and sets it
> conditionally. When it is set, it assumes the outer IP header is
> already created before ipgre_xmit().
>
> This is not true when we send packets through a raw packet socket,
> wh
Signed-off-by: Samanta Navarro
---
man/man8/ip-link.8.in | 14 +++---
man/man8/ip-neighbour.8 | 6 +++---
man/man8/tc-actions.8 | 2 +-
man/man8/tc-pie.8 | 4 ++--
4 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
i
On Tue, Oct 06, 2020 at 12:13:04PM +0200, Kurt Kanzenbach wrote:
> >> >> +static const struct hellcreek_platform_data de1soc_r1_pdata = {
> >> >> + .num_ports = 4,
> >> >> + .is_100_mbits= 1,
> >> >> + .qbv_support = 1,
> >> >> + .qbv_on_cpu_port = 1,
> >> >
>
The VCAP_IS1_ACT_VID_REPLACE_ENA action, from the VCAP IS1 ingress TCAM,
changes the classified VLAN.
We are only exposing this ability for switch ports that are under VLAN
aware bridges. This is because in standalone ports mode and under a
bridge with vlan_filtering=0, the ocelot driver configure
This series offloads one more action to the VCAP IS1 ingress TCAM, which
is to change the classified VLAN for packets, according to the VCAP IS1
keys (VLAN, source MAC, source IP, EtherType, etc).
Vladimir Oltean (3):
net: mscc: ocelot: offload VLAN mangle action to VCAP IS1
net: dsa: tag_ocel
When the Extraction Frame Header contains a valid classified VLAN, use
that instead of the VLAN header present in the packet.
Signed-off-by: Vladimir Oltean
---
net/dsa/tag_ocelot.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/net/dsa/tag_ocelot.c b/net
Create a test that changes a VLAN ID from 200 to 300.
We also need to modify the preferences of the filters installed for the
other rules so that they are unique, because we now install the "tc-vlan
modify" filter in VCAP IS1 only temporarily, and we need to perform the
deletion by filter preferen
Instructions and examples on kernel data structures dumping and coredump.
Signed-off-by: Coiby Xu
---
.../networking/device_drivers/index.rst | 1 +
.../device_drivers/qlogic/index.rst | 18 +++
.../networking/device_drivers/qlogic/qlge.rst | 118 ++
MAINTAINER
devlink health could be used to get coredump. No need to send so much
data to the kernel ring buffer.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge.h | 3 ---
drivers/staging/qlge/qlge_dbg.c | 11 ---
drivers/staging/qlge/qlge_ethtool.c | 1 -
drivers/staging/qlge/q
$ devlink health dump show DEVICE reporter coredump -p -j
{
"Core Registers": {
"segment": 1,
"values": [
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
With force_coredump module paramter set, devlink health dump will reset
the MPI RISC first which takes 5 secs to be finished.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/qlge/qlge_devlink.c
b/drivers/
The debugging code in the following ifdef land
- QL_ALL_DUMP
- QL_REG_DUMP
- QL_DEV_DUMP
- QL_CB_DUMP
- QL_IB_DUMP
- QL_OB_DUMP
becomes unnecessary because,
- Device status and general registers can be obtained by ethtool.
- Coredump can be done via devlink health reporter.
- Structure re
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig| 1 +
drivers/staging/qlge/Makefile | 2 +-
drivers/staging/qlge/qlge.h | 9 +++
drivers/staging/qlge/qlge
From: Maxim Kochetkov
When packets are received on the error queue, this function under
net_ratelimit():
netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
does not get printed. Instead we only see:
[ 3658.845592] net_ratelimit: 244 callbacks suppressed
[ 3663.969535] net_ratelimit: 230
On Thu, Oct 08, 2020 at 03:03:12PM +0300, Vladimir Oltean wrote:
> From: Maxim Kochetkov
>
> When packets are received on the error queue, this function under
> net_ratelimit():
>
> netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
>
> does not get printed. Instead we only see:
>
> [ 3
For older versions of gcc, the array = {0}; will cause warnings:
net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all':
net/smc/smc_llc.c:1317:9: warning: missing braces around initializer
[-Wmissing-braces]
struct smc_llc_msg_del_link delllc = {0};
^
net/smc/smc_llc.c:1317:9:
For older versions of gcc, the array = {0}; will cause warnings:
net/smc/smc_llc.c: In function 'smc_llc_add_link_local':
net/smc/smc_llc.c:1212:9: warning: missing braces around initializer
[-Wmissing-braces]
struct smc_llc_msg_add_link add_llc = {0};
^
net/smc/smc_llc.c:1212:9: warni
On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote:
>
> Initialize devlink health dump framework for the dlge driver so the
> coredump could be done via devlink.
>
> Signed-off-by: Coiby Xu
> @@ -4556,6 +4559,13 @@ static int qlge_probe(struct pci_dev *pdev,
> struct ql_adapter *qdev = NULL;
On Thu, Oct 8, 2020 at 7:06 AM Jesper Dangaard Brouer wrote:
>
> On Wed, 7 Oct 2020 16:46:10 -0700
> Maciej Żenczykowski wrote:
>
> > > static u32 __bpf_skb_max_len(const struct sk_buff *skb)
> > > {
> > > - return skb->dev ? skb->dev->mtu + skb->dev->hard_header_len :
> > > -
On Thu, Oct 8, 2020 at 5:48 AM Xin Long wrote:
>
> For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for
> gso_size. When using UDP to encapsulate its packet, it will
> return error in udp6_ufo_fragment() as skb->len < gso_size,
> and it will never go to the gso tunnel processing.
>
> So
1 - 100 of 451 matches
Mail list logo
