Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-06 Thread Lee Jones
On Fri, 02 Oct 2020, Rob Herring wrote: > Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open sou

Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-06 Thread Johan Hovold
On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote: > On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin wrote: > > On 10/5/2020 18:06, Johan Hovold wrote: > > > Do you remember the interface layout and why you blacklisted interface > > > 1? > > It is very likely that Cellient has replace

Re: [PATCH] fs: remove ->sendpage

2020-10-06 Thread Christoph Hellwig
On Mon, Sep 28, 2020 at 03:17:34PM -0700, David Miller wrote: > From: Christoph Hellwig > Date: Sat, 26 Sep 2020 09:00:49 +0200 > > > ->sendpage is only called from generic_splice_sendpage. The only user of > > generic_splice_sendpage is socket_file_ops, which is also the only > > instance that

Re: [PATCH v2 00/29] [Set 1,2,3] Rid W=1 warnings in Wireless

2020-10-06 Thread Kalle Valo
Lee Jones writes: > On Tue, 06 Oct 2020, Kalle Valo wrote: > >> Lee Jones writes: >> >> > On Thu, 10 Sep 2020, Lee Jones wrote: >> > >> >> This is a rebased/re-worked set of patches which have been >> >> previously posted to the mailing list(s). >> >> >> >> This set is part of a larger effort

Re: [PATCH 2/2] wireless: mt76: convert tasklets to use new tasklet_setup() API

2020-10-06 Thread Kalle Valo
Allen Pais writes: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-06 Thread Leon Romanovsky
On Mon, Oct 05, 2020 at 11:24:41AM -0700, Dave Ertman wrote: > Add support for the Ancillary Bus, ancillary_device and ancillary_driver. > It enables drivers to create an ancillary_device and bind an > ancillary_driver to it. I was under impression that this name is going to be changed. > > The b

Re: [RFC] net: phy: add shutdown hook to struct phy_driver

2020-10-06 Thread Jisheng Zhang
On Tue, 6 Oct 2020 07:45:10 +0200 Heiner Kallweit wrote: > > On 05.10.2020 18:00, Florian Fainelli wrote: > > > > > > On 10/5/2020 8:54 AM, Heiner Kallweit wrote: > >> On 05.10.2020 17:41, Florian Fainelli wrote: > >>> > >>> > >>> On 10/5/2020 1:53 AM, Jisheng Zhang wrote: > On Wed,

Re: [PATCH can-next] can: add ISO 15765-2:2016 transport protocol

2020-10-06 Thread Oliver Hartkopp
Hello Marc, this code had its initial commit on Nov 5th 2008: https://github.com/hartkopp/can-isotp/blob/master/net/can/isotp.c#L597 and has been used (and tested) in many productive environments by many people since then. So many (happy) developers contacted my off-list after this post, tha

Re: [PATCH can-next] can: add ISO 15765-2:2016 transport protocol

2020-10-06 Thread Oliver Hartkopp
Wrong URL for the initial commit m( https://github.com/hartkopp/can-isotp-modules/commit/ec109096fd72c0f286316d0084494582939626e5 Sorry On 06.10.20 09:19, Oliver Hartkopp wrote: Hello Marc, this code had its initial commit on Nov 5th 2008: https://github.com/hartkopp/can-isotp/blob/master/ne

Re: [PATCH 2/2] ath11k: Handle errors if peer creation fails

2020-10-06 Thread Kalle Valo
Alex Dewar writes: > ath11k_peer_create() is called without its return value being checked, > meaning errors will be unhandled. Add missing check and, as the mutex is > unconditionally unlocked on leaving this function, simplify the exit > path. > > Addresses-Coverity-ID: 1497531 ("Code maintaina

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 08:27:42AM +0200, Kurt Kanzenbach wrote: > On Sun Oct 04 2020, Vladimir Oltean wrote: > > On Sun, Oct 04, 2020 at 01:29:08PM +0200, Kurt Kanzenbach wrote: > >> +/* Enabling/disabling TX and RX HW timestamping for different PTP > >> messages is > >> + * not available in the

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-06 Thread Jesper Dangaard Brouer
On Mon, 05 Oct 2020 21:29:36 -0700 John Fastabend wrote: > Lorenzo Bianconi wrote: > > [...] > > > > > > > > In general I see no reason to populate these fields before the XDP > > > program runs. Someone needs to convince me why having frags info before > > > program runs is useful. In genera

Re: [PATCH 2/3] dt-bindings: can: rcar_can: Add r8a7742 support

2020-10-06 Thread Lad, Prabhakar
Hi Marc, On Tue, Aug 25, 2020 at 3:21 AM Rob Herring wrote: > > On Sun, 16 Aug 2020 20:07:31 +0100, Lad Prabhakar wrote: > > Document RZ/G1H (r8a7742) SoC specific bindings. The R8A7742 CAN module > > is identical to R-Car Gen2 family. > > > > No driver change is needed due to the fallback compat

Re: [RFC] Status of orinoco_usb

2020-10-06 Thread Arend Van Spriel
+ Jes On 10/5/2020 4:12 PM, Kalle Valo wrote: Greg Kroah-Hartman writes: On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior wrote: On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote: Is it possible to end up here in softirq context or is this a relic? I think it's a

Re: [RESEND net-next 4/8] net: mac802154: convert tasklets to use new tasklet_setup() API

2020-10-06 Thread Stefan Schmidt
Hello. On 06.10.20 08:31, Allen Pais wrote: In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Alle

PHY reset question

2020-10-06 Thread Oleksij Rempel
Hello PHY experts, Short version: what is the proper way to handle the PHY reset before identifying PHY? Long version: I stumbled over following issue: If PHY reset is registered within PHY node. Then, sometimes, we will not be able to identify it (read PHY ID), because PHY is under reset. mdio

WARNING in sta_info_alloc

2020-10-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:549738f1 Linux 5.9-rc8 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15b97ba390 kernel config: https://syzkaller.appspot.com/x/.config?x=c06bcf3cc963d91c dashboard link: https://syzkaller.appspot

WARNING in ieee80211_probe_client

2020-10-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c2568c8c Merge branch 'net-Constify-struct-genl_small_ops' git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14051a2b90 kernel config: https://syzkaller.appspot.com/x/.config?x=1e6c5266df853ae dashbo

WARNING in ieee80211_check_rate_mask

2020-10-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c2568c8c Merge branch 'net-Constify-struct-genl_small_ops' git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=16e2fb4d90 kernel config: https://syzkaller.appspot.com/x/.config?x=1e6c5266df853ae dashbo

Re: [PATCH 2/2] ath11k: Handle errors if peer creation fails

2020-10-06 Thread Alex Dewar
On Tue, Oct 06, 2020 at 10:26:28AM +0300, Kalle Valo wrote: > Alex Dewar writes: > > > ath11k_peer_create() is called without its return value being checked, > > meaning errors will be unhandled. Add missing check and, as the mutex is > > unconditionally unlocked on leaving this function, simplif

Re: WARNING in sta_info_alloc

2020-10-06 Thread Will Deacon
On Tue, Oct 06, 2020 at 01:08:23AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:549738f1 Linux 5.9-rc8 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=15b97ba390 > kernel config: https://syzkaller.appspot.co

INFO: task hung in usb_get_descriptor

2020-10-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d3d45f82 Merge tag 'pinctrl-v5.9-2' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1318aab790 kernel config: https://syzkaller.appspot.com/x/.config?x=89ab6a0c48f30b49 das

INFO: task hung in hub_port_init

2020-10-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d3d45f82 Merge tag 'pinctrl-v5.9-2' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14c3b3db90 kernel config: https://syzkaller.appspot.com/x/.config?x=89ab6a0c48f30b49 das

Re: [PATCH 5/9 net-next] gtp: use dev_sw_netstats_rx_add()

2020-10-06 Thread Harald Welte
On Mon, Oct 05, 2020 at 10:35:46PM +0200, Fabian Frederick wrote: > use new helper for netstats settings Acked-by: Harald Welte -- - Harald Weltehttp://laforge.gnumonks.org/ "Privacy in residential applicat

[PATCH net-next] net: openvswitch: Add support to lookup invalid packet in ct action.

2020-10-06 Thread nusiddiq
From: Numan Siddique For a tcp packet which is part of an existing committed connection, nf_conntrack_in() will return err and set skb->_nfct to NULL if it is out of tcp window. ct action for this packet will set the ct_state to +inv which is as expected. But a controller cannot add an OVS flow

Re: [PATCH v2 0/4] AX88796C SPI Ethernet Adapter

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-02 pią 21:45>, when Andrew Lunn wrote: > On Fri, Oct 02, 2020 at 09:22:06PM +0200, Łukasz Stelmach wrote: >> This is a driver for AX88796C Ethernet Adapter connected in SPI mode as >> found on ARTIK5 evaluation board. The driver has been ported from a >> v3.10.9 vendor kernel for AR

Re: INFO: task hung in hub_port_init

2020-10-06 Thread Oliver Neukum
Am Dienstag, den 06.10.2020, 01:19 -0700 schrieb syzbot: Hi, > HEAD commit:d3d45f82 Merge tag 'pinctrl-v5.9-2' of git://git.kernel.or.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=14c3b3db90 > kernel config: https://syzkaller.appspot.com/x/.conf

Re: linux-next: build failure after merge of the net-next tree

2020-10-06 Thread Daniel Borkmann
On 10/6/20 7:41 AM, Stephen Rothwell wrote: On Tue, 6 Oct 2020 07:13:01 +0200 Christoph Hellwig wrote: On Tue, Oct 06, 2020 at 02:58:47PM +1100, Stephen Rothwell wrote: Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: It actually doe

Re: [net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation

2020-10-06 Thread Jiri Pirko
Mon, Oct 05, 2020 at 03:07:12PM CEST, allan.niel...@microchip.com wrote: >Hi Jiri > >On 01.10.2020 14:49, Jiri Pirko wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> Thu, Oct 01, 2020 at 12:30:18PM CEST, henrik.bjoernl...@microchip.com

Re: [PATCH] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-10-06 Thread Marek Vasut
On 9/28/20 3:03 PM, Richard Leitner wrote: > On Sat, Sep 26, 2020 at 08:52:17PM +0200, Marek Vasut wrote: >> On 9/9/20 10:38 AM, Richard Leitner wrote: >>> On Fri, Sep 04, 2020 at 09:23:26PM +0200, Marek Vasut wrote: On 9/4/20 9:02 PM, Richard Leitner wrote: > On Fri, Sep 04, 2020 at 05:26

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 08:09:39AM +0200, Kurt Kanzenbach wrote: > On Sun Oct 04 2020, Vladimir Oltean wrote: > > I don't think this works. > > > > ip link add br0 type bridge vlan_filtering 1 > > ip link set swp0 master br0 > > bridge vlan add dev swp0 vid 100 > > ip link set br0 type bridge vlan_

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote: > On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: >> >> Add node for ax88796c ethernet chip. >> >> Signed-off-by: Łukasz Stelmach >> --- >> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 >> 1 file changed

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Kurt Kanzenbach
On Tue Oct 06 2020, Vladimir Oltean wrote: > On Tue, Oct 06, 2020 at 08:09:39AM +0200, Kurt Kanzenbach wrote: >> On Sun Oct 04 2020, Vladimir Oltean wrote: >> > I don't think this works. >> > >> > ip link add br0 type bridge vlan_filtering 1 >> > ip link set swp0 master br0 >> > bridge vlan add dev

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-06 Thread Krzysztof Kozlowski
On Tue, 6 Oct 2020 at 12:06, Lukasz Stelmach wrote: > > It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote: > > On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: > >> > >> Add node for ax88796c ethernet chip. > >> > >> Signed-off-by: Łukasz Stelmach > >> --- > >> arch/arm/boot/dts/

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-06 Thread Frederic Weisbecker
On Mon, Oct 05, 2020 at 02:52:49PM -0400, Nitesh Narayan Lal wrote: > > On 10/4/20 7:14 PM, Frederic Weisbecker wrote: > > On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote: > >> On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote: > >>> External Email > >>> > >>> --

Re: [net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation

2020-10-06 Thread Nikolay Aleksandrov
On Mon, 2020-10-05 at 15:07 +0200, Allan W. Nielsen wrote: > Hi Jiri > > On 01.10.2020 14:49, Jiri Pirko wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Thu, Oct 01, 2020 at 12:30:18PM CEST, henrik.bjoernl...@microchip.com wrote:

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-06 Thread Alex Belits
On Mon, 2020-10-05 at 01:14 +0200, Frederic Weisbecker wrote: > Speaking of which, I agree with Thomas that it's unnecessary. > > > It's > > > too much > > > code and complexity. We can use the existing trace events and > > > perform > > > the > > > analysis from userspace to find the source of the

Re: [PATCH net-next] net: openvswitch: Add support to lookup invalid packet in ct action.

2020-10-06 Thread Florian Westphal
nusid...@redhat.com wrote: > From: Numan Siddique > > For a tcp packet which is part of an existing committed connection, > nf_conntrack_in() will return err and set skb->_nfct to NULL if it is > out of tcp window. ct action for this packet will set the ct_state > to +inv which is as expected.

Re: [PATCH net-next] net: always dump full packets with skb_dump

2020-10-06 Thread Willem de Bruijn
On Mon, Oct 5, 2020 at 8:25 PM Jacob Keller wrote: > > > > On 10/5/2020 7:48 AM, Vladimir Oltean wrote: > > Currently skb_dump has a restriction to only dump full packet for the > > first 5 socket buffers, then only headers will be printed. Remove this > > arbitrary and confusing restriction, whic

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 12:13:04PM +0200, Kurt Kanzenbach wrote: > On Tue Oct 06 2020, Vladimir Oltean wrote: > > On Tue, Oct 06, 2020 at 08:09:39AM +0200, Kurt Kanzenbach wrote: > >> On Sun Oct 04 2020, Vladimir Oltean wrote: > >> > I don't think this works. > >> > > >> > ip link add br0 type brid

Re: [PATCH net-next] net: always dump full packets with skb_dump

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 07:30:13AM -0400, Willem de Bruijn wrote: > skb_dump is called from skb_warn_bad_offload and netdev_rx_csum_fault. > Previously when these were triggered, a few example bad packets were > sufficient to debug the issue. Yes, and it's only netdev_rx_csum_fault that matters, b

Re: BPF redirect API design issue for BPF-prog MTU feedback?

2020-10-06 Thread Jesper Dangaard Brouer
On Mon, 21 Sep 2020 11:04:09 -0700 John Fastabend wrote: > Daniel Borkmann wrote: > > On 9/21/20 2:49 PM, Jesper Dangaard Brouer wrote: > > > On Mon, 21 Sep 2020 11:37:18 +0100 > > > Lorenz Bauer wrote: > > >> On Sat, 19 Sep 2020 at 00:06, Maciej Żenczykowski > > >> wrote: > > >>> >

Re: [PATCH net-next 5/6] netlink: add mask validation

2020-10-06 Thread Johannes Berg
On Tue, 2020-10-06 at 08:37 +0200, Johannes Berg wrote: > On Mon, 2020-10-05 at 15:21 -0700, Jakub Kicinski wrote: > > > > > Nice, easy & useful, maybe I'll code it up tomorrow. > > > > > > OK I thought about it a bit more and looked at the code, and it's not > > > actually possible to do easil

Re: [PATCH net-next] net: always dump full packets with skb_dump

2020-10-06 Thread Willem de Bruijn
On Tue, Oct 6, 2020 at 7:43 AM Vladimir Oltean wrote: > > On Tue, Oct 06, 2020 at 07:30:13AM -0400, Willem de Bruijn wrote: > > skb_dump is called from skb_warn_bad_offload and netdev_rx_csum_fault. > > Previously when these were triggered, a few example bad packets were > > sufficient to debug th

[RFC PATCH] workqueue: Add support for exposing singlethread workqueues in sysfs

2020-10-06 Thread Tariq Toukan
Extend the workqueue API so that singlethread workqueues can be exposed in sysfs. Guarantee max_active is 1 by turning it read-only. This allows admins to control the cpumask of a workqueue, and apply the desired system cpu separation/isolation policy. Signed-off-by: Tariq Toukan --- drivers/ne

Re: WARNING in ieee80211_check_rate_mask

2020-10-06 Thread syzbot
syzbot has bisected this issue to: commit 983e1a6c95abf8058d26149a928578b720c77bce Author: Nelson Chang Date: Thu Oct 6 11:44:02 2016 + net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16

Re: [PATCH net-next] net: openvswitch: Add support to lookup invalid packet in ct action.

2020-10-06 Thread Numan Siddique
On Tue, Oct 6, 2020 at 4:46 PM Florian Westphal wrote: > > nusid...@redhat.com wrote: > > From: Numan Siddique > > > > For a tcp packet which is part of an existing committed connection, > > nf_conntrack_in() will return err and set skb->_nfct to NULL if it is > > out of tcp window. ct action fo

Re: [PATCH bpf-next] libbpf: fix compatibility problem in xsk_socket__create

2020-10-06 Thread Magnus Karlsson
On Mon, Oct 5, 2020 at 4:37 PM Daniel Borkmann wrote: > > On 10/2/20 3:36 PM, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > Fix a compatibility problem when the old XDP_SHARED_UMEM mode is used > > together with the xsk_socket__create() call. In the old XDP_SHARED_UMEM > > mode, only s

[PATCH 0/2] netlink: export policy on validation failures

2020-10-06 Thread Johannes Berg
Export the policy used for attribute validation when it fails, so e.g. for an out-of-range attribute userspace immediately gets the valid ranges back. Tested using nl80211/iw in a few scenarios, seems to work fine and return the policy back, e.g. kernel reports: integer out of range policy: 04 00

[PATCH 2/2] netlink: export policy in extended ACK

2020-10-06 Thread Johannes Berg
From: Johannes Berg Add a new attribute NLMSGERR_ATTR_POLICY to the extended ACK to advertise the policy, e.g. if an attribute was out of range, you'll know the range that's permissible. Add new NL_SET_ERR_MSG_ATTR_POL() and NL_SET_ERR_MSG_ATTR_POL() macros to set this, since realistically it's

[PATCH 1/2] netlink: policy: refactor per-attr policy writing

2020-10-06 Thread Johannes Berg
From: Johannes Berg Refactor the per-attribute policy writing into a new helper function, to be used later for dumping out the policy of a rejected attribute. Signed-off-by: Johannes Berg --- net/netlink/policy.c | 79 1 file changed, 51 insertions(

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 02:32:37PM +0300, Vladimir Oltean wrote: > - The .port_vlan_add will always install the VLAN to the hardware > database, no queuing if there's no reason for it (and I can't see any. > Your hardware seems to be sane enough to not drop a VLAN-tagged frame, > and forward

RE: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-06 Thread Jubran, Samih
> -Original Message- > From: Daniel Borkmann > Sent: Friday, October 2, 2020 10:53 PM > To: John Fastabend ; Lorenzo Bianconi > ; b...@vger.kernel.org; netdev@vger.kernel.org > Cc: da...@davemloft.net; k...@kernel.org; a...@kernel.org; Agroskin, > Shay ; Jubran, Samih ; > dsah...@kernel.

Re: [RFC] Status of orinoco_usb

2020-10-06 Thread Jes Sorensen
On 10/6/20 3:45 AM, Arend Van Spriel wrote: > + Jes > > On 10/5/2020 4:12 PM, Kalle Valo wrote: >> Greg Kroah-Hartman writes: >> >>> On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior >>> wrote: On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote: >> Is it possible

general protection fault in ieee80211_chanctx_num_assigned

2020-10-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:2172e358 Add linux-next specific files for 20201002 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=176b55c050 kernel config: https://syzkaller.appspot.com/x/.config?x=70698f530a7e856f dashboard

Re: [net-next 01/15] net/mlx5: DR, Add buddy allocator utilities

2020-10-06 Thread Yevgeny Kliteynik
On 29-Sep-20 23:44, Yevgeny Kliteynik wrote:> > On 29-Sep-20 00:41, David Miller wrote: >> >> From: Yevgeny Kliteynik >> Date: Mon, 28 Sep 2020 19:58:59 + >> >>> By replacing the bits-per-long array with a single counter we loose >>> this ability to jump faster to the free spot. >> >> I don't

Re: [PATCH v3] net: qrtr: ns: Fix the incorrect usage of rcu_read_lock()

2020-10-06 Thread David Miller
From: Manivannan Sadhasivam Date: Mon, 5 Oct 2020 12:46:42 +0530 > The rcu_read_lock() is not supposed to lock the kernel_sendmsg() API > since it has the lock_sock() in qrtr_sendmsg() which will sleep. Hence, > fix it by excluding the locking for kernel_sendmsg(). > > While at it, let's also u

Re: [PATCH net 0/2] Fix tail dropping watermarks for Ocelot switches

2020-10-06 Thread David Miller
From: Vladimir Oltean Date: Mon, 5 Oct 2020 12:09:10 +0300 > This series adds a missing division by 60, and a warning to prevent that > in the future. Series applied, thank you.

Re: [PATCH net] mptcp: more DATA FIN fixes

2020-10-06 Thread David Miller
From: Paolo Abeni Date: Mon, 5 Oct 2020 12:01:06 +0200 > Currently data fin on data packet are not handled properly: > the 'rcv_data_fin_seq' field is interpreted as the last > sequence number carrying a valid data, but for data fin > packet with valid maps we currently store map_seq + map_len,

Re: [PATCH net-next] mptcp: don't skip needed ack

2020-10-06 Thread David Miller
From: Paolo Abeni Date: Mon, 5 Oct 2020 12:36:44 +0200 > Currently we skip calling tcp_cleanup_rbuf() when packets > are moved into the OoO queue or simply dropped. In both > cases we still increment tp->copied_seq, and we should > ask the TCP stack to check for ack. > > Fixes: c76c6956566f ("m

Re: [PATCH v4] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-06 Thread David Miller
From: Anant Thazhemadam Date: Mon, 5 Oct 2020 18:59:58 +0530 > When get_registers() fails in set_ethernet_addr(),the uninitialized > value of node_id gets copied over as the address. > So, check the return value of get_registers(). > > If get_registers() executed successfully (i.e., it returns

Re: [PATCH net] tcp: fix receive window update in tcp_add_backlog()

2020-10-06 Thread David Miller
From: Eric Dumazet Date: Mon, 5 Oct 2020 06:48:13 -0700 > From: Eric Dumazet > > We got reports from GKE customers flows being reset by netfilter > conntrack unless nf_conntrack_tcp_be_liberal is set to 1. > > Traces seemed to suggest ACK packet being dropped by the > packet capture, or more

Re: [PATCH net-next] net: always dump full packets with skb_dump

2020-10-06 Thread David Miller
From: Vladimir Oltean Date: Mon, 5 Oct 2020 17:48:38 +0300 > Currently skb_dump has a restriction to only dump full packet for the > first 5 socket buffers, then only headers will be printed. Remove this > arbitrary and confusing restriction, which is only documented vaguely > ("up to") in the c

Re: [PATCH v3 net-next 0/3] net: atlantic: phy tunables from mac driver

2020-10-06 Thread David Miller
From: Igor Russkikh Date: Mon, 5 Oct 2020 18:39:36 +0300 > This series implements phy tunables settings via MAC driver callbacks. > > AQC 10G devices use integrated MAC+PHY solution, where PHY is fully controlled > by MAC firmware. Therefore, it is not possible to implement separate phy > drive

Re: [PATCH net 0/6] rxrpc: Miscellaneous fixes

2020-10-06 Thread David Miller
From: David Howells Date: Mon, 05 Oct 2020 17:18:44 +0100 > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-fixes-20201005.txt I think the ".txt" at the end of the branch name is a mistake. It's really hard to send a clea

Re: [PATCH 0/9 net-next] drivers/net: add sw_netstats_rx_add helper

2020-10-06 Thread David Miller
From: Fabian Frederick Date: Mon, 5 Oct 2020 22:33:57 +0200 > This small patchset creates netstats addition dev_sw_netstats_rx_add() > based on dev_lstats_add() and replaces some open coding > in both drivers/net and net branches. Series applied, thank you.

Re: [PATCH net-next] net: openvswitch: Add support to lookup invalid packet in ct action.

2020-10-06 Thread Numan Siddique
On Tue, Oct 6, 2020 at 5:49 PM Numan Siddique wrote: > > On Tue, Oct 6, 2020 at 4:46 PM Florian Westphal wrote: > > > > nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > For a tcp packet which is part of an existing committed connection, > > > nf_conntrack_in() will return err a

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Kurt Kanzenbach
On Tue Oct 06 2020, Vladimir Oltean wrote: > Yes, that's what I said, and it's not wrong because there's a big IF there. > But first of all, whatever you do has to work, no matter how you do it. > > DSA can at any moment call your .port_vlan_add method either from the > bridge or from the 8021q mod

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-06 Thread David Miller
From: Johannes Berg Date: Tue, 06 Oct 2020 08:43:17 +0200 > On Mon, 2020-10-05 at 15:07 -0700, Jakub Kicinski wrote: >> Hi! >> >> This series wires up ethtool policies to ops, so they can be >> dumped to user space for feature discovery. >> >> First patch wires up GET commands, and second patch

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-06 Thread Kurt Kanzenbach
On Tue Oct 06 2020, Vladimir Oltean wrote: > On Tue, Oct 06, 2020 at 08:27:42AM +0200, Kurt Kanzenbach wrote: >> On Sun Oct 04 2020, Vladimir Oltean wrote: >> > On Sun, Oct 04, 2020 at 01:29:08PM +0200, Kurt Kanzenbach wrote: >> >> +/* Enabling/disabling TX and RX HW timestamping for different PTP

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 03:30:36PM +0200, Kurt Kanzenbach wrote: > That's the point. The user (or anybody else) cannot disable hardware > stamping, because it is always performed. So, why should it be allowed > to disable it even when it cannot be disabled? Because your driver's user can attach a

Re: [PATCH net 0/6] rxrpc: Miscellaneous fixes

2020-10-06 Thread David Howells
David Miller wrote: > I think the ".txt" at the end of the branch name is a mistake. Sigh. That's the name of the file with the cover message in it (named for the tag). I need to adjust my script yet more to check not only that the tag name is in there, but that it also doesn't have any bits o

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 03:23:36PM +0200, Kurt Kanzenbach wrote: > On Tue Oct 06 2020, Vladimir Oltean wrote: > Does this mean that tagged traffic is forwarded no matter what? Precisely. The bridge VLAN table should be irrelevant to the acceptance or forwarding decision of the packet if vlan_filte

[PATCH][RESEND] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-10-06 Thread Marek Vasut
The phy_reset_after_clk_enable() does a PHY reset, which means the PHY loses its register settings. The fec_enet_mii_probe() starts the PHY and does the necessary calls to configure the PHY via PHY framework, and loads the correct register settings into the PHY. Therefore, fec_enet_mii_probe() shou

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-06 Thread Kurt Kanzenbach
On Tue Oct 06 2020, Vladimir Oltean wrote: > On Tue, Oct 06, 2020 at 03:30:36PM +0200, Kurt Kanzenbach wrote: >> That's the point. The user (or anybody else) cannot disable hardware >> stamping, because it is always performed. So, why should it be allowed >> to disable it even when it cannot be dis

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 03:23:36PM +0200, Kurt Kanzenbach wrote: > So you're saying private VLANs can be used but the user or the other > kernel modules shouldn't be allowed to use them to simplify the > implementation? Makes sense to me. It would be interesting to see if you could simply turn of

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 03:56:31PM +0200, Kurt Kanzenbach wrote: > On Tue Oct 06 2020, Vladimir Oltean wrote: > > On Tue, Oct 06, 2020 at 03:30:36PM +0200, Kurt Kanzenbach wrote: > >> That's the point. The user (or anybody else) cannot disable hardware > >> stamping, because it is always performed.

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-06 wto 12:17>, when Krzysztof Kozlowski wrote: > On Tue, 6 Oct 2020 at 12:06, Lukasz Stelmach wrote: >> It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote: >>> On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: Add node for ax88796c ethernet chip. S

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Kurt Kanzenbach
On Tue Oct 06 2020, Vladimir Oltean wrote: > On Tue, Oct 06, 2020 at 03:23:36PM +0200, Kurt Kanzenbach wrote: >> On Tue Oct 06 2020, Vladimir Oltean wrote: >> Does this mean that tagged traffic is forwarded no matter what? > > Precisely. The bridge VLAN table should be irrelevant to the acceptance

[PATCH v5 33/52] docs: net: statistics.rst: remove a duplicated kernel-doc

2020-10-06 Thread Mauro Carvalho Chehab
include/linux/ethtool.h is included twice with kernel-doc, both to document ethtool_pause_stats(). The first one is at statistics.rst, and the second one at ethtool-netlink.rst. Replace one of the references to use the name of the function. The automarkup.py extension should create the cross-refer

[PATCH v5 25/52] docs: net: ieee802154.rst: fix C expressions

2020-10-06 Thread Mauro Carvalho Chehab
There are some warnings produced with Sphinx 3.x: Documentation/networking/ieee802154.rst:29: WARNING: Error in declarator or parameters Invalid C declaration: Expecting "(" in parameters. [error at 7] int sd = socket(PF_IEEE802154, SOCK_DGRAM, 0); ---^

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Vladimir Oltean
On Tue, Oct 06, 2020 at 04:05:11PM +0200, Kurt Kanzenbach wrote: > > And because my knob is global and not per bridge either, I just set > > ds->vlan_filtering_is_global = true and let DSA handle the rest. > > What's that flag doing? ... > > /* Disallow bridge core from requesting different V

Re: [PATCH v5 25/52] docs: net: ieee802154.rst: fix C expressions

2020-10-06 Thread Stefan Schmidt
On 06.10.20 16:03, Mauro Carvalho Chehab wrote: There are some warnings produced with Sphinx 3.x: Documentation/networking/ieee802154.rst:29: WARNING: Error in declarator or parameters Invalid C declaration: Expecting "(" in parameters. [error at 7] int sd = socket(

Re: [net-next v2 01/11] net: bridge: extend the process of special frames

2020-10-06 Thread Nikolay Aleksandrov
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote: > This patch extends the processing of frames in the bridge. Currently MRP > frames needs special processing and the current implementation doesn't > allow a nice way to process different frame types. Therefore try to > improve this by add

Re: [PATCH v5 25/52] docs: net: ieee802154.rst: fix C expressions

2020-10-06 Thread Stefan Schmidt
Hello. [Sorry for the earlier empty mail] On 06.10.20 16:03, Mauro Carvalho Chehab wrote: There are some warnings produced with Sphinx 3.x: Documentation/networking/ieee802154.rst:29: WARNING: Error in declarator or parameters Invalid C declaration: Expecting "(" in parameters

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-06 Thread Kurt Kanzenbach
On Tue Oct 06 2020, Vladimir Oltean wrote: > On Tue, Oct 06, 2020 at 03:23:36PM +0200, Kurt Kanzenbach wrote: >> So you're saying private VLANs can be used but the user or the other >> kernel modules shouldn't be allowed to use them to simplify the >> implementation? Makes sense to me. > > It woul

Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events)

2020-10-06 Thread John Garry
On 05/10/2020 19:05, John Garry wrote: Can you provide a reproduction? Looking on broadwell this metric doesn't exist. Right, I just added this test metric as my 2x x86 platform has no examples which I can find: diff --git a/tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json b/tools/

Re: [net-next v2 04/11] bridge: cfm: Kernel space implementation of CFM.

2020-10-06 Thread Nikolay Aleksandrov
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote: > This is the first commit of the implementation of the CFM protocol > according to 802.1Q section 12.14. > > Connectivity Fault Management (CFM) comprises capabilities for > detecting, verifying, and isolating connectivity failures in >

Re: [RESEND net-next 1/8] net: dccp: convert tasklets to use new tasklet_setup() API

2020-10-06 Thread Jakub Kicinski
On Tue, 6 Oct 2020 12:01:54 +0530 Allen Pais wrote: > --- a/net/dccp/timer.c > +++ b/net/dccp/timer.c > @@ -219,9 +219,10 @@ static void dccp_delack_timer(struct timer_list *t) > * > * See the comments above %ccid_dequeueing_decision for supported modes. > */ > -static void dccp_write_xmitle

Re: [net-next v2 07/11] bridge: cfm: Netlink Interface.

2020-10-06 Thread Nikolay Aleksandrov
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote: > This is the implementation of CFM netlink configuration > and status information interface. > > Add new nested netlink attributes. These attributes are used by the > user space to create/delete/configure CFM instances and get status. >

Re: [net-next 01/15] net/mlx5: DR, Add buddy allocator utilities

2020-10-06 Thread David Miller
From: Yevgeny Kliteynik Date: Tue, 6 Oct 2020 16:02:24 +0300 > Buddy allocator allocates blocks of different sizes, so when it > scans the bits array, the allocator looks for free *area* of at > least the required size. > Can't store this info in a 'lowest set bit' counter. If you make it per-or

Re: [net-next v2 08/11] bridge: cfm: Netlink Notifications.

2020-10-06 Thread Nikolay Aleksandrov
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote: > This is the implementation of Netlink notifications out of CFM. > > Notifications are initiated whenever a state change happens in CFM. > > IFLA_BRIDGE_CFM: > Points to the CFM information. > > IFLA_BRIDGE_CFM_MEP_STATUS_INFO: >

Re: [net-next v2 09/11] bridge: cfm: Bridge port remove.

2020-10-06 Thread Nikolay Aleksandrov
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote: > This is addition of CFM functionality to delete MEP instances > on a port that is removed from the bridge. > A MEP can only exist on a port that is related to a bridge. > > Reviewed-by: Horatiu Vultur > Signed-off-by: Henrik Bjoernlun

Re: [net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation

2020-10-06 Thread allan.niel...@microchip.com
On 06.10.2020 10:50, Nikolay Aleksandrov wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Mon, 2020-10-05 at 15:07 +0200, Allan W. Nielsen wrote: Hi Jiri On 01.10.2020 14:49, Jiri Pirko wrote: > EXTERNAL EMAIL: Do not click links or open att

Re: [net-next v3 0/9] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-06 Thread Nikolay Aleksandrov
On Tue, 2020-10-06 at 14:53 +, Henrik Bjoernlund wrote: > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > Connectivity Fault Management (CFM) comprises capabilities for detecting, > verifying, > and isolating connectivity failures in Virtual Bridged Networks. > The

[PATCH net-next] net: mscc: ocelot: add missing VCAP ES0 and IS1 regmaps for VSC7514

2020-10-06 Thread Vladimir Oltean
Without these definitions, the driver will crash in: mscc_ocelot_probe -> ocelot_init -> ocelot_vcap_init -> __ocelot_target_read_ix I missed this because I did not have the VSC7514 hardware to test, only the VSC9959 and VSC9953, and the probing part is different. Fixes: e3aea296d86f ("ne

[PATCH ethtool-next v2 0/6] pause frame stats

2020-10-06 Thread Jakub Kicinski
Hi! This set adds support for pause frame statistics. First pause frame info is extended to support --json. Pause stats are first of this kind of statistics so add support for a new flag (--include-statistics). Next add support for dumping policy to check if the statistics flag is supported for

[PATCH ethtool-next v2 4/6] add support for stats in subcommands

2020-10-06 Thread Jakub Kicinski
Add new parameters (-I | --include-statistics) which will control requesting statistic dumps from the kernel. Signed-off-by: Jakub Kicinski --- ethtool.8.in | 7 +++ ethtool.c| 8 internal.h | 1 + 3 files changed, 16 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in ind

[PATCH ethtool-next v2 2/6] pause: add --json support

2020-10-06 Thread Jakub Kicinski
No change in normal text output: # ./ethtool -a eth0 Pause parameters for eth0: Autonegotiate: on RX: on TX: on RX negotiated: on TX negotiated: on JSON: # ./ethtool --json -a eth0 [ { "ifname": "eth0", "autonegotiate": true, "rx": true,

[PATCH ethtool-next v2 3/6] separate FLAGS out in -h

2020-10-06 Thread Jakub Kicinski
Help output is quite crowded already with every command being prefixed by --debug and --json options, and we're about to add a third one. Add an indirection. Signed-off-by: Jakub Kicinski --- ethtool.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ethtool.c b/etht

  1   2   3   >