On Tue, Oct 06, 2020 at 04:05:11PM +0200, Kurt Kanzenbach wrote: > > And because my knob is global and not per bridge either, I just set > > ds->vlan_filtering_is_global = true and let DSA handle the rest. > > What's that flag doing? ... > > /* Disallow bridge core from requesting different VLAN awareness > * settings on ports if not hardware-supported > */ > bool vlan_filtering_is_global; > > OK, that's what I need for the bridging part.
Yes, with the mention that not all checks for 8021q uppers may be in place properly today. But we are in a better position of adding those checks now, since we have a good place to start in dsa_slave_netdevice_event. If you find scenarios that should be rejected when this flag is set, but aren't, let me know and we'll fix that. Nonetheless, if you go this route, then yes, you should set that flag.
