Re: [Intel-wired-lan] [PATCH] e1000: do not panic on malformed rx_desc

2020-10-01 Thread Paul Menzel
Dear Tong, Thank you for your patch. Am 08.09.20 um 18:22 schrieb Tong Zhang: length may be corrupted in rx_desc How can that be? and lead to panic, so check the sanity before passing it to skb_put [ 167.667701] skbuff: skb_over_panic: text:b1e32cc1 len:60224 put:60224 head:

RE: [Intel-wired-lan] [PATCH] e1000: do not panic on malformed rx_desc

2020-10-01 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of Tong > Zhang > Sent: Tuesday, September 8, 2020 9:23 AM > To: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; intel-wired- > l...@lists.osuosl.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: ztong0...@gmail.com > Subject: [Intel-wired-

Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-10-01 Thread Marcel Holtmann
Hi Anmol, > AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called > from hci_event_packet() and there is a possibility, that hcon->amp_mgr may > not be found when accessing after initialization of hcon. > > - net/bluetooth/hci_event.c:4945 > The bug seems to get triggered i

Re: [Intel-wired-lan] [PATCH] e1000: do not panic on malformed rx_desc

2020-10-01 Thread Paul Menzel
Dear Tong, Am 01.10.20 um 09:03 schrieb Paul Menzel: Am 08.09.20 um 18:22 schrieb Tong Zhang: length may be corrupted in rx_desc How can that be? and lead to panic, so check the sanity before passing it to skb_put [  167.667701] skbuff: skb_over_panic: text:b1e32cc1 len:60224 pu

Re: [PATCH v3] Bluetooth: Check for encryption key size on connect

2020-10-01 Thread Marcel Holtmann
Hi Archie, > When receiving connection, we only check whether the link has been > encrypted, but not the encryption key size of the link. > > This patch adds check for encryption key size, and reject L2CAP > connection which size is below the specified thre

RE: [PATCH net] ravb: Fix bit fields checking in ravb_hwtstamp_get()

2020-10-01 Thread Andrew Gabbasov
Hi Sergei, > -Original Message- > From: Gabbasov, Andrew > Sent: Wednesday, September 30, 2020 10:21 PM > To: linux-renesas-...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Sergei Shtylyov ; David > S. Miller ; geert+rene...@glider.be; Julia Lawall > ; Behme, D

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-01 Thread Jiri Pirko
Thu, Oct 01, 2020 at 01:40:12AM CEST, jacob.e.kel...@intel.com wrote: >For some devices, updating the flash can take significant time during >operations where no status can meaningfully be reported. This can be >somewhat confusing to a user who sees devlink appear to hang on the >terminal waiting f

[patch iproute2-next] devlink: Add health reporter test command support

2020-10-01 Thread Jiri Pirko
From: Jiri Pirko Add health reporter test command and allow user to trigger a test event. Signed-off-by: Jiri Pirko --- bash-completion/devlink | 2 +- devlink/devlink.c | 11 +++ man/man8/devlink-health.8 | 16 3 files changed, 28 insertions(+), 1 deletion(

[PATCH net] r8169: fix data corruption issue on RTL8402

2020-10-01 Thread Heiner Kallweit
Petr reported that after resume from suspend RTL8402 partially truncates incoming packets, and re-initializing register RxConfig before the actual chip re-initialization sequence is needed to avoid the issue. Reported-by: Petr Tesarik Proposed-by: Petr Tesarik Tested-by: Petr Tesarik Signed-off

Re: [PATCH bpf-next v2 2/4] selftests: bpf: Add helper to compare socket cookies

2020-10-01 Thread Alexei Starovoitov
On Wed, Sep 30, 2020 at 10:28:33AM +0100, Lorenz Bauer wrote: > On Tue, 29 Sep 2020 at 16:48, Alexei Starovoitov > wrote: > > ... > > > There was a warning. I noticed it while applying and fixed it up. > > Lorenz, please upgrade your compiler. This is not the first time such > > warning has been

[Linux-kernel-mentees][PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-01 Thread Anant Thazhemadam
When get_registers() fails (which happens when usb_control_msg() fails) in set_ethernet_addr(), the uninitialized value of node_id gets copied as the address. Checking for the return values appropriately, and handling the case wherein set_ethernet_addr() fails like this, helps in avoiding the mac

Re: [RFC net-next 2/9] genetlink: reorg struct genl_family

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > There are holes and oversized members in struct genl_family. > > Before: /* size: 104, cachelines: 2, members: 16 */ > After: /* size: 88, cachelines: 2, members: 16 */ > > The command field in struct genlmsghdr is a u8, so no point > i

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-10-01 Thread Jiri Pirko
Wed, Sep 30, 2020 at 04:53:57PM CEST, and...@lunn.ch wrote: >> What do you mean by "regions"? Devlink regions? They are per-device, not >> per-port. I have to be missing something. > >The rest of the patch series, which add regions per port! This came Okay. Sorry about that. netdev ml kicked me ou

Re: [RFC net-next 3/9] genetlink: add small version of ops

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > We want to add maxattr and policy back to genl_ops, to enable > dumping per command policy to user space. This, however, would > cause bloat for all the families with global policies. Introduce > smaller version of ops (half the size of gen

Re: [RFC net-next 4/9] genetlink: move to smaller ops wherever possible

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > Bulk of the genetlink users can use smaller ops, move them. Reviewed-by: Johannes Berg johannes

Re: [PATCH v3 net-next 10/12] bpf: add xdp multi-buffer selftest

2020-10-01 Thread Eelco Chaudron
On 30 Sep 2020, at 17:42, Lorenzo Bianconi wrote: Introduce xdp multi-buffer selftest for the following ebpf helpers: - bpf_xdp_get_frags_total_size - bpf_xdp_get_frag_count Co-developed-by: Eelco Chaudron Signed-off-by: Eelco Chaudron Signed-off-by: Lorenzo Bianconi --- .../testing/self

Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-10-01 Thread Anmol Karn
On Thu, Oct 01, 2020 at 09:06:42AM +0200, Marcel Holtmann wrote: > Hi Anmol, > > > AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called > > from hci_event_packet() and there is a possibility, that hcon->amp_mgr may > > not be found when accessing after initialization of hco

Re: [RFC net-next 5/9] genetlink: add a structure for dump state

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > Whenever netlink dump uses more than 2 cb->args[] entries > code gets hard to read. We're about to add more state to > ctrl_dumppolicy() so create a structure. > > Since the structure is typed and clearly named we can remove > the local fa

Re: [PATCH net] r8169: fix handling ether_clk

2020-10-01 Thread Hans de Goede
Hi, On 10/1/20 8:44 AM, Heiner Kallweit wrote: Petr reported that system freezes on r8169 driver load on a system using ether_clk. The original change was done under the assumption that the clock isn't needed for basic operations like chip register access. But obviously that was wrong. Therefore

Re: [RFC net-next 6/9] genetlink: use .start callback for dumppolicy

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > The structure of ctrl_dumppolicy() is clearly split into > init and dumping. Move the init to a .start callback > for clarity, it's a more idiomatic netlink dump code structure. Yep, makes sense. Reviewed-by: Johannes Berg johannes

Re: [RFC net-next 7/9] genetlink: bring back per op policy

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > Add policy to the struct genl_ops structure, this time > with maxattr, so it can be used properly. > > Propagate .policy and .maxattr from the family > in genl_get_cmd() if needed, this say the rest of the typo: "this way" > code does no

[PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-10-01 Thread Coly Li
This series was original by a bug fix in nvme-over-tcp driver which only checked whether a page was allocated from slab allcoator, but forgot to check its page_count: The page handled by sendpage should be neither a Slab page nor 0 page_count page. As Sagi Grimberg suggested, the original fix is r

[PATCH v9 1/7] net: introduce helper sendpage_ok() in include/linux/net.h

2020-10-01 Thread Coly Li
The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a corrupte

[PATCH v9 2/7] net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send

2020-10-01 Thread Coly Li
If a page sent into kernel_sendpage() is a slab page or it doesn't have ref_count, this page is improper to send by the zero copy sendpage() method. Otherwise such page might be unexpected released in network code path and causes impredictable panic due to kernel memory management data structure co

[PATCH v9 5/7] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

2020-10-01 Thread Coly Li
In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro sendpage_

[PATCH v9 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()

2020-10-01 Thread Coly Li
In iscsci driver, iscsi_tcp_segment_map() uses the following code to check whether the page should or not be handled by sendpage: if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg))) The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to make sure the page can b

[PATCH v9 3/7] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

2020-10-01 Thread Coly Li
Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper sendpage_ok()

[PATCH v9 7/7] libceph: use sendpage_ok() in ceph_tcp_sendpage()

2020-10-01 Thread Coly Li
In libceph, ceph_tcp_sendpage() does the following checks before handle the page by network layer's zero copy sendpage method, if (page_count(page) >= 1 && !PageSlab(page)) This check is exactly what sendpage_ok() does. This patch replace the open coded checks by sendpage_ok() as a code cl

[PATCH v9 4/7] tcp: use sendpage_ok() to detect misused .sendpage

2020-10-01 Thread Coly Li
commit a10674bf2406 ("tcp: detecting the misuse of .sendpage for Slab objects") adds the checks for Slab pages, but the pages don't have page_count are still missing from the check. Network layer's sendpage method is not designed to send page_count 0 pages neither, therefore both PageSlab() and pa

Re: [RFC net-next 8/9] genetlink: use per-op policy for CTRL_CMD_GETPOLICY

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > Wire up per-op policy for CTRL_CMD_GETPOLICY. > This saves us a call to genlmsg_parse() and will soon allow > dumping this policy. > > Create a new policy definition, since we don't want to pollute > ctrl_policy with attributes which CTRL_

Re: [RFC net-next 9/9] genetlink: allow dumping command-specific policy

2020-10-01 Thread Johannes Berg
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > Right now CTRL_CMD_GETPOLICY can only dump the family-wide > policy. Support dumping policy of a specific op. So, hmm. Yeah, I guess this is fine, but you could end up having to do a lot of dumps, and with e.g. ethtool you'd end up with a

Re: [RFC net-next 5/9] genetlink: add a structure for dump state

2020-10-01 Thread Michal Kubecek
On Thu, Oct 01, 2020 at 09:48:31AM +0200, Johannes Berg wrote: > On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote: > > Whenever netlink dump uses more than 2 cb->args[] entries > > code gets hard to read. We're about to add more state to > > ctrl_dumppolicy() so create a structure. > > > >

[PATCH net 10/12] net: link_watch: fix detection of urgent events

2020-10-01 Thread Sabrina Dubroca
linkwatch_urgent_event can miss urgent events when the device and its link have the same ifindex, which can happen when those devices are in different network namespaces. With this setup, the vlan0 device can remain in LOWERLAYERDOWN state for a full second (the linkwatch delay for non-urgent even

[PATCH net 04/12] rtnetlink: always put IFLA_LINK for links with ndo_get_iflink

2020-10-01 Thread Sabrina Dubroca
The test that nla_put_iflink() uses to detect whether a device has a lower link doesn't work with network namespaces, as a device can have the same ifindex as its parent: ip netns add main ip netns add peer ip -net main link add dummy0 type dummy ip -net main link add link dummy0 m

[PATCH net 08/12] ipv6: advertise IFLA_LINK_NETNSID when dumping ipv6 addresses

2020-10-01 Thread Sabrina Dubroca
Currently, we're not advertising link-netnsid when dumping IPv6 addresses, so the "ip -6 addr" command will not correctly interpret the value of the IFLA_LINK attribute. For example, we'll get: 9: macvlan0@macvlan0: mtu 1500 state UP qlen 1000 Instead of: 9: macvlan0@if9: mtu

[PATCH net 12/12] batman-adv: fix detection of lower link in batadv_get_real_netdevice

2020-10-01 Thread Sabrina Dubroca
Currently, batadv_get_real_netdevice can return different results in this situation: ip netns add main ip netns add peer ip -net main link add dummy1 type dummy ip -net main link add link dummy1 netns peer type macsec # same ifindex as dummy1 ip -net main link add link dummy1

[PATCH net 07/12] ipv6: always put IFLA_LINK for devices with ndo_get_iflink

2020-10-01 Thread Sabrina Dubroca
IPv6 tries to detect if devices have a lower link when dumping addresses, but that detection doesn't work when the device and its link have the same ifindex. In this setup: ip netns add main ip netns add peer ip -net main link add dummy0 type dummy # ifidx 9 ip -net main link add l

[PATCH net 06/12] bridge: advertise IFLA_LINK_NETNSID when dumping bridge ports

2020-10-01 Thread Sabrina Dubroca
Currently, we're not advertising link-netnsid for bridge ports, so the "bridge link" command will not correctly interpret the value of the IFLA_LINK attribute. With this setup (ip link output): 9: bridge0: mtu 1500 ... 10: veth0@if10: mtu 1500 qdisc noop master bridge0 ... 11: veth1@

[PATCH net 05/12] bridge: always put IFLA_LINK for ports with ndo_get_iflink

2020-10-01 Thread Sabrina Dubroca
Bridge devices try to detect if devices have a lower link when dumping information about their ports, but that detection doesn't work when the device and its link have the same ifindex: For a bridge with the following ports: 20: veth1@if20: mtu 1500 qdisc noop master bridge0 ... 22: veth

[PATCH net 11/12] batman-adv: fix iflink detection in batadv_is_on_batman_iface

2020-10-01 Thread Sabrina Dubroca
BATMAN compares ifindex with dev_get_iflink to detect devices that don't have a parent, but that's wrong, since a device can have the same index as its parent if it's created in a different network namespace: ip netns add main ip netns add peer ip -net main link add dummy0 type dummy

[PATCH net 02/12] geneve: add get_link_net

2020-10-01 Thread Sabrina Dubroca
Currently, geneve devices don't advertise a link netns. Similarly to VXLAN, we can get it from geneve_dev->net. Fixes: 2d07dc79fe04 ("geneve: add initial netdev driver for GENEVE tunnels") Signed-off-by: Sabrina Dubroca --- drivers/net/geneve.c | 8 1 file changed, 8 insertions(+) diff

[PATCH net 03/12] Revert "rtnetlink: always put IFLA_LINK for links with a link-netnsid"

2020-10-01 Thread Sabrina Dubroca
This reverts commit feadc4b6cf42a53a8a93c918a569a0b7e62bd350. It fixed the particular issue that was seen in the OpenShift setup, but ignored the case of tunnels like VXLAN, which export a IFLA_LINK_NETNSID attribute but don't have an IFLA_LINK. In case a vxlan device is created in one netns, the

[PATCH net 09/12] net: link_watch: fix operstate when the link has the same index as the device

2020-10-01 Thread Sabrina Dubroca
When we create a macvlan device on top of a bond, the macvlan device should always start with IF_OPER_LOWERLAYERDOWN if the bond is down. Currently, this doesn't happen if the macvlan device gets the same ifindex as the bond, which can happen because different namespaces assign the ifindex independ

[PATCH net 01/12] ipvlan: add get_link_net

2020-10-01 Thread Sabrina Dubroca
Currently, ipvlan devices don't advertise a link-netnsid. We can get it from the lower device, like macvlan does. Signed-off-by: Sabrina Dubroca --- drivers/net/ipvlan/ipvlan_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan

[PATCH net 00/12] net: iflink and link-netnsid fixes

2020-10-01 Thread Sabrina Dubroca
In a lot of places, we use this kind of comparison to detect if a device has a lower link: dev->ifindex != dev_get_iflink(dev) This seems to be a leftover of the pre-netns days, when the ifindex was unique over the whole system. Nowadays, with network namespaces, it's very easy to create a devi

Re: [PATCH net 01/12] ipvlan: add get_link_net

2020-10-01 Thread Eric Dumazet
On 10/1/20 9:59 AM, Sabrina Dubroca wrote: > Currently, ipvlan devices don't advertise a link-netnsid. We can get > it from the lower device, like macvlan does. > > Signed-off-by: Sabrina Dubroca > --- > drivers/net/ipvlan/ipvlan_main.c | 9 + > 1 file changed, 9 insertions(+) > > di

RE: Altera TSE driver not working in 100mbps mode

2020-10-01 Thread David Laight
> These are implementation specific. Don't forget you're on FPGA device, which > allows for a lot of flexibility - memory region address and size shifts, 32 vs > 16 bit wide memory, etc. You have to take into account both, TSE's manual as > well as the actual implementation docs. Are you buildin

Re: [PATCH net-next 0/6] l2tp: add ac/pppoe driver

2020-10-01 Thread James Chapman
On 30/09/2020 22:07, Tom Parkin wrote: > L2TPv2 tunnels are often used as a part of a home broadband connection, > using a PPP link to connect the subscriber network into the Internet > Service Provider's network. > > In this scenario, PPPoE is widely used between the L2TP Access > Concentrator (LA

Re: [PATCH v3 net-next 00/12] mvneta: introduce XDP multi-buffer support

2020-10-01 Thread Lorenzo Bianconi
> Lorenzo Bianconi wrote: > > This series introduce XDP multi-buffer support. The mvneta driver is > > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > > please focus on how these new types of xdp_{buff,frame} packets > > traverse the different layers and the layout design.

Re: [PATCH v3 net-next 06/12] bpf: helpers: add multibuffer support

2020-10-01 Thread Jesper Dangaard Brouer
On Wed, 30 Sep 2020 12:11:21 -0700 Alexei Starovoitov wrote: > On Wed, Sep 30, 2020 at 05:41:57PM +0200, Lorenzo Bianconi wrote: > > From: Sameeh Jubran > > > > The implementation is based on this [0] draft by Jesper D. Brouer. First of all I think you are giving me too much credit, and this i

[PATCH net-next v4 resend 1/5] dt-bindings: net: ethernet-controller: Add internal delay properties

2020-10-01 Thread Geert Uytterhoeven
Internal Receive and Transmit Clock Delays are a common setting for RGMII capable devices. While these delays are typically applied by the PHY, some MACs support configuring internal clock delay settings, too. Hence add standardized properties to configure this. This is the MAC counterpart of co

[PATCH net-next v4 resend 2/5] dt-bindings: net: renesas,ravb: Document internal clock delay properties

2020-10-01 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Add properties for configuring the internal MAC delays. These properties are m

[PATCH net-next v4 resend 4/5] ravb: Split delay handling in parsing and applying

2020-10-01 Thread Geert Uytterhoeven
Currently, full delay handling is done in both the probe and resume paths. Split it in two parts, so the resume path doesn't have to redo the parsing part over and over again. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Florian Fainelli --- v4: - Add Reviewed-

[PATCH net-next v4 resend 5/5] ravb: Add support for explicit internal clock delay configuration

2020-10-01 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured these delays based on the "rgmii-

[PATCH net-next v4 resend 3/5] dt-bindings: net: renesas,etheravb: Convert to json-schema

2020-10-01 Thread Geert Uytterhoeven
Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding documentation to json-schema. Add missing properties. Update the example to match reality. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4: - Ad

[PATCH net-next v4 resend 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-10-01 Thread Geert Uytterhoeven
Hi David, Jakub, Some Renesas EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured

Re: [EXT] Re: [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables

2020-10-01 Thread Igor Russkikh
Hi Andrew, > Since this is your own PHY, not some magical black box, i assume you > actually know what value it is using? It probably even lists it in the > data sheet. > > So just hard code that value in the driver. That has got to be better > than saying the incorrect value of 1ms. You mean al

Re: [PATCH net-next 5/5] net: improve napi threaded config

2020-10-01 Thread Felix Fietkau
On 2020-09-30 21:21, Wei Wang wrote: > This commit mainly addresses the threaded config to make the switch > between softirq based and kthread based NAPI processing not require > a device down/up. > It also moves the kthread_create() call to the sysfs handler when user > tries to enable "threaded

WARNING in cfg80211_connect

2020-10-01 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:60e72093 Merge tag 'clk-fixes-for-linus' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12adca4790 kernel config: https://syzkaller.appspot.com/x/.config?x=4e0df28c181f1b6d das

KMSAN: uninit-value in batadv_nc_worker

2020-10-01 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5edb1df2 kmsan: drop the _nosanitize string functions git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=10cc55a790 kernel config: https://syzkaller.appspot.com/x/.co

Re: INFO: rcu detected stall in batadv_nc_worker (3)

2020-10-01 Thread Dmitry Vyukov
On Thu, Oct 1, 2020 at 12:35 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:fffe3ae0 Merge tag 'for-linus-hmm' of git://git.kernel.org.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=17e0334290 > kernel config:

[PATCH net-next 0/8] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

2020-10-01 Thread Grygorii Strashko
Hi This series adds multi-port support in mac-only mode (multi MAC mode) to TI AM65x CPSW driver in preparation for enabling support for multi-port devices, like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC. The multi MAC mode is implemented by configuring every enabled port in "m

[PATCH net-next 2/8] net: ethernet: ti: am65-cpsw: move free desc queue mode selection in pdata

2020-10-01 Thread Grygorii Strashko
In preparation of adding more multi-port K3 CPSW versions move free descriptor queue mode selection in am65_cpsw_pdata, so it can be selected basing on DT compatibility property. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +++- drivers/net/ethernet/ti/am65-

[PATCH net-next 5/8] net: ethernet: ti: am65-cpsw: fix vlan offload for multi mac mode

2020-10-01 Thread Grygorii Strashko
The VLAN offload for AM65x CPSW2G is implemented using existing ALE APIs, which are also used by legacy CPSW drivers. So, now it always adds current Ext. Port and Host as VLAN members when VLAN is added by 8021Q core (.ndo_vlan_rx_add_vid) and forcibly removes VLAN from ALE table in .ndo_vlan_rx_ki

[PATCH net-next 1/8] net: ethernet: ti: am65-cpsw: move ale selection in pdata

2020-10-01 Thread Grygorii Strashko
In preparation of adding more multi-port K3 CPSW versions move ALE selection in am65_cpsw_pdata, so it can be selected basing on DT compatibility property. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +++- drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 + 2 fi

[PATCH net-next 3/8] net: ethernet: ti: am65-cpsw: use cppi5_desc_is_tdcm()

2020-10-01 Thread Grygorii Strashko
Use cppi5_desc_is_tdcm() helper for teardown indicator detection instead of hard-coded value. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/

[PATCH net-next 7/8] net: ethernet: ti: am65-cpsw: prepare xmit/rx path for multi-port devices in mac-only mode

2020-10-01 Thread Grygorii Strashko
This patch adds multi-port support to TI AM65x CPSW driver xmit/rx path in preparation for adding support for multi-port devices, like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC. Hence DMA channels are common/shared for all ext Ports and the RX/TX NAPI and DMA processing going to b

[PATCH net-next 6/8] net: ethernet: ti: am65-cpsw: keep active if cpts enabled

2020-10-01 Thread Grygorii Strashko
Some K3 CPSW NUSS instances can lose context after PM runtime ON->OFF->ON transition depending on integration (including all submodules: CPTS, MDIO, etc), like J721E Main CPSW (CPSW9G). In case CPTS is enabled it's initialized during probe and does not expect to be reset. Hence, keep K3 CPSW activ

[PATCH net-next 8/8] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

2020-10-01 Thread Grygorii Strashko
This patch adds final multi-port support to TI AM65x CPSW driver in preparation for adding support for multi-port devices, like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC. - the separate netdev is created for every enabled external Port; - DMA channels are common/shared for all ext

[PATCH net-next 4/8] net: ethernet: ti: cpsw_ale: add cpsw_ale_vlan_del_modify()

2020-10-01 Thread Grygorii Strashko
Add/export cpsw_ale_vlan_del_modify() and use it in cpsw_switchdev instead of generic cpsw_ale_del_vlan() to avoid mixing 8021Q and switchdev VLAN offload. This is preparation patch equired by follow up changes. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 24 +

Re: [PATCH net 09/12] net: link_watch: fix operstate when the link has the same index as the device

2020-10-01 Thread Taehee Yoo
On Thu, 1 Oct 2020 at 17:09, Sabrina Dubroca wrote: > > When we create a macvlan device on top of a bond, the macvlan device > should always start with IF_OPER_LOWERLAYERDOWN if the bond is > down. Currently, this doesn't happen if the macvlan device gets the > same ifindex as the bond, which can

Re: [PATCH] can: raw: add missing error queue support

2020-10-01 Thread Oliver Hartkopp
On 26.09.20 18:24, Vincent Mailhol wrote: Error queue are not yet implemented in CAN-raw sockets. The problem: a userland call to recvmsg(soc, msg, MSG_ERRQUEUE) on a CAN-raw socket would unqueue messages from the normal queue without any kind of error or warning. As such, it prevented CAN dr

Re: [PATCH bpf-next] libbpf: export bpf_object__reuse_map() to libbpf api

2020-10-01 Thread Hangbin Liu
On Thu, 1 Oct 2020 at 02:30, Andrii Nakryiko wrote: > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > > index 32dc444224d8..5412aa7169db 100644 > > --- a/tools/lib/bpf/libbpf.c > > +++ b/tools/lib/bpf/libbpf.c > > @@ -4215,7 +4215,7 @@ bpf_object__create_maps(struct bpf_object *ob

Re: [PATCH net-next 0/6] l2tp: add ac/pppoe driver

2020-10-01 Thread Guillaume Nault
On Wed, Sep 30, 2020 at 10:07:01PM +0100, Tom Parkin wrote: > L2TPv2 tunnels are often used as a part of a home broadband connection, > using a PPP link to connect the subscriber network into the Internet > Service Provider's network. > > In this scenario, PPPoE is widely used between the L2TP Acc

Re: dsa: mv88e6xxx: serdes link without phy

2020-10-01 Thread Andrew Lunn
> > Can you run 1000Base-X over these links? > With some reading "1000base-x" does seem the right thing to say here. > It's even what is reflected in the CMODE field for those ports. One more thing you might need is managed = "in-band-status"; > > If you can, it is probably > > worth chatting t

Re: [PATCH net-next 00/15] sctp: Implement RFC6951: UDP Encapsulation of SCTP

2020-10-01 Thread Marcelo Ricardo Leitner
On Tue, Sep 29, 2020 at 09:48:52PM +0800, Xin Long wrote: ... > Patches: Please give me till tomorrow for revising this patchset. Thanks, Marcelo

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2020-10-01 Thread boris . ostrovsky
>>> Also, wrt KASLR stuff, that issue is still seen sometimes but I haven't >>> had >>> bandwidth to dive deep into the issue and fix it. So what's the plan there? You first mentioned this issue early this year and judged by your response it is not clear whether you will e

Re: [PATCH v2 0/2] vhost: Skip access checks on GIOVAs

2020-10-01 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 06:30:20PM +0200, Greg Kurz wrote: > This series addresses some misuse around vring addresses provided by > userspace when using an IOTLB device. The misuse cause failures of > the VHOST_SET_VRING_ADDR ioctl on POWER, which in turn causes QEMU > to crash at migration time. >

Re: [net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation

2020-10-01 Thread Jiri Pirko
Thu, Oct 01, 2020 at 12:30:18PM CEST, henrik.bjoernl...@microchip.com wrote: >This is the definition of the CFM switchdev interface. > >The interface consist of these objects: >SWITCHDEV_OBJ_ID_MEP_CFM, >SWITCHDEV_OBJ_ID_MEP_CONFIG_CFM, >SWITCHDEV_OBJ_ID_CC_CONFIG_CFM, >SWITCHDEV_OB

Re: [EXT] Re: [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables

2020-10-01 Thread Andrew Lunn
On Thu, Oct 01, 2020 at 01:18:06PM +0300, Igor Russkikh wrote: > Hi Andrew, > > > Since this is your own PHY, not some magical black box, i assume you > > actually know what value it is using? It probably even lists it in the > > data sheet. > > > > So just hard code that value in the driver. Tha

Re: [PATCH net-next v2 4/4] dpaa2-eth: add support for devlink parser error drop traps

2020-10-01 Thread Ioana Ciornei
On Wed, Sep 30, 2020 at 10:44:07PM +0300, Ido Schimmel wrote: > On Wed, Sep 30, 2020 at 10:16:45PM +0300, Ioana Ciornei wrote: > > +static int dpaa2_eth_dl_trap_action_set(struct devlink *devlink, > > + const struct devlink_trap *trap, > > +

[PATCH v3 devicetree 0/2] Add Seville Ethernet switch to T1040RDB

2020-10-01 Thread Vladimir Oltean
Seville is a DSA switch that is embedded inside the T1040 SoC, and supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. This series adds this switch to the SoC's dtsi files and to the T1040RDB board file. Vladimir Oltean (2): powerpc: dts: t1040: add bindings for Seville Ethe

[PATCH v3 devicetree 1/2] powerpc: dts: t1040: add bindings for Seville Ethernet switch

2020-10-01 Thread Vladimir Oltean
Add the description of the embedded L2 switch inside the SoC dtsi file for NXP T1040. Signed-off-by: Vladimir Oltean Reviewed-by: Maxim Kochetkov --- Changes in v3: Added definition for frame extraction interrupt, even if the driver doesn't use it at the moment. Changes in v2: Make switch node

[PATCH v3 devicetree 2/2] powerpc: dts: t1040rdb: add ports for Seville Ethernet switch

2020-10-01 Thread Vladimir Oltean
Define the network interface names for the switch ports and hook them up to the 2 QSGMII PHYs that are onboard. A conscious decision was taken to go along with the numbers that are written on the front panel of the board and not with the hardware numbers of the switch chip ports. The 2 numbering s

Re: [PATCH net-next v2 2/4] devlink: add .trap_group_action_set() callback

2020-10-01 Thread Ioana Ciornei
On Wed, Sep 30, 2020 at 10:53:31PM +0300, Ido Schimmel wrote: > On Wed, Sep 30, 2020 at 10:16:43PM +0300, Ioana Ciornei wrote: > > Add a new devlink callback, .trap_group_action_set(), which can be used > > by device drivers which do not support controlling the action (drop, > > trap) on each trap

Re: [RFC PATCH 09/24] vdpa: multiple address spaces support

2020-10-01 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:10AM +0800, Jason Wang wrote: > This patches introduces the multiple address spaces support for vDPA > device. This idea is to identify a specific address space via an > dedicated identifier - ASID. > > During vDPA device allocation, vDPA device driver needs to report

Re: [PATCH v3 devicetree 2/2] powerpc: dts: t1040rdb: add ports for Seville Ethernet switch

2020-10-01 Thread Andrew Lunn
On Thu, Oct 01, 2020 at 04:20:13PM +0300, Vladimir Oltean wrote: > Define the network interface names for the switch ports and hook them up > to the 2 QSGMII PHYs that are onboard. > > A conscious decision was taken to go along with the numbers that are > written on the front panel of the board an

Re: [PATCH v3 devicetree 1/2] powerpc: dts: t1040: add bindings for Seville Ethernet switch

2020-10-01 Thread Andrew Lunn
On Thu, Oct 01, 2020 at 04:20:12PM +0300, Vladimir Oltean wrote: > Add the description of the embedded L2 switch inside the SoC dtsi file > for NXP T1040. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Maxim Kochetkov Reviewed-by: Andrew Lunn Andrew

Re: [RFC PATCH 09/24] vdpa: multiple address spaces support

2020-10-01 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:10AM +0800, Jason Wang wrote: > This patches introduces the multiple address spaces support for vDPA > device. This idea is to identify a specific address space via an > dedicated identifier - ASID. > > During vDPA device allocation, vDPA device driver needs to report

Re: [PATCH 1/2] net: qrtr: Allow forwarded services

2020-10-01 Thread Manivannan Sadhasivam
On Tue, Sep 29, 2020 at 03:33:16PM +0200, Loic Poulain wrote: > A remote endpoint (immediate neighbor node) can forward services > from other non-immediate nodes, in that case ctrl packet node ID > (offering distant service) can differ from the qrtr source node > (forwarding the packet). > > Signe

Re: [net-next PATCH v1 1/7] Documentation: ACPI: DSD: Document MDIO PHY

2020-10-01 Thread Calvin Johnson
Hi Rafael, On Wed, Sep 30, 2020 at 06:37:09PM +0200, Rafael J. Wysocki wrote: > On Wed, Sep 30, 2020 at 6:05 PM Calvin Johnson > wrote: > > > > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > > provide them to be connected to MAC. > > > > Describe properties "phy-handle" and "

Re: [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group

2020-10-01 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:11AM +0800, Jason Wang wrote: > This patch introduces a new bus operation to allow the vDPA bus driver > to associate an ASID to a virtqueue group. > So in case of virtio_net, I would expect that all the data virtqueues will be associated with the same address space i

Re: [PATCH v2] rtw88: pci: Power cycle device during shutdown

2020-10-01 Thread Kalle Valo
Kai-Heng Feng wrote: > There are reports that 8822CE fails to work rtw88 with "failed to read DBI > register" error. Also I have a system with 8723DE which freezes the whole > system when the rtw88 is probing the device. > > According to [1], platform firmware may not properly power manage the >

Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-01 Thread Frederic Weisbecker
On Wed, Jul 22, 2020 at 02:49:49PM +, Alex Belits wrote: > +/* > + * Description of the last two tasks that ran isolated on a given CPU. > + * This is intended only for messages about isolation breaking. We > + * don't want any references to actual task while accessing this from > + * CPU that

[PATCH net-next 16/16] devlink: Add Documentation/networking/devlink/devlink-reload.rst

2020-10-01 Thread Moshe Shemesh
Add devlink reload rst documentation file. Update index file to include it. Signed-off-by: Moshe Shemesh --- RFCv5 -> v1: - Rename reload_action_limit_level to reload_limit RFCv4 -> RFCv5: - Rephrase namespace chnage section - Rephrase note on actions performed RFCv3 -> RFCv4: - Remove reload act

[PATCH net-next 12/16] devlink: Add enable_remote_dev_reset generic parameter

2020-10-01 Thread Moshe Shemesh
The enable_remote_dev_reset devlink param flags that the host admin allows device resets that can be initiated by other hosts. This parameter is useful for setups where a device is shared by different hosts, such as multi-host setup. Once the user set this parameter to false, the driver should NACK

[PATCH net-next 13/16] net/mlx5: Add devlink param enable_remote_dev_reset support

2020-10-01 Thread Moshe Shemesh
The enable_remote_dev_reset devlink param flags that the host admin allows resets by other hosts. In case it is cleared mlx5 host PF driver will send NACK on pci sync for firmware update reset request and the command will fail. By default enable_remote_dev_reset parameter is true, so pci sync for f

[PATCH net-next 02/16] devlink: Add reload action option to devlink reload command

2020-10-01 Thread Moshe Shemesh
Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward compatible). Note that when required to do firmware activation some drivers may need to reload the driver. On the

[PATCH net-next 04/16] devlink: Add reload stats

2020-10-01 Thread Moshe Shemesh
Add reload stats to hold the history per reload action type and limit. For example, the number of times fw_activate has been performed on this device since the driver module was added or if the firmware activation was performed with or without reset. Add devlink notification on stats update. Exp

[PATCH net-next 14/16] net/mlx5: Add support for fw live patch event

2020-10-01 Thread Moshe Shemesh
Firmware live patch event notifies the driver that the firmware was just updated using live patch. In such case the driver should not reload or re-initiate entities, part to updating the firmware version and re-initiate the firmware tracer which can be updated by live patch with new strings databas

  1   2   3   4   >