Re: [RFC PATCH net] ethtool: Fix incompatibility between netlink and ioctl interfaces

2020-09-30 Thread Ido Schimmel
On Tue, Sep 29, 2020 at 06:44:55PM +0200, Michal Kubecek wrote: > On Tue, Sep 29, 2020 at 07:02:47PM +0300, Ido Schimmel wrote: > > From: Ido Schimmel > > > > With the ioctl interface, when autoneg is enabled, but without > > specifying speed, duplex or link modes, the advertised link modes are >

Re: Fw: [Bug 209427] New: Incorrect timestamp cause packet to be dropped

2020-09-30 Thread Eric Dumazet
On 9/29/20 7:35 PM, Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Tue, 29 Sep 2020 17:15:23 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 209427] New: Incorrect timestamp cause packet to be dropped > > > https://bugzil

[RESEND PATCH iproute2-next 2/2] tc: implement support for terse dump

2020-09-30 Thread Vlad Buslov
From: Vlad Buslov Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when user requested it with following example CLI: > tc -s filter show terse dev ens1f0 ingress In terse mode dump only outputs ess

[RESEND PATCH iproute2-next 1/2] tc: skip actions that don't have options attribute when printing

2020-09-30 Thread Vlad Buslov
From: Vlad Buslov Modify implementations that return error from action_until->print_aopt() callback to silently skip actions that don't have their corresponding TCA_ACT_OPTIONS attribute set (some actions already behave like this). This is necessary to support terse dump mode in following patch i

[RESEND PATCH iproute2-next 0/2] Implement filter terse dump mode support

2020-09-30 Thread Vlad Buslov
Implement support for terse dump mode which provides only essential classifier/action info (handle, stats, cookie, etc.). Use new TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from kernel. Vlad Buslov (2): tc: skip actions that don't have options attribute when printing tc:

Re: [PATCH bpf-next v3 3/6] bpf: add redirect_neigh helper as redirect drop-in

2020-09-30 Thread Daniel Borkmann
On 9/30/20 8:48 AM, Martin KaFai Lau wrote: On Tue, Sep 29, 2020 at 11:23:03PM +0200, Daniel Borkmann wrote: [...] +/* Internal, non-exposed redirect flags. */ +enum { + BPF_F_NEIGH = (1ULL << 1), +}; It will be useful to ensure the future "flags" of BPF_FUNC_redirect will not overlap

Re: [patch V2 16/36] net: sfc: Use GFP_KERNEL in efx_ef10_try_update_nic_stats()

2020-09-30 Thread Martin Habets
On Tue, Sep 29, 2020 at 10:25:25PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > efx_ef10_try_update_nic_stats_vf() is now only invoked from thread context > and can sleep after efx::stats_lock is dropped. > > Change the allocation mode from GFP_ATOMIC to GFP_KERNEL. > Sign

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Kalle Valo
Leon Romanovsky writes: >> diff --git a/drivers/net/wireless/purelifi/Kconfig > b/drivers/net/wireless/purelifi/Kconfig >> new file mode 100644 >> index ..ff05eaf0a8d4 >> --- /dev/null >> +++ b/drivers/net/wireless/purelifi/Kconfig >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: GP

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Greg Kroah-Hartman
On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > CCing other lists and maintainers, hopefully, somebody would have a time to > look at it... > > On Saturday 08 August 2020 15:27:47 Pali Rohár wrote: > > On Wednesday 15 April 2020 00:56:18 Pali Rohár wrote: > > > On Sunday 09 February

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Kalle Valo
Leon Romanovsky writes: >> --- /dev/null >> +++ b/drivers/net/wireless/purelifi/Kconfig >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +config WLAN_VENDOR_PURELIFI >> +bool "pureLiFi devices" >> +default y > > "N" is preferred default. > >> +help >> + If you have a

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Marcel Holtmann
Hi Greg, I wrote a simple script "sco_features.pl" which show all supported codecs by local HCI bluetooth adapter. Script is available at: https://github.com/pali/hsphfpd-prototype/blob/prototype/sco_features.pl And I found out that OCF_READ_

[QUESTION] Enable the wireless module on Pinebook Pro

2020-09-30 Thread Jian-Hong Pan
Hi, According to the preloaded system Manjaro ARM on Pinebook Pro [1], I found the firmware files in ap6256-firmware package [2] enable the wireless module, including WiFi and Bluetooth. If we want to redistribute the firmware files to linux-firmware repository or other distros, which kind of lice

RE: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-30 Thread David Laight
From: Jakub Kicinski > Sent: 29 September 2020 22:49 ... > Isn't the fundamental problem that scheduler works at ms scale while > where we're talking about 100us at most? And AFAICT scheduler doesn't > have a knob to adjust migration cost per process? :( Have you tried setting the application proc

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > > CCing other lists and maintainers, hopefully, somebody would have a time to > > look at it... > > > > On Saturday 08 August 2020 15:27:47 Pali Rohár wrote: > > > On

Re: [PATCH net-next 2/3] net: atlantic: implement phy downshift feature

2020-09-30 Thread Igor Russkikh
> > Hi Igor > > I think all other implementations return -EINVAL or -E2BIG or similar > when the value is not supported. > > Also, given that a u8 is being passed, is cfg->downshift_counter > 255 > possible? I'm not even sure 255 makes any sense. Autoneg takes around > 1.5s, maybe longer. Do

Re: [PATCH v3 net-next 15/15] net: dsa: tag_rtl4_a: use the generic flow dissector procedure

2020-09-30 Thread Linus Walleij
On Sat, Sep 26, 2020 at 9:33 PM Vladimir Oltean wrote: > Remove the .flow_dissect procedure, so the flow dissector will call the > generic variant which works for this tagging protocol. > > Cc: Linus Walleij > Cc: DENG Qingfang > Cc: Mauri Sandberg > Signed-off-by: Vladimir Oltean > --- > Cha

Re: [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables

2020-09-30 Thread Igor Russkikh
>> switch (tuna->id) { >> +case ETHTOOL_PHY_EDPD: { >> +const u16 *val = data; >> + >> +/* msecs plays no role - configuration is always fixed in > PHY */ >> +aq_nic->aq_nic_cfg.is_media_detect = *val ? 1 : 0; > > This is the wrong usage of the API: >

Re: pull-request: bpf 2020-09-29

2020-09-30 Thread David Miller
From: Alexei Starovoitov Date: Tue, 29 Sep 2020 22:00:27 -0700 > The following pull-request contains BPF updates for your *net* tree. > > We've added 7 non-merge commits during the last 14 day(s) which contain > a total of 7 files changed, 28 insertions(+), 8 deletions(-). > > The main changes

Re: Request for backport of 78dc70ebaa38aa303274e333be6c98eef87619e2 to 4.19.y

2020-09-30 Thread Robert Bengtsson-Ölund
Thanks. /Robert On Tue, 29 Sep 2020 at 19:25, Priyaranjan Jha wrote: > > The BBR ACK aggregation patches have been packported to 4.19 kernel, > and are part of v4.19.148 stable release: > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=v4.19.148 > > Thanks, > Priyara

Re: [QUESTION] Enable the wireless module on Pinebook Pro

2020-09-30 Thread Jian-Hong Pan
I forgot to mail to Dan Johansen as well. Jian-Hong Pan 於 2020年9月30日 週三 下午4:15寫道: > > Hi, > > According to the preloaded system Manjaro ARM on Pinebook Pro [1], I > found the firmware files in ap6256-firmware package [2] enable the > wireless module, including WiFi and Bluetooth. > If we want to

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-30 Thread Paolo Abeni
On Tue, 2020-09-29 at 14:48 -0700, Jakub Kicinski wrote: > On Tue, 29 Sep 2020 13:16:59 -0700 Wei Wang wrote: > > On Tue, Sep 29, 2020 at 12:19 PM Jakub Kicinski wrote: > > > On Mon, 28 Sep 2020 19:43:36 +0200 Eric Dumazet wrote: > > > > Wei, this is a very nice work. > > > > > > > > Please re-

Re: [RFC PATCH net] ethtool: Fix incompatibility between netlink and ioctl interfaces

2020-09-30 Thread Michal Kubecek
On Wed, Sep 30, 2020 at 10:25:29AM +0300, Ido Schimmel wrote: > On Tue, Sep 29, 2020 at 06:44:55PM +0200, Michal Kubecek wrote: > > On Tue, Sep 29, 2020 at 07:02:47PM +0300, Ido Schimmel wrote: > > > diff --git a/net/ethtool/linkmodes.c b/net/ethtool/linkmodes.c > > > index 7044a2853886..a9458c7620

Re: RTL8402 stops working after hibernate/resume

2020-09-30 Thread Hans de Goede
Hi, On 9/29/20 10:35 PM, Heiner Kallweit wrote: On 29.09.2020 22:08, Hans de Goede wrote: Also some remarks about this while I'm being a bit grumpy about all this anyways (sorry): 1. 9f0b54cd167219 ("r8169: move switching optional clock on/off to pll power functions") commit's message does

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > > On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > > > CCing other lists and maintainers, hopefully, somebody would have a time > > > to look at it... > >

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2020 at 10:16:40AM +0200, Marcel Holtmann wrote: > Hi Greg, > > I wrote a simple script "sco_features.pl" which show all supported > codecs by local HCI bluetooth adapter. Script is available at: > > https://github.com/pali/hsphfpd-prototype/blo

Re: [PATCH bpf-next v2 2/4] selftests: bpf: Add helper to compare socket cookies

2020-09-30 Thread Lorenz Bauer
On Tue, 29 Sep 2020 at 16:48, Alexei Starovoitov wrote: ... > There was a warning. I noticed it while applying and fixed it up. > Lorenz, please upgrade your compiler. This is not the first time such > warning has been missed. I tried reproducing this on latest bpf-next (b0efc216f577997) with g

Re: [PATCH bpf-next v2 4/4] selftest: bpf: Test copying a sockmap and sockhash

2020-09-30 Thread Lorenz Bauer
On Tue, 29 Sep 2020 at 18:23, Martin KaFai Lau wrote: ... > > Yeah, I think so. We'd need to do something similar to your > > sock_common work for PTR_TO_RDONLY_BUF_OR_NULL. The fact that the > > pointer is read only makes it a bit more difficult I think. After > I thought the key arg should be

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > > > On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > > > > CCing other lists and maint

[RFC] net: phy: add shutdown hook to struct phy_driver

2020-09-30 Thread Jisheng Zhang
Hi, A GE phy supports pad isolation which can save power in WOL mode. But once the isolation is enabled, the MAC can't send/receive pkts to/from the phy because the phy is "isolated". To make the PHY work normally, I need to move the enabling isolation to suspend hook, so far so good. But the isol

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 11:20:20 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 10:16:40AM +0200, Marcel Holtmann wrote: > > Hi Greg, > > > > I wrote a simple script "sco_features.pl" which show all supported > > codecs by local HCI bluetooth adapter. Script is availa

Re: [PATCH 1/1 nf] selftests: netfilter: add time counter check

2020-09-30 Thread Pablo Neira Ayuso
On Thu, Sep 24, 2020 at 12:17:33PM +0200, Fabian Frederick wrote: > Check packets are correctly placed in current year. > Also do a NULL check for another one. Applied.

Re: [bpf-next PATCH 1/2] bpf, sockmap: add skb_adjust_room to pop bytes off ingress payload

2020-09-30 Thread Jakub Sitnicki
On Sat, Sep 26, 2020 at 06:27 AM CEST, John Fastabend wrote: > This implements a new helper skb_adjust_room() so users can push/pop > extra bytes from a BPF_SK_SKB_STREAM_VERDICT program. > > Some protocols may include headers and other information that we may > not want to include when doing a red

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> diff --git a/drivers/net/wireless/purelifi/Kconfig > > b/drivers/net/wireless/purelifi/Kconfig > >> new file mode 100644 > >> index ..ff05eaf0a8d4 > >> --- /dev/null > >> +++ b/drivers/net/wire

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:05:49AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> --- /dev/null > >> +++ b/drivers/net/wireless/purelifi/Kconfig > >> @@ -0,0 +1,38 @@ > >> +# SPDX-License-Identifier: GPL-2.0 > >> +config WLAN_VENDOR_PURELIFI > >> + bool "pureLiFi devices" > >> + defau

Re: [PATCH net-next v2] virtio-net: ethtool configurable RXCSUM

2020-09-30 Thread Willem de Bruijn
On Wed, Sep 30, 2020 at 4:05 AM wrote: > > From: Tonghao Zhang > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > If Rx checksum is

Re: [PATCH net-next v2] virtio-net: ethtool configurable RXCSUM

2020-09-30 Thread Michael S. Tsirkin
On Wed, Sep 30, 2020 at 10:03:00AM +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST

dsa/mv88e6xxx: leaking packets on MV88E6341 switch

2020-09-30 Thread Peter Vollmer
Hi all, I am currently investigating a leaking packets problem on a armada-37xx + MV88E6341 switch (via SGMII) + MV88E1512 Phy (via RGMII) platform. We are using the mainline 5.4.y kernel. The switch and phy setup is defined in the flat device tree as follows: ð0 { phy-mode = "rgmii-id"

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Johannes Berg
On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > > Leon Romanovsky writes: > > > > > > diff --git a/drivers/net/wireless/purelifi/Kconfig > > > b/drivers/net/wireless/purelifi/Kconfig > > > > new file mode 100644 > > > > ind

Re: [RFC PATCH] lsm,selinux: pass the family information along with xfrm flow

2020-09-30 Thread Herbert Xu
On Wed, Sep 30, 2020 at 09:09:20AM +1000, James Morris wrote: > > I'm not keen on adding a parameter which nobody is using. Perhaps a note > in the header instead? Please at least change to the struct flowi to flowi_common if we're not adding a family field. Thanks, -- Email: Herbert Xu Home P

Re: [PATCH 0/3] Add LSM/SELinux support for GPRS Tunneling Protocol (GTP)

2020-09-30 Thread Pablo Neira Ayuso
On Wed, Sep 30, 2020 at 10:49:31AM +0100, Richard Haines wrote: > These patches came about after looking at 5G open source in particular > the updated 5G GTP driver at [1]. As this driver is still under > development, added the LSM/SELinux hooks to the current stable GTP > version in kernel selinux

Re: dsa/mv88e6xxx: leaking packets on MV88E6341 switch

2020-09-30 Thread Vladimir Oltean
On Wed, Sep 30, 2020 at 12:09:03PM +0200, Peter Vollmer wrote: > lan0..lan3 are members of the br0 bridge interface. and so is eth0, I assume? > The problem is that for ICMP ping lan0-> eth0, ICMP ping request > packets are leaking (i.e. flooded) to all other ports lan1..lan3, > while the ping r

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 12:11:24PM +0200, Johannes Berg wrote: > On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: > > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > > > Leon Romanovsky writes: > > > > > > > > diff --git a/drivers/net/wireless/purelifi/Kconfig > > > > b/driv

[PATCH net-next 0/6] mlxsw: PFC and headroom selftests

2020-09-30 Thread Petr Machata
Recent changes in the headroom management code made it clear that an automated way of testing this functionality is needed. This patchset brings two tests: a synthetic headroom behavior test, which verifies mechanics of headroom management. And a PFC test, which verifies whether this behavior actua

[PATCH net-next 5/6] selftests: mlxsw: Add headroom handling test

2020-09-30 Thread Petr Machata
Add a test for headroom configuration. This covers projection of ETS configuration to ingress, PFC, adjustments for MTU, the qdisc / TC mode and the effect of egress SPAN session on buffer configuration. Signed-off-by: Petr Machata --- .../drivers/net/mlxsw/qos_headroom.sh | 379

[PATCH net-next 2/6] selftests: forwarding: devlink_lib: Add devlink_cell_size_get()

2020-09-30 Thread Petr Machata
Add a helper that answers the cell size of the devlink device. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/devlink_lib.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/net/forwarding/devlink_lib.sh b/tools/testing/selftests/net/forw

[PATCH net-next 3/6] selftests: forwarding: devlink_lib: Support port-less topologies

2020-09-30 Thread Petr Machata
Some selftests may not need any actual ports. Technically those are not forwarding selftests, but devlink_lib can still be handy. Fall back on NETIF_NO_CABLE in those cases. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/devlink_lib.sh | 2 +- 1 file changed, 1 insertion(

[PATCH net-next 4/6] selftests: mlxsw: qos_lib: Add a wrapper for running mlnx_qos

2020-09-30 Thread Petr Machata
mlnx_qos is a script for configuration of DCB. Despite the name it is not actually Mellanox-specific in any way. It is currently the only ad-hoc tool available (in contrast to a daemon that manages an interface on an ongoing basis). However, it is very verbose and parsing out error messages is not

[PATCH net-next 1/6] selftests: forwarding: devlink_lib: Split devlink_..._set() into save & set

2020-09-30 Thread Petr Machata
Changing pool type from static to dynamic causes reinterpretation of threshold values. They therefore need to be saved before pool type is changed, then the pool type can be changed, and then the new values need to be set up. For that reason, set cannot subsume save, because it would be saving the

[PATCH net-next 6/6] selftests: mlxsw: Add a PFC test

2020-09-30 Thread Petr Machata
Add a test for PFC. Runs 10MB of traffic through a bottleneck and checks that none of it gets lost. Signed-off-by: Petr Machata --- .../selftests/drivers/net/mlxsw/qos_pfc.sh| 403 ++ 1 file changed, 403 insertions(+) create mode 100755 tools/testing/selftests/drivers/net/ml

[PATCH net-next] net: macb: move pdata to private header

2020-09-30 Thread Alexandre Belloni
struct macb_platform_data is only used by macb_pci to register the platform device, move its definition to cadence/macb.h and remove platform_data/macb.h Signed-off-by: Alexandre Belloni --- drivers/net/ethernet/cadence/macb.h | 11 +++ drivers/net/ethernet/cadence/macb_main.c | 1

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > > On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > > > On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > > > > On Tue, Sep 29, 2020 at 11:

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > > > > On Wednesday 30 September 2

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-09-30 Thread Harald Welte
Hi Richard, I don't fully understand in which context you need / use those SELinux GTP hooks, however one comment from the point of view of somebody who is working on GGSN/P-GW software using the GTP kernel module: On Wed, Sep 30, 2020 at 10:49:34AM +0100, Richard Haines wrote: > +selinux_gtp_d

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-30 Thread Amit Pundir
On Wed, 30 Sep 2020 at 00:38, Rob Herring wrote: > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > There are firmware versions which do not support host capability > > QMI request. We suspect either the host cap is not implemented or > > there may be firmware specific issues, bu

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2020 at 01:00:13PM +0200, Pali Rohár wrote: > On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > > On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > > > On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > > > > On Wed, Sep 30, 2020 at 10:

Re: [RFC PATCH 05/24] vhost-vdpa: passing iotlb to IOMMU mapping helpers

2020-09-30 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:06AM +0800, Jason Wang wrote: > To prepare for the ASID support for vhost-vdpa, try to pass IOTLB > object to dma helpers. Maybe it's worth mentioning here that this patch does not change any functionality and is presented as a preparation for passing different iotlb'

Re: [RESEND PATCH iproute2-next 0/2] Implement filter terse dump mode support

2020-09-30 Thread Ivan Vecera
On Wed, 30 Sep 2020 10:36:49 +0300 Vlad Buslov wrote: > Implement support for terse dump mode which provides only essential > classifier/action info (handle, stats, cookie, etc.). Use new > TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from > kernel. > > Vlad Buslov (2): > t

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 13:20:06 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 01:00:13PM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > > > > On Wednesday 30 September 2

Re: dsa/mv88e6xxx: leaking packets on MV88E6341 switch

2020-09-30 Thread Peter Vollmer
On Wed, Sep 30, 2020 at 01:28:35PM +0300, Vladimir Oltean wrote: > On Wed, Sep 30, 2020 at 12:09:03PM +0200, Peter Vollmer wrote: > > lan0..lan3 are members of the br0 bridge interface. > > and so is eth0, I assume? No, eth0 is a dedicated interface with its own IP. We have routing between eth0 a

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2020 at 01:51:32PM +0200, Pali Rohár wrote: > On Wednesday 30 September 2020 13:20:06 Greg Kroah-Hartman wrote: > > On Wed, Sep 30, 2020 at 01:00:13PM +0200, Pali Rohár wrote: > > > On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > > > > On Wed, Sep 30, 2020 at 11:

Re: [RFC PATCH 06/24] vhost-vdpa: switch to use vhost-vdpa specific IOTLB

2020-09-30 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:07AM +0800, Jason Wang wrote: > To ease the implementation of per group ASID support for vDPA > device. This patch switches to use a vhost-vdpa specific IOTLB to > avoid the unnecessary refactoring of the vhost core. > > Signed-off-by: Jason Wang > --- > drivers/vho

Re: [PATCH 0/3] Add LSM/SELinux support for GPRS Tunneling Protocol (GTP)

2020-09-30 Thread Richard Haines
On Wed, 2020-09-30 at 12:17 +0200, Pablo Neira Ayuso wrote: > On Wed, Sep 30, 2020 at 10:49:31AM +0100, Richard Haines wrote: > > These patches came about after looking at 5G open source in > > particular > > the updated 5G GTP driver at [1]. As this driver is still under > > development, added the

Re: [PATCH net-next v4 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-09-30 Thread Geert Uytterhoeven
Hi David, Jakub, On Thu, Sep 17, 2020 at 3:57 PM Geert Uytterhoeven wrote: > Some Renesas EtherAVB variants support internal clock delay > configuration, which can add larger delays than the delays that are > typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or > "[rt]xc-skew-ps"

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-09-30 Thread Richard Haines
On Wed, 2020-09-30 at 13:01 +0200, Harald Welte wrote: > Hi Richard, > > I don't fully understand in which context you need / use those > SELinux GTP hooks, As in the reply to Pablo, I did it for no particular reason other than idle curiosity, and given the attempted move to Open 5G I thought add

Re: [PATCH 0/3] Add LSM/SELinux support for GPRS Tunneling Protocol (GTP)

2020-09-30 Thread Pablo Neira Ayuso
On Wed, Sep 30, 2020 at 01:20:41PM +0100, Richard Haines wrote: > On Wed, 2020-09-30 at 12:17 +0200, Pablo Neira Ayuso wrote: > > On Wed, Sep 30, 2020 at 10:49:31AM +0100, Richard Haines wrote: > > > These patches came about after looking at 5G open source in > > > particular > > > the updated 5G G

INFO: rcu detected stall in security_file_open (3)

2020-09-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fb0155a0 Merge tag 'nfs-for-5.9-3' of git://git.linux-nfs... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10b007cf90 kernel config: https://syzkaller.appspot.com/x/.config?x=41b736b7ce1b3ea4 das

[PATCH net-next 0/2] tcp: exponential backoff in tcp_send_ack()

2020-09-30 Thread Eric Dumazet
From: Eric Dumazet We had outages caused by repeated skb allocation failures in tcp_send_ack() It is time to add exponential backoff to reduce number of attempts. Before doing so, first patch removes icsk_ack.blocked to make room for a new field (icsk_ack.retry) Eric Dumazet (2): inet: remove

[PATCH net-next 1/2] inet: remove icsk_ack.blocked

2020-09-30 Thread Eric Dumazet
From: Eric Dumazet TCP has been using it to work around the possibility of tcp_delack_timer() finding the socket owned by user. After commit 6f458dfb4092 ("tcp: improve latencies of timer triggered events") we added TCP_DELACK_TIMER_DEFERRED atomic bit for more immediate recovery, so we can get

[PATCH net-next 2/2] tcp: add exponential backoff in __tcp_send_ack()

2020-09-30 Thread Eric Dumazet
From: Eric Dumazet Whenever host is under very high memory pressure, __tcp_send_ack() skb allocation fails, and we setup a 200 ms (TCP_DELACK_MAX) timer before retrying. On hosts with high number of TCP sockets, we can spend considerable amount of cpu cycles in these attempts, add high pressure

[PATCH v4 33/52] docs: net: statistics.rst: remove a duplicated kernel-doc

2020-09-30 Thread Mauro Carvalho Chehab
include/linux/ethtool.h is included twice with kernel-doc, both to document ethtool_pause_stats(). The first one is at statistics.rst, and the second one at ethtool-netlink.rst. Replace one of the references to use the name of the function. The automarkup.py extension should create the cross-refer

[PATCH v4 25/52] docs: net: ieee802154.rst: fix C expressions

2020-09-30 Thread Mauro Carvalho Chehab
There are some warnings produced with Sphinx 3.x: Documentation/networking/ieee802154.rst:29: WARNING: Error in declarator or parameters Invalid C declaration: Expecting "(" in parameters. [error at 7] int sd = socket(PF_IEEE802154, SOCK_DGRAM, 0); ---^

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-09-30 Thread Harald Welte
Hi Richard, On Wed, Sep 30, 2020 at 01:25:27PM +0100, Richard Haines wrote: > As in the reply to Pablo, I did it for no particular reason other than > idle curiosity, and given the attempted move to Open 5G I thought > adding MAC support might be useful somewhere along the line. thanks, I only s

Re: [RFC PATCH] lsm,selinux: pass the family information along with xfrm flow

2020-09-30 Thread Paul Moore
On Tue, Sep 29, 2020 at 7:09 PM James Morris wrote: > I'm not keen on adding a parameter which nobody is using. Perhaps a note > in the header instead? On Wed, Sep 30, 2020 at 6:14 AM Herbert Xu wrote: > Please at least change to the struct flowi to flowi_common if we're > not adding a family fi

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-30 Thread Andrew Lunn
> I get it. But I as I wrote previously, I wonder if used/unused should > not be another attribute. Then the flavour can be "undefined". In the DSA world, it is not undefined. It is clear defined as unused. And it cannot be on-the-fly changed. It is a property of the PCB, in that the pins exist on

[PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-09-30 Thread Anmol Karn
AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called from hci_event_packet() and there is a possibility, that hcon->amp_mgr may not be found when accessing after initialization of hcon. - net/bluetooth/hci_event.c:4945 The bug seems to get triggered in this line: bredr_hco

Re: [RFC PATCH net] ethtool: Fix incompatibility between netlink and ioctl interfaces

2020-09-30 Thread Andrew Lunn
> > I don't think so. Doing: > > > > # ethtool -s eth0 autoneg > > > > Is a pretty established behavior to enable all the supported advertise > > bits. I would disagree. phylib will return -EINVAL for this. int phy_ethtool_ksettings_set(struct phy_device *phydev, c

Re: [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables

2020-09-30 Thread Andrew Lunn
> The problem here is that FW interface only allows us to switch this mode on or > off. We can't control the interval value for this device. > Thus, we only can enable it, or disable. Basically ignoring the interval > value. Hi Igor Since this is your own PHY, not some magical black box, i assum

[PATCH] net/smscx5xx: change to of_get_mac_address() eth_platform_get_mac_address()

2020-09-30 Thread Łukasz Stelmach
Use more generic eth_platform_get_mac_address() which can get a MAC address from other than DT platform specific sources too. Check if the obtained address is valid. Signed-off-by: Łukasz Stelmach --- drivers/net/usb/smsc75xx.c | 13 +++-- drivers/net/usb/smsc95xx.c | 13 +++-- 2

Re: [RFC PATCH net] ethtool: Fix incompatibility between netlink and ioctl interfaces

2020-09-30 Thread Ido Schimmel
On Wed, Sep 30, 2020 at 04:19:09PM +0200, Andrew Lunn wrote: > > > I don't think so. Doing: > > > > > > # ethtool -s eth0 autoneg > > > > > > Is a pretty established behavior to enable all the supported advertise > > > bits. > > I would disagree. phylib will return -EINVAL for this. This has no

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-30 Thread Jiri Pirko
Wed, Sep 30, 2020 at 03:57:25PM CEST, and...@lunn.ch wrote: >> I get it. But I as I wrote previously, I wonder if used/unused should >> not be another attribute. Then the flavour can be "undefined". > >In the DSA world, it is not undefined. It is clear defined as >unused. And it cannot be on-the-fl

Re: [RFC PATCH net] ethtool: Fix incompatibility between netlink and ioctl interfaces

2020-09-30 Thread Ido Schimmel
On Wed, Sep 30, 2020 at 05:35:31PM +0300, Ido Schimmel wrote: > https://github.com/torvalds/linux/blob/master/net/ethtool/linkmodes.c#L2 Should be: https://github.com/torvalds/linux/blob/master/net/ethtool/linkmodes.c#L290

[PATCH v2 0/6] can: add support for ETAS ES58X CAN USB

2020-09-30 Thread Vincent Mailhol
The purpose of this patch series is to introduce a new CAN USB driver to support ETAS USB interfaces (ES58X series). During development, issues in drivers/net/can/dev.c where discovered, the fix for those issues are included in this patch series. We also propose to add two helper functions in inc

[PATCH v2 1/6] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-09-30 Thread Vincent Mailhol
If a driver calls can_get_echo_skb() during a hardware IRQ (which is often, but not always, the case), the 'WARN_ON(in_irq)' in net/core/skbuff.c#skb_release_head_state() might be triggered, under network congestion circumstances, together with the potential risk of a NULL pointer dereference. The

Re: [PATCH v2 bpf-next 1/2] bpf: introduce BPF_F_PRESERVE_ELEMS for perf event array

2020-09-30 Thread Daniel Borkmann
On 9/29/20 11:56 PM, Song Liu wrote: [...] +static void bpf_fd_array_map_clear(struct bpf_map *map); + +static void perf_event_fd_array_map_free(struct bpf_map *map) +{ + if (map->map_flags & BPF_F_PRESERVE_ELEMS) + bpf_fd_array_map_clear(map); + fd_array_map_free(map

[PATCH v2 2/6] can: dev: add a helper function to get the correct length of Classical frames

2020-09-30 Thread Vincent Mailhol
In classical CAN, the length of the data (i.e. CAN payload) is not always equal to the DLC! If the frame is a Remote Transmission Request (RTR), data length is always zero regardless of DLC value and else, if the DLC is greater than 8, the length is 8. Contrary to common belief, ISO 11898-1 Chapter

[PATCH v2 3/6] can: dev: __can_get_echo_skb(): fix the return length

2020-09-30 Thread Vincent Mailhol
The length of Remote Transmission Request (RTR) frames is always 0 bytes. The DLC represents the requested length, not the actual length of the RTR. But __can_get_echo_skb() returns the DLC value regardless. Apply get_can_len() function to retrieve the correct length. Signed-off-by: Vincent Mailh

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-30 Thread Andrew Lunn
> What do you mean by "regions"? Devlink regions? They are per-device, not > per-port. I have to be missing something. The rest of the patch series, which add regions per port! This came out of the discussion from the first version of this patchset, and Jakub said it would make sense to add per po

[PATCH v2 4/6] can: dev: add a helper function to calculate the duration of one bit

2020-09-30 Thread Vincent Mailhol
Rename macro CAN_CALC_SYNC_SEG to CAN_SYNC_SEG and make it available through include/linux/can/dev.h Add an helper function can_bit_time() which returns the duration (in time quanta) of one CAN bit. Rationale for this patch: the sync segment and the bit time are two concepts which are defined in

[PATCH v2 6/6] usb: cdc-acm: add quirk to blacklist ETAS ES58X devices

2020-09-30 Thread Vincent Mailhol
The ES58X devices has a CDC ACM interface (used for debug purpose). During probing, the device is thus recognized as USB Modem (CDC ACM), preventing the etas-es58x module to load: usbcore: registered new interface driver etas_es58x usb 1-1.1: new full-speed USB device number 14 using xhci_hcd

ethtool/phy tunables and extack (was Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver)

2020-09-30 Thread Michal Kubecek
On Tue, Sep 29, 2020 at 07:04:13PM +0200, Andrew Lunn wrote: > On Tue, Sep 29, 2020 at 07:13:04PM +0300, Igor Russkikh wrote: > > This series implements phy tunables settings via MAC driver callbacks. > > > > AQC 10G devices use integrated MAC+PHY solution, where PHY is fully > > controlled > > b

Re: [PATCH v2 bpf-next 1/2] bpf: introduce BPF_F_PRESERVE_ELEMS for perf event array

2020-09-30 Thread Song Liu
> On Sep 30, 2020, at 7:49 AM, Daniel Borkmann wrote: > > On 9/29/20 11:56 PM, Song Liu wrote: > [...] >> +static void bpf_fd_array_map_clear(struct bpf_map *map); >> + >> +static void perf_event_fd_array_map_free(struct bpf_map *map) >> +{ >> +if (map->map_flags & BPF_F_PRESERVE_ELEMS) >

Re: ethtool/phy tunables and extack (was Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver)

2020-09-30 Thread Andrew Lunn
> Another question is how to allow ethtool ops setting not only the text > message but also the offending attribute. For PHY tunables, i don't think it is needed. The current API only allows a single value to be passed. That seems to be enough, and it forces us to keep tunables simple. If need be,

[PATCH bpf-next v4 0/6] Various BPF helper improvements

2020-09-30 Thread Daniel Borkmann
This series adds two BPF helpers, that is, one for retrieving the classid of an skb and another one to redirect via the neigh subsystem, and improves also the cookie helpers by removing the atomic counter. I've also added the bpf_tail_call_static() helper to the libbpf API that we've been using in

[PATCH bpf-next v4 1/6] bpf: add classid helper only based on skb->sk

2020-09-30 Thread Daniel Borkmann
Similarly to 5a52ae4e32a6 ("bpf: Allow to retrieve cgroup v1 classid from v2 hooks"), add a helper to retrieve cgroup v1 classid solely based on the skb->sk, so it can be used as key as part of BPF map lookups out of tc from host ns, in particular given the skb->sk is retained these days when cross

[PATCH bpf-next v4 5/6] bpf, selftests: use bpf_tail_call_static where appropriate

2020-09-30 Thread Daniel Borkmann
For those locations where we use an immediate tail call map index use the newly added bpf_tail_call_static() helper. Signed-off-by: Daniel Borkmann --- samples/bpf/sockex3_kern.c| 20 +++-- tools/testing/selftests/bpf/progs/bpf_flow.c | 12 tools/testing/sel

[PATCH bpf-next v4 6/6] bpf, selftests: add redirect_neigh selftest

2020-09-30 Thread Daniel Borkmann
Add a small test that exercises the new redirect_neigh() helper for the IPv4 and IPv6 case. Signed-off-by: Daniel Borkmann --- .../selftests/bpf/progs/test_tc_neigh.c | 144 +++ tools/testing/selftests/bpf/test_tc_neigh.sh | 168 ++ 2 files changed, 312 inserti

[PATCH bpf-next v4 3/6] bpf: add redirect_neigh helper as redirect drop-in

2020-09-30 Thread Daniel Borkmann
Add a redirect_neigh() helper as redirect() drop-in replacement for the xmit side. Main idea for the helper is to be very similar in semantics to the latter just that the skb gets injected into the neighboring subsystem in order to let the stack do the work it knows best anyway to populate the L2 a

[PATCH bpf-next v4 2/6] bpf, net: rework cookie generator as per-cpu one

2020-09-30 Thread Daniel Borkmann
With its use in BPF, the cookie generator can be called very frequently in particular when used out of cgroup v2 hooks (e.g. connect / sendmsg) and attached to the root cgroup, for example, when used in v1/v2 mixed environments. In particular, when there's a high churn on sockets in the system ther

[PATCH bpf-next v4 4/6] bpf, libbpf: add bpf_tail_call_static helper for bpf programs

2020-09-30 Thread Daniel Borkmann
Port of tail_call_static() helper function from Cilium's BPF code base [0] to libbpf, so others can easily consume it as well. We've been using this in production code for some time now. The main idea is that we guarantee that the kernel's BPF infrastructure and JIT (here: x86_64) can patch the JIT

[PATCH v3 bpf-next 2/2] selftests/bpf: add tests for BPF_F_PRESERVE_ELEMS

2020-09-30 Thread Song Liu
Add tests for perf event array with and without BPF_F_PRESERVE_ELEMS. Add a perf event to array via fd mfd. Without BPF_F_PRESERVE_ELEMS, the perf event is removed when mfd is closed. With BPF_F_PRESERVE_ELEMS, the perf event is removed when the map is freed. Signed-off-by: Song Liu --- .../bpf

  1   2   3   4   >