Re: [PATCH bpf] bpf: Use hlist_add_head_rcu when linking to sk_storage

2020-09-17 Thread Alexei Starovoitov
On Wed, Sep 16, 2020 at 01:09:25PM -0700, Martin KaFai Lau wrote: > The sk_storage->list will be traversed by rcu reader in parallel. > Thus, hlist_add_head_rcu() is needed in __selem_link_sk(). This > patch fixes it. > > This part of the code has recently been refactored in bpf-next. > A separat

[PATCH net-next] net: remove comments on struct rtnl_link_stats

2020-09-17 Thread Jakub Kicinski
We removed the misleading comments from struct rtnl_link_stats64 when we added proper kdoc. struct rtnl_link_stats has the same inline comments, so remove them, too. Signed-off-by: Jakub Kicinski --- include/uapi/linux/if_link.h | 31 +++ 1 file changed, 15 insertions

[PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread Jakub Kicinski
struct ethtool_fecparam carries bitmasks not bit numbers. We want to return 1 (NONE), not 0. Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH net-next v3 7/7] net: ipa: do not enable GSI interrupt for wakeup

2020-09-17 Thread Alex Elder
We now trigger a system resume when we receive an IPA SUSPEND interrupt. We should *not* wake up on GSI interrupts. Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson --- v3: Added Bjorn's reviewed-by tag. drivers/net/ipa/gsi.c | 17 - drivers/net/ipa/gsi.h | 1 - 2 files

[PATCH net-next v3 6/7] net: ipa: enable wakeup on IPA interrupt

2020-09-17 Thread Alex Elder
Now that we handle wakeup interrupts properly, arrange for the IPA interrupt to be treated as a wakeup interrupt. Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson --- v3: Added Bjorn's reviewed-by tag. drivers/net/ipa/ipa_interrupt.c | 14 ++ 1 file changed, 14 insertions(+)

[PATCH net-next v3 5/7] net: ipa: repurpose CLOCK_HELD flag

2020-09-17 Thread Alex Elder
The previous patch causes a system resume to be triggered when a packet is available for receipt on a suspended RX endpoint. The CLOCK_HELD flag was previously used to indicate that an extra clock reference was held, preventing suspend. But we no longer need such a flag: - We take an initial re

[PATCH net-next v3 4/7] net: ipa: use device_init_wakeup()

2020-09-17 Thread Alex Elder
The call to wakeup_source_register() in ipa_probe() does not do what it was intended to do. Call device_init_wakeup() in ipa_setup() instead, to set the IPA device as wakeup-capable and to initially enable wakeup capability. When we receive a SUSPEND interrupt, call pm_wakeup_dev_event() with a z

[PATCH net-next v3 3/7] net: ipa: manage endpoints separate from clock

2020-09-17 Thread Alex Elder
Currently, when (before) the last IPA clock reference is dropped, all endpoints are suspended. And whenever the first IPA clock reference is taken, all endpoints are resumed (or started). In most cases there's no need to start endpoints when the clock starts. So move the calls to ipa_endpoint_su

[PATCH net-next v3 0/7] net: ipa: wake up system on RX available

2020-09-17 Thread Alex Elder
This series arranges for the IPA driver to wake up a suspended system if the IPA hardware has a packet to deliver to the AP. Version 2 replaced the first patch from version 1 with three patches, in response to David Miller's feedback. And based on Bjorn Andersson's feedback on version 2, this ver

[PATCH net-next v3 1/7] net: ipa: use refcount_t for IPA clock reference count

2020-09-17 Thread Alex Elder
Take advantage of the checking provided by refcount_t, rather than using a plain atomic to represent the IPA clock reference count. Note that we need to *set* the value to 1 in ipa_clock_get() rather than incrementing it from 0 (because doing that is considered an error for a refcount_t). Signed-

[PATCH net-next v3 2/7] net: ipa: replace ipa->suspend_ref with a flag bit

2020-09-17 Thread Alex Elder
We take a clock reference in ipa_config() in order to prevent the the IPA clock from being shutdown until a power management suspend request arrives. An atomic field in the IPA structure records whether that extra reference had been taken. Rather than using an atomic to represent a Boolean value,

Re: [PATCH bpf-next v5 5/8] bpf: Fix context type resolving for extension programs

2020-09-17 Thread Andrii Nakryiko
On Thu, Sep 17, 2020 at 10:10 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Wed, Sep 16, 2020 at 12:59 PM Andrii Nakryiko > > wrote: > >> > >> On Tue, Sep 15, 2020 at 5:50 PM Toke Høiland-Jørgensen > >> wrote: > >> > > >> > From: Toke Høiland-Jørgensen > >> > > >> > Ee

Re: [PATCH rdma-next 0/3] Extend mlx5_ib software steering interface

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 03:10:26PM -0300, Jason Gunthorpe wrote: > On Thu, Sep 03, 2020 at 10:38:54AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > This series from Alex extends software steering interface to support > > devices with extra capability "sw_owner_2" which will repla

Re: [PATCH bpf] bpf: Use hlist_add_head_rcu when linking to sk_storage

2020-09-17 Thread Martin KaFai Lau
On Thu, Sep 17, 2020 at 10:47:39AM -0700, Alexei Starovoitov wrote: > On Wed, Sep 16, 2020 at 01:09:25PM -0700, Martin KaFai Lau wrote: > > The sk_storage->list will be traversed by rcu reader in parallel. > > Thus, hlist_add_head_rcu() is needed in __selem_link_sk(). This > > patch fixes it. > >

Re: [PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread Jesse Brandeburg
Jakub Kicinski wrote: > struct ethtool_fecparam carries bitmasks not bit numbers. > We want to return 1 (NONE), not 0. > > Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") > Signed-off-by: Jakub Kicinski Good catch! Reviewed-by: Jesse Brandeburg

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-17 Thread Jesse Brandeburg
Nitesh Narayan Lal wrote: > Introduce a new API num_housekeeping_cpus(), that can be used to retrieve > the number of housekeeping CPUs by reading an atomic variable > __num_housekeeping_cpus. This variable is set from housekeeping_setup(). > > This API is introduced for the purpose of drivers th

Re: [PATCH rdma-next 0/3] Extend mlx5_ib software steering interface

2020-09-17 Thread Jason Gunthorpe
On Thu, Sep 03, 2020 at 10:38:54AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > This series from Alex extends software steering interface to support > devices with extra capability "sw_owner_2" which will replace existing > "sw_owner". > > Thanks > > Alex Vesker (3): > RDMA/mlx5:

Re: [PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread Simon Horman
On Thu, Sep 17, 2020 at 10:52:57AM -0700, Jakub Kicinski wrote: > struct ethtool_fecparam carries bitmasks not bit numbers. > We want to return 1 (NONE), not 0. > > Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") > Signed-off-by: Jakub Kicinski > --- > drivers/net/ethernet/netro

Re: [PATCH net-next] net: remove comments on struct rtnl_link_stats

2020-09-17 Thread Saeed Mahameed
On Thu, 2020-09-17 at 10:51 -0700, Jakub Kicinski wrote: > We removed the misleading comments from struct rtnl_link_stats64 > when we added proper kdoc. struct rtnl_link_stats has the same > inline comments, so remove them, too. > > Signed-off-by: Jakub Kicinski Thanks Jakub! Reviewed-by: Saeed

Re: [PATCH net 1/2] net: phy: Avoid NPD upon phy_detach() when driver is unbound

2020-09-17 Thread Andrew Lunn
On Wed, Sep 16, 2020 at 08:43:09PM -0700, Florian Fainelli wrote: > If we have unbound the PHY driver prior to calling phy_detach() (often > via phy_disconnect()) then we can cause a NULL pointer de-reference > accessing the driver owner member. The steps to reproduce are: > > echo unimac-mdio-0:0

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-17 Thread Nitesh Narayan Lal
On 9/17/20 2:23 PM, Jesse Brandeburg wrote: > Nitesh Narayan Lal wrote: > >> In a realtime environment, it is essential to isolate unwanted IRQs from >> isolated CPUs to prevent latency overheads. Creating MSIX vectors only >> based on the online CPUs could lead to a potential issue on an RT setup

Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()

2020-09-17 Thread Cong Wang
On Wed, Sep 16, 2020 at 9:33 AM YueHaibing wrote: > > It is never used, so can remove it. This is a bit confusing, it was actually used before, see commit ab0d76f6823cc3a4e2.

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-17 Thread Jesse Brandeburg
Nitesh Narayan Lal wrote: > In a realtime environment, it is essential to isolate unwanted IRQs from > isolated CPUs to prevent latency overheads. Creating MSIX vectors only > based on the online CPUs could lead to a potential issue on an RT setup > that has several isolated CPUs but a very few ho

[PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes

2020-09-17 Thread Parav Pandit
Prepare code to fill zero or more port function optional attributes. Subsequent patch makes use of this to fill more port function attributes. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- net/core/devlink.c | 53 +- 1 file changed, 29 inser

Re: [PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-17 Thread Dan Murphy
Andrew On 9/16/20 5:13 PM, Andrew Lunn wrote: On Wed, Sep 16, 2020 at 03:54:34PM -0500, Dan Murphy wrote: Andrew On 9/15/20 3:17 PM, Andrew Lunn wrote: + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT, +phydev->supported); + l

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-17 Thread Jason Gunthorpe
On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > infrastructure for communication between multiple accelerators. Same > as Nvidia uses NVlink, we use RDMA that we have inside our ASIC. > The RDMA implementation we did does NOT support some basic RDMA > IBverbs (such as MR and PD) and

Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-17 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Thu, Sep 17, 2020 at 3:06 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> >> >> >> +int bpf_check_attach_target(struct bpf_verifier_log *log, >> >> + const struct bpf_prog *prog, >> >> + con

[PATCH net-next] ionic: add DIMLIB to Kconfig

2020-09-17 Thread Shannon Nelson
>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a -- >> ld.lld: error: undefined symbol: net_dim >>

Re: [PATCH bpf-next v5 5/8] bpf: Fix context type resolving for extension programs

2020-09-17 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Thu, Sep 17, 2020 at 10:10 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > On Wed, Sep 16, 2020 at 12:59 PM Andrii Nakryiko >> > wrote: >> >> >> >> On Tue, Sep 15, 2020 at 5:50 PM Toke Høiland-Jørgensen >> >> wrote: >> >> > >> >> > From:

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-17 Thread Nitesh Narayan Lal
On 9/17/20 2:18 PM, Jesse Brandeburg wrote: > Nitesh Narayan Lal wrote: > >> Introduce a new API num_housekeeping_cpus(), that can be used to retrieve >> the number of housekeeping CPUs by reading an atomic variable >> __num_housekeeping_cpus. This variable is set from housekeeping_setup(). >> >>

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread Shay Agroskin
David Miller writes: From: Shay Agroskin Date: Sun, 13 Sep 2020 11:16:34 +0300 ENA logs are adjusted to display the full ENA representation to distinct each ENA device in case of multiple interfaces. Using dev_err/warn/info function family for logging provides uniform printing with clear

[PATCH v3,net-next,3/4] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-09-17 Thread Srujana Challa
Add support for the cryptographic acceleration unit (CPT) on OcteonTX2 CN96XX SoC. Signed-off-by: Suheil Chandran Signed-off-by: Lukas Bartosik Signed-off-by: Srujana Challa --- drivers/crypto/marvell/Kconfig| 13 + drivers/crypto/marvell/Makefile |1 + driv

Re: [PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration

2020-09-17 Thread Dan Murphy
Geert On 9/17/20 8:57 AM, Geert Uytterhoeven wrote: Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the Ether

Re: [PATCH net-next v2] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-17 Thread Florian Fainelli
On 9/17/2020 6:11 AM, Andrew Lunn wrote: On Wed, Sep 16, 2020 at 07:04:13PM -0700, Florian Fainelli wrote: The internal Gigabit PHY on Broadcom STB chips has a digital clock which drives its MDIO interface among other things, the driver now requests and manage that clock during .probe() and .

Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

2020-09-17 Thread Dan Murphy
Andrew On 9/15/20 6:29 PM, Dan Murphy wrote: Andrew On 9/15/20 3:21 PM, Andrew Lunn wrote: On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote: Add entries for the 100base-FX full and half duplex supported modes. $ ethtool eth0 Supported ports: [ TP    MII FIBRE ]    

Re: [PATCH net-next] ionic: add DIMLIB to Kconfig

2020-09-17 Thread Jakub Kicinski
On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: > >> ld.lld: error: undefined symbol: net_dim_get_rx_moderation >>>> referenced by ionic_lif.c:52 > (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) >>>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive > dr

[PATCH -next] vdpa: mlx5: select VHOST to fix build errors

2020-09-17 Thread Randy Dunlap
nlap Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: virtualizat...@lists.linux-foundation.org Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: netdev@vger.kernel.org --- Note: This patch may not be the right thing, but it fixes the build errors. drivers/vdpa/Kconfig |1 + 1 file change

Re: [PATCH net-next] ionic: add DIMLIB to Kconfig

2020-09-17 Thread Shannon Nelson
On 9/17/20 12:02 PM, Jakub Kicinski wrote: On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: ld.lld: error: undefined symbol: net_dim_get_rx_moderation >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) >>> net/ethernet/pensando/ionic/ionic_lif

[PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-09-17 Thread Krzysztof Kozlowski
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags, assuming the aut

Re: [PATCH] [PATCH] net/sched : cbs : fix calculation error of idleslope credits

2020-09-17 Thread Cong Wang
On Wed, Sep 16, 2020 at 11:05 PM Xiaoyong Yan wrote: > > in the function cbs_dequeue_soft, when q->credits <0, [now - q->last] > should be accounted for sendslope,not idleslope. > > so the solution as follows: when q->credits is less than 0, directly > calculate delay time, activate hrtimer and wh

Re: BPF redirect API design issue for BPF-prog MTU feedback?

2020-09-17 Thread Saeed Mahameed
On Thu, 2020-09-17 at 05:54 -0700, Maciej Żenczykowski wrote: > On Thu, Sep 17, 2020 at 5:39 AM Jesper Dangaard Brouer > wrote: > > > > As you likely know[1] I'm looking into moving the MTU check (for > > TC-BPF) > > in __bpf_skb_max_len() when e.g. called by bpf_skb_adjust_room(), > > because wh

Re: [PATCH] net: make netdev_wait_allrefs wake-able

2020-09-17 Thread Francesco Ruggeri
On Wed, Sep 16, 2020 at 11:51 PM Eric Dumazet wrote: > > Honestly I would not touch dev_put() at all. > > Simply change the msleep(250) to something better, with maybe > exponential backoff. OK, I will try that. Francesco

[PATCH v3,net-next,4/4] drivers: crypto: add the Virtual Function driver for OcteonTX2 CPT

2020-09-17 Thread Srujana Challa
Add support for the cryptographic accelerator unit virtual functions on OcteonTX2 96XX SoC. Signed-off-by: Suheil Chandran Signed-off-by: Lukas Bartosik Signed-off-by: Srujana Challa --- drivers/crypto/marvell/Kconfig|4 + drivers/crypto/marvell/octeontx2/Makefile |

Re: [PATCH v4 net-next 1/5] devlink: add timeout information to status_notify

2020-09-17 Thread Jakub Kicinski
On Wed, 16 Sep 2020 20:02:00 -0700 Shannon Nelson wrote: > Add a timeout element to the DEVLINK_CMD_FLASH_UPDATE_STATUS > netlink message for use by a userland utility to show that > a particular firmware flash activity may take a long but > bounded time to finish. Also add a handy helper for driv

Re: [PATCH v4 net-next 2/5] devlink: collect flash notify params into a struct

2020-09-17 Thread Jakub Kicinski
On Wed, 16 Sep 2020 20:02:01 -0700 Shannon Nelson wrote: > The dev flash status notify function parameter lists are getting > rather long, so add a struct to be filled and passed rather than > continuously changing the function signatures. > > Signed-off-by: Shannon Nelson > --- > include/net/de

Re: [PATCH v4 net-next 3/5] netdevsim: devlink flash timeout message

2020-09-17 Thread Jakub Kicinski
On Wed, 16 Sep 2020 20:02:02 -0700 Shannon Nelson wrote: > Add a simple devlink flash timeout message to exercise > the message mechanism. > > Signed-off-by: Shannon Nelson > --- > drivers/net/netdevsim/dev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/netdevsim/dev.c

Re: [PATCH] net: phy: realtek: Replace 2.5Gbps name from RTL8125 to RTL8226

2020-09-17 Thread Andrew Lunn
On Thu, Sep 17, 2020 at 09:39:08AM +0800, Willy Liu wrote: > According to PHY ID, 0x001cc800 should be named "RTL8226 2.5Gbps PHY" > and 0x001cc840 should be named "RTL8226B_RTL8221B 2.5Gbps PHY". > RTL8125 is not a single PHY solution, it integrates PHY/MAC/PCIE bus > controller and embedded memor

[PATCH v2 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-17 Thread Randy Dunlap
Randy Dunlap Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: virtualizat...@lists.linux-foundation.org Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: netdev@vger.kernel.org --- v2: change from select to depends (Saeed) drivers/vdpa/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 de

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-09-17 Thread Cong Wang
On Sun, Sep 13, 2020 at 7:10 PM Yunsheng Lin wrote: > > On 2020/9/11 4:19, Cong Wang wrote: > > On Thu, Sep 3, 2020 at 8:21 PM Kehuan Feng wrote: > >> I also tried Cong's patch (shown below on my tree) and it could avoid > >> the issue (stressing for 30 minutus for three times and not jitter > >>

Re: [PATCH v4 net-next 5/5] ionic: add devlink firmware update

2020-09-17 Thread Jakub Kicinski
On Wed, 16 Sep 2020 20:02:04 -0700 Shannon Nelson wrote: > Add support for firmware update through the devlink interface. > This update copies the firmware object into the device, asks > the current firmware to install it, then asks the firmware to > select the new firmware for the next boot-up. >

Re: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread David Ahern
On 9/17/20 11:20 AM, Parav Pandit wrote: > diff --git a/include/net/devlink.h b/include/net/devlink.h > index 48b1c1ef1ebd..1edb558125b0 100644 > --- a/include/net/devlink.h > +++ b/include/net/devlink.h > @@ -83,6 +83,20 @@ struct devlink_port_pci_vf_attrs { > u8 external:1; > }; > > +/**

Re: [PATCH net-next] ionic: add DIMLIB to Kconfig

2020-09-17 Thread Jakub Kicinski
On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote: > On 9/17/20 12:02 PM, Jakub Kicinski wrote: > > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: > ld.lld: error: undefined symbol: net_dim_get_rx_moderation > >> >>> referenced by ionic_lif.c:52 > >> (drivers/net/ether

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread Saeed Mahameed
On Thu, 2020-09-17 at 21:45 +0300, Shay Agroskin wrote: > David Miller writes: > > > From: Shay Agroskin > > Date: Sun, 13 Sep 2020 11:16:34 +0300 > > > > > ENA logs are adjusted to display the full ENA representation to > > > distinct each ENA device in case of multiple interfaces. > > > Using

Re: [PATCH v4 net-next 1/5] devlink: add timeout information to status_notify

2020-09-17 Thread Jacob Keller
On 9/16/2020 8:02 PM, Shannon Nelson wrote: > Add a timeout element to the DEVLINK_CMD_FLASH_UPDATE_STATUS > netlink message for use by a userland utility to show that > a particular firmware flash activity may take a long but > bounded time to finish. Also add a handy helper for drivers > to m

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Jacob Keller
On 9/9/2020 1:55 PM, Keith Busch wrote: > On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: >> diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c >> index eea0f453cfb6..8aac5bc60f4c 100644 >> --- a/crypto/tcrypt.c >> +++ b/crypto/tcrypt.c >> @@ -2464,7 +2464,7 @@ static int do_test(const

Re: [PATCH net-next] ionic: add DIMLIB to Kconfig

2020-09-17 Thread David Miller
From: Jakub Kicinski Date: Thu, 17 Sep 2020 13:02:31 -0700 > On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote: >> On 9/17/20 12:02 PM, Jakub Kicinski wrote: >> > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: >> ld.lld: error: undefined symbol: net_dim_get_rx_moderation

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-17 Thread Bjorn Helgaas
[+cc Ingo, Peter, Juri, Vincent (scheduler maintainers)] s/hosekeeping/housekeeping/ (in subject) On Wed, Sep 09, 2020 at 11:08:16AM -0400, Nitesh Narayan Lal wrote: > Introduce a new API num_housekeeping_cpus(), that can be used to retrieve > the number of housekeeping CPUs by reading an atomic

Re: [PATCH -next] vdpa: mlx5: select VHOST to fix build errors

2020-09-17 Thread Saeed Mahameed
Mahameed > Cc: Leon Romanovsky > Cc: netdev@vger.kernel.org > --- > Note: This patch may not be the right thing, but it fixes the build > errors. > > drivers/vdpa/Kconfig |1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200917.orig/drivers/vdpa/

Re: [PATCH v4 net-next 5/5] ionic: add devlink firmware update

2020-09-17 Thread Jacob Keller
On 9/16/2020 8:02 PM, Shannon Nelson wrote: > Add support for firmware update through the devlink interface. > This update copies the firmware object into the device, asks > the current firmware to install it, then asks the firmware to > select the new firmware for the next boot-up. > > The ins

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread David Miller
From: Saeed Mahameed Date: Thu, 17 Sep 2020 12:38:28 -0700 > allocated but unregistered netdevices also do not help much as the name > of the netdev is not assigned yet. > > why don't use dev_info(pci_dev) macors for low level functions when > netdev is not available or not allocated yet. The

Re: [PATCH v4 net-next 2/5] devlink: collect flash notify params into a struct

2020-09-17 Thread Jacob Keller
On 9/16/2020 8:02 PM, Shannon Nelson wrote: > The dev flash status notify function parameter lists are getting > rather long, so add a struct to be filled and passed rather than > continuously changing the function signatures. > > Signed-off-by: Shannon Nelson Guess I should have read farther

Re: [PATCH] ptp: mark symbols static where possible

2020-09-17 Thread Jacob Keller
On 9/17/2020 12:16 AM, Leon Romanovsky wrote: > On Thu, Sep 17, 2020 at 10:25:08AM +0800, Herrington wrote: >> We get 1 warning when building kernel with W=1: >> drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for >> ‘pch_ch_control_read’ [-Wmissing-prototypes] >> u32 pch_ch_contro

Re: [PATCH net-next v2 06/10] drivers/net/ethernet: handle one warning explicitly

2020-09-17 Thread Rustad, Mark D
at 8:25 PM, Saeed Mahameed wrote: I don't have any strong feeling against disabling compiler warnings, but maybe the right thing to do here is to initialize the gaps to the invalid value instead of pre-initializing the whole thing first and then setting up the valid values on the 2nd pass. I d

[PATCH bpf-next v6 05/10] bpf: support attaching freplace programs to multiple attach points

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This enables support for attaching freplace programs to multiple attach points. It does this by amending the UAPI for bpf_link_Create with a target btf ID that can be used to supply the new attachment point along with the target program fd. The target must be compatib

[PATCH bpf-next v6 07/10] libbpf: add support for freplace attachment in bpf_link_create

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds support for supplying a target btf ID for the bpf_link_create() operation, and adds a new bpf_program__attach_freplace() high-level API for attaching freplace functions with a target. Signed-off-by: Toke Høiland-Jørgensen --- tools/lib/bpf/bpf.c |

[PATCH bpf-next v6 01/10] bpf: disallow attaching modify_return tracing functions to other BPF programs

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen >From the checks and commit messages for modify_return, it seems it was never the intention that it should be possible to attach a tracing program with expected_attach_type == BPF_MODIFY_RETURN to another BPF program. However, check_attach_modify_return() will only lo

[PATCH bpf-next v6 00/10] bpf: Support multi-attach for freplace programs

2020-09-17 Thread Toke Høiland-Jørgensen
This series adds support attaching freplace BPF programs to multiple targets. This is needed to support incremental attachment of multiple XDP programs using the libxdp dispatcher model. The first patch fixes an issue that came up in review: The verifier will currently allow MODIFY_RETURN tracing

[PATCH bpf-next v6 04/10] bpf: move prog->aux->linked_prog and trampoline into bpf_link on attach

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen In preparation for allowing multiple attachments of freplace programs, move the references to the target program and trampoline into the bpf_tracing_link structure when that is created. To do this atomically, introduce a new mutex in prog->aux to protect writing to th

[PATCH bpf-next v6 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The check_attach_btf_id() function really does three things: 1. It performs a bunch of checks on the program to ensure that the attachment is valid. 2. It stores a bunch of state about the attachment being requested in the verifier environment and struct bpf_p

[PATCH bpf-next v6 02/10] bpf: change logging calls from verbose() to bpf_log() and use log pointer

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen In preparation for moving code around, change a bunch of references to env->log (and the verbose() logging helper) to use bpf_log() and a direct pointer to struct bpf_verifier_log. While we're touching the function signature, mark the 'prog' argument to bpf_check_type

[PATCH bpf-next v6 06/10] bpf: Fix context type resolving for extension programs

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Eelco reported we can't properly access arguments if the tracing program is attached to extension program. Having following program: SEC("classifier/test_pkt_md_access") int test_pkt_md_access(struct __sk_buff *skb) with its extension: SEC("freplace/test_pkt

[PATCH bpf-next v6 08/10] selftests: add test for multiple attachments of freplace program

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds a selftest for attaching an freplace program to multiple targets simultaneously. Signed-off-by: Toke Høiland-Jørgensen --- .../selftests/bpf/prog_tests/fexit_bpf2bpf.c | 157 .../selftests/bpf/progs/freplace_get_constant.c|

[PATCH bpf-next v6 10/10] selftests: Add selftest for disallowing modify_return attachment to freplace

2020-09-17 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds a selftest that ensures that modify_return tracing programs cannot be attached to freplace programs. The security_ prefix is added to the freplace program because that would otherwise let it pass the check for modify_return. Signed-off-by: Toke Høiland-Jørg

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-17 Thread Cong Wang
On Fri, Sep 11, 2020 at 1:13 AM Yunsheng Lin wrote: > > On 2020/9/11 4:07, Cong Wang wrote: > > On Tue, Sep 8, 2020 at 4:06 AM Yunsheng Lin wrote: > >> > >> Currently there is concurrent reset and enqueue operation for the > >> same lockless qdisc when there is no lock to synchronize the > >> q->

Re: [PATCH net-next v2 4/8] devlink: Support get and set state of port function

2020-09-17 Thread David Ahern
On 9/17/20 11:20 AM, Parav Pandit wrote: > diff --git a/net/core/devlink.c b/net/core/devlink.c > index d152489e48da..c82098cb75da 100644 > --- a/net/core/devlink.c > +++ b/net/core/devlink.c > @@ -595,6 +598,40 @@ devlink_port_function_hw_addr_fill(struct devlink > *devlink, const struct devlink

[PATCH bpf-next v6 09/10] selftests/bpf: Adding test for arg dereference in extension trace

2020-09-17 Thread Toke Høiland-Jørgensen
From: Jiri Olsa Adding test that setup following program: SEC("classifier/test_pkt_md_access") int test_pkt_md_access(struct __sk_buff *skb) with its extension: SEC("freplace/test_pkt_md_access") int test_pkt_md_access_new(struct __sk_buff *skb) and tracing that extension with: SEC

Re: [PATCH net-next] ionic: add DIMLIB to Kconfig

2020-09-17 Thread Shannon Nelson
On 9/17/20 1:02 PM, Jakub Kicinski wrote: On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote: On 9/17/20 12:02 PM, Jakub Kicinski wrote: On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote: ld.lld: error: undefined symbol: net_dim_get_rx_moderation >>> referenced by ionic_lif.c:

Re: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread David Ahern
On 9/17/20 11:20 AM, Parav Pandit wrote: > Simulate PCI SF ports. Allow user to create one or more PCI SF ports. > > Examples: > > Create a PCI PF and PCI SF port. > $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 > $ devlink port add netdevsim/netdevsim10/11 flavour pcisf pfnum

[PATCH v2 net-next] ionic: add DIMLIB to Kconfig

2020-09-17 Thread Shannon Nelson
>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52) >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a >> ld.lld: error: undefined symbol: net_dim >>>

Re: [PATCH v4] perf metricgroup: Fix uncore metric expressions

2020-09-17 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 17, 2020 at 01:18:07PM -0700, Ian Rogers escreveu: > A metric like DRAM_BW_Use has on SkylakeX events uncore_imc/cas_count_read/ > and uncore_imc/case_count_write/. These events open 6 events per socket > with pmu names of uncore_imc_[0-5]. The current metric setup code in > find_evsel_

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread Shay Agroskin
David Miller writes: From: Saeed Mahameed Date: Thu, 17 Sep 2020 12:38:28 -0700 allocated but unregistered netdevices also do not help much as the name of the netdev is not assigned yet. why don't use dev_info(pci_dev) macors for low level functions when netdev is not available or not

Re: [PATCH v4 net-next 1/5] devlink: add timeout information to status_notify

2020-09-17 Thread Shannon Nelson
On 9/17/20 12:46 PM, Jakub Kicinski wrote: On Wed, 16 Sep 2020 20:02:00 -0700 Shannon Nelson wrote: Add a timeout element to the DEVLINK_CMD_FLASH_UPDATE_STATUS netlink message for use by a userland utility to show that a particular firmware flash activity may take a long but bounded time to fin

Re: [PATCH v4 net-next 2/5] devlink: collect flash notify params into a struct

2020-09-17 Thread Shannon Nelson
On 9/17/20 12:47 PM, Jakub Kicinski wrote: On Wed, 16 Sep 2020 20:02:01 -0700 Shannon Nelson wrote: The dev flash status notify function parameter lists are getting rather long, so add a struct to be filled and passed rather than continuously changing the function signatures. Signed-off-by: Sha

Re: [PATCH v4 net-next 3/5] netdevsim: devlink flash timeout message

2020-09-17 Thread Shannon Nelson
On 9/17/20 12:50 PM, Jakub Kicinski wrote: On Wed, 16 Sep 2020 20:02:02 -0700 Shannon Nelson wrote: Add a simple devlink flash timeout message to exercise the message mechanism. Signed-off-by: Shannon Nelson --- drivers/net/netdevsim/dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v4 net-next 1/5] devlink: add timeout information to status_notify

2020-09-17 Thread Shannon Nelson
On 9/17/20 12:50 PM, Jacob Keller wrote: On 9/16/2020 8:02 PM, Shannon Nelson wrote: Add a timeout element to the DEVLINK_CMD_FLASH_UPDATE_STATUS netlink message for use by a userland utility to show that a particular firmware flash activity may take a long but bounded time to finish. Also add

Re: [PATCH v4 net-next 5/5] ionic: add devlink firmware update

2020-09-17 Thread Shannon Nelson
On 9/17/20 12:52 PM, Jakub Kicinski wrote: On Wed, 16 Sep 2020 20:02:04 -0700 Shannon Nelson wrote: Add support for firmware update through the devlink interface. This update copies the firmware object into the device, asks the current firmware to install it, then asks the firmware to select the

[PATCH net-next 0/1] net/smc: fix 2020-09-17

2020-09-17 Thread Karsten Graul
Please apply the following patch for smc to netdev's net-next tree. The patch fixes a problem reported by Dan. Because the fixed patch is still only in net-next tree I am sending this fix to net-next. Ursula Braun (1): net/smc: fix double kfree in smc_listen_work() net/smc/af_smc.c | 4 ++--

[PATCH net-next 1/1] net/smc: fix double kfree in smc_listen_work()

2020-09-17 Thread Karsten Graul
From: Ursula Braun If smc_listen_rmda_finish() returns with an error, the storage addressed by 'buf' is freed a second time. Consolidate freeing under a common label and jump to that label. Fixes: 6bb14e48ee8d ("net/smc: dynamic allocation of CLC proposal buffer") Reported-by: Dan Carpenter Sig

Re: [PATCH v8 bpf-next 6/7] bpf: allow for tailcalls in BPF subprograms for x64 JIT

2020-09-17 Thread Andrii Nakryiko
On Wed, Sep 16, 2020 at 3:54 PM Maciej Fijalkowski wrote: > > Relax verifier's restriction that was meant to forbid tailcall usage > when subprog count was higher than 1. > > Also, do not max out the stack depth of program that utilizes tailcalls. > > Signed-off-by: Maciej Fijalkowski > --- Maci

[PATCH net-next] mptcp: fix integer overflow in mptcp_subflow_discard_data()

2020-09-17 Thread Paolo Abeni
Christoph reported an infinite loop in the subflow receive path under stress condition. If there are multiple subflows, each of them using a large send buffer, the delta between the sequence number used by MPTCP-level retransmission can and the current msk->ack_seq can be greater than MAX_INT. In

Re: [PATCH bpf-next] selftests/bpf: Fix stat probe in d_path test

2020-09-17 Thread Alexei Starovoitov
On Thu, Sep 17, 2020 at 1:25 AM Jiri Olsa wrote: > > > Ideally resolve_btfids would parse dwarf info and check > > whether any of the funcs in allowlist were inlined. > > That would be more reliable, but not pretty to drag libdw > > dependency into resolve_btfids. > > hm, we could add some check t

Re: [BlueZ PATCH v2 1/6] Bluetooth: Update Adv monitor count upon removal

2020-09-17 Thread Luiz Augusto von Dentz
Hi Howard, On Thu, Sep 17, 2020 at 1:47 AM Howard Chung wrote: > > From: Miao-chen Chou > > This fixes the count of Adv monitor upon monitor removal. > > The following test was performed. > - Start two btmgmt consoles, issue a btmgmt advmon-remove command on one > console and observe a MGMT_EV_A

Re: Exposing device ACL setting through devlink

2020-09-17 Thread Thomas Falcon
On 9/10/20 2:00 AM, Jiri Pirko wrote: Tue, Sep 08, 2020 at 08:27:13PM CEST, tlfal...@linux.ibm.com wrote: On 9/4/20 5:37 PM, Jakub Kicinski wrote: On Fri, 4 Sep 2020 10:31:41 +0200 Jiri Pirko wrote: Thu, Sep 03, 2020 at 07:59:45PM CEST, tlfal...@linux.ibm.com wrote: Hello, I am trying to ex

Re: i4oe/XXV710 suspect tx_dropped stats

2020-09-17 Thread Nguyen, Anthony L
On Tue, 2020-09-15 at 09:22 -0400, Jamal Hadi Salim wrote: > Ethtool reporting zero. ip -s reporting non-zero. > Which is right? See attached for more details. > I've asked the team responsible for the driver to look into this issue. I will let you know what I hear back. Thanks, Tony

Re: [MPTCP] [PATCH net-next] mptcp: fix integer overflow in mptcp_subflow_discard_data()

2020-09-17 Thread Mat Martineau
On Thu, 17 Sep 2020, Paolo Abeni wrote: Christoph reported an infinite loop in the subflow receive path under stress condition. If there are multiple subflows, each of them using a large send buffer, the delta between the sequence number used by MPTCP-level retransmission can and the current

Re: [PATCH] i40e: Fix use of uninitialized variable

2020-09-17 Thread Nguyen, Anthony L
On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote: > In i40e_clean_rx_irq_zc(), the variable failure is only set when a > condition is met, but then its value is used unconditionally. Fix > this. > > Addresses-Coverity: 1496986 ("Uninitialized value") > Fixes: 8cbf74149903 ("i40e, xsk: move buff

Re: [PATCH net] ibmvnic: Fix returning uninitialized return code

2020-09-17 Thread Thomas Falcon
On 9/17/20 1:07 AM, Saeed Mahameed wrote: On Wed, 2020-09-16 at 17:12 -0500, Thomas Falcon wrote: If successful, __ibmvnic_open and reset_sub_crq_queues, if no device queues exist, will return an uninitialized variable rc. Return zero on success instead. Fixes: 57a49436f4e8 ("ibmvnic: Reset s

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread Michal Kubecek
On Thu, Sep 17, 2020 at 03:41:51AM +0200, Andrew Lunn wrote: > On Thu, Sep 17, 2020 at 01:04:10AM +0200, Michal Kubecek wrote: > > Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd > > field in genetlink header) for replies to tunnel info netlink request, i.e. > > the same

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread Andrew Lunn
> On the other hand, the enums are part of userspace API so I better take > a closer look to make sure we don't run into some trouble there. Hi Michal Yes, that is what i was thinking about. But i guess you can pass a tagged enum to a function expecting an int and the compiler will silently cast

[PATCH] add virtual PHY for PHY-less devices

2020-09-17 Thread Sergej Bauer
From: sba...@blackbox.su Here is a kernel related part of my work which was helps to develop brand new PHY device. It is migth be helpful for developers work with PHY-less lan743x (7431:0011 in my case). It's just a fake virtual PHY which can change speed of network card processing as a l

<    1   2   3   4   5   >