From: Jakub Kicinski <k...@kernel.org>
Date: Thu, 17 Sep 2020 13:02:31 -0700

> On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote:
>> On 9/17/20 12:02 PM, Jakub Kicinski wrote:
>> > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote:  
>> >>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation  
>> >>     >>> referenced by ionic_lif.c:52 
>> >> (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
>> >>     >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in 
>> >> archive drivers/built-in.a  
>> >> --  
>> > This is going to cut off the commit message when patch is applied.  
>> 
>> Isn't the trigger a three dash string?  It is only two dashes, not 
>> three, and "git am" seems to work correctly for me.  Is there a 
>> different mechanism I need to watch out for?
> 
> I got a verify_signoff failure on this patch:
> 
> Commit a92faed54662 ("ionic: add DIMLIB to Kconfig")
>       author Signed-off-by missing
>       author email:    snel...@pensando.io
> 
> And in the tree I can see the commit got cut off. 
> 
> Maybe it's some extra mangling my bot does. In any case, I wanted to
> at least give Dave a heads up.

Thanks I'll watch carefully when applying this :)

Reply via email to