Re: [PATCH net-next 6/6] net: hns3: use napi_consume_skb() when cleaning tx desc

2020-09-15 Thread Yunsheng Lin
On 2020/9/15 13:09, Saeed Mahameed wrote: > On Mon, 2020-09-14 at 20:06 +0800, Huazhong Tan wrote: >> From: Yunsheng Lin >> >> Use napi_consume_skb() to batch consuming skb when cleaning >> tx desc in NAPI polling. >> >> Signed-off-by: Yunsheng Lin >> Signed-off-by: Huazhong Tan >> --- >> drive

Re: [PATCH net-next 5/8] bridge: Add SWITCHDEV_FDB_FLUSH_TO_BRIDGE notifier

2020-09-15 Thread Nikolay Aleksandrov
On Thu, 2020-09-10 at 19:23 +0200, Julian Wiedmann wrote: > From: Alexandra Winter > > so the switchdev can notifiy the bridge to flush non-permanent fdb entries > for this port. This is useful whenever the hardware fdb of the switchdev > is reset, but the netdev and the bridgeport are not delete

Re: [PATCH] xfrm:fragmented ipv4 tunnel packets in inner interface

2020-09-15 Thread Steffen Klassert
On Wed, Sep 09, 2020 at 02:26:13PM +0800, mtk81216 wrote: > In esp's tunnel mode,if inner interface is ipv4,outer is ipv4,one big > packet which travels through tunnel will be fragmented with outer > interface's mtu,peer server will remove tunnelled esp header and assemble > them in big packet.Af

Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats to dev get

2020-09-15 Thread Jiri Pirko
Tue, Sep 15, 2020 at 08:45:19AM CEST, ido...@idosch.org wrote: >On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote: >> Mon, Sep 14, 2020 at 08:07:51AM CEST, mo...@mellanox.com wrote: >> >Expose devlink reload actions stats to the user through devlink dev >> >get command. >> > >> >Examples:

Re: [PATCH] vhost_vdpa: Fix duplicate included kernel.h

2020-09-15 Thread Jason Wang
On 2020/9/15 上午8:51, Tian Tao wrote: linux/kernel.h is included more than once, Remove the one that isn't necessary. Signed-off-by: Tian Tao --- drivers/vhost/vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 3fab94f..95e2b83 100644

general protection fault in cache_clean

2020-09-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:581cb3a2 Merge tag 'f2fs-for-5.9-rc5' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11f5c01190 kernel config: https://syzkaller.appspot.com/x/.config?x=a9075b36a6ae26c9 das

Re: [PATCH] vhost: reduce stack usage in log_used

2020-09-15 Thread Jason Wang
On 2020/9/15 上午2:08, Li Wang wrote: Fix the warning: [-Werror=-Wframe-larger-than=] drivers/vhost/vhost.c: In function log_used: drivers/vhost/vhost.c:1906:1: warning: the frame size of 1040 bytes is larger than 1024 bytes Signed-off-by: Li Wang --- drivers/vhost/vhost.c | 2 +- drivers/v

Re: [PATCH net-next 5/8] bridge: Add SWITCHDEV_FDB_FLUSH_TO_BRIDGE notifier

2020-09-15 Thread Ivan Vecera
On Thu, 10 Sep 2020 19:23:48 +0200 Julian Wiedmann wrote: > From: Alexandra Winter > > so the switchdev can notifiy the bridge to flush non-permanent fdb entries > for this port. This is useful whenever the hardware fdb of the switchdev > is reset, but the netdev and the bridgeport are not dele

Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication

2020-09-15 Thread Jason Wang
Hi Kishon: On 2020/9/14 下午3:23, Kishon Vijay Abraham I wrote: Then you need something that is functional equivalent to virtio PCI which is actually the concept of vDPA (e.g vDPA provides alternatives if the queue_sel is hard in the EP implementation). Okay, I just tried to compare the 'struct v

[PATCH net-next 5/8] mlxsw: reg: Add Monitoring FW Debug Register

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko Introduce MFDE register that is passed through MFDE trap in case of fatal FW event. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 79 +++ 1 file changed, 79 insertions(+) diff --git a/drivers/net/eth

[PATCH net-next 4/8] mlxsw: Move fw_load_policy devlink param into core.c

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko As the fw flashing code was moved to core.c, move the param which is related to it there as well. Remove unnecessary parentheses on the way. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c| 51 +++- .../net/

[PATCH net-next 2/8] mlxsw: Move fw flashing code into core.c

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko As the firmware flashing is not specific to Spectrum, move the code to core.c and avoid one op call and 2 exported symbols. Also, this allows to do flash before call of driver->init function and possibly do other core calls in between. Do some small renaming here and there on th

[PATCH net-next 3/8] mlxsw: core: Push code doing params register/unregister into separate helpers

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko Extract the code calling params register/unregister driver ops into separate functions. Call publish/unpublish unconditionally. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c | 39 +++--- 1 file changed, 27

[PATCH net-next 6/8] mlxsw: reg: Add Monitoring FW General Debug Register

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko Introduce MFGD register that is used to configure firmware debugging. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/ethernet/mellanox/m

[PATCH net-next 8/8] mlxsw: core: Introduce fw_fatal health reporter

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko Introduce devlink health reporter to report FW fatal events. Implement the event listener using MFDE trap and enable the events to be propagated using MFGD register configuration. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/co

[PATCH net-next 1/8] mlxsw: Bump firmware version to XX.2008.1310

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko Among other changes, this version supports FW monitoring. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/ml

[PATCH net-next 0/8] mlxsw: Introduce fw_fatal health reporter and test cmd to trigger test event

2020-09-15 Thread Ido Schimmel
From: Ido Schimmel Jiri says: This patch set introduces a health reporter for mlxsw that reports FW fatal events. Alongside that, it introduces a test command that is used to trigger a dummy FW fatal event by user: $ sudo devlink health test pci/:03:00.0 reporter fw_fatal $ devlink health

[PATCH net-next 7/8] devlink: introduce the health reporter test command

2020-09-15 Thread Ido Schimmel
From: Jiri Pirko Introduce a test command for health reporters. User might use this command to trigger test event on a reporter if the reporter supports it. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- include/net/devlink.h| 3 +++ include/uapi/linux/devlink.h | 2 ++ n

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-15 Thread Toke Høiland-Jørgensen
[ just jumping in to answer this bit: ] > Would you happen to know what ebpf startup overhead is? > How big a problem is having two (or more) back to back tc programs > instead of one? With a jit'ed BPF program and the in-kernel dispatcher code (which avoids indirect calls), it's quite close to a

[net-next:master 108/112] drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:752: undefined reference to `cxgb4_reclaim_completed_tx'

2020-09-15 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a33d91ee3817ef00fc7abfe95ab0b8ccef1b26fb commit: 6bd860ac1c2a0ec2bbe3470bf2b82348ee354dfc [108/112] chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4 config: x86_64-randconfig-a001-20200914 (a

[PATCH] Bluetooth: Move force_bredr_smp debugfs into hci_debugfs_create_bredr

2020-09-15 Thread Claire Chang
Avoid multiple attempts to create the debugfs entery, force_bredr_smp, by moving it from the SMP registration to the BR/EDR controller init section. hci_debugfs_create_bredr is only called when HCI_SETUP and HCI_CONFIG is not set. Signed-off-by: Claire Chang --- net/bluetooth/hci_debugfs.c | 50

Re: [PATCH net-next v2 04/10] drivers/net/ethernet: clean up unused assignments

2020-09-15 Thread Edward Cree
On 15/09/2020 02:44, Jesse Brandeburg wrote: > As part of the W=1 compliation series, these lines all created > warnings about unused variables that were assigned a value. Most > of them are from register reads, but some are just picking up > a return value from a function and never doing anything

Re: [PATCH RFC bpf-next 2/2] bpf: Enable bpf_skc_to_* sock casting helper to networking prog type

2020-09-15 Thread Lorenz Bauer
On Mon, 14 Sep 2020 at 20:43, Martin KaFai Lau wrote: [...] > > For other ARG_PTR_TO_SOCK_COMMON helpers, they are not available to > the tracing prog type. Hence, they are fine to accept PTR_TO_BTF_ID > as ARG_PTR_TO_SOCK_COMMON since the only way for non tracing prog to > get a PTR_TO_BTF_ID is

Re: [PATCH net-next v2 09/10] sfc: fix kdoc warning

2020-09-15 Thread Edward Cree
On 15/09/2020 02:44, Jesse Brandeburg wrote: > kernel-doc script as used by W=1, is confused by the macro > usage inside the header describing the efx_ptp_data struct. > > drivers/net/ethernet/sfc/ptp.c:345: warning: Function parameter or member > 'MC_CMD_PTP_IN_TRANSMIT_LENMAX' not described in '

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-15 Thread Jani Nikula
On Wed, 09 Sep 2020, Joe Perches wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c > b/drivers/gpu/drm/i915/display/intel_sprite.c > index 5ac0dbf0e03d..35ac539cc2b1 100644 > --- a/drivers/gpu/drm/i915/display/intel_sprite.c > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c > @@

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-15 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 07:30:33PM -0700, Alexei Starovoitov wrote: > On Fri, Sep 11, 2020 at 6:16 AM Jiri Olsa wrote: > > > > On Thu, Sep 10, 2020 at 05:46:21PM -0700, Alexei Starovoitov wrote: > > > On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote: > > > > > > > > Some kernels builds might inlin

Re: [PATCH 06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init'

2020-09-15 Thread Lee Jones
On Sat, 12 Sep 2020, Kalle Valo wrote: > Lee Jones wrote: > > > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > > gets confused if the variable does not follow the type/attribute > > definitions. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/ne

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-15 Thread Miquel Raynal
Hi Joe, For MTD: > drivers/mtd/nand/raw/nandsim.c| 2 +- Reviewed-by: Miquel Raynal Thanks, Miquèl

[PATCH] chelsio/chtls: Re-add dependencies on CHELSIO_T4 to fix modular CHELSIO_T4

2020-09-15 Thread Geert Uytterhoeven
As CHELSIO_INLINE_CRYPTO is bool, and CHELSIO_T4 is tristate, the dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is not sufficient to protect CRYPTO_DEV_CHELSIO_TLS and CHELSIO_IPSEC_INLINE. The latter two are also tristate, hence if CHELSIO_T4=n, they cannot be builtin, as that would lead to l

RE: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-15 Thread Tuong Tong Lien
> -Original Message- > From: Eric Dumazet > Sent: Wednesday, September 2, 2020 2:11 PM > To: Tuong Tong Lien ; Eric Dumazet > ; da...@davemloft.net; > jma...@redhat.com; ma...@donjonn.com; ying@windriver.com; > netdev@vger.kernel.org > Cc: tipc-discuss...@lists.sourceforge.net > Su

Re: [PATCH RESEND bpf-next v3 4/9] bpf: support attaching freplace programs to multiple attach points

2020-09-15 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Mon, Sep 14, 2020 at 9:08 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > On Fri, Sep 11, 2020 at 3:01 AM Toke Høiland-Jørgensen >> > wrote: >> >> >> >> From: Toke Høiland-Jørgensen >> >> >> >> This enables support for attaching freplace

[PATCH bpf-next v5 0/8] bpf: Support multi-attach for freplace programs

2020-09-15 Thread Toke Høiland-Jørgensen
This series adds support attaching freplace BPF programs to multiple targets. This is needed to support incremental attachment of multiple XDP programs using the libxdp dispatcher model. The first three patches are refactoring patches: The first one is a trivial change to the logging in the verifi

[PATCH net-next 5/5] selftests: fib_nexthops: Test cleanup of FDB entries following nexthop deletion

2020-09-15 Thread Ido Schimmel
From: Ido Schimmel Commit c7cdbe2efc40 ("vxlan: support for nexthop notifiers") registered a listener in the VXLAN driver to the nexthop notification chain. Its purpose is to cleanup FDB entries that use a nexthop that is being deleted. Test that such FDB entries are removed when the nexthop gro

[PATCH net-next 2/5] nexthop: Remove NEXTHOP_EVENT_ADD

2020-09-15 Thread Ido Schimmel
From: Ido Schimmel Not used anywhere. Signed-off-by: Ido Schimmel Suggested-by: David Ahern --- include/net/nexthop.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/nexthop.h b/include/net/nexthop.h index 2e44efe5709b..2fd76a9b6dc8 100644 --- a/include/net/nexthop.h +++ b/incl

Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()

2020-09-15 Thread Tariq Toukan
On 9/14/2020 11:02 PM, Jakub Kicinski wrote: On Sun, 13 Sep 2020 13:12:05 +0300 Tariq Toukan wrote: 2. When MLX4_EN_PERF_STAT is not defined, we should totally remove the local variable declaration, not only its usage. I was actually wondering about this when working on the pause stat patch

Re: [PATCH net-next RFC v4 02/15] devlink: Add reload action limit level

2020-09-15 Thread Moshe Shemesh
On 9/14/2020 4:10 PM, Jiri Pirko wrote: Mon, Sep 14, 2020 at 08:07:49AM CEST, mo...@mellanox.com wrote: [..] diff --git a/include/net/devlink.h b/include/net/devlink.h index b09db891db04..9ee5b8a9 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-15 Thread Moshe Shemesh
On 9/14/2020 3:27 PM, Jiri Pirko wrote: Mon, Sep 14, 2020 at 08:07:48AM CEST, mo...@mellanox.com wrote: Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward compa

Re: [PATCH RFC 1/7] net: bridge: extend the process of special frames

2020-09-15 Thread henrik.bjoernl...@microchip.com
Thanks for your review. I will update in the next version as suggested. Regards Henrik The 09/08/2020 12:12, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:

Re: [PATCH RFC 2/7] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-09-15 Thread henrik.bjoernl...@microchip.com
Thanks for your review. I will update in the next version as suggested. Regards Henrik The 09/08/2020 12:18, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:

Re: [PATCH net-next RFC v4 03/15] devlink: Add reload action stats

2020-09-15 Thread Moshe Shemesh
On 9/14/2020 4:39 PM, Jiri Pirko wrote: Mon, Sep 14, 2020 at 08:07:50AM CEST, mo...@mellanox.com wrote: Add reload action stats to hold the history per reload action type and limit level. Empty line missing. Ack. For example, the number of times fw_activate has been performed on this dev

Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats to dev get

2020-09-15 Thread Moshe Shemesh
On 9/15/2020 10:44 AM, Jiri Pirko wrote: Tue, Sep 15, 2020 at 08:45:19AM CEST, ido...@idosch.org wrote: On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote: Mon, Sep 14, 2020 at 08:07:51AM CEST, mo...@mellanox.com wrote: Expose devlink reload actions stats to the user through devlink

Re: [PATCH net-next RFC v4 10/15] net/mlx5: Add support for devlink reload action fw activate

2020-09-15 Thread Moshe Shemesh
On 9/14/2020 4:52 PM, Jiri Pirko wrote: Mon, Sep 14, 2020 at 08:07:57AM CEST, mo...@mellanox.com wrote: Add support for devlink reload action fw_activate. To activate firmware image the mlx5 driver resets the firmware and reloads it from flash. If a new image was stored on flash it will be loa

Re: [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-15 Thread Henrik Bjoernlund
Thanks for the review. Comments below. The 09/04/2020 08:02, Jakub Kicinski wrote: > > On Fri, 4 Sep 2020 09:15:24 + Henrik Bjoernlund wrote: > > + rcu_read_lock(); > > + b_port = rcu_dereference(mep->b_port); > > + if (!b_port) > > + return NULL; > > + skb = dev_a

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-15 Thread Moshe Shemesh
On 9/15/2020 12:33 AM, Jakub Kicinski wrote: External email: Use caution opening links or attachments On Mon, 14 Sep 2020 09:07:48 +0300 Moshe Shemesh wrote: @@ -3011,12 +3060,41 @@ static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info) return P

Re: [PATCH v2] arm64: bpf: Fix branch offset in JIT

2020-09-15 Thread Will Deacon
Hi Ilias, On Mon, Sep 14, 2020 at 07:03:55PM +0300, Ilias Apalodimas wrote: > Running the eBPF test_verifier leads to random errors looking like this: > > [ 6525.735488] Unexpected kernel BRK exception at EL1 > [ 6525.735502] Internal error: ptrace BRK handler: f2000100 [#1] SMP Does this happen

Re: [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-15 Thread henrik.bjoernl...@microchip.com
Thanks for the review. Comments below. The 09/08/2020 13:16, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of the CFM protocol according to > > 802.1Q section 12.14. > > > > Connectivity Fault Management (CFM) comprises c

WARNING: refcount bug in pde_put

2020-09-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:581cb3a2 Merge tag 'f2fs-for-5.9-rc5' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17796c0190 kernel config: https://syzkaller.appspot.com/x/.config?x=a9075b36a6ae26c9 das

Re: [PATCH RFC 5/7] bridge: cfm: Netlink Interface.

2020-09-15 Thread henrik.bjoernl...@microchip.com
Thanks for the review. Comments below. The 09/08/2020 13:47, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink configuration > > and status information interface. > > > > Add new nested netlink attributes. Thes

Re: [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-15 Thread henrik.bjoernl...@microchip.com
Thanks for the review. Comments below. The 09/08/2020 13:54, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of Netlink notifications out of CFM. > > > > Notifications are initiated whenever a state change happens in CFM. >

Re: [PATCH RFC 7/7] bridge: cfm: Bridge port remove.

2020-09-15 Thread henrik.bjoernl...@microchip.com
Thanks for the review. I will update the next version as suggested. The 09/08/2020 13:58, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is addition of CFM functionality to delete MEP instances > > on a port that is removed from the bridge. > >

Re: [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-15 Thread henrik.bjoernl...@microchip.com
Thanks for the review. Comments below. The 09/08/2020 13:54, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of Netlink notifications out of CFM. > > > > Notifications are initiated whenever a state change happens in CFM. >

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Andrew Lunn
On Mon, Sep 14, 2020 at 09:24:28PM -0700, Saeed Mahameed wrote: > On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote: > > After applying the patches below, the drivers/net/ethernet > > directory can be built as modules with W=1 with no warnings (so > > far on x64_64 arch only!). > > As Jakub

[PATCH 0/9 next] Changes to code that reads iovec from userspace

2020-09-15 Thread David Laight
The canonical code to read iov[] from userspace is currently: struct iovec iovstack[UIO_FASTIOV]; struct iovec *iov; ... iov = iovstack; rc = import_iovec(..., UIO_FASTIOV, &iov, &iter); if (rc < 0) return rc; ... kfr

[PATCH 2/9 next] fs: Move rw_copy_check_uvector() into lib/iov_iter.c and make static.

2020-09-15 Thread David Laight
This lets the compiler inline it into import_iovec() generating much better code. Signed-off-by: David Laight --- fs/read_write.c| 179 - include/linux/compat.h | 6 -- include/linux/fs.h | 5 -- lib/iov_iter.c | 178 +

[PATCH 5/9 next] scsi: Use iovec_import() instead of import_iovec().

2020-09-15 Thread David Laight
iovec_import() has a safer calling convention than import_iovec(). Signed-off-by: David Laight --- block/scsi_ioctl.c | 14 -- drivers/scsi/sg.c | 14 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index ef72

a saner API for allocating DMA addressable pages v3

2020-09-15 Thread Christoph Hellwig
Hi all, this series replaced the DMA_ATTR_NON_CONSISTENT flag to dma_alloc_attrs with a separate new dma_alloc_pages API, which is available on all platforms. In addition to cleaning up the convoluted code path, this ensures that other drivers that have asked for better support for non-coherent D

[PATCH 05/18] net/au1000-eth: stop using DMA_ATTR_NON_CONSISTENT

2020-09-15 Thread Christoph Hellwig
The au1000-eth driver contains none of the manual cache synchronization required for using DMA_ATTR_NON_CONSISTENT. From what I can tell it can be used on both dma coherent and non-coherent DMA platforms, but I suspect it has been buggy on the non-coherent platforms all along. Signed-off-by: Chri

Re: [PATCH v7 bpf-next 7/7] selftests: bpf: add dummy prog for bpf2bpf with tailcall

2020-09-15 Thread Daniel Borkmann
On 9/15/20 5:48 PM, Alexei Starovoitov wrote: On Tue, Sep 15, 2020 at 8:03 AM Daniel Borkmann wrote: On 9/15/20 6:39 AM, Alexei Starovoitov wrote: On Fri, Sep 11, 2020 at 08:59:27PM +0200, Maciej Fijalkowski wrote: On Thu, Sep 03, 2020 at 12:51:14PM -0700, Alexei Starovoitov wrote: On Wed,

[PATCH 12/18] sgiseeq: convert to dma_alloc_noncoherent

2020-09-15 Thread Christoph Hellwig
Use the new non-coherent DMA API including proper ownership transfers. This includes adding additional calls to dma_sync_desc_dev as the old syncing was rather ad-hoc. Thanks to Thomas Bogendoerfer for debugging the ownership transfer issues. Signed-off-by: Christoph Hellwig --- drivers/net/eth

Re: [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-09-15 Thread David Ahern
On 9/11/20 1:58 AM, Jesper Dangaard Brouer wrote: > On Thu, 10 Sep 2020 12:35:33 -0600 > David Ahern wrote: > >> On 9/10/20 11:50 AM, Jesper Dangaard Brouer wrote: >>> Maybe we should change the devmap-prog approach, and run this on the >>> xdp_frame's (in bq_xmit_all() to be precise) . Hangbin'

Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 22:06:45 +0530 sundeep subbaraya wrote: > On Tue, Sep 15, 2020 at 9:42 PM Jakub Kicinski wrote: > > > > On Tue, 15 Sep 2020 21:22:21 +0530 sundeep subbaraya wrote: > > > > > Make use of the standard devlink tracepoint wherever applicable, and > > > > > you > > > > > can keep

RE: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Keller, Jacob E
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, September 15, 2020 8:51 AM > To: Shannon Nelson > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > da...@davemloft.net > Subject: Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update > > On Mon, 14 Sep 2020 18:14:22

[PATCH v3 06/14] habanalabs/gaudi: add NIC PHY code

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Configure the NIC PHY (physical layer). The PHY is configured with the correct polarity and Tx taps depending on the card type. After the initial configuration, the PHY flow contains the following: - Auto-negotiation (if enabled) - PHY F/W tuning - Physical Coding Sublayer

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Shannon Nelson
On 9/15/20 9:50 AM, Keller, Jacob E wrote: -Original Message- From: Jakub Kicinski Sent: Tuesday, September 15, 2020 8:51 AM To: Shannon Nelson Cc: Keller, Jacob E ; netdev@vger.kernel.org; da...@davemloft.net Subject: Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update On

Re: [PATCH bpf-next v2 4/5] bpf: selftests: add MPTCP test base

2020-09-15 Thread Song Liu
> On Sep 15, 2020, at 9:35 AM, Nicolas Rybowski > wrote: > > Hi Song, > > Thanks for the feedback ! > > On Mon, Sep 14, 2020 at 8:07 PM Song Liu wrote: >> >> On Fri, Sep 11, 2020 at 8:02 AM Nicolas Rybowski >> wrote: >>> >>> This patch adds a base for MPTCP specific tests. >>> >>> It i

Re: [PATCH bpf-next] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 10:35:50 -0700 Yonghong Song wrote: > On 9/15/20 8:33 AM, Jakub Kicinski wrote: > > On Mon, 14 Sep 2020 11:46:30 -0700 Yonghong Song wrote: > >> Currently, we use bucket_lock when traversing bpf_sk_storage_map > >> elements. Since bpf_iter programs cannot use bpf_sk_storage_ge

Re: [PATCH bpf v4] xsk: do not discard packet when NETDEV_TX_BUSY

2020-09-15 Thread Magnus Karlsson
On Tue, Sep 15, 2020 at 5:49 PM Daniel Borkmann wrote: > > Hey Magnus, > > On 9/11/20 2:43 PM, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > In the skb Tx path, transmission of a packet is performed with > > dev_direct_xmit(). When NETDEV_TX_BUSY is set in the drivers, it > > signifies

Re: [PATCH v7 bpf-next 7/7] selftests: bpf: add dummy prog for bpf2bpf with tailcall

2020-09-15 Thread Alexei Starovoitov
On Tue, Sep 15, 2020 at 10:52 AM Maciej Fijalkowski wrote: > > > + /* this means we are at the end of the call chain; if throughout this > > > > In my mind 'end of the call chain' means 'leaf function', > > so the comment reads a bit misleading to me. > > Here we're at the end of subprog. > > It

[PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-15 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 73 +++ 1 file changed, 73

[PATCH net-next 3/3] net: phy: dp83822: Update the fiber advertisement for speed

2020-09-15 Thread Dan Murphy
Update the fiber advertisement for speed and duplex modes with the 100base-FX full and half linkmode entries. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83822.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp8

[PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

2020-09-15 Thread Dan Murphy
Add entries for the 100base-FX full and half duplex supported modes. $ ethtool eth0 Supported ports: [ TPMII FIBRE ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 100baseFX/Half

[PATCH net 2/7] net: mscc: ocelot: add locking for the port TX timestamp ID

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean The ocelot_port->ts_id is used to: - populate skb->cb[0] for matching the TX timestamp in the PTP IRQ with an skb. - populate the REW_OP from the injection header of the ongoing skb. Only then is ocelot_port->ts_id incremented. This is a problem because, at least theoreti

[PATCH net 5/7] net: mscc: ocelot: error checking when calling ocelot_init()

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean ocelot_init() allocates memory, resets the switch and polls for a status register, things which can fail. Stop probing the driver in that case, and propagate the error result. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/felix.c | 5 - drivers

[PATCH net 7/7] net: mscc: ocelot: unregister net devices on unbind

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean This driver was not unregistering its network interfaces on unbind. Now it is. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/ethernet/mscc/ocelot_vsc751

[PATCH net 4/7] net: mscc: ocelot: check for errors on memory allocation of ports

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean Do not proceed probing if we couldn't allocate memory for the ports array, just error out. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/dri

[PATCH net 3/7] net: dsa: seville: fix buffer size of the queue system

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/ocelot/seville_vsc99

[PATCH net 6/7] net: mscc: ocelot: refactor ports parsing code into a dedicated function

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean mscc_ocelot_probe() is already pretty large and hard to follow. So move the code for parsing ports in a separate function. This makes it easier for the next patch to just call mscc_ocelot_release_ports from the error path of mscc_ocelot_init_ports. Signed-off-by: Vladimir

[PATCH net 0/7] Bugfixes in Microsemi Ocelot switch driver

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean This is a series of 7 assorted patches for "net", on the drivers for the VSC7514 MIPS switch (Ocelot-1), the VSC9953 PowerPC (Seville), and a few more that are common to all supported devices since they are in the common library portion. Vladimir Oltean (7): net: mscc: oc

[PATCH net 1/7] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-15 Thread Vladimir Oltean
From: Vladimir Oltean The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It is in a race with the TX timestamp IRQ, which checks that queue trying to match the timestamp with the skb by the ts_id. The skb should be added to the queue before the IRQ can fire. Fixes: 4e3b0468e6d7

[PATCH bpf] bpf: bpf_skc_to_* casting helpers require a NULL check on sk

2020-09-15 Thread Martin KaFai Lau
The bpf_skc_to_* type casting helpers are available to BPF_PROG_TYPE_TRACING. The traced PTR_TO_BTF_ID may be NULL. For example, the skb->sk may be NULL. Thus, these casting helpers need to check "!sk" also and this patch fixes them. Fixes: 0d4fad3e57df ("bpf: Add bpf_skc_to_udp6_sock() helper")

[PATCH net-next 0/3] 100base Fx link modes

2020-09-15 Thread Dan Murphy
Hello As per patch https://lore.kernel.org/patchwork/patch/1300241/ the link modes for 100base FX full and half duplex modes did not exist. Adding these link modes to the core and ethtool allow devices like the DP83822, DP83869 and Broadcomm PHYs to properly advertise the correct mode for Fiber 1

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2020-09-15 Thread Anchal Agarwal
On Mon, Sep 14, 2020 at 08:24:22PM -0400, boris.ostrov...@oracle.com wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 9/14/20 5:47 PM, Anchal Agarwal w

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 10:20:11 -0700 Shannon Nelson wrote: > >>> What should the userland program do when the timeout expires?  Start > >>> counting backwards?  Stop waiting?  Do we care to define this at the > >>> moment? > >> [component] bla bla X% (timeout reached) > > > > Yep. I don't think

Re: [PATCH bpf-next] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-15 Thread Yonghong Song
On 9/15/20 8:33 AM, Jakub Kicinski wrote: On Mon, 14 Sep 2020 11:46:30 -0700 Yonghong Song wrote: Currently, we use bucket_lock when traversing bpf_sk_storage_map elements. Since bpf_iter programs cannot use bpf_sk_storage_get() and bpf_sk_storage_delete() helpers which may also grab bucket l

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jacob Keller
On 9/15/2020 10:39 AM, Jakub Kicinski wrote: > On Tue, 15 Sep 2020 10:20:11 -0700 Shannon Nelson wrote: > What should the userland program do when the timeout expires?  Start > counting backwards?  Stop waiting?  Do we care to define this at the > moment? [component] bla bla

[PATCH v3 13/14] habanalabs/gaudi: support DCB protocol

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Add DCB support to configure the NIC's Priority Flow Control (PFC). The added support is minimal because a full support is not currently required. A summary of the supported callbacks: - ieee_getpfc: get the current PFC configuration. PFC is enabled by defau

[PATCH v3 12/14] habanalabs/gaudi: Add ethtool support using coresight

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman The driver supports ethtool callbacks and provides statistics using the device's profiling infrastructure (coresight). We support the basic ethtool functionality and counters, as far as our H/W provides support. A summary of the supported callbacks: - get_drvinfo: fill so

[PATCH v3 11/14] habanalabs/gaudi: add QP error handling

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Add Queue Pair (QP) error notification to the user e.g. security violation, too many retransmissions, invalid QP etc. Whenever a QP caused an error, the firmware will send an event to the driver which will push the error as an error entry to the Completion Queue (if exists)

Re: [PATCH bpf-next] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-15 Thread Yonghong Song
On 9/15/20 10:40 AM, Jakub Kicinski wrote: On Tue, 15 Sep 2020 10:35:50 -0700 Yonghong Song wrote: On 9/15/20 8:33 AM, Jakub Kicinski wrote: On Mon, 14 Sep 2020 11:46:30 -0700 Yonghong Song wrote: Currently, we use bucket_lock when traversing bpf_sk_storage_map elements. Since bpf_iter prog

Re: [PATCH bpf] bpf: bpf_skc_to_* casting helpers require a NULL check on sk

2020-09-15 Thread Yonghong Song
On 9/15/20 11:29 AM, Martin KaFai Lau wrote: The bpf_skc_to_* type casting helpers are available to BPF_PROG_TYPE_TRACING. The traced PTR_TO_BTF_ID may be NULL. For example, the skb->sk may be NULL. Thus, these casting helpers need to check "!sk" also and this patch fixes them. Fixes: 0d4fa

[PATCH v3 14/14] habanalabs/gaudi: add NIC init/fini calls from common code

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Finally, enable the NIC engines. Initialize the NIC ports mask variable with full mask so all ports will be initialized. Call the NIC init/fini from the common code. Signed-off-by: Omer Shpigelman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/hab

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Jesse Brandeburg
Saeed Mahameed wrote: > Reviewed-by: Saeed Mahameed Thanks! In all fairness, Jakub reviewed this in v1 too but I made enough changes in v2 that I felt I had to drop the previous review ACKs. > Hi Jesse, > What was the criteria to select which drivers to enable in your .config > ? As Jakub said

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 11:44:07 -0700 Jacob Keller wrote: > Exactly how I saw it. > > Basically, the timeout should take effect as long as the (component, > msg) pair stays the same. > > So if you send percentage reports with the same message and component, > then the timeout stays in effect. Once y

Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-15 Thread Paul E. McKenney
On Mon, Sep 14, 2020 at 05:30:29PM -0700, Jakub Kicinski wrote: > On Mon, 14 Sep 2020 17:20:11 -0700 Paul E. McKenney wrote: > > > Seems like quite a few places depend on the macro disappearing its > > > argument. I was concerned that it's going to be had to pick out whether > > > !LOCKDEP builds s

[PATCH v3 05/14] habanalabs/gaudi: add NIC Ethernet support

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Basic NIC driver which handles Ethernet packet of several types like IPv4, IPv6, LLDP, VLAN and ARP. The NIC HW is composed of 5 NIC macros, in each macro 2 NIC engines of 100GbE each. Each engine exposes a single port of 100GbE, so in total we have 10 ports per GAUDI devic

Re: [PATCH bpf-next] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-15 Thread Alexei Starovoitov
On Tue, Sep 15, 2020 at 11:56 AM Yonghong Song wrote: > > > > On 9/15/20 10:40 AM, Jakub Kicinski wrote: > > On Tue, 15 Sep 2020 10:35:50 -0700 Yonghong Song wrote: > >> On 9/15/20 8:33 AM, Jakub Kicinski wrote: > >>> On Mon, 14 Sep 2020 11:46:30 -0700 Yonghong Song wrote: > Currently, we use

[PATCH v3 04/14] habanalabs/gaudi: add support for NIC QMANs

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Initialize the QMANs that are responsible to submit doorbells to the NIC engines. Add support for stopping and disabling them, and reset them as part of the hard-reset procedure of GAUDI. This will allow the user to submit work to the NICs. Add support for receiving events

[PATCH v3 02/14] habanalabs/gaudi: add NIC firmware-related definitions

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Add new structures and messages that the driver use to interact with the firmware to receive information and events (errors) about GAUDI's NIC. Signed-off-by: Omer Shpigelman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- .../misc/habanalabs/include/common/cpuc

[PATCH v3 08/14] habanalabs/gaudi: add a new IOCTL for NIC control operations

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Add Queue Pair (QP) opcodes to the NIC ioctl. A QP represents a connection between two Gaudi ports. Each port currently supports 1024 QPs where QP 0 is reserved for the driver for Ethernet. User-space process needs to create a QP in order to communicate with other Gaudis.

[PATCH v3 10/14] habanalabs/gaudi: add WQ control operations

2020-09-15 Thread Oded Gabbay
From: Omer Shpigelman Add Work Queue (WQ) opcodes to NIC ioctl. A WQ contains entries (WQEs) where each WQE represents a packet that should be sent or received. Each WQ has two types: requester (sender) and responder (receiver). The added opcodes are: - Set WQ: set the WQ configuration in the H

  1   2   3   4   >